git.delta.rocks / unique-network / refs/commits / 3bd9a5e8383e

difftreelog

test(nesting) extended test suite

Fahrrader2022-04-08parent: #6f234a4.patch.diff
in: master

4 files changed

modifiedtests/package.jsondiffbeforeafterboth
--- a/tests/package.json
+++ b/tests/package.json
@@ -33,6 +33,7 @@
     "loadTransfer": "ts-node src/transfer.nload.ts",
     "testCollision": "mocha --timeout 9999999 -r ts-node/register ./src/collision-tests/*.test.ts",
     "testEvent": "mocha --timeout 9999999 -r ts-node/register ./src/check-event/*.test.ts",
+    "testNesting": "mocha --timeout 9999999 -r ts-node/register ./**/nesting/**.test.ts",
     "testAddCollectionAdmin": "mocha --timeout 9999999 -r ts-node/register ./**/addCollectionAdmin.test.ts",
     "testSetSchemaVersion": "mocha --timeout 9999999 -r ts-node/register ./**/setSchemaVersion.test.ts",
     "testSetVariableMetaData": "mocha --timeout 9999999 -r ts-node/register ./**/setVariableMetaData.test.ts",
modifiedtests/src/nesting/nest.test.tsdiffbeforeafterboth
--- a/tests/src/nesting/nest.test.ts
+++ b/tests/src/nesting/nest.test.ts
@@ -1,37 +1,510 @@
 import {expect} from 'chai';
 import {tokenIdToAddress} from '../eth/util/helpers';
 import privateKey from '../substrate/privateKey';
-import usingApi from '../substrate/substrate-api';
-import {createCollectionExpectSuccess, createItemExpectSuccess, getTokenOwner, getTopmostTokenOwner, setCollectionLimitsExpectSuccess, transferExpectSuccess, transferFromExpectSuccess} from '../util/helpers';
+import usingApi, {executeTransaction} from '../substrate/substrate-api';
+import {
+  addToAllowListExpectSuccess,
+  createCollectionExpectSuccess,
+  createItemExpectFailure, 
+  createItemExpectSuccess,
+  enableAllowListExpectSuccess,
+  enablePublicMintingExpectSuccess,
+  getTokenOwner, 
+  getTopmostTokenOwner, 
+  setCollectionLimitsExpectSuccess, 
+  transferExpectFailure, 
+  transferExpectSuccess, 
+  transferFromExpectSuccess,
+} from '../util/helpers';
+import {IKeyringPair} from '@polkadot/types/types';
+
+let alice: IKeyringPair;
+let bob: IKeyringPair;
+
+describe('Integration Test: Nesting', () => {
+  before(async () => {
+    alice = privateKey('//Alice');
+    bob = privateKey('//Bob');
+  });
+
+  // ---------- Non-Fungible ----------
 
-describe('nesting', () => {
-  it('allows to nest/unnest token', async () => {
+  // todo refactor names
+  // todo remove excessive bundling, leave it for a single test
+  it('NFT: allows to nest/unnest token if nesting rule is Owner', async () => {
     await usingApi(async api => {
-      const alice = privateKey('//Alice');
-      const bob = privateKey('//Bob');
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: 'Owner'});
+      const targetToken = await createItemExpectSuccess(alice, collection, 'NFT');
+
+      // Create a nested token
+      const nestedToken = await createItemExpectSuccess(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, targetToken)});
+      expect(await getTopmostTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Substrate: alice.address});
+      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
+
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      
+      // Nest
+      await transferExpectSuccess(collection, newToken, alice, {Ethereum: tokenIdToAddress(collection, targetToken)});
+      expect(await getTopmostTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Substrate: alice.address});
+      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
+
+      // Move bundle to different user
+      await transferExpectSuccess(collection, targetToken, alice, {Substrate: bob.address});
+      expect(await getTopmostTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Substrate: bob.address});
+      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
+
+      // Unnest
+      await transferFromExpectSuccess(collection, newToken, bob, {Ethereum: tokenIdToAddress(collection, targetToken)}, {Substrate: bob.address});
+      expect(await getTokenOwner(api, collection, newToken)).to.be.deep.equal({Substrate: bob.address});
+    });
+  });
 
+  it('NFT: allows to nest/unnest token if Owner-Restricted', async () => {
+    await usingApi(async api => {
       const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
-      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule:{OwnerRestricted:[collection]}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: {OwnerRestricted:[collection]}});
       const targetToken = await createItemExpectSuccess(alice, collection, 'NFT');
 
-      const nestedToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      // Create a nested token
+      const nestedToken = await createItemExpectSuccess(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, targetToken)});
+      expect(await getTopmostTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Substrate: alice.address});
+      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
 
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      
       // Nest
-      await transferExpectSuccess(collection, nestedToken, alice, {Ethereum: tokenIdToAddress(collection, targetToken)});
-  
+      await transferExpectSuccess(collection, newToken, alice, {Ethereum: tokenIdToAddress(collection, targetToken)});
       expect(await getTopmostTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Substrate: alice.address});
       expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
 
       // Move bundle to different user
       await transferExpectSuccess(collection, targetToken, alice, {Substrate: bob.address});
-  
       expect(await getTopmostTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Substrate: bob.address});
       expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
+      
+      // Unnest
+      await transferFromExpectSuccess(collection, newToken, bob, {Ethereum: tokenIdToAddress(collection, targetToken)}, {Substrate: bob.address});
+      expect(await getTokenOwner(api, collection, newToken)).to.be.deep.equal({Substrate: bob.address});
+    });
+  });
+
+  // ---------- Fungible ----------
+
+  it('Fungible: allows to nest/unnest token if Owner', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: 'Owner'});
+      const targetToken = await createItemExpectSuccess(alice, collectionNFT, 'NFT', {Substrate: alice.address});
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionFT = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});
+
+      // Create a nested token
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionFT, 
+        targetAddress, 
+        {Fungible: {Value: 10}},
+      ))).to.not.be.rejected;
+
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collectionFT, 'Fungible');
+      // Nest
+      await transferExpectSuccess(collectionFT, newToken, alice, targetAddress, 1, 'Fungible');
+      // Move bundle to different user
+      await transferExpectSuccess(collectionNFT, targetToken, alice, {Substrate: bob.address});
+      // Unnest
+      await transferFromExpectSuccess(collectionFT, newToken, bob, targetAddress, {Substrate: bob.address}, 1, 'Fungible');
+    });
+  });
+
+  it('Fungible: allows to nest/unnest token if Owner-Restricted', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      const targetToken = await createItemExpectSuccess(alice, collectionNFT, 'NFT', {Substrate: alice.address});
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionFT = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});
+
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: {OwnerRestricted:[collectionFT]}});
+
+      // Create a nested token
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionFT, 
+        targetAddress, 
+        {Fungible: {Value: 10}},
+      ))).to.not.be.rejected;
 
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collectionFT, 'Fungible');
+      // Nest
+      await transferExpectSuccess(collectionFT, newToken, alice, targetAddress, 1, 'Fungible');
+      // Move bundle to different user
+      await transferExpectSuccess(collectionNFT, targetToken, alice, {Substrate: bob.address});
       // Unnest
-      await transferFromExpectSuccess(collection, nestedToken, bob, {Ethereum: tokenIdToAddress(collection, targetToken)}, {Substrate: bob.address});
+      await transferFromExpectSuccess(collectionFT, newToken, bob, targetAddress, {Substrate: bob.address}, 1, 'Fungible');
+    });
+  });
+
+  // ---------- Re-Fungible ----------
+
+  it('ReFungible: allows to nest/unnest token if Owner', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: 'Owner'});
+      const targetToken = await createItemExpectSuccess(alice, collectionNFT, 'NFT', {Substrate: alice.address});
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionRFT = await createCollectionExpectSuccess({mode: {type: 'ReFungible'}});
 
-      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Substrate: bob.address});
+      // Create a nested token
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionRFT, 
+        targetAddress, 
+        {ReFungible: {const_data: [], variable_data: [], pieces: 100}},
+      ))).to.not.be.rejected;
+
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collectionRFT, 'ReFungible');
+      // Nest
+      await transferExpectSuccess(collectionRFT, newToken, alice, targetAddress, 100, 'ReFungible');
+      // Move bundle to different user
+      await transferExpectSuccess(collectionNFT, targetToken, alice, {Substrate: bob.address});
+      // Unnest
+      await transferFromExpectSuccess(collectionRFT, newToken, bob, targetAddress, {Substrate: bob.address}, 100, 'ReFungible');
+    });
+  });
+
+  it('ReFungible: allows to nest/unnest token if Owner-Restricted', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      const targetToken = await createItemExpectSuccess(alice, collectionNFT, 'NFT', {Substrate: alice.address});
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionRFT = await createCollectionExpectSuccess({mode: {type: 'ReFungible'}});
+
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: {OwnerRestricted:[collectionRFT]}});
+
+      // Create a nested token
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionRFT, 
+        targetAddress,
+        {ReFungible: {const_data: [], variable_data: [], pieces: 100}},
+      ))).to.not.be.rejected;
+
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collectionRFT, 'ReFungible');
+      // Nest
+      await transferExpectSuccess(collectionRFT, newToken, alice, targetAddress, 100, 'ReFungible');
+      // Move bundle to different user
+      await transferExpectSuccess(collectionNFT, targetToken, alice, {Substrate: bob.address});
+      // Unnest
+      await transferFromExpectSuccess(collectionRFT, newToken, bob, targetAddress, {Substrate: bob.address}, 100, 'ReFungible');
+    });
+  });
+});
+
+describe('Negative Test: Nesting', async() => {
+  before(async () => {
+    alice = privateKey('//Alice');
+    bob = privateKey('//Bob');
+  });
+
+  // ---------- Non-Fungible ----------
+
+  it('NFT: disallows to nest token if nesting is disabled', async () => {
+    await usingApi(async api => {
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: 'Disabled'});
+      const targetToken = await createItemExpectSuccess(alice, collection, 'NFT');
+
+      // Try to create a nested token
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collection, 
+        {Ethereum: tokenIdToAddress(collection, targetToken)}, 
+        {nft: {const_data: [], variable_data: []}} as any,
+      ))).to.be.rejectedWith(/^common\.NestingIsDisabled$/);
+
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      // Try to nest
+      await transferExpectFailure(collection, newToken, alice, {Ethereum: tokenIdToAddress(collection, targetToken)}); // todo to.be.rejected
+      expect(await getTopmostTokenOwner(api, collection, newToken)).to.be.deep.equal({Substrate: alice.address});
+      expect(await getTokenOwner(api, collection, newToken)).to.be.deep.equal({Substrate: alice.address});
+    });
+  });
+
+  it('NFT: disallows to nest token if not Owner', async () => {
+    await usingApi(async api => {
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: 'Owner'});
+
+      await addToAllowListExpectSuccess(alice, collection, bob.address);
+      await enableAllowListExpectSuccess(alice, collection);
+      await enablePublicMintingExpectSuccess(alice, collection);
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(bob, collection, 'NFT');
+
+      // Try to create a nested token in the wrong collection
+      await createItemExpectFailure(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, targetToken)});
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      await transferExpectFailure(collection, newToken, alice, {Ethereum: tokenIdToAddress(collection, targetToken)});
+      expect(await getTokenOwner(api, collection, newToken)).to.be.deep.equal({Substrate: alice.address});
+    });
+  });
+
+  it('NFT: disallows to nest token if not Owner (Restricted nesting)', async () => {
+    await usingApi(async api => {
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: {OwnerRestricted:[collection]}});
+
+      await addToAllowListExpectSuccess(alice, collection, bob.address);
+      await enableAllowListExpectSuccess(alice, collection);
+      await enablePublicMintingExpectSuccess(alice, collection);
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(bob, collection, 'NFT');
+
+      // Try to create a nested token in the wrong collection
+      await createItemExpectFailure(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, targetToken)});
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      await transferExpectFailure(collection, newToken, alice, {Ethereum: tokenIdToAddress(collection, targetToken)});
+      expect(await getTokenOwner(api, collection, newToken)).to.be.deep.equal({Substrate: alice.address});
+    });
+  });
+
+  it('NFT: disallows to nest token to an unlisted collection', async () => {
+    await usingApi(async api => {
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: {OwnerRestricted:[]}});
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(alice, collection, 'NFT');
+
+      // Try to create a nested token in the wrong collection
+      await createItemExpectFailure(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, targetToken)});
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      await transferExpectFailure(collection, newToken, alice, {Ethereum: tokenIdToAddress(collection, targetToken)});
+      expect(await getTokenOwner(api, collection, newToken)).to.be.deep.equal({Substrate: alice.address});
+    });
+  });
+
+  // ---------- Fungible ----------
+
+  it('Fungible: disallows to nest token if nesting is disabled', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: 'Disabled'});
+      const targetToken = await createItemExpectSuccess(alice, collectionNFT, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionFT = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});
+
+      // Try to create a nested token
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionFT, 
+        targetAddress, 
+        {Fungible: {Value: 10}},
+      ))).to.be.rejectedWith(/^common\.NestingIsDisabled$/);
+
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collectionFT, 'Fungible');
+      // Try to nest
+      await transferExpectFailure(collectionFT, newToken, alice, targetAddress, 1);
+    });
+  });
+
+  it('Fungible: disallows to nest token if not Owner', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: 'Owner'});
+
+      await addToAllowListExpectSuccess(alice, collectionNFT, bob.address);
+      await enableAllowListExpectSuccess(alice, collectionNFT);
+      await enablePublicMintingExpectSuccess(alice, collectionNFT);
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(bob, collectionNFT, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionFT = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});
+
+      // Try to create a nested token in the wrong collection
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionFT, 
+        targetAddress, 
+        {Fungible: {Value: 10}},
+      ))).to.be.rejected;
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collectionFT, 'Fungible');
+      await transferExpectFailure(collectionFT, newToken, alice, targetAddress, 1);
+    });
+  });
+
+  it('Fungible: disallows to nest token if not Owner (Restricted nesting)', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: {OwnerRestricted:[collectionNFT]}}); // todo clear redundant restrictions
+
+      await addToAllowListExpectSuccess(alice, collectionNFT, bob.address);
+      await enableAllowListExpectSuccess(alice, collectionNFT);
+      await enablePublicMintingExpectSuccess(alice, collectionNFT);
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(bob, collectionNFT, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionFT = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});
+
+      // Try to create a nested token in the wrong collection
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionFT, 
+        targetAddress, 
+        {Fungible: {Value: 10}},
+      ))).to.be.rejected;
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collectionFT, 'Fungible');
+      await transferExpectFailure(collectionFT, newToken, alice, targetAddress, 1);
+    });
+  });
+
+  it('Fungible: disallows to nest token to an unlisted collection', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: {OwnerRestricted:[]}});
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(alice, collectionNFT, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionFT = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});
+
+      // Try to create a nested token in the wrong collection
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionFT, 
+        targetAddress, 
+        {Fungible: {Value: 10}},
+      ))).to.be.rejected;
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collectionFT, 'Fungible');
+      await transferExpectFailure(collectionFT, newToken, alice, targetAddress, 1);
+    });
+  });
+
+  // ---------- Re-Fungible ----------
+
+  it('ReFungible: disallows to nest token if nesting is disabled', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: 'Disabled'});
+      const targetToken = await createItemExpectSuccess(alice, collectionNFT, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionRFT = await createCollectionExpectSuccess({mode: {type: 'ReFungible'}});
+
+      // Create a nested token
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionRFT, 
+        targetAddress, 
+        {ReFungible: {const_data: [], variable_data: [], pieces: 100}},
+      ))).to.be.rejectedWith(/^common\.NestingIsDisabled$/);
+
+      // Create a token to be nested
+      const newToken = await createItemExpectSuccess(alice, collectionRFT, 'ReFungible');
+      // Try to nest
+      await transferExpectFailure(collectionRFT, newToken, alice, targetAddress, 100);
+    });
+  });
+
+  it('ReFungible: disallows to nest token if not Owner', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: 'Owner'});
+
+      await addToAllowListExpectSuccess(alice, collectionNFT, bob.address);
+      await enableAllowListExpectSuccess(alice, collectionNFT);
+      await enablePublicMintingExpectSuccess(alice, collectionNFT);
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(bob, collectionNFT, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionRFT = await createCollectionExpectSuccess({mode: {type: 'ReFungible'}});
+
+      // Try to create a nested token in the wrong collection
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionRFT, 
+        targetAddress, 
+        {ReFungible: {const_data: [], variable_data: [], pieces: 100}},
+      ))).to.be.rejected;
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collectionRFT, 'ReFungible');
+      await transferExpectFailure(collectionRFT, newToken, alice, targetAddress, 100);
+    });
+  });
+
+  it('ReFungible: disallows to nest token if not Owner (Restricted nesting)', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: {OwnerRestricted:[collectionNFT]}});
+
+      await addToAllowListExpectSuccess(alice, collectionNFT, bob.address);
+      await enableAllowListExpectSuccess(alice, collectionNFT);
+      await enablePublicMintingExpectSuccess(alice, collectionNFT);
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(bob, collectionNFT, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionRFT = await createCollectionExpectSuccess({mode: {type: 'ReFungible'}});
+
+      // Try to create a nested token in the wrong collection
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionRFT, 
+        targetAddress, 
+        {ReFungible: {const_data: [], variable_data: [], pieces: 100}},
+      ))).to.be.rejected;
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collectionRFT, 'ReFungible');
+      await transferExpectFailure(collectionRFT, newToken, alice, targetAddress, 100);
+    });
+  });
+
+  it('ReFungible: disallows to nest token to an unlisted collection', async () => {
+    await usingApi(async api => {
+      const collectionNFT = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collectionNFT, {nestingRule: {OwnerRestricted:[]}});
+
+      // Create a token to attempt to be nested into
+      const targetToken = await createItemExpectSuccess(alice, collectionNFT, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collectionNFT, targetToken)};
+
+      const collectionRFT = await createCollectionExpectSuccess({mode: {type: 'ReFungible'}});
+
+      // Try to create a nested token in the wrong collection
+      await expect(executeTransaction(api, alice, api.tx.unique.createItem(
+        collectionRFT, 
+        targetAddress, 
+        {ReFungible: {const_data: [], variable_data: [], pieces: 100}},
+      ))).to.be.rejected;
+
+      // Try to create and nest a token in the wrong collection
+      const newToken = await createItemExpectSuccess(alice, collectionRFT, 'ReFungible');
+      await transferExpectFailure(collectionRFT, newToken, alice, targetAddress, 100);
     });
   });
 });
addedtests/src/nesting/unnest.test.tsdiffbeforeafterboth
--- /dev/null
+++ b/tests/src/nesting/unnest.test.ts
@@ -0,0 +1,130 @@
+import {expect} from 'chai';
+import {tokenIdToAddress} from '../eth/util/helpers';
+import privateKey from '../substrate/privateKey';
+import usingApi, {executeTransaction} from '../substrate/substrate-api';
+import {
+  createCollectionExpectSuccess,
+  createItemExpectFailure, 
+  createItemExpectSuccess,
+  getTokenOwner, 
+  getTopmostTokenOwner, 
+  normalizeAccountId, 
+  setCollectionLimitsExpectSuccess, 
+  transferExpectFailure, 
+  transferExpectSuccess, 
+} from '../util/helpers';
+import {IKeyringPair} from '@polkadot/types/types';
+
+let alice: IKeyringPair;
+let bob: IKeyringPair;
+
+describe('Integration Test: Unnesting', () => {
+  before(async () => {
+    alice = privateKey('//Alice');
+    bob = privateKey('//Bob');
+  });
+
+  it('Allows the owner to successfully unnest a token', async () => {
+    await usingApi(async api => {
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: 'Owner'});
+      const targetToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collection, targetToken)};
+
+      // Create a nested token
+      const nestedToken = await createItemExpectSuccess(alice, collection, 'NFT', targetAddress);
+
+      // Unnest
+      await expect(executeTransaction(
+        api, 
+        alice, 
+        api.tx.unique.transferFrom(normalizeAccountId(targetAddress), normalizeAccountId(alice), collection, nestedToken, 1),
+      )).to.not.be.rejected;
+      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Substrate: alice.address});
+
+      // Nest and burn
+      await transferExpectSuccess(collection, nestedToken, alice, targetAddress);
+      await expect(executeTransaction(
+        api, 
+        alice, 
+        api.tx.unique.burnFrom(collection, normalizeAccountId(alice.address), nestedToken, 1),
+      )).to.not.be.rejected;
+      await expect(getTokenOwner(api, collection, nestedToken)).to.be.rejected; // 'owner == null'
+    });
+  });
+
+  // todo refungible-fungible test just in case
+});
+
+describe('Negative Test: Unnesting', () => {
+  before(async () => {
+    alice = privateKey('//Alice');
+    bob = privateKey('//Bob');
+  });
+  
+  it('Disallows a non-owner to unnest/burn a token', async () => {
+    await usingApi(async api => {
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: 'Owner'});
+      const targetToken = await createItemExpectSuccess(alice, collection, 'NFT');
+      const targetAddress = {Ethereum: tokenIdToAddress(collection, targetToken)};
+
+      // Create a nested token
+      const nestedToken = await createItemExpectSuccess(alice, collection, 'NFT', targetAddress);
+
+      // Try to unnest
+      await expect(executeTransaction(
+        api, 
+        bob, 
+        api.tx.unique.transferFrom(normalizeAccountId(targetAddress), normalizeAccountId(bob), collection, nestedToken, 1),
+      )).to.be.rejectedWith(/^common\.ApprovedValueTooLow$/);
+      //await transferFromExpectSuccess(collection, nestedToken, bob, targetAddress, {Substrate: bob.address});
+      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
+
+      // Try to burn
+      await expect(executeTransaction(
+        api, 
+        bob, 
+        api.tx.unique.burnFrom(collection, normalizeAccountId(bob.address), nestedToken, 1),
+      )).to.not.be.rejectedWith(/^common\.ApprovedValueTooLow$/);
+      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
+    });
+  });
+  
+  it('Disallows excessive token nesting', async () => {
+    await usingApi(async api => {
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: 'Owner'});
+      const targetToken = await createItemExpectSuccess(alice, collection, 'NFT');
+
+      // Create a nested token matryoshka
+      const nestedToken1 = await createItemExpectSuccess(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, targetToken)});
+      const nestedToken2 = await createItemExpectSuccess(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, nestedToken1)});
+      // The nesting depth is limited by 2
+      await createItemExpectFailure(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, nestedToken2)});
+
+      expect(await getTopmostTokenOwner(api, collection, nestedToken2)).to.be.deep.equal({Substrate: alice.address});
+    });
+  });
+
+  // todo another test for creating excessive depth matryoshka with Ethereum, move this one to nest ^
+  
+  // Recursive nesting
+  it('Prevents Ouroboros-nested operations', async () => { 
+    await usingApi(async api => {
+      const collection = await createCollectionExpectSuccess({mode: {type: 'NFT'}});
+      await setCollectionLimitsExpectSuccess(alice, collection, {nestingRule: 'Owner'});
+      const targetToken = await createItemExpectSuccess(alice, collection, 'NFT');
+
+      // Create a nested token ouroboros
+      const nestedToken = await createItemExpectSuccess(alice, collection, 'NFT', {Ethereum: tokenIdToAddress(collection, targetToken)});
+      await transferExpectSuccess(collection, targetToken, alice, {Ethereum: tokenIdToAddress(collection, nestedToken)});
+
+      expect(await getTokenOwner(api, collection, nestedToken)).to.be.deep.equal({Ethereum: tokenIdToAddress(collection, targetToken).toLowerCase()});
+
+      // Make sure the ouroboros is detected
+      await expect(getTopmostTokenOwner(api, collection, nestedToken)).to.be.rejected; // With(/^common\.DepthLimit$/);
+      // todo transferFrom, must exit with Ouroboros error
+    });
+  });
+});
\ No newline at end of file
modifiedtests/src/util/helpers.tsdiffbeforeafterboth
943  collectionId: number,943  collectionId: number,
944  tokenId: number,944  tokenId: number,
945  sender: IKeyringPair,945  sender: IKeyringPair,
946  recipient: IKeyringPair,946  recipient: IKeyringPair | CrossAccountId,
947  value: number | bigint = 1,947  value: number | bigint = 1,
948) {948) {
949  await usingApi(async (api: ApiPromise) => {949  await usingApi(async (api: ApiPromise) => {
950    const transferTx = api.tx.unique.transfer(normalizeAccountId(recipient.address), collectionId, tokenId, value);950    const transferTx = api.tx.unique.transfer(normalizeAccountId(recipient), collectionId, tokenId, value);
951    const events = await expect(submitTransactionExpectFailAsync(sender, transferTx)).to.be.rejected;951    const events = await expect(submitTransactionExpectFailAsync(sender, transferTx)).to.be.rejected;
952    const result = getGenericResult(events);952    const result = getGenericResult(events);
953    // if (events && Array.isArray(events)) {953    // if (events && Array.isArray(events)) {
1090  return newItemId;1090  return newItemId;
1091}1091}
10921092
1093export async function createItemExpectFailure(sender: IKeyringPair, collectionId: number, createMode: string, owner: string = sender.address) {1093export async function createItemExpectFailure(sender: IKeyringPair, collectionId: number, createMode: string, owner: CrossAccountId | string = sender.address) {
1094  await usingApi(async (api) => {1094  await usingApi(async (api) => {
1095    const tx = api.tx.unique.createItem(collectionId, normalizeAccountId(owner), createMode);1095    const tx = api.tx.unique.createItem(collectionId, normalizeAccountId(owner), createMode);
10961096