difftreelog
Support sponsoring from frontier
in: master
9 files changed
.gitignorediffbeforeafterboth--- a/.gitignore
+++ b/.gitignore
@@ -11,6 +11,7 @@
*store_key*.json
/.idea/
+/.cargo/
tests/.vscode
cumulus-parachain/
Cargo.lockdiffbeforeafterboth--- a/Cargo.lock
+++ b/Cargo.lock
@@ -6146,6 +6146,7 @@
"sp-core",
"sp-runtime",
"sp-std",
+ "up-evm-mapping",
"up-sponsorship",
]
pallets/common/src/account.rsdiffbeforeafterboth--- a/pallets/common/src/account.rs
+++ b/pallets/common/src/account.rs
@@ -23,6 +23,7 @@
use pallet_evm::AddressMapping;
use sp_std::vec::Vec;
use sp_std::clone::Clone;
+
pub use up_evm_mapping::EvmBackwardsAddressMapping;
pub trait CrossAccountId<AccountId>:
pallets/evm-contract-helpers/Cargo.tomldiffbeforeafterboth--- a/pallets/evm-contract-helpers/Cargo.toml
+++ b/pallets/evm-contract-helpers/Cargo.toml
@@ -17,6 +17,7 @@
pallet-evm-coder-substrate = { default-features = false, path = '../../pallets/evm-coder-substrate' }
pallet-evm = { default-features = false, git = "https://github.com/uniquenetwork/frontier.git", branch = "unique-polkadot-v0.9.18" }
up-sponsorship = { version = "0.1.0", default-features = false, git = "https://github.com/UniqueNetwork/pallet-sponsoring", branch = 'polkadot-v0.9.18' }
+up-evm-mapping = { default-features = false, path = "../../primitives/evm-mapping" }
log = "0.4.14"
[dependencies.codec]
pallets/evm-contract-helpers/src/eth.rsdiffbeforeafterboth--- a/pallets/evm-contract-helpers/src/eth.rs
+++ b/pallets/evm-contract-helpers/src/eth.rs
@@ -17,14 +17,17 @@
use core::marker::PhantomData;
use evm_coder::{abi::AbiWriter, execution::Result, generate_stubgen, solidity_interface, types::*};
use pallet_evm_coder_substrate::{SubstrateRecorder, WithRecorder};
-use pallet_evm::{ExitRevert, OnCreate, OnMethodCall, PrecompileResult, PrecompileFailure};
+use pallet_evm::{
+ ExitRevert, OnCreate, OnMethodCall, PrecompileResult, PrecompileFailure, AddressMapping
+};
use sp_core::H160;
use crate::{
AllowlistEnabled, Config, Owner, Pallet, SponsorBasket, SponsoringRateLimit, SponsoringModeT,
};
use frame_support::traits::Get;
use up_sponsorship::SponsorshipHandler;
-use sp_std::{convert::TryInto, vec::Vec};
+use up_evm_mapping::EvmBackwardsAddressMapping;
+use sp_std::vec::Vec;
struct ContractHelpers<T: Config>(SubstrateRecorder<T>);
impl<T: Config> WithRecorder<T> for ContractHelpers<T> {
@@ -177,13 +180,15 @@
}
pub struct HelpersContractSponsoring<T: Config>(PhantomData<*const T>);
-impl<T: Config> SponsorshipHandler<H160, (H160, Vec<u8>)> for HelpersContractSponsoring<T> {
- fn get_sponsor(who: &H160, call: &(H160, Vec<u8>)) -> Option<H160> {
+impl<T: Config> SponsorshipHandler<T::AccountId, (H160, Vec<u8>)> for HelpersContractSponsoring<T> {
+ fn get_sponsor(who: &T::AccountId, call: &(H160, Vec<u8>)) -> Option<T::AccountId> {
let mode = <Pallet<T>>::sponsoring_mode(call.0);
if mode == SponsoringModeT::Disabled {
return None;
}
- if mode == SponsoringModeT::Allowlisted && !<Pallet<T>>::allowed(call.0, *who) {
+
+ let who = T::EvmBackwardsAddressMapping::from_account_id(who.clone());
+ if mode == SponsoringModeT::Allowlisted && !<Pallet<T>>::allowed(call.0, who) {
return None;
}
let block_number = <frame_system::Pallet<T>>::block_number() as T::BlockNumber;
@@ -199,7 +204,8 @@
<SponsorBasket<T>>::insert(&call.0, who, block_number);
- Some(call.0)
+ let sponsor = T::EvmAddressMapping::into_account_id(call.0);
+ Some(sponsor)
}
}
pallets/evm-contract-helpers/src/lib.rsdiffbeforeafterboth--- a/pallets/evm-contract-helpers/src/lib.rs
+++ b/pallets/evm-contract-helpers/src/lib.rs
@@ -33,6 +33,8 @@
pub trait Config: frame_system::Config + pallet_evm_coder_substrate::Config {
type ContractAddress: Get<H160>;
type DefaultSponsoringRateLimit: Get<Self::BlockNumber>;
+ type EvmAddressMapping: pallet_evm::AddressMapping<Self::AccountId>;
+ type EvmBackwardsAddressMapping: up_evm_mapping::EvmBackwardsAddressMapping<Self::AccountId>;
}
#[pallet::error]
pallets/evm-transaction-payment/src/lib.rsdiffbeforeafterboth--- a/pallets/evm-transaction-payment/src/lib.rs
+++ b/pallets/evm-transaction-payment/src/lib.rs
@@ -36,7 +36,7 @@
#[pallet::config]
pub trait Config: frame_system::Config {
- type EvmSponsorshipHandler: SponsorshipHandler<H160, (H160, Vec<u8>)>;
+ type EvmSponsorshipHandler: SponsorshipHandler<Self::AccountId, (H160, Vec<u8>)>;
type Currency: Currency<Self::AccountId>;
type EvmBackwardsAddressMapping: EvmBackwardsAddressMapping<Self::AccountId>;
type EvmAddressMapping: AddressMapping<Self::AccountId>;
@@ -60,14 +60,15 @@
}
pub struct TransactionValidityHack<T: Config>(PhantomData<*const T>);
-impl<T: Config> fp_evm::TransactionValidityHack for TransactionValidityHack<T> {
- fn who_pays_fee(origin: H160, reason: &WithdrawReason) -> Option<H160> {
+impl<T: Config> fp_evm::TransactionValidityHack<T::AccountId> for TransactionValidityHack<T> {
+ fn who_pays_fee(origin: H160, reason: &WithdrawReason) -> Option<T::AccountId> {
match reason {
WithdrawReason::Call { target, input } => {
// This method is only used for checking, we shouldn't touch storage in it
frame_support::storage::with_transaction(|| {
+ let origin_sub = T::EvmAddressMapping::into_account_id(origin);
TransactionOutcome::Rollback(T::EvmSponsorshipHandler::get_sponsor(
- &origin,
+ &origin_sub,
&(*target, input.clone()),
))
})
@@ -85,33 +86,36 @@
type LiquidityInfo = Option<ChargeEvmLiquidityInfo<T>>;
fn withdraw_fee(
- who: &H160,
+ who: &T::AccountId,
reason: WithdrawReason,
fee: U256,
) -> core::result::Result<Self::LiquidityInfo, pallet_evm::Error<T>> {
- let mut who_pays_fee = *who;
+ let mut who_pays_fee = who.clone();
if let WithdrawReason::Call { target, input } = &reason {
who_pays_fee = T::EvmSponsorshipHandler::get_sponsor(who, &(*target, input.clone()))
.unwrap_or(who_pays_fee);
}
+
let negative_imbalance = EVMCurrencyAdapter::<<T as Config>::Currency, ()>::withdraw_fee(
&who_pays_fee,
reason,
fee,
)?;
+
+ let who_pays_fee_eth = T::EvmBackwardsAddressMapping::from_account_id(who_pays_fee);
Ok(negative_imbalance.map(|i| ChargeEvmLiquidityInfo {
- who: who_pays_fee,
+ who: who_pays_fee_eth,
negative_imbalance: i,
}))
}
fn correct_and_deposit_fee(
- who: &H160,
+ who: &T::AccountId,
corrected_fee: U256,
already_withdrawn: Self::LiquidityInfo,
) {
<EVMCurrencyAdapter<<T as Config>::Currency, ()> as pallet_evm::OnChargeEVMTransaction<T>>::correct_and_deposit_fee(
- &already_withdrawn.as_ref().map(|e| e.who).unwrap_or(*who),
+ &already_withdrawn.as_ref().map(|e| T::EvmAddressMapping::into_account_id(e.who)).unwrap_or(who.clone()),
corrected_fee,
already_withdrawn.map(|e| e.negative_imbalance),
)
@@ -142,7 +146,6 @@
<frame_system::RawOrigin<T::AccountId>>::Signed(who.clone()).into(),
)
.ok()?;
- let who = T::EvmBackwardsAddressMapping::from_account_id(who.clone());
// Effects from EvmSponsorshipHandler are applied in OnChargeEvmTransaction by pallet_evm::runner
// TODO: Should we implement simulation mode (test, but do not apply effects) in `up-sponsorship`?
let sponsor = frame_support::storage::with_transaction(|| {
@@ -151,7 +154,6 @@
&(*target, input.clone()),
))
})?;
- let sponsor = T::EvmAddressMapping::into_account_id(sponsor);
Some(sponsor)
}
_ => None,
pallets/unique/src/eth/sponsoring.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! Implements EVM sponsoring logic via OnChargeEVMTransaction1819use crate::{Config, sponsorship::*};20use evm_coder::{Call, abi::AbiReader};21use pallet_common::{CollectionHandle, eth::map_eth_to_id};22use sp_core::H160;23use sp_std::prelude::*;24use up_sponsorship::SponsorshipHandler;25use core::marker::PhantomData;26use core::convert::TryInto;27use up_data_structs::TokenId;28use up_evm_mapping::EvmBackwardsAddressMapping;29use pallet_common::account::CrossAccountId;3031use pallet_nonfungible::erc::{UniqueNFTCall, ERC721UniqueExtensionsCall, ERC721Call};32use pallet_fungible::erc::{UniqueFungibleCall, ERC20Call};3334pub struct UniqueEthSponsorshipHandler<T: Config>(PhantomData<*const T>);35impl<T: Config> SponsorshipHandler<H160, (H160, Vec<u8>)> for UniqueEthSponsorshipHandler<T> {36 fn get_sponsor(who: &H160, call: &(H160, Vec<u8>)) -> Option<H160> {37 let collection_id = map_eth_to_id(&call.0)?;38 let collection = <CollectionHandle<T>>::new(collection_id)?;39 let sponsor = collection.sponsorship.sponsor()?.clone();40 let sponsor =41 <T as pallet_common::Config>::EvmBackwardsAddressMapping::from_account_id(sponsor);42 let who = T::CrossAccountId::from_eth(*who);43 let (method_id, mut reader) = AbiReader::new_call(&call.1).ok()?;44 match &collection.mode {45 crate::CollectionMode::NFT => {46 let call = <UniqueNFTCall<T>>::parse(method_id, &mut reader).ok()??;47 match call {48 UniqueNFTCall::ERC721UniqueExtensions(49 ERC721UniqueExtensionsCall::Transfer { token_id, .. },50 ) => {51 let token_id: TokenId = token_id.try_into().ok()?;52 withdraw_transfer::<T>(&collection, &who, &token_id).map(|()| sponsor)53 }54 UniqueNFTCall::ERC721(ERC721Call::TransferFrom { token_id, from, .. }) => {55 let token_id: TokenId = token_id.try_into().ok()?;56 let from = T::CrossAccountId::from_eth(from);57 withdraw_transfer::<T>(&collection, &from, &token_id).map(|()| sponsor)58 }59 UniqueNFTCall::ERC721(ERC721Call::Approve { token_id, .. }) => {60 let token_id: TokenId = token_id.try_into().ok()?;61 withdraw_approve::<T>(&collection, who.as_sub(), &token_id)62 .map(|()| sponsor)63 }64 _ => None,65 }66 }67 crate::CollectionMode::Fungible(_) => {68 let call = <UniqueFungibleCall<T>>::parse(method_id, &mut reader).ok()??;69 #[allow(clippy::single_match)]70 match call {71 UniqueFungibleCall::ERC20(ERC20Call::Transfer { .. }) => {72 withdraw_transfer::<T>(&collection, &who, &TokenId::default())73 .map(|()| sponsor)74 }75 UniqueFungibleCall::ERC20(ERC20Call::TransferFrom { from, .. }) => {76 let from = T::CrossAccountId::from_eth(from);77 withdraw_transfer::<T>(&collection, &from, &TokenId::default())78 .map(|()| sponsor)79 }80 UniqueFungibleCall::ERC20(ERC20Call::Approve { .. }) => {81 withdraw_approve::<T>(&collection, who.as_sub(), &TokenId::default())82 .map(|()| sponsor)83 }84 _ => None,85 }86 }87 _ => None,88 }89 }90}1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617//! Implements EVM sponsoring logic via OnChargeEVMTransaction1819use crate::{Config, sponsorship::*};20use evm_coder::{Call, abi::AbiReader};21use pallet_common::{CollectionHandle, eth::map_eth_to_id};22use sp_core::H160;23use sp_std::prelude::*;24use up_sponsorship::SponsorshipHandler;25use core::marker::PhantomData;26use core::convert::TryInto;27use up_data_structs::TokenId;28use up_evm_mapping::EvmBackwardsAddressMapping;29use pallet_common::account::CrossAccountId;3031use pallet_nonfungible::erc::{UniqueNFTCall, ERC721UniqueExtensionsCall, ERC721Call};32use pallet_fungible::erc::{UniqueFungibleCall, ERC20Call};3334pub struct UniqueEthSponsorshipHandler<T: Config>(PhantomData<*const T>);35impl<T: Config> SponsorshipHandler<T::AccountId, (H160, Vec<u8>)> for UniqueEthSponsorshipHandler<T> {36 fn get_sponsor(who: &T::AccountId, call: &(H160, Vec<u8>)) -> Option<T::AccountId> {37 let collection_id = map_eth_to_id(&call.0)?;38 let collection = <CollectionHandle<T>>::new(collection_id)?;39 let sponsor = collection.sponsorship.sponsor()?.clone();40 let who = T::CrossAccountId::from_sub(who.clone());41 let (method_id, mut reader) = AbiReader::new_call(&call.1).ok()?;42 match &collection.mode {43 crate::CollectionMode::NFT => {44 let call = <UniqueNFTCall<T>>::parse(method_id, &mut reader).ok()??;45 match call {46 UniqueNFTCall::ERC721UniqueExtensions(47 ERC721UniqueExtensionsCall::Transfer { token_id, .. },48 ) => {49 let token_id: TokenId = token_id.try_into().ok()?;50 withdraw_transfer::<T>(&collection, &who, &token_id).map(|()| sponsor)51 }52 UniqueNFTCall::ERC721(ERC721Call::TransferFrom { token_id, from, .. }) => {53 let token_id: TokenId = token_id.try_into().ok()?;54 let from = T::CrossAccountId::from_eth(from);55 withdraw_transfer::<T>(&collection, &from, &token_id).map(|()| sponsor)56 }57 UniqueNFTCall::ERC721(ERC721Call::Approve { token_id, .. }) => {58 let token_id: TokenId = token_id.try_into().ok()?;59 withdraw_approve::<T>(&collection, who.as_sub(), &token_id)60 .map(|()| sponsor)61 }62 _ => None,63 }64 }65 crate::CollectionMode::Fungible(_) => {66 let call = <UniqueFungibleCall<T>>::parse(method_id, &mut reader).ok()??;67 #[allow(clippy::single_match)]68 match call {69 UniqueFungibleCall::ERC20(ERC20Call::Transfer { .. }) => {70 withdraw_transfer::<T>(&collection, &who, &TokenId::default())71 .map(|()| sponsor)72 }73 UniqueFungibleCall::ERC20(ERC20Call::TransferFrom { from, .. }) => {74 let from = T::CrossAccountId::from_eth(from);75 withdraw_transfer::<T>(&collection, &from, &TokenId::default())76 .map(|()| sponsor)77 }78 UniqueFungibleCall::ERC20(ERC20Call::Approve { .. }) => {79 withdraw_approve::<T>(&collection, who.as_sub(), &TokenId::default())80 .map(|()| sponsor)81 }82 _ => None,83 }84 }85 _ => None,86 }87 }88}runtime/opal/src/lib.rsdiffbeforeafterboth--- a/runtime/opal/src/lib.rs
+++ b/runtime/opal/src/lib.rs
@@ -933,6 +933,8 @@
impl pallet_evm_contract_helpers::Config for Runtime {
type ContractAddress = HelpersContractAddress;
type DefaultSponsoringRateLimit = DefaultSponsoringRateLimit;
+ type EvmAddressMapping = pallet_evm::HashedAddressMapping<Self::Hashing>;
+ type EvmBackwardsAddressMapping = up_evm_mapping::MapBackwardsAddressTruncated;
}
construct_runtime!(