git.delta.rocks / unique-network / refs/commits / 37e76bc01ac1

difftreelog

fix make runtime build on 0.9.42

Yaroslav Bolyukin2023-05-22parent: #6f7886b.patch.diff
in: master

11 files changed

modifiedCargo.lockdiffbeforeafterboth
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -13701,6 +13701,7 @@
 dependencies = [
  "app-promotion-rpc",
  "fc-db",
+ "fc-mapping-sync",
  "fc-rpc",
  "fc-rpc-core",
  "fp-rpc",
modifiedruntime/common/config/ethereum.rsdiffbeforeafterboth
after · runtime/common/config/ethereum.rs
1use sp_core::{U256, H160};2use frame_support::{3	weights::{Weight, constants::WEIGHT_REF_TIME_PER_SECOND},4	traits::{FindAuthor},5	parameter_types, ConsensusEngineId,6};7use sp_runtime::{RuntimeAppPublic, Perbill, traits::ConstU32};8use crate::{9	runtime_common::{10		config::sponsoring::DefaultSponsoringRateLimit,11		DealWithFees,12		dispatch::CollectionDispatchT,13		ethereum::{precompiles::UniquePrecompiles, sponsoring::EvmSponsorshipHandler},14	},15	Runtime, Aura, Balances, RuntimeEvent, ChainId,16};17use pallet_evm::{EnsureAddressTruncated, HashedAddressMapping};18use pallet_ethereum::PostLogContent;19use up_common::constants::*;2021pub type CrossAccountId = pallet_evm::account::BasicCrossAccountId<Runtime>;2223// ~~Assuming slowest ethereum opcode is SSTORE, with gas price of 20000 as our worst case~~24// ~~(contract, which only writes a lot of data),~~25// ~~approximating on top of our real store write weight~~26//27// The above approach is very wrong, and the reason is described there:28// https://forum.polkadot.network/t/frontier-support-for-evm-weight-v2/2470/5#problem-229parameter_types! {30	pub const ReadsPerSecond: u64 = WEIGHT_REF_TIME_PER_SECOND / <Runtime as frame_system::Config>::DbWeight::get().read;31	pub const GasPerSecond: u64 = ReadsPerSecond::get() * 2100;32	pub const WeightTimePerGas: u64 = WEIGHT_REF_TIME_PER_SECOND / GasPerSecond::get();3334	pub const WeightPerGas: Weight = Weight::from_parts(WeightTimePerGas::get(), 0);35}3637/// Limiting EVM execution to 50% of block for substrate users and management tasks38/// EVM transaction consumes more weight than substrate's, so we can't rely on them being39/// scheduled fairly40const EVM_DISPATCH_RATIO: Perbill = Perbill::from_percent(50);41parameter_types! {42	pub BlockGasLimit: U256 = U256::from((NORMAL_DISPATCH_RATIO * EVM_DISPATCH_RATIO * MAXIMUM_BLOCK_WEIGHT / WeightTimePerGas::get()).ref_time());43	pub PrecompilesValue: UniquePrecompiles<Runtime> = UniquePrecompiles::<_>::new();44}4546pub struct EthereumFindAuthor<F>(core::marker::PhantomData<F>);47impl<F: FindAuthor<u32>> FindAuthor<H160> for EthereumFindAuthor<F> {48	fn find_author<'a, I>(digests: I) -> Option<H160>49	where50		I: 'a + IntoIterator<Item = (ConsensusEngineId, &'a [u8])>,51	{52		if let Some(author_index) = F::find_author(digests) {53			let authority_id = Aura::authorities()[author_index as usize].clone();54			return Some(H160::from_slice(&authority_id.to_raw_vec()[4..24]));55		}56		None57	}58}5960impl pallet_evm::Config for Runtime {61	type CrossAccountId = CrossAccountId;62	type AddressMapping = HashedAddressMapping<Self::Hashing>;63	type BackwardsAddressMapping = HashedAddressMapping<Self::Hashing>;64	type BlockGasLimit = BlockGasLimit;65	type FeeCalculator = pallet_configuration::FeeCalculator<Self>;66	type GasWeightMapping = pallet_evm::FixedGasWeightMapping<Self>;67	type WeightPerGas = WeightPerGas;68	type BlockHashMapping = pallet_ethereum::EthereumBlockHashMapping<Self>;69	type CallOrigin = EnsureAddressTruncated<Self>;70	type WithdrawOrigin = EnsureAddressTruncated<Self>;71	type PrecompilesType = UniquePrecompiles<Self>;72	type PrecompilesValue = PrecompilesValue;73	type Currency = Balances;74	type RuntimeEvent = RuntimeEvent;75	type OnMethodCall = (76		pallet_evm_migration::OnMethodCall<Self>,77		pallet_evm_contract_helpers::HelpersOnMethodCall<Self>,78		CollectionDispatchT<Self>,79		pallet_unique::eth::CollectionHelpersOnMethodCall<Self>,80	);81	type OnCreate = pallet_evm_contract_helpers::HelpersOnCreate<Self>;82	type ChainId = ChainId;83	type Runner = pallet_evm::runner::stack::Runner<Self>;84	type OnChargeTransaction = pallet_evm::EVMCurrencyAdapter<Balances, DealWithFees>;85	type TransactionValidityHack = pallet_evm_transaction_payment::TransactionValidityHack<Self>;86	type FindAuthor = EthereumFindAuthor<Aura>;87	type Timestamp = crate::Timestamp;88	type WeightInfo = pallet_evm::weights::SubstrateWeight<Self>;89}9091impl pallet_evm_migration::Config for Runtime {92	type RuntimeEvent = RuntimeEvent;93	type WeightInfo = pallet_evm_migration::weights::SubstrateWeight<Self>;94}9596parameter_types! {97	pub const PostBlockAndTxnHashes: PostLogContent = PostLogContent::BlockAndTxnHashes;98}99100impl pallet_ethereum::Config for Runtime {101	type RuntimeEvent = RuntimeEvent;102	type StateRoot = pallet_ethereum::IntermediateStateRoot<Self>;103	type PostLogContent = PostBlockAndTxnHashes;104	// Space for revert reason. Ethereum transactions are not cheap, and overall size is much less105	// than the substrate tx size, so we can afford this106	type ExtraDataLength = ConstU32<32>;107}108109parameter_types! {110	// 0x842899ECF380553E8a4de75bF534cdf6fBF64049111	pub const HelpersContractAddress: H160 = H160([112		0x84, 0x28, 0x99, 0xec, 0xf3, 0x80, 0x55, 0x3e, 0x8a, 0x4d, 0xe7, 0x5b, 0xf5, 0x34, 0xcd, 0xf6, 0xfb, 0xf6, 0x40, 0x49,113	]);114115	// 0x6c4e9fe1ae37a41e93cee429e8e1881abdcbb54f116	pub const EvmCollectionHelpersAddress: H160 = H160([117		0x6c, 0x4e, 0x9f, 0xe1, 0xae, 0x37, 0xa4, 0x1e, 0x93, 0xce, 0xe4, 0x29, 0xe8, 0xe1, 0x88, 0x1a, 0xbd, 0xcb, 0xb5, 0x4f,118	]);119}120121impl pallet_evm_contract_helpers::Config for Runtime {122	type RuntimeEvent = RuntimeEvent;123	type ContractAddress = HelpersContractAddress;124	type DefaultSponsoringRateLimit = DefaultSponsoringRateLimit;125}126127impl pallet_evm_coder_substrate::Config for Runtime {}128129impl pallet_evm_transaction_payment::Config for Runtime {130	type EvmSponsorshipHandler = EvmSponsorshipHandler;131}
modifiedruntime/common/config/substrate.rsdiffbeforeafterboth
--- a/runtime/common/config/substrate.rs
+++ b/runtime/common/config/substrate.rs
@@ -36,7 +36,7 @@
 use pallet_transaction_payment::{Multiplier, ConstFeeMultiplier};
 use crate::{
 	runtime_common::DealWithFees, Runtime, RuntimeEvent, RuntimeCall, RuntimeOrigin, PalletInfo,
-	System, Balances, Treasury, SS58Prefix, Version,
+	System, Balances, SS58Prefix, Version,
 };
 use up_common::{types::*, constants::*};
 
@@ -142,10 +142,15 @@
 	type Balance = Balance;
 	/// The ubiquitous event type.
 	type RuntimeEvent = RuntimeEvent;
-	type DustRemoval = Treasury;
+	// FIXME: Is () the new treasury?
+	type DustRemoval = ();
 	type ExistentialDeposit = ExistentialDeposit;
 	type AccountStore = System;
 	type WeightInfo = pallet_balances::weights::SubstrateWeight<Self>;
+	type HoldIdentifier = [u8; 16];
+	type FreezeIdentifier = [u8; 16];
+	type MaxHolds = ();
+	type MaxFreezes = ();
 }
 
 parameter_types! {
modifiedruntime/common/config/xcm/mod.rsdiffbeforeafterboth
--- a/runtime/common/config/xcm/mod.rs
+++ b/runtime/common/config/xcm/mod.rs
@@ -15,7 +15,7 @@
 // along with Unique Network. If not, see <http://www.gnu.org/licenses/>.
 
 use frame_support::{
-	traits::{Everything, Nothing, Get, ConstU32},
+	traits::{Everything, Nothing, Get, ConstU32, ProcessMessageError},
 	parameter_types,
 };
 use frame_system::EnsureRoot;
@@ -114,26 +114,18 @@
 );
 
 pub trait TryPass {
-<<<<<<< HEAD
-	fn try_pass<Call>(origin: &MultiLocation, message: &mut [Instruction<Call>]) -> Result<(), ()>;
-=======
 	fn try_pass<Call>(
 		origin: &MultiLocation,
 		message: &mut [Instruction<Call>],
 	) -> Result<(), ProcessMessageError>;
->>>>>>> fd33b0ac (fixup pallets)
 }
 
 #[impl_trait_for_tuples::impl_for_tuples(30)]
 impl TryPass for Tuple {
-<<<<<<< HEAD
-	fn try_pass<Call>(origin: &MultiLocation, message: &mut [Instruction<Call>]) -> Result<(), ()> {
-=======
 	fn try_pass<Call>(
 		origin: &MultiLocation,
 		message: &mut [Instruction<Call>],
 	) -> Result<(), ProcessMessageError> {
->>>>>>> fd33b0ac (fixup pallets)
 		for_tuples!( #(
 			Tuple::try_pass(origin, message)?;
 		)* );
@@ -159,7 +151,7 @@
 		message: &mut [Instruction<Call>],
 		max_weight: Weight,
 		weight_credit: &mut Weight,
-	) -> Result<(), ()> {
+	) -> Result<(), ProcessMessageError> {
 		Deny::try_pass(origin, message)?;
 		Allow::should_execute(origin, message, max_weight, weight_credit)
 	}
@@ -227,6 +219,7 @@
 	type SovereignAccountOf = LocationToAccountId;
 	type MaxLockers = ConstU32<8>;
 	type WeightInfo = crate::weights::xcm::SubstrateWeight<Runtime>;
+	type AdminOrigin = EnsureRoot<AccountId>;
 	#[cfg(feature = "runtime-benchmarks")]
 	type ReachableDest = ReachableDest;
 }
modifiedruntime/common/config/xcm/nativeassets.rsdiffbeforeafterboth
--- a/runtime/common/config/xcm/nativeassets.rs
+++ b/runtime/common/config/xcm/nativeassets.rs
@@ -102,7 +102,8 @@
 	for UsingOnlySelfCurrencyComponents<WeightToFee, AssetId, AccountId, Currency, OnUnbalanced>
 {
 	fn new() -> Self {
-		Self(0, Zero::zero(), PhantomData)
+		// FIXME: benchmark
+		Self(Weight::from_parts(0, 0), Zero::zero(), PhantomData)
 	}
 
 	fn buy_weight(&mut self, _weight: Weight, payment: Assets) -> Result<Assets, XcmError> {
modifiedruntime/common/runtime_apis.rsdiffbeforeafterboth
--- a/runtime/common/runtime_apis.rs
+++ b/runtime/common/runtime_apis.rs
@@ -35,7 +35,7 @@
     ) => {
         use sp_std::prelude::*;
         use sp_api::impl_runtime_apis;
-        use sp_core::{crypto::KeyTypeId, OpaqueMetadata, H256, U256, H160, Bytes};
+        use sp_core::{crypto::KeyTypeId, OpaqueMetadata, H256, U256, H160};
         use sp_runtime::{
             Permill,
             traits::Block as BlockT,
@@ -250,6 +250,14 @@
                 fn metadata() -> OpaqueMetadata {
                     OpaqueMetadata::new(Runtime::metadata().into())
                 }
+
+                fn metadata_at_version(version: u32) -> Option<OpaqueMetadata> {
+                    Runtime::metadata_at_version(version)
+                }
+
+                fn metadata_versions() -> sp_std::vec::Vec<u32> {
+                    Runtime::metadata_versions()
+                }
             }
 
             impl sp_block_builder::BlockBuilder<Block> for Runtime {
@@ -311,7 +319,7 @@
                 fn account_code_at(address: H160) -> Vec<u8> {
                     use pallet_evm::OnMethodCall;
                     <Runtime as pallet_evm::Config>::OnMethodCall::get_code(&address)
-                        .unwrap_or_else(|| EVM::account_codes(address))
+                        .unwrap_or_else(|| pallet_evm::AccountCodes::<Runtime>::get(address))
                 }
 
                 fn author() -> H160 {
@@ -321,7 +329,7 @@
                 fn storage_at(address: H160, index: U256) -> H256 {
                     let mut tmp = [0u8; 32];
                     index.to_big_endian(&mut tmp);
-                    EVM::account_storages(address, H256::from_slice(&tmp[..]))
+                    pallet_evm::AccountStorages::<Runtime>::get(address, H256::from_slice(&tmp[..]))
                 }
 
                 #[allow(clippy::redundant_closure)]
@@ -401,15 +409,15 @@
                 }
 
                 fn current_transaction_statuses() -> Option<Vec<TransactionStatus>> {
-                    Ethereum::current_transaction_statuses()
+                    pallet_ethereum::CurrentTransactionStatuses::<Runtime>::get()
                 }
 
                 fn current_block() -> Option<pallet_ethereum::Block> {
-                    Ethereum::current_block()
+                    pallet_ethereum::CurrentBlock::<Runtime>::get()
                 }
 
                 fn current_receipts() -> Option<Vec<pallet_ethereum::Receipt>> {
-                    Ethereum::current_receipts()
+                    pallet_ethereum::CurrentReceipts::<Runtime>::get()
                 }
 
                 fn current_all() -> (
@@ -418,9 +426,9 @@
                     Option<Vec<TransactionStatus>>
                 ) {
                     (
-                        Ethereum::current_block(),
-                        Ethereum::current_receipts(),
-                        Ethereum::current_transaction_statuses()
+                        pallet_ethereum::CurrentBlock::<Runtime>::get(),
+                        pallet_ethereum::CurrentReceipts::<Runtime>::get(),
+                        pallet_ethereum::CurrentTransactionStatuses::<Runtime>::get()
                     )
                 }
 
@@ -653,12 +661,12 @@
 
             impl up_pov_estimate_rpc::PovEstimateApi<Block> for Runtime {
                 #[allow(unused_variables)]
-                fn pov_estimate(uxt: Bytes) -> ApplyExtrinsicResult {
+                fn pov_estimate(uxt: Vec<u8>) -> ApplyExtrinsicResult {
                     #[cfg(feature = "pov-estimate")]
                     {
                         use codec::Decode;
 
-                        let uxt_decode = <<Block as BlockT>::Extrinsic as Decode>::decode(&mut &*uxt)
+                        let uxt_decode = <<Block as BlockT>::Extrinsic as Decode>::decode(&mut &uxt)
                             .map_err(|_| DispatchError::Other("failed to decode the extrinsic"));
 
                         let uxt = match uxt_decode {
modifiedruntime/common/weights/xcm.rsdiffbeforeafterboth
--- a/runtime/common/weights/xcm.rs
+++ b/runtime/common/weights/xcm.rs
@@ -244,5 +244,9 @@
 			.saturating_add(T::DbWeight::get().reads(9_u64))
 			.saturating_add(T::DbWeight::get().writes(4_u64))
 	}
+
+	fn force_suspension() -> Weight {
+		Default::default()
+	}
 }
 
modifiedruntime/opal/Cargo.tomldiffbeforeafterboth
--- a/runtime/opal/Cargo.toml
+++ b/runtime/opal/Cargo.toml
@@ -220,7 +220,7 @@
 orml-xcm-support = { workspace = true }
 pallet-aura = { workspace = true }
 pallet-authorship = { workspace = true }
-pallet-balances = { workspace = true }
+pallet-balances = { features = ["insecure_zero_ed"], workspace = true }
 pallet-preimage = { workspace = true }
 pallet-session = { workspace = true }
 pallet-sudo = { workspace = true }
modifiedruntime/quartz/Cargo.tomldiffbeforeafterboth
--- a/runtime/quartz/Cargo.toml
+++ b/runtime/quartz/Cargo.toml
@@ -212,7 +212,7 @@
 orml-xcm-support = { workspace = true }
 pallet-aura = { workspace = true }
 pallet-authorship = { workspace = true }
-pallet-balances = { workspace = true }
+pallet-balances = { features = ["insecure_zero_ed"], workspace = true }
 pallet-preimage = { workspace = true }
 pallet-session = { workspace = true }
 pallet-sudo = { workspace = true }
modifiedruntime/tests/Cargo.tomldiffbeforeafterboth
--- a/runtime/tests/Cargo.toml
+++ b/runtime/tests/Cargo.toml
@@ -9,37 +9,37 @@
 refungible = []
 
 [dependencies]
-up-data-structs = { default-features = false, path = "../../primitives/data-structs" }
+up-data-structs = { workspace = true }
 
-sp-core = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
-sp-io = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
-sp-runtime = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
-sp-std = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
+sp-core = { workspace = true }
+sp-io = { workspace = true }
+sp-runtime = { workspace = true }
+sp-std = { workspace = true }
 
-frame-support = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
-frame-system = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
+frame-support = { workspace = true }
+frame-system = { workspace = true }
 
-pallet-balances = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
-pallet-timestamp = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
-pallet-transaction-payment = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.42" }
+pallet-balances = { features = ["insecure_zero_ed"], workspace = true }
+pallet-timestamp = { workspace = true }
+pallet-transaction-payment = { workspace = true }
 
-pallet-ethereum = { default-features = false, git = "https://github.com/uniquenetwork/unique-frontier", branch = "unique-polkadot-v0.9.42" }
-pallet-evm = { default-features = false, git = "https://github.com/uniquenetwork/unique-frontier", branch = "unique-polkadot-v0.9.42" }
+pallet-ethereum = { workspace = true }
+pallet-evm = { workspace = true }
 
-pallet-common.path = "../../pallets/common"
-pallet-fungible.path = "../../pallets/fungible"
-pallet-nonfungible.path = "../../pallets/nonfungible"
-pallet-refungible.path = "../../pallets/refungible"
-pallet-structure.path = "../../pallets/structure"
-pallet-unique.path = "../../pallets/unique"
+pallet-common = { workspace = true }
+pallet-fungible = { workspace = true }
+pallet-nonfungible = { workspace = true }
+pallet-refungible = { workspace = true }
+pallet-structure = { workspace = true }
+pallet-unique = { workspace = true }
 
-pallet-evm-coder-substrate.path = "../../pallets/evm-coder-substrate"
+pallet-evm-coder-substrate = { workspace = true }
 
-parity-scale-codec = { version = "3.2.2", default-features = false, features = ["derive"] }
-scale-info = "*"
+codec = { workspace = true }
+scale-info = { workspace = true }
 
 evm-coder = { workspace = true }
-up-sponsorship = { default-features = false, git = "https://github.com/uniquenetwork/pallet-sponsoring", branch = "polkadot-v0.9.42" }
+up-sponsorship = { workspace = true }
 xcm = { workspace = true }
 pallet-xcm = { workspace = true }
 pallet-configuration = { workspace = true }
modifiedruntime/unique/Cargo.tomldiffbeforeafterboth
--- a/runtime/unique/Cargo.toml
+++ b/runtime/unique/Cargo.toml
@@ -211,7 +211,7 @@
 orml-xcm-support = { workspace = true }
 pallet-aura = { workspace = true }
 pallet-authorship = { workspace = true }
-pallet-balances = { workspace = true }
+pallet-balances = { features = ["insecure_zero_ed"], workspace = true }
 pallet-preimage = { workspace = true }
 pallet-session = { workspace = true }
 pallet-sudo = { workspace = true }