git.delta.rocks / unique-network / refs/commits / 31fca6536571

difftreelog

Add no-floating-promises rule to eslint

Max Andreev2022-12-22parent: #72b9c7c.patch.diff
in: master

6 files changed

modifiedtests/.eslintrc.jsondiffbeforeafterboth
before · tests/.eslintrc.json
1{2    "env": {3        "browser": true,4        "es2020": true5    },6    "extends": [7        "eslint:recommended",8        "plugin:@typescript-eslint/recommended"9    ],10    "parser": "@typescript-eslint/parser",11    "parserOptions": {12        "ecmaVersion": 11,13        "sourceType": "module",14        "project": "**/tsconfig.json"15    },16    "plugins": [17        "@typescript-eslint",18        "mocha"19    ],20    "rules": {21        "indent": [22            "error",23            2,24            {25                "SwitchCase": 126            }27        ],28        "no-trailing-spaces": "warn",29        "function-call-argument-newline": [30            "error",31            "consistent"32        ],33        "function-paren-newline": [34            "error",35            "multiline"36        ],37        "linebreak-style": [38            "error",39            "unix"40        ],41        "quotes": [42            "error",43            "single",44            {45                "avoidEscape": true46            }47        ],48        "require-await": 2,49        "mocha/no-async-describe": "error",50        "mocha/no-nested-tests": "error",51        "mocha/no-synchronous-tests": "error",52        "semi": [53            "error",54            "always"55        ],56        "@typescript-eslint/explicit-module-boundary-types": "off",57        "comma-dangle": [58            "error",59            "always-multiline"60        ],61        "no-unused-vars": "off",62        "@typescript-eslint/no-empty-function": "off",63        "@typescript-eslint/no-non-null-assertion": "off",64        "@typescript-eslint/no-explicit-any": "off",65        "@typescript-eslint/no-unused-vars": [66            "warn",67            {68                "varsIgnorePattern": "_.+",69                "argsIgnorePattern": "_.+"70            }71        ],72        "no-async-promise-executor": "warn",73        "@typescript-eslint/no-empty-interface": "off",74        "prefer-const": [75            "error",76            {77                "destructuring": "all"78            }79        ],80        "@typescript-eslint/ban-ts-comment": "off",81        "object-curly-spacing": "warn",82        "arrow-spacing": "warn",83        "array-bracket-spacing": "warn",84        "template-curly-spacing": "warn",85        "space-in-parens": "warn",86        "@typescript-eslint/naming-convention": [87            "warn",88            {89                "selector": "default",90                "format": [91                    "camelCase"92                ],93                "leadingUnderscore": "allow",94                "trailingUnderscore": "allow"95            },96            {97                "selector": "variable",98                "format": [99                    "camelCase",100                    "UPPER_CASE"101                ],102                "leadingUnderscore": "allow",103                "trailingUnderscore": "allow"104            },105            {106                "selector": "typeLike",107                "format": [108                    "PascalCase"109                ]110            },111            {112                "selector": "memberLike",113                "format": null114            }115        ]116    }117}
after · tests/.eslintrc.json
1{2    "env": {3        "browser": true,4        "es2020": true5    },6    "extends": [7        "eslint:recommended",8        "plugin:@typescript-eslint/recommended"9    ],10    "parser": "@typescript-eslint/parser",11    "parserOptions": {12        "ecmaVersion": 11,13        "sourceType": "module",14        "project": "**/tsconfig.json"15    },16    "plugins": [17        "@typescript-eslint",18        "mocha"19    ],20    "rules": {21        "@typescript-eslint/no-floating-promises": [22            "error"23        ],24        "indent": [25            "error",26            2,27            {28                "SwitchCase": 129            }30        ],31        "no-trailing-spaces": "warn",32        "function-call-argument-newline": [33            "error",34            "consistent"35        ],36        "function-paren-newline": [37            "error",38            "multiline"39        ],40        "linebreak-style": [41            "error",42            "unix"43        ],44        "quotes": [45            "error",46            "single",47            {48                "avoidEscape": true49            }50        ],51        "require-await": 2,52        "mocha/no-async-describe": "error",53        "mocha/no-nested-tests": "error",54        "mocha/no-synchronous-tests": "error",55        "semi": [56            "error",57            "always"58        ],59        "@typescript-eslint/explicit-module-boundary-types": "off",60        "comma-dangle": [61            "error",62            "always-multiline"63        ],64        "no-unused-vars": "off",65        "@typescript-eslint/no-empty-function": "off",66        "@typescript-eslint/no-non-null-assertion": "off",67        "@typescript-eslint/no-explicit-any": "off",68        "@typescript-eslint/no-unused-vars": [69            "warn",70            {71                "varsIgnorePattern": "_.+",72                "argsIgnorePattern": "_.+"73            }74        ],75        "no-async-promise-executor": "warn",76        "@typescript-eslint/no-empty-interface": "off",77        "prefer-const": [78            "error",79            {80                "destructuring": "all"81            }82        ],83        "@typescript-eslint/ban-ts-comment": "off",84        "object-curly-spacing": "warn",85        "arrow-spacing": "warn",86        "array-bracket-spacing": "warn",87        "template-curly-spacing": "warn",88        "space-in-parens": "warn",89        "@typescript-eslint/naming-convention": [90            "warn",91            {92                "selector": "default",93                "format": [94                    "camelCase"95                ],96                "leadingUnderscore": "allow",97                "trailingUnderscore": "allow"98            },99            {100                "selector": "variable",101                "format": [102                    "camelCase",103                    "UPPER_CASE"104                ],105                "leadingUnderscore": "allow",106                "trailingUnderscore": "allow"107            },108            {109                "selector": "typeLike",110                "format": [111                    "PascalCase"112                ]113            },114            {115                "selector": "memberLike",116                "format": null117            }118        ]119    }120}
modifiedtests/package.jsondiffbeforeafterboth
--- a/tests/package.json
+++ b/tests/package.json
@@ -11,8 +11,8 @@
     "@types/chai-subset": "^1.3.3",
     "@types/mocha": "^10.0.0",
     "@types/node": "^18.11.2",
-    "@typescript-eslint/eslint-plugin": "^5.40.1",
-    "@typescript-eslint/parser": "^5.40.1",
+    "@typescript-eslint/eslint-plugin": "^5.47.0",
+    "@typescript-eslint/parser": "^5.47.0",
     "chai": "^4.3.6",
     "chai-subset": "^1.6.0",
     "eslint": "^8.25.0",
modifiedtests/src/calibrate.tsdiffbeforeafterboth
--- a/tests/src/calibrate.ts
+++ b/tests/src/calibrate.ts
@@ -295,6 +295,7 @@
   }
 }
 
+// eslint-disable-next-line @typescript-eslint/no-floating-promises
 (async () => {
   await usingEthPlaygrounds(async (helper: EthUniqueHelper, privateKey) => {
     // Subsequent runs reduce error, as price line is not actually straight, this is a curve
modifiedtests/src/transfer.nload.tsdiffbeforeafterboth
--- a/tests/src/transfer.nload.ts
+++ b/tests/src/transfer.nload.ts
@@ -14,6 +14,7 @@
 // You should have received a copy of the GNU General Public License
 // along with Unique Network. If not, see <http://www.gnu.org/licenses/>.
 
+/* eslint-disable @typescript-eslint/no-floating-promises */
 import os from 'os';
 import {IKeyringPair} from '@polkadot/types/types';
 import {usingPlaygrounds} from './util';
modifiedtests/src/util/globalSetup.tsdiffbeforeafterboth
--- a/tests/src/util/globalSetup.ts
+++ b/tests/src/util/globalSetup.ts
@@ -17,7 +17,7 @@
       // 2. Create donors for test files
       await fundFilenamesWithRetries(3)
         .then((result) => {
-          if (!result) Promise.reject();
+          if (!result) throw Error('Some problems with fundFilenamesWithRetries');
         });
 
       // 3. Configure App Promotion
@@ -38,7 +38,7 @@
       }
     } catch (error) {
       console.error(error);
-      Promise.reject();
+      throw Error('Error during globalSetup');
     }
   });
 };
modifiedtests/yarn.lockdiffbeforeafterboth
--- a/tests/yarn.lock
+++ b/tests/yarn.lock
@@ -1064,14 +1064,14 @@
   dependencies:
     "@types/node" "*"
 
-"@typescript-eslint/eslint-plugin@^5.40.1":
-  version "5.46.1"
-  resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-5.46.1.tgz#098abb4c9354e19f460d57ab18bff1f676a6cff0"
-  integrity sha512-YpzNv3aayRBwjs4J3oz65eVLXc9xx0PDbIRisHj+dYhvBn02MjYOD96P8YGiWEIFBrojaUjxvkaUpakD82phsA==
+"@typescript-eslint/eslint-plugin@^5.47.0":
+  version "5.47.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-5.47.0.tgz#dadb79df3b0499699b155839fd6792f16897d910"
+  integrity sha512-AHZtlXAMGkDmyLuLZsRpH3p4G/1iARIwc/T0vIem2YB+xW6pZaXYXzCBnZSF/5fdM97R9QqZWZ+h3iW10XgevQ==
   dependencies:
-    "@typescript-eslint/scope-manager" "5.46.1"
-    "@typescript-eslint/type-utils" "5.46.1"
-    "@typescript-eslint/utils" "5.46.1"
+    "@typescript-eslint/scope-manager" "5.47.0"
+    "@typescript-eslint/type-utils" "5.47.0"
+    "@typescript-eslint/utils" "5.47.0"
     debug "^4.3.4"
     ignore "^5.2.0"
     natural-compare-lite "^1.4.0"
@@ -1079,72 +1079,72 @@
     semver "^7.3.7"
     tsutils "^3.21.0"
 
-"@typescript-eslint/parser@^5.40.1":
-  version "5.46.1"
-  resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-5.46.1.tgz#1fc8e7102c1141eb64276c3b89d70da8c0ba5699"
-  integrity sha512-RelQ5cGypPh4ySAtfIMBzBGyrNerQcmfA1oJvPj5f+H4jI59rl9xxpn4bonC0tQvUKOEN7eGBFWxFLK3Xepneg==
+"@typescript-eslint/parser@^5.47.0":
+  version "5.47.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-5.47.0.tgz#62e83de93499bf4b500528f74bf2e0554e3a6c8d"
+  integrity sha512-udPU4ckK+R1JWCGdQC4Qa27NtBg7w020ffHqGyAK8pAgOVuNw7YaKXGChk+udh+iiGIJf6/E/0xhVXyPAbsczw==
   dependencies:
-    "@typescript-eslint/scope-manager" "5.46.1"
-    "@typescript-eslint/types" "5.46.1"
-    "@typescript-eslint/typescript-estree" "5.46.1"
+    "@typescript-eslint/scope-manager" "5.47.0"
+    "@typescript-eslint/types" "5.47.0"
+    "@typescript-eslint/typescript-estree" "5.47.0"
     debug "^4.3.4"
 
-"@typescript-eslint/scope-manager@5.46.1":
-  version "5.46.1"
-  resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-5.46.1.tgz#70af8425c79bbc1178b5a63fb51102ddf48e104a"
-  integrity sha512-iOChVivo4jpwUdrJZyXSMrEIM/PvsbbDOX1y3UCKjSgWn+W89skxWaYXACQfxmIGhPVpRWK/VWPYc+bad6smIA==
+"@typescript-eslint/scope-manager@5.47.0":
+  version "5.47.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-5.47.0.tgz#f58144a6b0ff58b996f92172c488813aee9b09df"
+  integrity sha512-dvJab4bFf7JVvjPuh3sfBUWsiD73aiftKBpWSfi3sUkysDQ4W8x+ZcFpNp7Kgv0weldhpmMOZBjx1wKN8uWvAw==
   dependencies:
-    "@typescript-eslint/types" "5.46.1"
-    "@typescript-eslint/visitor-keys" "5.46.1"
+    "@typescript-eslint/types" "5.47.0"
+    "@typescript-eslint/visitor-keys" "5.47.0"
 
-"@typescript-eslint/type-utils@5.46.1":
-  version "5.46.1"
-  resolved "https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-5.46.1.tgz#195033e4b30b51b870dfcf2828e88d57b04a11cc"
-  integrity sha512-V/zMyfI+jDmL1ADxfDxjZ0EMbtiVqj8LUGPAGyBkXXStWmCUErMpW873zEHsyguWCuq2iN4BrlWUkmuVj84yng==
+"@typescript-eslint/type-utils@5.47.0":
+  version "5.47.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-5.47.0.tgz#2b440979c574e317d3473225ae781f292c99e55d"
+  integrity sha512-1J+DFFrYoDUXQE1b7QjrNGARZE6uVhBqIvdaXTe5IN+NmEyD68qXR1qX1g2u4voA+nCaelQyG8w30SAOihhEYg==
   dependencies:
-    "@typescript-eslint/typescript-estree" "5.46.1"
-    "@typescript-eslint/utils" "5.46.1"
+    "@typescript-eslint/typescript-estree" "5.47.0"
+    "@typescript-eslint/utils" "5.47.0"
     debug "^4.3.4"
     tsutils "^3.21.0"
 
-"@typescript-eslint/types@5.46.1":
-  version "5.46.1"
-  resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-5.46.1.tgz#4e9db2107b9a88441c4d5ecacde3bb7a5ebbd47e"
-  integrity sha512-Z5pvlCaZgU+93ryiYUwGwLl9AQVB/PQ1TsJ9NZ/gHzZjN7g9IAn6RSDkpCV8hqTwAiaj6fmCcKSQeBPlIpW28w==
+"@typescript-eslint/types@5.47.0":
+  version "5.47.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/types/-/types-5.47.0.tgz#67490def406eaa023dbbd8da42ee0d0c9b5229d3"
+  integrity sha512-eslFG0Qy8wpGzDdYKu58CEr3WLkjwC5Usa6XbuV89ce/yN5RITLe1O8e+WFEuxnfftHiJImkkOBADj58ahRxSg==
 
-"@typescript-eslint/typescript-estree@5.46.1":
-  version "5.46.1"
-  resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-5.46.1.tgz#5358088f98a8f9939355e0996f9c8f41c25eced2"
-  integrity sha512-j9W4t67QiNp90kh5Nbr1w92wzt+toiIsaVPnEblB2Ih2U9fqBTyqV9T3pYWZBRt6QoMh/zVWP59EpuCjc4VRBg==
+"@typescript-eslint/typescript-estree@5.47.0":
+  version "5.47.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-5.47.0.tgz#ed971a11c5c928646d6ba7fc9dfdd6e997649aca"
+  integrity sha512-LxfKCG4bsRGq60Sqqu+34QT5qT2TEAHvSCCJ321uBWywgE2dS0LKcu5u+3sMGo+Vy9UmLOhdTw5JHzePV/1y4Q==
   dependencies:
-    "@typescript-eslint/types" "5.46.1"
-    "@typescript-eslint/visitor-keys" "5.46.1"
+    "@typescript-eslint/types" "5.47.0"
+    "@typescript-eslint/visitor-keys" "5.47.0"
     debug "^4.3.4"
     globby "^11.1.0"
     is-glob "^4.0.3"
     semver "^7.3.7"
     tsutils "^3.21.0"
 
-"@typescript-eslint/utils@5.46.1":
-  version "5.46.1"
-  resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-5.46.1.tgz#7da3c934d9fd0eb4002a6bb3429f33298b469b4a"
-  integrity sha512-RBdBAGv3oEpFojaCYT4Ghn4775pdjvwfDOfQ2P6qzNVgQOVrnSPe5/Pb88kv7xzYQjoio0eKHKB9GJ16ieSxvA==
+"@typescript-eslint/utils@5.47.0":
+  version "5.47.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-5.47.0.tgz#b5005f7d2696769a1fdc1e00897005a25b3a0ec7"
+  integrity sha512-U9xcc0N7xINrCdGVPwABjbAKqx4GK67xuMV87toI+HUqgXj26m6RBp9UshEXcTrgCkdGYFzgKLt8kxu49RilDw==
   dependencies:
     "@types/json-schema" "^7.0.9"
     "@types/semver" "^7.3.12"
-    "@typescript-eslint/scope-manager" "5.46.1"
-    "@typescript-eslint/types" "5.46.1"
-    "@typescript-eslint/typescript-estree" "5.46.1"
+    "@typescript-eslint/scope-manager" "5.47.0"
+    "@typescript-eslint/types" "5.47.0"
+    "@typescript-eslint/typescript-estree" "5.47.0"
     eslint-scope "^5.1.1"
     eslint-utils "^3.0.0"
     semver "^7.3.7"
 
-"@typescript-eslint/visitor-keys@5.46.1":
-  version "5.46.1"
-  resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-5.46.1.tgz#126cc6fe3c0f83608b2b125c5d9daced61394242"
-  integrity sha512-jczZ9noovXwy59KjRTk1OftT78pwygdcmCuBf8yMoWt/8O8l+6x2LSEze0E4TeepXK4MezW3zGSyoDRZK7Y9cg==
+"@typescript-eslint/visitor-keys@5.47.0":
+  version "5.47.0"
+  resolved "https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-5.47.0.tgz#4aca4efbdf6209c154df1f7599852d571b80bb45"
+  integrity sha512-ByPi5iMa6QqDXe/GmT/hR6MZtVPi0SqMQPDx15FczCBXJo/7M8T88xReOALAfpBLm+zxpPfmhuEvPb577JRAEg==
   dependencies:
-    "@typescript-eslint/types" "5.46.1"
+    "@typescript-eslint/types" "5.47.0"
     eslint-visitor-keys "^3.3.0"
 
 abortcontroller-polyfill@^1.7.3: