git.delta.rocks / unique-network / refs/commits / 31c9ea38932b

difftreelog

NFTPAR-268 CreateCollection Tests Broken. Null terminated strings replaced with fixed size strings

str-mv2020-12-30parent: #57a41c1.patch.diff
in: master

2 files changed

modifiedpallets/nft/src/lib.rsdiffbeforeafterboth
562 // check params562 // check params
563 ensure!(decimal_points <= MAX_DECIMAL_POINTS, Error::<T>::CollectionDecimalPointLimitExceeded);563 ensure!(decimal_points <= MAX_DECIMAL_POINTS, Error::<T>::CollectionDecimalPointLimitExceeded);
564
565 let mut name = collection_name.to_vec();
566 name.push(0);
567 ensure!(name.len() <= 64, Error::<T>::CollectionNameLimitExceeded);564 ensure!(collection_name.len() <= 64, Error::<T>::CollectionNameLimitExceeded);
568
569 let mut description = collection_description.to_vec();
570 description.push(0);
571 ensure!(name.len() <= 256, Error::<T>::CollectionDescriptionLimitExceeded);565 ensure!(collection_description.len() <= 256, Error::<T>::CollectionDescriptionLimitExceeded);
572
573 let mut prefix = token_prefix.to_vec();
574 prefix.push(0);
575 ensure!(prefix.len() <= 16, Error::<T>::CollectionTokenPrefixLimitExceeded);566 ensure!(token_prefix.len() <= 16, Error::<T>::CollectionTokenPrefixLimitExceeded);
576567
577 // Generate next collection ID568 // Generate next collection ID
578 let next_id = CreatedCollectionCount::get()569 let next_id = CreatedCollectionCount::get()
590 // Create new collection581 // Create new collection
591 let new_collection = CollectionType {582 let new_collection = CollectionType {
592 owner: who.clone(),583 owner: who.clone(),
593 name: name,584 name: collection_name,
594 mode: mode.clone(),585 mode: mode.clone(),
595 mint_mode: false,586 mint_mode: false,
596 access: AccessMode::Normal,587 access: AccessMode::Normal,
597 description: description,588 description: collection_description,
598 decimal_points: decimal_points,589 decimal_points: decimal_points,
599 token_prefix: prefix,590 token_prefix: token_prefix,
600 offchain_schema: Vec::new(),591 offchain_schema: Vec::new(),
601 schema_version: SchemaVersion::ImageURL,592 schema_version: SchemaVersion::ImageURL,
602 sponsor: T::AccountId::default(),593 sponsor: T::AccountId::default(),
modifiedpallets/nft/src/tests.rsdiffbeforeafterboth
49 mode.clone()49 mode.clone()
50 ));50 ));
5151
52 let saved_col_name: Vec<u16> = "Test1\0\0".encode_utf16().collect::<Vec<u16>>();52 let saved_col_name: Vec<u16> = "Test1\0".encode_utf16().collect::<Vec<u16>>();
53 let saved_description: Vec<u16> = "TestDescription1\0\0".encode_utf16().collect::<Vec<u16>>();53 let saved_description: Vec<u16> = "TestDescription1\0".encode_utf16().collect::<Vec<u16>>();
54 let saved_prefix: Vec<u8> = b"token_prefix1\0\0".to_vec();54 let saved_prefix: Vec<u8> = b"token_prefix1\0".to_vec();
55 assert_eq!(TemplateModule::collection(id).owner, owner);55 assert_eq!(TemplateModule::collection(id).owner, owner);
56 assert_eq!(TemplateModule::collection(id).name, saved_col_name);56 assert_eq!(TemplateModule::collection(id).name, saved_col_name);
57 assert_eq!(TemplateModule::collection(id).mode, *mode);57 assert_eq!(TemplateModule::collection(id).mode, *mode);