difftreelog
fix(preimage-execution) accounting for weight bound
in: master
1 file changed
pallets/maintenance/src/lib.rsdiffbeforeafterboth1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617#![cfg_attr(not(feature = "std"), no_std)]1819pub use pallet::*;2021#[cfg(feature = "runtime-benchmarks")]22pub mod benchmarking;2324pub mod weights;2526#[frame_support::pallet]27pub mod pallet {28 use frame_support::{dispatch::*, pallet_prelude::*};29 use frame_support::{30 traits::{QueryPreimage, StorePreimage},31 };32 use frame_system::pallet_prelude::*;33 use sp_core::H256;3435 use crate::weights::WeightInfo;3637 #[pallet::config]38 pub trait Config: frame_system::Config {39 /// The overarching event type.40 type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;4142 /// The runtime origin type.43 type RuntimeOrigin: From<RawOrigin<Self::AccountId>>44 + IsType<<Self as frame_system::Config>::RuntimeOrigin>;4546 /// The aggregated call type.47 type RuntimeCall: Parameter48 + Dispatchable<49 RuntimeOrigin = <Self as Config>::RuntimeOrigin,50 PostInfo = PostDispatchInfo,51 > + GetDispatchInfo52 + From<frame_system::Call<Self>>;5354 /// The preimage provider with which we look up call hashes to get the call.55 type Preimages: QueryPreimage + StorePreimage;5657 /// Weight information for extrinsics in this pallet.58 type WeightInfo: WeightInfo;59 }6061 #[pallet::event]62 #[pallet::generate_deposit(pub(super) fn deposit_event)]63 pub enum Event<T: Config> {64 MaintenanceEnabled,65 MaintenanceDisabled,66 }6768 #[pallet::pallet]69 #[pallet::generate_store(pub(super) trait Store)]70 pub struct Pallet<T>(_);7172 #[pallet::storage]73 #[pallet::getter(fn is_enabled)]74 pub type Enabled<T> = StorageValue<_, bool, ValueQuery>;7576 #[pallet::error]77 pub enum Error<T> {}7879 #[pallet::call]80 impl<T: Config> Pallet<T> {81 #[pallet::call_index(0)]82 #[pallet::weight(<T as Config>::WeightInfo::enable())]83 pub fn enable(origin: OriginFor<T>) -> DispatchResult {84 ensure_root(origin)?;8586 <Enabled<T>>::set(true);8788 Self::deposit_event(Event::MaintenanceEnabled);8990 Ok(())91 }9293 #[pallet::call_index(1)]94 #[pallet::weight(<T as Config>::WeightInfo::disable())]95 pub fn disable(origin: OriginFor<T>) -> DispatchResult {96 ensure_root(origin)?;9798 <Enabled<T>>::set(false);99100 Self::deposit_event(Event::MaintenanceDisabled);101102 Ok(())103 }104105 /// Execute a runtime call stored as a preimage.106 ///107 /// `weight_bound` is the maximum weight that the caller is willing108 /// to allow the extrinsic to be executed with.109 #[pallet::call_index(2)]110 #[pallet::weight(<T as Config>::WeightInfo::execute_preimage())]111 pub fn execute_preimage(112 origin: OriginFor<T>,113 hash: H256,114 weight_bound: Weight,115 ) -> DispatchResultWithPostInfo {116 use codec::Decode;117118 ensure_root(origin)?;119120 let data = T::Preimages::fetch(&hash, None)?;121 weight_bound.set_proof_size(122 weight_bound123 .proof_size()124 .checked_sub(125 data.len()126 .try_into()127 .map_err(|_| DispatchError::Corruption)?,128 )129 .ok_or(DispatchError::Exhausted)?,130 );131132 let call = <T as Config>::RuntimeCall::decode(&mut &data[..])133 .map_err(|_| DispatchError::Corruption)?;134135 ensure!(136 call.get_dispatch_info().weight.all_lte(weight_bound),137 DispatchError::Exhausted138 );139140 match call.dispatch(frame_system::RawOrigin::Root.into()) {141 Ok(_) => Ok(Pays::No.into()),142 Err(error_and_info) => Err(DispatchErrorWithPostInfo {143 post_info: Pays::No.into(),144 error: error_and_info.error,145 }),146 }147 }148 }149}1// Copyright 2019-2022 Unique Network (Gibraltar) Ltd.2// This file is part of Unique Network.34// Unique Network is free software: you can redistribute it and/or modify5// it under the terms of the GNU General Public License as published by6// the Free Software Foundation, either version 3 of the License, or7// (at your option) any later version.89// Unique Network is distributed in the hope that it will be useful,10// but WITHOUT ANY WARRANTY; without even the implied warranty of11// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the12// GNU General Public License for more details.1314// You should have received a copy of the GNU General Public License15// along with Unique Network. If not, see <http://www.gnu.org/licenses/>.1617#![cfg_attr(not(feature = "std"), no_std)]1819pub use pallet::*;2021#[cfg(feature = "runtime-benchmarks")]22pub mod benchmarking;2324pub mod weights;2526#[frame_support::pallet]27pub mod pallet {28 use frame_support::{dispatch::*, pallet_prelude::*};29 use frame_support::{30 traits::{QueryPreimage, StorePreimage},31 };32 use frame_system::pallet_prelude::*;33 use sp_core::H256;3435 use crate::weights::WeightInfo;3637 #[pallet::config]38 pub trait Config: frame_system::Config {39 /// The overarching event type.40 type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;4142 /// The runtime origin type.43 type RuntimeOrigin: From<RawOrigin<Self::AccountId>>44 + IsType<<Self as frame_system::Config>::RuntimeOrigin>;4546 /// The aggregated call type.47 type RuntimeCall: Parameter48 + Dispatchable<49 RuntimeOrigin = <Self as Config>::RuntimeOrigin,50 PostInfo = PostDispatchInfo,51 > + GetDispatchInfo52 + From<frame_system::Call<Self>>;5354 /// The preimage provider with which we look up call hashes to get the call.55 type Preimages: QueryPreimage + StorePreimage;5657 /// Weight information for extrinsics in this pallet.58 type WeightInfo: WeightInfo;59 }6061 #[pallet::event]62 #[pallet::generate_deposit(pub(super) fn deposit_event)]63 pub enum Event<T: Config> {64 MaintenanceEnabled,65 MaintenanceDisabled,66 }6768 #[pallet::pallet]69 #[pallet::generate_store(pub(super) trait Store)]70 pub struct Pallet<T>(_);7172 #[pallet::storage]73 #[pallet::getter(fn is_enabled)]74 pub type Enabled<T> = StorageValue<_, bool, ValueQuery>;7576 #[pallet::error]77 pub enum Error<T> {}7879 #[pallet::call]80 impl<T: Config> Pallet<T> {81 #[pallet::call_index(0)]82 #[pallet::weight(<T as Config>::WeightInfo::enable())]83 pub fn enable(origin: OriginFor<T>) -> DispatchResult {84 ensure_root(origin)?;8586 <Enabled<T>>::set(true);8788 Self::deposit_event(Event::MaintenanceEnabled);8990 Ok(())91 }9293 #[pallet::call_index(1)]94 #[pallet::weight(<T as Config>::WeightInfo::disable())]95 pub fn disable(origin: OriginFor<T>) -> DispatchResult {96 ensure_root(origin)?;9798 <Enabled<T>>::set(false);99100 Self::deposit_event(Event::MaintenanceDisabled);101102 Ok(())103 }104105 /// Execute a runtime call stored as a preimage.106 ///107 /// `weight_bound` is the maximum weight that the caller is willing108 /// to allow the extrinsic to be executed with.109 #[pallet::call_index(2)]110 #[pallet::weight(<T as Config>::WeightInfo::execute_preimage() + *weight_bound)]111 pub fn execute_preimage(112 origin: OriginFor<T>,113 hash: H256,114 weight_bound: Weight,115 ) -> DispatchResultWithPostInfo {116 use codec::Decode;117118 ensure_root(origin)?;119120 let data = T::Preimages::fetch(&hash, None)?;121 weight_bound.set_proof_size(122 weight_bound123 .proof_size()124 .checked_sub(125 data.len()126 .try_into()127 .map_err(|_| DispatchError::Corruption)?,128 )129 .ok_or(DispatchError::Exhausted)?,130 );131132 let call = <T as Config>::RuntimeCall::decode(&mut &data[..])133 .map_err(|_| DispatchError::Corruption)?;134135 ensure!(136 call.get_dispatch_info().weight.all_lte(weight_bound),137 DispatchError::Exhausted138 );139140 match call.dispatch(frame_system::RawOrigin::Root.into()) {141 Ok(_) => Ok(Pays::No.into()),142 Err(error_and_info) => Err(DispatchErrorWithPostInfo {143 post_info: Pays::No.into(),144 error: error_and_info.error,145 }),146 }147 }148 }149}