git.delta.rocks / unique-network / refs/commits / 2c040b3e73e9

difftreelog

fix unused `on_runtime_upgrade()` was removed

PraetorP2023-04-19parent: #6e3cf5e.patch.diff
in: master
- AppPromo
- Common
- NonFungible

10 files changed

modifiedCargo.lockdiffbeforeafterboth
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -5996,7 +5996,7 @@
 
 [[package]]
 name = "pallet-app-promotion"
-version = "0.1.5"
+version = "0.1.6"
 dependencies = [
  "frame-benchmarking",
  "frame-support",
@@ -6262,7 +6262,7 @@
 
 [[package]]
 name = "pallet-common"
-version = "0.1.13"
+version = "0.1.14"
 dependencies = [
  "ethereum",
  "evm-coder",
@@ -6814,7 +6814,7 @@
 
 [[package]]
 name = "pallet-nonfungible"
-version = "0.1.13"
+version = "0.1.14"
 dependencies = [
  "evm-coder",
  "frame-benchmarking",
modifiedpallets/app-promotion/CHANGELOG.mddiffbeforeafterboth
--- a/pallets/app-promotion/CHANGELOG.md
+++ b/pallets/app-promotion/CHANGELOG.md
@@ -3,6 +3,11 @@
 All notable changes to this project will be documented in this file.
 
 <!-- bureaucrate goes here -->
+## [0.1.6] - 2023-04-19
+
+- ### Fixed
+
+- Useless `on_runtime_upgrade()` has been removed
 
 ## [0.1.5] - 2023-02-14
modifiedpallets/app-promotion/Cargo.tomldiffbeforeafterboth
--- a/pallets/app-promotion/Cargo.toml
+++ b/pallets/app-promotion/Cargo.toml
@@ -9,7 +9,7 @@
 license = 'GPLv3'
 name = 'pallet-app-promotion'
 repository = 'https://github.com/UniqueNetwork/unique-chain'
-version = '0.1.5'
+version = '0.1.6'
 
 [package.metadata.docs.rs]
 targets = ['x86_64-unknown-linux-gnu']
modifiedpallets/app-promotion/src/lib.rsdiffbeforeafterboth
--- a/pallets/app-promotion/src/lib.rs
+++ b/pallets/app-promotion/src/lib.rs
@@ -263,10 +263,6 @@
 	pub type PreviousCalculatedRecord<T: Config> =
 		StorageValue<Value = (T::AccountId, T::BlockNumber), QueryKind = OptionQuery>;
 
-	#[pallet::storage]
-	pub(crate) type UpgradedToReserves<T: Config> =
-		StorageValue<Value = bool, QueryKind = ValueQuery>;
-
 	#[pallet::hooks]
 	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {
 		/// Block overflow is impossible due to the fact that the unstake algorithm in on_initialize
@@ -289,12 +285,6 @@
 			}
 
 			<T as Config>::WeightInfo::on_initialize(counter)
-		}
-
-		fn on_runtime_upgrade() -> Weight {
-			<UpgradedToReserves<T>>::kill();
-
-			T::DbWeight::get().reads_writes(0, 1)
 		}
 	}
modifiedpallets/common/CHANGELOG.mddiffbeforeafterboth
before · pallets/common/CHANGELOG.md
1# Change Log23All notable changes to this project will be documented in this file.45<!-- bureaucrate goes here -->67## [0.1.13] - 2023-01-2089### Changed1011- Behavior of the `CommonWeightInfo::create_item` method.1213## [0.1.12] - 2022-11-161415### Changed1617- Behavior of the `setCollectionLimit` method.18  Removed method overload: single signature `(string, uint256)`19  is used for both cases.2021## [0.1.11] - 2022-11-122223### Changed2425- In the `Collection` solidity interface,26  the `allowed` function has been renamed to `allow_listed_cross`.27  Also `EthCrossAccount` type is now used as `user` arg.2829## [0.1.10] - 2022-11-023031### Changed3233- Use named structure `EthCrossAccount` in eth functions.3435## [0.1.9] - 2022-10-133637## Added3839- EVM event for `destroy_collection`.4041## [0.1.8] - 2022-08-244243## Added4445- Eth methods for collection46  - set_collection_sponsor_substrate47  - has_collection_pending_sponsor48  - remove_collection_sponsor49  - get_collection_sponsor50- Add convert function from `uint256` to `CrossAccountId`.5152## [0.1.7] - 2022-08-195354### Added5556- Add convert funtion from `CrossAccountId` to eth `uint256`.5758## [0.1.6] - 2022-08-165960### Added6162- New Ethereum API methods: changeOwner, changeOwner(Substrate) and verifyOwnerOrAdmin(Substrate).6364## [v0.1.5] 2022-08-166566### Other changes6768- build: Upgrade polkadot to v0.9.27 2c498572636f2b34d53b1c51b7283a761a7dc90a6970- build: Upgrade polkadot to v0.9.26 85515e54c4ca1b82a2630034e55dcc804c643bf87172- refactor: Switch to new prefix removal methods 26734e9567589d75cdd99e404eabf11d5a97d9757374New methods allows to call `remove_prefix` with limit multiple times75in the same block76However, we don't use prefix removal limits, so upgrade is77straightforward7879Upstream-Change: https://github.com/paritytech/substrate/pull/114908081- build: Upgrade polkadot to v0.9.25 cdfb9bdc7b205ff1b5134f034ef9973d769e5e6b8283## [0.1.3] - 2022-07-258485### Add8687- Some static property keys and values.8889## [0.1.2] - 2022-07-209091### Fixed9293- Some methods in `#[solidity_interface]` for `CollectionHandle` had invalid94  mutability modifiers, causing invalid stub/abi generation.9596## [0.1.1] - 2022-07-149798### Added99100- Implementation of RPC method `token_owners` returning 10 owners in no particular order.101  This was an internal request to improve the web interface and support fractionalization event.
after · pallets/common/CHANGELOG.md
1# Change Log23All notable changes to this project will be documented in this file.45<!-- bureaucrate goes here -->6## [0.1.14] - 2023-04-1978- ### Fixed910- Useless `on_runtime_upgrade()` has been removed1112## [0.1.13] - 2023-01-201314### Changed1516- Behavior of the `CommonWeightInfo::create_item` method.1718## [0.1.12] - 2022-11-161920### Changed2122- Behavior of the `setCollectionLimit` method.23  Removed method overload: single signature `(string, uint256)`24  is used for both cases.2526## [0.1.11] - 2022-11-122728### Changed2930- In the `Collection` solidity interface,31  the `allowed` function has been renamed to `allow_listed_cross`.32  Also `EthCrossAccount` type is now used as `user` arg.3334## [0.1.10] - 2022-11-023536### Changed3738- Use named structure `EthCrossAccount` in eth functions.3940## [0.1.9] - 2022-10-134142## Added4344- EVM event for `destroy_collection`.4546## [0.1.8] - 2022-08-244748## Added4950- Eth methods for collection51  - set_collection_sponsor_substrate52  - has_collection_pending_sponsor53  - remove_collection_sponsor54  - get_collection_sponsor55- Add convert function from `uint256` to `CrossAccountId`.5657## [0.1.7] - 2022-08-195859### Added6061- Add convert funtion from `CrossAccountId` to eth `uint256`.6263## [0.1.6] - 2022-08-166465### Added6667- New Ethereum API methods: changeOwner, changeOwner(Substrate) and verifyOwnerOrAdmin(Substrate).6869## [v0.1.5] 2022-08-167071### Other changes7273- build: Upgrade polkadot to v0.9.27 2c498572636f2b34d53b1c51b7283a761a7dc90a7475- build: Upgrade polkadot to v0.9.26 85515e54c4ca1b82a2630034e55dcc804c643bf87677- refactor: Switch to new prefix removal methods 26734e9567589d75cdd99e404eabf11d5a97d9757879New methods allows to call `remove_prefix` with limit multiple times80in the same block81However, we don't use prefix removal limits, so upgrade is82straightforward8384Upstream-Change: <https://github.com/paritytech/substrate/pull/11490>8586- build: Upgrade polkadot to v0.9.25 cdfb9bdc7b205ff1b5134f034ef9973d769e5e6b8788## [0.1.3] - 2022-07-258990### Add9192- Some static property keys and values.9394## [0.1.2] - 2022-07-209596### Fixed9798- Some methods in `#[solidity_interface]` for `CollectionHandle` had invalid99  mutability modifiers, causing invalid stub/abi generation.100101## [0.1.1] - 2022-07-14102103### Added104105- Implementation of RPC method `token_owners` returning 10 owners in no particular order.106  This was an internal request to improve the web interface and support fractionalization event.
modifiedpallets/common/Cargo.tomldiffbeforeafterboth
--- a/pallets/common/Cargo.toml
+++ b/pallets/common/Cargo.toml
@@ -2,7 +2,7 @@
 edition = "2021"
 license = "GPLv3"
 name = "pallet-common"
-version = "0.1.13"
+version = "0.1.14"
 
 [dependencies]
 # Note: `package = "parity-scale-codec"` must be supplied since the `Encode` macro searches for it.
modifiedpallets/common/src/lib.rsdiffbeforeafterboth
--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -869,15 +869,6 @@
 		),
 		QueryKind = OptionQuery,
 	>;
-
-	#[pallet::hooks]
-	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {
-		fn on_runtime_upgrade() -> Weight {
-			StorageVersion::new(1).put::<Pallet<T>>();
-
-			Weight::zero()
-		}
-	}
 }
 
 impl<T: Config> Pallet<T> {
modifiedpallets/nonfungible/CHANGELOG.mddiffbeforeafterboth
--- a/pallets/nonfungible/CHANGELOG.md
+++ b/pallets/nonfungible/CHANGELOG.md
@@ -3,7 +3,12 @@
 All notable changes to this project will be documented in this file.
 
 <!-- bureaucrate goes here -->
+## [0.1.14] - 2023-04-19
+
+- ### Fixed
 
+- Useless `on_runtime_upgrade()` has been removed
+
 ## [0.1.13] - 2023-01-20
 
 ### Fixed
@@ -77,7 +82,7 @@
 However, we don't use prefix removal limits, so upgrade is
 straightforward
 
-Upstream-Change: https://github.com/paritytech/substrate/pull/11490
+Upstream-Change: <https://github.com/paritytech/substrate/pull/11490>
 
 - build: Upgrade polkadot to v0.9.25 cdfb9bdc7b205ff1b5134f034ef9973d769e5e6b
modifiedpallets/nonfungible/Cargo.tomldiffbeforeafterboth
--- a/pallets/nonfungible/Cargo.toml
+++ b/pallets/nonfungible/Cargo.toml
@@ -2,7 +2,7 @@
 edition = "2021"
 license = "GPLv3"
 name = "pallet-nonfungible"
-version = "0.1.13"
+version = "0.1.14"
 
 [dependencies]
 # Note: `package = "parity-scale-codec"` must be supplied since the `Encode` macro searches for it.
modifiedpallets/nonfungible/src/lib.rsdiffbeforeafterboth
--- a/pallets/nonfungible/src/lib.rs
+++ b/pallets/nonfungible/src/lib.rs
@@ -281,16 +281,6 @@
 		Value = bool,
 		QueryKind = ValueQuery,
 	>;
-
-	/// Upgrade from the old schema to properties.
-	#[pallet::hooks]
-	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {
-		fn on_runtime_upgrade() -> Weight {
-			StorageVersion::new(1).put::<Pallet<T>>();
-
-			Weight::zero()
-		}
-	}
 }
 
 pub struct NonfungibleHandle<T: Config>(pallet_common::CollectionHandle<T>);