git.delta.rocks / unique-network / refs/commits / 2390e1641b99

difftreelog

Merge pull request #67 from usetech-llc/feature/NFTPAR-257

Greg Zaitsev2021-01-19parents: #567e35d #fdbcd55.patch.diff
in: master
Feature/nftpar 257

6 files changed

modifiedtests/package.jsondiffbeforeafterboth
--- a/tests/package.json
+++ b/tests/package.json
@@ -28,7 +28,8 @@
     "testTransferFrom": "mocha --timeout 9999999 -r ts-node/register ./**/transferFrom.test.ts",
     "testCreateCollection": "mocha --timeout 9999999 -r ts-node/register ./**/createCollection.test.ts",
     "testToggleContractWhiteList": "mocha --timeout 9999999 -r ts-node/register ./**/toggleContractWhiteList.test.ts",
-    "testAddToContractWhiteList": "mocha --timeout 9999999 -r ts-node/register ./**/addToContractWhiteList.test.ts"
+    "testAddToContractWhiteList": "mocha --timeout 9999999 -r ts-node/register ./**/addToContractWhiteList.test.ts",
+    "testTransfer": "mocha --timeout 9999999 -r ts-node/register ./**/transfer.test.ts"
   },
   "author": "",
   "license": "Apache 2.0",
modifiedtests/src/burnItem.test.tsdiffbeforeafterboth
--- a/tests/src/burnItem.test.ts
+++ b/tests/src/burnItem.test.ts
@@ -35,16 +35,16 @@
       const tx = api.tx.nft.burnItem(collectionId, tokenId, 0);
       const events = await submitTransactionAsync(alice, tx);
       const result = getGenericResult(events);
-  
-      // Get the item 
+      // Get the item
       const item: any = (await api.query.nft.nftItemList(collectionId, tokenId)).toJSON();
- 
       // What to expect
+      // tslint:disable-next-line:no-unused-expression
       expect(result.success).to.be.true;
+      // tslint:disable-next-line:no-unused-expression
       expect(item).to.be.not.null;
       expect(item.Owner).to.be.equal(nullPublicKey);
     });
-  
+
   });
   it('Burn item in Fungible collection', async () => {
     const createMode = 'Fungible';
modifiedtests/src/substrate/get-balance.tsdiffbeforeafterboth
--- a/tests/src/substrate/get-balance.ts
+++ b/tests/src/substrate/get-balance.ts
@@ -3,12 +3,12 @@
 // file 'LICENSE', which is part of this source code package.
 //
 
-import { ApiPromise } from "@polkadot/api";
-import promisifySubstrate from "./promisify-substrate";
-import {AccountInfo} from "@polkadot/types/interfaces/system";
+import { ApiPromise } from '@polkadot/api';
+import {AccountInfo} from '@polkadot/types/interfaces/system';
+import promisifySubstrate from './promisify-substrate';
 
-export default async function getBalance(api: ApiPromise, accounts: string[]): Promise<bigint[]> {
-  const balance = promisifySubstrate(api, (accounts: string[]) => api.query.system.account.multi(accounts));
+export default async function getBalance(api: ApiPromise, accounts: string[]): Promise<Array<bigint>> {
+  const balance = promisifySubstrate(api, (acc: string[]) => api.query.system.account.multi(acc));
   const responce = await balance(accounts) as unknown as AccountInfo[];
-  return responce.map(r => r.data.free.toBigInt().valueOf());
+  return responce.map((r) => r.data.free.toBigInt().valueOf());
 }
modifiedtests/src/substrate/substrate-api.tsdiffbeforeafterboth
--- a/tests/src/substrate/substrate-api.ts
+++ b/tests/src/substrate/substrate-api.ts
@@ -58,21 +58,22 @@
   return TransactionStatus.Fail;
 }
 
-export function submitTransactionAsync(sender: IKeyringPair, transaction: SubmittableExtrinsic<ApiTypes>): Promise<EventRecord[]> {
-  return new Promise(async function(resolve, reject) {
+export function
+submitTransactionAsync(sender: IKeyringPair, transaction: SubmittableExtrinsic<ApiTypes>): Promise<EventRecord[]> {
+  return new Promise(async (resolve, reject) => {
     try {
       await transaction.signAndSend(sender, ({ events = [], status }) => {
         const transactionStatus = getTransactionStatus(events, status);
 
-        if (transactionStatus == TransactionStatus.Success) {
+        if (transactionStatus === TransactionStatus.Success) {
           resolve(events);
-        } else if (transactionStatus == TransactionStatus.Fail) {
+        } else if (transactionStatus === TransactionStatus.Fail) {
           console.log(`Something went wrong with transaction. Status: ${status}`);
           reject(events);
         }
       });
     } catch (e) {
-      console.log("Error: ", e);
+      console.log('Error: ', e);
       reject(e);
     }
   });
modifiedtests/src/transfer.test.tsdiffbeforeafterboth
before · tests/src/transfer.test.ts
1//2// This file is subject to the terms and conditions defined in3// file 'LICENSE', which is part of this source code package.4//56import { expect, assert } from "chai";7import { default as usingApi, submitTransactionAsync } from "./substrate/substrate-api";8import { alicesPublicKey, bobsPublicKey, ferdiesPublicKey } from "./accounts";9import privateKey from "./substrate/privateKey";10import getBalance from "./substrate/get-balance";11import { BigNumber } from 'bignumber.js';12import { findUnusedAddress } from './util/helpers'1314describe('Transfer', () => {15  it('Balance transfers', async () => {16    await usingApi(async api => {17      const [alicesBalanceBefore, bobsBalanceBefore] = await getBalance(api, [alicesPublicKey, bobsPublicKey]);1819      const alicePrivateKey = privateKey('//Alice');20      21      const transfer = api.tx.balances.transfer(bobsPublicKey, 1n);22      const result = await submitTransactionAsync(alicePrivateKey, transfer);2324      const [alicesBalanceAfter, bobsBalanceAfter] = await getBalance(api, [alicesPublicKey, bobsPublicKey]);2526      expect(alicesBalanceAfter < alicesBalanceBefore).to.be.true;27      expect(bobsBalanceAfter > bobsBalanceBefore).to.be.true;28    });29  });3031  it('Inability to pay fees error message is correct', async () => {32    await usingApi(async api => {33      // Find unused address34      const pk = await findUnusedAddress(api);3536      const error = console.error;37      const log = console.log;38      console.log = function () {};39      console.error = function () {};40  41      const badTransfer = api.tx.balances.transfer(bobsPublicKey, 1n);42      const badTransaction = async function () { 43        const result = await submitTransactionAsync(pk, badTransfer);44      };45      await expect(badTransaction()).to.be.rejectedWith("Inability to pay some fees");4647      console.log = log;48      console.error = error;49    });50  });51});
after · tests/src/transfer.test.ts
1//2// This file is subject to the terms and conditions defined in3// file 'LICENSE', which is part of this source code package.4//56import { ApiPromise } from '@polkadot/api';7import { IKeyringPair } from '@polkadot/types/types';8import { expect } from 'chai';9import { alicesPublicKey, bobsPublicKey } from './accounts';10import getBalance from './substrate/get-balance';11import privateKey from './substrate/privateKey';12import { default as usingApi, submitTransactionAsync } from './substrate/substrate-api';13import {14  burnItemExpectSuccess, createCollectionExpectSuccess, createItemExpectSuccess,15  destroyCollectionExpectSuccess,16  findUnusedAddress,17  getCreateCollectionResult,18  getCreateItemResult,19  transferExpectFail,20  transferExpectSuccess,21} from './util/helpers';2223let Alice: IKeyringPair;24let Bob: IKeyringPair;25let Charlie: IKeyringPair;2627describe('Integration Test Transfer(recipient, collection_id, item_id, value)', () => {28  it('Balance transfers and check balance', async () => {29    await usingApi(async (api: ApiPromise) => {30      const [alicesBalanceBefore, bobsBalanceBefore] = await getBalance(api, [alicesPublicKey, bobsPublicKey]);3132      const alicePrivateKey = privateKey('//Alice');3334      const transfer = api.tx.balances.transfer(bobsPublicKey, 1n);35      const events = await submitTransactionAsync(alicePrivateKey, transfer);36      const result = getCreateItemResult(events);37      // tslint:disable-next-line:no-unused-expression38      expect(result.success).to.be.true;3940      const [alicesBalanceAfter, bobsBalanceAfter] = await getBalance(api, [alicesPublicKey, bobsPublicKey]);4142      // tslint:disable-next-line:no-unused-expression43      expect(alicesBalanceAfter < alicesBalanceBefore).to.be.true;44      // tslint:disable-next-line:no-unused-expression45      expect(bobsBalanceAfter > bobsBalanceBefore).to.be.true;46    });47  });4849  it('Inability to pay fees error message is correct', async () => {50    await usingApi(async (api) => {51      // Find unused address52      const pk = await findUnusedAddress(api);5354      const badTransfer = api.tx.balances.transfer(bobsPublicKey, 1n);55      // const events = await submitTransactionAsync(pk, badTransfer);56      const badTransaction = async () => {57        const events = await submitTransactionAsync(pk, badTransfer);58        const result = getCreateCollectionResult(events);59        // tslint:disable-next-line:no-unused-expression60        expect(result.success).to.be.false;61      };62      expect(badTransaction()).to.be.rejectedWith('Inability to pay some fees , e.g. account balance too low');63    });64  });6566  it('Create collection, balance transfers and check balance', async () => {67    await usingApi(async (api) => {68      const Alice = privateKey('//Alice');69      const Bob = privateKey('//Bob');70      // nft71      const nftCollectionId = await createCollectionExpectSuccess();72      const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT');73      await transferExpectSuccess(nftCollectionId, newNftTokenId, Alice, Bob, 1, 'NFT');74      // fungible75      const fungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});76      const newFungibleTokenId = await createItemExpectSuccess(Alice, fungibleCollectionId, 'Fungible');77      await transferExpectSuccess(fungibleCollectionId, newFungibleTokenId, Alice, Bob, 1, 'Fungible');78      // reFungible79      const reFungibleCollectionId = await80        createCollectionExpectSuccess({mode: {type: 'ReFungible', decimalPoints: 0}});81      const newReFungibleTokenId = await createItemExpectSuccess(Alice, reFungibleCollectionId, 'ReFungible');82      await transferExpectSuccess(reFungibleCollectionId,83        newReFungibleTokenId, Alice, Bob, 1, 'ReFungible');84    });85  });86});8788describe('Negative Integration Test Transfer(recipient, collection_id, item_id, value)', () => {89  before(async () => {90    await usingApi(async (api: ApiPromise) => {91      Alice = privateKey('//Alice');92      Bob = privateKey('//Bob');93      Charlie = privateKey('//Charlie');94    });95  });96  it('Transfer with not existed collection_id', async () => {97    await usingApi(async (api) => {98      // nft99      const nftCollectionCount = await api.query.nft.createdCollectionCount() as unknown as number;100      await transferExpectFail(nftCollectionCount + 1, 1, Alice, Bob, 1);101      // fungible102      const fungibleCollectionCount = await api.query.nft.createdCollectionCount() as unknown as number;103      await transferExpectFail(fungibleCollectionCount + 1, 1, Alice, Bob, 1);104      // reFungible105      const reFungibleCollectionCount = await api.query.nft.createdCollectionCount() as unknown as number;106      await transferExpectFail(reFungibleCollectionCount + 1, 1, Alice, Bob, 1);107    });108  });109  it('Transfer with deleted collection_id', async () => {110    // nft111    const nftCollectionId = await createCollectionExpectSuccess();112    const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT');113    await destroyCollectionExpectSuccess(nftCollectionId);114    await transferExpectFail(nftCollectionId, newNftTokenId, Alice, Bob, 1, 'NFT');115    // fungible116    const fungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});117    const newFungibleTokenId = await createItemExpectSuccess(Alice, fungibleCollectionId, 'Fungible');118    await destroyCollectionExpectSuccess(fungibleCollectionId);119    await transferExpectFail(fungibleCollectionId, newFungibleTokenId, Alice, Bob, 1, 'Fungible');120    // reFungible121    const reFungibleCollectionId = await122      createCollectionExpectSuccess({mode: {type: 'ReFungible', decimalPoints: 0}});123    const newReFungibleTokenId = await createItemExpectSuccess(Alice, reFungibleCollectionId, 'ReFungible');124    await destroyCollectionExpectSuccess(reFungibleCollectionId);125    await transferExpectFail(reFungibleCollectionId,126      newReFungibleTokenId, Alice, Bob, 1, 'ReFungible');127  });128  it('Transfer with not existed item_id', async () => {129    // nft130    const nftCollectionId = await createCollectionExpectSuccess();131    await transferExpectFail(nftCollectionId, 2, Alice, Bob, 1, 'NFT');132    // fungible133    const fungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});134    await transferExpectFail(fungibleCollectionId, 2, Alice, Bob, 1, 'Fungible');135    // reFungible136    const reFungibleCollectionId = await137      createCollectionExpectSuccess({mode: {type: 'ReFungible', decimalPoints: 0}});138    await transferExpectFail(reFungibleCollectionId,139      2, Alice, Bob, 1, 'ReFungible');140  });141  it('Transfer with deleted item_id', async () => {142    // nft143    const nftCollectionId = await createCollectionExpectSuccess();144    const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT');145    await burnItemExpectSuccess(Alice, nftCollectionId, newNftTokenId, 1);146    await transferExpectFail(nftCollectionId, newNftTokenId, Alice, Bob, 1, 'NFT');147    // fungible148    const fungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});149    const newFungibleTokenId = await createItemExpectSuccess(Alice, fungibleCollectionId, 'Fungible');150    await burnItemExpectSuccess(Alice, fungibleCollectionId, newFungibleTokenId, 10);151    await transferExpectFail(fungibleCollectionId, newFungibleTokenId, Alice, Bob, 1, 'Fungible');152    // reFungible153    const reFungibleCollectionId = await154      createCollectionExpectSuccess({mode: {type: 'ReFungible', decimalPoints: 0}});155    const newReFungibleTokenId = await createItemExpectSuccess(Alice, reFungibleCollectionId, 'ReFungible');156    await burnItemExpectSuccess(Alice, reFungibleCollectionId, newReFungibleTokenId, 1);157    await transferExpectFail(reFungibleCollectionId,158      newReFungibleTokenId, Alice, Bob, 1, 'ReFungible');159  });160  it('Transfer with recipient that is not owner', async () => {161    // nft162    const nftCollectionId = await createCollectionExpectSuccess();163    const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT');164    await transferExpectFail(nftCollectionId, newNftTokenId, Charlie, Bob, 1, 'NFT');165    // fungible166    const fungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}});167    const newFungibleTokenId = await createItemExpectSuccess(Alice, fungibleCollectionId, 'Fungible');168    await transferExpectFail(fungibleCollectionId, newFungibleTokenId, Charlie, Bob, 1, 'Fungible');169    // reFungible170    const reFungibleCollectionId = await171      createCollectionExpectSuccess({mode: {type: 'ReFungible', decimalPoints: 0}});172    const newReFungibleTokenId = await createItemExpectSuccess(Alice, reFungibleCollectionId, 'ReFungible');173    await transferExpectFail(reFungibleCollectionId,174      newReFungibleTokenId, Charlie, Bob, 1, 'ReFungible');175  });176});
modifiedtests/src/util/helpers.tsdiffbeforeafterboth
--- a/tests/src/util/helpers.ts
+++ b/tests/src/util/helpers.ts
@@ -391,6 +391,22 @@
   ReFungible: CreateReFungibleData;
 }
 
+export async function burnItemExpectSuccess(owner: IKeyringPair, collectionId: number, tokenId: number, value = 0) {
+  await usingApi(async (api) => {
+    const tx = api.tx.nft.burnItem(collectionId, tokenId, value);
+    const events = await submitTransactionAsync(owner, tx);
+    const result = getGenericResult(events);
+    // Get the item
+    const item: any = (await api.query.nft.nftItemList(collectionId, tokenId)).toJSON();
+    // What to expect
+    // tslint:disable-next-line:no-unused-expression
+    expect(result.success).to.be.true;
+    // tslint:disable-next-line:no-unused-expression
+    expect(item).to.be.not.null;
+    expect(item.Owner).to.be.equal(nullPublicKey);
+  });
+}
+
 export async function
 approveExpectSuccess(collectionId: number,
                      tokenId: number, owner: IKeyringPair, approved: IKeyringPair, amount: number = 1) {
@@ -462,6 +478,58 @@
 }
 
 export async function
+transferExpectSuccess(collectionId: number,
+                      tokenId: number,
+                      sender: IKeyringPair,
+                      recipient: IKeyringPair,
+                      value: number = 1,
+                      type: string = 'NFT') {
+  await usingApi(async (api: ApiPromise) => {
+    let balanceBefore = new BN(0);
+    if (type === 'Fungible') {
+      balanceBefore = await api.query.nft.balance(collectionId, recipient.address) as unknown as BN;
+    }
+    const transferTx = await api.tx.nft.transfer(recipient.address, collectionId, tokenId, value);
+    const events = await submitTransactionAsync(sender, transferTx);
+    const result = getCreateItemResult(events);
+    // tslint:disable-next-line:no-unused-expression
+    expect(result.success).to.be.true;
+    if (type === 'NFT') {
+      const nftItemData = await api.query.nft.nftItemList(collectionId, tokenId) as unknown as ITokenDataType;
+      expect(nftItemData.Owner.toString()).to.be.equal(recipient.address);
+    }
+    if (type === 'Fungible') {
+      const balanceAfter = await api.query.nft.balance(collectionId, recipient.address) as unknown as BN;
+      expect(balanceAfter.sub(balanceBefore).toNumber()).to.be.equal(value);
+    }
+    if (type === 'ReFungible') {
+      const nftItemData =
+        await api.query.nft.reFungibleItemList(collectionId, tokenId) as unknown as IReFungibleTokenDataType;
+      expect(nftItemData.Owner[0].Owner.toString()).to.be.equal(recipient.address);
+      expect(nftItemData.Owner[0].Fraction.toNumber()).to.be.equal(value);
+    }
+  });
+}
+
+export async function
+transferExpectFail(collectionId: number,
+                   tokenId: number,
+                   sender: IKeyringPair,
+                   recipient: IKeyringPair,
+                   value: number = 1,
+                   type: string = 'NFT') {
+  await usingApi(async (api: ApiPromise) => {
+    const transferTx = await api.tx.nft.transfer(recipient.address, collectionId, tokenId, value);
+    const events = await expect(submitTransactionExpectFailAsync(sender, transferTx)).to.be.rejected;
+    if (events && Array.isArray(events)) {
+      const result = getCreateCollectionResult(events);
+      // tslint:disable-next-line:no-unused-expression
+      expect(result.success).to.be.false;
+    }
+  });
+}
+
+export async function
 approveExpectFail(collectionId: number,
                   tokenId: number, owner: IKeyringPair, approved: IKeyringPair, amount: number = 1) {
   await usingApi(async (api: ApiPromise) => {
@@ -473,7 +541,8 @@
   });
 }
 
-export async function createItemExpectSuccess(sender: IKeyringPair, collectionId: number, createMode: string, owner: string = '') {
+export async function createItemExpectSuccess(
+  sender: IKeyringPair, collectionId: number, createMode: string, owner: string = '') {
   let newItemId: number = 0;
   await usingApi(async (api) => {
     const AItemCount = parseInt((await api.query.nft.itemListIndex(collectionId)).toString(), 10);
@@ -525,6 +594,7 @@
     const collection: any = (await api.query.nft.collection(collectionId)).toJSON();
 
     // What to expect
+    // tslint:disable-next-line:no-unused-expression
     expect(result.success).to.be.true;
     expect(collection.Access).to.be.equal('WhiteList');
   });
@@ -559,6 +629,7 @@
     const collection: any = (await api.query.nft.collection(collectionId)).toJSON();
 
     // What to expect
+    // tslint:disable-next-line:no-unused-expression
     expect(result.success).to.be.true;
     expect(collection.MintMode).to.be.equal(true);
   });