difftreelog
Draft verification has been enabled.
in: master
1 file changed
.github/workflows/forkless-update-nodata.ymldiffbeforeafterboth6767686869 steps:69 steps:70# - name: Skip if pull request is in Draft70 - name: Skip if pull request is in Draft71 # `if: github.event.pull_request.draft == true` should be kept here, at71 # `if: github.event.pull_request.draft == true` should be kept here, at72 # the step level, rather than at the job level. The latter is not72 # the step level, rather than at the job level. The latter is not73 # recommended because when the PR is moved from "Draft" to "Ready to73 # recommended because when the PR is moved from "Draft" to "Ready to74 # review" the workflow will immediately be passing (since it was skipped),74 # review" the workflow will immediately be passing (since it was skipped),75 # even though it hasn't actually ran, since it takes a few seconds for75 # even though it hasn't actually ran, since it takes a few seconds for76 # the workflow to start. This is also disclosed in:76 # the workflow to start. This is also disclosed in:77 # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/1777 # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/1778 # That scenario would open an opportunity for the check to be bypassed:78 # That scenario would open an opportunity for the check to be bypassed:79 # 1. Get your PR approved79 # 1. Get your PR approved80 # 2. Move it to Draft80 # 2. Move it to Draft81 # 3. Push whatever commits you want81 # 3. Push whatever commits you want82 # 4. Move it to "Ready for review"; now the workflow is passing (it was82 # 4. Move it to "Ready for review"; now the workflow is passing (it was83 # skipped) and "Check reviews" is also passing (it won't be updated83 # skipped) and "Check reviews" is also passing (it won't be updated84 # until the workflow is finished)84 # until the workflow is finished)85# if: github.event.pull_request.draft == true85 if: github.event.pull_request.draft == true86# run: exit 186 run: exit 1878788 - name: Clean Workspace88 - name: Clean Workspace89 uses: AutoModality/action-clean@v1.1.089 uses: AutoModality/action-clean@v1.1.0