difftreelog
Fix evm nesting
in: master
1 file changed
tests/src/eth/nesting/nest.test.tsdiffbeforeafterboth1import {ApiPromise} from '@polkadot/api';2import {Contract} from 'web3-eth-contract';3import {expect} from 'chai';4import Web3 from 'web3';5import {createEthAccountWithBalance, evmCollectionHelpers, GAS_ARGS, getCollectionAddressFromResult, itWeb3, tokenIdToAddress} from '../../eth/util/helpers';6import nonFungibleAbi from '../nonFungibleAbi.json';78const createNestingCollection = async (9 api: ApiPromise,10 web3: Web3,11 owner: string,12): Promise<{ collectionId: number, collectionAddress: string, contract: Contract }> => {13 const collectionHelper = evmCollectionHelpers(web3, owner);14 15 const result = await collectionHelper.methods16 .createNonfungibleCollection('A', 'B', 'C')17 .send();18 const {collectionIdAddress: collectionAddress, collectionId} = await getCollectionAddressFromResult(api, result);1920 const contract = new web3.eth.Contract(nonFungibleAbi as any, collectionAddress, {from: owner, ...GAS_ARGS});21 await contract.methods.setCollectionNesting(true).send({from: owner});2223 return {collectionId, collectionAddress, contract};24};2526describe('Integration Test: EVM Nesting', () => {27 itWeb3('NFT: allows an Owner to nest/unnest their token', async ({api, web3, privateKeyWrapper}) => {28 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);29 const {collectionId, contract} = await createNestingCollection(api, web3, owner);3031 // Create a token to be nested32 const nftTokenId = await contract.methods.nextTokenId().call();33 await contract.methods.mint(34 owner,35 nftTokenId,36 ).send({from: owner});3738 // Nest into a token39 const firstTargetNftTokenId = await contract.methods.nextTokenId().call();40 await contract.methods.mint(41 owner,42 firstTargetNftTokenId,43 ).send({from: owner});4445 const targetNftTokenAddress = tokenIdToAddress(collectionId, firstTargetNftTokenId);4647 await contract.methods.transfer(targetNftTokenAddress, nftTokenId).send({from: owner});48 expect(await contract.methods.ownerOf(nftTokenId).call()).to.be.equal(targetNftTokenAddress);4950 // Re-nest into another51 const secondTargetNftTokenId = await contract.methods.nextTokenId().call();52 await contract.methods.mint(53 owner,54 secondTargetNftTokenId,55 ).send({from: owner});56 const nextNftTokenAddress = tokenIdToAddress(collectionId, secondTargetNftTokenId);5758 await contract.methods.transfer(nextNftTokenAddress, nftTokenId).send({from: owner});59 expect(await contract.methods.ownerOf(nftTokenId).call()).to.be.equal(nextNftTokenAddress);60 });6162 itWeb3('NFT: allows an Owner to nest/unnest their token (Restricted nesting)', async ({api, web3, privateKeyWrapper}) => {63 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);6465 const {collectionId: collectionIdA, collectionAddress: collectionAddressA, contract: contractA} = await createNestingCollection(api, web3, owner);66 const {collectionAddress: collectionAddressB, contract: contractB} = await createNestingCollection(api, web3, owner);67 await contractA.methods.setCollectionNesting(true, [collectionAddressA, collectionAddressB]).send({from: owner});6869 // Create a token to nest into70 const targetNftTokenId = await contractA.methods.nextTokenId().call();71 await contractA.methods.mint(72 owner,73 targetNftTokenId,74 ).send({from: owner});75 const nftTokenAddressA1 = tokenIdToAddress(collectionIdA, targetNftTokenId);7677 // Create a token for nesting in the same collection as the target78 const nftTokenIdA = await contractA.methods.nextTokenId().call();79 await contractA.methods.mint(80 owner,81 nftTokenIdA,82 ).send({from: owner});8384 // Create a token for nesting in a different collection85 const nftTokenIdB = await contractB.methods.nextTokenId().call();86 await contractB.methods.mint(87 owner,88 nftTokenIdB,89 ).send({from: owner});9091 // Nest92 await contractA.methods.transfer(nftTokenAddressA1, nftTokenIdA).send({from: owner});93 expect(await contractA.methods.ownerOf(nftTokenIdA).call()).to.be.equal(nftTokenAddressA1);9495 await contractB.methods.transfer(nftTokenAddressA1, nftTokenIdB).send({from: owner});96 expect(await contractB.methods.ownerOf(nftTokenIdB).call()).to.be.equal(nftTokenAddressA1);97 });98});99100describe('Negative Test: EVM Nesting', async() => {101 itWeb3('NFT: disallows to nest token if nesting is disabled', async ({api, web3, privateKeyWrapper}) => {102 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);103104 const {collectionId, contract} = await createNestingCollection(api, web3, owner);105 await contract.methods.setCollectionNesting(false).send({from: owner});106107 // Create a token to nest into108 const targetNftTokenId = await contract.methods.nextTokenId().call();109 await contract.methods.mint(110 owner,111 targetNftTokenId,112 ).send({from: owner});113114 const targetNftTokenAddress = tokenIdToAddress(collectionId, targetNftTokenId);115116 // Create a token to nest117 const nftTokenId = await contract.methods.nextTokenId().call();118 await contract.methods.mint(119 owner,120 nftTokenId,121 ).send({from: owner});122123 // Try to nest124 await expect(contract.methods125 .transfer(targetNftTokenAddress, nftTokenId)126 .call({from: owner})).to.be.rejectedWith('UserIsNotAllowedToNest');127 });128 129 itWeb3('NFT: disallows a non-Owner to nest someone else\'s token', async ({api, web3, privateKeyWrapper}) => {130 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);131 const malignant = await createEthAccountWithBalance(api, web3, privateKeyWrapper);132133 const {collectionId, contract} = await createNestingCollection(api, web3, owner);134135 // Mint a token136 const targetTokenId = await contract.methods.nextTokenId().call();137 await contract.methods.mint(138 owner,139 targetTokenId,140 ).send({from: owner});141 const targetTokenAddress = tokenIdToAddress(collectionId, targetTokenId);142 143 // Mint a token belonging to a different account144 const tokenId = await contract.methods.nextTokenId().call();145 await contract.methods.mint(146 malignant,147 tokenId,148 ).send({from: owner});149 150 // Try to nest one token in another as a non-owner account151 await expect(contract.methods152 .transfer(targetTokenAddress, tokenId)153 .call({from: malignant})).to.be.rejectedWith('UserIsNotAllowedToNest');154 });155 156 itWeb3('NFT: disallows a non-Owner to nest someone else\'s token (Restricted nesting)', async ({api, web3, privateKeyWrapper}) => {157 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);158 const malignant = await createEthAccountWithBalance(api, web3, privateKeyWrapper);159160 const {collectionId: collectionIdA, collectionAddress: collectionAddressA, contract: contractA} = await createNestingCollection(api, web3, owner);161 const {collectionAddress: collectionAddressB, contract: contractB} = await createNestingCollection(api, web3, owner);162163 await contractA.methods.setCollectionNesting(true, [collectionAddressA, collectionAddressB]).send({from: owner});164165 // Create a token in one collection166 const nftTokenIdA = await contractA.methods.nextTokenId().call();167 await contractA.methods.mint(168 owner,169 nftTokenIdA,170 ).send({from: owner});171 const nftTokenAddressA = tokenIdToAddress(collectionIdA, nftTokenIdA);172173 // Create a token in another collection belonging to someone else174 const nftTokenIdB = await contractB.methods.nextTokenId().call();175 await contractB.methods.mint(176 malignant,177 nftTokenIdB,178 ).send({from: owner});179180 // Try to drag someone else's token into the other collection and nest181 await expect(contractB.methods182 .transfer(nftTokenAddressA, nftTokenIdB)183 .call({from: malignant})).to.be.rejectedWith('UserIsNotAllowedToNest');184 });185 186 itWeb3('NFT: disallows to nest token in an unlisted collection', async ({api, web3, privateKeyWrapper}) => {187 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);188189 const {collectionId: collectionIdA, collectionAddress: collectionAddressA, contract: contractA} = await createNestingCollection(api, web3, owner);190 const {contract: contractB} = await createNestingCollection(api, web3, owner);191192 await contractA.methods.setCollectionNesting(true, [collectionAddressA]).send({from: owner});193194 // Create a token in one collection195 const nftTokenIdA = await contractA.methods.nextTokenId().call();196 await contractA.methods.mint(197 owner,198 nftTokenIdA,199 ).send({from: owner});200 const nftTokenAddressA = tokenIdToAddress(collectionIdA, nftTokenIdA);201202 // Create a token in another collection203 const nftTokenIdB = await contractB.methods.nextTokenId().call();204 await contractB.methods.mint(205 owner,206 nftTokenIdB,207 ).send({from: owner});208209 // Try to nest into a token in the other collection, disallowed in the first210 await expect(contractB.methods211 .transfer(nftTokenAddressA, nftTokenIdB)212 .call()).to.be.rejectedWith('SourceCollectionIsNotAllowedToNest');213 });214});1import {ApiPromise} from '@polkadot/api';2import {Contract} from 'web3-eth-contract';3import {expect} from 'chai';4import Web3 from 'web3';5import {createEthAccountWithBalance, evmCollectionHelpers, GAS_ARGS, getCollectionAddressFromResult, itWeb3, tokenIdToAddress} from '../../eth/util/helpers';6import nonFungibleAbi from '../nonFungibleAbi.json';78const createNestingCollection = async (9 api: ApiPromise,10 web3: Web3,11 owner: string,12): Promise<{ collectionId: number, collectionAddress: string, contract: Contract }> => {13 const collectionHelper = evmCollectionHelpers(web3, owner);14 15 const result = await collectionHelper.methods16 .createNonfungibleCollection('A', 'B', 'C')17 .send();18 const {collectionIdAddress: collectionAddress, collectionId} = await getCollectionAddressFromResult(api, result);1920 const contract = new web3.eth.Contract(nonFungibleAbi as any, collectionAddress, {from: owner, ...GAS_ARGS});21 await contract.methods.setCollectionNesting(true).send({from: owner});2223 return {collectionId, collectionAddress, contract};24};2526describe('Integration Test: EVM Nesting', () => {27 itWeb3('NFT: allows an Owner to nest/unnest their token', async ({api, web3, privateKeyWrapper}) => {28 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);29 const {collectionId, contract} = await createNestingCollection(api, web3, owner);3031 // Create a token to be nested32 const targetNFTTokenId = await contract.methods.nextTokenId().call();33 await contract.methods.mint(34 owner,35 targetNFTTokenId,36 ).send({from: owner});3738 const targetNftTokenAddress = tokenIdToAddress(collectionId, targetNFTTokenId);3940 // Create a nested token41 const firstTokenId = await contract.methods.nextTokenId().call();42 await contract.methods.mint(43 targetNftTokenAddress,44 firstTokenId,45 ).send({from: owner});4647 expect(await contract.methods.ownerOf(firstTokenId).call()).to.be.equal(targetNftTokenAddress);4849 // Create a token to be nested and nest50 const secondTokenId = await contract.methods.nextTokenId().call();51 await contract.methods.mint(52 owner,53 secondTokenId,54 ).send({from: owner});5556 await contract.methods.transfer(targetNftTokenAddress, secondTokenId).send({from: owner});5758 expect(await contract.methods.ownerOf(secondTokenId).call()).to.be.equal(targetNftTokenAddress);5960 // Unnest token back61 await contract.methods.transferFrom(targetNftTokenAddress, owner, secondTokenId).send({from: owner});62 expect(await contract.methods.ownerOf(secondTokenId).call()).to.be.equal(owner);63 });6465 itWeb3('NFT: allows an Owner to nest/unnest their token (Restricted nesting)', async ({api, web3, privateKeyWrapper}) => {66 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);6768 const {collectionId: collectionIdA, collectionAddress: collectionAddressA, contract: contractA} = await createNestingCollection(api, web3, owner);69 const {collectionAddress: collectionAddressB, contract: contractB} = await createNestingCollection(api, web3, owner);70 await contractA.methods.setCollectionNesting(true, [collectionAddressA, collectionAddressB]).send({from: owner});7172 // Create a token to nest into73 const targetNftTokenId = await contractA.methods.nextTokenId().call();74 await contractA.methods.mint(75 owner,76 targetNftTokenId,77 ).send({from: owner});78 const nftTokenAddressA1 = tokenIdToAddress(collectionIdA, targetNftTokenId);7980 // Create a token for nesting in the same collection as the target81 const nftTokenIdA = await contractA.methods.nextTokenId().call();82 await contractA.methods.mint(83 owner,84 nftTokenIdA,85 ).send({from: owner});8687 // Create a token for nesting in a different collection88 const nftTokenIdB = await contractB.methods.nextTokenId().call();89 await contractB.methods.mint(90 owner,91 nftTokenIdB,92 ).send({from: owner});9394 // Nest95 await contractA.methods.transfer(nftTokenAddressA1, nftTokenIdA).send({from: owner});96 expect(await contractA.methods.ownerOf(nftTokenIdA).call()).to.be.equal(nftTokenAddressA1);9798 await contractB.methods.transfer(nftTokenAddressA1, nftTokenIdB).send({from: owner});99 expect(await contractB.methods.ownerOf(nftTokenIdB).call()).to.be.equal(nftTokenAddressA1);100 });101});102103describe('Negative Test: EVM Nesting', async() => {104 itWeb3('NFT: disallows to nest token if nesting is disabled', async ({api, web3, privateKeyWrapper}) => {105 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);106107 const {collectionId, contract} = await createNestingCollection(api, web3, owner);108 await contract.methods.setCollectionNesting(false).send({from: owner});109110 // Create a token to nest into111 const targetNftTokenId = await contract.methods.nextTokenId().call();112 await contract.methods.mint(113 owner,114 targetNftTokenId,115 ).send({from: owner});116117 const targetNftTokenAddress = tokenIdToAddress(collectionId, targetNftTokenId);118119 // Create a token to nest120 const nftTokenId = await contract.methods.nextTokenId().call();121 await contract.methods.mint(122 owner,123 nftTokenId,124 ).send({from: owner});125126 // Try to nest127 await expect(contract.methods128 .transfer(targetNftTokenAddress, nftTokenId)129 .call({from: owner})).to.be.rejectedWith('UserIsNotAllowedToNest');130 });131132 itWeb3('NFT: disallows a non-Owner to nest someone else\'s token', async ({api, web3, privateKeyWrapper}) => {133 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);134 const malignant = await createEthAccountWithBalance(api, web3, privateKeyWrapper);135136 const {collectionId, contract} = await createNestingCollection(api, web3, owner);137138 // Mint a token139 const targetTokenId = await contract.methods.nextTokenId().call();140 await contract.methods.mint(141 owner,142 targetTokenId,143 ).send({from: owner});144 const targetTokenAddress = tokenIdToAddress(collectionId, targetTokenId);145146 // Mint a token belonging to a different account147 const tokenId = await contract.methods.nextTokenId().call();148 await contract.methods.mint(149 malignant,150 tokenId,151 ).send({from: owner});152153 // Try to nest one token in another as a non-owner account154 await expect(contract.methods155 .transfer(targetTokenAddress, tokenId)156 .call({from: malignant})).to.be.rejectedWith('UserIsNotAllowedToNest');157 });158159 itWeb3('NFT: disallows a non-Owner to nest someone else\'s token (Restricted nesting)', async ({api, web3, privateKeyWrapper}) => {160 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);161 const malignant = await createEthAccountWithBalance(api, web3, privateKeyWrapper);162163 const {collectionId: collectionIdA, collectionAddress: collectionAddressA, contract: contractA} = await createNestingCollection(api, web3, owner);164 const {collectionAddress: collectionAddressB, contract: contractB} = await createNestingCollection(api, web3, owner);165166 await contractA.methods.setCollectionNesting(true, [collectionAddressA, collectionAddressB]).send({from: owner});167168 // Create a token in one collection169 const nftTokenIdA = await contractA.methods.nextTokenId().call();170 await contractA.methods.mint(171 owner,172 nftTokenIdA,173 ).send({from: owner});174 const nftTokenAddressA = tokenIdToAddress(collectionIdA, nftTokenIdA);175176 // Create a token in another collection belonging to someone else177 const nftTokenIdB = await contractB.methods.nextTokenId().call();178 await contractB.methods.mint(179 malignant,180 nftTokenIdB,181 ).send({from: owner});182183 // Try to drag someone else's token into the other collection and nest184 await expect(contractB.methods185 .transfer(nftTokenAddressA, nftTokenIdB)186 .call({from: malignant})).to.be.rejectedWith('UserIsNotAllowedToNest');187 });188189 itWeb3('NFT: disallows to nest token in an unlisted collection', async ({api, web3, privateKeyWrapper}) => {190 const owner = await createEthAccountWithBalance(api, web3, privateKeyWrapper);191192 const {collectionId: collectionIdA, collectionAddress: collectionAddressA, contract: contractA} = await createNestingCollection(api, web3, owner);193 const {contract: contractB} = await createNestingCollection(api, web3, owner);194195 await contractA.methods.setCollectionNesting(true, [collectionAddressA]).send({from: owner});196197 // Create a token in one collection198 const nftTokenIdA = await contractA.methods.nextTokenId().call();199 await contractA.methods.mint(200 owner,201 nftTokenIdA,202 ).send({from: owner});203 const nftTokenAddressA = tokenIdToAddress(collectionIdA, nftTokenIdA);204205 // Create a token in another collection206 const nftTokenIdB = await contractB.methods.nextTokenId().call();207 await contractB.methods.mint(208 owner,209 nftTokenIdB,210 ).send({from: owner});211212 // Try to nest into a token in the other collection, disallowed in the first213 await expect(contractB.methods214 .transfer(nftTokenAddressA, nftTokenIdB)215 .call()).to.be.rejectedWith('SourceCollectionIsNotAllowedToNest');216 });217});