difftreelog
Temporary enable running tests ub a DRAFT mode
in: master
1 file changed
.github/workflows/forkless-update-nodata.ymldiffbeforeafterboth5252535354 steps:54 steps:55 - name: Skip if pull request is in Draft55# - name: Skip if pull request is in Draft56 # `if: github.event.pull_request.draft == true` should be kept here, at56 # `if: github.event.pull_request.draft == true` should be kept here, at57 # the step level, rather than at the job level. The latter is not57 # the step level, rather than at the job level. The latter is not58 # recommended because when the PR is moved from "Draft" to "Ready to58 # recommended because when the PR is moved from "Draft" to "Ready to59 # review" the workflow will immediately be passing (since it was skipped),59 # review" the workflow will immediately be passing (since it was skipped),60 # even though it hasn't actually ran, since it takes a few seconds for60 # even though it hasn't actually ran, since it takes a few seconds for61 # the workflow to start. This is also disclosed in:61 # the workflow to start. This is also disclosed in:62 # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/1762 # https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/1763 # That scenario would open an opportunity for the check to be bypassed:63 # That scenario would open an opportunity for the check to be bypassed:64 # 1. Get your PR approved64 # 1. Get your PR approved65 # 2. Move it to Draft65 # 2. Move it to Draft66 # 3. Push whatever commits you want66 # 3. Push whatever commits you want67 # 4. Move it to "Ready for review"; now the workflow is passing (it was67 # 4. Move it to "Ready for review"; now the workflow is passing (it was68 # skipped) and "Check reviews" is also passing (it won't be updated68 # skipped) and "Check reviews" is also passing (it won't be updated69 # until the workflow is finished)69 # until the workflow is finished)70 if: github.event.pull_request.draft == true70# if: github.event.pull_request.draft == true71 run: exit 171# run: exit 1727273 # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it73 # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it74 - uses: actions/checkout@v374 - uses: actions/checkout@v375 with:75 with:76 ref: ${{ github.head_ref }} #Checking out head commit76 ref: ${{ github.head_ref }} #Checking out head commit