git.delta.rocks / remowt / refs/commits / 2499daa8100a

difftreelog

feat enum prompt variant

wnlysuptYaroslav Bolyukin2024-08-05parent: #7c2fb57.patch.diff
in: trunk

11 files changed

modifiedCargo.lockdiffbeforeafterboth
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -351,9 +351,9 @@
 
 [[package]]
 name = "clap"
-version = "4.5.11"
+version = "4.5.13"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "35723e6a11662c2afb578bcf0b88bf6ea8e21282a953428f240574fcc3a2b5b3"
+checksum = "0fbb260a053428790f3de475e304ff84cdbc4face759ea7a3e64c1edd938a7fc"
 dependencies = [
  "clap_builder",
  "clap_derive",
@@ -361,9 +361,9 @@
 
 [[package]]
 name = "clap_builder"
-version = "4.5.11"
+version = "4.5.13"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "49eb96cbfa7cfa35017b7cd548c75b14c3118c98b423041d70562665e07fb0fa"
+checksum = "64b17d7ea74e9f833c7dbf2cbe4fb12ff26783eda4782a8975b72f895c9b4d99"
 dependencies = [
  "anstream",
  "anstyle",
@@ -373,9 +373,9 @@
 
 [[package]]
 name = "clap_derive"
-version = "4.5.11"
+version = "4.5.13"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5d029b67f89d30bbb547c89fd5161293c0aec155fc691d7924b64550662db93e"
+checksum = "501d359d5f3dcaf6ecdeee48833ae73ec6e42723a1e52419c79abf9507eec0a0"
 dependencies = [
  "heck",
  "proc-macro2",
@@ -863,24 +863,6 @@
 ]
 
 [[package]]
-name = "polkit-agent"
-version = "0.1.0"
-dependencies = [
- "anyhow",
- "pam-client",
- "polkit-shared",
- "rand",
- "serde",
- "tokio",
- "tracing",
- "tracing-subscriber",
- "ui-prompt",
- "uuid",
- "zbus",
- "zbus_polkit",
-]
-
-[[package]]
 name = "polkit-backend"
 version = "0.1.0"
 dependencies = [
@@ -1013,6 +995,29 @@
 checksum = "7a66a03ae7c801facd77a29370b4faec201768915ac14a721ba36f20bc9c209b"
 
 [[package]]
+name = "remowt-agent"
+version = "0.1.0"
+dependencies = [
+ "anyhow",
+ "clap",
+ "pam-client",
+ "polkit-shared",
+ "rand",
+ "serde",
+ "tokio",
+ "tracing",
+ "tracing-subscriber",
+ "ui-prompt",
+ "uuid",
+ "zbus",
+ "zbus_polkit",
+]
+
+[[package]]
+name = "remowt-ssh"
+version = "0.1.0"
+
+[[package]]
 name = "rpassword"
 version = "6.0.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
modifiedCargo.tomldiffbeforeafterboth
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,3 +1,7 @@
 [workspace]
 members = ["cmds/*", "crates/*"]
 resolver = "2"
+
+[workspace.packages]
+bifrostlink = { path = "../bifrostlink/crates/bifrostlink" }
+bifrostlink-ports = { path = "../bifrostlink/crates/bifrostlink-ports" }
deletedcmds/polkit-agent/Cargo.tomldiffbeforeafterboth
--- a/cmds/polkit-agent/Cargo.toml
+++ /dev/null
@@ -1,18 +0,0 @@
-[package]
-name = "polkit-agent"
-version = "0.1.0"
-edition = "2021"
-
-[dependencies]
-anyhow = "1.0.86"
-pam-client = "0.5.0"
-polkit-shared = { version = "0.1.0", path = "../../crates/polkit-shared" }
-rand = "0.8.5"
-serde = { version = "1.0.204", features = ["derive"] }
-tokio = { version = "1.39.2", features = ["rt-multi-thread", "fs", "macros"] }
-tracing = "0.1.40"
-tracing-subscriber = "0.3.18"
-ui-prompt = { version = "0.1.0", path = "../../crates/ui-prompt" }
-uuid = { version = "1.10.0", features = ["v4"] }
-zbus = { version = "4.4.0", features = ["tokio"] }
-zbus_polkit = { version = "4.0.0", features = ["tokio"] }
deletedcmds/polkit-agent/src/main.rsdiffbeforeafterboth
--- a/cmds/polkit-agent/src/main.rs
+++ /dev/null
@@ -1,177 +0,0 @@
-use std::collections::HashMap;
-use std::future;
-use std::marker::PhantomData;
-use std::sync::{Mutex, RwLock};
-
-use polkit_shared::{BackendRequest, Identity};
-use tokio::runtime::Handle;
-use tokio::task::{AbortHandle, JoinHandle, LocalSet};
-use tracing::trace;
-use ui_prompt::dbus::DbusPrompterInterface;
-use ui_prompt::rofi::RofiPrompter;
-use ui_prompt::Prompter;
-use zbus::zvariant::{OwnedValue, Str};
-use zbus::ObjectServer;
-use zbus::{interface, proxy, Connection};
-use zbus_polkit::policykit1::Subject;
-
-struct TemporaryPrompterInterface<P: Prompter + Send + Sync + 'static> {
-    connection: Connection,
-    path: String,
-    _marker: PhantomData<P>,
-}
-impl<P: Prompter + Send + Sync + 'static> TemporaryPrompterInterface<P> {
-    async fn new(connection: Connection, prompter: P) -> Self {
-        let path = format!(
-            "/remowt/prompters/{}",
-            uuid::Uuid::new_v4().to_string().replace("-", "_")
-        );
-        let _ = connection
-            .object_server()
-            .at(path.clone(), DbusPrompterInterface(prompter))
-            .await;
-        Self {
-            connection,
-            path,
-            _marker: PhantomData,
-        }
-    }
-}
-impl<P: Prompter + Send + Sync + 'static> Drop for TemporaryPrompterInterface<P> {
-    fn drop(&mut self) {
-        // FIXME: block_in_place prevents to moving to current_thread runtime
-        // There should be a blocking way to remove ObjectServer listener.
-        // As far as I can see, it is only async because of async RwLock, shouldn't it be
-        // just a sync lock?
-        tokio::task::block_in_place(move || {
-            Handle::current().block_on(async {
-                let _ = self
-                    .connection
-                    .object_server()
-                    .remove::<DbusPrompterInterface<P>, String>(self.path.clone())
-                    .await;
-            });
-        });
-    }
-}
-
-struct Agent {
-    helper: PolkitHelperProxy<'static>,
-    tasks: Mutex<HashMap<String, AbortHandle>>,
-    connection: Connection,
-}
-impl Agent {
-    async fn new(connection: Connection) -> anyhow::Result<Self> {
-        Ok(Self {
-            helper: PolkitHelperProxy::new(&connection).await?,
-            tasks: Mutex::new(HashMap::new()),
-            connection,
-        })
-    }
-}
-
-#[interface(name = "org.freedesktop.PolicyKit1.AuthenticationAgent")]
-impl Agent {
-    /// BeginAuthentication method
-    #[allow(clippy::too_many_arguments)]
-    async fn begin_authentication(
-        &mut self,
-        action_id: String,
-        message: String,
-        icon_name: String,
-        details: HashMap<String, String>,
-        cookie: String,
-        identities: Vec<Identity>,
-    ) -> zbus::fdo::Result<()> {
-        trace!("begin auth");
-        let task = {
-            let connection = self.connection.clone();
-            let helper = self.helper.clone();
-            let cookie = cookie.clone();
-            tokio::task::spawn(async move {
-                trace!("conversation task");
-                let prompter = TemporaryPrompterInterface::new(connection, RofiPrompter).await;
-                helper
-                    .init_conversation(
-                        BackendRequest {
-                            cookie: cookie.to_owned(),
-                            environment: HashMap::new(),
-                            prompter_path: prompter.path.clone(),
-                            // TODO: Let user choose
-                            identity: identities.get(0).expect("first always exists").clone(),
-                        }, // cookie.to_owned(), HashMap::new(), prompter.path.clone()
-                    )
-                    .await?;
-                println!("ASKED");
-                dbg!(action_id, message, icon_name, details, cookie, identities);
-
-                Ok(())
-            })
-        };
-
-        self.tasks
-            .lock()
-            .unwrap()
-            .insert(cookie.clone(), task.abort_handle());
-        let result = task.await.expect("join error");
-        // The only way to no reach this line, is to either panic in previous line, or if authorization cancelled,
-        // while cancellation will remove task by itself.
-        // TODO: But still it would be better to have abort guard, which will remove it from HashMap
-        self.tasks.lock().unwrap().remove(&cookie);
-
-        result
-    }
-
-    /// CancelAuthentication method
-    async fn cancel_authentication(&self, cookie: &str) -> zbus::fdo::Result<()> {
-        trace!("cancel auth");
-        if let Some(abort) = self.tasks.lock().unwrap().remove(cookie) {
-            abort.abort();
-        }
-        // debug!("Authentication cancled ! {cookie}");
-        Ok(())
-    }
-}
-
-const OBJ_PATH: &str = "/0lach/polkitAgent";
-#[tokio::main]
-async fn main() -> anyhow::Result<()> {
-    tracing_subscriber::fmt::init();
-
-    trace!("started");
-    let conn = Connection::system().await?;
-
-    let proxy = zbus_polkit::policykit1::AuthorityProxy::new(&conn).await?;
-    conn.object_server()
-        .at(OBJ_PATH, Agent::new(conn.clone()).await?)
-        .await?;
-
-    let session_id = std::env::var("XDG_SESSION_ID")?;
-    let mut details = HashMap::new();
-    let val: OwnedValue = {
-        let wrapped: Str<'_> = session_id.into();
-        wrapped.into()
-    };
-    details.insert("session-id".to_string(), val);
-    proxy
-        .register_authentication_agent(
-            &Subject {
-                subject_kind: "unix-session".to_string(),
-                subject_details: details,
-            },
-            "C",
-            OBJ_PATH,
-        )
-        .await?;
-
-    future::pending().await
-}
-
-#[proxy(
-    interface = "lach.PolkitHelper",
-    default_service = "lach.polkit.helper1",
-    default_path = "/lach/PolkitHelper"
-)]
-trait PolkitHelper {
-    fn init_conversation(&self, request: BackendRequest) -> zbus::Result<()>;
-}
addedcmds/remowt-agent/Cargo.tomldiffbeforeafterboth
--- /dev/null
+++ b/cmds/remowt-agent/Cargo.toml
@@ -0,0 +1,19 @@
+[package]
+name = "remowt-agent"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]
+anyhow = "1.0.86"
+clap = { version = "4.5.13", features = ["derive"] }
+pam-client = "0.5.0"
+polkit-shared = { version = "0.1.0", path = "../../crates/polkit-shared" }
+rand = "0.8.5"
+serde = { version = "1.0.204", features = ["derive"] }
+tokio = { version = "1.39.2", features = ["rt-multi-thread", "fs", "macros"] }
+tracing = "0.1.40"
+tracing-subscriber = "0.3.18"
+ui-prompt = { version = "0.1.0", path = "../../crates/ui-prompt" }
+uuid = { version = "1.10.0", features = ["v4"] }
+zbus = { version = "4.4.0", features = ["tokio"] }
+zbus_polkit = { version = "4.0.0", features = ["tokio"] }
addedcmds/remowt-agent/src/main.rsdiffbeforeafterboth
--- /dev/null
+++ b/cmds/remowt-agent/src/main.rs
@@ -0,0 +1,197 @@
+use std::collections::HashMap;
+use std::io::{stdout, Write};
+use std::marker::PhantomData;
+use std::sync::{Mutex, RwLock};
+use std::{future, process};
+
+use clap::Parser;
+use polkit_shared::{BackendRequest, Identity};
+use tokio::runtime::Handle;
+use tokio::task::{AbortHandle, JoinHandle, LocalSet};
+use tracing::trace;
+use ui_prompt::dbus::DbusPrompterInterface;
+use ui_prompt::rofi::RofiPrompter;
+use ui_prompt::Prompter;
+use zbus::zvariant::{OwnedValue, Str};
+use zbus::ObjectServer;
+use zbus::{interface, proxy, Connection};
+use zbus_polkit::policykit1::Subject;
+
+struct TemporaryPrompterInterface<P: Prompter + Send + Sync + 'static> {
+    connection: Connection,
+    path: String,
+    _marker: PhantomData<P>,
+}
+impl<P: Prompter + Send + Sync + 'static> TemporaryPrompterInterface<P> {
+    async fn new(connection: Connection, prompter: P) -> Self {
+        let path = format!(
+            "/remowt/prompters/{}",
+            uuid::Uuid::new_v4().to_string().replace("-", "_")
+        );
+        let _ = connection
+            .object_server()
+            .at(path.clone(), DbusPrompterInterface(prompter))
+            .await;
+        Self {
+            connection,
+            path,
+            _marker: PhantomData,
+        }
+    }
+}
+impl<P: Prompter + Send + Sync + 'static> Drop for TemporaryPrompterInterface<P> {
+    fn drop(&mut self) {
+        // FIXME: block_in_place prevents to moving to current_thread runtime
+        // There should be a blocking way to remove ObjectServer listener.
+        // As far as I can see, it is only async because of async RwLock, shouldn't it be
+        // just a sync lock?
+        tokio::task::block_in_place(move || {
+            Handle::current().block_on(async {
+                let _ = self
+                    .connection
+                    .object_server()
+                    .remove::<DbusPrompterInterface<P>, String>(self.path.clone())
+                    .await;
+            });
+        });
+    }
+}
+
+struct Agent {
+    helper: PolkitHelperProxy<'static>,
+    tasks: Mutex<HashMap<String, AbortHandle>>,
+    connection: Connection,
+}
+impl Agent {
+    async fn new(connection: Connection) -> anyhow::Result<Self> {
+        Ok(Self {
+            helper: PolkitHelperProxy::new(&connection).await?,
+            tasks: Mutex::new(HashMap::new()),
+            connection,
+        })
+    }
+}
+
+#[interface(name = "org.freedesktop.PolicyKit1.AuthenticationAgent")]
+impl Agent {
+    /// BeginAuthentication method
+    #[allow(clippy::too_many_arguments)]
+    async fn begin_authentication(
+        &mut self,
+        action_id: String,
+        message: String,
+        icon_name: String,
+        details: HashMap<String, String>,
+        cookie: String,
+        identities: Vec<Identity>,
+    ) -> zbus::fdo::Result<()> {
+        trace!("begin auth");
+        let task = {
+            let connection = self.connection.clone();
+            let helper = self.helper.clone();
+            let cookie = cookie.clone();
+            tokio::task::spawn(async move {
+                trace!("conversation task");
+                let prompter = TemporaryPrompterInterface::new(connection, RofiPrompter).await;
+                helper
+                    .init_conversation(
+                        BackendRequest {
+                            cookie: cookie.to_owned(),
+                            environment: HashMap::new(),
+                            prompter_path: prompter.path.clone(),
+                            // TODO: Let user choose
+                            identity: identities.get(0).expect("first always exists").clone(),
+                        }, // cookie.to_owned(), HashMap::new(), prompter.path.clone()
+                    )
+                    .await?;
+                println!("ASKED");
+                dbg!(action_id, message, icon_name, details, cookie, identities);
+
+                Ok(())
+            })
+        };
+
+        self.tasks
+            .lock()
+            .unwrap()
+            .insert(cookie.clone(), task.abort_handle());
+        let result = task.await.expect("join error");
+        // The only way to no reach this line, is to either panic in previous line, or if authorization cancelled,
+        // while cancellation will remove task by itself.
+        // TODO: But still it would be better to have abort guard, which will remove it from HashMap
+        self.tasks.lock().unwrap().remove(&cookie);
+
+        result
+    }
+
+    /// CancelAuthentication method
+    async fn cancel_authentication(&self, cookie: &str) -> zbus::fdo::Result<()> {
+        trace!("cancel auth");
+        if let Some(abort) = self.tasks.lock().unwrap().remove(cookie) {
+            abort.abort();
+        }
+        // debug!("Authentication cancled ! {cookie}");
+        Ok(())
+    }
+}
+
+const OBJ_PATH: &str = "/0lach/polkitAgent";
+
+#[proxy(
+    interface = "lach.PolkitHelper",
+    default_service = "lach.polkit.helper1",
+    default_path = "/lach/PolkitHelper"
+)]
+trait PolkitHelper {
+    fn init_conversation(&self, request: BackendRequest) -> zbus::Result<()>;
+}
+
+#[derive(Parser)]
+enum Opts {
+    Agent,
+    AskPass { description: String },
+}
+
+#[tokio::main]
+async fn main() -> anyhow::Result<()> {
+    tracing_subscriber::fmt::init();
+    let opts = Opts::parse();
+
+    match opts {
+        Opts::Agent => {
+            trace!("started");
+            let conn = Connection::system().await?;
+
+            let proxy = zbus_polkit::policykit1::AuthorityProxy::new(&conn).await?;
+            conn.object_server()
+                .at(OBJ_PATH, Agent::new(conn.clone()).await?)
+                .await?;
+
+            let session_id = std::env::var("XDG_SESSION_ID")?;
+            let mut details = HashMap::new();
+            let val: OwnedValue = {
+                let wrapped: Str<'_> = session_id.into();
+                wrapped.into()
+            };
+            details.insert("session-id".to_string(), val);
+            proxy
+                .register_authentication_agent(
+                    &Subject {
+                        subject_kind: "unix-session".to_string(),
+                        subject_details: details,
+                    },
+                    "C",
+                    OBJ_PATH,
+                )
+                .await?;
+        }
+        Opts::AskPass { description } => {
+            let password = RofiPrompter
+                .prompt_text(false, &description, "SSH password request", &[])
+                .await?;
+            stdout().lock().write_all(password.as_bytes())?;
+        }
+    }
+
+    future::pending().await
+}
addedcmds/remowt-ssh/Cargo.tomldiffbeforeafterboth
--- /dev/null
+++ b/cmds/remowt-ssh/Cargo.toml
@@ -0,0 +1,6 @@
+[package]
+name = "remowt-ssh"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]
addedcmds/remowt-ssh/src/main.rsdiffbeforeafterboth
--- /dev/null
+++ b/cmds/remowt-ssh/src/main.rs
@@ -0,0 +1,3 @@
+fn main() {
+    println!("Hello, world!");
+}
modifiedcrates/ui-prompt/src/dbus.rsdiffbeforeafterboth
--- a/crates/ui-prompt/src/dbus.rs
+++ b/crates/ui-prompt/src/dbus.rs
@@ -40,12 +40,13 @@
 
 #[proxy(interface = "lach.PolkitInputHandler")]
 trait DbusPrompter {
-    async fn prompt_radio(
+    async fn prompt_enum(
         &self,
         prompt: &str,
         description: &str,
+        variants: &[&str],
         source: &[Source],
-    ) -> fdo::Result<bool>;
+    ) -> fdo::Result<u32>;
     async fn prompt_text(
         &self,
         echo: bool,
@@ -62,13 +63,16 @@
 }
 
 impl Prompter for DbusPrompterProxy<'_> {
-    async fn prompt_radio(
+    async fn prompt_enum(
         &self,
         prompt: &str,
         description: &str,
+        variants: &[&str],
         source: &[Source],
-    ) -> Result<bool> {
-        Ok(self.prompt_radio(prompt, description, source).await?)
+    ) -> Result<u32> {
+        Ok(self
+            .prompt_enum(prompt, description, variants, source)
+            .await?)
     }
 
     async fn prompt_text(
@@ -86,8 +90,14 @@
     }
 }
 impl BlockingPrompter for DbusPrompterProxyBlocking<'_> {
-    fn prompt_radio(&self, prompt: &str, description: &str, source: &[Source]) -> Result<bool> {
-        Ok(self.prompt_radio(prompt, description, source)?)
+    fn prompt_enum(
+        &self,
+        prompt: &str,
+        description: &str,
+        variants: &[&str],
+        source: &[Source],
+    ) -> Result<u32> {
+        Ok(self.prompt_enum(prompt, description, variants, source)?)
     }
 
     fn prompt_text(
modifiedcrates/ui-prompt/src/lib.rsdiffbeforeafterboth
--- a/crates/ui-prompt/src/lib.rs
+++ b/crates/ui-prompt/src/lib.rs
@@ -31,7 +31,17 @@
         prompt: &str,
         description: &str,
         source: &[Source],
-    ) -> impl Future<Output = Result<bool>> + Send;
+    ) -> impl Future<Output = Result<bool>> + Send {
+        let fut = self.prompt_enum(prompt, description, &["No", "Yes"], source);
+        async { fut.await.map(|v| v == 1) }
+    }
+    fn prompt_enum(
+        &self,
+        prompt: &str,
+        description: &str,
+        variants: &[&str],
+        source: &[Source],
+    ) -> impl Future<Output = Result<u32>> + Send;
     fn prompt_text(
         &self,
         echo: bool,
@@ -47,7 +57,17 @@
     ) -> impl Future<Output = Result<()>> + Send;
 }
 pub trait BlockingPrompter {
-    fn prompt_radio(&self, prompt: &str, description: &str, source: &[Source]) -> Result<bool>;
+    fn prompt_radio(&self, prompt: &str, description: &str, source: &[Source]) -> Result<bool> {
+        self.prompt_enum(prompt, description, &["No", "Yes"], source)
+            .map(|v| v == 1)
+    }
+    fn prompt_enum(
+        &self,
+        prompt: &str,
+        description: &str,
+        variants: &[&str],
+        source: &[Source],
+    ) -> Result<u32>;
     fn prompt_text(
         &self,
         echo: bool,
@@ -73,14 +93,15 @@
 where
     P: Prompter + Sync,
 {
-    async fn prompt_radio(
+    async fn prompt_enum(
         &self,
         prompt: &str,
         description: &str,
+        variants: &[&str],
         source: &[Source],
-    ) -> Result<bool> {
+    ) -> Result<u32> {
         self.prompter
-            .prompt_radio(prompt, description, &self.source(source))
+            .prompt_enum(prompt, description, variants, &self.source(source))
             .await
     }
 
modifiedcrates/ui-prompt/src/rofi.rsdiffbeforeafterboth
88
9pub struct RofiPrompter;9pub struct RofiPrompter;
10
11fn fixup_prompt(prompt: &str) -> &str {
12 // Rofi always appends such suffix
13 prompt.strip_suffix(": ").unwrap_or(prompt)
14}
1015
11impl Prompter for RofiPrompter {16impl Prompter for RofiPrompter {
12 async fn prompt_radio(17 async fn prompt_enum(
13 &self,18 &self,
14 prompt: &str,19 prompt: &str,
15 description: &str,20 description: &str,
21 variants: &[&str],
16 source: &[Source],22 source: &[Source],
17 ) -> Result<bool> {23 ) -> Result<u32> {
18 trace!("rofi radio");24 trace!("rofi radio");
19 let mut cmd = Command::new("rofi");25 let mut cmd = Command::new("rofi");
20 let mesg = if source.is_empty() {26 let mesg = if source.is_empty() {
34 "-sync",40 "-sync",
35 "-only-match",41 "-only-match",
36 "-p",42 "-p",
37 prompt,43 fixup_prompt(prompt),
44 "-format",
45 "i",
38 ]);46 ]);
39 cmd.stdin(Stdio::piped());47 cmd.stdin(Stdio::piped());
40 cmd.stdout(Stdio::piped());48 cmd.stdout(Stdio::piped());
43 .spawn()51 .spawn()
44 .map_err(|e| Error::InputError(format!("failed to spawn rofi: {e}")))?;52 .map_err(|e| Error::InputError(format!("failed to spawn rofi: {e}")))?;
4553
46 child54 let mut stdin = child.stdin.take().expect("stdin is piped");
47 .stdin55 for var in variants {
48 .take()56 stdin
49 .expect("stdin is piped")57 .write_all(var.replace('\n', " ").as_bytes())
58 .await
59 .map_err(|e| Error::InputError(format!("failed to write rofi variants: {e}")))?;
60 stdin
50 .write_all(b"Yes\nNo\n")61 .write_all(b"\n")
51 .await62 .await
52 .map_err(|e| Error::InputError(format!("failed to write rofi variants: {e}")))?;63 .map_err(|e| Error::InputError(format!("failed to write rofi variants: {e}")))?;
64 }
65 // write_all already flushes, just to be sure.
66 let _ = stdin.flush().await;
67 drop(stdin);
5368
54 let out = child69 let out = child
55 .wait_with_output()70 .wait_with_output()
61 .unwrap_or(&out.stdout)76 .unwrap_or(&out.stdout)
62 .to_owned();77 .to_owned();
6378
79 let id: u32 = String::from_utf8(stdout)
80 .map_err(|e| Error::InputError(format!("rofi produced invalid output: {e}")))?
81 .parse()
82 .map_err(|e| Error::InputError(format!("rofi produced invalid output: {e}")))?;
64 if &stdout == b"Yes" {83 if id as usize >= variants.len() {
65 Ok(true)
66 } else if &stdout == b"No" {
67 Ok(false)
68 } else {
69 Err(Error::InputError("bad rofi response".to_owned()))84 return Err(Error::InputError("invalid rofi response".to_owned()));
70 }85 }
86
87 Ok(id)
71 }88 }
7289
73 async fn prompt_text(90 async fn prompt_text(
89 out.push_str("</b>");106 out.push_str("</b>");
90 out107 out
91 };108 };
92 cmd.args(["-dmenu", "-mesg", &mesg, "-p", prompt]);109 cmd.args(["-dmenu", "-mesg", &mesg, "-p", fixup_prompt(prompt)]);
93 if !echo {110 if !echo {
94 cmd.arg("-password");111 cmd.arg("-password");
95 }112 }