difftreelog
refactor drop unnecessary async/await
in: trunk
15 files changed
cmds/fleet/src/cmds/build_systems.rsdiffbeforeafterboth--- a/cmds/fleet/src/cmds/build_systems.rs
+++ b/cmds/fleet/src/cmds/build_systems.rs
@@ -30,9 +30,9 @@
async fn build_task(config: Config, hostname: String, build_attr: &str) -> Result<PathBuf> {
info!("building");
- let host = config.host(&hostname).await?;
+ let host = config.host(&hostname)?;
// let action = Action::from(self.subcommand.clone());
- let nixos = host.nixos_config().await?;
+ let nixos = host.nixos_config()?;
let drv = nix_go!(nixos.system.build[{ build_attr }]);
let out_output = spawn_blocking(move || drv.build("out"))
.await
@@ -59,7 +59,7 @@
impl BuildSystems {
pub async fn run(self, config: &Config, opts: &FleetOpts) -> Result<()> {
- let hosts = opts.filter_skipped(config.list_hosts().await?).await?;
+ let hosts = opts.filter_skipped(config.list_hosts()?)?;
let set = LocalSet::new();
let build_attr = self.build_attr.clone();
for host in hosts {
@@ -95,20 +95,20 @@
impl Deploy {
pub async fn run(self, config: &Config, opts: &FleetOpts) -> Result<()> {
- let hosts = opts.filter_skipped(config.list_hosts().await?).await?;
+ let hosts = opts.filter_skipped(config.list_hosts()?)?;
let set = LocalSet::new();
for host in hosts.into_iter() {
let config = config.clone();
let span = info_span!("deploy", host = field::display(&host.name));
let hostname = host.name.clone();
let opts = opts.clone();
- if let Some(deploy_kind) = opts.action_attr::<DeployKind>(&host, "deploy_kind").await? {
+ if let Some(deploy_kind) = opts.action_attr::<DeployKind>(&host, "deploy_kind")? {
host.set_deploy_kind(deploy_kind);
};
- if let Some(destination) = opts.action_attr::<String>(&host, "dest").await? {
+ if let Some(destination) = opts.action_attr::<String>(&host, "dest")? {
host.set_session_destination(destination);
};
- if let Some(legacy) = opts.action_attr::<bool>(&host, "legacy_ssh_store").await? {
+ if let Some(legacy) = opts.action_attr::<bool>(&host, "legacy_ssh_store")? {
host.set_legacy_ssh_store(legacy);
};
@@ -153,7 +153,7 @@
self.action,
&host,
remote_path,
- match opts.action_attr(&host, "specialisation").await {
+ match opts.action_attr(&host, "specialisation") {
Ok(v) => v,
_ => {
error!("unreachable? failed to get specialization");
cmds/fleet/src/cmds/info.rsdiffbeforeafterboth--- a/cmds/fleet/src/cmds/info.rs
+++ b/cmds/fleet/src/cmds/info.rs
@@ -35,7 +35,7 @@
let mut data = Vec::new();
match self.cmd {
InfoCmd::ListHosts { ref tagged } => {
- 'host: for host in config.list_hosts().await? {
+ 'host: for host in config.list_hosts()? {
if !tagged.is_empty() {
let config = &config.config_field;
let host_name = &host.name;
@@ -59,7 +59,7 @@
"at leas one of --external or --internal must be set"
);
let mut out = <BTreeSet<String>>::new();
- let host = config.system_config(&host).await?;
+ let host = config.system_config(&host)?;
if external {
let data: Vec<String> = nix_go_json!(host.network.externalIps);
out.extend(data);
cmds/fleet/src/cmds/rollback.rsdiffbeforeafterboth--- a/cmds/fleet/src/cmds/rollback.rs
+++ b/cmds/fleet/src/cmds/rollback.rs
@@ -75,7 +75,7 @@
impl RollbackSingle {
pub(crate) async fn run(&self, config: &Config, _opts: &FleetOpts) -> Result<()> {
- let host = config.host(&self.machine).await?;
+ let host = config.host(&self.machine)?;
match &self.action {
RollbackAction::ListTargets => {
let generations = list_all_generations(&host, config).await;
cmds/fleet/src/cmds/secrets/mod.rsdiffbeforeafterboth--- a/cmds/fleet/src/cmds/secrets/mod.rs
+++ b/cmds/fleet/src/cmds/secrets/mod.rs
@@ -1,24 +1,16 @@
use std::{
- collections::{BTreeMap, BTreeSet, HashSet},
- io::{self, Read, Write, stdin, stdout},
+ collections::{BTreeSet, HashSet},
+ io::{Read, Write, stdin, stdout},
path::PathBuf,
};
-use anyhow::{Context, Result, anyhow, bail, ensure};
-use chrono::{DateTime, Utc};
+use anyhow::{Context, Result, bail, ensure};
use clap::Parser;
-use fleet_base::{
- fleetdata::{FleetSecretData, FleetSecretDistribution, FleetSecretPart, encrypt_secret_data},
- host::Config,
- opts::FleetOpts,
- secret::{Expectations, RegenerationReason, secret_needs_regeneration},
-};
+use fleet_base::{host::Config, opts::FleetOpts};
use fleet_shared::SecretData;
-use nix_eval::{NixType, Value, nix_go, nix_go_json};
-use serde::Deserialize;
-use tabled::{Table, Tabled};
-use tokio::{fs::read, task::spawn_blocking};
-use tracing::{Instrument, error, info, info_span, warn};
+use tabled::Tabled;
+use tokio::fs::read;
+use tracing::{info, info_span, warn};
#[derive(Parser)]
pub enum Secret {
@@ -145,13 +137,7 @@
}
*/
-#[derive(Deserialize)]
-#[serde(rename_all = "camelCase")]
-enum GeneratorKind {
- Impure,
- Pure,
-}
-
+/*
async fn generate_pure(
_config: &Config,
_display_name: &str,
@@ -315,6 +301,7 @@
}
}
}
+*/
/*
async fn generate_shared(
config: &Config,
@@ -421,8 +408,8 @@
todo!("part of fleet-pusher")
}
Secret::ForceKeys => {
- for host in config.list_hosts().await? {
- if opts.should_skip(&host).await? {
+ for host in config.list_hosts()? {
+ if opts.should_skip(&host)? {
continue;
}
config.key(&host.name).await?;
@@ -467,7 +454,7 @@
let Some(identity_holder) = identity_holder else {
bail!("no available holder found");
};
- let host = config.host(identity_holder).await?;
+ let host = config.host(identity_holder)?;
host.decrypt(part.raw.clone()).await?
} else {
part.raw.data.clone()
@@ -619,7 +606,7 @@
}
Secret::List {} => {
let _span = info_span!("loading secrets").entered();
- let configured = config.list_configured_shared().await?;
+ let configured = config.list_configured_shared()?;
#[derive(Tabled)]
struct SecretDisplay {
#[tabled(rename = "Name")]
@@ -662,7 +649,7 @@
.host_secret(&machine, &name)
.context("secret not found")?;
if let Some(data) = secret.secret.parts.get(&part) {
- let host = config.host(&machine).await?;
+ let host = config.host(&machine)?;
let secret = host.decrypt(data.raw.clone()).await?;
String::from_utf8(secret).context("secret is not utf8")?
} else if add {
cmds/fleet/src/main.rsdiffbeforeafterboth--- a/cmds/fleet/src/main.rs
+++ b/cmds/fleet/src/main.rs
@@ -216,13 +216,10 @@
.map(|a| extra_args::parse_os(&a))
.transpose()?
.unwrap_or_default();
- let config = opts
- .fleet_opts
- .build(
- nix_args,
- matches!(opts.command, Opts::Deploy(_) | Opts::BuildSystems(_)),
- )
- .await?;
+ let config = opts.fleet_opts.build(
+ nix_args,
+ matches!(opts.command, Opts::Deploy(_) | Opts::BuildSystems(_)),
+ )?;
match run_command(&config, opts.fleet_opts, opts.command).await {
Ok(()) => {
crates/fleet-base/src/fleetdata.rsdiffbeforeafterboth--- a/crates/fleet-base/src/fleetdata.rs
+++ b/crates/fleet-base/src/fleetdata.rs
@@ -421,3 +421,14 @@
}
}
}
+
+#[derive(Debug)]
+pub struct Expectations {
+ pub owners: BTreeSet<String>,
+ pub generation_data: serde_json::Value,
+ pub parts: BTreeMap<String, GeneratorPart>,
+}
+#[derive(Deserialize, Debug, Clone)]
+pub struct GeneratorPart {
+ pub encrypted: bool,
+}
crates/fleet-base/src/host.rsdiffbeforeafterboth--- a/crates/fleet-base/src/host.rs
+++ b/crates/fleet-base/src/host.rs
@@ -471,10 +471,13 @@
cmd.run().await
}
}
+
+struct HostSecretDefinition(Value);
+
impl ConfigHost {
// TOCTOU is possible here in case if config is changed, but this case is not handled anywhere anyway,
// assuming getting tags always returns the same value.
- pub async fn tags(&self) -> Result<Vec<String>> {
+ pub fn tags(&self) -> Result<Vec<String>> {
if let Some(v) = self.groups.get() {
return Ok(v.clone());
}
@@ -487,7 +490,7 @@
Ok(tags)
}
- pub async fn nixos_config(&self) -> Result<Value> {
+ pub fn nixos_config(&self) -> Result<Value> {
if let Some(v) = self.nixos_config.get() {
return Ok(v.clone());
}
@@ -495,7 +498,7 @@
bail!("local host has no nixos_config");
};
let nixos_config = nix_go!(host_config.nixos.config);
- assert_warn("nixos config evaluation", &nixos_config).await?;
+ assert_warn("nixos config evaluation", &nixos_config)?;
let _ = self.nixos_config.set(nixos_config.clone());
@@ -522,7 +525,7 @@
}
/// Packages for this host, resolved with nixpkgs overlays
- pub async fn pkgs(&self) -> Result<Value> {
+ pub fn pkgs(&self) -> Result<Value> {
if let Some(value) = &self.pkgs_override {
return Ok(value.clone());
}
@@ -534,17 +537,29 @@
}
}
+pub struct SharedSecretDefinition(Value);
+impl SharedSecretDefinition {
+ pub fn expected_owners(&self) -> Result<BTreeSet<String>> {
+ let secret = &self.0;
+ Ok(nix_go_json!(secret.expectedOwners))
+ }
+ pub fn generator(&self) -> Result<Value> {
+ let secret = &self.0;
+ Ok(nix_go!(secret.generator))
+ }
+}
+
impl Config {
- pub async fn tagged_hostnames(&self, tag: &str) -> Result<Vec<String>> {
+ pub fn tagged_hostnames(&self, tag: &str) -> Result<Vec<String>> {
let config = &self.config_field;
let tagged: Vec<String> = nix_go_json!(config.taggedWith[{ tag }]);
Ok(tagged)
}
- pub async fn expand_owner_set(&self, owners: Vec<String>) -> Result<BTreeSet<String>> {
+ pub fn expand_owner_set(&self, owners: Vec<String>) -> Result<BTreeSet<String>> {
let mut out = BTreeSet::new();
for owner in owners {
if let Some(tag) = owner.strip_prefix('@') {
- let hosts = self.tagged_hostnames(tag).await?;
+ let hosts = self.tagged_hostnames(tag)?;
out.extend(hosts);
} else {
out.insert(owner);
@@ -574,7 +589,7 @@
}
}
- pub async fn host(&self, name: &str) -> Result<ConfigHost> {
+ pub fn host(&self, name: &str) -> Result<ConfigHost> {
let config = &self.config_field;
let host_config = nix_go!(config.hosts[{ name }]);
@@ -595,23 +610,23 @@
legacy_ssh_store: OnceCell::new(),
})
}
- pub async fn list_hosts(&self) -> Result<Vec<ConfigHost>> {
+ pub fn list_hosts(&self) -> Result<Vec<ConfigHost>> {
let config = &self.config_field;
let names = nix_go!(config.hosts).list_fields()?;
let mut out = vec![];
for name in names {
- out.push(self.host(&name).await?);
+ out.push(self.host(&name)?);
}
Ok(out)
}
// TODO: Replace usages with .host().nixos_config
- pub async fn system_config(&self, host: &str) -> Result<Value> {
+ pub fn system_config(&self, host: &str) -> Result<Value> {
let fleet_field = &self.config_field;
Ok(nix_go!(fleet_field.hosts[{ host }].nixos.config))
}
/// Shared secrets configured in fleet.nix or in flake
- pub async fn list_configured_shared(&self) -> Result<Vec<String>> {
+ pub fn list_configured_shared(&self) -> Result<Vec<String>> {
let config_field = &self.config_field;
nix_go!(config_field.sharedSecrets).list_fields()
}
@@ -659,6 +674,17 @@
data.secrets.get(secret).cloned()
}
+ pub fn secret_definition(&self, secret: &str) -> Result<Option<SharedSecretDefinition>> {
+ let config = &self.config_field;
+ let shared_secrets = nix_go!(config.secrets);
+ if !shared_secrets.has_field(secret)? {
+ return Ok(None);
+ }
+ Ok(Some(SharedSecretDefinition(nix_go!(
+ shared_secrets[secret]
+ ))))
+ }
+
// TODO: Should this be something modifiable from other processes?
// E.g terraform provider might want to update FleetData (e.g secrets),
// and current implementation assumes only one process holds current fleet.nix
crates/fleet-base/src/keys.rsdiffbeforeafterboth--- a/crates/fleet-base/src/keys.rs
+++ b/crates/fleet-base/src/keys.rs
@@ -12,10 +12,10 @@
pub fn cached_key(&self, host: &str) -> Option<String> {
let data = self.data();
let key = data.hosts.get(host).map(|h| &h.encryption_key);
- if let Some(key) = key {
- if key.is_empty() {
- return None;
- }
+ if let Some(key) = key
+ && key.is_empty()
+ {
+ return None;
}
key.cloned()
}
@@ -30,7 +30,7 @@
Ok(key)
} else {
warn!("Loading key for {}", host);
- let host = self.host(host).await?;
+ let host = self.host(host)?;
let mut cmd = host.cmd("cat").await?;
cmd.arg("/etc/ssh/ssh_host_ed25519_key.pub");
let key = cmd.run_string().await?;
@@ -47,7 +47,7 @@
}
pub async fn recipients(&self, hosts: Vec<String>) -> Result<Vec<Box<dyn Recipient>>> {
- let hosts = self.expand_owner_set(hosts).await?;
+ let hosts = self.expand_owner_set(hosts)?;
futures::stream::iter(hosts.iter())
.then(|m| self.recipient(m.as_ref()))
.try_collect::<Vec<_>>()
@@ -57,12 +57,7 @@
#[allow(dead_code)]
pub async fn orphaned_data(&self) -> Result<Vec<String>> {
let mut out = Vec::new();
- let host_names = self
- .list_hosts()
- .await?
- .into_iter()
- .map(|h| h.name)
- .collect_vec();
+ let host_names = self.list_hosts()?.into_iter().map(|h| h.name).collect_vec();
for hostname in self
.data()
.hosts
crates/fleet-base/src/opts.rsdiffbeforeafterboth--- a/crates/fleet-base/src/opts.rs
+++ b/crates/fleet-base/src/opts.rs
@@ -104,20 +104,20 @@
}
impl FleetOpts {
- pub async fn filter_skipped(
+ pub fn filter_skipped(
&self,
hosts: impl IntoIterator<Item = ConfigHost>,
) -> Result<Vec<ConfigHost>> {
let mut out = Vec::new();
for host in hosts {
- if self.should_skip(&host).await? {
+ if self.should_skip(&host)? {
continue;
}
out.push(host);
}
Ok(out)
}
- pub async fn should_skip(&self, host: &ConfigHost) -> Result<bool> {
+ pub fn should_skip(&self, host: &ConfigHost) -> Result<bool> {
if self.skip.iter().any(|h| h as &str == host.name) {
return Ok(true);
}
@@ -137,7 +137,7 @@
}
}
if have_group_matches {
- let host_tags = host.tags().await?;
+ let host_tags = host.tags()?;
for item in self.only.iter() {
match item {
HostItem::Tag { name, .. } if host_tags.contains(name) => {
@@ -149,15 +149,15 @@
}
Ok(true)
}
- pub async fn action_attr<T: FromStr>(&self, host: &ConfigHost, attr: &str) -> Result<Option<T>>
+ pub fn action_attr<T: FromStr>(&self, host: &ConfigHost, attr: &str) -> Result<Option<T>>
where
T::Err: Sync,
anyhow::Error: From<T::Err>,
{
- let str = self.action_attr_str(host, attr).await?;
+ let str = self.action_attr_str(host, attr)?;
Ok(str.map(|v| T::from_str(&v)).transpose()?)
}
- pub async fn action_attr_str(&self, host: &ConfigHost, attr: &str) -> Result<Option<String>> {
+ pub fn action_attr_str(&self, host: &ConfigHost, attr: &str) -> Result<Option<String>> {
if self.only.is_empty() {
return Ok(None);
}
@@ -176,7 +176,7 @@
}
}
if have_group_matches {
- let host_tags = host.tags().await?;
+ let host_tags = host.tags()?;
for item in self.only.iter() {
match item {
HostItem::Tag { name, attrs }
@@ -195,7 +195,7 @@
}
// TODO: Config should be detached from opts.
- pub async fn build(&self, nix_args: Vec<OsString>, assert: bool) -> Result<Config> {
+ pub fn build(&self, nix_args: Vec<OsString>, assert: bool) -> Result<Config> {
let cwd = current_dir()?;
let mut directory = cwd.clone();
let mut fleet_data_path = directory.join("fleet.nix");
@@ -248,7 +248,6 @@
if assert {
assert_warn("fleet config evaluation", &config_field)
- .await
.context("failed to verify assertions")?;
}
crates/fleet-base/src/primops.rsdiffbeforeafterboth1use std::cell::OnceCell;2use std::collections::{BTreeMap, HashMap};3use std::sync::{Arc, Mutex, OnceLock};45use anyhow::{Context, bail};6use itertools::Itertools;7use nix_eval::{NativeFn, Value, nix_go, nix_go_json};8use serde::Deserialize;9use tracing::{info, warn};1011use crate::fleetdata::{FleetData, FleetSecrets};12use crate::host::Config;1314#[derive(thiserror::Error, Debug)]15enum Error {}1617struct Parts {18 encrypted: Vec<String>,19 public: Vec<String>,20}2122trait SecretsBackend {23 fn has_shared(&self, name: &str);24 fn has_host(&self, host: &str, name: &str);25 fn shared_parts(&self, name: &str) -> Parts;26 fn host_parts(&self, host: &str, name: &str) -> Parts;27}2829struct FsSecretsBackend {}3031pub static PRIMOPS_DATA: OnceLock<Config> = OnceLock::new();3233#[derive(Deserialize, Debug)]34struct GeneratorPart {35 encrypted: bool,36}3738pub fn init_primops() {39 info!("initializing primops");40 NativeFn::new(41 c"__fleetEnsureHostSecret",42 c"Ensure secret existence for a host, regenerating it in case of some mismatch",43 [c"host", c"secret", c"generator"],44 |es, [host, secret, generator]| {45 info!("get host");46 let host = host.to_string()?;47 info!("get secret");48 let secret = secret.to_string()?;4950 info!("get config");51 let config = PRIMOPS_DATA52 .get()53 .expect("primops data should be set on init");5455 info!("get pkgs");56 let nixpkgs = &config.nixpkgs;57 let default_pkgs = &config.default_pkgs;58 let default_mk_secret_generators = nix_go!(default_pkgs.mkSecretGenerators);59 let generators = nix_go!(default_mk_secret_generators(Obj {60 recipients: <Vec<String>>::new(),61 }));62 let pkgs_and_generators = default_pkgs.clone().attrs_update(generators)?;6364 info!("call package");65 let call_package = nix_go!(nixpkgs.lib.callPackageWith(pkgs_and_generators));66 let default_generator = call_package67 .call(generator.clone())68 .context("calling callPackage with generator")?69 .call(Value::new_attrs(HashMap::new()))70 .context("providing extra callPackage args")?;7172 info!("get parts");73 let mut parts: BTreeMap<String, GeneratorPart> = nix_go_json!(default_generator.parts);74 info!("got parts: {parts:?}");7576 let Some(existing) = config77 .host_secret(&host, &secret) else {78 bail!("missing secret {secret} for host {host}; secret needs regeneration")79 };8081 info!("got existing: {existing:?}");8283 let mut out = HashMap::new();8485 for (part_name, part) in &existing.secret.parts {86 let Some(definition) = parts.remove(part_name) else {87 warn!("secret {secret} part {part_name} is stored, but not defined in nixos config, it will not be passed to nix");88 continue;89 };90 if definition.encrypted != part.raw.encrypted {91 bail!("secret {secret} part {part_name} is supposed to be {}, but it is {}; secret needs regeneration", if definition.encrypted {"encrypted"} else {"unencrypted"}, if part.raw.encrypted {"encrypted"} else {"unencrypted"});92 }93 out.insert(part_name.as_str(), Value::new_attrs(HashMap::from_iter([("raw", Value::new_str(&part.raw.to_string()))])));94 }95 if !parts.is_empty(){96 let defs = parts.keys().collect_vec();97 bail!("secret parts are defined, but not stored: {defs:?}, secret needs regeneration")98 }99100 Ok(Value::new_attrs(out))101 },102 )103 .register();104}1use std::collections::{BTreeMap, BTreeSet, HashMap};2use std::sync::OnceLock;34use anyhow::{Context, bail, ensure};5use fleet_shared::SecretData;6use itertools::Itertools;7use nix_eval::{NativeFn, Value, nix_go, nix_go_json};8use serde::Deserialize;9use tracing::{info, warn};1011use crate::fleetdata::{12 Expectations, FleetSecretData, FleetSecretDistribution, FleetSecretPart, GeneratorPart,13};14use crate::host::{Config, ConfigHost};15use crate::secret::{RegenerationReason, secret_needs_regeneration};16use anyhow::{Result, anyhow};1718#[derive(thiserror::Error, Debug)]19enum Error {}2021pub static PRIMOPS_DATA: OnceLock<Config> = OnceLock::new();2223#[derive(Deserialize)]24#[serde(rename_all = "camelCase")]25enum GeneratorKind {26 Impure,27 Pure,28}2930pub fn get_pkgs_and_generators(host_on: &ConfigHost, recipients: Vec<String>) -> Result<Value> {31 info!("get pkgs");32 let pkgs = host_on.pkgs()?;33 let default_mk_secret_generators = nix_go!(pkgs.mkSecretGenerators);34 let generators = nix_go!(default_mk_secret_generators(Obj { recipients }));35 Ok(pkgs.clone().attrs_update(generators)?)36}37pub fn get_default_pkgs_and_generators(config: &Config) -> Result<Value> {38 let host_on = config.local_host();39 get_pkgs_and_generators(&host_on, vec![])40}41pub fn call_package(config: &Config, pkgs: &Value, package: &Value) -> Result<Value> {42 ensure!(43 package.is_function(),44 "package should be a function to be called with callPackage"45 );46 // No need to use nixpkgs.buildUsing, as only nixpkgs-lib is used.47 let nixpkgs = &config.nixpkgs;48 let call_package = nix_go!(nixpkgs.lib.callPackageWith(pkgs));49 Ok(nix_go!(call_package(package)(Obj {})))50}5152pub fn get_default_generator_drv(config: &Config, generator: &Value) -> Result<Value> {53 let default_pkgs_and_generators = get_default_pkgs_and_generators(config)?;54 let default_generator_drv = call_package(config, &default_pkgs_and_generators, generator)55 .context("failed to initialize generator to get metadata")?;5657 Ok(default_generator_drv)58}5960pub async fn generate(61 config: &Config,62 expectations: Expectations,63 generator: &Value,64 default_generator_drv: &Value,65) -> Result<FleetSecretDistribution> {66 let kind: GeneratorKind = nix_go_json!(default_generator_drv.generatorKind);6768 match kind {69 GeneratorKind::Impure => {70 let impure_on: Option<String> = nix_go_json!(default_generator_drv.impureOn);7172 let host_on = if let Some(on) = &impure_on {73 config74 .host(on)75 .context("failed to get secret generation target host")?76 } else {77 config.local_host()78 };79 let pkgs_and_generators =80 get_pkgs_and_generators(&host_on, expectations.owners.iter().cloned().collect())81 .context("failed to get pkgs for target host")?;82 let generator = call_package(config, &pkgs_and_generators, generator)83 .context("failed to evaluate generator for target host")?;8485 let generator = generator86 .build("out")87 .context("failed to build generator for target host")?;8889 let generator = host_on90 .remote_derivation(&generator)91 .await92 .context("failed to copy generator to target host")?;9394 // TODO: Remove destdir after everything is done95 let out_parent = host_on96 .mktemp_dir()97 .await98 .context("failed to prepare generator output dir on target host")?;99 let out = format!("{out_parent}/out");100 let mut generator_cmd = host_on.cmd(generator).await?;101 generator_cmd.env("out", &out);102 if impure_on.is_none() {103 let project_path: String = config104 .directory105 .clone()106 .into_os_string()107 .into_string()108 .map_err(|e| anyhow!("fleet project path is not utf-8: {e:?}"))?;109 generator_cmd.env("FLEET_PROJECT", project_path);110 };111 generator_cmd112 .run()113 .await114 .context("failed to run impure generator")?;115116 {117 let marker = host_on.read_file_text(format!("{out}/marker")).await?;118 ensure!(119 marker == "SUCCESS",120 "impure generator ended prematurely, secret generation failed"121 );122 }123124 let mut parts = BTreeMap::new();125 for part in host_on.read_dir(&out).await? {126 if part == "created_at" || part == "expires_at" || part == "marker" {127 continue;128 }129 let contents: SecretData = host_on130 .read_file_text(format!("{out}/{part}"))131 .await?132 .parse()133 .map_err(|e| anyhow!("failed to decode secret {out:?} part {part:?}: {e}"))?;134 parts.insert(part.to_owned(), FleetSecretPart { raw: contents });135 }136137 let created_at = host_on.read_file_value(format!("{out}/created_at")).await?;138 let expires_at = host_on139 .read_file_value(format!("{out}/expires_at"))140 .await141 .ok();142143 let new_data = FleetSecretData {144 created_at,145 expires_at,146 parts,147 generation_data: expectations.generation_data.clone(),148 };149150 let new_data = FleetSecretDistribution {151 secret: new_data,152 owners: expectations.owners.clone(),153 _deprecated_managed: true,154 };155156 if let Some(reason) = secret_needs_regeneration(&new_data, &expectations) {157 bail!("newly generated secret needs to be regenerated: {reason}")158 }159160 Ok(new_data)161 }162 GeneratorKind::Pure => {163 bail!("pure generators are disabled for now")164 }165 }166}167168pub fn init_primops() {169 info!("initializing primops");170 NativeFn::new(171 c"__fleetEnsureHostSecret",172 c"Ensure secret existence for a host, regenerating it in case of some mismatch",173 [c"host", c"secret", c"generator"],174 |es, [host, secret, generator]| {175 info!("get host");176 let host = host.to_string()?;177 info!("get secret");178 let secret = secret.to_string()?;179180 info!("get config");181 let config = PRIMOPS_DATA182 .get()183 .expect("primops data should be set on init");184185 let shared_def = config.secret_definition(&secret).context("failed to get shared secret definition")?;186187 let (shared, generator, expected_owners) = if generator.is_string() {188 assert_eq!(generator.to_string()?, "shared", "asserted by nixos type system");189 let Some(shared_def) = shared_def else {190 bail!("secret {secret} is defined on host {host} as shared, but there is no shared secret with same name defined at fleetConfiguration.secrets.{secret}.generator")191 };192 let expected_owners = shared_def.expected_owners()?;193194 ensure!(expected_owners.contains(&host), "secret {secret} does not define {host} as expected owner");195196 (true, shared_def.generator()?, expected_owners)197 } else {198 if shared_def.is_some() {199 bail!("hosts can only have their own generators for non-shared secrets, either set host secret generator to \"shared\", or remove shared secret generator at fleetConfiguration.secrets.{secret}.generator")200 }201202 (false, generator.clone(), BTreeSet::from_iter([host.clone()]))203 };204205 let default_generator_drv = get_default_generator_drv(config, &generator).context("failed to evaluate default generator")?;206 let expectations = Expectations {207 parts: nix_go_json!(default_generator_drv.parts),208 generation_data: nix_go_json!(default_generator_drv.generationData),209 owners: expected_owners,210 };211212 let reason: RegenerationReason = 'regenerate: {213 let Some(existing) = config214 .host_secret(&host, &secret) else {215 break 'regenerate RegenerationReason::Missing;216 };217 if let Some(reason) = secret_needs_regeneration(&existing, &expectations) {218 break 'regenerate reason;219 }220221 let mut parts = expectations.parts.clone();222223 let mut out = HashMap::new();224 for (part_name, part) in &existing.secret.parts {225 let Some(definition) = parts.remove(part_name) else {226 warn!("secret {secret} part {part_name} is stored, but not defined in nixos config, it will not be passed to nix");227 continue;228 };229 assert!(definition.encrypted != part.raw.encrypted, "encryption status is checked by secret_needs_regeneration");230 out.insert(part_name.as_str(), Value::new_attrs(HashMap::from_iter([("raw", Value::new_str(&part.raw.to_string()))])));231 }232 assert!(parts.is_empty(), "secret part is missing, secret_needs_regeneration should check that");233234 return Ok(Value::new_attrs(out))235 };236237 todo!()238239240 },241 )242 .register();243}crates/fleet-base/src/secret.rsdiffbeforeafterboth--- a/crates/fleet-base/src/secret.rs
+++ b/crates/fleet-base/src/secret.rs
@@ -1,16 +1,8 @@
-use std::collections::BTreeSet;
+use std::collections::{BTreeMap, BTreeSet};
use chrono::{DateTime, Utc};
-use crate::fleetdata::FleetSecretData;
-
-#[derive(Debug)]
-pub struct Expectations {
- pub owners: BTreeSet<String>,
- pub generation_data: serde_json::Value,
- pub public_parts: BTreeSet<String>,
- pub private_parts: BTreeSet<String>,
-}
+use crate::fleetdata::{Expectations, FleetSecretData, FleetSecretDistribution, GeneratorPart};
#[derive(thiserror::Error, Debug)]
pub enum RegenerationReason {
@@ -34,56 +26,62 @@
ExpectedPublic(String),
#[error("secret is expired at {0}")]
Expired(DateTime<Utc>),
+
+ #[error("secret is not generated for this host")]
+ Missing,
}
pub fn secret_needs_regeneration(
- secret: &FleetSecretData,
- owners: &BTreeSet<String>,
+ secret: &FleetSecretDistribution,
expectations: &Expectations,
) -> Option<RegenerationReason> {
- if !owners.is_empty() {
- let added: BTreeSet<String> = expectations.owners.difference(owners).cloned().collect();
- if !added.is_empty() {
- return Some(RegenerationReason::OwnersAdded(added));
- }
+ let added: BTreeSet<String> = expectations
+ .owners
+ .difference(&secret.owners)
+ .cloned()
+ .collect();
+ if !added.is_empty() {
+ return Some(RegenerationReason::OwnersAdded(added));
+ }
- let removed: BTreeSet<String> = owners.difference(&expectations.owners).cloned().collect();
- if !removed.is_empty() {
- return Some(RegenerationReason::OwnersRemoved(removed));
- }
+ let removed: BTreeSet<String> = secret
+ .owners
+ .difference(&expectations.owners)
+ .cloned()
+ .collect();
+ if !removed.is_empty() {
+ return Some(RegenerationReason::OwnersRemoved(removed));
}
- if secret.generation_data != expectations.generation_data {
+ if secret.secret.generation_data != expectations.generation_data {
return Some(RegenerationReason::GenerationData {
expected: expectations.generation_data.clone(),
- found: secret.generation_data.clone(),
+ found: secret.secret.generation_data.clone(),
});
}
- if !expectations.public_parts.is_empty() || !expectations.private_parts.is_empty() {
- let expected: BTreeSet<String> = expectations
- .public_parts
- .union(&expectations.private_parts)
- .cloned()
- .collect();
- let found: BTreeSet<String> = secret.parts.keys().cloned().collect();
+ let expected: BTreeSet<String> = expectations.parts.keys().cloned().collect();
+ let found: BTreeSet<String> = secret.secret.parts.keys().cloned().collect();
- if found != expected {
- return Some(RegenerationReason::PartList { expected, found });
- }
+ if found != expected {
+ return Some(RegenerationReason::PartList { expected, found });
+ }
- for (name, value) in secret.parts.iter() {
- if value.raw.encrypted {
- if !expectations.private_parts.contains(name) {
- return Some(RegenerationReason::ExpectedPrivate(name.clone()));
- }
- } else if !expectations.public_parts.contains(name) {
- return Some(RegenerationReason::ExpectedPublic(name.clone()));
+ for (name, value) in secret.secret.parts.iter() {
+ let expectation = expectations
+ .parts
+ .get(name)
+ .expect("found == expected checked");
+ if value.raw.encrypted {
+ if !expectation.encrypted {
+ return Some(RegenerationReason::ExpectedPrivate(name.clone()));
}
+ } else if expectation.encrypted {
+ return Some(RegenerationReason::ExpectedPublic(name.clone()));
}
}
- if let Some(expiration) = secret.expires_at {
+ if let Some(expiration) = secret.secret.expires_at {
// TODO: Leeway?
if expiration < Utc::now() {
return Some(RegenerationReason::Expired(expiration));
crates/nix-eval/src/lib.rsdiffbeforeafterboth--- a/crates/nix-eval/src/lib.rs
+++ b/crates/nix-eval/src/lib.rs
@@ -731,6 +731,10 @@
}
pub fn has_field(&self, field: &str) -> Result<bool> {
+ if !matches!(self.type_of(), NixType::Attrs) {
+ bail!("invalid type: expected attrs");
+ }
+
let f = init_field_name(field);
with_default_context(|c, es| unsafe { has_attr_byname(c, self.0, es, f.as_ptr().cast()) })
}
@@ -881,6 +885,12 @@
pub fn is_null(&self) -> bool {
matches!(self.type_of(), NixType::Null)
}
+ pub fn is_string(&self) -> bool {
+ matches!(self.type_of(), NixType::String)
+ }
+ pub fn is_attrs(&self) -> bool {
+ matches!(self.type_of(), NixType::Attrs)
+ }
}
impl From<String> for Value {
crates/nix-eval/src/util.rsdiffbeforeafterboth--- a/crates/nix-eval/src/util.rs
+++ b/crates/nix-eval/src/util.rs
@@ -1,23 +1,15 @@
use std::time::Instant;
use anyhow::bail;
-use serde::Deserialize;
use tracing::{debug, warn};
use crate::{Value, nix_go_json};
-
-#[derive(Deserialize, Debug)]
-struct Assertion {
- assertion: bool,
- message: String,
-}
#[tracing::instrument(level = "info", skip(val))]
-pub async fn assert_warn(action: &str, val: &Value) -> anyhow::Result<()> {
+pub fn assert_warn(action: &str, val: &Value) -> anyhow::Result<()> {
let before_errors = Instant::now();
let errors: Vec<String> = nix_go_json!(val.errors);
- // let assertions: Vec<Assertion> = nix_go_json!(val.assertions);
- debug!("errors evaluation took {:?} {errors:?} ", before_errors.elapsed());
+ debug!("errors evaluation took {:?}", before_errors.elapsed());
if !errors.is_empty() {
bail!(
"failed with error{}{}",
lib/default.nixdiffbeforeafterboth--- a/lib/default.nix
+++ b/lib/default.nix
@@ -160,7 +160,7 @@
mkImpureSecretGenerator,
}:
mkImpureSecretGenerator {
- # TODO: Escape prompt?
+ # TODO: Escape prompt/part (preferrably just use env) to prevent shell injection
script = ''
${kdePackages.kdialog}/bin/kdialog --inputbox "${prompt}" | gh private -o $out/${part}
'';
modules/secrets.nixdiffbeforeafterboth--- a/modules/secrets.nix
+++ b/modules/secrets.nix
@@ -89,6 +89,7 @@
# If set - script will be run on remote machine, otherwise it will be run with fleet project in CWD
# (Some secrets-encryption-in-git/managed PKI solution is expected)
impureOn ? null,
+ generationData ? null,
parts,
}:
(prev.writeShellScript "impureGenerator.sh" ''
@@ -117,7 +118,7 @@
'').overrideAttrs
(old: {
passthru = {
- inherit impureOn parts;
+ inherit impureOn parts generationData;
generatorKind = "impure";
};
});