difftreelog
feat preserve object field order
in: trunk
5 files changed
crates/nixlike/Cargo.tomldiffbeforeafterboth--- a/crates/nixlike/Cargo.toml
+++ b/crates/nixlike/Cargo.toml
@@ -8,6 +8,7 @@
[dependencies]
anyhow = "1.0.44"
dprint-core = "0.46.2"
+linked-hash-map = "0.5.4"
peg = "0.7.0"
serde = "1.0.130"
serde_json = "1.0.68"
crates/nixlike/src/de_impl.rsdiffbeforeafterboth--- a/crates/nixlike/src/de_impl.rs
+++ b/crates/nixlike/src/de_impl.rs
@@ -1,8 +1,6 @@
-use std::{
- collections::BTreeMap,
- convert::{TryFrom, TryInto},
-};
+use std::convert::{TryFrom, TryInto};
+use linked_hash_map::LinkedHashMap;
use serde::{
de::{self, MapAccess, SeqAccess},
Deserializer,
@@ -11,11 +9,11 @@
use crate::{Error, Value};
struct ObjectAccess {
- iter: std::collections::btree_map::IntoIter<String, Value>,
+ iter: linked_hash_map::IntoIter<String, Value>,
value: Option<Value>,
}
impl ObjectAccess {
- fn new(v: BTreeMap<String, Value>) -> Self {
+ fn new(v: LinkedHashMap<String, Value>) -> Self {
Self {
iter: v.into_iter(),
value: None,
@@ -103,7 +101,7 @@
_ => Err(Error::Expected("array")),
}
}
- fn parse_object(self) -> Result<BTreeMap<String, Value>, Error> {
+ fn parse_object(self) -> Result<LinkedHashMap<String, Value>, Error> {
match self {
Value::Object(s) => Ok(s),
_ => Err(Error::Expected("object")),
crates/nixlike/src/lib.rsdiffbeforeafterboth1use std::collections::BTreeMap;1use linked_hash_map::LinkedHashMap;23use peg::str::LineCol;2use peg::str::LineCol;4use se_impl::MySerialize;3use se_impl::MySerialize;29 Number(i64),28 Number(i64),30 String(String),29 String(String),31 Boolean(bool),30 Boolean(bool),32 Object(BTreeMap<String, Value>),31 Object(LinkedHashMap<String, Value>),33 Array(Vec<Value>),32 Array(Vec<Value>),34 Null,33 Null,35}34}49 / "false" {false} } / expected!("<boolean>")48 / "false" {false} } / expected!("<boolean>")50 rule indent() -> String49 rule indent() -> String51 = quiet! { s:$(['a'..='z' | 'A'..='Z' | '0'..='9' | '_' | '-']+) { s.to_owned() } } / expected!("<identifier>")50 = quiet! { s:$(['a'..='z' | 'A'..='Z' | '0'..='9' | '_' | '-']+) { s.to_owned() } } / expected!("<identifier>")52 rule object() -> BTreeMap<String, Value>51 rule object() -> LinkedHashMap<String, Value>53 = "{" _52 = "{" _54 e:(k:indent()++(_ "." _) _ "=" _ v:value() _ ";" _ {(k, v)})*53 e:(k:indent()++(_ "." _) _ "=" _ v:value() _ ";" _ {(k, v)})*55 "}" {?54 "}" {?56 let mut out = BTreeMap::new();55 let mut out = LinkedHashMap::new();57 for (k, v) in e {56 for (k, v) in e {58 let mut map = &mut out;57 let mut map = &mut out;59 for v in k.iter().take(k.len() - 1) {58 for v in k.iter().take(k.len() - 1) {crates/nixlike/src/se_impl.rsdiffbeforeafterboth--- a/crates/nixlike/src/se_impl.rs
+++ b/crates/nixlike/src/se_impl.rs
@@ -1,5 +1,6 @@
-use std::{collections::BTreeMap, convert::TryInto};
+use std::convert::TryInto;
+use linked_hash_map::LinkedHashMap;
use serde::{
ser::{
self, SerializeMap, SerializeSeq, SerializeStruct, SerializeStructVariant, SerializeTuple,
@@ -96,7 +97,7 @@
}
}
-pub struct MySerializeMap(BTreeMap<String, Value>, Option<String>);
+pub struct MySerializeMap(LinkedHashMap<String, Value>, Option<String>);
impl SerializeMap for MySerializeMap {
type Ok = Value;
@@ -127,7 +128,7 @@
}
}
-pub struct MySerializeStruct(BTreeMap<String, Value>);
+pub struct MySerializeStruct(LinkedHashMap<String, Value>);
impl SerializeStruct for MySerializeStruct {
type Ok = Value;
@@ -147,7 +148,7 @@
}
}
-pub struct MySerializeStructVariant(String, BTreeMap<String, Value>);
+pub struct MySerializeStructVariant(String, LinkedHashMap<String, Value>);
impl SerializeStructVariant for MySerializeStructVariant {
type Ok = Value;
@@ -336,7 +337,7 @@
}
fn serialize_map(self, _len: Option<usize>) -> Result<Self::SerializeMap, Self::Error> {
- Ok(MySerializeMap(BTreeMap::new(), None))
+ Ok(MySerializeMap(LinkedHashMap::new(), None))
}
fn serialize_struct(
@@ -344,7 +345,7 @@
_name: &'static str,
_len: usize,
) -> Result<Self::SerializeStruct, Self::Error> {
- Ok(MySerializeStruct(BTreeMap::new()))
+ Ok(MySerializeStruct(LinkedHashMap::new()))
}
fn serialize_struct_variant(
@@ -356,7 +357,7 @@
) -> Result<Self::SerializeStructVariant, Self::Error> {
Ok(MySerializeStructVariant(
variant.to_owned(),
- BTreeMap::new(),
+ LinkedHashMap::new(),
))
}
}
crates/nixlike/src/to_string.rsdiffbeforeafterboth--- a/crates/nixlike/src/to_string.rs
+++ b/crates/nixlike/src/to_string.rs
@@ -41,7 +41,7 @@
out.push_signal(Signal::StartIndent);
out.push_condition(conditions::if_true_or(
"array start",
- is_multiple_lines.clone(),
+ is_multiple_lines,
Signal::NewLine.into(),
Signal::SpaceOrNewLine.into(),
));
@@ -49,7 +49,7 @@
write_nix_buf(item, out);
out.push_condition(conditions::if_true_or(
"element separator",
- is_multiple_lines.clone(),
+ is_multiple_lines,
Signal::NewLine.into(),
Signal::SpaceOrNewLine.into(),
));
@@ -73,7 +73,7 @@
out.push_signal(Signal::StartIndent);
out.push_condition(conditions::if_true_or(
"object start",
- is_multiple_lines.clone(),
+ is_multiple_lines,
Signal::NewLine.into(),
Signal::SpaceOrNewLine.into(),
));
@@ -81,7 +81,7 @@
write_nix_obj_key_buf(k, v, out);
out.push_condition(conditions::if_true_or(
"element separator",
- is_multiple_lines.clone(),
+ is_multiple_lines,
Signal::NewLine.into(),
Signal::SpaceOrNewLine.into(),
));