git.delta.rocks / jrsonnet / refs/commits / ec654c44d309

difftreelog

refactor get rid of LazyBinding variants

Yaroslav Bolyukin2021-02-22parent: #3154bc9.patch.diff
in: master

5 files changed

modifiedcrates/jrsonnet-evaluator/src/ctx.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/ctx.rs
+++ b/crates/jrsonnet-evaluator/src/ctx.rs
@@ -1,17 +1,24 @@
 use crate::{
-	error::Error::*, map::LayeredHashMap, rc_fn_helper, resolved_lazy_val, FutureWrapper,
-	LazyBinding, LazyVal, ObjValue, Result, Val,
+	error::Error::*, map::LayeredHashMap, resolved_lazy_val, FutureWrapper, LazyBinding, LazyVal,
+	ObjValue, Result, Val,
 };
 use jrsonnet_interner::IStr;
 use rustc_hash::FxHashMap;
 use std::hash::BuildHasherDefault;
-use std::{collections::HashMap, fmt::Debug, rc::Rc};
+use std::{fmt::Debug, rc::Rc};
 
-rc_fn_helper!(
-	ContextCreator,
-	context_creator,
-	dyn Fn(Option<ObjValue>, Option<ObjValue>) -> Result<Context>
-);
+#[derive(Clone)]
+pub struct ContextCreator(pub Context, pub FutureWrapper<FxHashMap<IStr, LazyBinding>>);
+impl ContextCreator {
+	pub fn create(&self, this: Option<ObjValue>, super_obj: Option<ObjValue>) -> Result<Context> {
+		self.0.clone().extend_unbound(
+			self.1.clone().unwrap(),
+			self.0.dollar().clone().or_else(|| this.clone()),
+			this,
+			super_obj,
+		)
+	}
+}
 
 struct ContextInternals {
 	dollar: Option<ObjValue>,
@@ -120,9 +127,14 @@
 			}
 		}
 	}
+	pub fn extend_bound(self, new_bindings: FxHashMap<IStr, LazyVal>) -> Self {
+		let new_this = self.0.this.clone();
+		let new_super_obj = self.0.super_obj.clone();
+		self.extend(new_bindings, None, new_this, new_super_obj)
+	}
 	pub fn extend_unbound(
 		self,
-		new_bindings: HashMap<IStr, LazyBinding>,
+		new_bindings: FxHashMap<IStr, LazyBinding>,
 		new_dollar: Option<ObjValue>,
 		new_this: Option<ObjValue>,
 		new_super_obj: Option<ObjValue>,
modifiedcrates/jrsonnet-evaluator/src/dynamic.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/dynamic.rs
+++ b/crates/jrsonnet-evaluator/src/dynamic.rs
@@ -12,7 +12,7 @@
 	}
 }
 impl<T: Clone> FutureWrapper<T> {
-	pub fn unwrap(self) -> T {
+	pub fn unwrap(&self) -> T {
 		self.0.borrow().as_ref().cloned().unwrap()
 	}
 }
@@ -21,30 +21,4 @@
 	fn default() -> Self {
 		Self::new()
 	}
-}
-
-#[macro_export]
-macro_rules! rc_fn_helper {
-	($name: ident, $macro_name: ident, $fn: ty) => {
-		#[derive(Clone)]
-		#[doc = "Function wrapper"]
-		pub struct $name(pub std::rc::Rc<$fn>);
-		impl std::fmt::Debug for $name {
-			fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-				f.debug_struct(std::stringify!($name)).finish()
-			}
-		}
-		impl std::cmp::PartialEq for $name {
-			fn eq(&self, other: &$name) -> bool {
-				std::ptr::eq(&self.0, &other.0)
-			}
-		}
-		#[doc = "Macro to ease wrapper creation"]
-		#[macro_export]
-		macro_rules! $macro_name {
-			($val: expr) => {
-				$crate::$name(std::rc::Rc::new($val))
-			};
-		}
-	};
 }
modifiedcrates/jrsonnet-evaluator/src/evaluate.rsdiffbeforeafterboth
before · crates/jrsonnet-evaluator/src/evaluate.rs
1use crate::{2	context_creator, error::Error::*, lazy_val, push, throw, with_state, Context, ContextCreator,3	FuncDesc, FuncVal, FutureWrapper, LazyBinding, LazyVal, ObjMember, ObjValue, Result, Val,4};5use closure::closure;6use jrsonnet_interner::IStr;7use jrsonnet_parser::{8	ArgsDesc, AssertStmt, BinaryOpType, BindSpec, CompSpec, Expr, ExprLocation, FieldMember,9	ForSpecData, IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc, UnaryOpType,10	Visibility,11};12use jrsonnet_types::ValType;13use rustc_hash::FxHashMap;14use std::{collections::HashMap, rc::Rc};1516pub fn evaluate_binding(b: &BindSpec, context_creator: ContextCreator) -> (IStr, LazyBinding) {17	let b = b.clone();18	if let Some(params) = &b.params {19		let params = params.clone();20		(21			b.name.clone(),22			LazyBinding::Bindable(Rc::new(move |this, super_obj| {23				Ok(lazy_val!(24					closure!(clone b, clone params, clone context_creator, || Ok(evaluate_method(25						context_creator.0(this.clone(), super_obj.clone())?,26						b.name.clone(),27						params.clone(),28						b.value.clone(),29					)))30				))31			})),32		)33	} else {34		(35			b.name.clone(),36			LazyBinding::Bindable(Rc::new(move |this, super_obj| {37				Ok(lazy_val!(closure!(clone context_creator, clone b, ||38						evaluate_named(39							context_creator.0(this.clone(), super_obj.clone())?,40							&b.value,41							b.name.clone()42						)43				)))44			})),45		)46	}47}4849pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {50	Val::Func(Rc::new(FuncVal::Normal(FuncDesc {51		name,52		ctx,53		params,54		body,55	})))56}5758pub fn evaluate_field_name(59	context: Context,60	field_name: &jrsonnet_parser::FieldName,61) -> Result<Option<IStr>> {62	Ok(match field_name {63		jrsonnet_parser::FieldName::Fixed(n) => Some(n.clone()),64		jrsonnet_parser::FieldName::Dyn(expr) => {65			let value = evaluate(context, expr)?;66			if matches!(value, Val::Null) {67				None68			} else {69				Some(value.try_cast_str("dynamic field name")?)70			}71		}72	})73}7475pub fn evaluate_unary_op(op: UnaryOpType, b: &Val) -> Result<Val> {76	Ok(match (op, b) {77		(UnaryOpType::Not, Val::Bool(v)) => Val::Bool(!v),78		(UnaryOpType::Minus, Val::Num(n)) => Val::Num(-*n),79		(UnaryOpType::BitNot, Val::Num(n)) => Val::Num(!(*n as i32) as f64),80		(op, o) => throw!(UnaryOperatorDoesNotOperateOnType(op, o.value_type())),81	})82}8384pub fn evaluate_add_op(a: &Val, b: &Val) -> Result<Val> {85	Ok(match (a, b) {86		(Val::Str(v1), Val::Str(v2)) => Val::Str(((**v1).to_owned() + v2).into()),8788		// Can't use generic json serialization way, because it depends on number to string concatenation (std.jsonnet:890)89		(Val::Num(n), Val::Str(o)) => Val::Str(format!("{}{}", n, o).into()),90		(Val::Str(o), Val::Num(n)) => Val::Str(format!("{}{}", o, n).into()),9192		(Val::Str(s), o) => Val::Str(format!("{}{}", s, o.clone().to_string()?).into()),93		(o, Val::Str(s)) => Val::Str(format!("{}{}", o.clone().to_string()?, s).into()),9495		(Val::Obj(v1), Val::Obj(v2)) => Val::Obj(v2.extend_from(v1.clone())),96		(Val::Arr(a), Val::Arr(b)) => {97			let mut out = Vec::with_capacity(a.len() + b.len());98			out.extend(a.iter_lazy());99			out.extend(b.iter_lazy());100			Val::Arr(out.into())101		}102		(Val::Num(v1), Val::Num(v2)) => Val::new_checked_num(v1 + v2)?,103		_ => throw!(BinaryOperatorDoesNotOperateOnValues(104			BinaryOpType::Add,105			a.value_type(),106			b.value_type(),107		)),108	})109}110111pub fn evaluate_binary_op_special(112	context: Context,113	a: &LocExpr,114	op: BinaryOpType,115	b: &LocExpr,116) -> Result<Val> {117	Ok(match (evaluate(context.clone(), a)?, op, b) {118		(Val::Bool(true), BinaryOpType::Or, _o) => Val::Bool(true),119		(Val::Bool(false), BinaryOpType::And, _o) => Val::Bool(false),120		(a, op, eb) => evaluate_binary_op_normal(&a, op, &evaluate(context, eb)?)?,121	})122}123124pub fn evaluate_binary_op_normal(a: &Val, op: BinaryOpType, b: &Val) -> Result<Val> {125	Ok(match (a, op, b) {126		(a, BinaryOpType::Add, b) => evaluate_add_op(a, b)?,127128		(Val::Str(v1), BinaryOpType::Mul, Val::Num(v2)) => Val::Str(v1.repeat(*v2 as usize).into()),129130		// Bool X Bool131		(Val::Bool(a), BinaryOpType::And, Val::Bool(b)) => Val::Bool(*a && *b),132		(Val::Bool(a), BinaryOpType::Or, Val::Bool(b)) => Val::Bool(*a || *b),133134		// Str X Str135		(Val::Str(v1), BinaryOpType::Lt, Val::Str(v2)) => Val::Bool(v1 < v2),136		(Val::Str(v1), BinaryOpType::Gt, Val::Str(v2)) => Val::Bool(v1 > v2),137		(Val::Str(v1), BinaryOpType::Lte, Val::Str(v2)) => Val::Bool(v1 <= v2),138		(Val::Str(v1), BinaryOpType::Gte, Val::Str(v2)) => Val::Bool(v1 >= v2),139140		// Num X Num141		(Val::Num(v1), BinaryOpType::Mul, Val::Num(v2)) => Val::new_checked_num(v1 * v2)?,142		(Val::Num(v1), BinaryOpType::Div, Val::Num(v2)) => {143			if *v2 <= f64::EPSILON {144				throw!(DivisionByZero)145			}146			Val::new_checked_num(v1 / v2)?147		}148149		(Val::Num(v1), BinaryOpType::Sub, Val::Num(v2)) => Val::new_checked_num(v1 - v2)?,150151		(Val::Num(v1), BinaryOpType::Lt, Val::Num(v2)) => Val::Bool(v1 < v2),152		(Val::Num(v1), BinaryOpType::Gt, Val::Num(v2)) => Val::Bool(v1 > v2),153		(Val::Num(v1), BinaryOpType::Lte, Val::Num(v2)) => Val::Bool(v1 <= v2),154		(Val::Num(v1), BinaryOpType::Gte, Val::Num(v2)) => Val::Bool(v1 >= v2),155156		(Val::Num(v1), BinaryOpType::BitAnd, Val::Num(v2)) => {157			Val::Num(((*v1 as i32) & (*v2 as i32)) as f64)158		}159		(Val::Num(v1), BinaryOpType::BitOr, Val::Num(v2)) => {160			Val::Num(((*v1 as i32) | (*v2 as i32)) as f64)161		}162		(Val::Num(v1), BinaryOpType::BitXor, Val::Num(v2)) => {163			Val::Num(((*v1 as i32) ^ (*v2 as i32)) as f64)164		}165		(Val::Num(v1), BinaryOpType::Lhs, Val::Num(v2)) => {166			if *v2 < 0.0 {167				throw!(RuntimeError("shift by negative exponent".into()))168			}169			Val::Num(((*v1 as i32) << (*v2 as i32)) as f64)170		}171		(Val::Num(v1), BinaryOpType::Rhs, Val::Num(v2)) => {172			if *v2 < 0.0 {173				throw!(RuntimeError("shift by negative exponent".into()))174			}175			Val::Num(((*v1 as i32) >> (*v2 as i32)) as f64)176		}177178		_ => throw!(BinaryOperatorDoesNotOperateOnValues(179			op,180			a.value_type(),181			b.value_type(),182		)),183	})184}185186pub fn evaluate_comp<T>(187	context: Context,188	value: &impl Fn(Context) -> Result<T>,189	specs: &[CompSpec],190) -> Result<Option<Vec<T>>> {191	Ok(match specs.get(0) {192		None => Some(vec![value(context)?]),193		Some(CompSpec::IfSpec(IfSpecData(cond))) => {194			if evaluate(context.clone(), cond)?.try_cast_bool("if spec")? {195				evaluate_comp(context, value, &specs[1..])?196			} else {197				None198			}199		}200		Some(CompSpec::ForSpec(ForSpecData(var, expr))) => match evaluate(context.clone(), expr)? {201			Val::Arr(list) => {202				let mut out = Vec::new();203				for item in list.iter() {204					out.push(evaluate_comp(205						context.clone().with_var(var.clone(), item?.clone()),206						value,207						&specs[1..],208					)?);209				}210				Some(out.into_iter().flatten().flatten().collect())211			}212			_ => throw!(InComprehensionCanOnlyIterateOverArray),213		},214	})215}216217pub fn evaluate_member_list_object(context: Context, members: &[Member]) -> Result<ObjValue> {218	let new_bindings = FutureWrapper::new();219	let future_this = FutureWrapper::new();220	let context_creator = context_creator!(221		closure!(clone context, clone new_bindings, |this: Option<ObjValue>, super_obj: Option<ObjValue>| {222			context.clone().extend_unbound(223				new_bindings.clone().unwrap(),224				context.dollar().clone().or_else(||this.clone()),225				Some(this.unwrap()),226				super_obj227			)228		})229	);230	{231		let mut bindings: HashMap<IStr, LazyBinding> = HashMap::new();232		for (n, b) in members233			.iter()234			.filter_map(|m| match m {235				Member::BindStmt(b) => Some(b.clone()),236				_ => None,237			})238			.map(|b| evaluate_binding(&b, context_creator.clone()))239		{240			bindings.insert(n, b);241		}242		new_bindings.fill(bindings);243	}244245	let mut new_members = FxHashMap::default();246	for member in members.iter() {247		match member {248			Member::Field(FieldMember {249				name,250				plus,251				params: None,252				visibility,253				value,254			}) => {255				let name = evaluate_field_name(context.clone(), name)?;256				if name.is_none() {257					continue;258				}259				let name = name.unwrap();260				new_members.insert(261					name.clone(),262					ObjMember {263						add: *plus,264						visibility: *visibility,265						invoke: LazyBinding::Bindable(Rc::new(266							closure!(clone name, clone value, clone context_creator, |this, super_obj| {267								Ok(LazyVal::new_resolved(evaluate(268									context_creator.0(this, super_obj)?,269									&value,270								)?))271							}),272						)),273						location: value.1.clone(),274					},275				);276			}277			Member::Field(FieldMember {278				name,279				params: Some(params),280				value,281				..282			}) => {283				let name = evaluate_field_name(context.clone(), name)?;284				if name.is_none() {285					continue;286				}287				let name = name.unwrap();288				new_members.insert(289					name.clone(),290					ObjMember {291						add: false,292						visibility: Visibility::Hidden,293						invoke: LazyBinding::Bindable(Rc::new(294							closure!(clone value, clone context_creator, clone params, clone name, |this, super_obj| {295								// TODO: Assert296								Ok(LazyVal::new_resolved(evaluate_method(297									context_creator.0(this, super_obj)?,298									name.clone(),299									params.clone(),300									value.clone(),301								)))302							}),303						)),304						location: value.1.clone(),305					},306				);307			}308			Member::BindStmt(_) => {}309			Member::AssertStmt(_) => {}310		}311	}312	let this = ObjValue::new(None, Rc::new(new_members));313	future_this.fill(this.clone());314	Ok(this)315}316317pub fn evaluate_object(context: Context, object: &ObjBody) -> Result<ObjValue> {318	Ok(match object {319		ObjBody::MemberList(members) => evaluate_member_list_object(context, members)?,320		ObjBody::ObjComp(obj) => {321			let future_this = FutureWrapper::new();322			let mut new_members = FxHashMap::default();323			for (k, v) in evaluate_comp(324				context.clone(),325				&|ctx| {326					let new_bindings = FutureWrapper::new();327					let context_creator = context_creator!(328						closure!(clone context, clone new_bindings, |this: Option<ObjValue>, super_obj: Option<ObjValue>| {329							context.clone().extend_unbound(330								new_bindings.clone().unwrap(),331								context.dollar().clone().or_else(||this.clone()),332								None,333								super_obj334							)335						})336					);337					let mut bindings: HashMap<IStr, LazyBinding> = HashMap::new();338					for (n, b) in obj339						.pre_locals340						.iter()341						.chain(obj.post_locals.iter())342						.map(|b| evaluate_binding(b, context_creator.clone()))343					{344						bindings.insert(n, b);345					}346					new_bindings.fill(bindings.clone());347					let ctx = ctx.extend_unbound(bindings, None, None, None)?;348					let key = evaluate(ctx.clone(), &obj.key)?;349					let value = LazyBinding::Bindable(Rc::new(350						closure!(clone ctx, clone obj.value, |this, _super_obj| {351							Ok(LazyVal::new_resolved(evaluate(ctx.clone().extend(FxHashMap::default(), None, this, None), &value)?))352						}),353					));354355					Ok((key, value))356				},357				&obj.compspecs,358			)?359			.unwrap()360			{361				match k {362					Val::Null => {}363					Val::Str(n) => {364						new_members.insert(365							n,366							ObjMember {367								add: false,368								visibility: Visibility::Normal,369								invoke: v,370								location: obj.value.1.clone(),371							},372						);373					}374					v => throw!(FieldMustBeStringGot(v.value_type())),375				}376			}377378			let this = ObjValue::new(None, Rc::new(new_members));379			future_this.fill(this.clone());380			this381		}382	})383}384385pub fn evaluate_apply(386	context: Context,387	value: &LocExpr,388	args: &ArgsDesc,389	loc: Option<&ExprLocation>,390	tailstrict: bool,391) -> Result<Val> {392	let value = evaluate(context.clone(), value)?;393	Ok(match value {394		Val::Func(f) => {395			let body = || f.evaluate(context, loc, args, tailstrict);396			if tailstrict {397				body()?398			} else {399				push(loc, || format!("function <{}> call", f.name()), body)?400			}401		}402		v => throw!(OnlyFunctionsCanBeCalledGot(v.value_type())),403	})404}405406pub fn evaluate_named(context: Context, lexpr: &LocExpr, name: IStr) -> Result<Val> {407	use Expr::*;408	let LocExpr(expr, _loc) = lexpr;409	Ok(match &**expr {410		Function(params, body) => evaluate_method(context, name, params.clone(), body.clone()),411		_ => evaluate(context, lexpr)?,412	})413}414415pub fn evaluate(context: Context, expr: &LocExpr) -> Result<Val> {416	use Expr::*;417	let LocExpr(expr, loc) = expr;418	Ok(match &**expr {419		Literal(LiteralType::This) => {420			Val::Obj(context.this().clone().ok_or(CantUseSelfOutsideOfObject)?)421		}422		Literal(LiteralType::Super) => Val::Obj(423			context424				.super_obj()425				.clone()426				.ok_or(NoSuperFound)?427				.with_this(context.this().clone().unwrap()),428		),429		Literal(LiteralType::Dollar) => {430			Val::Obj(context.dollar().clone().ok_or(NoTopLevelObjectFound)?)431		}432		Literal(LiteralType::True) => Val::Bool(true),433		Literal(LiteralType::False) => Val::Bool(false),434		Literal(LiteralType::Null) => Val::Null,435		Parened(e) => evaluate(context, e)?,436		Str(v) => Val::Str(v.clone()),437		Num(v) => Val::new_checked_num(*v)?,438		BinaryOp(v1, o, v2) => evaluate_binary_op_special(context, v1, *o, v2)?,439		UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(context, v)?)?,440		Var(name) => push(441			loc.as_ref(),442			|| format!("variable <{}>", name),443			|| context.binding(name.clone())?.evaluate(),444		)?,445		Index(value, index) => {446			match (evaluate(context.clone(), value)?, evaluate(context, index)?) {447				(Val::Obj(v), Val::Str(s)) => {448					let sn = s.clone();449					push(450						loc.as_ref(),451						|| format!("field <{}> access", sn),452						|| {453							if let Some(v) = v.get(s.clone())? {454								Ok(v)455							} else if v.get("__intrinsic_namespace__".into())?.is_some() {456								Ok(Val::Func(Rc::new(FuncVal::Intrinsic(s))))457							} else {458								throw!(NoSuchField(s))459							}460						},461					)?462				}463				(Val::Obj(_), n) => throw!(ValueIndexMustBeTypeGot(464					ValType::Obj,465					ValType::Str,466					n.value_type(),467				)),468469				(Val::Arr(v), Val::Num(n)) => {470					if n.fract() > f64::EPSILON {471						throw!(FractionalIndex)472					}473					v.get(n as usize)?474						.ok_or_else(|| ArrayBoundsError(n as usize, v.len()))?475				}476				(Val::Arr(_), Val::Str(n)) => throw!(AttemptedIndexAnArrayWithString(n)),477				(Val::Arr(_), n) => throw!(ValueIndexMustBeTypeGot(478					ValType::Arr,479					ValType::Num,480					n.value_type(),481				)),482483				(Val::Str(s), Val::Num(n)) => Val::Str(484					s.chars()485						.skip(n as usize)486						.take(1)487						.collect::<String>()488						.into(),489				),490				(Val::Str(_), n) => throw!(ValueIndexMustBeTypeGot(491					ValType::Str,492					ValType::Num,493					n.value_type(),494				)),495496				(v, _) => throw!(CantIndexInto(v.value_type())),497			}498		}499		LocalExpr(bindings, returned) => {500			let mut new_bindings: HashMap<IStr, LazyBinding> = HashMap::new();501			let future_context = Context::new_future();502503			let context_creator = context_creator!(504				closure!(clone future_context, |_, _| Ok(future_context.clone().unwrap()))505			);506507			for (k, v) in bindings508				.iter()509				.map(|b| evaluate_binding(b, context_creator.clone()))510			{511				new_bindings.insert(k, v);512			}513514			let context = context515				.extend_unbound(new_bindings, None, None, None)?516				.into_future(future_context);517			evaluate(context, &returned.clone())?518		}519		Arr(items) => {520			let mut out = Vec::with_capacity(items.len());521			for item in items {522				out.push(LazyVal::new(Box::new(523					closure!(clone context, clone item, || {524						evaluate(context.clone(), &item)525					}),526				)));527			}528			Val::Arr(out.into())529		}530		ArrComp(expr, comp_specs) => Val::Arr(531			// First comp_spec should be for_spec, so no "None" possible here532			evaluate_comp(context, &|ctx| evaluate(ctx, expr), comp_specs)?533				.unwrap()534				.into(),535		),536		Obj(body) => Val::Obj(evaluate_object(context, body)?),537		ObjExtend(s, t) => evaluate_add_op(538			&evaluate(context.clone(), s)?,539			&Val::Obj(evaluate_object(context, t)?),540		)?,541		Apply(value, args, tailstrict) => {542			evaluate_apply(context, value, args, loc.as_ref(), *tailstrict)?543		}544		Function(params, body) => {545			evaluate_method(context, "anonymous".into(), params.clone(), body.clone())546		}547		Intrinsic(name) => Val::Func(Rc::new(FuncVal::Intrinsic(name.clone()))),548		AssertExpr(AssertStmt(value, msg), returned) => {549			let assertion_result = push(550				value.1.as_ref(),551				|| "assertion condition".to_owned(),552				|| {553					evaluate(context.clone(), value)?554						.try_cast_bool("assertion condition should be of type `boolean`")555				},556			)?;557			if assertion_result {558				evaluate(context, returned)?559			} else {560				push(561					value.1.as_ref(),562					|| "assertion failure".to_owned(),563					|| {564						if let Some(msg) = msg {565							throw!(AssertionFailed(evaluate(context, msg)?.to_string()?));566						} else {567							throw!(AssertionFailed(Val::Null.to_string()?));568						}569					},570				)?571			}572		}573		ErrorStmt(e) => push(574			loc.as_ref(),575			|| "error statement".to_owned(),576			|| {577				throw!(RuntimeError(578					evaluate(context, e)?.try_cast_str("error text should be of type `string`")?,579				))580			},581		)?,582		IfElse {583			cond,584			cond_then,585			cond_else,586		} => {587			if push(588				loc.as_ref(),589				|| "if condition".to_owned(),590				|| evaluate(context.clone(), &cond.0)?.try_cast_bool("in if condition"),591			)? {592				evaluate(context, cond_then)?593			} else {594				match cond_else {595					Some(v) => evaluate(context, v)?,596					None => Val::Null,597				}598			}599		}600		Import(path) => {601			let mut tmp = loc602				.clone()603				.expect("imports cannot be used without loc_data")604				.0;605			let import_location = Rc::make_mut(&mut tmp);606			import_location.pop();607			push(608				loc.as_ref(),609				|| format!("import {:?}", path),610				|| with_state(|s| s.import_file(import_location, path)),611			)?612		}613		ImportStr(path) => {614			let mut tmp = loc615				.clone()616				.expect("imports cannot be used without loc_data")617				.0;618			let import_location = Rc::make_mut(&mut tmp);619			import_location.pop();620			Val::Str(with_state(|s| s.import_file_str(import_location, path))?)621		}622	})623}
after · crates/jrsonnet-evaluator/src/evaluate.rs
1use crate::{2	error::Error::*, lazy_val, push, throw, with_state, Context, ContextCreator, FuncDesc, FuncVal,3	FutureWrapper, LazyBinding, LazyVal, ObjMember, ObjValue, Result, Val,4};5use closure::closure;6use jrsonnet_interner::IStr;7use jrsonnet_parser::{8	ArgsDesc, AssertStmt, BinaryOpType, BindSpec, CompSpec, Expr, ExprLocation, FieldMember,9	ForSpecData, IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc, UnaryOpType,10	Visibility,11};12use jrsonnet_types::ValType;13use rustc_hash::{FxHashMap, FxHasher};14use std::{collections::HashMap, hash::BuildHasherDefault, rc::Rc};1516pub fn evaluate_binding_in_future(17	b: &BindSpec,18	context_creator: FutureWrapper<Context>,19) -> LazyVal {20	let b = b.clone();21	if let Some(params) = &b.params {22		let params = params.clone();23		LazyVal::new(Box::new(move || {24			Ok(evaluate_method(25				context_creator.unwrap(),26				b.name.clone(),27				params.clone(),28				b.value.clone(),29			))30		}))31	} else {32		LazyVal::new(Box::new(move || {33			evaluate_named(context_creator.unwrap(), &b.value, b.name.clone())34		}))35	}36}3738pub fn evaluate_binding(b: &BindSpec, context_creator: ContextCreator) -> (IStr, LazyBinding) {39	let b = b.clone();40	if let Some(params) = &b.params {41		let params = params.clone();42		(43			b.name.clone(),44			LazyBinding::Bindable(Rc::new(move |this, super_obj| {45				Ok(lazy_val!(46					closure!(clone b, clone params, clone context_creator, || Ok(evaluate_method(47						context_creator.create(this.clone(), super_obj.clone())?,48						b.name.clone(),49						params.clone(),50						b.value.clone(),51					)))52				))53			})),54		)55	} else {56		(57			b.name.clone(),58			LazyBinding::Bindable(Rc::new(move |this, super_obj| {59				Ok(lazy_val!(closure!(clone context_creator, clone b, ||60					evaluate_named(61						context_creator.create(this.clone(), super_obj.clone())?,62						&b.value,63						b.name.clone()64					)65				)))66			})),67		)68	}69}7071pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {72	Val::Func(Rc::new(FuncVal::Normal(FuncDesc {73		name,74		ctx,75		params,76		body,77	})))78}7980pub fn evaluate_field_name(81	context: Context,82	field_name: &jrsonnet_parser::FieldName,83) -> Result<Option<IStr>> {84	Ok(match field_name {85		jrsonnet_parser::FieldName::Fixed(n) => Some(n.clone()),86		jrsonnet_parser::FieldName::Dyn(expr) => {87			let value = evaluate(context, expr)?;88			if matches!(value, Val::Null) {89				None90			} else {91				Some(value.try_cast_str("dynamic field name")?)92			}93		}94	})95}9697pub fn evaluate_unary_op(op: UnaryOpType, b: &Val) -> Result<Val> {98	Ok(match (op, b) {99		(UnaryOpType::Not, Val::Bool(v)) => Val::Bool(!v),100		(UnaryOpType::Minus, Val::Num(n)) => Val::Num(-*n),101		(UnaryOpType::BitNot, Val::Num(n)) => Val::Num(!(*n as i32) as f64),102		(op, o) => throw!(UnaryOperatorDoesNotOperateOnType(op, o.value_type())),103	})104}105106pub fn evaluate_add_op(a: &Val, b: &Val) -> Result<Val> {107	Ok(match (a, b) {108		(Val::Str(v1), Val::Str(v2)) => Val::Str(((**v1).to_owned() + v2).into()),109110		// Can't use generic json serialization way, because it depends on number to string concatenation (std.jsonnet:890)111		(Val::Num(n), Val::Str(o)) => Val::Str(format!("{}{}", n, o).into()),112		(Val::Str(o), Val::Num(n)) => Val::Str(format!("{}{}", o, n).into()),113114		(Val::Str(s), o) => Val::Str(format!("{}{}", s, o.clone().to_string()?).into()),115		(o, Val::Str(s)) => Val::Str(format!("{}{}", o.clone().to_string()?, s).into()),116117		(Val::Obj(v1), Val::Obj(v2)) => Val::Obj(v2.extend_from(v1.clone())),118		(Val::Arr(a), Val::Arr(b)) => {119			let mut out = Vec::with_capacity(a.len() + b.len());120			out.extend(a.iter_lazy());121			out.extend(b.iter_lazy());122			Val::Arr(out.into())123		}124		(Val::Num(v1), Val::Num(v2)) => Val::new_checked_num(v1 + v2)?,125		_ => throw!(BinaryOperatorDoesNotOperateOnValues(126			BinaryOpType::Add,127			a.value_type(),128			b.value_type(),129		)),130	})131}132133pub fn evaluate_binary_op_special(134	context: Context,135	a: &LocExpr,136	op: BinaryOpType,137	b: &LocExpr,138) -> Result<Val> {139	Ok(match (evaluate(context.clone(), a)?, op, b) {140		(Val::Bool(true), BinaryOpType::Or, _o) => Val::Bool(true),141		(Val::Bool(false), BinaryOpType::And, _o) => Val::Bool(false),142		(a, op, eb) => evaluate_binary_op_normal(&a, op, &evaluate(context, eb)?)?,143	})144}145146pub fn evaluate_binary_op_normal(a: &Val, op: BinaryOpType, b: &Val) -> Result<Val> {147	Ok(match (a, op, b) {148		(a, BinaryOpType::Add, b) => evaluate_add_op(a, b)?,149150		(Val::Str(v1), BinaryOpType::Mul, Val::Num(v2)) => Val::Str(v1.repeat(*v2 as usize).into()),151152		// Bool X Bool153		(Val::Bool(a), BinaryOpType::And, Val::Bool(b)) => Val::Bool(*a && *b),154		(Val::Bool(a), BinaryOpType::Or, Val::Bool(b)) => Val::Bool(*a || *b),155156		// Str X Str157		(Val::Str(v1), BinaryOpType::Lt, Val::Str(v2)) => Val::Bool(v1 < v2),158		(Val::Str(v1), BinaryOpType::Gt, Val::Str(v2)) => Val::Bool(v1 > v2),159		(Val::Str(v1), BinaryOpType::Lte, Val::Str(v2)) => Val::Bool(v1 <= v2),160		(Val::Str(v1), BinaryOpType::Gte, Val::Str(v2)) => Val::Bool(v1 >= v2),161162		// Num X Num163		(Val::Num(v1), BinaryOpType::Mul, Val::Num(v2)) => Val::new_checked_num(v1 * v2)?,164		(Val::Num(v1), BinaryOpType::Div, Val::Num(v2)) => {165			if *v2 <= f64::EPSILON {166				throw!(DivisionByZero)167			}168			Val::new_checked_num(v1 / v2)?169		}170171		(Val::Num(v1), BinaryOpType::Sub, Val::Num(v2)) => Val::new_checked_num(v1 - v2)?,172173		(Val::Num(v1), BinaryOpType::Lt, Val::Num(v2)) => Val::Bool(v1 < v2),174		(Val::Num(v1), BinaryOpType::Gt, Val::Num(v2)) => Val::Bool(v1 > v2),175		(Val::Num(v1), BinaryOpType::Lte, Val::Num(v2)) => Val::Bool(v1 <= v2),176		(Val::Num(v1), BinaryOpType::Gte, Val::Num(v2)) => Val::Bool(v1 >= v2),177178		(Val::Num(v1), BinaryOpType::BitAnd, Val::Num(v2)) => {179			Val::Num(((*v1 as i32) & (*v2 as i32)) as f64)180		}181		(Val::Num(v1), BinaryOpType::BitOr, Val::Num(v2)) => {182			Val::Num(((*v1 as i32) | (*v2 as i32)) as f64)183		}184		(Val::Num(v1), BinaryOpType::BitXor, Val::Num(v2)) => {185			Val::Num(((*v1 as i32) ^ (*v2 as i32)) as f64)186		}187		(Val::Num(v1), BinaryOpType::Lhs, Val::Num(v2)) => {188			if *v2 < 0.0 {189				throw!(RuntimeError("shift by negative exponent".into()))190			}191			Val::Num(((*v1 as i32) << (*v2 as i32)) as f64)192		}193		(Val::Num(v1), BinaryOpType::Rhs, Val::Num(v2)) => {194			if *v2 < 0.0 {195				throw!(RuntimeError("shift by negative exponent".into()))196			}197			Val::Num(((*v1 as i32) >> (*v2 as i32)) as f64)198		}199200		_ => throw!(BinaryOperatorDoesNotOperateOnValues(201			op,202			a.value_type(),203			b.value_type(),204		)),205	})206}207208pub fn evaluate_comp<T>(209	context: Context,210	value: &impl Fn(Context) -> Result<T>,211	specs: &[CompSpec],212) -> Result<Option<Vec<T>>> {213	Ok(match specs.get(0) {214		None => Some(vec![value(context)?]),215		Some(CompSpec::IfSpec(IfSpecData(cond))) => {216			if evaluate(context.clone(), cond)?.try_cast_bool("if spec")? {217				evaluate_comp(context, value, &specs[1..])?218			} else {219				None220			}221		}222		Some(CompSpec::ForSpec(ForSpecData(var, expr))) => match evaluate(context.clone(), expr)? {223			Val::Arr(list) => {224				let mut out = Vec::new();225				for item in list.iter() {226					out.push(evaluate_comp(227						context.clone().with_var(var.clone(), item?.clone()),228						value,229						&specs[1..],230					)?);231				}232				Some(out.into_iter().flatten().flatten().collect())233			}234			_ => throw!(InComprehensionCanOnlyIterateOverArray),235		},236	})237}238239pub fn evaluate_member_list_object(context: Context, members: &[Member]) -> Result<ObjValue> {240	let new_bindings = FutureWrapper::new();241	let future_this = FutureWrapper::new();242	let context_creator = ContextCreator(context.clone(), new_bindings.clone());243	{244		let mut bindings: FxHashMap<IStr, LazyBinding> =245			FxHashMap::with_capacity_and_hasher(members.len(), BuildHasherDefault::default());246		for (n, b) in members247			.iter()248			.filter_map(|m| match m {249				Member::BindStmt(b) => Some(b.clone()),250				_ => None,251			})252			.map(|b| evaluate_binding(&b, context_creator.clone()))253		{254			bindings.insert(n, b);255		}256		new_bindings.fill(bindings);257	}258259	let mut new_members = FxHashMap::default();260	for member in members.iter() {261		match member {262			Member::Field(FieldMember {263				name,264				plus,265				params: None,266				visibility,267				value,268			}) => {269				let name = evaluate_field_name(context.clone(), name)?;270				if name.is_none() {271					continue;272				}273				let name = name.unwrap();274				new_members.insert(275					name.clone(),276					ObjMember {277						add: *plus,278						visibility: *visibility,279						invoke: LazyBinding::Bindable(Rc::new(280							closure!(clone name, clone value, clone context_creator, |this, super_obj| {281								Ok(LazyVal::new_resolved(evaluate(282									context_creator.create(this, super_obj)?,283									&value,284								)?))285							}),286						)),287						location: value.1.clone(),288					},289				);290			}291			Member::Field(FieldMember {292				name,293				params: Some(params),294				value,295				..296			}) => {297				let name = evaluate_field_name(context.clone(), name)?;298				if name.is_none() {299					continue;300				}301				let name = name.unwrap();302				new_members.insert(303					name.clone(),304					ObjMember {305						add: false,306						visibility: Visibility::Hidden,307						invoke: LazyBinding::Bindable(Rc::new(308							closure!(clone value, clone context_creator, clone params, clone name, |this, super_obj| {309								// TODO: Assert310								Ok(LazyVal::new_resolved(evaluate_method(311									context_creator.create(this, super_obj)?,312									name.clone(),313									params.clone(),314									value.clone(),315								)))316							}),317						)),318						location: value.1.clone(),319					},320				);321			}322			Member::BindStmt(_) => {}323			Member::AssertStmt(_) => {}324		}325	}326	let this = ObjValue::new(None, Rc::new(new_members));327	future_this.fill(this.clone());328	Ok(this)329}330331pub fn evaluate_object(context: Context, object: &ObjBody) -> Result<ObjValue> {332	Ok(match object {333		ObjBody::MemberList(members) => evaluate_member_list_object(context, members)?,334		ObjBody::ObjComp(obj) => {335			let future_this = FutureWrapper::new();336			let mut new_members = FxHashMap::default();337			for (k, v) in evaluate_comp(338				context.clone(),339				&|ctx| {340					let new_bindings = FutureWrapper::new();341					let context_creator = ContextCreator(context.clone(), new_bindings.clone());342					let mut bindings: FxHashMap<IStr, LazyBinding> = FxHashMap::with_capacity_and_hasher(obj.pre_locals.len() + obj.post_locals.len(), BuildHasherDefault::default());343					for (n, b) in obj344						.pre_locals345						.iter()346						.chain(obj.post_locals.iter())347						.map(|b| evaluate_binding(b, context_creator.clone()))348					{349						bindings.insert(n, b);350					}351					new_bindings.fill(bindings.clone());352					let ctx = ctx.extend_unbound(bindings, None, None, None)?;353					let key = evaluate(ctx.clone(), &obj.key)?;354					let value = LazyBinding::Bindable(Rc::new(355						closure!(clone ctx, clone obj.value, |this, _super_obj| {356							Ok(LazyVal::new_resolved(evaluate(ctx.clone().extend(FxHashMap::default(), None, this, None), &value)?))357						}),358					));359360					Ok((key, value))361				},362				&obj.compspecs,363			)?364			.unwrap()365			{366				match k {367					Val::Null => {}368					Val::Str(n) => {369						new_members.insert(370							n,371							ObjMember {372								add: false,373								visibility: Visibility::Normal,374								invoke: v,375								location: obj.value.1.clone(),376							},377						);378					}379					v => throw!(FieldMustBeStringGot(v.value_type())),380				}381			}382383			let this = ObjValue::new(None, Rc::new(new_members));384			future_this.fill(this.clone());385			this386		}387	})388}389390pub fn evaluate_apply(391	context: Context,392	value: &LocExpr,393	args: &ArgsDesc,394	loc: Option<&ExprLocation>,395	tailstrict: bool,396) -> Result<Val> {397	let value = evaluate(context.clone(), value)?;398	Ok(match value {399		Val::Func(f) => {400			let body = || f.evaluate(context, loc, args, tailstrict);401			if tailstrict {402				body()?403			} else {404				push(loc, || format!("function <{}> call", f.name()), body)?405			}406		}407		v => throw!(OnlyFunctionsCanBeCalledGot(v.value_type())),408	})409}410411pub fn evaluate_named(context: Context, lexpr: &LocExpr, name: IStr) -> Result<Val> {412	use Expr::*;413	let LocExpr(expr, _loc) = lexpr;414	Ok(match &**expr {415		Function(params, body) => evaluate_method(context, name, params.clone(), body.clone()),416		_ => evaluate(context, lexpr)?,417	})418}419420pub fn evaluate(context: Context, expr: &LocExpr) -> Result<Val> {421	use Expr::*;422	let LocExpr(expr, loc) = expr;423	Ok(match &**expr {424		Literal(LiteralType::This) => {425			Val::Obj(context.this().clone().ok_or(CantUseSelfOutsideOfObject)?)426		}427		Literal(LiteralType::Super) => Val::Obj(428			context429				.super_obj()430				.clone()431				.ok_or(NoSuperFound)?432				.with_this(context.this().clone().unwrap()),433		),434		Literal(LiteralType::Dollar) => {435			Val::Obj(context.dollar().clone().ok_or(NoTopLevelObjectFound)?)436		}437		Literal(LiteralType::True) => Val::Bool(true),438		Literal(LiteralType::False) => Val::Bool(false),439		Literal(LiteralType::Null) => Val::Null,440		Parened(e) => evaluate(context, e)?,441		Str(v) => Val::Str(v.clone()),442		Num(v) => Val::new_checked_num(*v)?,443		BinaryOp(v1, o, v2) => evaluate_binary_op_special(context, v1, *o, v2)?,444		UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(context, v)?)?,445		Var(name) => push(446			loc.as_ref(),447			|| format!("variable <{}>", name),448			|| context.binding(name.clone())?.evaluate(),449		)?,450		Index(value, index) => {451			match (evaluate(context.clone(), value)?, evaluate(context, index)?) {452				(Val::Obj(v), Val::Str(s)) => {453					let sn = s.clone();454					push(455						loc.as_ref(),456						|| format!("field <{}> access", sn),457						|| {458							if let Some(v) = v.get(s.clone())? {459								Ok(v)460							} else if v.get("__intrinsic_namespace__".into())?.is_some() {461								Ok(Val::Func(Rc::new(FuncVal::Intrinsic(s))))462							} else {463								throw!(NoSuchField(s))464							}465						},466					)?467				}468				(Val::Obj(_), n) => throw!(ValueIndexMustBeTypeGot(469					ValType::Obj,470					ValType::Str,471					n.value_type(),472				)),473474				(Val::Arr(v), Val::Num(n)) => {475					if n.fract() > f64::EPSILON {476						throw!(FractionalIndex)477					}478					v.get(n as usize)?479						.ok_or_else(|| ArrayBoundsError(n as usize, v.len()))?480				}481				(Val::Arr(_), Val::Str(n)) => throw!(AttemptedIndexAnArrayWithString(n)),482				(Val::Arr(_), n) => throw!(ValueIndexMustBeTypeGot(483					ValType::Arr,484					ValType::Num,485					n.value_type(),486				)),487488				(Val::Str(s), Val::Num(n)) => Val::Str(489					s.chars()490						.skip(n as usize)491						.take(1)492						.collect::<String>()493						.into(),494				),495				(Val::Str(_), n) => throw!(ValueIndexMustBeTypeGot(496					ValType::Str,497					ValType::Num,498					n.value_type(),499				)),500501				(v, _) => throw!(CantIndexInto(v.value_type())),502			}503		}504		LocalExpr(bindings, returned) => {505			let mut new_bindings: FxHashMap<IStr, LazyVal> = HashMap::with_capacity_and_hasher(506				bindings.len(),507				BuildHasherDefault::<FxHasher>::default(),508			);509			let future_context = Context::new_future();510			for b in bindings {511				new_bindings.insert(512					b.name.clone(),513					evaluate_binding_in_future(b, future_context.clone()),514				);515			}516			let context = context517				.extend_bound(new_bindings)518				.into_future(future_context);519			evaluate(context, &returned.clone())?520		}521		Arr(items) => {522			let mut out = Vec::with_capacity(items.len());523			for item in items {524				out.push(LazyVal::new(Box::new(525					closure!(clone context, clone item, || {526						evaluate(context.clone(), &item)527					}),528				)));529			}530			Val::Arr(out.into())531		}532		ArrComp(expr, comp_specs) => Val::Arr(533			// First comp_spec should be for_spec, so no "None" possible here534			evaluate_comp(context, &|ctx| evaluate(ctx, expr), comp_specs)?535				.unwrap()536				.into(),537		),538		Obj(body) => Val::Obj(evaluate_object(context, body)?),539		ObjExtend(s, t) => evaluate_add_op(540			&evaluate(context.clone(), s)?,541			&Val::Obj(evaluate_object(context, t)?),542		)?,543		Apply(value, args, tailstrict) => {544			evaluate_apply(context, value, args, loc.as_ref(), *tailstrict)?545		}546		Function(params, body) => {547			evaluate_method(context, "anonymous".into(), params.clone(), body.clone())548		}549		Intrinsic(name) => Val::Func(Rc::new(FuncVal::Intrinsic(name.clone()))),550		AssertExpr(AssertStmt(value, msg), returned) => {551			let assertion_result = push(552				value.1.as_ref(),553				|| "assertion condition".to_owned(),554				|| {555					evaluate(context.clone(), value)?556						.try_cast_bool("assertion condition should be of type `boolean`")557				},558			)?;559			if assertion_result {560				evaluate(context, returned)?561			} else {562				push(563					value.1.as_ref(),564					|| "assertion failure".to_owned(),565					|| {566						if let Some(msg) = msg {567							throw!(AssertionFailed(evaluate(context, msg)?.to_string()?));568						} else {569							throw!(AssertionFailed(Val::Null.to_string()?));570						}571					},572				)?573			}574		}575		ErrorStmt(e) => push(576			loc.as_ref(),577			|| "error statement".to_owned(),578			|| {579				throw!(RuntimeError(580					evaluate(context, e)?.try_cast_str("error text should be of type `string`")?,581				))582			},583		)?,584		IfElse {585			cond,586			cond_then,587			cond_else,588		} => {589			if push(590				loc.as_ref(),591				|| "if condition".to_owned(),592				|| evaluate(context.clone(), &cond.0)?.try_cast_bool("in if condition"),593			)? {594				evaluate(context, cond_then)?595			} else {596				match cond_else {597					Some(v) => evaluate(context, v)?,598					None => Val::Null,599				}600			}601		}602		Import(path) => {603			let mut tmp = loc604				.clone()605				.expect("imports cannot be used without loc_data")606				.0;607			let import_location = Rc::make_mut(&mut tmp);608			import_location.pop();609			push(610				loc.as_ref(),611				|| format!("import {:?}", path),612				|| with_state(|s| s.import_file(import_location, path)),613			)?614		}615		ImportStr(path) => {616			let mut tmp = loc617				.clone()618				.expect("imports cannot be used without loc_data")619				.0;620			let import_location = Rc::make_mut(&mut tmp);621			import_location.pop();622			Val::Str(with_state(|s| s.import_file_str(import_location, path))?)623		}624	})625}
modifiedcrates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/lib.rs
+++ b/crates/jrsonnet-evaluator/src/lib.rs
@@ -27,10 +27,12 @@
 use jrsonnet_parser::*;
 use native::NativeCallback;
 pub use obj::*;
+use rustc_hash::FxHashMap;
 use std::{
 	cell::{Ref, RefCell, RefMut},
 	collections::HashMap,
 	fmt::Debug,
+	hash::BuildHasherDefault,
 	path::PathBuf,
 	rc::Rc,
 };
@@ -230,7 +232,7 @@
 			}
 			value.parsed.clone()
 		};
-		let value = evaluate(self.create_default_context()?, &expr)?;
+		let value = evaluate(self.create_default_context(), &expr)?;
 		{
 			self.data_mut()
 				.files
@@ -260,16 +262,14 @@
 	}
 
 	/// Creates context with all passed global variables
-	pub fn create_default_context(&self) -> Result<Context> {
+	pub fn create_default_context(&self) -> Context {
 		let globals = &self.settings().globals;
-		let mut new_bindings: HashMap<IStr, LazyBinding> = HashMap::new();
+		let mut new_bindings: FxHashMap<IStr, LazyVal> =
+			FxHashMap::with_capacity_and_hasher(globals.len(), BuildHasherDefault::default());
 		for (name, value) in globals.iter() {
-			new_bindings.insert(
-				name.clone(),
-				LazyBinding::Bound(resolved_lazy_val!(value.clone())),
-			);
+			new_bindings.insert(name.clone(), resolved_lazy_val!(value.clone()));
 		}
-		Context::new().extend_unbound(new_bindings, None, None, None)
+		Context::new().extend_bound(new_bindings)
 	}
 
 	/// Executes code creating a new stack frame
@@ -345,7 +345,7 @@
 					|| "during TLA call".to_owned(),
 					|| {
 						func.evaluate_map(
-							self.create_default_context()?,
+							self.create_default_context(),
 							&self.settings().tla_vars,
 							true,
 						)
@@ -396,7 +396,7 @@
 	}
 	/// Evaluates the parsed expression
 	pub fn evaluate_expr_raw(&self, code: LocExpr) -> Result<Val> {
-		self.run_in_state(|| evaluate(self.create_default_context()?, &code))
+		self.run_in_state(|| evaluate(self.create_default_context(), &code))
 	}
 }
 
@@ -950,6 +950,23 @@
 		Ok(())
 	}
 
+	#[test]
+	fn comp_self() -> crate::error::Result<()> {
+		assert_eval!(
+			r#"
+			std.objectFields({
+				a:{
+					[name]: name for name in std.objectFields(self)
+				},
+				b: 2,
+				c: 3,
+			}.a) == ['a', 'b', 'c']
+			"#
+		);
+
+		Ok(())
+	}
+
 	struct TestImportResolver(IStr);
 	impl crate::import::ImportResolver for TestImportResolver {
 		fn resolve_file(&self, _: &PathBuf, _: &PathBuf) -> crate::error::Result<Rc<PathBuf>> {
modifiedcrates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/val.rs
+++ b/crates/jrsonnet-evaluator/src/val.rs
@@ -535,7 +535,7 @@
 	pub fn to_yaml(&self, padding: usize) -> Result<IStr> {
 		with_state(|s| {
 			let ctx = s
-				.create_default_context()?
+				.create_default_context()
 				.with_var("__tmp__to_json__".into(), self.clone());
 			evaluate(
 				ctx,