difftreelog
feat update libjsonnet to use gc
in: master
4 files changed
bindings/jsonnet/Cargo.tomldiffbeforeafterboth--- a/bindings/jsonnet/Cargo.toml
+++ b/bindings/jsonnet/Cargo.toml
@@ -11,6 +11,7 @@
jrsonnet-interner = { path = "../../crates/jrsonnet-interner", version = "0.3.8" }
jrsonnet-evaluator = { path = "../../crates/jrsonnet-evaluator", version = "0.3.8" }
jrsonnet-parser = { path = "../../crates/jrsonnet-parser", version = "0.3.8" }
+gc = { version = "0.4.1", features = ["derive"] }
[lib]
crate-type = ["cdylib"]
bindings/jsonnet/src/native.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/native.rs
+++ b/bindings/jsonnet/src/native.rs
@@ -1,8 +1,14 @@
-use jrsonnet_evaluator::{error::Error, native::NativeCallback, EvaluationState, Val};
+use gc::{unsafe_empty_trace, Finalize, Gc, Trace};
+use jrsonnet_evaluator::{
+ error::{Error, LocError},
+ native::{NativeCallback, NativeCallbackHandler},
+ EvaluationState, Val,
+};
use jrsonnet_parser::{Param, ParamsDesc};
use std::{
ffi::{c_void, CStr},
os::raw::{c_char, c_int},
+ path::PathBuf,
rc::Rc,
};
@@ -12,6 +18,39 @@
success: *mut c_int,
) -> *mut Val;
+struct JsonnetNativeCallbackHandler {
+ ctx: *const c_void,
+ cb: JsonnetNativeCallback,
+}
+impl Finalize for JsonnetNativeCallbackHandler {}
+unsafe impl Trace for JsonnetNativeCallbackHandler {
+ unsafe_empty_trace!();
+}
+impl NativeCallbackHandler for JsonnetNativeCallbackHandler {
+ fn call(&self, _from: Option<Rc<PathBuf>>, args: &[Val]) -> Result<Val, LocError> {
+ let mut n_args = Vec::new();
+ for a in args {
+ n_args.push(Some(Box::new(a.clone())));
+ }
+ n_args.push(None);
+ let mut success = 1;
+ let v = unsafe {
+ (self.cb)(
+ self.ctx,
+ &n_args as *const _ as *const *const Val,
+ &mut success,
+ )
+ };
+ let v = unsafe { *Box::from_raw(v) };
+ if success == 1 {
+ Ok(v)
+ } else {
+ let e = v.try_cast_str("native error").expect("error msg");
+ Err(Error::RuntimeError(e).into())
+ }
+ }
+}
+
/// # Safety
#[no_mangle]
pub unsafe extern "C" fn jsonnet_native_callback(
@@ -21,5 +60,23 @@
ctx: *const c_void,
mut raw_params: *const *const c_char,
) {
- todo!()
+ let name = CStr::from_ptr(name).to_str().expect("utf8 name").into();
+ let mut params = Vec::new();
+ loop {
+ if (*raw_params).is_null() {
+ break;
+ }
+ let param = CStr::from_ptr(*raw_params).to_str().expect("not utf8");
+ params.push(Param(param.into(), None));
+ raw_params = raw_params.offset(1);
+ }
+ let params = ParamsDesc(Rc::new(params));
+
+ vm.add_native(
+ name,
+ Gc::new(NativeCallback::new(
+ params,
+ Box::new(JsonnetNativeCallbackHandler { ctx, cb }),
+ )),
+ )
}
bindings/jsonnet/src/val_make.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/val_make.rs
+++ b/bindings/jsonnet/src/val_make.rs
@@ -1,10 +1,10 @@
//! Create values in VM
+use gc::Gc;
use jrsonnet_evaluator::{ArrValue, EvaluationState, ObjValue, Val};
use std::{
ffi::CStr,
os::raw::{c_char, c_double, c_int},
- rc::Rc,
};
/// # Safety
@@ -38,7 +38,7 @@
#[no_mangle]
pub extern "C" fn jsonnet_json_make_array(_vm: &EvaluationState) -> *mut Val {
- todo!()
+ Box::into_raw(Box::new(Val::Arr(ArrValue::Eager(Gc::new(Vec::new())))))
}
#[no_mangle]
bindings/jsonnet/src/val_modify.rsdiffbeforeafterboth1//! Modify VM values2//! Only tested with variables, which haven't altered by code before appearing here3//! In jrsonnet every value is immutable, and this code is probally broken45use jrsonnet_evaluator::{EvaluationState, LazyBinding, LazyVal, ObjMember, Val};6use jrsonnet_parser::Visibility;7use std::{ffi::CStr, os::raw::c_char};89/// # Safety10///11/// Received arr value should be correct pointer to array allocated by make_array12#[no_mangle]13pub unsafe extern "C" fn jsonnet_json_array_append(14 _vm: &EvaluationState,15 arr: &mut Val,16 val: &Val,17) {18 match arr {19 Val::Arr(old) => {20 let mut new = Vec::new();21 for item in old.iter_lazy() {22 new.push(item);23 }24 new.push(LazyVal::new_resolved(val.clone()));25 // *arr = Val::Arr(ArrValue::Lazy(Gc::new(new)));26 todo!()27 }28 _ => panic!("should receive array"),29 }30}3132/// # Safety33///34/// This function is safe if passed name is ok35#[no_mangle]36pub unsafe extern "C" fn jsonnet_json_object_append(37 _vm: &EvaluationState,38 obj: &mut Val,39 name: *const c_char,40 val: &Val,41) {42 match obj {43 Val::Obj(old) => {44 let new_obj = old.clone().extend_with_field(45 CStr::from_ptr(name).to_str().unwrap().into(),46 ObjMember {47 add: false,48 visibility: Visibility::Normal,49 invoke: LazyBinding::Bound(LazyVal::new_resolved(val.clone())),50 location: None,51 },52 );5354 *obj = Val::Obj(new_obj);55 }56 _ => panic!("should receive object"),57 }58}1//! Modify VM values2//! Only tested with variables, which haven't altered by code before appearing here3//! In jrsonnet every value is immutable, and this code is probally broken45use gc::Gc;6use jrsonnet_evaluator::{ArrValue, EvaluationState, LazyBinding, LazyVal, ObjMember, Val};7use jrsonnet_parser::Visibility;8use std::{ffi::CStr, os::raw::c_char};910/// # Safety11///12/// Received arr value should be correct pointer to array allocated by make_array13#[no_mangle]14pub unsafe extern "C" fn jsonnet_json_array_append(15 _vm: &EvaluationState,16 arr: &mut Val,17 val: &Val,18) {19 match arr {20 Val::Arr(old) => {21 let mut new = Vec::new();22 for item in old.iter_lazy() {23 new.push(item);24 }25 new.push(LazyVal::new_resolved(val.clone()));26 *arr = Val::Arr(ArrValue::Lazy(Gc::new(new)));27 }28 _ => panic!("should receive array"),29 }30}3132/// # Safety33///34/// This function is safe if passed name is ok35#[no_mangle]36pub unsafe extern "C" fn jsonnet_json_object_append(37 _vm: &EvaluationState,38 obj: &mut Val,39 name: *const c_char,40 val: &Val,41) {42 match obj {43 Val::Obj(old) => {44 let new_obj = old.clone().extend_with_field(45 CStr::from_ptr(name).to_str().unwrap().into(),46 ObjMember {47 add: false,48 visibility: Visibility::Normal,49 invoke: LazyBinding::Bound(LazyVal::new_resolved(val.clone())),50 location: None,51 },52 );5354 *obj = Val::Obj(new_obj);55 }56 _ => panic!("should receive object"),57 }58}