difftreelog
fix make jsonnet tests partially pass
in: master
3 files changed
crates/jsonnet-evaluator/src/evaluate.rsdiffbeforeafterboth--- a/crates/jsonnet-evaluator/src/evaluate.rs
+++ b/crates/jsonnet-evaluator/src/evaluate.rs
@@ -54,11 +54,16 @@
pub fn evaluate_field_name(
context: Context,
field_name: &jsonnet_parser::FieldName,
-) -> Result<String> {
+) -> Result<Option<String>> {
Ok(match field_name {
- jsonnet_parser::FieldName::Fixed(n) => n.clone(),
+ jsonnet_parser::FieldName::Fixed(n) => Some(n.clone()),
jsonnet_parser::FieldName::Dyn(expr) => {
- evaluate(context, expr)?.try_cast_str("dynamic field name")?
+ let value = evaluate(context, expr)?.unwrap_if_lazy()?;
+ if matches!(value, Val::Null) {
+ None
+ } else {
+ Some(value.try_cast_str("dynamic field name")?)
+ }
}
})
}
@@ -234,6 +239,10 @@
value,
}) => {
let name = evaluate_field_name(context.clone(), &name)?;
+ if name.is_none() {
+ continue;
+ }
+ let name = name.unwrap();
new_members.insert(
name.clone(),
ObjMember {
@@ -260,6 +269,10 @@
..
}) => {
let name = evaluate_field_name(context.clone(), &name)?;
+ if name.is_none() {
+ continue;
+ }
+ let name = name.unwrap();
new_members.insert(
name,
ObjMember {
@@ -299,12 +312,6 @@
.clone()
.unwrap_or_else(|| panic!("this not found")),
),
- Literal(LiteralType::Super) => Val::Obj(
- context
- .super_obj()
- .clone()
- .unwrap_or_else(|| panic!("super not found")),
- ),
Literal(LiteralType::Dollar) => Val::Obj(
context
.dollar()
@@ -320,6 +327,15 @@
BinaryOp(v1, o, v2) => evaluate_binary_op_special(context, &v1, *o, &v2)?,
UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(context, v)?)?,
Var(name) => Val::Lazy(context.binding(&name)).unwrap_if_lazy()?,
+ Index(LocExpr(v, _), index) if matches!(&**v, Expr::Literal(LiteralType::Super)) => {
+ let name = evaluate(context.clone(), index)?.try_cast_str("object index")?;
+ context
+ .super_obj()
+ .clone()
+ .expect("no super found")
+ .get_raw(&name, &context.this().clone().expect("no this found"))?
+ .expect("value not found")
+ }
Index(value, index) => {
match (
evaluate(context.clone(), value)?.unwrap_if_lazy()?,
@@ -381,6 +397,10 @@
evaluate_comp(context, expr, compspecs)?.unwrap(),
),
Obj(body) => Val::Obj(evaluate_object(context, body.clone())?),
+ ObjExtend(s, t) => evaluate_add_op(
+ &evaluate(context.clone(), s)?,
+ &Val::Obj(evaluate_object(context, t.clone())?),
+ )?,
Apply(value, ArgsDesc(args)) => {
let value = evaluate(context.clone(), value)?.unwrap_if_lazy()?;
match value {
@@ -408,7 +428,7 @@
evaluate(context.clone(), &args[0].1)?,
evaluate(context, &args[1].1)?,
) {
- assert!(v > 0.0);
+ assert!(v >= 0.0);
let mut out = Vec::with_capacity(v as usize);
for i in 0..v as usize {
out.push(d.evaluate(vec![(None, Val::Num(i as f64))])?)
@@ -452,6 +472,25 @@
);
Val::Bool(a == b)
}
+ ("std", "modulo") => {
+ assert_eq!(args.len(), 2);
+ if let (Val::Num(a), Val::Num(b)) = (
+ evaluate(context.clone(), &args[0].1)?,
+ evaluate(context, &args[1].1)?,
+ ) {
+ Val::Num(a % b)
+ } else {
+ panic!("bad modulo call");
+ }
+ }
+ ("std", "floor") => {
+ assert_eq!(args.len(), 1);
+ if let Val::Num(a) = evaluate(context, &args[0].1)? {
+ Val::Num(a.floor())
+ } else {
+ panic!("bad floor call");
+ }
+ }
(ns, name) => panic!("Intristic not found: {}.{}", ns, name),
},
Val::Func(f) => push(locexpr, "function call".to_owned(), || {
@@ -516,7 +555,7 @@
Some(v) => push(v.clone(), "if condition 'else' branch".to_owned(), || {
evaluate(context, v)
})?,
- None => Val::Bool(false),
+ None => Val::Null,
}
}
}
crates/jsonnet-evaluator/src/obj.rsdiffbeforeafterboth--- a/crates/jsonnet-evaluator/src/obj.rs
+++ b/crates/jsonnet-evaluator/src/obj.rs
@@ -83,7 +83,7 @@
Ok(None)
}
}
- fn get_raw(&self, key: &str, real_this: &ObjValue) -> Result<Option<Val>> {
+ pub(crate) fn get_raw(&self, key: &str, real_this: &ObjValue) -> Result<Option<Val>> {
match (self.0.this_entries.get(key), &self.0.super_obj) {
(Some(k), None) => Ok(Some(k.invoke.0(
Some(real_this.clone()),
crates/jsonnet-evaluator/src/val.rsdiffbeforeafterboth3 ObjValue, Result,3 ObjValue, Result,4};4};5use closure::closure;5use closure::closure;6use jsonnet_parser::ParamsDesc;6use jsonnet_parser::{Param, ParamsDesc};7use std::{7use std::{8 cell::RefCell,8 cell::RefCell,9 collections::HashMap,9 collections::HashMap,70 let mut new_bindings: HashMap<String, LazyBinding> = HashMap::new();70 let mut new_bindings: HashMap<String, LazyBinding> = HashMap::new();71 let future_ctx = Context::new_future();71 let future_ctx = Context::new_future();727273 // self.params73 for Param(name, default) in self.params.with_defaults() {74 // .with_defaults()74 let default = default.unwrap();75 // .into_iter()75 let eval_default = self.eval_default.clone();76 // .for_each(|Param(name, default)| {76 new_bindings.insert(77 // let default = Rc::new(*default.unwrap());77 name,78 // new_bindings.insert(78 lazy_binding!(closure!(clone future_ctx, clone default, clone eval_default, |_, _| Ok(lazy_val!(closure!(clone future_ctx, clone eval_default, clone default, || (eval_default.clone()).079 // name,79 (future_ctx.clone().unwrap(), default.clone())))))),80 // binding!(move |_, _| Val::Lazy(lazy_val!(|| self80 );81 // .eval_default81 }82 // .083 // .default(future_ctx.unwrap(), *default.clone())))),84 // );85 // });86 for (name, val) in args.clone().into_iter().filter(|e| e.0.is_some()) {82 for (name, val) in args.clone().into_iter().filter(|e| e.0.is_some()) {87 new_bindings.insert(83 new_bindings.insert(88 name.as_ref().unwrap().clone(),84 name.as_ref().unwrap().clone(),