git.delta.rocks / jrsonnet / refs/commits / e0c62dfdfc24

difftreelog

feat(evaluator) number overflow checks

Лач2020-07-01parent: #625fbae.patch.diff
in: master

2 files changed

modifiedcrates/jrsonnet-evaluator/src/evaluate.rsdiffbeforeafterboth
before · crates/jrsonnet-evaluator/src/evaluate.rs
1use crate::{2	context_creator, create_error, create_error_result, escape_string_json, future_wrapper,3	lazy_val, manifest_json_ex, parse_args, push, with_state, Context, ContextCreator, Error,4	FuncDesc, LazyBinding, LazyVal, ObjMember, ObjValue, Result, Val, ValType,5};6use closure::closure;7use jrsonnet_parser::{8	ArgsDesc, AssertStmt, BinaryOpType, BindSpec, CompSpec, Expr, ExprLocation, FieldMember,9	ForSpecData, IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc, UnaryOpType,10	Visibility,11};12use std::{collections::HashMap, rc::Rc};1314pub fn evaluate_binding(b: &BindSpec, context_creator: ContextCreator) -> (Rc<str>, LazyBinding) {15	let b = b.clone();16	if let Some(params) = &b.params {17		let params = params.clone();18		(19			b.name.clone(),20			LazyBinding::Bindable(Rc::new(move |this, super_obj| {21				Ok(lazy_val!(22					closure!(clone b, clone params, clone context_creator, || Ok(evaluate_method(23						context_creator.0(this.clone(), super_obj.clone())?,24						params.clone(),25						b.value.clone(),26					)))27				))28			})),29		)30	} else {31		(32			b.name.clone(),33			LazyBinding::Bindable(Rc::new(move |this, super_obj| {34				Ok(lazy_val!(closure!(clone context_creator, clone b, ||35					push(&b.value.1, "thunk", ||{36						evaluate(37							context_creator.0(this.clone(), super_obj.clone())?,38							&b.value39						)40					})41				)))42			})),43		)44	}45}4647pub fn evaluate_method(ctx: Context, params: ParamsDesc, body: LocExpr) -> Val {48	Val::Func(FuncDesc { ctx, params, body })49}5051pub fn evaluate_field_name(52	context: Context,53	field_name: &jrsonnet_parser::FieldName,54) -> Result<Option<Rc<str>>> {55	Ok(match field_name {56		jrsonnet_parser::FieldName::Fixed(n) => Some(n.clone()),57		jrsonnet_parser::FieldName::Dyn(expr) => {58			let lazy = evaluate(context, expr)?;59			let value = lazy.unwrap_if_lazy()?;60			if matches!(value, Val::Null) {61				None62			} else {63				Some(value.try_cast_str("dynamic field name")?)64			}65		}66	})67}6869pub fn evaluate_unary_op(op: UnaryOpType, b: &Val) -> Result<Val> {70	Ok(match (op, b) {71		(o, Val::Lazy(l)) => evaluate_unary_op(o, &l.evaluate()?)?,72		(UnaryOpType::Not, Val::Bool(v)) => Val::Bool(!v),73		(UnaryOpType::Minus, Val::Num(n)) => Val::Num(-*n),74		(UnaryOpType::BitNot, Val::Num(n)) => Val::Num(!(*n as i32) as f64),75		(op, o) => create_error_result(Error::UnaryOperatorDoesNotOperateOnType(76			op,77			o.value_type()?,78		))?,79	})80}8182pub(crate) fn evaluate_add_op(a: &Val, b: &Val) -> Result<Val> {83	Ok(match (a, b) {84		(Val::Str(v1), Val::Str(v2)) => Val::Str(((**v1).to_owned() + &v2).into()),8586		// Can't use generic json serialization way, because it depends on number to string concatenation (std.jsonnet:890)87		(Val::Num(n), Val::Str(o)) => Val::Str(format!("{}{}", n, o).into()),88		(Val::Str(o), Val::Num(n)) => Val::Str(format!("{}{}", o, n).into()),8990		(Val::Str(s), o) => Val::Str(format!("{}{}", s, o.clone().into_json(0)?).into()),91		(o, Val::Str(s)) => Val::Str(format!("{}{}", o.clone().into_json(0)?, s).into()),9293		(Val::Obj(v1), Val::Obj(v2)) => Val::Obj(v2.with_super(v1.clone())),94		(Val::Arr(a), Val::Arr(b)) => Val::Arr(Rc::new([&a[..], &b[..]].concat())),95		(Val::Num(v1), Val::Num(v2)) => Val::Num(v1 + v2),96		_ => create_error_result(Error::BinaryOperatorDoesNotOperateOnValues(97			BinaryOpType::Add,98			a.value_type()?,99			b.value_type()?,100		))?,101	})102}103104pub fn evaluate_binary_op_special(105	context: Context,106	a: &LocExpr,107	op: BinaryOpType,108	b: &LocExpr,109) -> Result<Val> {110	Ok(111		match (evaluate(context.clone(), &a)?.unwrap_if_lazy()?, op, b) {112			(Val::Bool(true), BinaryOpType::Or, _o) => Val::Bool(true),113			(Val::Bool(false), BinaryOpType::And, _o) => Val::Bool(false),114			(a, op, eb) => {115				evaluate_binary_op_normal(&a, op, &evaluate(context, eb)?.unwrap_if_lazy()?)?116			}117		},118	)119}120121pub fn evaluate_binary_op_normal(a: &Val, op: BinaryOpType, b: &Val) -> Result<Val> {122	Ok(match (a, op, b) {123		(a, BinaryOpType::Add, b) => evaluate_add_op(a, b)?,124125		(Val::Str(v1), BinaryOpType::Mul, Val::Num(v2)) => Val::Str(v1.repeat(*v2 as usize).into()),126127		// Bool X Bool128		(Val::Bool(a), BinaryOpType::And, Val::Bool(b)) => Val::Bool(*a && *b),129		(Val::Bool(a), BinaryOpType::Or, Val::Bool(b)) => Val::Bool(*a || *b),130131		// Str X Str132		(Val::Str(v1), BinaryOpType::Lt, Val::Str(v2)) => Val::Bool(v1 < v2),133		(Val::Str(v1), BinaryOpType::Gt, Val::Str(v2)) => Val::Bool(v1 > v2),134		(Val::Str(v1), BinaryOpType::Lte, Val::Str(v2)) => Val::Bool(v1 <= v2),135		(Val::Str(v1), BinaryOpType::Gte, Val::Str(v2)) => Val::Bool(v1 >= v2),136137		// Num X Num138		(Val::Num(v1), BinaryOpType::Mul, Val::Num(v2)) => Val::Num(v1 * v2),139		(Val::Num(v1), BinaryOpType::Div, Val::Num(v2)) => {140			if *v2 <= f64::EPSILON {141				create_error_result(crate::Error::DivisionByZero)?142			}143			Val::Num(v1 / v2)144		}145146		(Val::Num(v1), BinaryOpType::Sub, Val::Num(v2)) => Val::Num(v1 - v2),147148		(Val::Num(v1), BinaryOpType::Lt, Val::Num(v2)) => Val::Bool(v1 < v2),149		(Val::Num(v1), BinaryOpType::Gt, Val::Num(v2)) => Val::Bool(v1 > v2),150		(Val::Num(v1), BinaryOpType::Lte, Val::Num(v2)) => Val::Bool(v1 <= v2),151		(Val::Num(v1), BinaryOpType::Gte, Val::Num(v2)) => Val::Bool(v1 >= v2),152153		(Val::Num(v1), BinaryOpType::BitAnd, Val::Num(v2)) => {154			Val::Num(((*v1 as i32) & (*v2 as i32)) as f64)155		}156		(Val::Num(v1), BinaryOpType::BitOr, Val::Num(v2)) => {157			Val::Num(((*v1 as i32) | (*v2 as i32)) as f64)158		}159		(Val::Num(v1), BinaryOpType::BitXor, Val::Num(v2)) => {160			Val::Num(((*v1 as i32) ^ (*v2 as i32)) as f64)161		}162		(Val::Num(v1), BinaryOpType::Lhs, Val::Num(v2)) => {163			Val::Num(((*v1 as i32) << (*v2 as i32)) as f64)164		}165		(Val::Num(v1), BinaryOpType::Rhs, Val::Num(v2)) => {166			Val::Num(((*v1 as i32) >> (*v2 as i32)) as f64)167		}168169		_ => create_error_result(Error::BinaryOperatorDoesNotOperateOnValues(170			op,171			a.value_type()?,172			b.value_type()?,173		))?,174	})175}176177future_wrapper!(HashMap<Rc<str>, LazyBinding>, FutureNewBindings);178future_wrapper!(ObjValue, FutureObjValue);179180pub fn evaluate_comp<T>(181	context: Context,182	value: &impl Fn(Context) -> Result<T>,183	specs: &[CompSpec],184) -> Result<Option<Vec<T>>> {185	Ok(match specs.get(0) {186		None => Some(vec![value(context)?]),187		Some(CompSpec::IfSpec(IfSpecData(cond))) => {188			if evaluate(context.clone(), &cond)?.try_cast_bool("if spec")? {189				evaluate_comp(context, value, &specs[1..])?190			} else {191				None192			}193		}194		Some(CompSpec::ForSpec(ForSpecData(var, expr))) => {195			match evaluate(context.clone(), &expr)?.unwrap_if_lazy()? {196				Val::Arr(list) => {197					let mut out = Vec::new();198					for item in list.iter() {199						let item = item.unwrap_if_lazy()?;200						out.push(evaluate_comp(201							context.with_var(var.clone(), item.clone())?,202							value,203							&specs[1..],204						)?);205					}206					Some(out.into_iter().flatten().flatten().collect())207				}208				_ => create_error_result(Error::InComprehensionCanOnlyIterateOverArray)?,209			}210		}211	})212}213214pub fn evaluate_member_list_object(context: Context, members: &[Member]) -> Result<ObjValue> {215	let new_bindings = FutureNewBindings::new();216	let future_this = FutureObjValue::new();217	let context_creator = context_creator!(218		closure!(clone context, clone new_bindings, |this: Option<ObjValue>, super_obj: Option<ObjValue>| {219			Ok(context.extend_unbound(220				new_bindings.clone().unwrap(),221				context.dollar().clone().or_else(||this.clone()),222				Some(this.unwrap()),223				super_obj224			)?)225		})226	);227	{228		let mut bindings: HashMap<Rc<str>, LazyBinding> = HashMap::new();229		for (n, b) in members230			.iter()231			.filter_map(|m| match m {232				Member::BindStmt(b) => Some(b.clone()),233				_ => None,234			})235			.map(|b| evaluate_binding(&b, context_creator.clone()))236		{237			bindings.insert(n, b);238		}239		new_bindings.fill(bindings);240	}241242	let mut new_members = HashMap::new();243	for member in members.iter() {244		match member {245			Member::Field(FieldMember {246				name,247				plus,248				params: None,249				visibility,250				value,251			}) => {252				let name = evaluate_field_name(context.clone(), &name)?;253				if name.is_none() {254					continue;255				}256				let name = name.unwrap();257				new_members.insert(258					name.clone(),259					ObjMember {260						add: *plus,261						visibility: *visibility,262						invoke: LazyBinding::Bindable(Rc::new(263							closure!(clone name, clone value, clone context_creator, |this, super_obj| {264								Ok(LazyVal::new_resolved(push(&value.1, "object field", ||{265									let context = context_creator.0(this, super_obj)?;266									evaluate(267										context,268										&value,269									)270								})?))271							}),272						)),273					},274				);275			}276			Member::Field(FieldMember {277				name,278				params: Some(params),279				value,280				..281			}) => {282				let name = evaluate_field_name(context.clone(), &name)?;283				if name.is_none() {284					continue;285				}286				let name = name.unwrap();287				new_members.insert(288					name,289					ObjMember {290						add: false,291						visibility: Visibility::Hidden,292						invoke: LazyBinding::Bindable(Rc::new(293							closure!(clone value, clone context_creator, clone params, |this, super_obj| {294								// TODO: Assert295								Ok(LazyVal::new_resolved(evaluate_method(296									context_creator.0(this, super_obj)?,297									params.clone(),298									value.clone(),299								)))300							}),301						)),302					},303				);304			}305			Member::BindStmt(_) => {}306			Member::AssertStmt(_) => {}307		}308	}309	Ok(future_this.fill(ObjValue::new(None, Rc::new(new_members))))310}311312pub fn evaluate_object(context: Context, object: &ObjBody) -> Result<ObjValue> {313	Ok(match object {314		ObjBody::MemberList(members) => evaluate_member_list_object(context, &members)?,315		ObjBody::ObjComp(obj) => {316			let future_this = FutureObjValue::new();317			let mut new_members = HashMap::new();318			for (k, v) in evaluate_comp(319				context.clone(),320				&|ctx| {321					let new_bindings = FutureNewBindings::new();322					let context_creator = context_creator!(323						closure!(clone context, clone new_bindings, |this: Option<ObjValue>, super_obj: Option<ObjValue>| {324							Ok(context.extend_unbound(325								new_bindings.clone().unwrap(),326								context.dollar().clone().or_else(||this.clone()),327								None,328								super_obj329							)?)330						})331					);332					let mut bindings: HashMap<Rc<str>, LazyBinding> = HashMap::new();333					for (n, b) in obj334						.pre_locals335						.iter()336						.chain(obj.post_locals.iter())337						.map(|b| evaluate_binding(b, context_creator.clone()))338					{339						bindings.insert(n, b);340					}341					let bindings = new_bindings.fill(bindings);342					let ctx = ctx.extend_unbound(bindings, None, None, None)?;343					let key = evaluate(ctx.clone(), &obj.key)?;344					let value = LazyBinding::Bindable(Rc::new(345						closure!(clone ctx, clone obj.value, |this, _super_obj| {346							Ok(LazyVal::new_resolved(evaluate(ctx.extend(HashMap::new(), None, this, None)?, &value)?))347						}),348					));349350					Ok((key, value))351				},352				&obj.compspecs,353			)?354			.unwrap()355			{356				match k {357					Val::Null => {}358					Val::Str(n) => {359						new_members.insert(360							n,361							ObjMember {362								add: false,363								visibility: Visibility::Normal,364								invoke: v,365							},366						);367					}368					v => create_error_result(Error::FieldMustBeStringGot(v.value_type()?))?,369				}370			}371372			future_this.fill(ObjValue::new(None, Rc::new(new_members)))373		}374	})375}376377/// Extracts code block and disables inlining for them378/// Fixes WASM to java bytecode compilation failing because of very large method379macro_rules! noinline {380	($e:expr) => {381		(#[inline(never)]382		move || $e)()383	};384}385386pub fn evaluate_apply(387	context: Context,388	value: &LocExpr,389	args: &ArgsDesc,390	loc: &Option<ExprLocation>,391	tailstrict: bool,392) -> Result<Val> {393	let lazy = evaluate(context.clone(), value)?;394	let value = lazy.unwrap_if_lazy()?;395	Ok(match value {396		Val::Intristic(ns, name) => match (&ns as &str, &name as &str) {397			// arr/string/function398			("std", "length") => noinline!(parse_args!(context, "std.length", args, 1, [399				0, x: [Val::Str|Val::Arr|Val::Obj], vec![ValType::Str, ValType::Arr, ValType::Obj];400			], {401				Ok(match x {402					Val::Str(n) => Val::Num(n.chars().count() as f64),403					Val::Arr(i) => Val::Num(i.len() as f64),404					Val::Obj(o) => Val::Num(405						o.fields_visibility()406							.into_iter()407							.filter(|(_k, v)| *v)408							.count() as f64,409					),410					_ => unreachable!(),411				})412			}))?,413			// any414			("std", "type") => parse_args!(context, "std.type", args, 1, [415				0, x, vec![];416			], {417				Val::Str(x.value_type()?.name().into())418			}),419			// length, idx=>any420			("std", "makeArray") => noinline!(parse_args!(context, "std.makeArray", args, 2, [421				0, sz: [Val::Num]!!Val::Num, vec![ValType::Num];422				1, func: [Val::Func]!!Val::Func, vec![ValType::Func];423			], {424				assert!(sz >= 0.0);425				let mut out = Vec::with_capacity(sz as usize);426				for i in 0..sz as usize {427					out.push(func.evaluate_values(428						Context::new(),429						&[Val::Num(i as f64)]430					)?)431				}432				Ok(Val::Arr(Rc::new(out)))433			}))?,434			// string435			("std", "codepoint") => parse_args!(context, "std.codepoint", args, 1, [436				0, str: [Val::Str]!!Val::Str, vec![ValType::Str];437			], {438				assert!(439					str.chars().count() == 1,440					"std.codepoint should receive single char string"441				);442				Val::Num(str.chars().take(1).next().unwrap() as u32 as f64)443			}),444			// object, includeHidden445			("std", "objectFieldsEx") => {446				noinline!(parse_args!(context, "std.objectFieldsEx",args, 2, [447					0, obj: [Val::Obj]!!Val::Obj, vec![ValType::Obj];448					1, inc_hidden: [Val::Bool]!!Val::Bool, vec![ValType::Bool];449				], {450					let mut out = obj.fields_visibility()451						.into_iter()452						.filter(|(_k, v)| *v || inc_hidden)453						.map(|(k, _v)|k)454						.collect::<Vec<_>>();455					out.sort();456					Ok(Val::Arr(Rc::new(out.into_iter().map(Val::Str).collect())))457				}))?458			}459			// object, field, includeHidden460			("std", "objectHasEx") => parse_args!(context, "std.objectHasEx", args, 3, [461				0, obj: [Val::Obj]!!Val::Obj, vec![ValType::Obj];462				1, f: [Val::Str]!!Val::Str, vec![ValType::Str];463				2, inc_hidden: [Val::Bool]!!Val::Bool, vec![ValType::Bool];464			], {465				Val::Bool(466					obj.fields_visibility()467						.into_iter()468						.filter(|(_k, v)| *v || inc_hidden)469						.any(|(k, _v)| *k == *f),470				)471			}),472			("std", "primitiveEquals") => parse_args!(context, "std.primitiveEquals", args, 2, [473				0, a, vec![];474				1, b, vec![];475			], {476				Val::Bool(a == b)477			}),478			("std", "modulo") => parse_args!(context, "std.modulo", args, 2, [479				0, a: [Val::Num]!!Val::Num, vec![ValType::Num];480				1, b: [Val::Num]!!Val::Num, vec![ValType::Num];481			], {482				Val::Num(a % b)483			}),484			("std", "floor") => parse_args!(context, "std.floor", args, 1, [485				0, x: [Val::Num]!!Val::Num, vec![ValType::Num];486			], {487				Val::Num(x.floor())488			}),489			("std", "trace") => parse_args!(context, "std.trace", args, 2, [490				0, str: [Val::Str]!!Val::Str, vec![ValType::Str];491				1, rest, vec![];492			], {493				eprint!("TRACE: ");494				if let Some(loc) = loc {495					with_state(|s|{496						let locs = s.map_source_locations(&loc.0, &[loc.1]);497						eprint!("{}:{} ", loc.0.display(), locs[0].line);498					});499				}500				eprintln!("{}", str);501				rest502			}),503			("std", "pow") => parse_args!(context, "std.modulo", args, 2, [504				0, x: [Val::Num]!!Val::Num, vec![ValType::Num];505				1, n: [Val::Num]!!Val::Num, vec![ValType::Num];506			], {507				Val::Num(x.powf(n))508			}),509			("std", "extVar") => parse_args!(context, "std.extVar", args, 2, [510				0, x: [Val::Str]!!Val::Str, vec![ValType::Str];511			], {512				with_state(|s| s.settings().ext_vars.get(&x).cloned()).ok_or_else(513					|| create_error(crate::Error::UndefinedExternalVariable(x)),514				)?515			}),516			("std", "filter") => noinline!(parse_args!(context, "std.filter", args, 2, [517				0, func: [Val::Func]!!Val::Func, vec![ValType::Func];518				1, arr: [Val::Arr]!!Val::Arr, vec![ValType::Arr];519			], {520				Ok(Val::Arr(Rc::new(521					arr.iter()522						.cloned()523						.filter(|e| {524							func525								.evaluate_values(context.clone(), &[e.clone()])526								.unwrap()527								.try_cast_bool("filter predicate")528								.unwrap()529						})530						.collect(),531				)))532			}))?,533			("std", "char") => parse_args!(context, "std.char", args, 1, [534				0, n: [Val::Num]!!Val::Num, vec![ValType::Num];535			], {536				let mut out = String::new();537				out.push(std::char::from_u32(n as u32).unwrap());538				Val::Str(out.into())539			}),540			("std", "encodeUTF8") => parse_args!(context, "std.encodeUtf8", args, 1, [541				0, str: [Val::Str]!!Val::Str, vec![ValType::Str];542			], {543				Val::Arr(Rc::new(str.bytes().map(|b| Val::Num(b as f64)).collect()))544			}),545			("std", "md5") => noinline!(parse_args!(context, "std.md5", args, 1, [546				0, str: [Val::Str]!!Val::Str, vec![ValType::Str];547			], {548				Ok(Val::Str(format!("{:x}", md5::compute(&str.as_bytes())).into()))549			}))?,550			// faster551			("std", "join") => noinline!(parse_args!(context, "std.join", args, 2, [552				0, sep: [Val::Str|Val::Arr], vec![ValType::Str, ValType::Arr];553				1, arr: [Val::Arr]!!Val::Arr, vec![ValType::Arr];554			], {555				Ok(match sep {556					Val::Arr(joiner_items) => {557						let mut out = Vec::new();558559						let mut first = true;560						for item in arr.iter().cloned() {561							if let Val::Arr(items) = item.unwrap_if_lazy()? {562								if !first {563									out.reserve(joiner_items.len());564									out.extend(joiner_items.iter().cloned());565								}566								first = false;567								out.reserve(items.len());568								out.extend(items.iter().cloned());569							} else {570								create_error_result(crate::Error::RuntimeError("in std.join all items should be arrays".into()))?;571							}572						}573574						Val::Arr(Rc::new(out))575					},576					Val::Str(sep) => {577						let mut out = String::new();578579						let mut first = true;580						for item in arr.iter().cloned() {581							if let Val::Str(item) = item.unwrap_if_lazy()? {582								if !first {583									out += &sep;584								}585								first = false;586								out += &item;587							} else {588								create_error_result(crate::Error::RuntimeError("in std.join all items should be strings".into()))?;589							}590						}591592						Val::Str(out.into())593					},594					_ => unreachable!()595				})596			}))?,597			// Faster598			("std", "escapeStringJson") => parse_args!(context, "std.escapeStringJson", args, 1, [599				0, str_: [Val::Str]!!Val::Str, vec![ValType::Str];600			], {601				Val::Str(escape_string_json(&str_).into())602			}),603			// Faster604			("std", "manifestJsonEx") => parse_args!(context, "std.manifestJsonEx", args, 2, [605				0, value, vec![];606				1, indent: [Val::Str]!!Val::Str, vec![ValType::Str];607			], {608				Val::Str(manifest_json_ex(&value, &indent)?.into())609			}),610			(ns, name) => {611				create_error_result(crate::Error::IntristicNotFound(ns.into(), name.into()))?612			}613		},614		Val::Func(f) => {615			let body = || f.evaluate(context, args, tailstrict);616			if tailstrict {617				body()?618			} else {619				push(loc, "function call", body)?620			}621		}622		v => create_error_result(crate::Error::OnlyFunctionsCanBeCalledGot(v.value_type()?))?,623	})624}625626pub fn evaluate(context: Context, expr: &LocExpr) -> Result<Val> {627	use Expr::*;628	let LocExpr(expr, loc) = expr;629	Ok(match &**expr {630		Literal(LiteralType::This) => Val::Obj(631			context632				.this()633				.clone()634				.ok_or_else(|| create_error(crate::Error::CantUseSelfOutsideOfObject))?,635		),636		Literal(LiteralType::Dollar) => Val::Obj(637			context638				.dollar()639				.clone()640				.ok_or_else(|| create_error(crate::Error::NoTopLevelObjectFound))?,641		),642		Literal(LiteralType::True) => Val::Bool(true),643		Literal(LiteralType::False) => Val::Bool(false),644		Literal(LiteralType::Null) => Val::Null,645		Parened(e) => evaluate(context, e)?,646		Str(v) => Val::Str(v.clone()),647		Num(v) => Val::Num(*v),648		BinaryOp(v1, o, v2) => evaluate_binary_op_special(context, &v1, *o, &v2)?,649		UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(context, v)?)?,650		Var(name) => push(loc, "var", || {651			Ok(Val::Lazy(context.binding(name.clone())?).unwrap_if_lazy()?)652		})?,653		Index(LocExpr(v, _), index) if matches!(&**v, Expr::Literal(LiteralType::Super)) => {654			let name = evaluate(context.clone(), index)?.try_cast_str("object index")?;655			context656				.super_obj()657				.clone()658				.expect("no super found")659				.get_raw(&name, &context.this().clone().expect("no this found"))?660				.expect("value not found")661		}662		Index(value, index) => {663			match (664				evaluate(context.clone(), value)?.unwrap_if_lazy()?,665				evaluate(context, index)?,666			) {667				(Val::Obj(v), Val::Str(s)) => {668					if let Some(v) = v.get(s.clone())? {669						v.unwrap_if_lazy()?670					} else if let Some(Val::Str(n)) = v.get("__intristic_namespace__".into())? {671						Val::Intristic(n, s)672					} else {673						create_error_result(crate::Error::NoSuchField(s))?674					}675				}676				(Val::Obj(_), n) => create_error_result(crate::Error::ValueIndexMustBeTypeGot(677					ValType::Obj,678					ValType::Str,679					n.value_type()?,680				))?,681682				(Val::Arr(v), Val::Num(n)) => {683					if n.fract() > f64::EPSILON {684						create_error_result(crate::Error::FractionalIndex)?685					}686					v.get(n as usize)687						.ok_or_else(|| {688							create_error(crate::Error::ArrayBoundsError(n as usize, v.len()))689						})?690						.clone()691						.unwrap_if_lazy()?692				}693				(Val::Arr(_), Val::Str(n)) => {694					create_error_result(crate::Error::AttemptedIndexAnArrayWithString(n))?695				}696				(Val::Arr(_), n) => create_error_result(crate::Error::ValueIndexMustBeTypeGot(697					ValType::Arr,698					ValType::Num,699					n.value_type()?,700				))?,701702				(Val::Str(s), Val::Num(n)) => Val::Str(703					s.chars()704						.skip(n as usize)705						.take(1)706						.collect::<String>()707						.into(),708				),709				(Val::Str(_), n) => create_error_result(crate::Error::ValueIndexMustBeTypeGot(710					ValType::Str,711					ValType::Num,712					n.value_type()?,713				))?,714715				(v, _) => create_error_result(crate::Error::CantIndexInto(v.value_type()?))?,716			}717		}718		LocalExpr(bindings, returned) => {719			let mut new_bindings: HashMap<Rc<str>, LazyBinding> = HashMap::new();720			let future_context = Context::new_future();721722			let context_creator = context_creator!(723				closure!(clone future_context, |_, _| Ok(future_context.clone().unwrap()))724			);725726			for (k, v) in bindings727				.iter()728				.map(|b| evaluate_binding(b, context_creator.clone()))729			{730				new_bindings.insert(k, v);731			}732733			let context = context734				.extend_unbound(new_bindings, None, None, None)?735				.into_future(future_context);736			evaluate(context, &returned.clone())?737		}738		Arr(items) => {739			let mut out = Vec::with_capacity(items.len());740			for item in items {741				out.push(Val::Lazy(lazy_val!(742					closure!(clone context, clone item, || {743						evaluate(context.clone(), &item)744					})745				)));746			}747			Val::Arr(Rc::new(out))748		}749		ArrComp(expr, compspecs) => Val::Arr(750			// First compspec should be forspec, so no "None" possible here751			Rc::new(evaluate_comp(context, &|ctx| evaluate(ctx, expr), compspecs)?.unwrap()),752		),753		Obj(body) => Val::Obj(evaluate_object(context, body)?),754		ObjExtend(s, t) => evaluate_add_op(755			&evaluate(context.clone(), s)?,756			&Val::Obj(evaluate_object(context, t)?),757		)?,758		Apply(value, args, tailstrict) => evaluate_apply(context, value, args, loc, *tailstrict)?,759		Function(params, body) => evaluate_method(context, params.clone(), body.clone()),760		AssertExpr(AssertStmt(value, msg), returned) => {761			let assertion_result = push(&value.1, "assertion condition", || {762				evaluate(context.clone(), &value)?763					.try_cast_bool("assertion condition should be boolean")764			})?;765			if assertion_result {766				evaluate(context, returned)?767			} else if let Some(msg) = msg {768				create_error_result(crate::Error::AssertionFailed(evaluate(context, msg)?))?769			} else {770				create_error_result(crate::Error::AssertionFailed(Val::Null))?771			}772		}773		Error(e) => create_error_result(crate::Error::RuntimeError(774			evaluate(context, e)?.try_cast_str("error text should be string")?,775		))?,776		IfElse {777			cond,778			cond_then,779			cond_else,780		} => {781			if evaluate(context.clone(), &cond.0)?782				.try_cast_bool("if condition should be boolean")?783			{784				evaluate(context, cond_then)?785			} else {786				match cond_else {787					Some(v) => evaluate(context, v)?,788					None => Val::Null,789				}790			}791		}792		Import(path) => {793			let mut tmp = loc794				.clone()795				.expect("imports can't be used without loc_data")796				.0;797			let import_location = Rc::make_mut(&mut tmp);798			import_location.pop();799			with_state(|s| s.import_file(&import_location, path))?800		}801		ImportStr(path) => {802			let mut tmp = loc803				.clone()804				.expect("imports can't be used without loc_data")805				.0;806			let import_location = Rc::make_mut(&mut tmp);807			import_location.pop();808			Val::Str(with_state(|s| s.import_file_str(&import_location, path))?)809		}810		Literal(LiteralType::Super) => return create_error_result(crate::Error::StandaloneSuper),811	})812}
modifiedcrates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/val.rs
+++ b/crates/jrsonnet-evaluator/src/val.rs
@@ -134,6 +134,15 @@
 	};
 }
 impl Val {
+	/// Creates Val::Num after checking for overflow. As numbers are f64, we can just check for finity
+	pub fn new_checked_num(num: f64) -> Result<Val> {
+		if num.is_finite() {
+			Ok(Val::Num(num))
+		} else {
+			create_error_result(Error::RuntimeError("overflow".into()))
+		}
+	}
+
 	pub fn assert_type(&self, context: &'static str, val_type: ValType) -> Result<()> {
 		let this_type = self.value_type()?;
 		if this_type != val_type {