difftreelog
perf move error and stacktrace to heap
in: master
3 files changed
crates/jrsonnet-evaluator/src/error.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/error.rs
+++ b/crates/jrsonnet-evaluator/src/error.rs
@@ -76,7 +76,7 @@
}
impl From<Error> for LocError {
fn from(e: Error) -> Self {
- Self(e, StackTrace(vec![]))
+ Self::new(e)
}
}
@@ -89,10 +89,20 @@
pub struct StackTrace(pub Vec<StackTraceElement>);
#[derive(Debug, Clone)]
-pub struct LocError(pub Error, pub StackTrace);
+pub struct LocError(Box<(Error, StackTrace)>);
impl LocError {
pub fn new(e: Error) -> Self {
- Self(e, StackTrace(vec![]))
+ Self(Box::new((e, StackTrace(vec![]))))
+ }
+
+ pub fn error(&self) -> &Error {
+ &(self.0).0
+ }
+ pub fn trace(&self) -> &StackTrace {
+ &(self.0).1
+ }
+ pub fn trace_mut(&mut self) -> &mut StackTrace {
+ &mut (self.0).1
}
}
crates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/lib.rs
+++ b/crates/jrsonnet-evaluator/src/lib.rs
@@ -285,7 +285,7 @@
let result = f();
self.data_mut().stack_depth -= 1;
if let Err(mut err) = result {
- (err.1).0.push(StackTraceElement {
+ err.trace_mut().0.push(StackTraceElement {
location: e.clone(),
desc: frame_desc(),
});
crates/jrsonnet-evaluator/src/trace/mod.rsdiffbeforeafterboth86 evaluation_state: &EvaluationState,86 evaluation_state: &EvaluationState,87 error: &LocError,87 error: &LocError,88 ) -> Result<(), std::fmt::Error> {88 ) -> Result<(), std::fmt::Error> {89 writeln!(out, "{:?}", error.0)?;89 writeln!(out, "{:?}", error.error())?;90 let file_names = (error.1)90 let file_names = error91 .trace()91 .092 .092 .iter()93 .iter()93 .map(|el| {94 .map(|el| {105 })106 })106 .collect::<Vec<_>>();107 .collect::<Vec<_>>();107 let align = file_names.iter().map(|e| e.len()).max().unwrap_or(0);108 let align = file_names.iter().map(|e| e.len()).max().unwrap_or(0);108 for (i, (el, file)) in (error.1).0.iter().zip(file_names).enumerate() {109 for (i, (el, file)) in error.trace().0.iter().zip(file_names).enumerate() {109 if i != 0 {110 if i != 0 {110 writeln!(out)?;111 writeln!(out)?;111 }112 }131 evaluation_state: &EvaluationState,132 evaluation_state: &EvaluationState,132 error: &LocError,133 error: &LocError,133 ) -> Result<(), std::fmt::Error> {134 ) -> Result<(), std::fmt::Error> {134 writeln!(out, "{:?}", error.0)?;135 writeln!(out, "{:?}", error.error())?;135 for (i, item) in (error.1).0.iter().enumerate() {136 for (i, item) in error.trace().0.iter().enumerate() {136 if i != 0 {137 if i != 0 {137 writeln!(out)?;138 writeln!(out)?;138 }139 }170 display_list::{DisplayList, FormatOptions},171 display_list::{DisplayList, FormatOptions},171 snippet::{AnnotationType, Slice, Snippet, SourceAnnotation},172 snippet::{AnnotationType, Slice, Snippet, SourceAnnotation},172 };173 };173 writeln!(out, "{:?}", error.0)?;174 writeln!(out, "{:?}", error.error())?;174 let trace = &error.1;175 let trace = &error.trace();175 for item in trace.0.iter() {176 for item in trace.0.iter() {176 let desc = &item.desc;177 let desc = &item.desc;177 let source = item.location.clone();178 let source = item.location.clone();