difftreelog
fix field in super should not be interpreted with standalone-super concept.
in: master
Jsonnet spec defines special behavior for `super.field` and `field in super` expressions, while in jrsonnet it is implemented by standalone-super concept, with optimizations in case of `super.field`. However, standalone-super is conflicting with `field in super` behavior, so special handling is needed for this expression.
3 files changed
crates/jrsonnet-evaluator/src/evaluate/mod.rsdiffbeforeafterboth1use std::rc::Rc;23use jrsonnet_gcmodule::{Cc, Trace};4use jrsonnet_interner::IStr;5use jrsonnet_parser::{6 ArgsDesc, AssertStmt, BindSpec, CompSpec, Expr, FieldMember, FieldName, ForSpecData,7 IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc,8};9use jrsonnet_types::ValType;1011use self::destructure::destruct;12use crate::{13 arr::ArrValue,14 bail,15 destructure::evaluate_dest,16 error::{suggest_object_fields, ErrorKind::*},17 evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},18 function::{CallLocation, FuncDesc, FuncVal},19 typed::Typed,20 val::{CachedUnbound, IndexableVal, StrValue, Thunk, ThunkValue},21 Context, Error, GcHashMap, ObjValue, ObjValueBuilder, ObjectAssertion, Pending, Result,22 ResultExt, State, Unbound, Val,23};24pub mod destructure;25pub mod operator;2627pub fn evaluate_trivial(expr: &LocExpr) -> Option<Val> {28 fn is_trivial(expr: &LocExpr) -> bool {29 match &*expr.0 {30 Expr::Str(_)31 | Expr::Num(_)32 | Expr::Literal(LiteralType::False | LiteralType::True | LiteralType::Null) => true,33 Expr::Arr(a) => a.iter().all(is_trivial),34 Expr::Parened(e) => is_trivial(e),35 _ => false,36 }37 }38 Some(match &*expr.0 {39 Expr::Str(s) => Val::string(s.clone()),40 Expr::Num(n) => Val::Num(*n),41 Expr::Literal(LiteralType::False) => Val::Bool(false),42 Expr::Literal(LiteralType::True) => Val::Bool(true),43 Expr::Literal(LiteralType::Null) => Val::Null,44 Expr::Arr(n) => {45 if n.iter().any(|e| !is_trivial(e)) {46 return None;47 }48 Val::Arr(ArrValue::eager(49 n.iter()50 .map(evaluate_trivial)51 .map(|e| e.expect("checked trivial"))52 .collect(),53 ))54 }55 Expr::Parened(e) => evaluate_trivial(e)?,56 _ => return None,57 })58}5960pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {61 Val::Func(FuncVal::Normal(Cc::new(FuncDesc {62 name,63 ctx,64 params,65 body,66 })))67}6869pub fn evaluate_field_name(ctx: Context, field_name: &FieldName) -> Result<Option<IStr>> {70 Ok(match field_name {71 FieldName::Fixed(n) => Some(n.clone()),72 FieldName::Dyn(expr) => State::push(73 CallLocation::new(&expr.1),74 || "evaluating field name".to_string(),75 || {76 let value = evaluate(ctx, expr)?;77 if matches!(value, Val::Null) {78 Ok(None)79 } else {80 Ok(Some(IStr::from_untyped(value)?))81 }82 },83 )?,84 })85}8687pub fn evaluate_comp(88 ctx: Context,89 specs: &[CompSpec],90 callback: &mut impl FnMut(Context) -> Result<()>,91) -> Result<()> {92 match specs.first() {93 None => callback(ctx)?,94 Some(CompSpec::IfSpec(IfSpecData(cond))) => {95 if bool::from_untyped(evaluate(ctx.clone(), cond)?)? {96 evaluate_comp(ctx, &specs[1..], callback)?;97 }98 }99 Some(CompSpec::ForSpec(ForSpecData(var, expr))) => match evaluate(ctx.clone(), expr)? {100 Val::Arr(list) => {101 for item in list.iter_lazy() {102 let fctx = Pending::new();103 let mut new_bindings = GcHashMap::with_capacity(var.capacity_hint());104 destruct(var, item, fctx.clone(), &mut new_bindings)?;105 let ctx = ctx106 .clone()107 .extend(new_bindings, None, None, None)108 .into_future(fctx);109110 evaluate_comp(ctx, &specs[1..], callback)?;111 }112 }113 #[cfg(feature = "exp-object-iteration")]114 Val::Obj(obj) => {115 for field in obj.fields(116 // TODO: Should there be ability to preserve iteration order?117 #[cfg(feature = "exp-preserve-order")]118 false,119 ) {120 #[derive(Trace)]121 struct ObjectFieldThunk {122 obj: ObjValue,123 field: IStr,124 }125 impl ThunkValue for ObjectFieldThunk {126 type Output = Val;127128 fn get(self: Box<Self>) -> Result<Self::Output> {129 self.obj.get(self.field).transpose().expect(130 "field exists, as field name was obtained from object.fields()",131 )132 }133 }134135 let fctx = Pending::new();136 let mut new_bindings = GcHashMap::with_capacity(var.capacity_hint());137 let value = Thunk::evaluated(Val::Arr(ArrValue::lazy(vec![138 Thunk::evaluated(Val::string(field.clone())),139 Thunk::new(ObjectFieldThunk {140 field: field.clone(),141 obj: obj.clone(),142 }),143 ])));144 destruct(var, value, fctx.clone(), &mut new_bindings)?;145 let ctx = ctx146 .clone()147 .extend(new_bindings, None, None, None)148 .into_future(fctx);149150 evaluate_comp(ctx, &specs[1..], callback)?;151 }152 }153 _ => bail!(InComprehensionCanOnlyIterateOverArray),154 },155 }156 Ok(())157}158159trait CloneableUnbound<T>: Unbound<Bound = T> + Clone {}160impl<V, T> CloneableUnbound<T> for V where V: Unbound<Bound = T> + Clone {}161162fn evaluate_object_locals(163 fctx: Pending<Context>,164 locals: Rc<Vec<BindSpec>>,165) -> impl CloneableUnbound<Context> {166 #[derive(Trace, Clone)]167 struct UnboundLocals {168 fctx: Pending<Context>,169 locals: Rc<Vec<BindSpec>>,170 }171 impl Unbound for UnboundLocals {172 type Bound = Context;173174 fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Context> {175 let fctx = Context::new_future();176 let mut new_bindings =177 GcHashMap::with_capacity(self.locals.iter().map(BindSpec::capacity_hint).sum());178 for b in self.locals.iter() {179 evaluate_dest(b, fctx.clone(), &mut new_bindings)?;180 }181182 let ctx = self.fctx.unwrap();183 let new_dollar = ctx.dollar().cloned().or_else(|| this.clone());184185 let ctx = ctx186 .extend(new_bindings, new_dollar, sup, this)187 .into_future(fctx);188189 Ok(ctx)190 }191 }192193 UnboundLocals { fctx, locals }194}195196pub fn evaluate_field_member<B: Unbound<Bound = Context> + Clone>(197 builder: &mut ObjValueBuilder,198 ctx: Context,199 uctx: B,200 field: &FieldMember,201) -> Result<()> {202 let name = evaluate_field_name(ctx, &field.name)?;203 let Some(name) = name else {204 return Ok(());205 };206207 match field {208 FieldMember {209 plus,210 params: None,211 visibility,212 value,213 ..214 } => {215 #[derive(Trace)]216 struct UnboundValue<B: Trace> {217 uctx: B,218 value: LocExpr,219 name: IStr,220 }221 impl<B: Unbound<Bound = Context>> Unbound for UnboundValue<B> {222 type Bound = Val;223 fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Val> {224 evaluate_named(self.uctx.bind(sup, this)?, &self.value, self.name.clone())225 }226 }227228 builder229 .field(name.clone())230 .with_add(*plus)231 .with_visibility(*visibility)232 .with_location(value.1.clone())233 .bindable(UnboundValue {234 uctx,235 value: value.clone(),236 name,237 })?;238 }239 FieldMember {240 params: Some(params),241 visibility,242 value,243 ..244 } => {245 #[derive(Trace)]246 struct UnboundMethod<B: Trace> {247 uctx: B,248 value: LocExpr,249 params: ParamsDesc,250 name: IStr,251 }252 impl<B: Unbound<Bound = Context>> Unbound for UnboundMethod<B> {253 type Bound = Val;254 fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Val> {255 Ok(evaluate_method(256 self.uctx.bind(sup, this)?,257 self.name.clone(),258 self.params.clone(),259 self.value.clone(),260 ))261 }262 }263264 builder265 .field(name.clone())266 .with_visibility(*visibility)267 .with_location(value.1.clone())268 .bindable(UnboundMethod {269 uctx,270 value: value.clone(),271 params: params.clone(),272 name,273 })?;274 }275 }276 Ok(())277}278279#[allow(clippy::too_many_lines)]280pub fn evaluate_member_list_object(ctx: Context, members: &[Member]) -> Result<ObjValue> {281 let mut builder = ObjValueBuilder::new();282 let locals = Rc::new(283 members284 .iter()285 .filter_map(|m| match m {286 Member::BindStmt(bind) => Some(bind.clone()),287 _ => None,288 })289 .collect::<Vec<_>>(),290 );291292 let fctx = Context::new_future();293294 // We have single context for all fields, so we can cache binds295 let uctx = CachedUnbound::new(evaluate_object_locals(fctx.clone(), locals));296297 for member in members {298 match member {299 Member::Field(field) => {300 evaluate_field_member(&mut builder, ctx.clone(), uctx.clone(), field)?;301 }302 Member::AssertStmt(stmt) => {303 #[derive(Trace)]304 struct ObjectAssert<B: Trace> {305 uctx: B,306 assert: AssertStmt,307 }308 impl<B: Unbound<Bound = Context>> ObjectAssertion for ObjectAssert<B> {309 fn run(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<()> {310 let ctx = self.uctx.bind(sup, this)?;311 evaluate_assert(ctx, &self.assert)312 }313 }314 builder.assert(ObjectAssert {315 uctx: uctx.clone(),316 assert: stmt.clone(),317 });318 }319 Member::BindStmt(_) => {320 // Already handled321 }322 }323 }324 let this = builder.build();325 fctx.fill(ctx.extend(GcHashMap::new(), None, None, Some(this.clone())));326 Ok(this)327}328329pub fn evaluate_object(ctx: Context, object: &ObjBody) -> Result<ObjValue> {330 Ok(match object {331 ObjBody::MemberList(members) => evaluate_member_list_object(ctx, members)?,332 ObjBody::ObjComp(obj) => {333 let mut builder = ObjValueBuilder::new();334 let locals = Rc::new(335 obj.pre_locals336 .iter()337 .chain(obj.post_locals.iter())338 .cloned()339 .collect::<Vec<_>>(),340 );341 let mut ctxs = vec![];342 evaluate_comp(ctx, &obj.compspecs, &mut |ctx| {343 let fctx = Context::new_future();344 ctxs.push((ctx.clone(), fctx.clone()));345 let uctx = evaluate_object_locals(fctx, locals.clone());346347 evaluate_field_member(&mut builder, ctx, uctx, &obj.field)348 })?;349350 let this = builder.build();351 for (ctx, fctx) in ctxs {352 let _ctx = ctx353 .extend(GcHashMap::new(), None, None, Some(this.clone()))354 .into_future(fctx);355 }356 this357 }358 })359}360361pub fn evaluate_apply(362 ctx: Context,363 value: &LocExpr,364 args: &ArgsDesc,365 loc: CallLocation<'_>,366 tailstrict: bool,367) -> Result<Val> {368 let value = evaluate(ctx.clone(), value)?;369 Ok(match value {370 Val::Func(f) => {371 let body = || f.evaluate(ctx, loc, args, tailstrict);372 if tailstrict {373 body()?374 } else {375 State::push(loc, || format!("function <{}> call", f.name()), body)?376 }377 }378 v => bail!(OnlyFunctionsCanBeCalledGot(v.value_type())),379 })380}381382pub fn evaluate_assert(ctx: Context, assertion: &AssertStmt) -> Result<()> {383 let value = &assertion.0;384 let msg = &assertion.1;385 let assertion_result = State::push(386 CallLocation::new(&value.1),387 || "assertion condition".to_owned(),388 || bool::from_untyped(evaluate(ctx.clone(), value)?),389 )?;390 if !assertion_result {391 State::push(392 CallLocation::new(&value.1),393 || "assertion failure".to_owned(),394 || {395 if let Some(msg) = msg {396 bail!(AssertionFailed(evaluate(ctx, msg)?.to_string()?));397 }398 bail!(AssertionFailed(Val::Null.to_string()?));399 },400 )?;401 }402 Ok(())403}404405pub fn evaluate_named(ctx: Context, expr: &LocExpr, name: IStr) -> Result<Val> {406 use Expr::*;407 let LocExpr(raw_expr, _loc) = expr;408 Ok(match &**raw_expr {409 Function(params, body) => evaluate_method(ctx, name, params.clone(), body.clone()),410 _ => evaluate(ctx, expr)?,411 })412}413414#[allow(clippy::too_many_lines)]415pub fn evaluate(ctx: Context, expr: &LocExpr) -> Result<Val> {416 use Expr::*;417418 if let Some(trivial) = evaluate_trivial(expr) {419 return Ok(trivial);420 }421 let LocExpr(expr, loc) = expr;422 Ok(match &**expr {423 Literal(LiteralType::This) => {424 Val::Obj(ctx.this().ok_or(CantUseSelfOutsideOfObject)?.clone())425 }426 Literal(LiteralType::Super) => Val::Obj(427 ctx.super_obj().ok_or(NoSuperFound)?.with_this(428 ctx.this()429 .expect("if super exists - then this should too")430 .clone(),431 ),432 ),433 Literal(LiteralType::Dollar) => {434 Val::Obj(ctx.dollar().ok_or(NoTopLevelObjectFound)?.clone())435 }436 Literal(LiteralType::True) => Val::Bool(true),437 Literal(LiteralType::False) => Val::Bool(false),438 Literal(LiteralType::Null) => Val::Null,439 Parened(e) => evaluate(ctx, e)?,440 Str(v) => Val::string(v.clone()),441 Num(v) => Val::new_checked_num(*v)?,442 BinaryOp(v1, o, v2) => evaluate_binary_op_special(ctx, v1, *o, v2)?,443 UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(ctx, v)?)?,444 Var(name) => State::push(445 CallLocation::new(loc),446 || format!("variable <{name}> access"),447 || ctx.binding(name.clone())?.evaluate(),448 )?,449 Index { indexable, parts } => {450 let mut parts = parts.iter();451 let mut indexable = match &indexable {452 // Cheaper to execute than creating object with overriden `this`453 LocExpr(v, _) if matches!(&**v, Expr::Literal(LiteralType::Super)) => {454 let part = parts.next().expect("at least part should exist");455 let Some(super_obj) = ctx.super_obj() else {456 #[cfg(feature = "exp-null-coaelse")]457 if part.null_coaelse {458 return Ok(Val::Null);459 }460 bail!(NoSuperFound)461 };462 let name = evaluate(ctx.clone(), &part.value)?;463464 let Val::Str(name) = name else {465 bail!(ValueIndexMustBeTypeGot(466 ValType::Obj,467 ValType::Str,468 name.value_type(),469 ))470 };471472 let this = ctx473 .this()474 .expect("no this found, while super present, should not happen");475 let name = name.into_flat();476 match super_obj477 .get_for(name.clone(), this.clone())478 .with_description_src(&part.value, || format!("field <{name}> access"))?479 {480 Some(v) => v,481 #[cfg(feature = "exp-null-coaelse")]482 None if part.null_coaelse => return Ok(Val::Null),483 None => {484 let suggestions = suggest_object_fields(super_obj, name.clone());485486 bail!(NoSuchField(name, suggestions))487 }488 }489 }490 e => evaluate(ctx.clone(), e)?,491 };492493 for part in parts {494 indexable = match (indexable, evaluate(ctx.clone(), &part.value)?) {495 (Val::Obj(v), Val::Str(key)) => match v496 .get(key.clone().into_flat())497 .with_description_src(&part.value, || format!("field <{key}> access"))?498 {499 Some(v) => v,500 #[cfg(feature = "exp-null-coaelse")]501 None if part.null_coaelse => return Ok(Val::Null),502 None => {503 let suggestions = suggest_object_fields(&v, key.clone().into_flat());504505 return Err(Error::from(NoSuchField(506 key.clone().into_flat(),507 suggestions,508 )))509 .with_description_src(&part.value, || format!("field <{key}> access"));510 }511 },512 (Val::Obj(_), n) => bail!(ValueIndexMustBeTypeGot(513 ValType::Obj,514 ValType::Str,515 n.value_type(),516 )),517 (Val::Arr(v), Val::Num(n)) => {518 if n.fract() > f64::EPSILON {519 bail!(FractionalIndex)520 }521 if n < 0.0 {522 bail!(ArrayBoundsError(n as isize, v.len()));523 }524 v.get(n as usize)?525 .ok_or_else(|| ArrayBoundsError(n as isize, v.len()))?526 }527 (Val::Arr(_), Val::Str(n)) => {528 bail!(AttemptedIndexAnArrayWithString(n.into_flat()))529 }530 (Val::Arr(_), n) => bail!(ValueIndexMustBeTypeGot(531 ValType::Arr,532 ValType::Num,533 n.value_type(),534 )),535536 (Val::Str(s), Val::Num(n)) => Val::Str({537 let v: IStr = s538 .clone()539 .into_flat()540 .chars()541 .skip(n as usize)542 .take(1)543 .collect::<String>()544 .into();545 if v.is_empty() {546 let size = s.into_flat().chars().count();547 bail!(StringBoundsError(n as usize, size))548 }549 StrValue::Flat(v)550 }),551 (Val::Str(_), n) => bail!(ValueIndexMustBeTypeGot(552 ValType::Str,553 ValType::Num,554 n.value_type(),555 )),556 #[cfg(feature = "exp-null-coaelse")]557 (Val::Null, _) if part.null_coaelse => return Ok(Val::Null),558 (v, _) => bail!(CantIndexInto(v.value_type())),559 };560 }561 indexable562 }563 LocalExpr(bindings, returned) => {564 let mut new_bindings: GcHashMap<IStr, Thunk<Val>> =565 GcHashMap::with_capacity(bindings.iter().map(BindSpec::capacity_hint).sum());566 let fctx = Context::new_future();567 for b in bindings {568 evaluate_dest(b, fctx.clone(), &mut new_bindings)?;569 }570 let ctx = ctx.extend(new_bindings, None, None, None).into_future(fctx);571 evaluate(ctx, &returned.clone())?572 }573 Arr(items) => {574 if items.is_empty() {575 Val::Arr(ArrValue::empty())576 } else if items.len() == 1 {577 #[derive(Trace)]578 struct ArrayElement {579 ctx: Context,580 item: LocExpr,581 }582 impl ThunkValue for ArrayElement {583 type Output = Val;584 fn get(self: Box<Self>) -> Result<Val> {585 evaluate(self.ctx, &self.item)586 }587 }588 Val::Arr(ArrValue::lazy(vec![Thunk::new(ArrayElement {589 ctx,590 item: items[0].clone(),591 })]))592 } else {593 Val::Arr(ArrValue::expr(ctx, items.iter().cloned()))594 }595 }596 ArrComp(expr, comp_specs) => {597 let mut out = Vec::new();598 evaluate_comp(ctx, comp_specs, &mut |ctx| {599 #[derive(Trace)]600 struct EvaluateThunk {601 ctx: Context,602 expr: LocExpr,603 }604 impl ThunkValue for EvaluateThunk {605 type Output = Val;606 fn get(self: Box<Self>) -> Result<Val> {607 evaluate(self.ctx, &self.expr)608 }609 }610 out.push(Thunk::new(EvaluateThunk {611 ctx,612 expr: expr.clone(),613 }));614 Ok(())615 })?;616 Val::Arr(ArrValue::lazy(out))617 }618 Obj(body) => Val::Obj(evaluate_object(ctx, body)?),619 ObjExtend(a, b) => evaluate_add_op(620 &evaluate(ctx.clone(), a)?,621 &Val::Obj(evaluate_object(ctx, b)?),622 )?,623 Apply(value, args, tailstrict) => {624 evaluate_apply(ctx, value, args, CallLocation::new(loc), *tailstrict)?625 }626 Function(params, body) => {627 evaluate_method(ctx, "anonymous".into(), params.clone(), body.clone())628 }629 AssertExpr(assert, returned) => {630 evaluate_assert(ctx.clone(), assert)?;631 evaluate(ctx, returned)?632 }633 ErrorStmt(e) => State::push(634 CallLocation::new(loc),635 || "error statement".to_owned(),636 || bail!(RuntimeError(evaluate(ctx, e)?.to_string()?,)),637 )?,638 IfElse {639 cond,640 cond_then,641 cond_else,642 } => {643 if State::push(644 CallLocation::new(loc),645 || "if condition".to_owned(),646 || bool::from_untyped(evaluate(ctx.clone(), &cond.0)?),647 )? {648 evaluate(ctx, cond_then)?649 } else {650 match cond_else {651 Some(v) => evaluate(ctx, v)?,652 None => Val::Null,653 }654 }655 }656 Slice(value, desc) => {657 fn parse_idx<T: Typed>(658 loc: CallLocation<'_>,659 ctx: &Context,660 expr: Option<&LocExpr>,661 desc: &'static str,662 ) -> Result<Option<T>> {663 if let Some(value) = expr {664 Ok(Some(State::push(665 loc,666 || format!("slice {desc}"),667 || T::from_untyped(evaluate(ctx.clone(), value)?),668 )?))669 } else {670 Ok(None)671 }672 }673674 let indexable = evaluate(ctx.clone(), value)?;675 let loc = CallLocation::new(loc);676677 let start = parse_idx(loc, &ctx, desc.start.as_ref(), "start")?;678 let end = parse_idx(loc, &ctx, desc.end.as_ref(), "end")?;679 let step = parse_idx(loc, &ctx, desc.step.as_ref(), "step")?;680681 IndexableVal::into_untyped(indexable.into_indexable()?.slice(start, end, step)?)?682 }683 i @ (Import(path) | ImportStr(path) | ImportBin(path)) => {684 let Expr::Str(path) = &*path.0 else {685 bail!("computed imports are not supported")686 };687 let tmp = loc.clone().0;688 let s = ctx.state();689 let resolved_path = s.resolve_from(tmp.source_path(), path as &str)?;690 match i {691 Import(_) => State::push(692 CallLocation::new(loc),693 || format!("import {:?}", path.clone()),694 || s.import_resolved(resolved_path),695 )?,696 ImportStr(_) => Val::string(s.import_resolved_str(resolved_path)?),697 ImportBin(_) => Val::Arr(ArrValue::bytes(s.import_resolved_bin(resolved_path)?)),698 _ => unreachable!(),699 }700 }701 })702}1use std::rc::Rc;23use jrsonnet_gcmodule::{Cc, Trace};4use jrsonnet_interner::IStr;5use jrsonnet_parser::{6 ArgsDesc, AssertStmt, BinaryOpType, BindSpec, CompSpec, Expr, FieldMember, FieldName,7 ForSpecData, IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc,8};9use jrsonnet_types::ValType;1011use self::destructure::destruct;12use crate::{13 arr::ArrValue,14 bail,15 destructure::evaluate_dest,16 error::{suggest_object_fields, ErrorKind::*},17 evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},18 function::{CallLocation, FuncDesc, FuncVal},19 typed::Typed,20 val::{CachedUnbound, IndexableVal, StrValue, Thunk, ThunkValue},21 Context, Error, GcHashMap, ObjValue, ObjValueBuilder, ObjectAssertion, Pending, Result,22 ResultExt, State, Unbound, Val,23};24pub mod destructure;25pub mod operator;2627pub fn evaluate_trivial(expr: &LocExpr) -> Option<Val> {28 fn is_trivial(expr: &LocExpr) -> bool {29 match &*expr.0 {30 Expr::Str(_)31 | Expr::Num(_)32 | Expr::Literal(LiteralType::False | LiteralType::True | LiteralType::Null) => true,33 Expr::Arr(a) => a.iter().all(is_trivial),34 Expr::Parened(e) => is_trivial(e),35 _ => false,36 }37 }38 Some(match &*expr.0 {39 Expr::Str(s) => Val::string(s.clone()),40 Expr::Num(n) => Val::Num(*n),41 Expr::Literal(LiteralType::False) => Val::Bool(false),42 Expr::Literal(LiteralType::True) => Val::Bool(true),43 Expr::Literal(LiteralType::Null) => Val::Null,44 Expr::Arr(n) => {45 if n.iter().any(|e| !is_trivial(e)) {46 return None;47 }48 Val::Arr(ArrValue::eager(49 n.iter()50 .map(evaluate_trivial)51 .map(|e| e.expect("checked trivial"))52 .collect(),53 ))54 }55 Expr::Parened(e) => evaluate_trivial(e)?,56 _ => return None,57 })58}5960pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {61 Val::Func(FuncVal::Normal(Cc::new(FuncDesc {62 name,63 ctx,64 params,65 body,66 })))67}6869pub fn evaluate_field_name(ctx: Context, field_name: &FieldName) -> Result<Option<IStr>> {70 Ok(match field_name {71 FieldName::Fixed(n) => Some(n.clone()),72 FieldName::Dyn(expr) => State::push(73 CallLocation::new(&expr.1),74 || "evaluating field name".to_string(),75 || {76 let value = evaluate(ctx, expr)?;77 if matches!(value, Val::Null) {78 Ok(None)79 } else {80 Ok(Some(IStr::from_untyped(value)?))81 }82 },83 )?,84 })85}8687pub fn evaluate_comp(88 ctx: Context,89 specs: &[CompSpec],90 callback: &mut impl FnMut(Context) -> Result<()>,91) -> Result<()> {92 match specs.first() {93 None => callback(ctx)?,94 Some(CompSpec::IfSpec(IfSpecData(cond))) => {95 if bool::from_untyped(evaluate(ctx.clone(), cond)?)? {96 evaluate_comp(ctx, &specs[1..], callback)?;97 }98 }99 Some(CompSpec::ForSpec(ForSpecData(var, expr))) => match evaluate(ctx.clone(), expr)? {100 Val::Arr(list) => {101 for item in list.iter_lazy() {102 let fctx = Pending::new();103 let mut new_bindings = GcHashMap::with_capacity(var.capacity_hint());104 destruct(var, item, fctx.clone(), &mut new_bindings)?;105 let ctx = ctx106 .clone()107 .extend(new_bindings, None, None, None)108 .into_future(fctx);109110 evaluate_comp(ctx, &specs[1..], callback)?;111 }112 }113 #[cfg(feature = "exp-object-iteration")]114 Val::Obj(obj) => {115 for field in obj.fields(116 // TODO: Should there be ability to preserve iteration order?117 #[cfg(feature = "exp-preserve-order")]118 false,119 ) {120 #[derive(Trace)]121 struct ObjectFieldThunk {122 obj: ObjValue,123 field: IStr,124 }125 impl ThunkValue for ObjectFieldThunk {126 type Output = Val;127128 fn get(self: Box<Self>) -> Result<Self::Output> {129 self.obj.get(self.field).transpose().expect(130 "field exists, as field name was obtained from object.fields()",131 )132 }133 }134135 let fctx = Pending::new();136 let mut new_bindings = GcHashMap::with_capacity(var.capacity_hint());137 let value = Thunk::evaluated(Val::Arr(ArrValue::lazy(vec![138 Thunk::evaluated(Val::string(field.clone())),139 Thunk::new(ObjectFieldThunk {140 field: field.clone(),141 obj: obj.clone(),142 }),143 ])));144 destruct(var, value, fctx.clone(), &mut new_bindings)?;145 let ctx = ctx146 .clone()147 .extend(new_bindings, None, None, None)148 .into_future(fctx);149150 evaluate_comp(ctx, &specs[1..], callback)?;151 }152 }153 _ => bail!(InComprehensionCanOnlyIterateOverArray),154 },155 }156 Ok(())157}158159trait CloneableUnbound<T>: Unbound<Bound = T> + Clone {}160impl<V, T> CloneableUnbound<T> for V where V: Unbound<Bound = T> + Clone {}161162fn evaluate_object_locals(163 fctx: Pending<Context>,164 locals: Rc<Vec<BindSpec>>,165) -> impl CloneableUnbound<Context> {166 #[derive(Trace, Clone)]167 struct UnboundLocals {168 fctx: Pending<Context>,169 locals: Rc<Vec<BindSpec>>,170 }171 impl Unbound for UnboundLocals {172 type Bound = Context;173174 fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Context> {175 let fctx = Context::new_future();176 let mut new_bindings =177 GcHashMap::with_capacity(self.locals.iter().map(BindSpec::capacity_hint).sum());178 for b in self.locals.iter() {179 evaluate_dest(b, fctx.clone(), &mut new_bindings)?;180 }181182 let ctx = self.fctx.unwrap();183 let new_dollar = ctx.dollar().cloned().or_else(|| this.clone());184185 let ctx = ctx186 .extend(new_bindings, new_dollar, sup, this)187 .into_future(fctx);188189 Ok(ctx)190 }191 }192193 UnboundLocals { fctx, locals }194}195196pub fn evaluate_field_member<B: Unbound<Bound = Context> + Clone>(197 builder: &mut ObjValueBuilder,198 ctx: Context,199 uctx: B,200 field: &FieldMember,201) -> Result<()> {202 let name = evaluate_field_name(ctx, &field.name)?;203 let Some(name) = name else {204 return Ok(());205 };206207 match field {208 FieldMember {209 plus,210 params: None,211 visibility,212 value,213 ..214 } => {215 #[derive(Trace)]216 struct UnboundValue<B: Trace> {217 uctx: B,218 value: LocExpr,219 name: IStr,220 }221 impl<B: Unbound<Bound = Context>> Unbound for UnboundValue<B> {222 type Bound = Val;223 fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Val> {224 evaluate_named(self.uctx.bind(sup, this)?, &self.value, self.name.clone())225 }226 }227228 builder229 .field(name.clone())230 .with_add(*plus)231 .with_visibility(*visibility)232 .with_location(value.1.clone())233 .bindable(UnboundValue {234 uctx,235 value: value.clone(),236 name,237 })?;238 }239 FieldMember {240 params: Some(params),241 visibility,242 value,243 ..244 } => {245 #[derive(Trace)]246 struct UnboundMethod<B: Trace> {247 uctx: B,248 value: LocExpr,249 params: ParamsDesc,250 name: IStr,251 }252 impl<B: Unbound<Bound = Context>> Unbound for UnboundMethod<B> {253 type Bound = Val;254 fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Val> {255 Ok(evaluate_method(256 self.uctx.bind(sup, this)?,257 self.name.clone(),258 self.params.clone(),259 self.value.clone(),260 ))261 }262 }263264 builder265 .field(name.clone())266 .with_visibility(*visibility)267 .with_location(value.1.clone())268 .bindable(UnboundMethod {269 uctx,270 value: value.clone(),271 params: params.clone(),272 name,273 })?;274 }275 }276 Ok(())277}278279#[allow(clippy::too_many_lines)]280pub fn evaluate_member_list_object(ctx: Context, members: &[Member]) -> Result<ObjValue> {281 let mut builder = ObjValueBuilder::new();282 let locals = Rc::new(283 members284 .iter()285 .filter_map(|m| match m {286 Member::BindStmt(bind) => Some(bind.clone()),287 _ => None,288 })289 .collect::<Vec<_>>(),290 );291292 let fctx = Context::new_future();293294 // We have single context for all fields, so we can cache binds295 let uctx = CachedUnbound::new(evaluate_object_locals(fctx.clone(), locals));296297 for member in members {298 match member {299 Member::Field(field) => {300 evaluate_field_member(&mut builder, ctx.clone(), uctx.clone(), field)?;301 }302 Member::AssertStmt(stmt) => {303 #[derive(Trace)]304 struct ObjectAssert<B: Trace> {305 uctx: B,306 assert: AssertStmt,307 }308 impl<B: Unbound<Bound = Context>> ObjectAssertion for ObjectAssert<B> {309 fn run(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<()> {310 let ctx = self.uctx.bind(sup, this)?;311 evaluate_assert(ctx, &self.assert)312 }313 }314 builder.assert(ObjectAssert {315 uctx: uctx.clone(),316 assert: stmt.clone(),317 });318 }319 Member::BindStmt(_) => {320 // Already handled321 }322 }323 }324 let this = builder.build();325 fctx.fill(ctx.extend(GcHashMap::new(), None, None, Some(this.clone())));326 Ok(this)327}328329pub fn evaluate_object(ctx: Context, object: &ObjBody) -> Result<ObjValue> {330 Ok(match object {331 ObjBody::MemberList(members) => evaluate_member_list_object(ctx, members)?,332 ObjBody::ObjComp(obj) => {333 let mut builder = ObjValueBuilder::new();334 let locals = Rc::new(335 obj.pre_locals336 .iter()337 .chain(obj.post_locals.iter())338 .cloned()339 .collect::<Vec<_>>(),340 );341 let mut ctxs = vec![];342 evaluate_comp(ctx, &obj.compspecs, &mut |ctx| {343 let fctx = Context::new_future();344 ctxs.push((ctx.clone(), fctx.clone()));345 let uctx = evaluate_object_locals(fctx, locals.clone());346347 evaluate_field_member(&mut builder, ctx, uctx, &obj.field)348 })?;349350 let this = builder.build();351 for (ctx, fctx) in ctxs {352 let _ctx = ctx353 .extend(GcHashMap::new(), None, None, Some(this.clone()))354 .into_future(fctx);355 }356 this357 }358 })359}360361pub fn evaluate_apply(362 ctx: Context,363 value: &LocExpr,364 args: &ArgsDesc,365 loc: CallLocation<'_>,366 tailstrict: bool,367) -> Result<Val> {368 let value = evaluate(ctx.clone(), value)?;369 Ok(match value {370 Val::Func(f) => {371 let body = || f.evaluate(ctx, loc, args, tailstrict);372 if tailstrict {373 body()?374 } else {375 State::push(loc, || format!("function <{}> call", f.name()), body)?376 }377 }378 v => bail!(OnlyFunctionsCanBeCalledGot(v.value_type())),379 })380}381382pub fn evaluate_assert(ctx: Context, assertion: &AssertStmt) -> Result<()> {383 let value = &assertion.0;384 let msg = &assertion.1;385 let assertion_result = State::push(386 CallLocation::new(&value.1),387 || "assertion condition".to_owned(),388 || bool::from_untyped(evaluate(ctx.clone(), value)?),389 )?;390 if !assertion_result {391 State::push(392 CallLocation::new(&value.1),393 || "assertion failure".to_owned(),394 || {395 if let Some(msg) = msg {396 bail!(AssertionFailed(evaluate(ctx, msg)?.to_string()?));397 }398 bail!(AssertionFailed(Val::Null.to_string()?));399 },400 )?;401 }402 Ok(())403}404405pub fn evaluate_named(ctx: Context, expr: &LocExpr, name: IStr) -> Result<Val> {406 use Expr::*;407 let LocExpr(raw_expr, _loc) = expr;408 Ok(match &**raw_expr {409 Function(params, body) => evaluate_method(ctx, name, params.clone(), body.clone()),410 _ => evaluate(ctx, expr)?,411 })412}413414#[allow(clippy::too_many_lines)]415pub fn evaluate(ctx: Context, expr: &LocExpr) -> Result<Val> {416 use Expr::*;417418 if let Some(trivial) = evaluate_trivial(expr) {419 return Ok(trivial);420 }421 let LocExpr(expr, loc) = expr;422 Ok(match &**expr {423 Literal(LiteralType::This) => {424 Val::Obj(ctx.this().ok_or(CantUseSelfOutsideOfObject)?.clone())425 }426 Literal(LiteralType::Super) => Val::Obj(427 ctx.super_obj().ok_or(NoSuperFound)?.with_this(428 ctx.this()429 .expect("if super exists - then this should too")430 .clone(),431 ),432 ),433 Literal(LiteralType::Dollar) => {434 Val::Obj(ctx.dollar().ok_or(NoTopLevelObjectFound)?.clone())435 }436 Literal(LiteralType::True) => Val::Bool(true),437 Literal(LiteralType::False) => Val::Bool(false),438 Literal(LiteralType::Null) => Val::Null,439 Parened(e) => evaluate(ctx, e)?,440 Str(v) => Val::string(v.clone()),441 Num(v) => Val::new_checked_num(*v)?,442 // I have tried to remove special behavior from super by implementing standalone-super443 // expresion, but looks like this case still needs special treatment.444 //445 // Note that other jsonnet implementations will fail on `if value in (super)` expression,446 // because the standalone super literal is not supported, that is because in other447 // implementations `in super` treated differently from in `smth_else`.448 BinaryOp(field, BinaryOpType::In, e)449 if matches!(&*e.0, Expr::Literal(LiteralType::Super)) =>450 {451 let Some(super_obj) = ctx.super_obj() else {452 return Ok(Val::Bool(false));453 };454 let field = evaluate(ctx.clone(), field)?;455 Val::Bool(super_obj.has_field_ex(field.to_string()?, true))456 }457 BinaryOp(v1, o, v2) => evaluate_binary_op_special(ctx, v1, *o, v2)?,458 UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(ctx, v)?)?,459 Var(name) => State::push(460 CallLocation::new(loc),461 || format!("variable <{name}> access"),462 || ctx.binding(name.clone())?.evaluate(),463 )?,464 Index { indexable, parts } => {465 let mut parts = parts.iter();466 let mut indexable = match &indexable {467 // Cheaper to execute than creating object with overriden `this`468 LocExpr(v, _) if matches!(&**v, Expr::Literal(LiteralType::Super)) => {469 let part = parts.next().expect("at least part should exist");470 let Some(super_obj) = ctx.super_obj() else {471 #[cfg(feature = "exp-null-coaelse")]472 if part.null_coaelse {473 return Ok(Val::Null);474 }475 bail!(NoSuperFound)476 };477 let name = evaluate(ctx.clone(), &part.value)?;478479 let Val::Str(name) = name else {480 bail!(ValueIndexMustBeTypeGot(481 ValType::Obj,482 ValType::Str,483 name.value_type(),484 ))485 };486487 let this = ctx488 .this()489 .expect("no this found, while super present, should not happen");490 let name = name.into_flat();491 match super_obj492 .get_for(name.clone(), this.clone())493 .with_description_src(&part.value, || format!("field <{name}> access"))?494 {495 Some(v) => v,496 #[cfg(feature = "exp-null-coaelse")]497 None if part.null_coaelse => return Ok(Val::Null),498 None => {499 let suggestions = suggest_object_fields(super_obj, name.clone());500501 bail!(NoSuchField(name, suggestions))502 }503 }504 }505 e => evaluate(ctx.clone(), e)?,506 };507508 for part in parts {509 indexable = match (indexable, evaluate(ctx.clone(), &part.value)?) {510 (Val::Obj(v), Val::Str(key)) => match v511 .get(key.clone().into_flat())512 .with_description_src(&part.value, || format!("field <{key}> access"))?513 {514 Some(v) => v,515 #[cfg(feature = "exp-null-coaelse")]516 None if part.null_coaelse => return Ok(Val::Null),517 None => {518 let suggestions = suggest_object_fields(&v, key.clone().into_flat());519520 return Err(Error::from(NoSuchField(521 key.clone().into_flat(),522 suggestions,523 )))524 .with_description_src(&part.value, || format!("field <{key}> access"));525 }526 },527 (Val::Obj(_), n) => bail!(ValueIndexMustBeTypeGot(528 ValType::Obj,529 ValType::Str,530 n.value_type(),531 )),532 (Val::Arr(v), Val::Num(n)) => {533 if n.fract() > f64::EPSILON {534 bail!(FractionalIndex)535 }536 if n < 0.0 {537 bail!(ArrayBoundsError(n as isize, v.len()));538 }539 v.get(n as usize)?540 .ok_or_else(|| ArrayBoundsError(n as isize, v.len()))?541 }542 (Val::Arr(_), Val::Str(n)) => {543 bail!(AttemptedIndexAnArrayWithString(n.into_flat()))544 }545 (Val::Arr(_), n) => bail!(ValueIndexMustBeTypeGot(546 ValType::Arr,547 ValType::Num,548 n.value_type(),549 )),550551 (Val::Str(s), Val::Num(n)) => Val::Str({552 let v: IStr = s553 .clone()554 .into_flat()555 .chars()556 .skip(n as usize)557 .take(1)558 .collect::<String>()559 .into();560 if v.is_empty() {561 let size = s.into_flat().chars().count();562 bail!(StringBoundsError(n as usize, size))563 }564 StrValue::Flat(v)565 }),566 (Val::Str(_), n) => bail!(ValueIndexMustBeTypeGot(567 ValType::Str,568 ValType::Num,569 n.value_type(),570 )),571 #[cfg(feature = "exp-null-coaelse")]572 (Val::Null, _) if part.null_coaelse => return Ok(Val::Null),573 (v, _) => bail!(CantIndexInto(v.value_type())),574 };575 }576 indexable577 }578 LocalExpr(bindings, returned) => {579 let mut new_bindings: GcHashMap<IStr, Thunk<Val>> =580 GcHashMap::with_capacity(bindings.iter().map(BindSpec::capacity_hint).sum());581 let fctx = Context::new_future();582 for b in bindings {583 evaluate_dest(b, fctx.clone(), &mut new_bindings)?;584 }585 let ctx = ctx.extend(new_bindings, None, None, None).into_future(fctx);586 evaluate(ctx, &returned.clone())?587 }588 Arr(items) => {589 if items.is_empty() {590 Val::Arr(ArrValue::empty())591 } else if items.len() == 1 {592 #[derive(Trace)]593 struct ArrayElement {594 ctx: Context,595 item: LocExpr,596 }597 impl ThunkValue for ArrayElement {598 type Output = Val;599 fn get(self: Box<Self>) -> Result<Val> {600 evaluate(self.ctx, &self.item)601 }602 }603 Val::Arr(ArrValue::lazy(vec![Thunk::new(ArrayElement {604 ctx,605 item: items[0].clone(),606 })]))607 } else {608 Val::Arr(ArrValue::expr(ctx, items.iter().cloned()))609 }610 }611 ArrComp(expr, comp_specs) => {612 let mut out = Vec::new();613 evaluate_comp(ctx, comp_specs, &mut |ctx| {614 #[derive(Trace)]615 struct EvaluateThunk {616 ctx: Context,617 expr: LocExpr,618 }619 impl ThunkValue for EvaluateThunk {620 type Output = Val;621 fn get(self: Box<Self>) -> Result<Val> {622 evaluate(self.ctx, &self.expr)623 }624 }625 out.push(Thunk::new(EvaluateThunk {626 ctx,627 expr: expr.clone(),628 }));629 Ok(())630 })?;631 Val::Arr(ArrValue::lazy(out))632 }633 Obj(body) => Val::Obj(evaluate_object(ctx, body)?),634 ObjExtend(a, b) => evaluate_add_op(635 &evaluate(ctx.clone(), a)?,636 &Val::Obj(evaluate_object(ctx, b)?),637 )?,638 Apply(value, args, tailstrict) => {639 evaluate_apply(ctx, value, args, CallLocation::new(loc), *tailstrict)?640 }641 Function(params, body) => {642 evaluate_method(ctx, "anonymous".into(), params.clone(), body.clone())643 }644 AssertExpr(assert, returned) => {645 evaluate_assert(ctx.clone(), assert)?;646 evaluate(ctx, returned)?647 }648 ErrorStmt(e) => State::push(649 CallLocation::new(loc),650 || "error statement".to_owned(),651 || bail!(RuntimeError(evaluate(ctx, e)?.to_string()?,)),652 )?,653 IfElse {654 cond,655 cond_then,656 cond_else,657 } => {658 if State::push(659 CallLocation::new(loc),660 || "if condition".to_owned(),661 || bool::from_untyped(evaluate(ctx.clone(), &cond.0)?),662 )? {663 evaluate(ctx, cond_then)?664 } else {665 match cond_else {666 Some(v) => evaluate(ctx, v)?,667 None => Val::Null,668 }669 }670 }671 Slice(value, desc) => {672 fn parse_idx<T: Typed>(673 loc: CallLocation<'_>,674 ctx: &Context,675 expr: Option<&LocExpr>,676 desc: &'static str,677 ) -> Result<Option<T>> {678 if let Some(value) = expr {679 Ok(Some(State::push(680 loc,681 || format!("slice {desc}"),682 || T::from_untyped(evaluate(ctx.clone(), value)?),683 )?))684 } else {685 Ok(None)686 }687 }688689 let indexable = evaluate(ctx.clone(), value)?;690 let loc = CallLocation::new(loc);691692 let start = parse_idx(loc, &ctx, desc.start.as_ref(), "start")?;693 let end = parse_idx(loc, &ctx, desc.end.as_ref(), "end")?;694 let step = parse_idx(loc, &ctx, desc.step.as_ref(), "step")?;695696 IndexableVal::into_untyped(indexable.into_indexable()?.slice(start, end, step)?)?697 }698 i @ (Import(path) | ImportStr(path) | ImportBin(path)) => {699 let Expr::Str(path) = &*path.0 else {700 bail!("computed imports are not supported")701 };702 let tmp = loc.clone().0;703 let s = ctx.state();704 let resolved_path = s.resolve_from(tmp.source_path(), path as &str)?;705 match i {706 Import(_) => State::push(707 CallLocation::new(loc),708 || format!("import {:?}", path.clone()),709 || s.import_resolved(resolved_path),710 )?,711 ImportStr(_) => Val::string(s.import_resolved_str(resolved_path)?),712 ImportBin(_) => Val::Arr(ArrValue::bytes(s.import_resolved_bin(resolved_path)?)),713 _ => unreachable!(),714 }715 }716 })717}tests/golden/issue153.jsonnetdiffbeforeafterboth--- /dev/null
+++ b/tests/golden/issue153.jsonnet
@@ -0,0 +1,9 @@
+local upper = {
+ 'bar': if 'baz' in super then super.baz else 'nope',
+};
+
+local obj = {
+ foo+: upper,
+};
+
+obj
tests/golden/issue153.jsonnet.goldendiffbeforeafterboth--- /dev/null
+++ b/tests/golden/issue153.jsonnet.golden
@@ -0,0 +1,5 @@
+{
+ "foo": {
+ "bar": "nope"
+ }
+}
\ No newline at end of file