difftreelog
build switch to released gcmodule fork
in: master
38 files changed
Cargo.lockdiffbeforeafterboth--- a/Cargo.lock
+++ b/Cargo.lock
@@ -25,9 +25,9 @@
[[package]]
name = "anyhow"
-version = "1.0.49"
+version = "1.0.57"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0a03e93e97a28fbc9f42fbc5ba0886a3c67eb637b476dbee711f80a6ffe8223d"
+checksum = "08f9b8508dccb7687a1d6c4ce66b2b0ecef467c94667de27d8d7fe1f8d2a9cdc"
[[package]]
name = "atty"
@@ -42,9 +42,9 @@
[[package]]
name = "autocfg"
-version = "1.0.1"
+version = "1.1.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "cdb031dd78e28731d87d56cc8ffef4a8f36ca26c38fe2de700543e627f8a464a"
+checksum = "d468802bab17cbc0cc575e9b053f41e72aa36bfa6b7f55e3529ffa43161b97fa"
[[package]]
name = "base64"
@@ -69,9 +69,9 @@
[[package]]
name = "cc"
-version = "1.0.72"
+version = "1.0.73"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "22a9137b95ea06864e018375b72adfb7db6e6f68cfc8df5a04d00288050485ee"
+checksum = "2fff2a6927b3bb87f9595d67196a70493f627687a71d87a0d692242c33f58c11"
[[package]]
name = "cfg-if"
@@ -87,9 +87,9 @@
[[package]]
name = "clap"
-version = "3.1.13"
+version = "3.1.18"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c4b3ee449efa0c4f95cd48b00539829d3655a98e189a90617246492788d22404"
+checksum = "d2dbdf4bdacb33466e854ce889eee8dfd5729abf7ccd7664d0a2d60cd384440b"
dependencies = [
"atty",
"bitflags",
@@ -104,18 +104,18 @@
[[package]]
name = "clap_complete"
-version = "3.1.3"
+version = "3.1.4"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1d7ca9141e27e6ebc52e3c378b0c07f3cea52db46ed1cc5861735fb697b56356"
+checksum = "da92e6facd8d73c22745a5d3cbb59bdf8e46e3235c923e516527d8e81eec14a4"
dependencies = [
"clap",
]
[[package]]
name = "clap_derive"
-version = "3.1.7"
+version = "3.1.18"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a3aab4734e083b809aaf5794e14e756d1c798d2c69c7f7de7a09a2f5214993c1"
+checksum = "25320346e922cffe59c0bbc5410c8d8784509efb321488971081313cb1e1a33c"
dependencies = [
"heck",
"proc-macro-error",
@@ -147,26 +147,6 @@
version = "0.4.8"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "56899898ce76aaf4a0f24d914c97ea6ed976d42fec6ad33fcbb0a1103e07b2b0"
-
-[[package]]
-name = "gcmodule"
-version = "0.3.3"
-source = "git+https://github.com/CertainLach/gcmodule?branch=jrsonnet#f72713c24c2b1bf5a78f1d01bee5a0f52bc2a094"
-dependencies = [
- "gcmodule_derive",
- "parking_lot",
-]
-
-[[package]]
-name = "gcmodule_derive"
-version = "0.3.3"
-source = "git+https://github.com/CertainLach/gcmodule?branch=jrsonnet#f72713c24c2b1bf5a78f1d01bee5a0f52bc2a094"
-dependencies = [
- "proc-macro2",
- "quote",
- "syn",
- "synstructure",
-]
[[package]]
name = "getrandom"
@@ -211,9 +191,9 @@
[[package]]
name = "indexmap"
-version = "1.7.0"
+version = "1.8.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "bc633605454125dec4b66843673f01c7df2b89479b32e0ed634e43a91cff62a5"
+checksum = "e6012d540c5baa3589337a98ce73408de9b5a25ec9fc2c6fd6be8f0d39e0ca5a"
dependencies = [
"autocfg",
"hashbrown 0.11.2",
@@ -221,9 +201,9 @@
[[package]]
name = "itoa"
-version = "0.4.8"
+version = "1.0.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b71991ff56294aa922b450139ee08b3bfc70982c6b2c7562771375cf73542dd4"
+checksum = "112c678d4050afce233f4f2852bb2eb519230b3cf12f33585275537d7e41578d"
[[package]]
name = "jrsonnet"
@@ -231,9 +211,9 @@
dependencies = [
"clap",
"clap_complete",
- "gcmodule",
"jrsonnet-cli",
"jrsonnet-evaluator",
+ "jrsonnet-gcmodule",
"jrsonnet-parser",
"mimallocator",
"thiserror",
@@ -244,8 +224,8 @@
version = "0.4.2"
dependencies = [
"clap",
- "gcmodule",
"jrsonnet-evaluator",
+ "jrsonnet-gcmodule",
"jrsonnet-parser",
]
@@ -257,8 +237,8 @@
"anyhow",
"base64",
"bincode",
- "gcmodule",
"hashbrown 0.12.1",
+ "jrsonnet-gcmodule",
"jrsonnet-interner",
"jrsonnet-macros",
"jrsonnet-parser",
@@ -276,11 +256,32 @@
]
[[package]]
+name = "jrsonnet-gcmodule"
+version = "0.3.4"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "22d4e1572e4b61e4f5deb3701312a330df0e69b48805a540d740e5e53ac8c78a"
+dependencies = [
+ "jrsonnet-gcmodule-derive",
+ "parking_lot",
+]
+
+[[package]]
+name = "jrsonnet-gcmodule-derive"
+version = "0.3.4"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "ae2f3bf7d38e0a9098b5b9062a7d9e7a97a206bc3c91118d76e7e37f2e0f1202"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn",
+]
+
+[[package]]
name = "jrsonnet-interner"
version = "0.4.2"
dependencies = [
- "gcmodule",
"hashbrown 0.12.1",
+ "jrsonnet-gcmodule",
"rustc-hash",
"serde",
]
@@ -298,7 +299,7 @@
name = "jrsonnet-parser"
version = "0.4.2"
dependencies = [
- "gcmodule",
+ "jrsonnet-gcmodule",
"jrsonnet-interner",
"jrsonnet-stdlib",
"peg",
@@ -314,7 +315,7 @@
name = "jrsonnet-types"
version = "0.4.2"
dependencies = [
- "gcmodule",
+ "jrsonnet-gcmodule",
"peg",
]
@@ -322,8 +323,8 @@
name = "jsonnet"
version = "0.4.2"
dependencies = [
- "gcmodule",
"jrsonnet-evaluator",
+ "jrsonnet-gcmodule",
"jrsonnet-parser",
]
@@ -335,9 +336,9 @@
[[package]]
name = "libc"
-version = "0.2.125"
+version = "0.2.126"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5916d2ae698f6de9bfb891ad7a8d65c09d232dc58cc4ac433c7da3b2fd84bc2b"
+checksum = "349d5a591cd28b49e1d1037471617a32ddcda5731b99419008085f72d5a53836"
[[package]]
name = "linked-hash-map"
@@ -381,15 +382,15 @@
[[package]]
name = "once_cell"
-version = "1.10.0"
+version = "1.12.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "87f3e037eac156d1775da914196f0f37741a274155e34a0b7e427c35d2a2ecb9"
+checksum = "7709cef83f0c1f58f666e746a08b21e0085f7440fa6a29cc194d68aac97a4225"
[[package]]
name = "os_str_bytes"
-version = "6.0.0"
+version = "6.1.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8e22443d1643a904602595ba1cd8f7d896afe56d26712531c5ff73a15b2fbf64"
+checksum = "21326818e99cfe6ce1e524c2a805c189a99b5ae555a35d19f9a284b427d86afa"
[[package]]
name = "parking_lot"
@@ -474,18 +475,18 @@
[[package]]
name = "proc-macro2"
-version = "1.0.32"
+version = "1.0.39"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ba508cc11742c0dc5c1659771673afbab7a0efab23aa17e854cbab0837ed0b43"
+checksum = "c54b25569025b7fc9651de43004ae593a75ad88543b17178aa5e1b9c4f15f56f"
dependencies = [
- "unicode-xid",
+ "unicode-ident",
]
[[package]]
name = "quote"
-version = "1.0.10"
+version = "1.0.18"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "38bc8cc6a5f2e3655e0899c1b848643b2562f853f114bfec7be120678e3ace05"
+checksum = "a1feb54ed693b93a84e14094943b84b7c4eae204c512b7ccb95ab0c66d278ad1"
dependencies = [
"proc-macro2",
]
@@ -504,9 +505,9 @@
[[package]]
name = "ryu"
-version = "1.0.5"
+version = "1.0.10"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "71d301d4193d031abdd79ff7e3dd721168a9572ef3fe51a1517aba235bd8f86e"
+checksum = "f3f6f92acf49d1b98f7a81226834412ada05458b7364277387724a237f062695"
[[package]]
name = "scopeguard"
@@ -516,18 +517,18 @@
[[package]]
name = "serde"
-version = "1.0.130"
+version = "1.0.137"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f12d06de37cf59146fbdecab66aa99f9fe4f78722e3607577a5375d66bd0c913"
+checksum = "61ea8d54c77f8315140a05f4c7237403bf38b72704d031543aa1d16abbf517d1"
dependencies = [
"serde_derive",
]
[[package]]
name = "serde_derive"
-version = "1.0.130"
+version = "1.0.137"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d7bc1a1ab1961464eae040d96713baa5a724a8152c1222492465b54322ec508b"
+checksum = "1f26faba0c3959972377d3b2d306ee9f71faee9714294e41bb777f83f88578be"
dependencies = [
"proc-macro2",
"quote",
@@ -536,9 +537,9 @@
[[package]]
name = "serde_json"
-version = "1.0.72"
+version = "1.0.81"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d0ffa0837f2dfa6fb90868c2b5468cad482e175f7dad97e7421951e663f2b527"
+checksum = "9b7ce2b32a1aed03c558dc61a5cd328f15aff2dbc17daad8fb8af04d2100e15c"
dependencies = [
"indexmap",
"itoa",
@@ -559,9 +560,9 @@
[[package]]
name = "smallvec"
-version = "1.7.0"
+version = "1.8.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1ecab6c735a6bb4139c0caafd0cc3635748bbb3acf4550e8138122099251f309"
+checksum = "f2dd574626839106c320a323308629dcb1acfc96e32a8cba364ddc61ac23ee83"
[[package]]
name = "static_assertions"
@@ -577,32 +578,20 @@
[[package]]
name = "syn"
-version = "1.0.82"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8daf5dd0bb60cbd4137b1b587d2fc0ae729bc07cf01cd70b36a1ed5ade3b9d59"
-dependencies = [
- "proc-macro2",
- "quote",
- "unicode-xid",
-]
-
-[[package]]
-name = "synstructure"
-version = "0.12.6"
+version = "1.0.96"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f36bdaa60a83aca3921b5259d5400cbf5e90fc51931376a9bd4a0eb79aa7210f"
+checksum = "0748dd251e24453cb8717f0354206b91557e4ec8703673a4b30208f2abaf1ebf"
dependencies = [
"proc-macro2",
"quote",
- "syn",
- "unicode-xid",
+ "unicode-ident",
]
[[package]]
name = "termcolor"
-version = "1.1.2"
+version = "1.1.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2dfed899f0eb03f32ee8c6a0aabdb8a7949659e3466561fc0adf54e26d88c5f4"
+checksum = "bab24d30b911b2376f3a13cc2cd443142f0c81dda04c118693e35b3835757755"
dependencies = [
"winapi-util",
]
@@ -615,18 +604,18 @@
[[package]]
name = "thiserror"
-version = "1.0.30"
+version = "1.0.31"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "854babe52e4df1653706b98fcfc05843010039b406875930a70e4d9644e5c417"
+checksum = "bd829fe32373d27f76265620b5309d0340cb8550f523c1dda251d6298069069a"
dependencies = [
"thiserror-impl",
]
[[package]]
name = "thiserror-impl"
-version = "1.0.30"
+version = "1.0.31"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "aa32fd3f627f367fe16f893e2597ae3c05020f8bba2666a4e6ea73d377e5714b"
+checksum = "0396bc89e626244658bef819e22d0cc459e795a5ebe878e6ec336d1674a8d79a"
dependencies = [
"proc-macro2",
"quote",
@@ -634,22 +623,22 @@
]
[[package]]
-name = "unicode-width"
-version = "0.1.9"
+name = "unicode-ident"
+version = "1.0.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3ed742d4ea2bd1176e236172c8429aaf54486e7ac098db29ffe6529e0ce50973"
+checksum = "d22af068fba1eb5edcb4aea19d382b2a3deb4c8f9d475c589b6ada9e0fd493ee"
[[package]]
-name = "unicode-xid"
-version = "0.2.2"
+name = "unicode-width"
+version = "0.1.9"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8ccb82d61f80a663efe1f787a51b16b5a51e3314d6ac365b08639f52387b33f3"
+checksum = "3ed742d4ea2bd1176e236172c8429aaf54486e7ac098db29ffe6529e0ce50973"
[[package]]
name = "version_check"
-version = "0.9.3"
+version = "0.9.4"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5fecdca9a5291cc2b8dcf7dc02453fee791a280f3743cb0905f8822ae463b3fe"
+checksum = "49874b5167b65d7193b8aba1567f5c7d93d001cafc34600cee003eda787e483f"
[[package]]
name = "wasi"
bindings/jsonnet/Cargo.tomldiffbeforeafterboth--- a/bindings/jsonnet/Cargo.toml
+++ b/bindings/jsonnet/Cargo.toml
@@ -10,7 +10,7 @@
[dependencies]
jrsonnet-evaluator = { path = "../../crates/jrsonnet-evaluator", version = "0.4.2" }
jrsonnet-parser = { path = "../../crates/jrsonnet-parser", version = "0.4.2" }
-gcmodule = { git = "https://github.com/CertainLach/gcmodule", branch = "jrsonnet" }
+jrsonnet-gcmodule = { version = "0.3.4" }
[lib]
crate-type = ["cdylib"]
bindings/jsonnet/src/native.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/native.rs
+++ b/bindings/jsonnet/src/native.rs
@@ -3,7 +3,6 @@
os::raw::{c_char, c_int},
};
-use gcmodule::Cc;
use jrsonnet_evaluator::{
error::{Error, LocError},
function::builtin::{BuiltinParam, NativeCallback, NativeCallbackHandler},
@@ -11,6 +10,7 @@
typed::Typed,
IStr, State, Val,
};
+use jrsonnet_gcmodule::Cc;
type JsonnetNativeCallback = unsafe extern "C" fn(
ctx: *const c_void,
@@ -18,11 +18,11 @@
success: *mut c_int,
) -> *mut Val;
-#[derive(gcmodule::Trace)]
+#[derive(jrsonnet_gcmodule::Trace)]
struct JsonnetNativeCallbackHandler {
- #[skip_trace]
+ #[trace(skip)]
ctx: *const c_void,
- #[skip_trace]
+ #[trace(skip)]
cb: JsonnetNativeCallback,
}
impl NativeCallbackHandler for JsonnetNativeCallbackHandler {
bindings/jsonnet/src/val_make.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/val_make.rs
+++ b/bindings/jsonnet/src/val_make.rs
@@ -5,8 +5,8 @@
os::raw::{c_char, c_double, c_int},
};
-use gcmodule::Cc;
use jrsonnet_evaluator::{val::ArrValue, ObjValue, State, Val};
+use jrsonnet_gcmodule::Cc;
/// # Safety
///
bindings/jsonnet/src/val_modify.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/val_modify.rs
+++ b/bindings/jsonnet/src/val_modify.rs
@@ -4,8 +4,8 @@
use std::{ffi::CStr, os::raw::c_char};
-use gcmodule::Cc;
use jrsonnet_evaluator::{val::ArrValue, State, Thunk, Val};
+use jrsonnet_gcmodule::Cc;
/// # Safety
///
cmds/jrsonnet/Cargo.tomldiffbeforeafterboth--- a/cmds/jrsonnet/Cargo.toml
+++ b/cmds/jrsonnet/Cargo.toml
@@ -23,8 +23,9 @@
jrsonnet-evaluator = { path = "../../crates/jrsonnet-evaluator", version = "0.4.2" }
jrsonnet-parser = { path = "../../crates/jrsonnet-parser", version = "0.4.2" }
jrsonnet-cli = { path = "../../crates/jrsonnet-cli", version = "0.4.2" }
+jrsonnet-gcmodule = { version = "0.3.4" }
+
mimallocator = { version = "0.1.3", optional = true }
thiserror = "1.0"
-gcmodule = { git = "https://github.com/CertainLach/gcmodule", branch = "jrsonnet" }
clap = { version = "3.1", features = ["derive"] }
clap_complete = { version = "3.1" }
cmds/jrsonnet/src/main.rsdiffbeforeafterboth--- a/cmds/jrsonnet/src/main.rs
+++ b/cmds/jrsonnet/src/main.rs
@@ -115,7 +115,6 @@
}
fn main_real(s: &State, opts: Opts) -> Result<(), Error> {
- opts.gc.configure_global();
opts.general.configure(s)?;
opts.manifest.configure(s)?;
crates/jrsonnet-cli/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-cli/Cargo.toml
+++ b/crates/jrsonnet-cli/Cargo.toml
@@ -14,6 +14,6 @@
"explaining-traces",
] }
jrsonnet-parser = { path = "../../crates/jrsonnet-parser", version = "0.4.2" }
-gcmodule = { git = "https://github.com/CertainLach/gcmodule", branch = "jrsonnet" }
+jrsonnet-gcmodule = { version = "0.3.4" }
clap = { version = "3.1", features = ["derive"] }
crates/jrsonnet-cli/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-cli/src/lib.rs
+++ b/crates/jrsonnet-cli/src/lib.rs
@@ -8,6 +8,7 @@
use clap::Parser;
pub use ext::*;
use jrsonnet_evaluator::{error::Result, FileImportResolver, State};
+use jrsonnet_gcmodule::with_thread_object_space;
pub use manifest::*;
pub use tla::*;
pub use trace::*;
@@ -111,15 +112,21 @@
gc_collect_before_printing_stats: bool,
}
impl GcOpts {
- pub fn configure_global(&self) {
- if !self.gc_collect_on_exit {
- gcmodule::set_thread_collect_on_drop(false)
- }
+ pub fn stats_printer(&self) -> (Option<GcStatsPrinter>, Option<LeakSpace>) {
+ (
+ self.gc_print_stats.then(|| GcStatsPrinter {
+ collect_before_printing_stats: self.gc_collect_before_printing_stats,
+ }),
+ (!self.gc_collect_on_exit).then(|| LeakSpace {}),
+ )
}
- pub fn stats_printer(&self) -> Option<GcStatsPrinter> {
- self.gc_print_stats.then(|| GcStatsPrinter {
- collect_before_printing_stats: self.gc_collect_before_printing_stats,
- })
+}
+
+pub struct LeakSpace {}
+
+impl Drop for LeakSpace {
+ fn drop(&mut self) {
+ with_thread_object_space(|s| s.leak())
}
}
@@ -130,9 +137,9 @@
fn drop(&mut self) {
eprintln!("=== GC STATS ===");
if self.collect_before_printing_stats {
- let collected = gcmodule::collect_thread_cycles();
+ let collected = jrsonnet_gcmodule::collect_thread_cycles();
eprintln!("Collected: {}", collected);
}
- eprintln!("Tracked: {}", gcmodule::count_thread_tracked())
+ eprintln!("Tracked: {}", jrsonnet_gcmodule::count_thread_tracked())
}
}
crates/jrsonnet-evaluator/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-evaluator/Cargo.toml
+++ b/crates/jrsonnet-evaluator/Cargo.toml
@@ -30,6 +30,8 @@
jrsonnet-stdlib = { path = "../jrsonnet-stdlib", version = "0.4.2" }
jrsonnet-types = { path = "../jrsonnet-types", version = "0.4.2" }
jrsonnet-macros = { path = "../jrsonnet-macros", version = "0.4.2" }
+jrsonnet-gcmodule = { version = "0.3.4" }
+
pathdiff = "0.2.1"
hashbrown = "0.12.1"
static_assertions = "1.1.0"
@@ -39,7 +41,6 @@
rustc-hash = "1.1"
thiserror = "1.0"
-gcmodule = { git = "https://github.com/CertainLach/gcmodule", branch = "jrsonnet" }
serde = "1.0"
serde_json = "1.0"
crates/jrsonnet-evaluator/src/ctx.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/ctx.rs
+++ b/crates/jrsonnet-evaluator/src/ctx.rs
@@ -1,11 +1,10 @@
use std::fmt::Debug;
-use gcmodule::{Cc, Trace};
+use jrsonnet_gcmodule::{Cc, Trace};
use jrsonnet_interner::IStr;
use crate::{
- cc_ptr_eq, error::Error::*, gc::GcHashMap, map::LayeredHashMap, ObjValue, Pending, Result,
- Thunk, Val,
+ error::Error::*, gc::GcHashMap, map::LayeredHashMap, ObjValue, Pending, Result, Thunk, Val,
};
#[derive(Trace)]
@@ -136,6 +135,6 @@
impl PartialEq for Context {
fn eq(&self, other: &Self) -> bool {
- cc_ptr_eq(&self.0, &other.0)
+ Cc::ptr_eq(&self.0, &other.0)
}
}
crates/jrsonnet-evaluator/src/dynamic.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/dynamic.rs
+++ b/crates/jrsonnet-evaluator/src/dynamic.rs
@@ -1,6 +1,6 @@
use std::cell::RefCell;
-use gcmodule::{Cc, Trace};
+use jrsonnet_gcmodule::{Cc, Trace};
#[derive(Clone, Trace)]
pub struct Pending<V: Trace + 'static>(pub Cc<RefCell<Option<V>>>);
crates/jrsonnet-evaluator/src/error.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/error.rs
+++ b/crates/jrsonnet-evaluator/src/error.rs
@@ -1,6 +1,6 @@
use std::{fmt::Debug, path::PathBuf};
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
use jrsonnet_interner::IStr;
use jrsonnet_parser::{BinaryOpType, ExprLocation, Source, UnaryOpType};
use jrsonnet_types::ValType;
@@ -125,7 +125,7 @@
ImportSyntaxError {
path: Source,
source_code: IStr,
- #[skip_trace]
+ #[trace(skip)]
error: Box<jrsonnet_parser::ParseError>,
},
crates/jrsonnet-evaluator/src/evaluate/destructure.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate/destructure.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/destructure.rs
@@ -1,4 +1,4 @@
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
use jrsonnet_interner::IStr;
use jrsonnet_parser::{BindSpec, Destruct, LocExpr, ParamsDesc};
crates/jrsonnet-evaluator/src/evaluate/mod.rsdiffbeforeafterboth1use std::{cmp::Ordering, rc::Rc};23use gcmodule::{Cc, Trace};4use jrsonnet_interner::IStr;5use jrsonnet_parser::{6 ArgsDesc, AssertStmt, BindSpec, CompSpec, Expr, FieldMember, FieldName, ForSpecData,7 IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc,8};9use jrsonnet_types::ValType;1011use crate::{12 destructure::evaluate_dest,13 error::Error::*,14 evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},15 function::{CallLocation, FuncDesc, FuncVal},16 stdlib::{std_slice, BUILTINS},17 tb, throw,18 typed::Typed,19 val::{ArrValue, CachedUnbound, Thunk, ThunkValue},20 Context, GcHashMap, ObjValue, ObjValueBuilder, ObjectAssertion, Pending, Result, State,21 Unbound, Val,22};23pub mod destructure;24pub mod operator;2526pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {27 Val::Func(FuncVal::Normal(Cc::new(FuncDesc {28 name,29 ctx,30 params,31 body,32 })))33}3435pub fn evaluate_field_name(s: State, ctx: Context, field_name: &FieldName) -> Result<Option<IStr>> {36 Ok(match field_name {37 FieldName::Fixed(n) => Some(n.clone()),38 FieldName::Dyn(expr) => s.push(39 CallLocation::new(&expr.1),40 || "evaluating field name".to_string(),41 || {42 let value = evaluate(s.clone(), ctx, expr)?;43 if matches!(value, Val::Null) {44 Ok(None)45 } else {46 Ok(Some(IStr::from_untyped(value, s.clone())?))47 }48 },49 )?,50 })51}5253pub fn evaluate_comp(54 s: State,55 ctx: Context,56 specs: &[CompSpec],57 callback: &mut impl FnMut(Context) -> Result<()>,58) -> Result<()> {59 match specs.get(0) {60 None => callback(ctx)?,61 Some(CompSpec::IfSpec(IfSpecData(cond))) => {62 if bool::from_untyped(evaluate(s.clone(), ctx.clone(), cond)?, s.clone())? {63 evaluate_comp(s, ctx, &specs[1..], callback)?;64 }65 }66 Some(CompSpec::ForSpec(ForSpecData(var, expr))) => {67 match evaluate(s.clone(), ctx.clone(), expr)? {68 Val::Arr(list) => {69 for item in list.iter(s.clone()) {70 evaluate_comp(71 s.clone(),72 ctx.clone().with_var(var.clone(), item?.clone()),73 &specs[1..],74 callback,75 )?;76 }77 }78 _ => throw!(InComprehensionCanOnlyIterateOverArray),79 }80 }81 }82 Ok(())83}8485trait CloneableUnbound<T>: Unbound<Bound = T> + Clone {}8687fn evaluate_object_locals(88 fctx: Pending<Context>,89 locals: Rc<Vec<BindSpec>>,90) -> impl CloneableUnbound<Context> {91 #[derive(Trace, Clone)]92 struct UnboundLocals {93 fctx: Pending<Context>,94 locals: Rc<Vec<BindSpec>>,95 }96 impl CloneableUnbound<Context> for UnboundLocals {}97 impl Unbound for UnboundLocals {98 type Bound = Context;99100 fn bind(101 &self,102 _s: State,103 sup: Option<ObjValue>,104 this: Option<ObjValue>,105 ) -> Result<Context> {106 let fctx = Context::new_future();107 let mut new_bindings = GcHashMap::new();108 for b in self.locals.iter() {109 evaluate_dest(b, fctx.clone(), &mut new_bindings)?;110 }111112 let ctx = self.fctx.unwrap();113 let new_dollar = ctx.dollar().clone().or_else(|| this.clone());114115 let ctx = ctx116 .extend(new_bindings, new_dollar, sup, this)117 .into_future(fctx);118119 Ok(ctx)120 }121 }122123 UnboundLocals { fctx, locals }124}125126#[allow(clippy::too_many_lines)]127pub fn evaluate_member_list_object(s: State, ctx: Context, members: &[Member]) -> Result<ObjValue> {128 let mut builder = ObjValueBuilder::new();129 let locals = Rc::new(130 members131 .iter()132 .filter_map(|m| match m {133 Member::BindStmt(bind) => Some(bind.clone()),134 _ => None,135 })136 .collect::<Vec<_>>(),137 );138139 let fctx = Context::new_future();140141 // We have single context for all fields, so we can cache binds142 let uctx = CachedUnbound::new(evaluate_object_locals(fctx.clone(), locals));143144 for member in members.iter() {145 match member {146 Member::Field(FieldMember {147 name,148 plus,149 params: None,150 visibility,151 value,152 }) => {153 #[derive(Trace)]154 struct UnboundValue<B> {155 uctx: B,156 value: LocExpr,157 name: IStr,158 }159 impl<B: Unbound<Bound = Context>> Unbound for UnboundValue<B> {160 type Bound = Thunk<Val>;161 fn bind(162 &self,163 s: State,164 sup: Option<ObjValue>,165 this: Option<ObjValue>,166 ) -> Result<Thunk<Val>> {167 Ok(Thunk::evaluated(evaluate_named(168 s.clone(),169 self.uctx.bind(s, sup, this)?,170 &self.value,171 self.name.clone(),172 )?))173 }174 }175176 let name = evaluate_field_name(s.clone(), ctx.clone(), name)?;177 let name = if let Some(name) = name {178 name179 } else {180 continue;181 };182183 builder184 .member(name.clone())185 .with_add(*plus)186 .with_visibility(*visibility)187 .with_location(value.1.clone())188 .bindable(189 s.clone(),190 tb!(UnboundValue {191 uctx: uctx.clone(),192 value: value.clone(),193 name: name.clone()194 }),195 )?;196 }197 Member::Field(FieldMember {198 name,199 params: Some(params),200 value,201 ..202 }) => {203 #[derive(Trace)]204 struct UnboundMethod<B> {205 uctx: B,206 value: LocExpr,207 params: ParamsDesc,208 name: IStr,209 }210 impl<B: Unbound<Bound = Context>> Unbound for UnboundMethod<B> {211 type Bound = Thunk<Val>;212 fn bind(213 &self,214 s: State,215 sup: Option<ObjValue>,216 this: Option<ObjValue>,217 ) -> Result<Thunk<Val>> {218 Ok(Thunk::evaluated(evaluate_method(219 self.uctx.bind(s, sup, this)?,220 self.name.clone(),221 self.params.clone(),222 self.value.clone(),223 )))224 }225 }226227 let name = if let Some(name) = evaluate_field_name(s.clone(), ctx.clone(), name)? {228 name229 } else {230 continue;231 };232233 builder234 .member(name.clone())235 .hide()236 .with_location(value.1.clone())237 .bindable(238 s.clone(),239 tb!(UnboundMethod {240 uctx: uctx.clone(),241 value: value.clone(),242 params: params.clone(),243 name: name.clone()244 }),245 )?;246 }247 Member::BindStmt(_) => {}248 Member::AssertStmt(stmt) => {249 #[derive(Trace)]250 struct ObjectAssert<B> {251 uctx: B,252 assert: AssertStmt,253 }254 impl<B: Unbound<Bound = Context>> ObjectAssertion for ObjectAssert<B> {255 fn run(256 &self,257 s: State,258 sup: Option<ObjValue>,259 this: Option<ObjValue>,260 ) -> Result<()> {261 let ctx = self.uctx.bind(s.clone(), sup, this)?;262 evaluate_assert(s, ctx, &self.assert)263 }264 }265 builder.assert(tb!(ObjectAssert {266 uctx: uctx.clone(),267 assert: stmt.clone(),268 }));269 }270 }271 }272 let this = builder.build();273 let _ctx = ctx274 .extend(GcHashMap::new(), None, None, Some(this.clone()))275 .into_future(fctx);276 Ok(this)277}278279pub fn evaluate_object(s: State, ctx: Context, object: &ObjBody) -> Result<ObjValue> {280 Ok(match object {281 ObjBody::MemberList(members) => evaluate_member_list_object(s, ctx, members)?,282 ObjBody::ObjComp(obj) => {283 let mut builder = ObjValueBuilder::new();284 let locals = Rc::new(285 obj.pre_locals286 .iter()287 .chain(obj.post_locals.iter())288 .cloned()289 .collect::<Vec<_>>(),290 );291 let mut ctxs = vec![];292 evaluate_comp(s.clone(), ctx, &obj.compspecs, &mut |ctx| {293 let key = evaluate(s.clone(), ctx.clone(), &obj.key)?;294 let fctx = Context::new_future();295 ctxs.push((ctx, fctx.clone()));296 let uctx = evaluate_object_locals(fctx, locals.clone());297298 match key {299 Val::Null => {}300 Val::Str(n) => {301 #[derive(Trace)]302 struct UnboundValue<B> {303 uctx: B,304 value: LocExpr,305 }306 impl<B: Unbound<Bound = Context>> Unbound for UnboundValue<B> {307 type Bound = Thunk<Val>;308 fn bind(309 &self,310 s: State,311 sup: Option<ObjValue>,312 this: Option<ObjValue>,313 ) -> Result<Thunk<Val>> {314 Ok(Thunk::evaluated(evaluate(315 s.clone(),316 self.uctx.bind(s, sup, this.clone())?.extend(317 GcHashMap::new(),318 None,319 None,320 this,321 ),322 &self.value,323 )?))324 }325 }326 builder327 .member(n)328 .with_location(obj.value.1.clone())329 .with_add(obj.plus)330 .bindable(331 s.clone(),332 tb!(UnboundValue {333 uctx,334 value: obj.value.clone(),335 }),336 )?;337 }338 v => throw!(FieldMustBeStringGot(v.value_type())),339 }340341 Ok(())342 })?;343344 let this = builder.build();345 for (ctx, fctx) in ctxs {346 let _ctx = ctx347 .extend(GcHashMap::new(), None, None, Some(this.clone()))348 .into_future(fctx);349 }350 this351 }352 })353}354355pub fn evaluate_apply(356 s: State,357 ctx: Context,358 value: &LocExpr,359 args: &ArgsDesc,360 loc: CallLocation,361 tailstrict: bool,362) -> Result<Val> {363 let value = evaluate(s.clone(), ctx.clone(), value)?;364 Ok(match value {365 Val::Func(f) => {366 let body = || f.evaluate(s.clone(), ctx, loc, args, tailstrict);367 if tailstrict {368 body()?369 } else {370 s.push(loc, || format!("function <{}> call", f.name()), body)?371 }372 }373 v => throw!(OnlyFunctionsCanBeCalledGot(v.value_type())),374 })375}376377pub fn evaluate_assert(s: State, ctx: Context, assertion: &AssertStmt) -> Result<()> {378 let value = &assertion.0;379 let msg = &assertion.1;380 let assertion_result = s.push(381 CallLocation::new(&value.1),382 || "assertion condition".to_owned(),383 || bool::from_untyped(evaluate(s.clone(), ctx.clone(), value)?, s.clone()),384 )?;385 if !assertion_result {386 s.push(387 CallLocation::new(&value.1),388 || "assertion failure".to_owned(),389 || {390 if let Some(msg) = msg {391 throw!(AssertionFailed(392 evaluate(s.clone(), ctx, msg)?.to_string(s.clone())?393 ));394 }395 throw!(AssertionFailed(Val::Null.to_string(s.clone())?));396 },397 )?;398 }399 Ok(())400}401402pub fn evaluate_named(s: State, ctx: Context, expr: &LocExpr, name: IStr) -> Result<Val> {403 use Expr::*;404 let LocExpr(raw_expr, _loc) = expr;405 Ok(match &**raw_expr {406 Function(params, body) => evaluate_method(ctx, name, params.clone(), body.clone()),407 _ => evaluate(s, ctx, expr)?,408 })409}410411#[allow(clippy::too_many_lines)]412pub fn evaluate(s: State, ctx: Context, expr: &LocExpr) -> Result<Val> {413 use Expr::*;414 let LocExpr(expr, loc) = expr;415 // let bp = with_state(|s| s.0.stop_at.borrow().clone());416 Ok(match &**expr {417 Literal(LiteralType::This) => {418 Val::Obj(ctx.this().clone().ok_or(CantUseSelfOutsideOfObject)?)419 }420 Literal(LiteralType::Super) => Val::Obj(421 ctx.super_obj().clone().ok_or(NoSuperFound)?.with_this(422 ctx.this()423 .clone()424 .expect("if super exists - then this should to"),425 ),426 ),427 Literal(LiteralType::Dollar) => {428 Val::Obj(ctx.dollar().clone().ok_or(NoTopLevelObjectFound)?)429 }430 Literal(LiteralType::True) => Val::Bool(true),431 Literal(LiteralType::False) => Val::Bool(false),432 Literal(LiteralType::Null) => Val::Null,433 Parened(e) => evaluate(s, ctx, e)?,434 Str(v) => Val::Str(v.clone()),435 Num(v) => Val::new_checked_num(*v)?,436 BinaryOp(v1, o, v2) => evaluate_binary_op_special(s, ctx, v1, *o, v2)?,437 UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(s, ctx, v)?)?,438 Var(name) => s.push(439 CallLocation::new(loc),440 || format!("variable <{}> access", name),441 || ctx.binding(name.clone())?.evaluate(s.clone()),442 )?,443 Index(value, index) => {444 match (445 evaluate(s.clone(), ctx.clone(), value)?,446 evaluate(s.clone(), ctx, index)?,447 ) {448 (Val::Obj(v), Val::Str(key)) => s.push(449 CallLocation::new(loc),450 || format!("field <{}> access", key),451 || match v.get(s.clone(), key.clone()) {452 Ok(Some(v)) => Ok(v),453 #[cfg(not(feature = "friendly-errors"))]454 Ok(None) => throw!(NoSuchField(key.clone(), vec![])),455 #[cfg(feature = "friendly-errors")]456 Ok(None) => {457 let mut heap = Vec::new();458 for field in v.fields_ex(459 true,460 #[cfg(feature = "exp-preserve-order")]461 false,462 ) {463 let conf = strsim::jaro_winkler(&field as &str, &key as &str);464 if conf < 0.8 {465 continue;466 }467 heap.push((conf, field));468 }469 heap.sort_by(|a, b| b.0.partial_cmp(&a.0).unwrap_or(Ordering::Equal));470471 throw!(NoSuchField(472 key.clone(),473 heap.into_iter().map(|(_, v)| v).collect()474 ))475 }476 Err(e) if matches!(e.error(), MagicThisFileUsed) => {477 Ok(Val::Str(loc.0.full_path().into()))478 }479 Err(e) => Err(e),480 },481 )?,482 (Val::Obj(_), n) => throw!(ValueIndexMustBeTypeGot(483 ValType::Obj,484 ValType::Str,485 n.value_type(),486 )),487488 (Val::Arr(v), Val::Num(n)) => {489 if n.fract() > f64::EPSILON {490 throw!(FractionalIndex)491 }492 v.get(s, n as usize)?493 .ok_or_else(|| ArrayBoundsError(n as usize, v.len()))?494 }495 (Val::Arr(_), Val::Str(n)) => throw!(AttemptedIndexAnArrayWithString(n)),496 (Val::Arr(_), n) => throw!(ValueIndexMustBeTypeGot(497 ValType::Arr,498 ValType::Num,499 n.value_type(),500 )),501502 (Val::Str(s), Val::Num(n)) => Val::Str({503 let v: IStr = s504 .chars()505 .skip(n as usize)506 .take(1)507 .collect::<String>()508 .into();509 if v.is_empty() {510 let size = s.chars().count();511 throw!(StringBoundsError(n as usize, size))512 }513 v514 }),515 (Val::Str(_), n) => throw!(ValueIndexMustBeTypeGot(516 ValType::Str,517 ValType::Num,518 n.value_type(),519 )),520521 (v, _) => throw!(CantIndexInto(v.value_type())),522 }523 }524 LocalExpr(bindings, returned) => {525 let mut new_bindings: GcHashMap<IStr, Thunk<Val>> =526 GcHashMap::with_capacity(bindings.len());527 let fctx = Context::new_future();528 for b in bindings {529 evaluate_dest(b, fctx.clone(), &mut new_bindings)?;530 }531 let ctx = ctx.extend(new_bindings, None, None, None).into_future(fctx);532 evaluate(s, ctx, &returned.clone())?533 }534 Arr(items) => {535 let mut out = Vec::with_capacity(items.len());536 for item in items {537 // TODO: Implement ArrValue::Lazy with same context for every element?538 #[derive(Trace)]539 struct ArrayElement {540 ctx: Context,541 item: LocExpr,542 }543 impl ThunkValue for ArrayElement {544 type Output = Val;545 fn get(self: Box<Self>, s: State) -> Result<Val> {546 evaluate(s, self.ctx, &self.item)547 }548 }549 out.push(Thunk::new(tb!(ArrayElement {550 ctx: ctx.clone(),551 item: item.clone(),552 })));553 }554 Val::Arr(out.into())555 }556 ArrComp(expr, comp_specs) => {557 let mut out = Vec::new();558 evaluate_comp(s.clone(), ctx, comp_specs, &mut |ctx| {559 out.push(evaluate(s.clone(), ctx, expr)?);560 Ok(())561 })?;562 Val::Arr(ArrValue::Eager(Cc::new(out)))563 }564 Obj(body) => Val::Obj(evaluate_object(s, ctx, body)?),565 ObjExtend(a, b) => evaluate_add_op(566 s.clone(),567 &evaluate(s.clone(), ctx.clone(), a)?,568 &Val::Obj(evaluate_object(s, ctx, b)?),569 )?,570 Apply(value, args, tailstrict) => {571 evaluate_apply(s, ctx, value, args, CallLocation::new(loc), *tailstrict)?572 }573 Function(params, body) => {574 evaluate_method(ctx, "anonymous".into(), params.clone(), body.clone())575 }576 Intrinsic(name) => Val::Func(FuncVal::StaticBuiltin(577 BUILTINS578 .with(|b| b.get(name).copied())579 .ok_or_else(|| IntrinsicNotFound(name.clone()))?,580 )),581 IntrinsicThisFile => return Err(MagicThisFileUsed.into()),582 IntrinsicId => Val::Func(FuncVal::identity()),583 AssertExpr(assert, returned) => {584 evaluate_assert(s.clone(), ctx.clone(), assert)?;585 evaluate(s, ctx, returned)?586 }587 ErrorStmt(e) => s.push(588 CallLocation::new(loc),589 || "error statement".to_owned(),590 || {591 throw!(RuntimeError(592 evaluate(s.clone(), ctx, e)?.to_string(s.clone())?,593 ))594 },595 )?,596 IfElse {597 cond,598 cond_then,599 cond_else,600 } => {601 if s.push(602 CallLocation::new(loc),603 || "if condition".to_owned(),604 || bool::from_untyped(evaluate(s.clone(), ctx.clone(), &cond.0)?, s.clone()),605 )? {606 evaluate(s, ctx, cond_then)?607 } else {608 match cond_else {609 Some(v) => evaluate(s, ctx, v)?,610 None => Val::Null,611 }612 }613 }614 Slice(value, desc) => {615 fn parse_idx<T: Typed>(616 loc: CallLocation,617 s: State,618 ctx: &Context,619 expr: &Option<LocExpr>,620 desc: &'static str,621 ) -> Result<Option<T>> {622 if let Some(value) = expr {623 Ok(Some(s.push(624 loc,625 || format!("slice {}", desc),626 || T::from_untyped(evaluate(s.clone(), ctx.clone(), value)?, s.clone()),627 )?))628 } else {629 Ok(None)630 }631 }632633 let indexable = evaluate(s.clone(), ctx.clone(), value)?;634 let loc = CallLocation::new(loc);635636 let start = parse_idx(loc, s.clone(), &ctx, &desc.start, "start")?;637 let end = parse_idx(loc, s.clone(), &ctx, &desc.end, "end")?;638 let step = parse_idx(loc, s, &ctx, &desc.step, "step")?;639640 std_slice(indexable.into_indexable()?, start, end, step)?641 }642 i @ (Import(path) | ImportStr(path) | ImportBin(path)) => {643 let tmp = loc.clone().0;644 let import_location = tmp645 .path()646 .map(|p| {647 let mut p = p.to_owned();648 p.pop();649 p650 })651 .unwrap_or_default();652 let resolved_path = s.resolve_file(&import_location, path as &str)?;653 match i {654 Import(_) => s.push(655 CallLocation::new(loc),656 || format!("import {:?}", path.clone()),657 || s.import(resolved_path.clone()),658 )?,659 ImportStr(_) => Val::Str(s.import_str(resolved_path)?),660 ImportBin(_) => Val::Arr(ArrValue::Bytes(s.import_bin(resolved_path)?)),661 _ => unreachable!(),662 }663 }664 })665}1use std::{cmp::Ordering, rc::Rc};23use jrsonnet_gcmodule::{Cc, Trace};4use jrsonnet_interner::IStr;5use jrsonnet_parser::{6 ArgsDesc, AssertStmt, BindSpec, CompSpec, Expr, FieldMember, FieldName, ForSpecData,7 IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc,8};9use jrsonnet_types::ValType;1011use crate::{12 destructure::evaluate_dest,13 error::Error::*,14 evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},15 function::{CallLocation, FuncDesc, FuncVal},16 stdlib::{std_slice, BUILTINS},17 tb, throw,18 typed::Typed,19 val::{ArrValue, CachedUnbound, Thunk, ThunkValue},20 Context, GcHashMap, ObjValue, ObjValueBuilder, ObjectAssertion, Pending, Result, State,21 Unbound, Val,22};23pub mod destructure;24pub mod operator;2526pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {27 Val::Func(FuncVal::Normal(Cc::new(FuncDesc {28 name,29 ctx,30 params,31 body,32 })))33}3435pub fn evaluate_field_name(s: State, ctx: Context, field_name: &FieldName) -> Result<Option<IStr>> {36 Ok(match field_name {37 FieldName::Fixed(n) => Some(n.clone()),38 FieldName::Dyn(expr) => s.push(39 CallLocation::new(&expr.1),40 || "evaluating field name".to_string(),41 || {42 let value = evaluate(s.clone(), ctx, expr)?;43 if matches!(value, Val::Null) {44 Ok(None)45 } else {46 Ok(Some(IStr::from_untyped(value, s.clone())?))47 }48 },49 )?,50 })51}5253pub fn evaluate_comp(54 s: State,55 ctx: Context,56 specs: &[CompSpec],57 callback: &mut impl FnMut(Context) -> Result<()>,58) -> Result<()> {59 match specs.get(0) {60 None => callback(ctx)?,61 Some(CompSpec::IfSpec(IfSpecData(cond))) => {62 if bool::from_untyped(evaluate(s.clone(), ctx.clone(), cond)?, s.clone())? {63 evaluate_comp(s, ctx, &specs[1..], callback)?;64 }65 }66 Some(CompSpec::ForSpec(ForSpecData(var, expr))) => {67 match evaluate(s.clone(), ctx.clone(), expr)? {68 Val::Arr(list) => {69 for item in list.iter(s.clone()) {70 evaluate_comp(71 s.clone(),72 ctx.clone().with_var(var.clone(), item?.clone()),73 &specs[1..],74 callback,75 )?;76 }77 }78 _ => throw!(InComprehensionCanOnlyIterateOverArray),79 }80 }81 }82 Ok(())83}8485trait CloneableUnbound<T>: Unbound<Bound = T> + Clone {}8687fn evaluate_object_locals(88 fctx: Pending<Context>,89 locals: Rc<Vec<BindSpec>>,90) -> impl CloneableUnbound<Context> {91 #[derive(Trace, Clone)]92 struct UnboundLocals {93 fctx: Pending<Context>,94 locals: Rc<Vec<BindSpec>>,95 }96 impl CloneableUnbound<Context> for UnboundLocals {}97 impl Unbound for UnboundLocals {98 type Bound = Context;99100 fn bind(101 &self,102 _s: State,103 sup: Option<ObjValue>,104 this: Option<ObjValue>,105 ) -> Result<Context> {106 let fctx = Context::new_future();107 let mut new_bindings = GcHashMap::new();108 for b in self.locals.iter() {109 evaluate_dest(b, fctx.clone(), &mut new_bindings)?;110 }111112 let ctx = self.fctx.unwrap();113 let new_dollar = ctx.dollar().clone().or_else(|| this.clone());114115 let ctx = ctx116 .extend(new_bindings, new_dollar, sup, this)117 .into_future(fctx);118119 Ok(ctx)120 }121 }122123 UnboundLocals { fctx, locals }124}125126#[allow(clippy::too_many_lines)]127pub fn evaluate_member_list_object(s: State, ctx: Context, members: &[Member]) -> Result<ObjValue> {128 let mut builder = ObjValueBuilder::new();129 let locals = Rc::new(130 members131 .iter()132 .filter_map(|m| match m {133 Member::BindStmt(bind) => Some(bind.clone()),134 _ => None,135 })136 .collect::<Vec<_>>(),137 );138139 let fctx = Context::new_future();140141 // We have single context for all fields, so we can cache binds142 let uctx = CachedUnbound::new(evaluate_object_locals(fctx.clone(), locals));143144 for member in members.iter() {145 match member {146 Member::Field(FieldMember {147 name,148 plus,149 params: None,150 visibility,151 value,152 }) => {153 #[derive(Trace)]154 struct UnboundValue<B: Trace> {155 uctx: B,156 value: LocExpr,157 name: IStr,158 }159 impl<B: Unbound<Bound = Context>> Unbound for UnboundValue<B> {160 type Bound = Thunk<Val>;161 fn bind(162 &self,163 s: State,164 sup: Option<ObjValue>,165 this: Option<ObjValue>,166 ) -> Result<Thunk<Val>> {167 Ok(Thunk::evaluated(evaluate_named(168 s.clone(),169 self.uctx.bind(s, sup, this)?,170 &self.value,171 self.name.clone(),172 )?))173 }174 }175176 let name = evaluate_field_name(s.clone(), ctx.clone(), name)?;177 let name = if let Some(name) = name {178 name179 } else {180 continue;181 };182183 builder184 .member(name.clone())185 .with_add(*plus)186 .with_visibility(*visibility)187 .with_location(value.1.clone())188 .bindable(189 s.clone(),190 tb!(UnboundValue {191 uctx: uctx.clone(),192 value: value.clone(),193 name: name.clone()194 }),195 )?;196 }197 Member::Field(FieldMember {198 name,199 params: Some(params),200 value,201 ..202 }) => {203 #[derive(Trace)]204 struct UnboundMethod<B: Trace> {205 uctx: B,206 value: LocExpr,207 params: ParamsDesc,208 name: IStr,209 }210 impl<B: Unbound<Bound = Context>> Unbound for UnboundMethod<B> {211 type Bound = Thunk<Val>;212 fn bind(213 &self,214 s: State,215 sup: Option<ObjValue>,216 this: Option<ObjValue>,217 ) -> Result<Thunk<Val>> {218 Ok(Thunk::evaluated(evaluate_method(219 self.uctx.bind(s, sup, this)?,220 self.name.clone(),221 self.params.clone(),222 self.value.clone(),223 )))224 }225 }226227 let name = if let Some(name) = evaluate_field_name(s.clone(), ctx.clone(), name)? {228 name229 } else {230 continue;231 };232233 builder234 .member(name.clone())235 .hide()236 .with_location(value.1.clone())237 .bindable(238 s.clone(),239 tb!(UnboundMethod {240 uctx: uctx.clone(),241 value: value.clone(),242 params: params.clone(),243 name: name.clone()244 }),245 )?;246 }247 Member::BindStmt(_) => {}248 Member::AssertStmt(stmt) => {249 #[derive(Trace)]250 struct ObjectAssert<B: Trace> {251 uctx: B,252 assert: AssertStmt,253 }254 impl<B: Unbound<Bound = Context>> ObjectAssertion for ObjectAssert<B> {255 fn run(256 &self,257 s: State,258 sup: Option<ObjValue>,259 this: Option<ObjValue>,260 ) -> Result<()> {261 let ctx = self.uctx.bind(s.clone(), sup, this)?;262 evaluate_assert(s, ctx, &self.assert)263 }264 }265 builder.assert(tb!(ObjectAssert {266 uctx: uctx.clone(),267 assert: stmt.clone(),268 }));269 }270 }271 }272 let this = builder.build();273 let _ctx = ctx274 .extend(GcHashMap::new(), None, None, Some(this.clone()))275 .into_future(fctx);276 Ok(this)277}278279pub fn evaluate_object(s: State, ctx: Context, object: &ObjBody) -> Result<ObjValue> {280 Ok(match object {281 ObjBody::MemberList(members) => evaluate_member_list_object(s, ctx, members)?,282 ObjBody::ObjComp(obj) => {283 let mut builder = ObjValueBuilder::new();284 let locals = Rc::new(285 obj.pre_locals286 .iter()287 .chain(obj.post_locals.iter())288 .cloned()289 .collect::<Vec<_>>(),290 );291 let mut ctxs = vec![];292 evaluate_comp(s.clone(), ctx, &obj.compspecs, &mut |ctx| {293 let key = evaluate(s.clone(), ctx.clone(), &obj.key)?;294 let fctx = Context::new_future();295 ctxs.push((ctx, fctx.clone()));296 let uctx = evaluate_object_locals(fctx, locals.clone());297298 match key {299 Val::Null => {}300 Val::Str(n) => {301 #[derive(Trace)]302 struct UnboundValue<B: Trace> {303 uctx: B,304 value: LocExpr,305 }306 impl<B: Unbound<Bound = Context>> Unbound for UnboundValue<B> {307 type Bound = Thunk<Val>;308 fn bind(309 &self,310 s: State,311 sup: Option<ObjValue>,312 this: Option<ObjValue>,313 ) -> Result<Thunk<Val>> {314 Ok(Thunk::evaluated(evaluate(315 s.clone(),316 self.uctx.bind(s, sup, this.clone())?.extend(317 GcHashMap::new(),318 None,319 None,320 this,321 ),322 &self.value,323 )?))324 }325 }326 builder327 .member(n)328 .with_location(obj.value.1.clone())329 .with_add(obj.plus)330 .bindable(331 s.clone(),332 tb!(UnboundValue {333 uctx,334 value: obj.value.clone(),335 }),336 )?;337 }338 v => throw!(FieldMustBeStringGot(v.value_type())),339 }340341 Ok(())342 })?;343344 let this = builder.build();345 for (ctx, fctx) in ctxs {346 let _ctx = ctx347 .extend(GcHashMap::new(), None, None, Some(this.clone()))348 .into_future(fctx);349 }350 this351 }352 })353}354355pub fn evaluate_apply(356 s: State,357 ctx: Context,358 value: &LocExpr,359 args: &ArgsDesc,360 loc: CallLocation,361 tailstrict: bool,362) -> Result<Val> {363 let value = evaluate(s.clone(), ctx.clone(), value)?;364 Ok(match value {365 Val::Func(f) => {366 let body = || f.evaluate(s.clone(), ctx, loc, args, tailstrict);367 if tailstrict {368 body()?369 } else {370 s.push(loc, || format!("function <{}> call", f.name()), body)?371 }372 }373 v => throw!(OnlyFunctionsCanBeCalledGot(v.value_type())),374 })375}376377pub fn evaluate_assert(s: State, ctx: Context, assertion: &AssertStmt) -> Result<()> {378 let value = &assertion.0;379 let msg = &assertion.1;380 let assertion_result = s.push(381 CallLocation::new(&value.1),382 || "assertion condition".to_owned(),383 || bool::from_untyped(evaluate(s.clone(), ctx.clone(), value)?, s.clone()),384 )?;385 if !assertion_result {386 s.push(387 CallLocation::new(&value.1),388 || "assertion failure".to_owned(),389 || {390 if let Some(msg) = msg {391 throw!(AssertionFailed(392 evaluate(s.clone(), ctx, msg)?.to_string(s.clone())?393 ));394 }395 throw!(AssertionFailed(Val::Null.to_string(s.clone())?));396 },397 )?;398 }399 Ok(())400}401402pub fn evaluate_named(s: State, ctx: Context, expr: &LocExpr, name: IStr) -> Result<Val> {403 use Expr::*;404 let LocExpr(raw_expr, _loc) = expr;405 Ok(match &**raw_expr {406 Function(params, body) => evaluate_method(ctx, name, params.clone(), body.clone()),407 _ => evaluate(s, ctx, expr)?,408 })409}410411#[allow(clippy::too_many_lines)]412pub fn evaluate(s: State, ctx: Context, expr: &LocExpr) -> Result<Val> {413 use Expr::*;414 let LocExpr(expr, loc) = expr;415 // let bp = with_state(|s| s.0.stop_at.borrow().clone());416 Ok(match &**expr {417 Literal(LiteralType::This) => {418 Val::Obj(ctx.this().clone().ok_or(CantUseSelfOutsideOfObject)?)419 }420 Literal(LiteralType::Super) => Val::Obj(421 ctx.super_obj().clone().ok_or(NoSuperFound)?.with_this(422 ctx.this()423 .clone()424 .expect("if super exists - then this should to"),425 ),426 ),427 Literal(LiteralType::Dollar) => {428 Val::Obj(ctx.dollar().clone().ok_or(NoTopLevelObjectFound)?)429 }430 Literal(LiteralType::True) => Val::Bool(true),431 Literal(LiteralType::False) => Val::Bool(false),432 Literal(LiteralType::Null) => Val::Null,433 Parened(e) => evaluate(s, ctx, e)?,434 Str(v) => Val::Str(v.clone()),435 Num(v) => Val::new_checked_num(*v)?,436 BinaryOp(v1, o, v2) => evaluate_binary_op_special(s, ctx, v1, *o, v2)?,437 UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(s, ctx, v)?)?,438 Var(name) => s.push(439 CallLocation::new(loc),440 || format!("variable <{}> access", name),441 || ctx.binding(name.clone())?.evaluate(s.clone()),442 )?,443 Index(value, index) => {444 match (445 evaluate(s.clone(), ctx.clone(), value)?,446 evaluate(s.clone(), ctx, index)?,447 ) {448 (Val::Obj(v), Val::Str(key)) => s.push(449 CallLocation::new(loc),450 || format!("field <{}> access", key),451 || match v.get(s.clone(), key.clone()) {452 Ok(Some(v)) => Ok(v),453 #[cfg(not(feature = "friendly-errors"))]454 Ok(None) => throw!(NoSuchField(key.clone(), vec![])),455 #[cfg(feature = "friendly-errors")]456 Ok(None) => {457 let mut heap = Vec::new();458 for field in v.fields_ex(459 true,460 #[cfg(feature = "exp-preserve-order")]461 false,462 ) {463 let conf = strsim::jaro_winkler(&field as &str, &key as &str);464 if conf < 0.8 {465 continue;466 }467 heap.push((conf, field));468 }469 heap.sort_by(|a, b| b.0.partial_cmp(&a.0).unwrap_or(Ordering::Equal));470471 throw!(NoSuchField(472 key.clone(),473 heap.into_iter().map(|(_, v)| v).collect()474 ))475 }476 Err(e) if matches!(e.error(), MagicThisFileUsed) => {477 Ok(Val::Str(loc.0.full_path().into()))478 }479 Err(e) => Err(e),480 },481 )?,482 (Val::Obj(_), n) => throw!(ValueIndexMustBeTypeGot(483 ValType::Obj,484 ValType::Str,485 n.value_type(),486 )),487488 (Val::Arr(v), Val::Num(n)) => {489 if n.fract() > f64::EPSILON {490 throw!(FractionalIndex)491 }492 v.get(s, n as usize)?493 .ok_or_else(|| ArrayBoundsError(n as usize, v.len()))?494 }495 (Val::Arr(_), Val::Str(n)) => throw!(AttemptedIndexAnArrayWithString(n)),496 (Val::Arr(_), n) => throw!(ValueIndexMustBeTypeGot(497 ValType::Arr,498 ValType::Num,499 n.value_type(),500 )),501502 (Val::Str(s), Val::Num(n)) => Val::Str({503 let v: IStr = s504 .chars()505 .skip(n as usize)506 .take(1)507 .collect::<String>()508 .into();509 if v.is_empty() {510 let size = s.chars().count();511 throw!(StringBoundsError(n as usize, size))512 }513 v514 }),515 (Val::Str(_), n) => throw!(ValueIndexMustBeTypeGot(516 ValType::Str,517 ValType::Num,518 n.value_type(),519 )),520521 (v, _) => throw!(CantIndexInto(v.value_type())),522 }523 }524 LocalExpr(bindings, returned) => {525 let mut new_bindings: GcHashMap<IStr, Thunk<Val>> =526 GcHashMap::with_capacity(bindings.len());527 let fctx = Context::new_future();528 for b in bindings {529 evaluate_dest(b, fctx.clone(), &mut new_bindings)?;530 }531 let ctx = ctx.extend(new_bindings, None, None, None).into_future(fctx);532 evaluate(s, ctx, &returned.clone())?533 }534 Arr(items) => {535 let mut out = Vec::with_capacity(items.len());536 for item in items {537 // TODO: Implement ArrValue::Lazy with same context for every element?538 #[derive(Trace)]539 struct ArrayElement {540 ctx: Context,541 item: LocExpr,542 }543 impl ThunkValue for ArrayElement {544 type Output = Val;545 fn get(self: Box<Self>, s: State) -> Result<Val> {546 evaluate(s, self.ctx, &self.item)547 }548 }549 out.push(Thunk::new(tb!(ArrayElement {550 ctx: ctx.clone(),551 item: item.clone(),552 })));553 }554 Val::Arr(out.into())555 }556 ArrComp(expr, comp_specs) => {557 let mut out = Vec::new();558 evaluate_comp(s.clone(), ctx, comp_specs, &mut |ctx| {559 out.push(evaluate(s.clone(), ctx, expr)?);560 Ok(())561 })?;562 Val::Arr(ArrValue::Eager(Cc::new(out)))563 }564 Obj(body) => Val::Obj(evaluate_object(s, ctx, body)?),565 ObjExtend(a, b) => evaluate_add_op(566 s.clone(),567 &evaluate(s.clone(), ctx.clone(), a)?,568 &Val::Obj(evaluate_object(s, ctx, b)?),569 )?,570 Apply(value, args, tailstrict) => {571 evaluate_apply(s, ctx, value, args, CallLocation::new(loc), *tailstrict)?572 }573 Function(params, body) => {574 evaluate_method(ctx, "anonymous".into(), params.clone(), body.clone())575 }576 Intrinsic(name) => Val::Func(FuncVal::StaticBuiltin(577 BUILTINS578 .with(|b| b.get(name).copied())579 .ok_or_else(|| IntrinsicNotFound(name.clone()))?,580 )),581 IntrinsicThisFile => return Err(MagicThisFileUsed.into()),582 IntrinsicId => Val::Func(FuncVal::identity()),583 AssertExpr(assert, returned) => {584 evaluate_assert(s.clone(), ctx.clone(), assert)?;585 evaluate(s, ctx, returned)?586 }587 ErrorStmt(e) => s.push(588 CallLocation::new(loc),589 || "error statement".to_owned(),590 || {591 throw!(RuntimeError(592 evaluate(s.clone(), ctx, e)?.to_string(s.clone())?,593 ))594 },595 )?,596 IfElse {597 cond,598 cond_then,599 cond_else,600 } => {601 if s.push(602 CallLocation::new(loc),603 || "if condition".to_owned(),604 || bool::from_untyped(evaluate(s.clone(), ctx.clone(), &cond.0)?, s.clone()),605 )? {606 evaluate(s, ctx, cond_then)?607 } else {608 match cond_else {609 Some(v) => evaluate(s, ctx, v)?,610 None => Val::Null,611 }612 }613 }614 Slice(value, desc) => {615 fn parse_idx<T: Typed>(616 loc: CallLocation,617 s: State,618 ctx: &Context,619 expr: &Option<LocExpr>,620 desc: &'static str,621 ) -> Result<Option<T>> {622 if let Some(value) = expr {623 Ok(Some(s.push(624 loc,625 || format!("slice {}", desc),626 || T::from_untyped(evaluate(s.clone(), ctx.clone(), value)?, s.clone()),627 )?))628 } else {629 Ok(None)630 }631 }632633 let indexable = evaluate(s.clone(), ctx.clone(), value)?;634 let loc = CallLocation::new(loc);635636 let start = parse_idx(loc, s.clone(), &ctx, &desc.start, "start")?;637 let end = parse_idx(loc, s.clone(), &ctx, &desc.end, "end")?;638 let step = parse_idx(loc, s, &ctx, &desc.step, "step")?;639640 std_slice(indexable.into_indexable()?, start, end, step)?641 }642 i @ (Import(path) | ImportStr(path) | ImportBin(path)) => {643 let tmp = loc.clone().0;644 let import_location = tmp645 .path()646 .map(|p| {647 let mut p = p.to_owned();648 p.pop();649 p650 })651 .unwrap_or_default();652 let resolved_path = s.resolve_file(&import_location, path as &str)?;653 match i {654 Import(_) => s.push(655 CallLocation::new(loc),656 || format!("import {:?}", path.clone()),657 || s.import(resolved_path.clone()),658 )?,659 ImportStr(_) => Val::Str(s.import_str(resolved_path)?),660 ImportBin(_) => Val::Arr(ArrValue::Bytes(s.import_bin(resolved_path)?)),661 _ => unreachable!(),662 }663 }664 })665}crates/jrsonnet-evaluator/src/function/arglike.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/arglike.rs
+++ b/crates/jrsonnet-evaluator/src/function/arglike.rs
@@ -1,6 +1,6 @@
use std::collections::HashMap;
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
use jrsonnet_interner::IStr;
use jrsonnet_parser::{ArgsDesc, LocExpr};
crates/jrsonnet-evaluator/src/function/builtin.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/builtin.rs
+++ b/crates/jrsonnet-evaluator/src/function/builtin.rs
@@ -1,6 +1,6 @@
use std::borrow::Cow;
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
use super::{arglike::ArgsLike, parse::parse_builtin_call, CallLocation};
use crate::{error::Result, gc::TraceBox, Context, State, Val};
crates/jrsonnet-evaluator/src/function/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/mod.rs
+++ b/crates/jrsonnet-evaluator/src/function/mod.rs
@@ -1,7 +1,7 @@
use std::fmt::Debug;
pub use arglike::{ArgLike, ArgsLike, TlaArg};
-use gcmodule::{Cc, Trace};
+use jrsonnet_gcmodule::{Cc, Trace};
use jrsonnet_interner::IStr;
pub use jrsonnet_macros::builtin;
use jrsonnet_parser::{ExprLocation, LocExpr, ParamsDesc};
@@ -91,7 +91,7 @@
/// Plain function implemented in jsonnet
Normal(Cc<FuncDesc>),
/// Standard library function
- StaticBuiltin(#[skip_trace] &'static dyn StaticBuiltin),
+ StaticBuiltin(#[trace(skip)] &'static dyn StaticBuiltin),
/// User-provided function
Builtin(Cc<TraceBox<dyn Builtin>>),
}
crates/jrsonnet-evaluator/src/function/parse.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/parse.rs
+++ b/crates/jrsonnet-evaluator/src/function/parse.rs
@@ -1,4 +1,4 @@
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
use jrsonnet_interner::IStr;
use jrsonnet_parser::{LocExpr, ParamsDesc};
crates/jrsonnet-evaluator/src/gc.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/gc.rs
+++ b/crates/jrsonnet-evaluator/src/gc.rs
@@ -6,8 +6,8 @@
ops::{Deref, DerefMut},
};
-use gcmodule::{Trace, Tracer};
use hashbrown::HashMap;
+use jrsonnet_gcmodule::{Trace, Tracer};
use rustc_hash::{FxHashSet, FxHasher};
/// Replacement for box, which assumes that the underlying type is [`Trace`]
@@ -92,7 +92,7 @@
where
V: Trace,
{
- fn trace(&self, tracer: &mut gcmodule::Tracer) {
+ fn trace(&self, tracer: &mut jrsonnet_gcmodule::Tracer) {
for v in &self.0 {
v.trace(tracer);
}
@@ -133,7 +133,7 @@
K: Trace,
V: Trace,
{
- fn trace(&self, tracer: &mut gcmodule::Tracer) {
+ fn trace(&self, tracer: &mut jrsonnet_gcmodule::Tracer) {
for (k, v) in &self.0 {
k.trace(tracer);
v.trace(tracer);
crates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/lib.rs
+++ b/crates/jrsonnet-evaluator/src/lib.rs
@@ -57,9 +57,9 @@
pub use evaluate::*;
use function::{builtin::Builtin, CallLocation, TlaArg};
use gc::{GcHashMap, TraceBox};
-use gcmodule::{Cc, Trace, Weak};
use hashbrown::hash_map::RawEntryMut;
pub use import::*;
+use jrsonnet_gcmodule::{Cc, Trace};
use jrsonnet_interner::IBytes;
pub use jrsonnet_interner::IStr;
pub use jrsonnet_parser as parser;
@@ -704,32 +704,4 @@
pub fn set_max_stack(&self, trace: usize) {
self.settings_mut().max_stack = trace;
}
-}
-
-pub fn cc_ptr_eq<T>(a: &Cc<T>, b: &Cc<T>) -> bool {
- let a = a as &T;
- let b = b as &T;
- std::ptr::eq(a, b)
-}
-
-fn weak_raw<T>(a: Weak<T>) -> *const () {
- unsafe { std::mem::transmute(a) }
-}
-fn weak_ptr_eq<T>(a: Weak<T>, b: Weak<T>) -> bool {
- std::ptr::eq(weak_raw(a), weak_raw(b))
-}
-
-#[test]
-fn weak_unsafe() {
- let a = Cc::new(1);
- let b = Cc::new(2);
-
- let aw1 = a.clone().downgrade();
- let aw2 = a.clone().downgrade();
- let aw3 = a.clone().downgrade();
-
- let bw = b.clone().downgrade();
-
- assert!(weak_ptr_eq(aw1, aw2));
- assert!(!weak_ptr_eq(aw3, bw));
}
crates/jrsonnet-evaluator/src/map.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/map.rs
+++ b/crates/jrsonnet-evaluator/src/map.rs
@@ -1,10 +1,10 @@
-use gcmodule::{Cc, Trace};
+use jrsonnet_gcmodule::{Cc, Trace};
use jrsonnet_interner::IStr;
use crate::{GcHashMap, Thunk, Val};
#[derive(Trace)]
-#[force_tracking]
+#[trace(tracking(force))]
pub struct LayeredHashMapInternals {
parent: Option<LayeredHashMap>,
current: GcHashMap<IStr, Thunk<Val>>,
crates/jrsonnet-evaluator/src/obj.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/obj.rs
+++ b/crates/jrsonnet-evaluator/src/obj.rs
@@ -5,18 +5,17 @@
ptr::addr_of,
};
-use gcmodule::{Cc, Trace, Weak};
+use jrsonnet_gcmodule::{Cc, Trace, Weak};
use jrsonnet_interner::IStr;
use jrsonnet_parser::{ExprLocation, Visibility};
use rustc_hash::FxHashMap;
use crate::{
- cc_ptr_eq,
error::{Error::*, LocError},
function::CallLocation,
gc::{GcHashMap, GcHashSet, TraceBox},
operator::evaluate_add_op,
- throw, weak_ptr_eq, weak_raw, LazyBinding, Result, State, Thunk, Unbound, Val,
+ throw, LazyBinding, Result, State, Thunk, Unbound, Val,
};
#[cfg(not(feature = "exp-preserve-order"))]
@@ -26,7 +25,7 @@
clippy::unused_self,
)]
- use gcmodule::Trace;
+ use jrsonnet_gcmodule::Trace;
#[derive(Clone, Copy, Default, Debug, Trace)]
pub struct FieldIndex;
@@ -57,7 +56,7 @@
mod ordering {
use std::cmp::Reverse;
- use gcmodule::Trace;
+ use jrsonnet_gcmodule::Trace;
#[derive(Clone, Copy, Default, Debug, Trace, PartialEq, Eq, PartialOrd, Ord)]
pub struct FieldIndex(u32);
@@ -122,7 +121,7 @@
#[allow(clippy::module_name_repetitions)]
#[derive(Trace)]
-#[force_tracking]
+#[trace(tracking(force))]
pub struct ObjValueInternals {
sup: Option<ObjValue>,
this: Option<ObjValue>,
@@ -134,18 +133,20 @@
}
#[derive(Clone, Trace)]
-pub struct WeakObjValue(#[skip_trace] pub(crate) Weak<ObjValueInternals>);
+pub struct WeakObjValue(#[trace(skip)] pub(crate) Weak<ObjValueInternals>);
impl PartialEq for WeakObjValue {
fn eq(&self, other: &Self) -> bool {
- weak_ptr_eq(self.0.clone(), other.0.clone())
+ Weak::ptr_eq(&self.0, &other.0)
}
}
impl Eq for WeakObjValue {}
impl Hash for WeakObjValue {
fn hash<H: Hasher>(&self, hasher: &mut H) {
- hasher.write_usize(weak_raw(self.0.clone()) as usize);
+ // Safety: usize is POD
+ let addr = unsafe { *std::ptr::addr_of!(self.0).cast() };
+ hasher.write_usize(addr);
}
}
@@ -454,7 +455,7 @@
}
pub fn ptr_eq(a: &Self, b: &Self) -> bool {
- cc_ptr_eq(&a.0, &b.0)
+ Cc::ptr_eq(&a.0, &b.0)
}
pub fn downgrade(self) -> WeakObjValue {
WeakObjValue(self.0.downgrade())
@@ -463,7 +464,7 @@
impl PartialEq for ObjValue {
fn eq(&self, other: &Self) -> bool {
- cc_ptr_eq(&self.0, &other.0)
+ Cc::ptr_eq(&self.0, &other.0)
}
}
crates/jrsonnet-evaluator/src/stdlib/format.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/stdlib/format.rs
+++ b/crates/jrsonnet-evaluator/src/stdlib/format.rs
@@ -1,7 +1,7 @@
//! faster std.format impl
#![allow(clippy::too_many_arguments)]
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
use jrsonnet_interner::IStr;
use jrsonnet_types::ValType;
use thiserror::Error;
crates/jrsonnet-evaluator/src/stdlib/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/stdlib/mod.rs
+++ b/crates/jrsonnet-evaluator/src/stdlib/mod.rs
@@ -4,7 +4,7 @@
use std::collections::HashMap;
use format::{format_arr, format_obj};
-use gcmodule::Cc;
+use jrsonnet_gcmodule::Cc;
use jrsonnet_interner::{IBytes, IStr};
use serde::Deserialize;
use serde_yaml::DeserializingQuirks;
crates/jrsonnet-evaluator/src/stdlib/sort.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/stdlib/sort.rs
+++ b/crates/jrsonnet-evaluator/src/stdlib/sort.rs
@@ -1,4 +1,4 @@
-use gcmodule::{Cc, Trace};
+use jrsonnet_gcmodule::{Cc, Trace};
use crate::{
error::{Error, LocError, Result},
crates/jrsonnet-evaluator/src/typed/conversions.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/typed/conversions.rs
+++ b/crates/jrsonnet-evaluator/src/typed/conversions.rs
@@ -1,6 +1,6 @@
use std::ops::Deref;
-use gcmodule::Cc;
+use jrsonnet_gcmodule::Cc;
use jrsonnet_interner::{IBytes, IStr};
pub use jrsonnet_macros::Typed;
use jrsonnet_types::{ComplexValType, ValType};
crates/jrsonnet-evaluator/src/typed/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/typed/mod.rs
+++ b/crates/jrsonnet-evaluator/src/typed/mod.rs
@@ -2,7 +2,7 @@
mod conversions;
pub use conversions::*;
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
pub use jrsonnet_types::{ComplexValType, ValType};
use thiserror::Error;
@@ -16,7 +16,7 @@
#[error("expected {0}, got {1}")]
ExpectedGot(ComplexValType, ValType),
#[error("missing property {0} from {1}")]
- MissingProperty(#[skip_trace] Rc<str>, ComplexValType),
+ MissingProperty(#[trace(skip)] Rc<str>, ComplexValType),
#[error("every failed from {0}:\n{1}")]
UnionFailed(ComplexValType, TypeLocErrorList),
#[error(
@@ -119,7 +119,7 @@
#[derive(Clone, Debug, Trace)]
enum ValuePathItem {
- Field(#[skip_trace] Rc<str>),
+ Field(#[trace(skip)] Rc<str>),
Index(u64),
}
impl Display for ValuePathItem {
crates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/val.rs
+++ b/crates/jrsonnet-evaluator/src/val.rs
@@ -1,11 +1,10 @@
use std::{cell::RefCell, fmt::Debug, rc::Rc};
-use gcmodule::{Cc, Trace};
+use jrsonnet_gcmodule::{Cc, Trace};
use jrsonnet_interner::{IBytes, IStr};
use jrsonnet_types::ValType;
use crate::{
- cc_ptr_eq,
error::{Error::*, LocError},
function::FuncVal,
gc::{GcHashMap, TraceBox},
@@ -21,7 +20,7 @@
}
#[derive(Trace)]
-enum ThunkInner<T> {
+enum ThunkInner<T: Trace> {
Computed(T),
Errored(LocError),
Waiting(TraceBox<dyn ThunkValue<Output = T>>),
@@ -30,7 +29,7 @@
#[allow(clippy::module_name_repetitions)]
#[derive(Clone, Trace)]
-pub struct Thunk<T>(Cc<RefCell<ThunkInner<T>>>);
+pub struct Thunk<T: Trace>(Cc<RefCell<ThunkInner<T>>>);
impl<T> Thunk<T>
where
@@ -78,6 +77,7 @@
pub struct CachedUnbound<I, T>
where
I: Unbound<Bound = T>,
+ T: Trace,
{
cache: Cc<RefCell<GcHashMap<CacheKey, T>>>,
value: I,
@@ -113,14 +113,14 @@
}
}
-impl<T: Debug> Debug for Thunk<T> {
+impl<T: Debug + Trace> Debug for Thunk<T> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
write!(f, "Lazy")
}
}
-impl<T> PartialEq for Thunk<T> {
+impl<T: Trace> PartialEq for Thunk<T> {
fn eq(&self, other: &Self) -> bool {
- cc_ptr_eq(&self.0, &other.0)
+ Cc::ptr_eq(&self.0, &other.0)
}
}
@@ -185,9 +185,10 @@
}
#[derive(Debug, Clone, Trace)]
-#[force_tracking]
+// may contrain other ArrValue
+#[trace(tracking(force))]
pub enum ArrValue {
- Bytes(#[skip_trace] IBytes),
+ Bytes(#[trace(skip)] IBytes),
Lazy(Cc<Vec<Thunk<Val>>>),
Eager(Cc<Vec<Val>>),
Extended(Box<(Self, Self)>),
@@ -434,8 +435,8 @@
pub fn ptr_eq(a: &Self, b: &Self) -> bool {
match (a, b) {
- (Self::Lazy(a), Self::Lazy(b)) => cc_ptr_eq(a, b),
- (Self::Eager(a), Self::Eager(b)) => cc_ptr_eq(a, b),
+ (Self::Lazy(a), Self::Lazy(b)) => Cc::ptr_eq(a, b),
+ (Self::Eager(a), Self::Eager(b)) => Cc::ptr_eq(a, b),
_ => false,
}
}
crates/jrsonnet-evaluator/tests/builtin.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/tests/builtin.rs
+++ b/crates/jrsonnet-evaluator/tests/builtin.rs
@@ -1,6 +1,5 @@
mod common;
-use gcmodule::Cc;
use jrsonnet_evaluator::{
error::Result,
function::{builtin, builtin::Builtin, CallLocation, FuncVal},
@@ -8,6 +7,7 @@
typed::Typed,
State, Val,
};
+use jrsonnet_gcmodule::Cc;
#[builtin]
fn a() -> Result<u32> {
crates/jrsonnet-interner/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-interner/Cargo.toml
+++ b/crates/jrsonnet-interner/Cargo.toml
@@ -11,7 +11,8 @@
serde = ["dep:serde"]
[dependencies]
+jrsonnet-gcmodule = { version = "0.3.4" }
+
serde = { version = "1.0", optional = true }
rustc-hash = "1.1"
-gcmodule = { git = "https://github.com/CertainLach/gcmodule", branch = "jrsonnet" }
hashbrown = { version = "0.12.1", features = ["inline-more"] }
crates/jrsonnet-interner/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-interner/src/lib.rs
+++ b/crates/jrsonnet-interner/src/lib.rs
@@ -13,8 +13,8 @@
str,
};
-use gcmodule::Trace;
use hashbrown::HashMap;
+use jrsonnet_gcmodule::Trace;
use rustc_hash::FxHasher;
mod inner;
crates/jrsonnet-macros/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-macros/src/lib.rs
+++ b/crates/jrsonnet-macros/src/lib.rs
@@ -342,7 +342,7 @@
#fun
#[doc(hidden)]
#[allow(non_camel_case_types)]
- #[derive(Clone, gcmodule::Trace #static_derive_copy)]
+ #[derive(Clone, jrsonnet_gcmodule::Trace #static_derive_copy)]
#vis struct #name {
#(#fields)*
}
crates/jrsonnet-parser/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-parser/Cargo.toml
+++ b/crates/jrsonnet-parser/Cargo.toml
@@ -11,12 +11,13 @@
[dependencies]
jrsonnet-interner = { path = "../jrsonnet-interner", version = "0.4.2" }
+jrsonnet-gcmodule = { version = "0.3.4" }
+
static_assertions = "1.1.0"
peg = "0.8.0"
serde = { version = "1.0", features = ["derive", "rc"], optional = true }
-gcmodule = { git = "https://github.com/CertainLach/gcmodule", branch = "jrsonnet" }
[dev-dependencies]
jrsonnet-stdlib = { path = "../jrsonnet-stdlib", version = "0.4.2" }
crates/jrsonnet-parser/src/expr.rsdiffbeforeafterboth--- a/crates/jrsonnet-parser/src/expr.rs
+++ b/crates/jrsonnet-parser/src/expr.rs
@@ -4,7 +4,7 @@
rc::Rc,
};
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
use jrsonnet_interner::IStr;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
@@ -359,7 +359,7 @@
/// file, begin offset, end offset
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[derive(Clone, PartialEq, Eq, Trace)]
-#[skip_trace]
+#[trace(skip)]
#[repr(C)]
pub struct ExprLocation(pub Source, pub u32, pub u32);
impl ExprLocation {
crates/jrsonnet-parser/src/source.rsdiffbeforeafterboth--- a/crates/jrsonnet-parser/src/source.rs
+++ b/crates/jrsonnet-parser/src/source.rs
@@ -5,7 +5,7 @@
rc::Rc,
};
-use gcmodule::{Trace, Tracer};
+use jrsonnet_gcmodule::{Trace, Tracer};
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
crates/jrsonnet-types/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-types/Cargo.toml
+++ b/crates/jrsonnet-types/Cargo.toml
@@ -7,5 +7,6 @@
edition = "2021"
[dependencies]
+jrsonnet-gcmodule = { version = "0.3.4" }
+
peg = "0.8.0"
-gcmodule = { git = "https://github.com/CertainLach/gcmodule", branch = "jrsonnet" }
crates/jrsonnet-types/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-types/src/lib.rs
+++ b/crates/jrsonnet-types/src/lib.rs
@@ -2,7 +2,7 @@
use std::fmt::Display;
-use gcmodule::Trace;
+use jrsonnet_gcmodule::Trace;
#[macro_export]
macro_rules! ty {
@@ -115,7 +115,7 @@
}
#[derive(Debug, Clone, PartialEq, Trace)]
-#[skip_trace]
+#[trace(skip)]
pub enum ComplexValType {
Any,
Char,