git.delta.rocks / jrsonnet / refs/commits / abd809cc16d2

difftreelog

fix unchecked conversion of array index

Yaroslav Bolyukin2023-09-22parent: #e19afeb.patch.diff
in: master

2 files changed

modifiedcrates/jrsonnet-evaluator/src/error.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/error.rs
+++ b/crates/jrsonnet-evaluator/src/error.rs
@@ -114,7 +114,7 @@
 	InComprehensionCanOnlyIterateOverArray,
 
 	#[error("array out of bounds: {0} is not within [0,{1})")]
-	ArrayBoundsError(usize, usize),
+	ArrayBoundsError(isize, usize),
 	#[error("string out of bounds: {0} is not within [0,{1})")]
 	StringBoundsError(usize, usize),
 
modifiedcrates/jrsonnet-evaluator/src/evaluate/mod.rsdiffbeforeafterboth
before · crates/jrsonnet-evaluator/src/evaluate/mod.rs
1use std::rc::Rc;23use jrsonnet_gcmodule::{Cc, Trace};4use jrsonnet_interner::IStr;5use jrsonnet_parser::{6	ArgsDesc, AssertStmt, BindSpec, CompSpec, Expr, FieldMember, FieldName, ForSpecData,7	IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc,8};9use jrsonnet_types::ValType;1011use self::destructure::destruct;12use crate::{13	arr::ArrValue,14	bail,15	destructure::evaluate_dest,16	error::{suggest_object_fields, ErrorKind::*},17	evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},18	function::{CallLocation, FuncDesc, FuncVal},19	typed::Typed,20	val::{CachedUnbound, IndexableVal, StrValue, Thunk, ThunkValue},21	Context, GcHashMap, ObjValue, ObjValueBuilder, ObjectAssertion, Pending, Result, ResultExt,22	State, Unbound, Val, Error,23};24pub mod destructure;25pub mod operator;2627pub fn evaluate_trivial(expr: &LocExpr) -> Option<Val> {28	fn is_trivial(expr: &LocExpr) -> bool {29		match &*expr.0 {30			Expr::Str(_)31			| Expr::Num(_)32			| Expr::Literal(LiteralType::False | LiteralType::True | LiteralType::Null) => true,33			Expr::Arr(a) => a.iter().all(is_trivial),34			Expr::Parened(e) => is_trivial(e),35			_ => false,36		}37	}38	Some(match &*expr.0 {39		Expr::Str(s) => Val::string(s.clone()),40		Expr::Num(n) => Val::Num(*n),41		Expr::Literal(LiteralType::False) => Val::Bool(false),42		Expr::Literal(LiteralType::True) => Val::Bool(true),43		Expr::Literal(LiteralType::Null) => Val::Null,44		Expr::Arr(n) => {45			if n.iter().any(|e| !is_trivial(e)) {46				return None;47			}48			Val::Arr(ArrValue::eager(49				n.iter()50					.map(evaluate_trivial)51					.map(|e| e.expect("checked trivial"))52					.collect(),53			))54		}55		Expr::Parened(e) => evaluate_trivial(e)?,56		_ => return None,57	})58}5960pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {61	Val::Func(FuncVal::Normal(Cc::new(FuncDesc {62		name,63		ctx,64		params,65		body,66	})))67}6869pub fn evaluate_field_name(ctx: Context, field_name: &FieldName) -> Result<Option<IStr>> {70	Ok(match field_name {71		FieldName::Fixed(n) => Some(n.clone()),72		FieldName::Dyn(expr) => State::push(73			CallLocation::new(&expr.1),74			|| "evaluating field name".to_string(),75			|| {76				let value = evaluate(ctx, expr)?;77				if matches!(value, Val::Null) {78					Ok(None)79				} else {80					Ok(Some(IStr::from_untyped(value)?))81				}82			},83		)?,84	})85}8687pub fn evaluate_comp(88	ctx: Context,89	specs: &[CompSpec],90	callback: &mut impl FnMut(Context) -> Result<()>,91) -> Result<()> {92	match specs.get(0) {93		None => callback(ctx)?,94		Some(CompSpec::IfSpec(IfSpecData(cond))) => {95			if bool::from_untyped(evaluate(ctx.clone(), cond)?)? {96				evaluate_comp(ctx, &specs[1..], callback)?;97			}98		}99		Some(CompSpec::ForSpec(ForSpecData(var, expr))) => match evaluate(ctx.clone(), expr)? {100			Val::Arr(list) => {101				for item in list.iter_lazy() {102					let fctx = Pending::new();103					let mut new_bindings = GcHashMap::with_capacity(var.capacity_hint());104					destruct(var, item, fctx.clone(), &mut new_bindings)?;105					let ctx = ctx106						.clone()107						.extend(new_bindings, None, None, None)108						.into_future(fctx);109110					evaluate_comp(ctx, &specs[1..], callback)?;111				}112			}113			#[cfg(feature = "exp-object-iteration")]114			Val::Obj(obj) => {115				for field in obj.fields(116					// TODO: Should there be ability to preserve iteration order?117					#[cfg(feature = "exp-preserve-order")]118					false,119				) {120					#[derive(Trace)]121					struct ObjectFieldThunk {122						obj: ObjValue,123						field: IStr,124					}125					impl ThunkValue for ObjectFieldThunk {126						type Output = Val;127128						fn get(self: Box<Self>) -> Result<Self::Output> {129							self.obj.get(self.field).transpose().expect(130								"field exists, as field name was obtained from object.fields()",131							)132						}133					}134135					let fctx = Pending::new();136					let mut new_bindings = GcHashMap::with_capacity(var.capacity_hint());137					let value = Thunk::evaluated(Val::Arr(ArrValue::lazy(vec![138						Thunk::evaluated(Val::string(field.clone())),139						Thunk::new(ObjectFieldThunk {140							field: field.clone(),141							obj: obj.clone(),142						}),143					])));144					destruct(var, value, fctx.clone(), &mut new_bindings)?;145					let ctx = ctx146						.clone()147						.extend(new_bindings, None, None, None)148						.into_future(fctx);149150					evaluate_comp(ctx, &specs[1..], callback)?;151				}152			}153			_ => bail!(InComprehensionCanOnlyIterateOverArray),154		},155	}156	Ok(())157}158159trait CloneableUnbound<T>: Unbound<Bound = T> + Clone {}160impl<V, T> CloneableUnbound<T> for V where V: Unbound<Bound = T> + Clone {}161162fn evaluate_object_locals(163	fctx: Pending<Context>,164	locals: Rc<Vec<BindSpec>>,165) -> impl CloneableUnbound<Context> {166	#[derive(Trace, Clone)]167	struct UnboundLocals {168		fctx: Pending<Context>,169		locals: Rc<Vec<BindSpec>>,170	}171	impl Unbound for UnboundLocals {172		type Bound = Context;173174		fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Context> {175			let fctx = Context::new_future();176			let mut new_bindings =177				GcHashMap::with_capacity(self.locals.iter().map(BindSpec::capacity_hint).sum());178			for b in self.locals.iter() {179				evaluate_dest(b, fctx.clone(), &mut new_bindings)?;180			}181182			let ctx = self.fctx.unwrap();183			let new_dollar = ctx.dollar().cloned().or_else(|| this.clone());184185			let ctx = ctx186				.extend(new_bindings, new_dollar, sup, this)187				.into_future(fctx);188189			Ok(ctx)190		}191	}192193	UnboundLocals { fctx, locals }194}195196pub fn evaluate_field_member<B: Unbound<Bound = Context> + Clone>(197	builder: &mut ObjValueBuilder,198	ctx: Context,199	uctx: B,200	field: &FieldMember,201) -> Result<()> {202	let name = evaluate_field_name(ctx, &field.name)?;203	let Some(name) = name else {204		return Ok(());205	};206207	match field {208		FieldMember {209			plus,210			params: None,211			visibility,212			value,213			..214		} => {215			#[derive(Trace)]216			struct UnboundValue<B: Trace> {217				uctx: B,218				value: LocExpr,219				name: IStr,220			}221			impl<B: Unbound<Bound = Context>> Unbound for UnboundValue<B> {222				type Bound = Val;223				fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Val> {224					evaluate_named(self.uctx.bind(sup, this)?, &self.value, self.name.clone())225				}226			}227228			builder229				.field(name.clone())230				.with_add(*plus)231				.with_visibility(*visibility)232				.with_location(value.1.clone())233				.bindable(UnboundValue {234					uctx,235					value: value.clone(),236					name,237				})?;238		}239		FieldMember {240			params: Some(params),241			visibility,242			value,243			..244		} => {245			#[derive(Trace)]246			struct UnboundMethod<B: Trace> {247				uctx: B,248				value: LocExpr,249				params: ParamsDesc,250				name: IStr,251			}252			impl<B: Unbound<Bound = Context>> Unbound for UnboundMethod<B> {253				type Bound = Val;254				fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Val> {255					Ok(evaluate_method(256						self.uctx.bind(sup, this)?,257						self.name.clone(),258						self.params.clone(),259						self.value.clone(),260					))261				}262			}263264			builder265				.field(name.clone())266				.with_visibility(*visibility)267				.with_location(value.1.clone())268				.bindable(UnboundMethod {269					uctx,270					value: value.clone(),271					params: params.clone(),272					name,273				})?;274		}275	}276	Ok(())277}278279#[allow(clippy::too_many_lines)]280pub fn evaluate_member_list_object(ctx: Context, members: &[Member]) -> Result<ObjValue> {281	let mut builder = ObjValueBuilder::new();282	let locals = Rc::new(283		members284			.iter()285			.filter_map(|m| match m {286				Member::BindStmt(bind) => Some(bind.clone()),287				_ => None,288			})289			.collect::<Vec<_>>(),290	);291292	let fctx = Context::new_future();293294	// We have single context for all fields, so we can cache binds295	let uctx = CachedUnbound::new(evaluate_object_locals(fctx.clone(), locals));296297	for member in members {298		match member {299			Member::Field(field) => {300				evaluate_field_member(&mut builder, ctx.clone(), uctx.clone(), field)?;301			}302			Member::AssertStmt(stmt) => {303				#[derive(Trace)]304				struct ObjectAssert<B: Trace> {305					uctx: B,306					assert: AssertStmt,307				}308				impl<B: Unbound<Bound = Context>> ObjectAssertion for ObjectAssert<B> {309					fn run(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<()> {310						let ctx = self.uctx.bind(sup, this)?;311						evaluate_assert(ctx, &self.assert)312					}313				}314				builder.assert(ObjectAssert {315					uctx: uctx.clone(),316					assert: stmt.clone(),317				});318			}319			Member::BindStmt(_) => {320				// Already handled321			}322		}323	}324	let this = builder.build();325	fctx.fill(ctx.extend(GcHashMap::new(), None, None, Some(this.clone())));326	Ok(this)327}328329pub fn evaluate_object(ctx: Context, object: &ObjBody) -> Result<ObjValue> {330	Ok(match object {331		ObjBody::MemberList(members) => evaluate_member_list_object(ctx, members)?,332		ObjBody::ObjComp(obj) => {333			let mut builder = ObjValueBuilder::new();334			let locals = Rc::new(335				obj.pre_locals336					.iter()337					.chain(obj.post_locals.iter())338					.cloned()339					.collect::<Vec<_>>(),340			);341			let mut ctxs = vec![];342			evaluate_comp(ctx, &obj.compspecs, &mut |ctx| {343				let fctx = Context::new_future();344				ctxs.push((ctx.clone(), fctx.clone()));345				let uctx = evaluate_object_locals(fctx, locals.clone());346347				evaluate_field_member(&mut builder, ctx, uctx, &obj.field)348			})?;349350			let this = builder.build();351			for (ctx, fctx) in ctxs {352				let _ctx = ctx353					.extend(GcHashMap::new(), None, None, Some(this.clone()))354					.into_future(fctx);355			}356			this357		}358	})359}360361pub fn evaluate_apply(362	ctx: Context,363	value: &LocExpr,364	args: &ArgsDesc,365	loc: CallLocation<'_>,366	tailstrict: bool,367) -> Result<Val> {368	let value = evaluate(ctx.clone(), value)?;369	Ok(match value {370		Val::Func(f) => {371			let body = || f.evaluate(ctx, loc, args, tailstrict);372			if tailstrict {373				body()?374			} else {375				State::push(loc, || format!("function <{}> call", f.name()), body)?376			}377		}378		v => bail!(OnlyFunctionsCanBeCalledGot(v.value_type())),379	})380}381382pub fn evaluate_assert(ctx: Context, assertion: &AssertStmt) -> Result<()> {383	let value = &assertion.0;384	let msg = &assertion.1;385	let assertion_result = State::push(386		CallLocation::new(&value.1),387		|| "assertion condition".to_owned(),388		|| bool::from_untyped(evaluate(ctx.clone(), value)?),389	)?;390	if !assertion_result {391		State::push(392			CallLocation::new(&value.1),393			|| "assertion failure".to_owned(),394			|| {395				if let Some(msg) = msg {396					bail!(AssertionFailed(evaluate(ctx, msg)?.to_string()?));397				}398				bail!(AssertionFailed(Val::Null.to_string()?));399			},400		)?;401	}402	Ok(())403}404405pub fn evaluate_named(ctx: Context, expr: &LocExpr, name: IStr) -> Result<Val> {406	use Expr::*;407	let LocExpr(raw_expr, _loc) = expr;408	Ok(match &**raw_expr {409		Function(params, body) => evaluate_method(ctx, name, params.clone(), body.clone()),410		_ => evaluate(ctx, expr)?,411	})412}413414#[allow(clippy::too_many_lines)]415pub fn evaluate(ctx: Context, expr: &LocExpr) -> Result<Val> {416	use Expr::*;417418	if let Some(trivial) = evaluate_trivial(expr) {419		return Ok(trivial);420	}421	let LocExpr(expr, loc) = expr;422	Ok(match &**expr {423		Literal(LiteralType::This) => {424			Val::Obj(ctx.this().ok_or(CantUseSelfOutsideOfObject)?.clone())425		}426		Literal(LiteralType::Super) => Val::Obj(427			ctx.super_obj().ok_or(NoSuperFound)?.with_this(428				ctx.this()429					.expect("if super exists - then this should too")430					.clone(),431			),432		),433		Literal(LiteralType::Dollar) => {434			Val::Obj(ctx.dollar().ok_or(NoTopLevelObjectFound)?.clone())435		}436		Literal(LiteralType::True) => Val::Bool(true),437		Literal(LiteralType::False) => Val::Bool(false),438		Literal(LiteralType::Null) => Val::Null,439		Parened(e) => evaluate(ctx, e)?,440		Str(v) => Val::string(v.clone()),441		Num(v) => Val::new_checked_num(*v)?,442		BinaryOp(v1, o, v2) => evaluate_binary_op_special(ctx, v1, *o, v2)?,443		UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(ctx, v)?)?,444		Var(name) => State::push(445			CallLocation::new(loc),446			|| format!("variable <{name}> access"),447			|| ctx.binding(name.clone())?.evaluate(),448		)?,449		Index { indexable, parts } => {450			let mut parts = parts.iter();451			let mut indexable = match &indexable {452				// Cheaper to execute than creating object with overriden `this`453				LocExpr(v, _) if matches!(&**v, Expr::Literal(LiteralType::Super)) => {454					let part = parts.next().expect("at least part should exist");455					let Some(super_obj) = ctx.super_obj() else {456						#[cfg(feature = "exp-null-coaelse")]457						if part.null_coaelse {458							return Ok(Val::Null);459						}460						bail!(NoSuperFound)461					};462					let name = evaluate(ctx.clone(), &part.value)?;463464					let Val::Str(name) = name else {465						bail!(ValueIndexMustBeTypeGot(466							ValType::Obj,467							ValType::Str,468							name.value_type(),469						))470					};471472					let this = ctx473						.this()474						.expect("no this found, while super present, should not happen");475					let name = name.into_flat();476					match super_obj477						.get_for(name.clone(), this.clone())478						.with_description_src(&part.value, || format!("field <{name}> access"))?479					{480						Some(v) => v,481						#[cfg(feature = "exp-null-coaelse")]482						None if part.null_coaelse => return Ok(Val::Null),483						None => {484							let suggestions = suggest_object_fields(super_obj, name.clone());485486							bail!(NoSuchField(name, suggestions))487						}488					}489				}490				e => evaluate(ctx.clone(), e)?,491			};492493			for part in parts {494				indexable = match (indexable, evaluate(ctx.clone(), &part.value)?) {495					(Val::Obj(v), Val::Str(key)) => match v496						.get(key.clone().into_flat())497						.with_description_src(&part.value, || format!("field <{key}> access"))?498					{499						Some(v) => v,500						#[cfg(feature = "exp-null-coaelse")]501						None if part.null_coaelse => return Ok(Val::Null),502						None => {503							let suggestions = suggest_object_fields(&v, key.clone().into_flat());504505							return Err(Error::from(NoSuchField(506								key.clone().into_flat(),507								suggestions,508							)))509							.with_description_src(&part.value, || format!("field <{key}> access"));510						}511					},512					(Val::Obj(_), n) => bail!(ValueIndexMustBeTypeGot(513						ValType::Obj,514						ValType::Str,515						n.value_type(),516					)),517					(Val::Arr(v), Val::Num(n)) => {518						if n.fract() > f64::EPSILON {519							bail!(FractionalIndex)520						}521						v.get(n as usize)?522							.ok_or_else(|| ArrayBoundsError(n as usize, v.len()))?523					}524					(Val::Arr(_), Val::Str(n)) => {525						bail!(AttemptedIndexAnArrayWithString(n.into_flat()))526					}527					(Val::Arr(_), n) => bail!(ValueIndexMustBeTypeGot(528						ValType::Arr,529						ValType::Num,530						n.value_type(),531					)),532533					(Val::Str(s), Val::Num(n)) => Val::Str({534						let v: IStr = s535							.clone()536							.into_flat()537							.chars()538							.skip(n as usize)539							.take(1)540							.collect::<String>()541							.into();542						if v.is_empty() {543							let size = s.into_flat().chars().count();544							bail!(StringBoundsError(n as usize, size))545						}546						StrValue::Flat(v)547					}),548					(Val::Str(_), n) => bail!(ValueIndexMustBeTypeGot(549						ValType::Str,550						ValType::Num,551						n.value_type(),552					)),553					#[cfg(feature = "exp-null-coaelse")]554					(Val::Null, _) if part.null_coaelse => return Ok(Val::Null),555					(v, _) => bail!(CantIndexInto(v.value_type())),556				};557			}558			indexable559		}560		LocalExpr(bindings, returned) => {561			let mut new_bindings: GcHashMap<IStr, Thunk<Val>> =562				GcHashMap::with_capacity(bindings.iter().map(BindSpec::capacity_hint).sum());563			let fctx = Context::new_future();564			for b in bindings {565				evaluate_dest(b, fctx.clone(), &mut new_bindings)?;566			}567			let ctx = ctx.extend(new_bindings, None, None, None).into_future(fctx);568			evaluate(ctx, &returned.clone())?569		}570		Arr(items) => {571			if items.is_empty() {572				Val::Arr(ArrValue::empty())573			} else if items.len() == 1 {574				#[derive(Trace)]575				struct ArrayElement {576					ctx: Context,577					item: LocExpr,578				}579				impl ThunkValue for ArrayElement {580					type Output = Val;581					fn get(self: Box<Self>) -> Result<Val> {582						evaluate(self.ctx, &self.item)583					}584				}585				Val::Arr(ArrValue::lazy(vec![Thunk::new(ArrayElement {586					ctx,587					item: items[0].clone(),588				})]))589			} else {590				Val::Arr(ArrValue::expr(ctx, items.iter().cloned()))591			}592		}593		ArrComp(expr, comp_specs) => {594			let mut out = Vec::new();595			evaluate_comp(ctx, comp_specs, &mut |ctx| {596				out.push(evaluate(ctx, expr)?);597				Ok(())598			})?;599			Val::Arr(ArrValue::eager(out))600		}601		Obj(body) => Val::Obj(evaluate_object(ctx, body)?),602		ObjExtend(a, b) => evaluate_add_op(603			&evaluate(ctx.clone(), a)?,604			&Val::Obj(evaluate_object(ctx, b)?),605		)?,606		Apply(value, args, tailstrict) => {607			evaluate_apply(ctx, value, args, CallLocation::new(loc), *tailstrict)?608		}609		Function(params, body) => {610			evaluate_method(ctx, "anonymous".into(), params.clone(), body.clone())611		}612		AssertExpr(assert, returned) => {613			evaluate_assert(ctx.clone(), assert)?;614			evaluate(ctx, returned)?615		}616		ErrorStmt(e) => State::push(617			CallLocation::new(loc),618			|| "error statement".to_owned(),619			|| bail!(RuntimeError(evaluate(ctx, e)?.to_string()?,)),620		)?,621		IfElse {622			cond,623			cond_then,624			cond_else,625		} => {626			if State::push(627				CallLocation::new(loc),628				|| "if condition".to_owned(),629				|| bool::from_untyped(evaluate(ctx.clone(), &cond.0)?),630			)? {631				evaluate(ctx, cond_then)?632			} else {633				match cond_else {634					Some(v) => evaluate(ctx, v)?,635					None => Val::Null,636				}637			}638		}639		Slice(value, desc) => {640			fn parse_idx<T: Typed>(641				loc: CallLocation<'_>,642				ctx: &Context,643				expr: Option<&LocExpr>,644				desc: &'static str,645			) -> Result<Option<T>> {646				if let Some(value) = expr {647					Ok(Some(State::push(648						loc,649						|| format!("slice {desc}"),650						|| T::from_untyped(evaluate(ctx.clone(), value)?),651					)?))652				} else {653					Ok(None)654				}655			}656657			let indexable = evaluate(ctx.clone(), value)?;658			let loc = CallLocation::new(loc);659660			let start = parse_idx(loc, &ctx, desc.start.as_ref(), "start")?;661			let end = parse_idx(loc, &ctx, desc.end.as_ref(), "end")?;662			let step = parse_idx(loc, &ctx, desc.step.as_ref(), "step")?;663664			IndexableVal::into_untyped(indexable.into_indexable()?.slice(start, end, step)?)?665		}666		i @ (Import(path) | ImportStr(path) | ImportBin(path)) => {667			let Expr::Str(path) = &*path.0 else {668				bail!("computed imports are not supported")669			};670			let tmp = loc.clone().0;671			let s = ctx.state();672			let resolved_path = s.resolve_from(tmp.source_path(), path as &str)?;673			match i {674				Import(_) => State::push(675					CallLocation::new(loc),676					|| format!("import {:?}", path.clone()),677					|| s.import_resolved(resolved_path),678				)?,679				ImportStr(_) => Val::string(s.import_resolved_str(resolved_path)?),680				ImportBin(_) => Val::Arr(ArrValue::bytes(s.import_resolved_bin(resolved_path)?)),681				_ => unreachable!(),682			}683		}684	})685}
after · crates/jrsonnet-evaluator/src/evaluate/mod.rs
1use std::rc::Rc;23use jrsonnet_gcmodule::{Cc, Trace};4use jrsonnet_interner::IStr;5use jrsonnet_parser::{6	ArgsDesc, AssertStmt, BindSpec, CompSpec, Expr, FieldMember, FieldName, ForSpecData,7	IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc,8};9use jrsonnet_types::ValType;1011use self::destructure::destruct;12use crate::{13	arr::ArrValue,14	bail,15	destructure::evaluate_dest,16	error::{suggest_object_fields, ErrorKind::*},17	evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},18	function::{CallLocation, FuncDesc, FuncVal},19	typed::Typed,20	val::{CachedUnbound, IndexableVal, StrValue, Thunk, ThunkValue},21	Context, Error, GcHashMap, ObjValue, ObjValueBuilder, ObjectAssertion, Pending, Result,22	ResultExt, State, Unbound, Val,23};24pub mod destructure;25pub mod operator;2627pub fn evaluate_trivial(expr: &LocExpr) -> Option<Val> {28	fn is_trivial(expr: &LocExpr) -> bool {29		match &*expr.0 {30			Expr::Str(_)31			| Expr::Num(_)32			| Expr::Literal(LiteralType::False | LiteralType::True | LiteralType::Null) => true,33			Expr::Arr(a) => a.iter().all(is_trivial),34			Expr::Parened(e) => is_trivial(e),35			_ => false,36		}37	}38	Some(match &*expr.0 {39		Expr::Str(s) => Val::string(s.clone()),40		Expr::Num(n) => Val::Num(*n),41		Expr::Literal(LiteralType::False) => Val::Bool(false),42		Expr::Literal(LiteralType::True) => Val::Bool(true),43		Expr::Literal(LiteralType::Null) => Val::Null,44		Expr::Arr(n) => {45			if n.iter().any(|e| !is_trivial(e)) {46				return None;47			}48			Val::Arr(ArrValue::eager(49				n.iter()50					.map(evaluate_trivial)51					.map(|e| e.expect("checked trivial"))52					.collect(),53			))54		}55		Expr::Parened(e) => evaluate_trivial(e)?,56		_ => return None,57	})58}5960pub fn evaluate_method(ctx: Context, name: IStr, params: ParamsDesc, body: LocExpr) -> Val {61	Val::Func(FuncVal::Normal(Cc::new(FuncDesc {62		name,63		ctx,64		params,65		body,66	})))67}6869pub fn evaluate_field_name(ctx: Context, field_name: &FieldName) -> Result<Option<IStr>> {70	Ok(match field_name {71		FieldName::Fixed(n) => Some(n.clone()),72		FieldName::Dyn(expr) => State::push(73			CallLocation::new(&expr.1),74			|| "evaluating field name".to_string(),75			|| {76				let value = evaluate(ctx, expr)?;77				if matches!(value, Val::Null) {78					Ok(None)79				} else {80					Ok(Some(IStr::from_untyped(value)?))81				}82			},83		)?,84	})85}8687pub fn evaluate_comp(88	ctx: Context,89	specs: &[CompSpec],90	callback: &mut impl FnMut(Context) -> Result<()>,91) -> Result<()> {92	match specs.get(0) {93		None => callback(ctx)?,94		Some(CompSpec::IfSpec(IfSpecData(cond))) => {95			if bool::from_untyped(evaluate(ctx.clone(), cond)?)? {96				evaluate_comp(ctx, &specs[1..], callback)?;97			}98		}99		Some(CompSpec::ForSpec(ForSpecData(var, expr))) => match evaluate(ctx.clone(), expr)? {100			Val::Arr(list) => {101				for item in list.iter_lazy() {102					let fctx = Pending::new();103					let mut new_bindings = GcHashMap::with_capacity(var.capacity_hint());104					destruct(var, item, fctx.clone(), &mut new_bindings)?;105					let ctx = ctx106						.clone()107						.extend(new_bindings, None, None, None)108						.into_future(fctx);109110					evaluate_comp(ctx, &specs[1..], callback)?;111				}112			}113			#[cfg(feature = "exp-object-iteration")]114			Val::Obj(obj) => {115				for field in obj.fields(116					// TODO: Should there be ability to preserve iteration order?117					#[cfg(feature = "exp-preserve-order")]118					false,119				) {120					#[derive(Trace)]121					struct ObjectFieldThunk {122						obj: ObjValue,123						field: IStr,124					}125					impl ThunkValue for ObjectFieldThunk {126						type Output = Val;127128						fn get(self: Box<Self>) -> Result<Self::Output> {129							self.obj.get(self.field).transpose().expect(130								"field exists, as field name was obtained from object.fields()",131							)132						}133					}134135					let fctx = Pending::new();136					let mut new_bindings = GcHashMap::with_capacity(var.capacity_hint());137					let value = Thunk::evaluated(Val::Arr(ArrValue::lazy(vec![138						Thunk::evaluated(Val::string(field.clone())),139						Thunk::new(ObjectFieldThunk {140							field: field.clone(),141							obj: obj.clone(),142						}),143					])));144					destruct(var, value, fctx.clone(), &mut new_bindings)?;145					let ctx = ctx146						.clone()147						.extend(new_bindings, None, None, None)148						.into_future(fctx);149150					evaluate_comp(ctx, &specs[1..], callback)?;151				}152			}153			_ => bail!(InComprehensionCanOnlyIterateOverArray),154		},155	}156	Ok(())157}158159trait CloneableUnbound<T>: Unbound<Bound = T> + Clone {}160impl<V, T> CloneableUnbound<T> for V where V: Unbound<Bound = T> + Clone {}161162fn evaluate_object_locals(163	fctx: Pending<Context>,164	locals: Rc<Vec<BindSpec>>,165) -> impl CloneableUnbound<Context> {166	#[derive(Trace, Clone)]167	struct UnboundLocals {168		fctx: Pending<Context>,169		locals: Rc<Vec<BindSpec>>,170	}171	impl Unbound for UnboundLocals {172		type Bound = Context;173174		fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Context> {175			let fctx = Context::new_future();176			let mut new_bindings =177				GcHashMap::with_capacity(self.locals.iter().map(BindSpec::capacity_hint).sum());178			for b in self.locals.iter() {179				evaluate_dest(b, fctx.clone(), &mut new_bindings)?;180			}181182			let ctx = self.fctx.unwrap();183			let new_dollar = ctx.dollar().cloned().or_else(|| this.clone());184185			let ctx = ctx186				.extend(new_bindings, new_dollar, sup, this)187				.into_future(fctx);188189			Ok(ctx)190		}191	}192193	UnboundLocals { fctx, locals }194}195196pub fn evaluate_field_member<B: Unbound<Bound = Context> + Clone>(197	builder: &mut ObjValueBuilder,198	ctx: Context,199	uctx: B,200	field: &FieldMember,201) -> Result<()> {202	let name = evaluate_field_name(ctx, &field.name)?;203	let Some(name) = name else {204		return Ok(());205	};206207	match field {208		FieldMember {209			plus,210			params: None,211			visibility,212			value,213			..214		} => {215			#[derive(Trace)]216			struct UnboundValue<B: Trace> {217				uctx: B,218				value: LocExpr,219				name: IStr,220			}221			impl<B: Unbound<Bound = Context>> Unbound for UnboundValue<B> {222				type Bound = Val;223				fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Val> {224					evaluate_named(self.uctx.bind(sup, this)?, &self.value, self.name.clone())225				}226			}227228			builder229				.field(name.clone())230				.with_add(*plus)231				.with_visibility(*visibility)232				.with_location(value.1.clone())233				.bindable(UnboundValue {234					uctx,235					value: value.clone(),236					name,237				})?;238		}239		FieldMember {240			params: Some(params),241			visibility,242			value,243			..244		} => {245			#[derive(Trace)]246			struct UnboundMethod<B: Trace> {247				uctx: B,248				value: LocExpr,249				params: ParamsDesc,250				name: IStr,251			}252			impl<B: Unbound<Bound = Context>> Unbound for UnboundMethod<B> {253				type Bound = Val;254				fn bind(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<Val> {255					Ok(evaluate_method(256						self.uctx.bind(sup, this)?,257						self.name.clone(),258						self.params.clone(),259						self.value.clone(),260					))261				}262			}263264			builder265				.field(name.clone())266				.with_visibility(*visibility)267				.with_location(value.1.clone())268				.bindable(UnboundMethod {269					uctx,270					value: value.clone(),271					params: params.clone(),272					name,273				})?;274		}275	}276	Ok(())277}278279#[allow(clippy::too_many_lines)]280pub fn evaluate_member_list_object(ctx: Context, members: &[Member]) -> Result<ObjValue> {281	let mut builder = ObjValueBuilder::new();282	let locals = Rc::new(283		members284			.iter()285			.filter_map(|m| match m {286				Member::BindStmt(bind) => Some(bind.clone()),287				_ => None,288			})289			.collect::<Vec<_>>(),290	);291292	let fctx = Context::new_future();293294	// We have single context for all fields, so we can cache binds295	let uctx = CachedUnbound::new(evaluate_object_locals(fctx.clone(), locals));296297	for member in members {298		match member {299			Member::Field(field) => {300				evaluate_field_member(&mut builder, ctx.clone(), uctx.clone(), field)?;301			}302			Member::AssertStmt(stmt) => {303				#[derive(Trace)]304				struct ObjectAssert<B: Trace> {305					uctx: B,306					assert: AssertStmt,307				}308				impl<B: Unbound<Bound = Context>> ObjectAssertion for ObjectAssert<B> {309					fn run(&self, sup: Option<ObjValue>, this: Option<ObjValue>) -> Result<()> {310						let ctx = self.uctx.bind(sup, this)?;311						evaluate_assert(ctx, &self.assert)312					}313				}314				builder.assert(ObjectAssert {315					uctx: uctx.clone(),316					assert: stmt.clone(),317				});318			}319			Member::BindStmt(_) => {320				// Already handled321			}322		}323	}324	let this = builder.build();325	fctx.fill(ctx.extend(GcHashMap::new(), None, None, Some(this.clone())));326	Ok(this)327}328329pub fn evaluate_object(ctx: Context, object: &ObjBody) -> Result<ObjValue> {330	Ok(match object {331		ObjBody::MemberList(members) => evaluate_member_list_object(ctx, members)?,332		ObjBody::ObjComp(obj) => {333			let mut builder = ObjValueBuilder::new();334			let locals = Rc::new(335				obj.pre_locals336					.iter()337					.chain(obj.post_locals.iter())338					.cloned()339					.collect::<Vec<_>>(),340			);341			let mut ctxs = vec![];342			evaluate_comp(ctx, &obj.compspecs, &mut |ctx| {343				let fctx = Context::new_future();344				ctxs.push((ctx.clone(), fctx.clone()));345				let uctx = evaluate_object_locals(fctx, locals.clone());346347				evaluate_field_member(&mut builder, ctx, uctx, &obj.field)348			})?;349350			let this = builder.build();351			for (ctx, fctx) in ctxs {352				let _ctx = ctx353					.extend(GcHashMap::new(), None, None, Some(this.clone()))354					.into_future(fctx);355			}356			this357		}358	})359}360361pub fn evaluate_apply(362	ctx: Context,363	value: &LocExpr,364	args: &ArgsDesc,365	loc: CallLocation<'_>,366	tailstrict: bool,367) -> Result<Val> {368	let value = evaluate(ctx.clone(), value)?;369	Ok(match value {370		Val::Func(f) => {371			let body = || f.evaluate(ctx, loc, args, tailstrict);372			if tailstrict {373				body()?374			} else {375				State::push(loc, || format!("function <{}> call", f.name()), body)?376			}377		}378		v => bail!(OnlyFunctionsCanBeCalledGot(v.value_type())),379	})380}381382pub fn evaluate_assert(ctx: Context, assertion: &AssertStmt) -> Result<()> {383	let value = &assertion.0;384	let msg = &assertion.1;385	let assertion_result = State::push(386		CallLocation::new(&value.1),387		|| "assertion condition".to_owned(),388		|| bool::from_untyped(evaluate(ctx.clone(), value)?),389	)?;390	if !assertion_result {391		State::push(392			CallLocation::new(&value.1),393			|| "assertion failure".to_owned(),394			|| {395				if let Some(msg) = msg {396					bail!(AssertionFailed(evaluate(ctx, msg)?.to_string()?));397				}398				bail!(AssertionFailed(Val::Null.to_string()?));399			},400		)?;401	}402	Ok(())403}404405pub fn evaluate_named(ctx: Context, expr: &LocExpr, name: IStr) -> Result<Val> {406	use Expr::*;407	let LocExpr(raw_expr, _loc) = expr;408	Ok(match &**raw_expr {409		Function(params, body) => evaluate_method(ctx, name, params.clone(), body.clone()),410		_ => evaluate(ctx, expr)?,411	})412}413414#[allow(clippy::too_many_lines)]415pub fn evaluate(ctx: Context, expr: &LocExpr) -> Result<Val> {416	use Expr::*;417418	if let Some(trivial) = evaluate_trivial(expr) {419		return Ok(trivial);420	}421	let LocExpr(expr, loc) = expr;422	Ok(match &**expr {423		Literal(LiteralType::This) => {424			Val::Obj(ctx.this().ok_or(CantUseSelfOutsideOfObject)?.clone())425		}426		Literal(LiteralType::Super) => Val::Obj(427			ctx.super_obj().ok_or(NoSuperFound)?.with_this(428				ctx.this()429					.expect("if super exists - then this should too")430					.clone(),431			),432		),433		Literal(LiteralType::Dollar) => {434			Val::Obj(ctx.dollar().ok_or(NoTopLevelObjectFound)?.clone())435		}436		Literal(LiteralType::True) => Val::Bool(true),437		Literal(LiteralType::False) => Val::Bool(false),438		Literal(LiteralType::Null) => Val::Null,439		Parened(e) => evaluate(ctx, e)?,440		Str(v) => Val::string(v.clone()),441		Num(v) => Val::new_checked_num(*v)?,442		BinaryOp(v1, o, v2) => evaluate_binary_op_special(ctx, v1, *o, v2)?,443		UnaryOp(o, v) => evaluate_unary_op(*o, &evaluate(ctx, v)?)?,444		Var(name) => State::push(445			CallLocation::new(loc),446			|| format!("variable <{name}> access"),447			|| ctx.binding(name.clone())?.evaluate(),448		)?,449		Index { indexable, parts } => {450			let mut parts = parts.iter();451			let mut indexable = match &indexable {452				// Cheaper to execute than creating object with overriden `this`453				LocExpr(v, _) if matches!(&**v, Expr::Literal(LiteralType::Super)) => {454					let part = parts.next().expect("at least part should exist");455					let Some(super_obj) = ctx.super_obj() else {456						#[cfg(feature = "exp-null-coaelse")]457						if part.null_coaelse {458							return Ok(Val::Null);459						}460						bail!(NoSuperFound)461					};462					let name = evaluate(ctx.clone(), &part.value)?;463464					let Val::Str(name) = name else {465						bail!(ValueIndexMustBeTypeGot(466							ValType::Obj,467							ValType::Str,468							name.value_type(),469						))470					};471472					let this = ctx473						.this()474						.expect("no this found, while super present, should not happen");475					let name = name.into_flat();476					match super_obj477						.get_for(name.clone(), this.clone())478						.with_description_src(&part.value, || format!("field <{name}> access"))?479					{480						Some(v) => v,481						#[cfg(feature = "exp-null-coaelse")]482						None if part.null_coaelse => return Ok(Val::Null),483						None => {484							let suggestions = suggest_object_fields(super_obj, name.clone());485486							bail!(NoSuchField(name, suggestions))487						}488					}489				}490				e => evaluate(ctx.clone(), e)?,491			};492493			for part in parts {494				indexable = match (indexable, evaluate(ctx.clone(), &part.value)?) {495					(Val::Obj(v), Val::Str(key)) => match v496						.get(key.clone().into_flat())497						.with_description_src(&part.value, || format!("field <{key}> access"))?498					{499						Some(v) => v,500						#[cfg(feature = "exp-null-coaelse")]501						None if part.null_coaelse => return Ok(Val::Null),502						None => {503							let suggestions = suggest_object_fields(&v, key.clone().into_flat());504505							return Err(Error::from(NoSuchField(506								key.clone().into_flat(),507								suggestions,508							)))509							.with_description_src(&part.value, || format!("field <{key}> access"));510						}511					},512					(Val::Obj(_), n) => bail!(ValueIndexMustBeTypeGot(513						ValType::Obj,514						ValType::Str,515						n.value_type(),516					)),517					(Val::Arr(v), Val::Num(n)) => {518						if n.fract() > f64::EPSILON {519							bail!(FractionalIndex)520						}521						if n < 0.0 {522							bail!(ArrayBoundsError(n as isize, v.len()));523						}524						v.get(n as usize)?525							.ok_or_else(|| ArrayBoundsError(n as isize, v.len()))?526					}527					(Val::Arr(_), Val::Str(n)) => {528						bail!(AttemptedIndexAnArrayWithString(n.into_flat()))529					}530					(Val::Arr(_), n) => bail!(ValueIndexMustBeTypeGot(531						ValType::Arr,532						ValType::Num,533						n.value_type(),534					)),535536					(Val::Str(s), Val::Num(n)) => Val::Str({537						let v: IStr = s538							.clone()539							.into_flat()540							.chars()541							.skip(n as usize)542							.take(1)543							.collect::<String>()544							.into();545						if v.is_empty() {546							let size = s.into_flat().chars().count();547							bail!(StringBoundsError(n as usize, size))548						}549						StrValue::Flat(v)550					}),551					(Val::Str(_), n) => bail!(ValueIndexMustBeTypeGot(552						ValType::Str,553						ValType::Num,554						n.value_type(),555					)),556					#[cfg(feature = "exp-null-coaelse")]557					(Val::Null, _) if part.null_coaelse => return Ok(Val::Null),558					(v, _) => bail!(CantIndexInto(v.value_type())),559				};560			}561			indexable562		}563		LocalExpr(bindings, returned) => {564			let mut new_bindings: GcHashMap<IStr, Thunk<Val>> =565				GcHashMap::with_capacity(bindings.iter().map(BindSpec::capacity_hint).sum());566			let fctx = Context::new_future();567			for b in bindings {568				evaluate_dest(b, fctx.clone(), &mut new_bindings)?;569			}570			let ctx = ctx.extend(new_bindings, None, None, None).into_future(fctx);571			evaluate(ctx, &returned.clone())?572		}573		Arr(items) => {574			if items.is_empty() {575				Val::Arr(ArrValue::empty())576			} else if items.len() == 1 {577				#[derive(Trace)]578				struct ArrayElement {579					ctx: Context,580					item: LocExpr,581				}582				impl ThunkValue for ArrayElement {583					type Output = Val;584					fn get(self: Box<Self>) -> Result<Val> {585						evaluate(self.ctx, &self.item)586					}587				}588				Val::Arr(ArrValue::lazy(vec![Thunk::new(ArrayElement {589					ctx,590					item: items[0].clone(),591				})]))592			} else {593				Val::Arr(ArrValue::expr(ctx, items.iter().cloned()))594			}595		}596		ArrComp(expr, comp_specs) => {597			let mut out = Vec::new();598			evaluate_comp(ctx, comp_specs, &mut |ctx| {599				out.push(evaluate(ctx, expr)?);600				Ok(())601			})?;602			Val::Arr(ArrValue::eager(out))603		}604		Obj(body) => Val::Obj(evaluate_object(ctx, body)?),605		ObjExtend(a, b) => evaluate_add_op(606			&evaluate(ctx.clone(), a)?,607			&Val::Obj(evaluate_object(ctx, b)?),608		)?,609		Apply(value, args, tailstrict) => {610			evaluate_apply(ctx, value, args, CallLocation::new(loc), *tailstrict)?611		}612		Function(params, body) => {613			evaluate_method(ctx, "anonymous".into(), params.clone(), body.clone())614		}615		AssertExpr(assert, returned) => {616			evaluate_assert(ctx.clone(), assert)?;617			evaluate(ctx, returned)?618		}619		ErrorStmt(e) => State::push(620			CallLocation::new(loc),621			|| "error statement".to_owned(),622			|| bail!(RuntimeError(evaluate(ctx, e)?.to_string()?,)),623		)?,624		IfElse {625			cond,626			cond_then,627			cond_else,628		} => {629			if State::push(630				CallLocation::new(loc),631				|| "if condition".to_owned(),632				|| bool::from_untyped(evaluate(ctx.clone(), &cond.0)?),633			)? {634				evaluate(ctx, cond_then)?635			} else {636				match cond_else {637					Some(v) => evaluate(ctx, v)?,638					None => Val::Null,639				}640			}641		}642		Slice(value, desc) => {643			fn parse_idx<T: Typed>(644				loc: CallLocation<'_>,645				ctx: &Context,646				expr: Option<&LocExpr>,647				desc: &'static str,648			) -> Result<Option<T>> {649				if let Some(value) = expr {650					Ok(Some(State::push(651						loc,652						|| format!("slice {desc}"),653						|| T::from_untyped(evaluate(ctx.clone(), value)?),654					)?))655				} else {656					Ok(None)657				}658			}659660			let indexable = evaluate(ctx.clone(), value)?;661			let loc = CallLocation::new(loc);662663			let start = parse_idx(loc, &ctx, desc.start.as_ref(), "start")?;664			let end = parse_idx(loc, &ctx, desc.end.as_ref(), "end")?;665			let step = parse_idx(loc, &ctx, desc.step.as_ref(), "step")?;666667			IndexableVal::into_untyped(indexable.into_indexable()?.slice(start, end, step)?)?668		}669		i @ (Import(path) | ImportStr(path) | ImportBin(path)) => {670			let Expr::Str(path) = &*path.0 else {671				bail!("computed imports are not supported")672			};673			let tmp = loc.clone().0;674			let s = ctx.state();675			let resolved_path = s.resolve_from(tmp.source_path(), path as &str)?;676			match i {677				Import(_) => State::push(678					CallLocation::new(loc),679					|| format!("import {:?}", path.clone()),680					|| s.import_resolved(resolved_path),681				)?,682				ImportStr(_) => Val::string(s.import_resolved_str(resolved_path)?),683				ImportBin(_) => Val::Arr(ArrValue::bytes(s.import_resolved_bin(resolved_path)?)),684				_ => unreachable!(),685			}686		}687	})688}