difftreelog
feat field destructuring
in: master
22 files changed
bindings/jsonnet/src/native.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/native.rs
+++ b/bindings/jsonnet/src/native.rs
@@ -9,7 +9,7 @@
use jrsonnet_evaluator::{
error::{Error, LocError},
function::builtin::{BuiltinParam, NativeCallback, NativeCallbackHandler},
- gc::TraceBox,
+ tb,
typed::Typed,
IStr, State, Val,
};
@@ -78,9 +78,9 @@
vm.add_native(
name,
#[allow(deprecated)]
- Cc::new(TraceBox(Box::new(NativeCallback::new(
+ Cc::new(tb!(NativeCallback::new(
params,
- TraceBox(Box::new(JsonnetNativeCallbackHandler { ctx, cb })),
- )))),
+ tb!(JsonnetNativeCallbackHandler { ctx, cb }),
+ ))),
)
}
bindings/jsonnet/src/val_modify.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/val_modify.rs
+++ b/bindings/jsonnet/src/val_modify.rs
@@ -5,7 +5,7 @@
use std::{ffi::CStr, os::raw::c_char};
use gcmodule::Cc;
-use jrsonnet_evaluator::{val::ArrValue, LazyVal, State, Val};
+use jrsonnet_evaluator::{val::ArrValue, State, Thunk, Val};
/// # Safety
///
@@ -18,7 +18,8 @@
for item in old.iter_lazy() {
new.push(item);
}
- new.push(LazyVal::new_resolved(val.clone()));
+
+ new.push(Thunk::evaluated(val.clone()));
*arr = Val::Arr(ArrValue::Lazy(Cc::new(new)));
}
_ => panic!("should receive array"),
cmds/jrsonnet/Cargo.tomldiffbeforeafterboth--- a/cmds/jrsonnet/Cargo.toml
+++ b/cmds/jrsonnet/Cargo.toml
@@ -16,6 +16,8 @@
"jrsonnet-evaluator/exp-serde-preserve-order",
"jrsonnet-cli/exp-preserve-order",
]
+# Destructuring of locals
+exp-destruct = ["jrsonnet-evaluator/exp-destruct"]
[dependencies]
jrsonnet-evaluator = { path = "../../crates/jrsonnet-evaluator", version = "0.4.2" }
crates/jrsonnet-evaluator/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-evaluator/Cargo.toml
+++ b/crates/jrsonnet-evaluator/Cargo.toml
@@ -18,6 +18,8 @@
# Allows to preserve field order in objects
exp-preserve-order = []
exp-serde-preserve-order = ["serde_json/preserve_order"]
+# Implements field destructuring
+exp-destruct = []
[dependencies]
jrsonnet-interner = { path = "../jrsonnet-interner", version = "0.4.2" }
crates/jrsonnet-evaluator/src/ctx.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/ctx.rs
+++ b/crates/jrsonnet-evaluator/src/ctx.rs
@@ -4,12 +4,12 @@
use jrsonnet_interner::IStr;
use crate::{
- cc_ptr_eq, error::Error::*, gc::GcHashMap, map::LayeredHashMap, FutureWrapper, LazyBinding,
- LazyVal, ObjValue, Result, State, Val,
+ cc_ptr_eq, error::Error::*, gc::GcHashMap, map::LayeredHashMap, LazyBinding, ObjValue, Pending,
+ Result, State, Thunk, Val,
};
#[derive(Clone, Trace)]
-pub struct ContextCreator(pub Context, pub FutureWrapper<GcHashMap<IStr, LazyBinding>>);
+pub struct ContextCreator(pub Context, pub Pending<GcHashMap<IStr, LazyBinding>>);
impl ContextCreator {
pub fn create(
&self,
@@ -43,8 +43,8 @@
#[derive(Debug, Clone, Trace)]
pub struct Context(Cc<ContextInternals>);
impl Context {
- pub fn new_future() -> FutureWrapper<Self> {
- FutureWrapper::new()
+ pub fn new_future() -> Pending<Self> {
+ Pending::new()
}
pub fn dollar(&self) -> &Option<ObjValue> {
@@ -68,7 +68,7 @@
}))
}
- pub fn binding(&self, name: IStr) -> Result<LazyVal> {
+ pub fn binding(&self, name: IStr) -> Result<Thunk<Val>> {
Ok(self
.0
.bindings
@@ -80,7 +80,7 @@
self.0.bindings.contains_key(&name)
}
#[must_use]
- pub fn into_future(self, ctx: FutureWrapper<Self>) -> Self {
+ pub fn into_future(self, ctx: Pending<Self>) -> Self {
{
ctx.0.borrow_mut().replace(self);
}
@@ -90,7 +90,7 @@
#[must_use]
pub fn with_var(self, name: IStr, value: Val) -> Self {
let mut new_bindings = GcHashMap::with_capacity(1);
- new_bindings.insert(name, LazyVal::new_resolved(value));
+ new_bindings.insert(name, Thunk::evaluated(value));
self.extend(new_bindings, None, None, None)
}
@@ -102,7 +102,7 @@
#[must_use]
pub fn extend(
self,
- new_bindings: GcHashMap<IStr, LazyVal>,
+ new_bindings: GcHashMap<IStr, Thunk<Val>>,
new_dollar: Option<ObjValue>,
new_this: Option<ObjValue>,
new_super_obj: Option<ObjValue>,
@@ -124,7 +124,7 @@
}))
}
#[must_use]
- pub fn extend_bound(self, new_bindings: GcHashMap<IStr, LazyVal>) -> Self {
+ pub fn extend_bound(self, new_bindings: GcHashMap<IStr, Thunk<Val>>) -> Self {
let new_this = self.0.this.clone();
let new_super_obj = self.0.super_obj.clone();
self.extend(new_bindings, None, new_this, new_super_obj)
crates/jrsonnet-evaluator/src/dynamic.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/dynamic.rs
+++ b/crates/jrsonnet-evaluator/src/dynamic.rs
@@ -3,8 +3,8 @@
use gcmodule::{Cc, Trace};
#[derive(Clone, Trace)]
-pub struct FutureWrapper<V: Trace + 'static>(pub Cc<RefCell<Option<V>>>);
-impl<T: Trace + 'static> FutureWrapper<T> {
+pub struct Pending<V: Trace + 'static>(pub Cc<RefCell<Option<V>>>);
+impl<T: Trace + 'static> Pending<T> {
pub fn new() -> Self {
Self(Cc::new(RefCell::new(None)))
}
@@ -15,7 +15,7 @@
self.0.borrow_mut().replace(value);
}
}
-impl<T: Clone + Trace + 'static> FutureWrapper<T> {
+impl<T: Clone + Trace + 'static> Pending<T> {
/// # Panics
/// If wrapper is not yet filled
pub fn unwrap(&self) -> T {
@@ -23,7 +23,7 @@
}
}
-impl<T: Trace + 'static> Default for FutureWrapper<T> {
+impl<T: Trace + 'static> Default for Pending<T> {
fn default() -> Self {
Self::new()
}
crates/jrsonnet-evaluator/src/error.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/error.rs
+++ b/crates/jrsonnet-evaluator/src/error.rs
@@ -45,6 +45,9 @@
#[error("variable is not defined: {0}")]
VariableIsNotDefined(IStr),
+ #[error("duplicate local var: {0}")]
+ DuplicateLocalVar(IStr),
+
#[error("type mismatch: expected {}, got {2} {0}", .1.iter().map(|e| format!("{}", e)).collect::<Vec<_>>().join(", "))]
TypeMismatch(&'static str, Vec<ValType>, ValType),
#[error("no such field: {0}")]
crates/jrsonnet-evaluator/src/evaluate/destructure.rsdiffbeforeafterboth--- /dev/null
+++ b/crates/jrsonnet-evaluator/src/evaluate/destructure.rs
@@ -0,0 +1,294 @@
+use gcmodule::Trace;
+use jrsonnet_interner::IStr;
+use jrsonnet_parser::{BindSpec, Destruct, LocExpr, ParamsDesc};
+
+use crate::{
+ error::{Error::*, Result},
+ evaluate, evaluate_method,
+ gc::GcHashMap,
+ tb, throw,
+ val::ThunkValue,
+ Context, Pending, State, Thunk, Val,
+};
+
+fn destruct(
+ d: &Destruct,
+ parent: Thunk<Val>,
+ new_bindings: &mut GcHashMap<IStr, Thunk<Val>>,
+) -> Result<()> {
+ Ok(match d {
+ Destruct::Full(v) => {
+ let old = new_bindings.insert(v.clone(), parent);
+ if old.is_some() {
+ throw!(DuplicateLocalVar(v.clone()))
+ }
+ }
+ #[cfg(feature = "exp-destruct")]
+ Destruct::Skip => {}
+ #[cfg(feature = "exp-destruct")]
+ Destruct::Array { start, rest, end } => {
+ use jrsonnet_parser::DestructRest;
+
+ use crate::{throw_runtime, val::ArrValue};
+
+ #[derive(Trace)]
+ struct DataThunk {
+ parent: Thunk<Val>,
+ min_len: usize,
+ has_rest: bool,
+ }
+ impl ThunkValue for DataThunk {
+ type Output = ArrValue;
+
+ fn get(self: Box<Self>, s: State) -> Result<Self::Output> {
+ let v = self.parent.evaluate(s)?;
+ let arr = match v {
+ Val::Arr(a) => a,
+ _ => throw_runtime!("expected array"),
+ };
+ if !self.has_rest {
+ if arr.len() != self.min_len {
+ throw_runtime!("expected {} elements, got {}", self.min_len, arr.len())
+ }
+ } else if arr.len() < self.min_len {
+ throw_runtime!(
+ "expected at least {} elements, but array was only {}",
+ self.min_len,
+ arr.len()
+ )
+ }
+ Ok(arr)
+ }
+ }
+
+ let full = Thunk::new(tb!(DataThunk {
+ min_len: start.len() + end.len(),
+ has_rest: rest.is_some(),
+ parent,
+ }));
+
+ {
+ #[derive(Trace)]
+ struct BaseThunk {
+ full: Thunk<ArrValue>,
+ index: usize,
+ }
+ impl ThunkValue for BaseThunk {
+ type Output = Val;
+
+ fn get(self: Box<Self>, s: State) -> Result<Self::Output> {
+ let full = self.full.evaluate(s.clone())?;
+ Ok(full.get(s, self.index)?.expect("length is checked"))
+ }
+ }
+ for (i, d) in start.iter().enumerate() {
+ destruct(
+ d,
+ Thunk::new(tb!(BaseThunk {
+ full: full.clone(),
+ index: i,
+ })),
+ new_bindings,
+ )?;
+ }
+ }
+
+ match rest {
+ Some(DestructRest::Keep(v)) => {
+ #[derive(Trace)]
+ struct RestThunk {
+ full: Thunk<ArrValue>,
+ start: usize,
+ end: usize,
+ }
+ impl ThunkValue for RestThunk {
+ type Output = Val;
+
+ fn get(self: Box<Self>, s: State) -> Result<Self::Output> {
+ let full = self.full.evaluate(s)?;
+ let to = full.len() - self.end;
+ Ok(Val::Arr(full.slice(Some(self.start), Some(to), None)))
+ }
+ }
+
+ destruct(
+ &Destruct::Full(v.clone()),
+ Thunk::new(tb!(RestThunk {
+ full: full.clone(),
+ start: start.len(),
+ end: end.len(),
+ })),
+ new_bindings,
+ )?;
+ }
+ Some(DestructRest::Drop) => {}
+ None => {}
+ }
+
+ {
+ #[derive(Trace)]
+ struct EndThunk {
+ full: Thunk<ArrValue>,
+ index: usize,
+ end: usize,
+ }
+ impl ThunkValue for EndThunk {
+ type Output = Val;
+
+ fn get(self: Box<Self>, s: State) -> Result<Self::Output> {
+ let full = self.full.evaluate(s.clone())?;
+ Ok(full
+ .get(s, full.len() - self.end + self.index)?
+ .expect("length is checked"))
+ }
+ }
+ for (i, d) in end.iter().enumerate() {
+ destruct(
+ d,
+ Thunk::new(tb!(EndThunk {
+ full: full.clone(),
+ index: i,
+ end: end.len(),
+ })),
+ new_bindings,
+ )?;
+ }
+ }
+ }
+ #[cfg(feature = "exp-destruct")]
+ Destruct::Object { fields, rest } => {
+ use jrsonnet_parser::DestructRest;
+
+ use crate::{obj::ObjValue, throw_runtime};
+
+ #[derive(Trace)]
+ struct DataThunk {
+ parent: Thunk<Val>,
+ field_names: Vec<IStr>,
+ has_rest: bool,
+ }
+ impl ThunkValue for DataThunk {
+ type Output = ObjValue;
+
+ fn get(self: Box<Self>, s: State) -> Result<Self::Output> {
+ let v = self.parent.evaluate(s)?;
+ let obj = match v {
+ Val::Obj(o) => o,
+ _ => throw_runtime!("expected object"),
+ };
+ for field in &self.field_names {
+ if !obj.has_field_ex(field.clone(), true) {
+ throw_runtime!("missing field: {}", field);
+ }
+ }
+ if !self.has_rest {
+ let len = obj.len();
+ if len != self.field_names.len() {
+ throw_runtime!("too many fields, and rest not found");
+ }
+ }
+ Ok(obj)
+ }
+ }
+ let field_names: Vec<_> = fields.iter().map(|f| f.0.clone()).collect();
+ let full = Thunk::new(tb!(DataThunk {
+ parent,
+ field_names: field_names.clone(),
+ has_rest: rest.is_some()
+ }));
+
+ for (field, d) in fields {
+ #[derive(Trace)]
+ struct FieldThunk {
+ full: Thunk<ObjValue>,
+ field: IStr,
+ }
+ impl ThunkValue for FieldThunk {
+ type Output = Val;
+
+ fn get(self: Box<Self>, s: State) -> Result<Self::Output> {
+ let full = self.full.evaluate(s.clone())?;
+ let field = full.get(s, self.field)?.expect("shape is checked");
+ Ok(field)
+ }
+ }
+ let value = Thunk::new(tb!(FieldThunk {
+ full: full.clone(),
+ field: field.clone()
+ }));
+ if let Some(d) = d {
+ destruct(d, value, new_bindings)?;
+ } else {
+ destruct(&Destruct::Full(field.clone()), value, new_bindings)?;
+ }
+ }
+ }
+ })
+}
+
+pub fn evaluate_dest(
+ d: &BindSpec,
+ fctx: Pending<Context>,
+ new_bindings: &mut GcHashMap<IStr, Thunk<Val>>,
+) -> Result<()> {
+ match d {
+ BindSpec::Field { into, value } => {
+ #[derive(Trace)]
+ struct EvaluateThunkValue {
+ fctx: Pending<Context>,
+ expr: LocExpr,
+ }
+ impl ThunkValue for EvaluateThunkValue {
+ type Output = Val;
+ fn get(self: Box<Self>, s: State) -> Result<Self::Output> {
+ evaluate(s, self.fctx.unwrap(), &self.expr)
+ }
+ }
+ // TODO: Generate some name, as destructure spec may be used with plain functions
+ let data = Thunk::new(tb!(EvaluateThunkValue {
+ fctx,
+ expr: value.clone(),
+ }));
+ destruct(into, data, new_bindings)?;
+ }
+ BindSpec::Function {
+ name,
+ params,
+ value,
+ } => {
+ #[derive(Trace)]
+ struct MethodThunk {
+ fctx: Pending<Context>,
+ name: IStr,
+ params: ParamsDesc,
+ value: LocExpr,
+ }
+ impl ThunkValue for MethodThunk {
+ type Output = Val;
+
+ fn get(self: Box<Self>, _s: State) -> Result<Self::Output> {
+ Ok(evaluate_method(
+ self.fctx.unwrap(),
+ self.name,
+ self.params,
+ self.value,
+ ))
+ }
+ }
+
+ let old = new_bindings.insert(
+ name.clone(),
+ Thunk::new(tb!(MethodThunk {
+ fctx,
+ name: name.clone(),
+ params: params.clone(),
+ value: value.clone()
+ })),
+ );
+ if old.is_some() {
+ throw!(DuplicateLocalVar(name.clone()))
+ }
+ }
+ }
+ Ok(())
+}
crates/jrsonnet-evaluator/src/evaluate/mod.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate/mod.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/mod.rs
@@ -1,189 +1,157 @@
use gcmodule::{Cc, Trace};
use jrsonnet_interner::IStr;
use jrsonnet_parser::{
- ArgsDesc, AssertStmt, BindSpec, CompSpec, Expr, FieldMember, ForSpecData, IfSpecData,
+ ArgsDesc, AssertStmt, BindSpec, CompSpec, Destruct, Expr, FieldMember, ForSpecData, IfSpecData,
LiteralType, LocExpr, Member, ObjBody, ParamsDesc,
};
use jrsonnet_types::ValType;
use crate::{
+ destructure::evaluate_dest,
error::Error::*,
evaluate::operator::{evaluate_add_op, evaluate_binary_op_special, evaluate_unary_op},
function::{CallLocation, FuncDesc, FuncVal},
- gc::TraceBox,
stdlib::{std_slice, BUILTINS},
- throw,
+ tb, throw,
typed::Typed,
- val::{ArrValue, LazyValValue},
- Bindable, Context, ContextCreator, FutureWrapper, GcHashMap, LazyBinding, LazyVal, ObjValue,
- ObjValueBuilder, ObjectAssertion, Result, State, Val,
+ val::{ArrValue, Thunk, ThunkValue},
+ Bindable, Context, ContextCreator, GcHashMap, LazyBinding, ObjValue, ObjValueBuilder,
+ ObjectAssertion, Pending, Result, State, Val,
};
+pub mod destructure;
pub mod operator;
-pub fn evaluate_binding_in_future(b: &BindSpec, fctx: FutureWrapper<Context>) -> LazyVal {
- let b = b.clone();
- if let Some(params) = &b.params {
- #[derive(Trace)]
- struct LazyMethodBinding {
- fctx: FutureWrapper<Context>,
- name: IStr,
- params: ParamsDesc,
- value: LocExpr,
- }
- impl LazyValValue for LazyMethodBinding {
- fn get(self: Box<Self>, _: State) -> Result<Val> {
- Ok(evaluate_method(
- self.fctx.unwrap(),
- self.name,
- self.params,
- self.value,
- ))
+#[allow(clippy::too_many_lines)]
+pub fn evaluate_binding(b: BindSpec, cctx: ContextCreator) -> Result<(IStr, LazyBinding)> {
+ match b {
+ BindSpec::Field {
+ into: Destruct::Full(name),
+ value,
+ } => {
+ #[derive(Trace)]
+ struct BindableNamedThunk {
+ this: Option<ObjValue>,
+ super_obj: Option<ObjValue>,
+
+ cctx: ContextCreator,
+ name: IStr,
+ value: LocExpr,
}
- }
+ impl ThunkValue for BindableNamedThunk {
+ type Output = Val;
+ fn get(self: Box<Self>, s: State) -> Result<Val> {
+ evaluate_named(
+ s.clone(),
+ self.cctx.create(s, self.this, self.super_obj)?,
+ &self.value,
+ self.name,
+ )
+ }
+ }
- let params = params.clone();
+ #[derive(Trace)]
+ struct BindableNamed {
+ cctx: ContextCreator,
+ name: IStr,
+ value: LocExpr,
+ }
+ impl Bindable for BindableNamed {
+ fn bind(
+ &self,
+ _: State,
+ this: Option<ObjValue>,
+ super_obj: Option<ObjValue>,
+ ) -> Result<Thunk<Val>> {
+ Ok(Thunk::new(tb!(BindableNamedThunk {
+ this,
+ super_obj,
- LazyVal::new(TraceBox(Box::new(LazyMethodBinding {
- fctx,
- name: b.name.clone(),
- params,
- value: b.value.clone(),
- })))
- } else {
- #[derive(Trace)]
- struct LazyNamedBinding {
- fctx: FutureWrapper<Context>,
- name: IStr,
- value: LocExpr,
- }
- impl LazyValValue for LazyNamedBinding {
- fn get(self: Box<Self>, s: State) -> Result<Val> {
- evaluate_named(s, self.fctx.unwrap(), &self.value, self.name)
+ cctx: self.cctx.clone(),
+ name: self.name.clone(),
+ value: self.value.clone(),
+ })))
+ }
}
- }
- LazyVal::new(TraceBox(Box::new(LazyNamedBinding {
- fctx,
- name: b.name.clone(),
- value: b.value,
- })))
- }
-}
-#[allow(clippy::too_many_lines)]
-pub fn evaluate_binding(b: &BindSpec, cctx: ContextCreator) -> (IStr, LazyBinding) {
- let b = b.clone();
- if let Some(params) = &b.params {
- #[derive(Trace)]
- struct BindableMethodLazyVal {
- this: Option<ObjValue>,
- super_obj: Option<ObjValue>,
-
- cctx: ContextCreator,
- name: IStr,
- params: ParamsDesc,
- value: LocExpr,
- }
- impl LazyValValue for BindableMethodLazyVal {
- fn get(self: Box<Self>, s: State) -> Result<Val> {
- Ok(evaluate_method(
- self.cctx.create(s, self.this, self.super_obj)?,
- self.name,
- self.params,
- self.value,
- ))
- }
+ Ok((
+ name.clone(),
+ LazyBinding::Bindable(Cc::new(tb!(BindableNamed {
+ cctx,
+ name: name.clone(),
+ value: value.clone(),
+ }))),
+ ))
}
-
- #[derive(Trace)]
- struct BindableMethod {
- cctx: ContextCreator,
- name: IStr,
- params: ParamsDesc,
- value: LocExpr,
+ #[cfg(feature = "exp-destruct")]
+ BindSpec::Field { into: _, .. } => {
+ use crate::throw_runtime;
+ throw_runtime!("destructuring is not yet supported here")
}
- impl Bindable for BindableMethod {
- fn bind(
- &self,
- _: State,
+ BindSpec::Function {
+ name,
+ params,
+ value,
+ } => {
+ #[derive(Trace)]
+ struct BindableMethodThunk {
this: Option<ObjValue>,
super_obj: Option<ObjValue>,
- ) -> Result<LazyVal> {
- Ok(LazyVal::new(TraceBox(Box::new(BindableMethodLazyVal {
- this,
- super_obj,
- cctx: self.cctx.clone(),
- name: self.name.clone(),
- params: self.params.clone(),
- value: self.value.clone(),
- }))))
+ cctx: ContextCreator,
+ name: IStr,
+ params: ParamsDesc,
+ value: LocExpr,
}
- }
+ impl ThunkValue for BindableMethodThunk {
+ type Output = Val;
+ fn get(self: Box<Self>, s: State) -> Result<Val> {
+ Ok(evaluate_method(
+ self.cctx.create(s, self.this, self.super_obj)?,
+ self.name,
+ self.params,
+ self.value,
+ ))
+ }
+ }
- let params = params.clone();
-
- (
- b.name.clone(),
- LazyBinding::Bindable(Cc::new(TraceBox(Box::new(BindableMethod {
- cctx,
- name: b.name.clone(),
- params,
- value: b.value.clone(),
- })))),
- )
- } else {
- #[derive(Trace)]
- struct BindableNamedLazyVal {
- this: Option<ObjValue>,
- super_obj: Option<ObjValue>,
+ #[derive(Trace)]
+ struct BindableMethod {
+ cctx: ContextCreator,
+ name: IStr,
+ params: ParamsDesc,
+ value: LocExpr,
+ }
+ impl Bindable for BindableMethod {
+ fn bind(
+ &self,
+ _: State,
+ this: Option<ObjValue>,
+ super_obj: Option<ObjValue>,
+ ) -> Result<Thunk<Val>> {
+ Ok(Thunk::<Val>::new(tb!(BindableMethodThunk {
+ this,
+ super_obj,
- cctx: ContextCreator,
- name: IStr,
- value: LocExpr,
- }
- impl LazyValValue for BindableNamedLazyVal {
- fn get(self: Box<Self>, s: State) -> Result<Val> {
- evaluate_named(
- s.clone(),
- self.cctx.create(s, self.this, self.super_obj)?,
- &self.value,
- self.name,
- )
+ cctx: self.cctx.clone(),
+ name: self.name.clone(),
+ params: self.params.clone(),
+ value: self.value.clone(),
+ })))
+ }
}
- }
- #[derive(Trace)]
- struct BindableNamed {
- cctx: ContextCreator,
- name: IStr,
- value: LocExpr,
- }
- impl Bindable for BindableNamed {
- fn bind(
- &self,
- _: State,
- this: Option<ObjValue>,
- super_obj: Option<ObjValue>,
- ) -> Result<LazyVal> {
- Ok(LazyVal::new(TraceBox(Box::new(BindableNamedLazyVal {
- this,
- super_obj,
+ let params = params.clone();
- cctx: self.cctx.clone(),
- name: self.name.clone(),
- value: self.value.clone(),
- }))))
- }
+ Ok((
+ name.clone(),
+ LazyBinding::Bindable(Cc::new(tb!(BindableMethod {
+ cctx,
+ name: name.clone(),
+ params,
+ value,
+ }))),
+ ))
}
-
- (
- b.name.clone(),
- LazyBinding::Bindable(Cc::new(TraceBox(Box::new(BindableNamed {
- cctx,
- name: b.name.clone(),
- value: b.value.clone(),
- })))),
- )
}
}
@@ -252,19 +220,20 @@
#[allow(clippy::too_many_lines)]
pub fn evaluate_member_list_object(s: State, ctx: Context, members: &[Member]) -> Result<ObjValue> {
- let new_bindings = FutureWrapper::new();
- let future_this = FutureWrapper::new();
+ let new_bindings = Pending::new();
+ let future_this = Pending::new();
let cctx = ContextCreator(ctx.clone(), new_bindings.clone());
{
let mut bindings: GcHashMap<IStr, LazyBinding> = GcHashMap::with_capacity(members.len());
- for (n, b) in members
+ for r in members
.iter()
.filter_map(|m| match m {
Member::BindStmt(b) => Some(b.clone()),
_ => None,
})
- .map(|b| evaluate_binding(&b, cctx.clone()))
+ .map(|b| evaluate_binding(b.clone(), cctx.clone()))
{
+ let (n, b) = r?;
bindings.insert(n, b);
}
new_bindings.fill(bindings);
@@ -292,8 +261,8 @@
s: State,
this: Option<ObjValue>,
super_obj: Option<ObjValue>,
- ) -> Result<LazyVal> {
- Ok(LazyVal::new_resolved(evaluate_named(
+ ) -> Result<Thunk<Val>> {
+ Ok(Thunk::evaluated(evaluate_named(
s.clone(),
self.cctx.create(s, this, super_obj)?,
&self.value,
@@ -316,11 +285,11 @@
.with_location(value.1.clone())
.bindable(
s.clone(),
- TraceBox(Box::new(ObjMemberBinding {
+ tb!(ObjMemberBinding {
cctx: cctx.clone(),
value: value.clone(),
name,
- })),
+ }),
)?;
}
Member::Field(FieldMember {
@@ -342,8 +311,8 @@
s: State,
this: Option<ObjValue>,
super_obj: Option<ObjValue>,
- ) -> Result<LazyVal> {
- Ok(LazyVal::new_resolved(evaluate_method(
+ ) -> Result<Thunk<Val>> {
+ Ok(Thunk::evaluated(evaluate_method(
self.cctx.create(s, this, super_obj)?,
self.name.clone(),
self.params.clone(),
@@ -364,12 +333,12 @@
.with_location(value.1.clone())
.bindable(
s.clone(),
- TraceBox(Box::new(ObjMemberBinding {
+ tb!(ObjMemberBinding {
cctx: cctx.clone(),
value: value.clone(),
params: params.clone(),
name,
- })),
+ }),
)?;
}
Member::BindStmt(_) => {}
@@ -390,10 +359,10 @@
evaluate_assert(s, ctx, &self.assert)
}
}
- builder.assert(TraceBox(Box::new(ObjectAssert {
+ builder.assert(tb!(ObjectAssert {
cctx: cctx.clone(),
assert: stmt.clone(),
- })));
+ }));
}
}
}
@@ -406,19 +375,20 @@
Ok(match object {
ObjBody::MemberList(members) => evaluate_member_list_object(s, ctx, members)?,
ObjBody::ObjComp(obj) => {
- let future_this = FutureWrapper::new();
+ let future_this = Pending::new();
let mut builder = ObjValueBuilder::new();
evaluate_comp(s.clone(), ctx, &obj.compspecs, &mut |ctx| {
- let new_bindings = FutureWrapper::new();
+ let new_bindings = Pending::new();
let cctx = ContextCreator(ctx.clone(), new_bindings.clone());
let mut bindings: GcHashMap<IStr, LazyBinding> =
GcHashMap::with_capacity(obj.pre_locals.len() + obj.post_locals.len());
- for (n, b) in obj
+ for r in obj
.pre_locals
.iter()
.chain(obj.post_locals.iter())
- .map(|b| evaluate_binding(b, cctx.clone()))
+ .map(|b| evaluate_binding(b.clone(), cctx.clone()))
{
+ let (n, b) = r?;
bindings.insert(n, b);
}
new_bindings.fill(bindings.clone());
@@ -439,8 +409,8 @@
s: State,
this: Option<ObjValue>,
_super_obj: Option<ObjValue>,
- ) -> Result<LazyVal> {
- Ok(LazyVal::new_resolved(evaluate(
+ ) -> Result<Thunk<Val>> {
+ Ok(Thunk::evaluated(evaluate(
s,
self.ctx.clone().extend(GcHashMap::new(), None, this, None),
&self.value,
@@ -453,10 +423,10 @@
.with_add(obj.plus)
.bindable(
s.clone(),
- TraceBox(Box::new(ObjCompBinding {
+ tb!(ObjCompBinding {
ctx,
value: obj.value.clone(),
- })),
+ }),
)?;
}
v => throw!(FieldMustBeStringGot(v.value_type())),
@@ -620,11 +590,11 @@
}
}
LocalExpr(bindings, returned) => {
- let mut new_bindings: GcHashMap<IStr, LazyVal> =
+ let mut new_bindings: GcHashMap<IStr, Thunk<Val>> =
GcHashMap::with_capacity(bindings.len());
let fctx = Context::new_future();
for b in bindings {
- new_bindings.insert(b.name.clone(), evaluate_binding_in_future(b, fctx.clone()));
+ evaluate_dest(b, fctx.clone(), &mut new_bindings)?;
}
let ctx = ctx.extend_bound(new_bindings).into_future(fctx);
evaluate(s, ctx, &returned.clone())?
@@ -638,15 +608,16 @@
ctx: Context,
item: LocExpr,
}
- impl LazyValValue for ArrayElement {
+ impl ThunkValue for ArrayElement {
+ type Output = Val;
fn get(self: Box<Self>, s: State) -> Result<Val> {
evaluate(s, self.ctx, &self.item)
}
}
- out.push(LazyVal::new(TraceBox(Box::new(ArrayElement {
+ out.push(Thunk::new(tb!(ArrayElement {
ctx: ctx.clone(),
item: item.clone(),
- }))));
+ })));
}
Val::Arr(out.into())
}
crates/jrsonnet-evaluator/src/function/arglike.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/arglike.rs
+++ b/crates/jrsonnet-evaluator/src/function/arglike.rs
@@ -5,34 +5,34 @@
use jrsonnet_parser::{ArgsDesc, LocExpr};
use crate::{
- error::Result, evaluate, gc::TraceBox, typed::Typed, val::LazyValValue, Context, LazyVal,
- State, Val,
+ error::Result, evaluate, tb, typed::Typed, val::ThunkValue, Context, State, Thunk, Val,
};
#[derive(Trace)]
-struct EvaluateLazyVal {
+struct EvaluateThunk {
ctx: Context,
expr: LocExpr,
}
-impl LazyValValue for EvaluateLazyVal {
+impl ThunkValue for EvaluateThunk {
+ type Output = Val;
fn get(self: Box<Self>, s: State) -> Result<Val> {
evaluate(s, self.ctx, &self.expr)
}
}
pub trait ArgLike {
- fn evaluate_arg(&self, s: State, ctx: Context, tailstrict: bool) -> Result<LazyVal>;
+ fn evaluate_arg(&self, s: State, ctx: Context, tailstrict: bool) -> Result<Thunk<Val>>;
}
impl ArgLike for &LocExpr {
- fn evaluate_arg(&self, s: State, ctx: Context, tailstrict: bool) -> Result<LazyVal> {
+ fn evaluate_arg(&self, s: State, ctx: Context, tailstrict: bool) -> Result<Thunk<Val>> {
Ok(if tailstrict {
- LazyVal::new_resolved(evaluate(s, ctx, self)?)
+ Thunk::evaluated(evaluate(s, ctx, self)?)
} else {
- LazyVal::new(TraceBox(Box::new(EvaluateLazyVal {
+ Thunk::new(tb!(EvaluateThunk {
ctx,
expr: (*self).clone(),
- })))
+ }))
})
}
}
@@ -41,9 +41,9 @@
where
T: Typed + Clone,
{
- fn evaluate_arg(&self, s: State, _ctx: Context, _tailstrict: bool) -> Result<LazyVal> {
+ fn evaluate_arg(&self, s: State, _ctx: Context, _tailstrict: bool) -> Result<Thunk<Val>> {
let val = T::into_untyped(self.clone(), s)?;
- Ok(LazyVal::new_resolved(val))
+ Ok(Thunk::evaluated(val))
}
}
@@ -53,18 +53,18 @@
Val(Val),
}
impl ArgLike for TlaArg {
- fn evaluate_arg(&self, s: State, ctx: Context, tailstrict: bool) -> Result<LazyVal> {
+ fn evaluate_arg(&self, s: State, ctx: Context, tailstrict: bool) -> Result<Thunk<Val>> {
match self {
- TlaArg::String(s) => Ok(LazyVal::new_resolved(Val::Str(s.clone()))),
+ TlaArg::String(s) => Ok(Thunk::evaluated(Val::Str(s.clone()))),
TlaArg::Code(code) => Ok(if tailstrict {
- LazyVal::new_resolved(evaluate(s, ctx, code)?)
+ Thunk::evaluated(evaluate(s, ctx, code)?)
} else {
- LazyVal::new(TraceBox(Box::new(EvaluateLazyVal {
+ Thunk::new(tb!(EvaluateThunk {
ctx,
expr: code.clone(),
- })))
+ }))
}),
- TlaArg::Val(val) => Ok(LazyVal::new_resolved(val.clone())),
+ TlaArg::Val(val) => Ok(Thunk::evaluated(val.clone())),
}
}
}
@@ -83,14 +83,14 @@
s: State,
ctx: Context,
tailstrict: bool,
- handler: &mut dyn FnMut(usize, LazyVal) -> Result<()>,
+ handler: &mut dyn FnMut(usize, Thunk<Val>) -> Result<()>,
) -> Result<()>;
fn named_iter(
&self,
s: State,
ctx: Context,
tailstrict: bool,
- handler: &mut dyn FnMut(&IStr, LazyVal) -> Result<()>,
+ handler: &mut dyn FnMut(&IStr, Thunk<Val>) -> Result<()>,
) -> Result<()>;
fn named_names(&self, handler: &mut dyn FnMut(&IStr));
}
@@ -105,18 +105,18 @@
s: State,
ctx: Context,
tailstrict: bool,
- handler: &mut dyn FnMut(usize, LazyVal) -> Result<()>,
+ handler: &mut dyn FnMut(usize, Thunk<Val>) -> Result<()>,
) -> Result<()> {
for (id, arg) in self.unnamed.iter().enumerate() {
handler(
id,
if tailstrict {
- LazyVal::new_resolved(evaluate(s.clone(), ctx.clone(), arg)?)
+ Thunk::evaluated(evaluate(s.clone(), ctx.clone(), arg)?)
} else {
- LazyVal::new(TraceBox(Box::new(EvaluateLazyVal {
+ Thunk::new(tb!(EvaluateThunk {
ctx: ctx.clone(),
expr: arg.clone(),
- })))
+ }))
},
)?;
}
@@ -128,18 +128,18 @@
s: State,
ctx: Context,
tailstrict: bool,
- handler: &mut dyn FnMut(&IStr, LazyVal) -> Result<()>,
+ handler: &mut dyn FnMut(&IStr, Thunk<Val>) -> Result<()>,
) -> Result<()> {
for (name, arg) in &self.named {
handler(
name,
if tailstrict {
- LazyVal::new_resolved(evaluate(s.clone(), ctx.clone(), arg)?)
+ Thunk::evaluated(evaluate(s.clone(), ctx.clone(), arg)?)
} else {
- LazyVal::new(TraceBox(Box::new(EvaluateLazyVal {
+ Thunk::new(tb!(EvaluateThunk {
ctx: ctx.clone(),
expr: arg.clone(),
- })))
+ }))
},
)?;
}
@@ -164,7 +164,7 @@
_s: State,
_ctx: Context,
_tailstrict: bool,
- _handler: &mut dyn FnMut(usize, LazyVal) -> Result<()>,
+ _handler: &mut dyn FnMut(usize, Thunk<Val>) -> Result<()>,
) -> Result<()> {
Ok(())
}
@@ -174,7 +174,7 @@
s: State,
ctx: Context,
tailstrict: bool,
- handler: &mut dyn FnMut(&IStr, LazyVal) -> Result<()>,
+ handler: &mut dyn FnMut(&IStr, Thunk<Val>) -> Result<()>,
) -> Result<()> {
for (name, value) in self.iter() {
handler(
@@ -205,7 +205,7 @@
s: State,
ctx: Context,
tailstrict: bool,
- handler: &mut dyn FnMut(usize, LazyVal) -> Result<()>,
+ handler: &mut dyn FnMut(usize, Thunk<Val>) -> Result<()>,
) -> Result<()> {
let mut i = 0usize;
let ($($gen,)*) = self;
@@ -220,7 +220,7 @@
_s: State,
_ctx: Context,
_tailstrict: bool,
- _handler: &mut dyn FnMut(&IStr, LazyVal) -> Result<()>,
+ _handler: &mut dyn FnMut(&IStr, Thunk<Val>) -> Result<()>,
) -> Result<()> {
Ok(())
}
@@ -236,7 +236,7 @@
_s: State,
_ctx: Context,
_tailstrict: bool,
- _handler: &mut dyn FnMut(usize, LazyVal) -> Result<()>,
+ _handler: &mut dyn FnMut(usize, Thunk<Val>) -> Result<()>,
) -> Result<()> {
Ok(())
}
@@ -246,7 +246,7 @@
s: State,
ctx: Context,
tailstrict: bool,
- handler: &mut dyn FnMut(&IStr, LazyVal) -> Result<()>,
+ handler: &mut dyn FnMut(&IStr, Thunk<Val>) -> Result<()>,
) -> Result<()> {
let ($($gen,)*) = self;
$(
@@ -285,7 +285,7 @@
_s: State,
_ctx: Context,
_tailstrict: bool,
- _handler: &mut dyn FnMut(usize, LazyVal) -> Result<()>,
+ _handler: &mut dyn FnMut(usize, Thunk<Val>) -> Result<()>,
) -> Result<()> {
Ok(())
}
@@ -295,7 +295,7 @@
_s: State,
_ctx: Context,
_tailstrict: bool,
- _handler: &mut dyn FnMut(&IStr, LazyVal) -> Result<()>,
+ _handler: &mut dyn FnMut(&IStr, Thunk<Val>) -> Result<()>,
) -> Result<()> {
Ok(())
}
crates/jrsonnet-evaluator/src/function/parse.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function/parse.rs
+++ b/crates/jrsonnet-evaluator/src/function/parse.rs
@@ -9,20 +9,21 @@
use crate::{
error::{Error::*, Result},
evaluate_named,
- gc::{GcHashMap, TraceBox},
- throw,
- val::LazyValValue,
- Context, FutureWrapper, LazyVal, State, Val,
+ gc::GcHashMap,
+ tb, throw,
+ val::ThunkValue,
+ Context, Pending, State, Thunk, Val,
};
#[derive(Trace)]
-struct EvaluateNamedLazyVal {
- ctx: FutureWrapper<Context>,
+struct EvaluateNamedThunk {
+ ctx: Pending<Context>,
name: IStr,
value: LocExpr,
}
-impl LazyValValue for EvaluateNamedLazyVal {
+impl ThunkValue for EvaluateNamedThunk {
+ type Output = Val;
fn get(self: Box<Self>, s: State) -> Result<Val> {
evaluate_named(s, self.ctx.unwrap(), &self.value, self.name)
}
@@ -83,11 +84,11 @@
defaults.insert(
param.0.clone(),
- LazyVal::new(TraceBox(Box::new(EvaluateNamedLazyVal {
+ Thunk::new(tb!(EvaluateNamedThunk {
ctx: fctx.clone(),
name: param.0.clone(),
value: param.1.clone().expect("default exists"),
- }))),
+ })),
);
filled_args += 1;
}
@@ -131,7 +132,7 @@
params: &[BuiltinParam],
args: &dyn ArgsLike,
tailstrict: bool,
-) -> Result<GcHashMap<BuiltinParamName, LazyVal>> {
+) -> Result<GcHashMap<BuiltinParamName, Thunk<Val>>> {
let mut passed_args = GcHashMap::with_capacity(params.len());
if args.unnamed_len() > params.len() {
throw!(TooManyArgsFunctionHas(params.len()))
@@ -191,7 +192,8 @@
pub fn parse_default_function_call(body_ctx: Context, params: &ParamsDesc) -> Context {
#[derive(Trace)]
struct DependsOnUnbound(IStr);
- impl LazyValValue for DependsOnUnbound {
+ impl ThunkValue for DependsOnUnbound {
+ type Output = Val;
fn get(self: Box<Self>, _: State) -> Result<Val> {
Err(FunctionParameterNotBoundInCall(self.0.clone()).into())
}
@@ -205,16 +207,16 @@
if let Some(v) = ¶m.1 {
bindings.insert(
param.0.clone(),
- LazyVal::new(TraceBox(Box::new(EvaluateNamedLazyVal {
+ Thunk::new(tb!(EvaluateNamedThunk {
ctx: fctx.clone(),
name: param.0.clone(),
value: v.clone(),
- }))),
+ })),
);
} else {
bindings.insert(
param.0.clone(),
- LazyVal::new(TraceBox(Box::new(DependsOnUnbound(param.0.clone())))),
+ Thunk::new(tb!(DependsOnUnbound(param.0.clone()))),
);
}
}
crates/jrsonnet-evaluator/src/gc.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/gc.rs
+++ b/crates/jrsonnet-evaluator/src/gc.rs
@@ -10,8 +10,15 @@
use rustc_hash::{FxHashMap, FxHashSet};
/// Replacement for box, which assumes that the underlying type is [`Trace`]
+/// Used in places, where Cc<dyn Trait> should be used instead, but it can't, because CoerceUnsiced is not stable
#[derive(Debug, Clone)]
pub struct TraceBox<T: ?Sized>(pub Box<T>);
+#[macro_export]
+macro_rules! tb {
+ ($v:expr) => {
+ $crate::gc::TraceBox(Box::new($v))
+ };
+}
impl<T: ?Sized + Trace> Trace for TraceBox<T> {
fn trace(&self, tracer: &mut Tracer) {
crates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/lib.rs
+++ b/crates/jrsonnet-evaluator/src/lib.rs
@@ -58,7 +58,7 @@
use jrsonnet_parser::*;
pub use obj::*;
use trace::{location_to_offset, offset_to_location, CodeLocation, CompactFormat, TraceFormat};
-pub use val::{LazyVal, ManifestFormat, Val};
+pub use val::{ManifestFormat, Thunk, Val};
pub trait Bindable: Trace + 'static {
fn bind(
@@ -66,13 +66,13 @@
s: State,
this: Option<ObjValue>,
super_obj: Option<ObjValue>,
- ) -> Result<LazyVal>;
+ ) -> Result<Thunk<Val>>;
}
#[derive(Clone, Trace)]
pub enum LazyBinding {
Bindable(Cc<TraceBox<dyn Bindable>>),
- Bound(LazyVal),
+ Bound(Thunk<Val>),
}
impl Debug for LazyBinding {
@@ -86,7 +86,7 @@
s: State,
this: Option<ObjValue>,
super_obj: Option<ObjValue>,
- ) -> Result<LazyVal> {
+ ) -> Result<Thunk<Val>> {
match self {
Self::Bindable(v) => v.bind(s, this, super_obj),
Self::Bound(v) => Ok(v.clone()),
@@ -343,7 +343,7 @@
let globals = &self.settings().globals;
let mut new_bindings = GcHashMap::with_capacity(globals.len());
for (name, value) in globals.iter() {
- new_bindings.insert(name.clone(), LazyVal::new_resolved(value.clone()));
+ new_bindings.insert(name.clone(), Thunk::evaluated(value.clone()));
}
Context::new().extend_bound(new_bindings)
}
crates/jrsonnet-evaluator/src/map.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/map.rs
+++ b/crates/jrsonnet-evaluator/src/map.rs
@@ -1,27 +1,27 @@
use gcmodule::{Cc, Trace};
use jrsonnet_interner::IStr;
-use crate::{GcHashMap, LazyVal};
+use crate::{GcHashMap, Thunk, Val};
#[derive(Trace)]
#[force_tracking]
pub struct LayeredHashMapInternals {
parent: Option<LayeredHashMap>,
- current: GcHashMap<IStr, LazyVal>,
+ current: GcHashMap<IStr, Thunk<Val>>,
}
#[derive(Trace)]
pub struct LayeredHashMap(Cc<LayeredHashMapInternals>);
impl LayeredHashMap {
- pub fn extend(self, new_layer: GcHashMap<IStr, LazyVal>) -> Self {
+ pub fn extend(self, new_layer: GcHashMap<IStr, Thunk<Val>>) -> Self {
Self(Cc::new(LayeredHashMapInternals {
parent: Some(self),
current: new_layer,
}))
}
- pub fn get(&self, key: &IStr) -> Option<&LazyVal> {
+ pub fn get(&self, key: &IStr) -> Option<&Thunk<Val>> {
(self.0)
.current
.get(key)
crates/jrsonnet-evaluator/src/obj.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/obj.rs
+++ b/crates/jrsonnet-evaluator/src/obj.rs
@@ -16,7 +16,7 @@
function::CallLocation,
gc::{GcHashMap, GcHashSet, TraceBox},
operator::evaluate_add_op,
- throw, weak_ptr_eq, weak_raw, Bindable, LazyBinding, LazyVal, Result, State, Val,
+ throw, weak_ptr_eq, weak_raw, Bindable, LazyBinding, Result, State, Thunk, Val,
};
#[cfg(not(feature = "exp-preserve-order"))]
@@ -581,7 +581,7 @@
pub struct ValueBuilder<'v>(&'v mut ObjValueBuilder);
impl<'v> ObjMemberBuilder<ValueBuilder<'v>> {
pub fn value(self, s: State, value: Val) -> Result<()> {
- self.binding(s, LazyBinding::Bound(LazyVal::new_resolved(value)))
+ self.binding(s, LazyBinding::Bound(Thunk::evaluated(value)))
}
pub fn bindable(self, s: State, bindable: TraceBox<dyn Bindable>) -> Result<()> {
self.binding(s, LazyBinding::Bindable(Cc::new(bindable)))
@@ -604,7 +604,7 @@
pub struct ExtendBuilder<'v>(&'v mut ObjValue);
impl<'v> ObjMemberBuilder<ExtendBuilder<'v>> {
pub fn value(self, value: Val) {
- self.binding(LazyBinding::Bound(LazyVal::new_resolved(value)));
+ self.binding(LazyBinding::Bound(Thunk::evaluated(value)));
}
pub fn bindable(self, bindable: TraceBox<dyn Bindable>) {
self.binding(LazyBinding::Bindable(Cc::new(bindable)));
crates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth1use std::{cell::RefCell, fmt::Debug, rc::Rc};23use gcmodule::{Cc, Trace};4use jrsonnet_interner::IStr;5use jrsonnet_types::ValType;67use crate::{8 cc_ptr_eq,9 error::{Error::*, LocError},10 function::FuncVal,11 gc::TraceBox,12 stdlib::manifest::{13 manifest_json_ex, manifest_yaml_ex, ManifestJsonOptions, ManifestType, ManifestYamlOptions,14 },15 throw, ObjValue, Result, State,16};1718pub trait LazyValValue: Trace {19 fn get(self: Box<Self>, s: State) -> Result<Val>;20}2122#[derive(Trace)]23enum LazyValInternals {24 Computed(Val),25 Errored(LocError),26 Waiting(TraceBox<dyn LazyValValue>),27 Pending,28}2930#[allow(clippy::module_name_repetitions)]31#[derive(Clone, Trace)]32pub struct LazyVal(Cc<RefCell<LazyValInternals>>);33impl LazyVal {34 pub fn new(f: TraceBox<dyn LazyValValue>) -> Self {35 Self(Cc::new(RefCell::new(LazyValInternals::Waiting(f))))36 }37 pub fn new_resolved(val: Val) -> Self {38 Self(Cc::new(RefCell::new(LazyValInternals::Computed(val))))39 }40 pub fn force(&self, s: State) -> Result<()> {41 self.evaluate(s)?;42 Ok(())43 }44 pub fn evaluate(&self, s: State) -> Result<Val> {45 match &*self.0.borrow() {46 LazyValInternals::Computed(v) => return Ok(v.clone()),47 LazyValInternals::Errored(e) => return Err(e.clone()),48 LazyValInternals::Pending => return Err(InfiniteRecursionDetected.into()),49 LazyValInternals::Waiting(..) => (),50 };51 let value = if let LazyValInternals::Waiting(value) =52 std::mem::replace(&mut *self.0.borrow_mut(), LazyValInternals::Pending)53 {54 value55 } else {56 unreachable!()57 };58 let new_value = match value.0.get(s) {59 Ok(v) => v,60 Err(e) => {61 *self.0.borrow_mut() = LazyValInternals::Errored(e.clone());62 return Err(e);63 }64 };65 *self.0.borrow_mut() = LazyValInternals::Computed(new_value.clone());66 Ok(new_value)67 }68}6970impl Debug for LazyVal {71 fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {72 write!(f, "Lazy")73 }74}75impl PartialEq for LazyVal {76 fn eq(&self, other: &Self) -> bool {77 cc_ptr_eq(&self.0, &other.0)78 }79}8081#[derive(Clone)]82pub enum ManifestFormat {83 YamlStream(Box<ManifestFormat>),84 Yaml {85 padding: usize,86 #[cfg(feature = "exp-preserve-order")]87 preserve_order: bool,88 },89 Json {90 padding: usize,91 #[cfg(feature = "exp-preserve-order")]92 preserve_order: bool,93 },94 ToString,95 String,96}97impl ManifestFormat {98 #[cfg(feature = "exp-preserve-order")]99 fn preserve_order(&self) -> bool {100 match self {101 ManifestFormat::YamlStream(s) => s.preserve_order(),102 ManifestFormat::Yaml { preserve_order, .. } => *preserve_order,103 ManifestFormat::Json { preserve_order, .. } => *preserve_order,104 ManifestFormat::ToString => false,105 ManifestFormat::String => false,106 }107 }108}109110#[derive(Debug, Clone, Trace)]111pub struct Slice {112 pub(crate) inner: ArrValue,113 pub(crate) from: u32,114 pub(crate) to: u32,115 pub(crate) step: u32,116}117impl Slice {118 const fn from(&self) -> usize {119 self.from as usize120 }121 const fn to(&self) -> usize {122 self.to as usize123 }124 const fn step(&self) -> usize {125 self.step as usize126 }127 const fn len(&self) -> usize {128 // TODO: use div_ceil129 let diff = self.to() - self.from();130 let rem = diff % self.step();131 let div = diff / self.step();132133 if rem == 0 {134 div135 } else {136 div + 1137 }138 }139}140141#[derive(Debug, Clone, Trace)]142#[force_tracking]143pub enum ArrValue {144 Bytes(#[skip_trace] Rc<[u8]>),145 Lazy(Cc<Vec<LazyVal>>),146 Eager(Cc<Vec<Val>>),147 Extended(Box<(Self, Self)>),148 Range(i32, i32),149 Slice(Box<Slice>),150 Reversed(Box<Self>),151}152impl ArrValue {153 pub fn new_eager() -> Self {154 Self::Eager(Cc::new(Vec::new()))155 }156157 /// # Panics158 /// If a > b159 pub fn new_range(a: i32, b: i32) -> Self {160 assert!(a <= b);161 Self::Range(a, b)162 }163164 /// # Panics165 /// If passed numbers are incorrect166 #[must_use]167 pub fn slice(self, from: Option<usize>, to: Option<usize>, step: Option<usize>) -> Self {168 let len = self.len();169 let from = from.unwrap_or(0);170 let to = to.unwrap_or(len).min(len);171 let step = step.unwrap_or(1);172 assert!(from < to);173 assert!(step > 0);174175 Self::Slice(Box::new(Slice {176 inner: self,177 from: from as u32,178 to: to as u32,179 step: step as u32,180 }))181 }182183 pub fn len(&self) -> usize {184 match self {185 Self::Bytes(i) => i.len(),186 Self::Lazy(l) => l.len(),187 Self::Eager(e) => e.len(),188 Self::Extended(v) => v.0.len() + v.1.len(),189 Self::Range(a, b) => a.abs_diff(*b) as usize + 1,190 Self::Reversed(i) => i.len(),191 Self::Slice(s) => s.len(),192 }193 }194195 pub fn is_empty(&self) -> bool {196 self.len() == 0197 }198199 pub fn get(&self, s: State, index: usize) -> Result<Option<Val>> {200 match self {201 Self::Bytes(i) => i202 .get(index)203 .map_or(Ok(None), |v| Ok(Some(Val::Num(f64::from(*v))))),204 Self::Lazy(vec) => {205 if let Some(v) = vec.get(index) {206 Ok(Some(v.evaluate(s)?))207 } else {208 Ok(None)209 }210 }211 Self::Eager(vec) => Ok(vec.get(index).cloned()),212 Self::Extended(v) => {213 let a_len = v.0.len();214 if a_len > index {215 v.0.get(s, index)216 } else {217 v.1.get(s, index - a_len)218 }219 }220 Self::Range(a, _) => {221 if index >= self.len() {222 return Ok(None);223 }224 Ok(Some(Val::Num(((*a as isize) + index as isize) as f64)))225 }226 Self::Reversed(v) => {227 let len = v.len();228 if index >= len {229 return Ok(None);230 }231 v.get(s, len - index - 1)232 }233 Self::Slice(v) => {234 let index = v.from() + index * v.step();235 if index >= v.to() {236 return Ok(None);237 }238 v.inner.get(s, index as usize)239 }240 }241 }242243 pub fn get_lazy(&self, index: usize) -> Option<LazyVal> {244 match self {245 Self::Bytes(i) => i246 .get(index)247 .map(|b| LazyVal::new_resolved(Val::Num(f64::from(*b)))),248 Self::Lazy(vec) => vec.get(index).cloned(),249 Self::Eager(vec) => vec.get(index).cloned().map(LazyVal::new_resolved),250 Self::Extended(v) => {251 let a_len = v.0.len();252 if a_len > index {253 v.0.get_lazy(index)254 } else {255 v.1.get_lazy(index - a_len)256 }257 }258 Self::Range(a, _) => {259 if index >= self.len() {260 return None;261 }262 Some(LazyVal::new_resolved(Val::Num(263 ((*a as isize) + index as isize) as f64,264 )))265 }266 Self::Reversed(v) => {267 let len = v.len();268 if index >= len {269 return None;270 }271 v.get_lazy(len - index - 1)272 }273 Self::Slice(s) => {274 let index = s.from() + index * s.step();275 if index >= s.to() {276 return None;277 }278 s.inner.get_lazy(index as usize)279 }280 }281 }282283 pub fn evaluated(&self, s: State) -> Result<Cc<Vec<Val>>> {284 Ok(match self {285 Self::Bytes(i) => {286 let mut out = Vec::with_capacity(i.len());287 for v in i.iter() {288 out.push(Val::Num(f64::from(*v)));289 }290 Cc::new(out)291 }292 Self::Lazy(vec) => {293 let mut out = Vec::with_capacity(vec.len());294 for item in vec.iter() {295 out.push(item.evaluate(s.clone())?);296 }297 Cc::new(out)298 }299 Self::Eager(vec) => vec.clone(),300 Self::Extended(_v) => {301 let mut out = Vec::with_capacity(self.len());302 for item in self.iter(s) {303 out.push(item?);304 }305 Cc::new(out)306 }307 Self::Range(a, b) => {308 let mut out = Vec::with_capacity(self.len());309 for i in *a..*b {310 out.push(Val::Num(f64::from(i)));311 }312 Cc::new(out)313 }314 Self::Reversed(r) => {315 let mut r = r.evaluated(s)?;316 Cc::update_with(&mut r, |v| v.reverse());317 r318 }319 Self::Slice(v) => {320 let mut out = Vec::with_capacity(v.inner.len());321 for v in v322 .inner323 .iter_lazy()324 .skip(v.from())325 .take(v.to() - v.from())326 .step_by(v.step())327 {328 out.push(v.evaluate(s.clone())?);329 }330 Cc::new(out)331 }332 })333 }334335 pub fn iter(&self, s: State) -> impl DoubleEndedIterator<Item = Result<Val>> + '_ {336 (0..self.len()).map(move |idx| match self {337 Self::Bytes(b) => Ok(Val::Num(f64::from(b[idx]))),338 Self::Lazy(l) => l[idx].evaluate(s.clone()),339 Self::Eager(e) => Ok(e[idx].clone()),340 Self::Extended(..) | Self::Range(..) | Self::Reversed(..) | Self::Slice(..) => {341 self.get(s.clone(), idx).map(|e| e.expect("idx < len"))342 }343 })344 }345346 pub fn iter_lazy(&self) -> impl DoubleEndedIterator<Item = LazyVal> + '_ {347 (0..self.len()).map(move |idx| match self {348 Self::Bytes(b) => LazyVal::new_resolved(Val::Num(f64::from(b[idx]))),349 Self::Lazy(l) => l[idx].clone(),350 Self::Eager(e) => LazyVal::new_resolved(e[idx].clone()),351 Self::Slice(..) | Self::Extended(..) | Self::Range(..) | Self::Reversed(..) => {352 self.get_lazy(idx).expect("idx < len")353 }354 })355 }356357 #[must_use]358 pub fn reversed(self) -> Self {359 Self::Reversed(Box::new(self))360 }361362 pub fn map(self, s: State, mapper: impl Fn(Val) -> Result<Val>) -> Result<Self> {363 let mut out = Vec::with_capacity(self.len());364365 for value in self.iter(s) {366 out.push(mapper(value?)?);367 }368369 Ok(Self::Eager(Cc::new(out)))370 }371372 pub fn filter(self, s: State, filter: impl Fn(&Val) -> Result<bool>) -> Result<Self> {373 let mut out = Vec::with_capacity(self.len());374375 for value in self.iter(s) {376 let value = value?;377 if filter(&value)? {378 out.push(value);379 }380 }381382 Ok(Self::Eager(Cc::new(out)))383 }384385 pub fn ptr_eq(a: &Self, b: &Self) -> bool {386 match (a, b) {387 (Self::Lazy(a), Self::Lazy(b)) => cc_ptr_eq(a, b),388 (Self::Eager(a), Self::Eager(b)) => cc_ptr_eq(a, b),389 _ => false,390 }391 }392}393394impl From<Vec<LazyVal>> for ArrValue {395 fn from(v: Vec<LazyVal>) -> Self {396 Self::Lazy(Cc::new(v))397 }398}399400impl From<Vec<Val>> for ArrValue {401 fn from(v: Vec<Val>) -> Self {402 Self::Eager(Cc::new(v))403 }404}405406#[allow(clippy::module_name_repetitions)]407pub enum IndexableVal {408 Str(IStr),409 Arr(ArrValue),410}411412#[derive(Debug, Clone, Trace)]413pub enum Val {414 Bool(bool),415 Null,416 Str(IStr),417 Num(f64),418 Arr(ArrValue),419 Obj(ObjValue),420 Func(FuncVal),421}422423impl Val {424 pub const fn as_bool(&self) -> Option<bool> {425 match self {426 Val::Bool(v) => Some(*v),427 _ => None,428 }429 }430 pub const fn as_null(&self) -> Option<()> {431 match self {432 Val::Null => Some(()),433 _ => None,434 }435 }436 pub fn as_str(&self) -> Option<IStr> {437 match self {438 Val::Str(s) => Some(s.clone()),439 _ => None,440 }441 }442 pub const fn as_num(&self) -> Option<f64> {443 match self {444 Val::Num(n) => Some(*n),445 _ => None,446 }447 }448 pub fn as_arr(&self) -> Option<ArrValue> {449 match self {450 Val::Arr(a) => Some(a.clone()),451 _ => None,452 }453 }454 pub fn as_obj(&self) -> Option<ObjValue> {455 match self {456 Val::Obj(o) => Some(o.clone()),457 _ => None,458 }459 }460 pub fn as_func(&self) -> Option<FuncVal> {461 match self {462 Val::Func(f) => Some(f.clone()),463 _ => None,464 }465 }466467 /// Creates `Val::Num` after checking for numeric overflow.468 /// As numbers are `f64`, we can just check for their finity.469 pub fn new_checked_num(num: f64) -> Result<Self> {470 if num.is_finite() {471 Ok(Self::Num(num))472 } else {473 throw!(RuntimeError("overflow".into()))474 }475 }476477 pub const fn value_type(&self) -> ValType {478 match self {479 Self::Str(..) => ValType::Str,480 Self::Num(..) => ValType::Num,481 Self::Arr(..) => ValType::Arr,482 Self::Obj(..) => ValType::Obj,483 Self::Bool(_) => ValType::Bool,484 Self::Null => ValType::Null,485 Self::Func(..) => ValType::Func,486 }487 }488489 pub fn to_string(&self, s: State) -> Result<IStr> {490 Ok(match self {491 Self::Bool(true) => "true".into(),492 Self::Bool(false) => "false".into(),493 Self::Null => "null".into(),494 Self::Str(s) => s.clone(),495 v => manifest_json_ex(496 s,497 v,498 &ManifestJsonOptions {499 padding: "",500 mtype: ManifestType::ToString,501 newline: "\n",502 key_val_sep: ": ",503 #[cfg(feature = "exp-preserve-order")]504 preserve_order: false,505 },506 )?507 .into(),508 })509 }510511 /// Expects value to be object, outputs (key, manifested value) pairs512 pub fn manifest_multi(&self, s: State, ty: &ManifestFormat) -> Result<Vec<(IStr, IStr)>> {513 let obj = match self {514 Self::Obj(obj) => obj,515 _ => throw!(MultiManifestOutputIsNotAObject),516 };517 let keys = obj.fields(518 #[cfg(feature = "exp-preserve-order")]519 ty.preserve_order(),520 );521 let mut out = Vec::with_capacity(keys.len());522 for key in keys {523 let value = obj524 .get(s.clone(), key.clone())?525 .expect("item in object")526 .manifest(s.clone(), ty)?;527 out.push((key, value));528 }529 Ok(out)530 }531532 /// Expects value to be array, outputs manifested values533 pub fn manifest_stream(&self, s: State, ty: &ManifestFormat) -> Result<Vec<IStr>> {534 let arr = match self {535 Self::Arr(a) => a,536 _ => throw!(StreamManifestOutputIsNotAArray),537 };538 let mut out = Vec::with_capacity(arr.len());539 for i in arr.iter(s.clone()) {540 out.push(i?.manifest(s.clone(), ty)?);541 }542 Ok(out)543 }544545 pub fn manifest(&self, s: State, ty: &ManifestFormat) -> Result<IStr> {546 Ok(match ty {547 ManifestFormat::YamlStream(format) => {548 let arr = match self {549 Self::Arr(a) => a,550 _ => throw!(StreamManifestOutputIsNotAArray),551 };552 let mut out = String::new();553554 match format as &ManifestFormat {555 ManifestFormat::YamlStream(_) => throw!(StreamManifestOutputCannotBeRecursed),556 ManifestFormat::String => throw!(StreamManifestCannotNestString),557 _ => {}558 };559560 if !arr.is_empty() {561 for v in arr.iter(s.clone()) {562 out.push_str("---\n");563 out.push_str(&v?.manifest(s.clone(), format)?);564 out.push('\n');565 }566 out.push_str("...");567 }568569 out.into()570 }571 ManifestFormat::Yaml {572 padding,573 #[cfg(feature = "exp-preserve-order")]574 preserve_order,575 } => self.to_yaml(576 s,577 *padding,578 #[cfg(feature = "exp-preserve-order")]579 *preserve_order,580 )?,581 ManifestFormat::Json {582 padding,583 #[cfg(feature = "exp-preserve-order")]584 preserve_order,585 } => self.to_json(586 s,587 *padding,588 #[cfg(feature = "exp-preserve-order")]589 *preserve_order,590 )?,591 ManifestFormat::ToString => self.to_string(s)?,592 ManifestFormat::String => match self {593 Self::Str(s) => s.clone(),594 _ => throw!(StringManifestOutputIsNotAString),595 },596 })597 }598599 /// For manifestification600 pub fn to_json(601 &self,602 s: State,603 padding: usize,604 #[cfg(feature = "exp-preserve-order")] preserve_order: bool,605 ) -> Result<IStr> {606 manifest_json_ex(607 s,608 self,609 &ManifestJsonOptions {610 padding: &" ".repeat(padding),611 mtype: if padding == 0 {612 ManifestType::Minify613 } else {614 ManifestType::Manifest615 },616 newline: "\n",617 key_val_sep: ": ",618 #[cfg(feature = "exp-preserve-order")]619 preserve_order,620 },621 )622 .map(Into::into)623 }624625 /// Calls `std.manifestJson`626 pub fn to_std_json(627 &self,628 s: State,629 padding: usize,630 #[cfg(feature = "exp-preserve-order")] preserve_order: bool,631 ) -> Result<Rc<str>> {632 manifest_json_ex(633 s,634 self,635 &ManifestJsonOptions {636 padding: &" ".repeat(padding),637 mtype: ManifestType::Std,638 newline: "\n",639 key_val_sep: ": ",640 #[cfg(feature = "exp-preserve-order")]641 preserve_order,642 },643 )644 .map(Into::into)645 }646647 pub fn to_yaml(648 &self,649 s: State,650 padding: usize,651 #[cfg(feature = "exp-preserve-order")] preserve_order: bool,652 ) -> Result<IStr> {653 let padding = &" ".repeat(padding);654 manifest_yaml_ex(655 s,656 self,657 &ManifestYamlOptions {658 padding,659 arr_element_padding: padding,660 quote_keys: false,661 #[cfg(feature = "exp-preserve-order")]662 preserve_order,663 },664 )665 .map(Into::into)666 }667 pub fn into_indexable(self) -> Result<IndexableVal> {668 Ok(match self {669 Val::Str(s) => IndexableVal::Str(s),670 Val::Arr(arr) => IndexableVal::Arr(arr),671 _ => throw!(ValueIsNotIndexable(self.value_type())),672 })673 }674}675676const fn is_function_like(val: &Val) -> bool {677 matches!(val, Val::Func(_))678}679680/// Native implementation of `std.primitiveEquals`681pub fn primitive_equals(val_a: &Val, val_b: &Val) -> Result<bool> {682 Ok(match (val_a, val_b) {683 (Val::Bool(a), Val::Bool(b)) => a == b,684 (Val::Null, Val::Null) => true,685 (Val::Str(a), Val::Str(b)) => a == b,686 (Val::Num(a), Val::Num(b)) => (a - b).abs() <= f64::EPSILON,687 (Val::Arr(_), Val::Arr(_)) => throw!(RuntimeError(688 "primitiveEquals operates on primitive types, got array".into(),689 )),690 (Val::Obj(_), Val::Obj(_)) => throw!(RuntimeError(691 "primitiveEquals operates on primitive types, got object".into(),692 )),693 (a, b) if is_function_like(a) && is_function_like(b) => {694 throw!(RuntimeError("cannot test equality of functions".into()))695 }696 (_, _) => false,697 })698}699700/// Native implementation of `std.equals`701pub fn equals(s: State, val_a: &Val, val_b: &Val) -> Result<bool> {702 if val_a.value_type() != val_b.value_type() {703 return Ok(false);704 }705 match (val_a, val_b) {706 (Val::Arr(a), Val::Arr(b)) => {707 if ArrValue::ptr_eq(a, b) {708 return Ok(true);709 }710 if a.len() != b.len() {711 return Ok(false);712 }713 for (a, b) in a.iter(s.clone()).zip(b.iter(s.clone())) {714 if !equals(s.clone(), &a?, &b?)? {715 return Ok(false);716 }717 }718 Ok(true)719 }720 (Val::Obj(a), Val::Obj(b)) => {721 if ObjValue::ptr_eq(a, b) {722 return Ok(true);723 }724 let fields = a.fields(725 #[cfg(feature = "exp-preserve-order")]726 false,727 );728 if fields729 != b.fields(730 #[cfg(feature = "exp-preserve-order")]731 false,732 ) {733 return Ok(false);734 }735 for field in fields {736 if !equals(737 s.clone(),738 &a.get(s.clone(), field.clone())?.expect("field exists"),739 &b.get(s.clone(), field)?.expect("field exists"),740 )? {741 return Ok(false);742 }743 }744 Ok(true)745 }746 (a, b) => Ok(primitive_equals(a, b)?),747 }748}crates/jrsonnet-evaluator/tests/builtin.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/tests/builtin.rs
+++ b/crates/jrsonnet-evaluator/tests/builtin.rs
@@ -7,6 +7,7 @@
error::Result,
function::{builtin, builtin::Builtin, CallLocation, FuncVal},
gc::TraceBox,
+ tb,
typed::Typed,
State, Val,
};
@@ -70,9 +71,7 @@
#[builtin]
fn curry_add(a: u32) -> Result<FuncVal> {
- Ok(FuncVal::Builtin(Cc::new(TraceBox(Box::new(curried_add {
- a,
- })))))
+ Ok(FuncVal::Builtin(Cc::new(tb!(curried_add { a }))))
}
#[test]
crates/jrsonnet-evaluator/tests/common.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/tests/common.rs
+++ b/crates/jrsonnet-evaluator/tests/common.rs
@@ -1,7 +1,7 @@
use jrsonnet_evaluator::{
error::Result,
function::{builtin, FuncVal},
- throw_runtime, LazyVal, ObjValueBuilder, State, Val,
+ throw_runtime, ObjValueBuilder, State, Thunk, Val,
};
#[macro_export]
@@ -38,7 +38,7 @@
}
#[builtin]
-fn assert_throw(s: State, lazy: LazyVal, message: String) -> Result<bool> {
+fn assert_throw(s: State, lazy: Thunk<Val>, message: String) -> Result<bool> {
match lazy.evaluate(s) {
Ok(_) => {
throw_runtime!("expected argument to throw on evaluation, but it returned instead")
crates/jrsonnet-macros/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-macros/src/lib.rs
+++ b/crates/jrsonnet-macros/src/lib.rs
@@ -150,7 +150,7 @@
return Ok(Self::State);
} else if type_is_path(ty, "CallLocation").is_some() {
return Ok(Self::Location);
- } else if type_is_path(ty, "LazyVal").is_some() {
+ } else if type_is_path(ty, "Thunk").is_some() {
return Ok(Self::Lazy {
is_option: false,
name: ident.to_string(),
@@ -163,7 +163,7 @@
}
let (is_option, ty) = if let Some(ty) = extract_type_from_option(ty)? {
- if type_is_path(ty, "LazyVal").is_some() {
+ if type_is_path(ty, "Thunk").is_some() {
return Ok(Self::Lazy {
is_option: true,
name: ident.to_string(),
crates/jrsonnet-parser/Cargo.tomldiffbeforeafterboth--- a/crates/jrsonnet-parser/Cargo.toml
+++ b/crates/jrsonnet-parser/Cargo.toml
@@ -6,6 +6,9 @@
license = "MIT"
edition = "2021"
+[features]
+exp-destruct = []
+
[dependencies]
jrsonnet-interner = { path = "../jrsonnet-interner", version = "0.4.2" }
crates/jrsonnet-parser/src/expr.rsdiffbeforeafterboth--- a/crates/jrsonnet-parser/src/expr.rs
+++ b/crates/jrsonnet-parser/src/expr.rs
@@ -179,10 +179,44 @@
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[derive(Debug, Clone, PartialEq, Trace)]
-pub struct BindSpec {
- pub name: IStr,
- pub params: Option<ParamsDesc>,
- pub value: LocExpr,
+pub enum DestructRest {
+ /// ...rest
+ Keep(IStr),
+ /// ...
+ Drop,
+}
+
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[derive(Debug, Clone, PartialEq, Trace)]
+pub enum Destruct {
+ Full(IStr),
+ #[cfg(feature = "exp-destruct")]
+ Skip,
+ #[cfg(feature = "exp-destruct")]
+ Array {
+ start: Vec<Destruct>,
+ rest: Option<DestructRest>,
+ end: Vec<Destruct>,
+ },
+ #[cfg(feature = "exp-destruct")]
+ Object {
+ fields: Vec<(IStr, Option<Destruct>)>,
+ rest: Option<DestructRest>,
+ },
+}
+
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[derive(Debug, Clone, PartialEq, Trace)]
+pub enum BindSpec {
+ Field {
+ into: Destruct,
+ value: LocExpr,
+ },
+ Function {
+ name: IStr,
+ params: ParamsDesc,
+ value: LocExpr,
+ },
}
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
crates/jrsonnet-parser/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-parser/src/lib.rs
+++ b/crates/jrsonnet-parser/src/lib.rs
@@ -55,18 +55,18 @@
/// Reserved word followed by any non-alphanumberic
rule reserved() = ("assert" / "else" / "error" / "false" / "for" / "function" / "if" / "import" / "importstr" / "importbin" / "in" / "local" / "null" / "tailstrict" / "then" / "self" / "super" / "true") end_of_ident()
- rule id() = quiet!{ !reserved() alpha() (alpha() / digit())*} / expected!("<identifier>")
+ rule id() -> IStr = v:$(quiet!{ !reserved() alpha() (alpha() / digit())*} / expected!("<identifier>")) { v.into() }
rule keyword(id: &'static str) -> ()
= ##parse_string_literal(id) end_of_ident()
- pub rule param(s: &ParserSettings) -> expr::Param = name:$(id()) expr:(_ "=" _ expr:expr(s){expr})? { expr::Param(name.into(), expr) }
+ pub rule param(s: &ParserSettings) -> expr::Param = name:id() expr:(_ "=" _ expr:expr(s){expr})? { expr::Param(name, expr) }
pub rule params(s: &ParserSettings) -> expr::ParamsDesc
= params:param(s) ** comma() comma()? { expr::ParamsDesc(Rc::new(params)) }
/ { expr::ParamsDesc(Rc::new(Vec::new())) }
pub rule arg(s: &ParserSettings) -> (Option<IStr>, LocExpr)
- = quiet! { name:(s:$(id()) _ "=" _ {s})? expr:expr(s) {(name.map(Into::into), expr)} }
+ = quiet! { name:(s:id() _ "=" _ {s})? expr:expr(s) {(name, expr)} }
/ expected!("<argument>")
pub rule args(s: &ParserSettings) -> expr::ArgsDesc
@@ -89,9 +89,52 @@
Ok(expr::ArgsDesc::new(unnamed, named))
}
+ pub rule destruct_rest() -> expr::DestructRest
+ = "..." into:(_ into:id() {into})? {if let Some(into) = into {
+ expr::DestructRest::Keep(into)
+ } else {expr::DestructRest::Drop}}
+ pub rule destruct_array(s: &ParserSettings) -> expr::Destruct
+ = "[" _ start:destruct(s)**comma() rest:(
+ comma() _ rest:destruct_rest()? end:(
+ comma() end:destruct(s)**comma() (_ comma())? {end}
+ / comma()? {Vec::new()}
+ ) {(rest, end)}
+ / comma()? {(None, Vec::new())}
+ ) _ "]" {?
+ #[cfg(feature = "exp-destruct")] return Ok(expr::Destruct::Array {
+ start,
+ rest: rest.0,
+ end: rest.1,
+ });
+ #[cfg(not(feature = "exp-destruct"))] Err("experimental destructuring was not enabled")
+ }
+ pub rule destruct_object(s: &ParserSettings) -> expr::Destruct
+ = "{" _
+ fields:(name:id() _ into:(":" _ into:destruct(s) {into})? {(name, into)})**comma()
+ rest:(
+ comma() rest:destruct_rest()? {rest}
+ / comma()? {None}
+ )
+ _ "}" {?
+ #[cfg(feature = "exp-destruct")] return Ok(expr::Destruct::Object {
+ fields,
+ rest,
+ });
+ #[cfg(not(feature = "exp-destruct"))] Err("experimental destructuring was not enabled")
+ }
+ pub rule destruct(s: &ParserSettings) -> expr::Destruct
+ = v:id() {expr::Destruct::Full(v)}
+ / "?" {?
+ #[cfg(feature = "exp-destruct")] return Ok(expr::Destruct::Skip);
+ #[cfg(not(feature = "exp-destruct"))] Err("experimental destructuring was not enabled")
+ }
+ / arr:destruct_array(s) {arr}
+ / obj:destruct_object(s) {obj}
+
pub rule bind(s: &ParserSettings) -> expr::BindSpec
- = name:$(id()) _ "=" _ expr:expr(s) {expr::BindSpec{name:name.into(), params: None, value: expr}}
- / name:$(id()) _ "(" _ params:params(s) _ ")" _ "=" _ expr:expr(s) {expr::BindSpec{name:name.into(), params: Some(params), value: expr}}
+ = into:destruct(s) _ "=" _ expr:expr(s) {expr::BindSpec::Field{into, value: expr}}
+ / name:id() _ "(" _ params:params(s) _ ")" _ "=" _ expr:expr(s) {expr::BindSpec::Function{name, params, value: expr}}
+
pub rule assertion(s: &ParserSettings) -> expr::AssertStmt
= keyword("assert") _ cond:expr(s) msg:(_ ":" _ e:expr(s) {e})? { expr::AssertStmt(cond, msg) }
@@ -122,7 +165,7 @@
/ string_block() } / expected!("<string>")
pub rule field_name(s: &ParserSettings) -> expr::FieldName
- = name:$(id()) {expr::FieldName::Fixed(name.into())}
+ = name:id() {expr::FieldName::Fixed(name.into())}
/ name:string() {expr::FieldName::Fixed(name.into())}
/ "[" _ expr:expr(s) _ "]" {expr::FieldName::Dyn(expr)}
pub rule visibility() -> expr::Visibility
@@ -167,7 +210,7 @@
pub rule ifspec(s: &ParserSettings) -> IfSpecData
= keyword("if") _ expr:expr(s) {IfSpecData(expr)}
pub rule forspec(s: &ParserSettings) -> ForSpecData
- = keyword("for") _ id:$(id()) _ keyword("in") _ cond:expr(s) {ForSpecData(id.into(), cond)}
+ = keyword("for") _ id:id() _ keyword("in") _ cond:expr(s) {ForSpecData(id, cond)}
pub rule compspec(s: &ParserSettings) -> Vec<expr::CompSpec>
= s:(i:ifspec(s) { expr::CompSpec::IfSpec(i) } / f:forspec(s) {expr::CompSpec::ForSpec(f)} ) ** _ {s}
pub rule local_expr(s: &ParserSettings) -> Expr
@@ -187,9 +230,9 @@
pub rule number_expr(s: &ParserSettings) -> Expr
= n:number() { expr::Expr::Num(n) }
pub rule var_expr(s: &ParserSettings) -> Expr
- = n:$(id()) { expr::Expr::Var(n.into()) }
+ = n:id() { expr::Expr::Var(n) }
pub rule id_loc(s: &ParserSettings) -> LocExpr
- = a:position!() n:$(id()) b:position!() { LocExpr(Rc::new(expr::Expr::Str(n.into())), ExprLocation(s.file_name.clone(), a,b)) }
+ = a:position!() n:id() b:position!() { LocExpr(Rc::new(expr::Expr::Str(n)), ExprLocation(s.file_name.clone(), a,b)) }
pub rule if_then_else_expr(s: &ParserSettings) -> Expr
= cond:ifspec(s) _ keyword("then") _ cond_then:expr(s) cond_else:(_ keyword("else") _ e:expr(s) {e})? {Expr::IfElse{
cond,
@@ -212,7 +255,7 @@
/ quiet!{"$intrinsicThisFile" {Expr::IntrinsicThisFile}}
/ quiet!{"$intrinsicId" {Expr::IntrinsicId}}
- / quiet!{"$intrinsic(" name:$(id()) ")" {Expr::Intrinsic(name.into())}}
+ / quiet!{"$intrinsic(" name:id() ")" {Expr::Intrinsic(name)}}
/ string_expr(s) / number_expr(s)
/ array_expr(s)
@@ -693,9 +736,8 @@
ObjExtend(
el!(Obj(ObjBody::MemberList(vec![])), 0, 2),
ObjBody::MemberList(vec![
- Member::BindStmt(BindSpec {
- name: "x".into(),
- params: None,
+ Member::BindStmt(BindSpec::Field {
+ into: Destruct::Full("x".into()),
value: el!(Num(1.0), 15, 16)
}),
Member::Field(FieldMember {