difftreelog
refact: simplify error management
in: master
18 files changed
bindings/jsonnet/src/import.rsdiffbeforeafterboth--- a/bindings/jsonnet/src/import.rs
+++ b/bindings/jsonnet/src/import.rs
@@ -1,7 +1,8 @@
//! Import resolution manipulation utilities
use jrsonnet_evaluator::{
- create_error, create_error_result, Error, EvaluationState, ImportResolver, Result,
+ error::{Error::*, Result},
+ throw, EvaluationState, ImportResolver,
};
use std::{
any::Any,
@@ -55,10 +56,9 @@
let result_str = result_raw.to_str().unwrap();
assert!(success == 0 || success == 1);
if success == 0 {
+ unsafe { CString::from_raw(result_ptr) };
let result = result_str.to_owned();
- let err = Err(create_error(Error::ImportCallbackError(result)));
- unsafe { CString::from_raw(result_ptr) };
- return err;
+ throw!(ImportCallbackError(result));
}
let found_here_raw = unsafe { CStr::from_ptr(found_here) };
@@ -121,15 +121,14 @@
return Ok(Rc::new(cloned));
}
}
- create_error_result(Error::ImportFileNotFound(from.clone(), path.clone()))
+ throw!(ImportFileNotFound(from.clone(), path.clone()))
}
}
fn load_file_contents(&self, id: &PathBuf) -> Result<Rc<str>> {
- let mut file =
- File::open(id).map_err(|_e| create_error(Error::ResolvedFileNotFound(id.clone())))?;
+ let mut file = File::open(id).map_err(|_e| ResolvedFileNotFound(id.clone()))?;
let mut out = String::new();
file.read_to_string(&mut out)
- .map_err(|_e| create_error(Error::ImportBadFileUtf8(id.clone())))?;
+ .map_err(|_e| ImportBadFileUtf8(id.clone()))?;
Ok(out.into())
}
unsafe fn as_any(&self) -> &dyn Any {
cmds/jrsonnet/src/main.rsdiffbeforeafterboth--- a/cmds/jrsonnet/src/main.rs
+++ b/cmds/jrsonnet/src/main.rs
@@ -1,6 +1,6 @@
use clap::Clap;
use jrsonnet_cli::{ConfigureState, GeneralOpts, InputOpts, ManifestOpts};
-use jrsonnet_evaluator::{EvaluationState, Result};
+use jrsonnet_evaluator::{error::Result, EvaluationState};
use std::{path::PathBuf, rc::Rc};
#[global_allocator]
crates/jrsonnet-cli/src/ext.rsdiffbeforeafterboth--- a/crates/jrsonnet-cli/src/ext.rs
+++ b/crates/jrsonnet-cli/src/ext.rs
@@ -1,6 +1,6 @@
use crate::ConfigureState;
use clap::Clap;
-use jrsonnet_evaluator::{EvaluationState, Result};
+use jrsonnet_evaluator::{error::Result, EvaluationState};
use std::str::FromStr;
#[derive(Clone)]
crates/jrsonnet-cli/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-cli/src/lib.rs
+++ b/crates/jrsonnet-cli/src/lib.rs
@@ -9,7 +9,7 @@
pub use trace::*;
use clap::Clap;
-use jrsonnet_evaluator::{EvaluationState, FileImportResolver, Result};
+use jrsonnet_evaluator::{error::Result, EvaluationState, FileImportResolver};
use std::path::PathBuf;
pub trait ConfigureState {
crates/jrsonnet-cli/src/manifest.rsdiffbeforeafterboth--- a/crates/jrsonnet-cli/src/manifest.rs
+++ b/crates/jrsonnet-cli/src/manifest.rs
@@ -1,6 +1,6 @@
use crate::ConfigureState;
use clap::Clap;
-use jrsonnet_evaluator::{EvaluationState, ManifestFormat, Result};
+use jrsonnet_evaluator::{error::Result, EvaluationState, ManifestFormat};
use std::str::FromStr;
pub enum ManifestFormatName {
crates/jrsonnet-cli/src/tla.rsdiffbeforeafterboth--- a/crates/jrsonnet-cli/src/tla.rs
+++ b/crates/jrsonnet-cli/src/tla.rs
@@ -1,6 +1,6 @@
use crate::{ConfigureState, ExtStr};
use clap::Clap;
-use jrsonnet_evaluator::{EvaluationState, Result};
+use jrsonnet_evaluator::{error::Result, EvaluationState};
#[derive(Clap)]
// #[clap(help_heading = "TOP LEVEL ARGUMENTS")]
crates/jrsonnet-cli/src/trace.rsdiffbeforeafterboth--- a/crates/jrsonnet-cli/src/trace.rs
+++ b/crates/jrsonnet-cli/src/trace.rs
@@ -1,8 +1,9 @@
use crate::ConfigureState;
use clap::Clap;
use jrsonnet_evaluator::{
+ error::Result,
trace::{CompactFormat, ExplainingFormat, PathResolver},
- EvaluationState, Result,
+ EvaluationState,
};
use std::str::FromStr;
crates/jrsonnet-evaluator/src/builtin/format.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/builtin/format.rs
+++ b/crates/jrsonnet-evaluator/src/builtin/format.rs
@@ -1,31 +1,32 @@
//! faster std.format impl
#![allow(clippy::too_many_arguments)]
-use crate::{
- create_error, create_error_result, to_string, Error, LocError, ObjValue, Val, ValType,
-};
+use crate::{error::Error::*, throw, to_string, LocError, ObjValue, Result, Val, ValType};
-#[derive(Debug)]
+#[derive(Debug, Clone)]
pub enum FormatError {
TruncatedFormatCode,
UnrecognizedConversionType(char),
- ValueError(LocError),
NotEnoughValues,
CannotUseStarWidthWithObject,
MappingKeysRequired,
- NoSuchField(Rc<str>),
+ NoSuchFormatField(Rc<str>),
}
-impl From<LocError> for FormatError {
- fn from(e: LocError) -> Self {
- Self::ValueError(e)
+
+impl From<FormatError> for LocError {
+ fn from(e: FormatError) -> Self {
+ Self::new(Format(e))
}
}
+
use std::rc::Rc;
use FormatError::*;
-pub fn try_parse_mapping_key(str: &str) -> Result<(&str, &str), FormatError> {
+type ParseResult<'t, T> = std::result::Result<(T, &'t str), FormatError>;
+
+pub fn try_parse_mapping_key(str: &str) -> ParseResult<&str> {
if str.is_empty() {
return Err(TruncatedFormatCode);
}
@@ -84,7 +85,7 @@
pub sign: bool,
}
-pub fn try_parse_cflags(str: &str) -> Result<(CFlags, &str), FormatError> {
+pub fn try_parse_cflags(str: &str) -> ParseResult<CFlags> {
if str.is_empty() {
return Err(TruncatedFormatCode);
}
@@ -113,7 +114,7 @@
Star,
Fixed(usize),
}
-pub fn try_parse_field_width(str: &str) -> Result<(Width, &str), FormatError> {
+pub fn try_parse_field_width(str: &str) -> ParseResult<Width> {
if str.is_empty() {
return Err(TruncatedFormatCode);
}
@@ -134,7 +135,7 @@
Ok((Width::Fixed(out), &str[digits..]))
}
-pub fn try_parse_precision(str: &str) -> Result<(Option<Width>, &str), FormatError> {
+pub fn try_parse_precision(str: &str) -> ParseResult<Option<Width>> {
if str.is_empty() {
return Err(TruncatedFormatCode);
}
@@ -147,7 +148,7 @@
}
// Only skips
-pub fn try_parse_length_modifier(str: &str) -> Result<&str, FormatError> {
+pub fn try_parse_length_modifier(str: &str) -> ParseResult<()> {
if str.is_empty() {
return Err(TruncatedFormatCode);
}
@@ -159,10 +160,10 @@
return Err(TruncatedFormatCode);
}
}
- Ok(&str[idx..])
+ Ok(((), &str[idx..]))
}
-#[derive(Debug)]
+#[derive(Debug, PartialEq)]
pub enum ConvTypeV {
Decimal,
Octal,
@@ -179,7 +180,7 @@
caps: bool,
}
-pub fn parse_conversion_type(str: &str) -> Result<(ConvType, &str), FormatError> {
+pub fn parse_conversion_type(str: &str) -> ParseResult<ConvType> {
if str.is_empty() {
return Err(TruncatedFormatCode);
}
@@ -214,7 +215,7 @@
convtype: ConvTypeV,
caps: bool,
}
-pub fn parse_code(str: &str) -> Result<(Code, &str), FormatError> {
+pub fn parse_code(str: &str) -> ParseResult<Code> {
if str.is_empty() {
return Err(TruncatedFormatCode);
}
@@ -222,7 +223,7 @@
let (cflags, str) = try_parse_cflags(str)?;
let (width, str) = try_parse_field_width(str)?;
let (precision, str) = try_parse_precision(str)?;
- let str = try_parse_length_modifier(str)?;
+ let (_, str) = try_parse_length_modifier(str)?;
let (convtype, str) = parse_conversion_type(str)?;
Ok((
@@ -243,7 +244,7 @@
String(&'s str),
Code(Code<'s>),
}
-pub fn parse_codes(mut str: &str) -> Result<Vec<Element>, FormatError> {
+pub fn parse_codes(mut str: &str) -> Result<Vec<Element>> {
let mut bytes = str.as_bytes();
let mut out = vec![];
let mut offset = 0;
@@ -453,7 +454,7 @@
code: &Code,
width: usize,
precision: Option<usize>,
-) -> Result<(), FormatError> {
+) -> Result<()> {
let clfags = &code.cflags;
let (fpprec, iprec) = match precision {
Some(v) => (v, v),
@@ -565,22 +566,22 @@
ConvTypeV::Char => match value.clone().unwrap_if_lazy()? {
Val::Num(n) => tmp_out.push(
std::char::from_u32(n as u32)
- .ok_or_else(|| create_error(Error::InvalidUnicodeCodepointGot(n as u32)))?,
+ .ok_or_else(|| InvalidUnicodeCodepointGot(n as u32))?,
),
Val::Str(s) => {
if s.chars().count() != 1 {
- create_error_result(Error::RuntimeError(
+ throw!(RuntimeError(
format!("%c expected 1 char string, got {}", s.chars().count()).into(),
- ))?;
+ ));
}
tmp_out.push_str(&s);
}
_ => {
- create_error_result(Error::TypeMismatch(
+ throw!(TypeMismatch(
"%c requires number/string",
vec![ValType::Num, ValType::Str],
value.value_type()?,
- ))?;
+ ));
}
},
ConvTypeV::Percent => tmp_out.push('%'),
@@ -603,7 +604,7 @@
Ok(())
}
-pub fn format_arr(str: &str, mut values: &[Val]) -> Result<String, FormatError> {
+pub fn format_arr(str: &str, mut values: &[Val]) -> Result<String> {
let codes = parse_codes(&str)?;
let mut out = String::new();
@@ -616,7 +617,7 @@
let width = match c.width {
Width::Star => {
if values.is_empty() {
- return Err(FormatError::NotEnoughValues);
+ throw!(NotEnoughValues);
}
let value = &values[0];
values = &values[1..];
@@ -627,7 +628,7 @@
let precision = match c.precision {
Some(Width::Star) => {
if values.is_empty() {
- return Err(FormatError::NotEnoughValues);
+ throw!(NotEnoughValues);
}
let value = &values[0];
values = &values[1..];
@@ -642,7 +643,7 @@
&Val::Null
} else {
if values.is_empty() {
- return Err(FormatError::NotEnoughValues);
+ throw!(NotEnoughValues);
}
let value = &values[0];
values = &values[1..];
@@ -657,7 +658,7 @@
Ok(out)
}
-pub fn format_obj(str: &str, values: &ObjValue) -> Result<String, FormatError> {
+pub fn format_obj(str: &str, values: &ObjValue) -> Result<String> {
let codes = parse_codes(&str)?;
let mut out = String::new();
@@ -670,17 +671,17 @@
// TODO: Operate on ref
let f: Rc<str> = c.mkey.into();
if f.is_empty() {
- return Err(FormatError::MappingKeysRequired);
+ throw!(MappingKeysRequired);
}
let width = match c.width {
Width::Star => {
- return Err(FormatError::CannotUseStarWidthWithObject);
+ throw!(CannotUseStarWidthWithObject);
}
Width::Fixed(n) => n,
};
let precision = match c.precision {
Some(Width::Star) => {
- return Err(FormatError::CannotUseStarWidthWithObject);
+ throw!(CannotUseStarWidthWithObject);
}
Some(Width::Fixed(n)) => Some(n),
None => None,
@@ -688,7 +689,7 @@
let value = if let Some(v) = values.get(f.clone())? {
v
} else {
- return Err(FormatError::NoSuchField(f));
+ throw!(NoSuchFormatField(f));
};
format_code(&mut out, &value, &c, width, precision)?;
crates/jrsonnet-evaluator/src/ctx.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/ctx.rs
+++ b/crates/jrsonnet-evaluator/src/ctx.rs
@@ -1,5 +1,5 @@
use crate::{
- create_error, future_wrapper, map::LayeredHashMap, rc_fn_helper, resolved_lazy_val, Error,
+ error::Error::*, future_wrapper, map::LayeredHashMap, rc_fn_helper, resolved_lazy_val,
LazyBinding, LazyVal, ObjValue, Result, Val,
};
use std::{
@@ -61,11 +61,12 @@
}
pub fn binding(&self, name: Rc<str>) -> Result<LazyVal> {
- self.0
+ Ok(self
+ .0
.bindings
.get(&name)
.cloned()
- .ok_or_else(|| create_error(Error::UnknownVariable(name)))
+ .ok_or_else(|| UnknownVariable(name))?)
}
pub fn into_future(self, ctx: FutureContext) -> Context {
{
crates/jrsonnet-evaluator/src/error.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/error.rs
+++ b/crates/jrsonnet-evaluator/src/error.rs
@@ -1,4 +1,4 @@
-use crate::{Val, ValType};
+use crate::{builtin::format::FormatError, Val, ValType};
use jrsonnet_parser::{BinaryOpType, ExprLocation, UnaryOpType};
use std::{path::PathBuf, rc::Rc};
@@ -61,7 +61,14 @@
ImportCallbackError(String),
InvalidUnicodeCodepointGot(u32),
+
+ Format(FormatError),
}
+impl From<Error> for LocError {
+ fn from(e: Error) -> Self {
+ Self(e, StackTrace(vec![]))
+ }
+}
#[derive(Clone, Debug)]
pub struct StackTraceElement {
@@ -73,4 +80,17 @@
#[derive(Debug, Clone)]
pub struct LocError(pub Error, pub StackTrace);
+impl LocError {
+ pub fn new(e: Error) -> Self {
+ Self(e, StackTrace(vec![]))
+ }
+}
+
pub type Result<V> = std::result::Result<V, LocError>;
+
+#[macro_export]
+macro_rules! throw {
+ ($e: expr) => {
+ return Err($e.into());
+ };
+}
crates/jrsonnet-evaluator/src/evaluate.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate.rs
@@ -1,9 +1,10 @@
use crate::{
builtin::format::{format_arr, format_obj},
- context_creator, create_error, create_error_result, equals, escape_string_json, future_wrapper,
- lazy_val, manifest_json_ex, parse_args, primitive_equals, push, with_state, Context,
- ContextCreator, Error, FuncDesc, LazyBinding, LazyVal, ObjMember, ObjValue, Result, Val,
- ValType,
+ context_creator, equals,
+ error::Error::*,
+ escape_string_json, future_wrapper, lazy_val, manifest_json_ex, parse_args, primitive_equals,
+ push, throw, with_state, Context, ContextCreator, FuncDesc, LazyBinding, LazyVal, LocError,
+ ObjMember, ObjValue, Result, Val, ValType,
};
use closure::closure;
use jrsonnet_parser::{
@@ -11,7 +12,7 @@
ForSpecData, IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc, UnaryOpType,
Visibility,
};
-use std::{cmp::Ordering, collections::HashMap, rc::Rc};
+use std::{cmp::Ordering, collections::HashMap, path::PathBuf, rc::Rc};
pub fn evaluate_binding(b: &BindSpec, context_creator: ContextCreator) -> (Rc<str>, LazyBinding) {
let b = b.clone();
@@ -79,10 +80,7 @@
(UnaryOpType::Not, Val::Bool(v)) => Val::Bool(!v),
(UnaryOpType::Minus, Val::Num(n)) => Val::Num(-*n),
(UnaryOpType::BitNot, Val::Num(n)) => Val::Num(!(*n as i32) as f64),
- (op, o) => create_error_result(Error::UnaryOperatorDoesNotOperateOnType(
- op,
- o.value_type()?,
- ))?,
+ (op, o) => throw!(UnaryOperatorDoesNotOperateOnType(op, o.value_type()?)),
})
}
@@ -100,11 +98,11 @@
(Val::Obj(v1), Val::Obj(v2)) => Val::Obj(v2.with_super(v1.clone())),
(Val::Arr(a), Val::Arr(b)) => Val::Arr(Rc::new([&a[..], &b[..]].concat())),
(Val::Num(v1), Val::Num(v2)) => Val::new_checked_num(v1 + v2)?,
- _ => create_error_result(Error::BinaryOperatorDoesNotOperateOnValues(
+ _ => throw!(BinaryOperatorDoesNotOperateOnValues(
BinaryOpType::Add,
a.value_type()?,
b.value_type()?,
- ))?,
+ )),
})
}
@@ -145,7 +143,7 @@
(Val::Num(v1), BinaryOpType::Mul, Val::Num(v2)) => Val::new_checked_num(v1 * v2)?,
(Val::Num(v1), BinaryOpType::Div, Val::Num(v2)) => {
if *v2 <= f64::EPSILON {
- create_error_result(crate::Error::DivisionByZero)?
+ throw!(DivisionByZero)
}
Val::new_checked_num(v1 / v2)?
}
@@ -168,22 +166,22 @@
}
(Val::Num(v1), BinaryOpType::Lhs, Val::Num(v2)) => {
if *v2 < 0.0 {
- create_error_result(Error::RuntimeError("shift by negative exponent".into()))?
+ throw!(RuntimeError("shift by negative exponent".into()))
}
Val::Num(((*v1 as i32) << (*v2 as i32)) as f64)
}
(Val::Num(v1), BinaryOpType::Rhs, Val::Num(v2)) => {
if *v2 < 0.0 {
- create_error_result(Error::RuntimeError("shift by negative exponent".into()))?
+ throw!(RuntimeError("shift by negative exponent".into()))
}
Val::Num(((*v1 as i32) >> (*v2 as i32)) as f64)
}
- _ => create_error_result(Error::BinaryOperatorDoesNotOperateOnValues(
+ _ => throw!(BinaryOperatorDoesNotOperateOnValues(
op,
a.value_type()?,
b.value_type()?,
- ))?,
+ )),
})
}
@@ -218,7 +216,7 @@
}
Some(out.into_iter().flatten().flatten().collect())
}
- _ => create_error_result(Error::InComprehensionCanOnlyIterateOverArray)?,
+ _ => throw!(InComprehensionCanOnlyIterateOverArray),
}
}
})
@@ -379,7 +377,7 @@
},
);
}
- v => create_error_result(Error::FieldMustBeStringGot(v.value_type()?))?,
+ v => throw!(FieldMustBeStringGot(v.value_type()?)),
}
}
@@ -409,7 +407,7 @@
Ok(match value {
Val::Intristic(ns, name) => match (&ns as &str, &name as &str) {
// arr/string/function
- ("std", "length") => noinline!(parse_args!(context, "std.length", args, 1, [
+ ("std", "length") => parse_args!(context, "std.length", args, 1, [
0, x: [Val::Str|Val::Arr|Val::Obj], vec![ValType::Str, ValType::Arr, ValType::Obj];
], {
Ok(match x {
@@ -423,20 +421,20 @@
),
_ => unreachable!(),
})
- }))?,
+ })?,
// any
("std", "type") => parse_args!(context, "std.type", args, 1, [
0, x, vec![];
], {
- Val::Str(x.value_type()?.name().into())
- }),
+ Ok(Val::Str(x.value_type()?.name().into()))
+ })?,
// length, idx=>any
("std", "makeArray") => noinline!(parse_args!(context, "std.makeArray", args, 2, [
0, sz: [Val::Num]!!Val::Num, vec![ValType::Num];
1, func: [Val::Func]!!Val::Func, vec![ValType::Func];
], {
if sz < 0.0 {
- create_error_result(crate::error::Error::RuntimeError(format!("makeArray requires size >= 0, got {}", sz).into()))?;
+ throw!(RuntimeError(format!("makeArray requires size >= 0, got {}", sz).into()));
}
let mut out = Vec::with_capacity(sz as usize);
for i in 0..sz as usize {
@@ -455,8 +453,8 @@
str.chars().count() == 1,
"std.codepoint should receive single char string"
);
- Val::Num(str.chars().take(1).next().unwrap() as u32 as f64)
- }),
+ Ok(Val::Num(str.chars().take(1).next().unwrap() as u32 as f64))
+ })?,
// object, includeHidden
("std", "objectFieldsEx") => {
noinline!(parse_args!(context, "std.objectFieldsEx",args, 2, [
@@ -478,42 +476,42 @@
1, f: [Val::Str]!!Val::Str, vec![ValType::Str];
2, inc_hidden: [Val::Bool]!!Val::Bool, vec![ValType::Bool];
], {
- Val::Bool(
+ Ok(Val::Bool(
obj.fields_visibility()
.into_iter()
.filter(|(_k, v)| *v || inc_hidden)
.any(|(k, _v)| *k == *f),
- )
- }),
+ ))
+ })?,
("std", "primitiveEquals") => parse_args!(context, "std.primitiveEquals", args, 2, [
0, a, vec![];
1, b, vec![];
], {
- Val::Bool(primitive_equals(&a, &b)?)
- }),
+ Ok(Val::Bool(primitive_equals(&a, &b)?))
+ })?,
// faster
("std", "equals") => parse_args!(context, "std.equals", args, 2, [
0, a, vec![];
1, b, vec![];
], {
- Val::Bool(equals(&a, &b)?)
- }),
+ Ok(Val::Bool(equals(&a, &b)?))
+ })?,
("std", "modulo") => parse_args!(context, "std.modulo", args, 2, [
0, a: [Val::Num]!!Val::Num, vec![ValType::Num];
1, b: [Val::Num]!!Val::Num, vec![ValType::Num];
], {
- Val::Num(a % b)
- }),
+ Ok(Val::Num(a % b))
+ })?,
("std", "floor") => parse_args!(context, "std.floor", args, 1, [
0, x: [Val::Num]!!Val::Num, vec![ValType::Num];
], {
- Val::Num(x.floor())
- }),
+ Ok(Val::Num(x.floor()))
+ })?,
("std", "log") => parse_args!(context, "std.log", args, 2, [
0, n: [Val::Num]!!Val::Num, vec![ValType::Num];
], {
- Val::Num(n.ln())
- }),
+ Ok(Val::Num(n.ln()))
+ })?,
("std", "trace") => parse_args!(context, "std.trace", args, 2, [
0, str: [Val::Str]!!Val::Str, vec![ValType::Str];
1, rest, vec![];
@@ -526,21 +524,21 @@
});
}
eprintln!(" {}", str);
- rest
- }),
+ Ok(rest)
+ })?,
("std", "pow") => parse_args!(context, "std.modulo", args, 2, [
0, x: [Val::Num]!!Val::Num, vec![ValType::Num];
1, n: [Val::Num]!!Val::Num, vec![ValType::Num];
], {
- Val::Num(x.powf(n))
- }),
+ Ok(Val::Num(x.powf(n)))
+ })?,
("std", "extVar") => parse_args!(context, "std.extVar", args, 2, [
0, x: [Val::Str]!!Val::Str, vec![ValType::Str];
], {
- with_state(|s| s.settings().ext_vars.get(&x).cloned()).ok_or_else(
- || create_error(crate::Error::UndefinedExternalVariable(x)),
- )?
- }),
+ Ok(with_state(|s| s.settings().ext_vars.get(&x).cloned()).ok_or_else(
+ || UndefinedExternalVariable(x),
+ )?)
+ })?,
("std", "filter") => noinline!(parse_args!(context, "std.filter", args, 2, [
0, func: [Val::Func]!!Val::Func, vec![ValType::Func];
1, arr: [Val::Arr]!!Val::Arr, vec![ValType::Arr];
@@ -583,6 +581,7 @@
Ok(acc)
}))?,
// faster
+ #[allow(non_snake_case)]
("std", "sortImpl") => noinline!(parse_args!(context, "std.sort", args, 2, [
0, arr: [Val::Arr]!!Val::Arr, vec![ValType::Arr];
1, keyF: [Val::Func]!!Val::Func, vec![ValType::Func];
@@ -598,7 +597,7 @@
match keyF.evaluate_values(context.clone(), &[k.clone()]) {
Ok(Val::Str(v)) => v,
Ok(_) => {
- err = Some(create_error(crate::error::Error::RuntimeError("types of all array elements should equal".into())));
+ err = Some(LocError::new(RuntimeError("types of all array elements should equal".into())));
"".into()
}
Err(e) => {
@@ -617,7 +616,7 @@
match (keyF.evaluate_values(context.clone(), &[a.clone()]), keyF.evaluate_values(context.clone(), &[b.clone()])) {
(Ok(Val::Num(a)), Ok(Val::Num(b))) => a.partial_cmp(&b).unwrap(),
(Ok(_a), Ok(_b)) => {
- err = Some(create_error(crate::error::Error::RuntimeError("types of all array elements should equal".into())));
+ err = Some(RuntimeError("types of all array elements should equal".into()).into());
Ordering::Equal
}
(Err(e), _) | (_, Err(e)) => {
@@ -630,21 +629,23 @@
return Err(e);
}
},
- _ => return Err(create_error(crate::error::Error::RuntimeError("keys should be number or string".into())))
+ _ => throw!(RuntimeError("keys should be number or string".into()))
}
Ok(Val::Arr(Rc::new(new_arr)))
}))?,
// faster
("std", "format") => parse_args!(context, "std.format", args, 2, [
0, str: [Val::Str]!!Val::Str, vec![ValType::Str];
- 1, vals: [Val::Arr|Val::Obj], vec![ValType::Arr, ValType::Obj];
+ 1, vals, vec![]
], {
- match vals {
- Val::Arr(vals) => Val::Str(format_arr(&str, &vals).unwrap().into()),
- Val::Obj(obj) => Val::Str(format_obj(&str, &obj).unwrap().into()),
- _ => unreachable!()
- }
- }),
+ push(&Some(ExprLocation(Rc::from(PathBuf::from("std.jsonnet")), 0, 0)), ||format!("std.format of {}", str), ||{
+ Ok(match vals {
+ Val::Arr(vals) => Val::Str(format_arr(&str, &vals)?.into()),
+ Val::Obj(obj) => Val::Str(format_obj(&str, &obj)?.into()),
+ o => Val::Str(format_arr(&str, &[o])?.into()),
+ })
+ })
+ })?,
// faster
("std", "range") => parse_args!(context, "std.range", args, 2, [
0, from: [Val::Num]!!Val::Num, vec![ValType::Num];
@@ -654,22 +655,22 @@
for i in from as usize..=to as usize {
out.push(Val::Num(i as f64));
}
- Val::Arr(Rc::new(out))
- }),
+ Ok(Val::Arr(Rc::new(out)))
+ })?,
("std", "char") => parse_args!(context, "std.char", args, 1, [
0, n: [Val::Num]!!Val::Num, vec![ValType::Num];
], {
let mut out = String::new();
out.push(std::char::from_u32(n as u32).ok_or_else(||
- create_error(crate::error::Error::InvalidUnicodeCodepointGot(n as u32))
+ InvalidUnicodeCodepointGot(n as u32)
)?);
Ok(Val::Str(out.into()))
})?,
("std", "encodeUTF8") => parse_args!(context, "std.encodeUtf8", args, 1, [
0, str: [Val::Str]!!Val::Str, vec![ValType::Str];
], {
- Val::Arr(Rc::new(str.bytes().map(|b| Val::Num(b as f64)).collect()))
- }),
+ Ok(Val::Arr(Rc::new(str.bytes().map(|b| Val::Num(b as f64)).collect())))
+ })?,
("std", "md5") => noinline!(parse_args!(context, "std.md5", args, 1, [
0, str: [Val::Str]!!Val::Str, vec![ValType::Str];
], {
@@ -679,7 +680,7 @@
("std", "base64") => parse_args!(context, "std.base64", args, 1, [
0, input: [Val::Str | Val::Arr], vec![ValType::Arr, ValType::Str];
], {
- Val::Str(match input {
+ Ok(Val::Str(match input {
Val::Str(s) => {
base64::encode(s.bytes().collect::<Vec<_>>()).into()
},
@@ -689,8 +690,8 @@
}).collect::<Result<Vec<_>>>()?).into()
},
_ => unreachable!()
- })
- }),
+ }))
+ })?,
// faster
("std", "join") => noinline!(parse_args!(context, "std.join", args, 2, [
0, sep: [Val::Str|Val::Arr], vec![ValType::Str, ValType::Arr];
@@ -711,7 +712,7 @@
out.reserve(items.len());
out.extend(items.iter().cloned());
} else {
- create_error_result(crate::Error::RuntimeError("in std.join all items should be arrays".into()))?;
+ throw!(RuntimeError("in std.join all items should be arrays".into()));
}
}
@@ -729,7 +730,7 @@
first = false;
out += &item;
} else {
- create_error_result(crate::Error::RuntimeError("in std.join all items should be strings".into()))?;
+ throw!(RuntimeError("in std.join all items should be strings".into()));
}
}
@@ -742,18 +743,16 @@
("std", "escapeStringJson") => parse_args!(context, "std.escapeStringJson", args, 1, [
0, str_: [Val::Str]!!Val::Str, vec![ValType::Str];
], {
- Val::Str(escape_string_json(&str_).into())
- }),
+ Ok(Val::Str(escape_string_json(&str_).into()))
+ })?,
// Faster
("std", "manifestJsonEx") => parse_args!(context, "std.manifestJsonEx", args, 2, [
0, value, vec![];
1, indent: [Val::Str]!!Val::Str, vec![ValType::Str];
], {
- Val::Str(manifest_json_ex(&value, &indent)?.into())
- }),
- (ns, name) => {
- create_error_result(crate::Error::IntristicNotFound(ns.into(), name.into()))?
- }
+ Ok(Val::Str(manifest_json_ex(&value, &indent)?.into()))
+ })?,
+ (ns, name) => throw!(IntristicNotFound(ns.into(), name.into())),
},
Val::Func(f) => {
let body = || f.evaluate(context, args, tailstrict);
@@ -763,7 +762,7 @@
push(loc, || format!("function <{}> call", f.name), body)?
}
}
- v => create_error_result(crate::Error::OnlyFunctionsCanBeCalledGot(v.value_type()?))?,
+ v => throw!(OnlyFunctionsCanBeCalledGot(v.value_type()?)),
})
}
@@ -784,13 +783,13 @@
context
.this()
.clone()
- .ok_or_else(|| create_error(crate::Error::CantUseSelfOutsideOfObject))?,
+ .ok_or_else(|| CantUseSelfOutsideOfObject)?,
),
Literal(LiteralType::Dollar) => Val::Obj(
context
.dollar()
.clone()
- .ok_or_else(|| create_error(crate::Error::NoTopLevelObjectFound))?,
+ .ok_or_else(|| NoTopLevelObjectFound)?,
),
Literal(LiteralType::True) => Val::Bool(true),
Literal(LiteralType::False) => Val::Bool(false),
@@ -825,34 +824,30 @@
} else if let Some(Val::Str(n)) = v.get("__intristic_namespace__".into())? {
Val::Intristic(n, s)
} else {
- create_error_result(crate::Error::NoSuchField(s))?
+ throw!(NoSuchField(s))
}
}
- (Val::Obj(_), n) => create_error_result(crate::Error::ValueIndexMustBeTypeGot(
+ (Val::Obj(_), n) => throw!(ValueIndexMustBeTypeGot(
ValType::Obj,
ValType::Str,
n.value_type()?,
- ))?,
+ )),
(Val::Arr(v), Val::Num(n)) => {
if n.fract() > f64::EPSILON {
- create_error_result(crate::Error::FractionalIndex)?
+ throw!(FractionalIndex)
}
v.get(n as usize)
- .ok_or_else(|| {
- create_error(crate::Error::ArrayBoundsError(n as usize, v.len()))
- })?
+ .ok_or_else(|| ArrayBoundsError(n as usize, v.len()))?
.clone()
.unwrap_if_lazy()?
- }
- (Val::Arr(_), Val::Str(n)) => {
- create_error_result(crate::Error::AttemptedIndexAnArrayWithString(n))?
}
- (Val::Arr(_), n) => create_error_result(crate::Error::ValueIndexMustBeTypeGot(
+ (Val::Arr(_), Val::Str(n)) => throw!(AttemptedIndexAnArrayWithString(n)),
+ (Val::Arr(_), n) => throw!(ValueIndexMustBeTypeGot(
ValType::Arr,
ValType::Num,
n.value_type()?,
- ))?,
+ )),
(Val::Str(s), Val::Num(n)) => Val::Str(
s.chars()
@@ -861,13 +856,13 @@
.collect::<String>()
.into(),
),
- (Val::Str(_), n) => create_error_result(crate::Error::ValueIndexMustBeTypeGot(
+ (Val::Str(_), n) => throw!(ValueIndexMustBeTypeGot(
ValType::Str,
ValType::Num,
n.value_type()?,
- ))?,
+ )),
- (v, _) => create_error_result(crate::Error::CantIndexInto(v.value_type()?))?,
+ (v, _) => throw!(CantIndexInto(v.value_type()?)),
}
}
LocalExpr(bindings, returned) => {
@@ -926,18 +921,18 @@
if assertion_result {
evaluate(context, returned)?
} else if let Some(msg) = msg {
- create_error_result(crate::Error::AssertionFailed(evaluate(context, msg)?))?
+ throw!(AssertionFailed(evaluate(context, msg)?));
} else {
- create_error_result(crate::Error::AssertionFailed(Val::Null))?
+ throw!(AssertionFailed(Val::Null));
}
}
- Error(e) => push(
+ ErrorStmt(e) => push(
&loc,
|| "error statement".to_owned(),
|| {
- create_error_result(crate::Error::RuntimeError(
+ throw!(RuntimeError(
evaluate(context, e)?.try_cast_str("error text should be string")?,
- ))?
+ ))
},
)?,
IfElse {
@@ -978,6 +973,6 @@
import_location.pop();
Val::Str(with_state(|s| s.import_file_str(&import_location, path))?)
}
- Literal(LiteralType::Super) => return create_error_result(crate::Error::StandaloneSuper),
+ Literal(LiteralType::Super) => throw!(StandaloneSuper),
})
}
crates/jrsonnet-evaluator/src/function.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/function.rs
+++ b/crates/jrsonnet-evaluator/src/function.rs
@@ -1,7 +1,4 @@
-use crate::{
- create_error, create_error_result, evaluate, lazy_val, resolved_lazy_val, Context, Error,
- Result, Val,
-};
+use crate::{error::Error::*, evaluate, lazy_val, resolved_lazy_val, throw, Context, Result, Val};
use closure::closure;
use jrsonnet_parser::{ArgsDesc, ParamsDesc};
use std::{collections::HashMap, rc::Rc};
@@ -30,16 +27,16 @@
params
.iter()
.position(|p| *p.0 == *name)
- .ok_or_else(|| create_error(Error::UnknownFunctionParameter(name.clone())))?
+ .ok_or_else(|| UnknownFunctionParameter(name.clone()))?
} else {
id
};
if idx >= params.len() {
- create_error_result(Error::TooManyArgsFunctionHas(params.len()))?;
+ throw!(TooManyArgsFunctionHas(params.len()));
}
if positioned_args[idx].is_some() {
- create_error_result(Error::BindingParameterASecondTime(params[idx].0.clone()))?;
+ throw!(BindingParameterASecondTime(params[idx].0.clone()));
}
positioned_args[idx] = Some(arg.1.clone());
}
@@ -50,8 +47,7 @@
} else if let Some(default) = &p.1 {
(body_ctx.clone().expect(NO_DEFAULT_CONTEXT), default)
} else {
- create_error_result(Error::FunctionParameterNotBoundInCall(p.0.clone()))?;
- unreachable!()
+ throw!(FunctionParameterNotBoundInCall(p.0.clone()));
};
let val = if tailstrict {
resolved_lazy_val!(evaluate(ctx, expr)?)
@@ -74,15 +70,16 @@
let mut out = HashMap::new();
let mut positioned_args = vec![None; params.0.len()];
for (name, val) in args.iter() {
- let idx = params.iter().position(|p| *p.0 == **name).ok_or_else(|| {
- create_error(Error::UnknownFunctionParameter((&name as &str).to_owned()))
- })?;
+ let idx = params
+ .iter()
+ .position(|p| *p.0 == **name)
+ .ok_or_else(|| UnknownFunctionParameter((&name as &str).to_owned()))?;
if idx >= params.len() {
- create_error_result(Error::TooManyArgsFunctionHas(params.len()))?;
+ throw!(TooManyArgsFunctionHas(params.len()));
}
if positioned_args[idx].is_some() {
- create_error_result(Error::BindingParameterASecondTime(params[idx].0.clone()))?;
+ throw!(BindingParameterASecondTime(params[idx].0.clone()));
}
positioned_args[idx] = Some(val.clone());
}
@@ -104,8 +101,7 @@
})
}
} else {
- create_error_result(Error::FunctionParameterNotBoundInCall(p.0.clone()))?;
- unreachable!()
+ throw!(FunctionParameterNotBoundInCall(p.0.clone()));
};
out.insert(p.0.clone(), val);
}
@@ -123,7 +119,7 @@
let mut positioned_args = vec![None; params.0.len()];
for (id, arg) in args.iter().enumerate() {
if id >= params.len() {
- create_error_result(Error::TooManyArgsFunctionHas(params.len()))?;
+ throw!(TooManyArgsFunctionHas(params.len()));
}
positioned_args[id] = Some(arg);
}
@@ -134,8 +130,7 @@
} else if let Some(default) = &p.1 {
evaluate(ctx.clone(), default)?
} else {
- create_error_result(Error::FunctionParameterNotBoundInCall(p.0.clone()))?;
- unreachable!()
+ throw!(FunctionParameterNotBoundInCall(p.0.clone()));
};
out.insert(p.0.clone(), resolved_lazy_val!(val));
}
@@ -148,36 +143,39 @@
($ctx: expr, $fn_name: expr, $args: expr, $total_args: expr, [
$($id: expr, $name: ident $(: [$($p: path)|+] $(!! $a: path)?)?, $nt: expr);+ $(;)?
], $handler:block) => {{
- use crate::Error;
+ use crate::{throw, error::Error::*};
let args = $args;
if args.len() > $total_args {
- create_error_result(Error::TooManyArgsFunctionHas($total_args))?;
+ throw!(TooManyArgsFunctionHas($total_args));
}
$(
if args.len() <= $id {
- create_error_result(Error::FunctionParameterNotBoundInCall(stringify!($name).into()))?;
+ throw!(FunctionParameterNotBoundInCall(stringify!($name).into()));
}
let $name = &args[$id];
if $name.0.is_some() {
if $name.0.as_ref().unwrap() != stringify!($name) {
- create_error_result(Error::IntristicArgumentReorderingIsNotSupportedYet)?;
+ throw!(IntristicArgumentReorderingIsNotSupportedYet);
}
}
let $name = evaluate($ctx.clone(), &$name.1)?;
$(
match $name {
$($p(_))|+ => {},
- _ => create_error_result(Error::TypeMismatch(concat!($fn_name, " ", stringify!($id), "nd (", stringify!($name), ") argument"), $nt, $name.value_type()?))?,
+ _ => throw!(TypeMismatch(
+ concat!($fn_name, " ", stringify!($id), "nd (", stringify!($name), ") argument"),
+ $nt, $name.value_type()?
+ )),
};
$(
let $name = match $name {
$a(v) => v,
- _ => create_error_result(Error::TypeMismatch(concat!($fn_name, " ", stringify!($id), "nd (", stringify!($name), ") argument"), $nt, $name.value_type()?))?,
+ _ =>throw!(TypeMismatch(concat!($fn_name, " ", stringify!($id), "nd (", stringify!($name), ") argument"), $nt, $name.value_type()?)),
};
)*
)*
)+
- $handler
+ ($handler as crate::Result<_>)
}};
}
@@ -198,7 +196,9 @@
], {
assert!((a - 2.0).abs() <= f64::EPSILON);
assert!((b - 1.0).abs() <= f64::EPSILON);
- });
+ Ok(())
+ })
+ .unwrap();
Ok(())
})
}
crates/jrsonnet-evaluator/src/import.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/import.rs
+++ b/crates/jrsonnet-evaluator/src/import.rs
@@ -1,7 +1,6 @@
-use crate::create_error_result;
use crate::{
- create_error,
- error::{Error, Result},
+ error::{Error::*, Result},
+ throw,
};
use fs::File;
use std::fs;
@@ -28,7 +27,7 @@
pub struct DummyImportResolver;
impl ImportResolver for DummyImportResolver {
fn resolve_file(&self, from: &PathBuf, path: &PathBuf) -> Result<Rc<PathBuf>> {
- create_error_result(Error::ImportNotSupported(from.clone(), path.clone()))
+ throw!(ImportNotSupported(from.clone(), path.clone()))
}
fn load_file_contents(&self, _resolved: &PathBuf) -> Result<Rc<str>> {
// Can be only caused by library direct consumer, not by supplied jsonnet
@@ -65,15 +64,14 @@
return Ok(Rc::new(cloned));
}
}
- create_error_result(Error::ImportFileNotFound(from.clone(), path.clone()))
+ throw!(ImportFileNotFound(from.clone(), path.clone()))
}
}
fn load_file_contents(&self, id: &PathBuf) -> Result<Rc<str>> {
- let mut file =
- File::open(id).map_err(|_e| create_error(Error::ResolvedFileNotFound(id.clone())))?;
+ let mut file = File::open(id).map_err(|_e| ResolvedFileNotFound(id.clone()))?;
let mut out = String::new();
file.read_to_string(&mut out)
- .map_err(|_e| create_error(Error::ImportBadFileUtf8(id.clone())))?;
+ .map_err(|_e| ImportBadFileUtf8(id.clone()))?;
Ok(out.into())
}
unsafe fn as_any(&self) -> &dyn Any {
crates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth1#![feature(box_syntax, box_patterns)]2#![feature(type_alias_impl_trait)]3#![feature(debug_non_exhaustive)]4#![feature(test)]5#![feature(stmt_expr_attributes)]6#![allow(macro_expanded_macro_exports_accessed_by_absolute_paths)]78extern crate test;910mod builtin;11mod ctx;12mod dynamic;13mod error;14mod evaluate;15mod function;16mod import;17mod map;18mod obj;19pub mod trace;20mod val;2122pub use ctx::*;23pub use dynamic::*;24pub use error::*;25pub use evaluate::*;26pub use function::parse_function_call;27pub use import::*;28use jrsonnet_parser::*;29pub use obj::*;30use std::{31 cell::{Ref, RefCell, RefMut},32 collections::HashMap,33 fmt::Debug,34 path::PathBuf,35 rc::Rc,36};37use trace::{offset_to_location, CodeLocation, CompactFormat, TraceFormat};38pub use val::*;3940type BindableFn = dyn Fn(Option<ObjValue>, Option<ObjValue>) -> Result<LazyVal>;41#[derive(Clone)]42pub enum LazyBinding {43 Bindable(Rc<BindableFn>),44 Bound(LazyVal),45}4647impl Debug for LazyBinding {48 fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {49 write!(f, "LazyBinding")50 }51}52impl LazyBinding {53 pub fn evaluate(&self, this: Option<ObjValue>, super_obj: Option<ObjValue>) -> Result<LazyVal> {54 match self {55 LazyBinding::Bindable(v) => v(this, super_obj),56 LazyBinding::Bound(v) => Ok(v.clone()),57 }58 }59}6061#[derive(Clone)]62pub enum ManifestFormat {63 Yaml(usize),64 Json(usize),65 None,66}6768pub struct EvaluationSettings {69 /// Limits recursion by limiting stack frames70 pub max_stack: usize,71 /// Limit amount of stack trace items preserved72 pub max_trace: usize,73 /// Used for std.extVar74 pub ext_vars: HashMap<Rc<str>, Val>,75 /// TLA vars76 pub tla_vars: HashMap<Rc<str>, Val>,77 /// Global variables are inserted in default context78 pub globals: HashMap<Rc<str>, Val>,79 /// Used to resolve file locations/contents80 pub import_resolver: Box<dyn ImportResolver>,81 /// Used in manifestification functions82 pub manifest_format: ManifestFormat,83 /// Used for bindings84 pub trace_format: Box<dyn TraceFormat>,85}86impl Default for EvaluationSettings {87 fn default() -> Self {88 EvaluationSettings {89 max_stack: 200,90 max_trace: 20,91 globals: Default::default(),92 ext_vars: Default::default(),93 tla_vars: Default::default(),94 import_resolver: Box::new(DummyImportResolver),95 manifest_format: ManifestFormat::Json(4),96 trace_format: Box::new(CompactFormat {97 padding: 4,98 resolver: trace::PathResolver::Absolute,99 }),100 }101 }102}103104#[derive(Default)]105struct EvaluationData {106 /// Used for stack overflow detection, stacktrace is now populated on unwind107 stack_depth: usize,108 /// Contains file source codes and evaluated results for imports and pretty109 /// printing stacktraces110 files: HashMap<Rc<PathBuf>, FileData>,111 str_files: HashMap<Rc<PathBuf>, Rc<str>>,112}113114pub struct FileData {115 source_code: Rc<str>,116 parsed: LocExpr,117 evaluated: Option<Val>,118}119#[derive(Default)]120pub struct EvaluationStateInternals {121 /// Internal state122 data: RefCell<EvaluationData>,123 /// Settings, safe to change at runtime124 settings: RefCell<EvaluationSettings>,125}126127thread_local! {128 /// Contains state for currently executing file129 /// Global state is fine there130 pub(crate) static EVAL_STATE: RefCell<Option<EvaluationState>> = RefCell::new(None)131}132pub(crate) fn with_state<T>(f: impl FnOnce(&EvaluationState) -> T) -> T {133 EVAL_STATE.with(|s| f(s.borrow().as_ref().unwrap()))134}135pub fn create_error(err: Error) -> LocError {136 LocError(err, StackTrace(vec![]))137}138pub fn create_error_result<T>(err: Error) -> Result<T> {139 Err(LocError(err, StackTrace(vec![])))140}141pub(crate) fn push<T>(142 e: &Option<ExprLocation>,143 frame_desc: impl FnOnce() -> String,144 f: impl FnOnce() -> Result<T>,145) -> Result<T> {146 if let Some(v) = e {147 with_state(|s| s.push(&v, frame_desc, f))148 } else {149 f()150 }151}152153/// Maintains stack trace and import resolution154#[derive(Default, Clone)]155pub struct EvaluationState(Rc<EvaluationStateInternals>);156157impl EvaluationState {158 /// Parses and adds file to loaded159 pub fn add_file(&self, path: Rc<PathBuf>, source_code: Rc<str>) -> Result<()> {160 self.add_parsed_file(161 path.clone(),162 source_code.clone(),163 parse(164 &source_code,165 &ParserSettings {166 file_name: path.clone(),167 loc_data: true,168 },169 )170 .map_err(|error| {171 create_error(Error::ImportSyntaxError {172 error,173 path,174 source_code,175 })176 })?,177 )?;178179 Ok(())180 }181182 /// Adds file by source code and parsed expr183 pub fn add_parsed_file(184 &self,185 name: Rc<PathBuf>,186 source_code: Rc<str>,187 parsed: LocExpr,188 ) -> Result<()> {189 self.data_mut().files.insert(190 name,191 FileData {192 source_code,193 parsed,194 evaluated: None,195 },196 );197198 Ok(())199 }200 pub fn get_source(&self, name: &PathBuf) -> Option<Rc<str>> {201 let ro_map = &self.data().files;202 ro_map.get(name).map(|value| value.source_code.clone())203 }204 pub fn map_source_locations(&self, file: &PathBuf, locs: &[usize]) -> Vec<CodeLocation> {205 offset_to_location(&self.get_source(file).unwrap(), locs)206 }207208 pub(crate) fn import_file(&self, from: &PathBuf, path: &PathBuf) -> Result<Val> {209 let file_path = self.resolve_file(from, path)?;210 {211 let files = &self.data().files;212 if files.contains_key(&file_path) {213 return self.evaluate_loaded_file_raw(&file_path);214 }215 }216 let contents = self.load_file_contents(&file_path)?;217 self.add_file(file_path.clone(), contents)?;218 self.evaluate_loaded_file_raw(&file_path)219 }220 pub(crate) fn import_file_str(&self, from: &PathBuf, path: &PathBuf) -> Result<Rc<str>> {221 let path = self.resolve_file(from, path)?;222 if !self.data().str_files.contains_key(&path) {223 let file_str = self.load_file_contents(&path)?;224 self.data_mut().str_files.insert(path.clone(), file_str);225 }226 Ok(self.data().str_files.get(&path).cloned().unwrap())227 }228229 fn evaluate_loaded_file_raw(&self, name: &PathBuf) -> Result<Val> {230 let expr: LocExpr = {231 let ro_map = &self.data().files;232 let value = ro_map233 .get(name)234 .unwrap_or_else(|| panic!("file not added: {:?}", name));235 if let Some(ref evaluated) = value.evaluated {236 return Ok(evaluated.clone());237 }238 value.parsed.clone()239 };240 let value = evaluate(self.create_default_context()?, &expr)?;241 {242 self.data_mut()243 .files244 .get_mut(name)245 .unwrap()246 .evaluated247 .replace(value.clone());248 }249 Ok(value)250 }251252 /// Adds standard library global variable (std) to this evaluator253 pub fn with_stdlib(&self) -> &Self {254 use jrsonnet_stdlib::STDLIB_STR;255 let std_path = Rc::new(PathBuf::from("std.jsonnet"));256 self.run_in_state(|| {257 self.add_parsed_file(258 std_path.clone(),259 STDLIB_STR.to_owned().into(),260 builtin::get_parsed_stdlib(),261 )262 .unwrap();263 let val = self.evaluate_loaded_file_raw(&std_path).unwrap();264 self.settings_mut().globals.insert("std".into(), val);265 });266 self267 }268269 /// Creates context with all passed global variables270 pub fn create_default_context(&self) -> Result<Context> {271 let globals = &self.settings().globals;272 let mut new_bindings: HashMap<Rc<str>, LazyBinding> = HashMap::new();273 for (name, value) in globals.iter() {274 new_bindings.insert(275 name.clone(),276 LazyBinding::Bound(resolved_lazy_val!(value.clone())),277 );278 }279 Context::new().extend_unbound(new_bindings, None, None, None)280 }281282 /// Executes code, creating new stack frame283 pub fn push<T>(284 &self,285 e: &ExprLocation,286 frame_desc: impl FnOnce() -> String,287 f: impl FnOnce() -> Result<T>,288 ) -> Result<T> {289 {290 let mut data = self.data_mut();291 let stack_depth = &mut data.stack_depth;292 if *stack_depth > self.max_stack() {293 // Error creation uses data, so i drop guard here294 drop(data);295 return Err(create_error(Error::StackOverflow));296 } else {297 *stack_depth += 1;298 }299 }300 let result = f();301 self.data_mut().stack_depth -= 1;302 if let Err(mut err) = result {303 (err.1).0.push(StackTraceElement {304 location: e.clone(),305 desc: frame_desc(),306 });307 return Err(err);308 }309 result310 }311312 /// Runs passed function in state (required, if function needs to modify stack trace)313 pub fn run_in_state<T>(&self, f: impl FnOnce() -> T) -> T {314 EVAL_STATE.with(|v| {315 let has_state = v.borrow().is_some();316 if !has_state {317 v.borrow_mut().replace(self.clone());318 }319 let result = f();320 if !has_state {321 v.borrow_mut().take();322 }323 result324 })325 }326327 pub fn stringify_err(&self, e: &LocError) -> String {328 let mut out = String::new();329 self.settings()330 .trace_format331 .write_trace(&mut out, self, e)332 .unwrap();333 out334 }335336 pub fn manifest(&self, val: Val) -> Result<Rc<str>> {337 self.run_in_state(|| {338 Ok(match self.manifest_format() {339 ManifestFormat::Yaml(padding) => val.into_yaml(padding)?,340 ManifestFormat::Json(padding) => val.into_json(padding)?,341 ManifestFormat::None => match val {342 Val::Str(s) => s,343 _ => return Err(create_error(Error::StringManifestOutputIsNotAString)),344 },345 })346 })347 }348349 /// If passed value is function - call with set TLA350 pub fn with_tla(&self, val: Val) -> Result<Val> {351 Ok(match val {352 Val::Func(func) => func.evaluate_map(353 self.create_default_context()?,354 &self.settings().tla_vars,355 true,356 )?,357 v => v,358 })359 }360}361362/// Internals363impl EvaluationState {364 fn data(&self) -> Ref<EvaluationData> {365 self.0.data.borrow()366 }367 fn data_mut(&self) -> RefMut<EvaluationData> {368 self.0.data.borrow_mut()369 }370 pub fn settings(&self) -> Ref<EvaluationSettings> {371 self.0.settings.borrow()372 }373 pub fn settings_mut(&self) -> RefMut<EvaluationSettings> {374 self.0.settings.borrow_mut()375 }376}377378/// Raw methods evaluates passed values, but not performs TLA execution379impl EvaluationState {380 pub fn evaluate_file_raw(&self, name: &PathBuf) -> Result<Val> {381 self.run_in_state(|| self.import_file(&std::env::current_dir().expect("cwd"), &name))382 }383 pub fn evaluate_file_raw_nocwd(&self, name: &PathBuf) -> Result<Val> {384 self.run_in_state(|| self.import_file(&PathBuf::from("."), &name))385 }386 /// Parses and evaluates snippet387 pub fn evaluate_snippet_raw(&self, source: Rc<PathBuf>, code: Rc<str>) -> Result<Val> {388 let parsed = parse(389 &code,390 &ParserSettings {391 file_name: source.clone(),392 loc_data: true,393 },394 )395 .unwrap();396 self.add_parsed_file(source, code, parsed.clone())?;397 self.evaluate_expr_raw(parsed)398 }399 /// Evaluates parsed expression400 pub fn evaluate_expr_raw(&self, code: LocExpr) -> Result<Val> {401 self.run_in_state(|| evaluate(self.create_default_context()?, &code))402 }403}404405/// Settings utilities406impl EvaluationState {407 pub fn add_ext_var(&self, name: Rc<str>, value: Val) {408 self.settings_mut().ext_vars.insert(name, value);409 }410 pub fn add_ext_str(&self, name: Rc<str>, value: Rc<str>) {411 self.add_ext_var(name, Val::Str(value));412 }413 pub fn add_ext_code(&self, name: Rc<str>, code: Rc<str>) -> Result<()> {414 let value =415 self.evaluate_snippet_raw(Rc::new(PathBuf::from(format!("ext_code {}", name))), code)?;416 self.add_ext_var(name, value);417 Ok(())418 }419420 pub fn add_tla(&self, name: Rc<str>, value: Val) {421 self.settings_mut().tla_vars.insert(name, value);422 }423 pub fn add_tla_str(&self, name: Rc<str>, value: Rc<str>) {424 self.add_tla(name, Val::Str(value));425 }426 pub fn add_tla_code(&self, name: Rc<str>, code: Rc<str>) -> Result<()> {427 let value =428 self.evaluate_snippet_raw(Rc::new(PathBuf::from(format!("tla_code {}", name))), code)?;429 self.add_ext_var(name, value);430 Ok(())431 }432433 pub fn resolve_file(&self, from: &PathBuf, path: &PathBuf) -> Result<Rc<PathBuf>> {434 Ok(self.settings().import_resolver.resolve_file(from, path)?)435 }436 pub fn load_file_contents(&self, path: &PathBuf) -> Result<Rc<str>> {437 Ok(self.settings().import_resolver.load_file_contents(path)?)438 }439440 pub fn import_resolver(&self) -> Ref<dyn ImportResolver> {441 Ref::map(self.settings(), |s| &*s.import_resolver)442 }443 pub fn set_import_resolver(&self, resolver: Box<dyn ImportResolver>) {444 self.settings_mut().import_resolver = resolver;445 }446447 pub fn manifest_format(&self) -> ManifestFormat {448 self.settings().manifest_format.clone()449 }450 pub fn set_manifest_format(&self, format: ManifestFormat) {451 self.settings_mut().manifest_format = format;452 }453454 pub fn trace_format(&self) -> Ref<dyn TraceFormat> {455 Ref::map(self.settings(), |s| &*s.trace_format)456 }457 pub fn set_trace_format(&self, format: Box<dyn TraceFormat>) {458 self.settings_mut().trace_format = format;459 }460461 pub fn max_trace(&self) -> usize {462 self.settings().max_trace463 }464 pub fn set_max_trace(&self, trace: usize) {465 self.settings_mut().max_trace = trace;466 }467468 pub fn max_stack(&self) -> usize {469 self.settings().max_stack470 }471 pub fn set_max_stack(&self, trace: usize) {472 self.settings_mut().max_stack = trace;473 }474}475476#[cfg(test)]477pub mod tests {478 use super::Val;479 use crate::{create_error, primitive_equals, EvaluationState};480 use jrsonnet_parser::*;481 use std::{path::PathBuf, rc::Rc};482483 #[test]484 #[should_panic]485 fn eval_state_stacktrace() {486 let state = EvaluationState::default();487 state.run_in_state(|| {488 state489 .push(490 &ExprLocation(Rc::new(PathBuf::from("test1.jsonnet")), 10, 20),491 || "outer".to_owned(),492 || {493 state.push(494 &ExprLocation(Rc::new(PathBuf::from("test2.jsonnet")), 30, 40),495 || "inner".to_owned(),496 || Err(create_error(crate::error::Error::RuntimeError("".into()))),497 )?;498 Ok(())499 },500 )501 .unwrap();502 });503 }504505 #[test]506 fn eval_state_standard() {507 let state = EvaluationState::default();508 state.with_stdlib();509 assert!(primitive_equals(510 &state511 .evaluate_snippet_raw(512 Rc::new(PathBuf::from("raw.jsonnet")),513 r#"std.assertEqual(std.base64("test"), "dGVzdA==")"#.into()514 )515 .unwrap(),516 &Val::Bool(true),517 )518 .unwrap());519 }520521 macro_rules! eval {522 ($str: expr) => {523 EvaluationState::default()524 .with_stdlib()525 .evaluate_snippet_raw(Rc::new(PathBuf::from("raw.jsonnet")), $str.into())526 .unwrap()527 };528 }529 macro_rules! eval_json {530 ($str: expr) => {{531 let evaluator = EvaluationState::default();532 evaluator.with_stdlib();533 evaluator.run_in_state(|| {534 evaluator535 .evaluate_snippet_raw(Rc::new(PathBuf::from("raw.jsonnet")), $str.into())536 .unwrap()537 .into_json(0)538 .unwrap()539 .replace("\n", "")540 })541 }};542 }543544 /// Asserts given code returns `true`545 macro_rules! assert_eval {546 ($str: expr) => {547 assert!(primitive_equals(&eval!($str), &Val::Bool(true)).unwrap())548 };549 }550551 /// Asserts given code returns `false`552 macro_rules! assert_eval_neg {553 ($str: expr) => {554 assert!(primitive_equals(&eval!($str), &Val::Bool(false)).unwrap())555 };556 }557 macro_rules! assert_json {558 ($str: expr, $out: expr) => {559 assert_eq!(eval_json!($str), $out.replace("\t", ""))560 };561 }562563 /// Sanity checking, before trusting to another tests564 #[test]565 fn equality_operator() {566 assert_eval!("2 == 2");567 assert_eval_neg!("2 != 2");568 assert_eval!("2 != 3");569 assert_eval_neg!("2 == 3");570 assert_eval!("'Hello' == 'Hello'");571 assert_eval_neg!("'Hello' != 'Hello'");572 assert_eval!("'Hello' != 'World'");573 assert_eval_neg!("'Hello' == 'World'");574 }575576 #[test]577 fn math_evaluation() {578 assert_eval!("2 + 2 * 2 == 6");579 assert_eval!("3 + (2 + 2 * 2) == 9");580 }581582 #[test]583 fn string_concat() {584 assert_eval!("'Hello' + 'World' == 'HelloWorld'");585 assert_eval!("'Hello' * 3 == 'HelloHelloHello'");586 assert_eval!("'Hello' + 'World' * 3 == 'HelloWorldWorldWorld'");587 }588589 #[test]590 fn faster_join() {591 assert_eval!("std.join([0,0], [[1,2],[3,4],[5,6]]) == [1,2,0,0,3,4,0,0,5,6]");592 assert_eval!("std.join(',', ['1','2','3','4']) == '1,2,3,4'");593 }594595 #[test]596 fn function_contexts() {597 assert_eval!(598 r#"599 local k = {600 t(name = self.h): [self.h, name],601 h: 3,602 };603 local f = {604 t: k.t(),605 h: 4,606 };607 f.t[0] == f.t[1]608 "#609 );610 }611612 #[test]613 fn local() {614 assert_eval!("local a = 2; local b = 3; a + b == 5");615 assert_eval!("local a = 1, b = a + 1; a + b == 3");616 assert_eval!("local a = 1; local a = 2; a == 2");617 }618619 #[test]620 fn object_lazyness() {621 assert_json!("local a = {a:error 'test'}; {}", r#"{}"#);622 }623624 #[test]625 fn object_inheritance() {626 assert_json!("{a: self.b} + {b:3}", r#"{"a": 3,"b": 3}"#);627 }628629 #[test]630 fn object_assertion_success() {631 eval!("{assert \"a\" in self} + {a:2}");632 }633634 #[test]635 fn object_assertion_error() {636 eval!("{assert \"a\" in self}");637 }638639 #[test]640 fn lazy_args() {641 eval!("local test(a) = 2; test(error '3')");642 }643644 #[test]645 #[should_panic]646 fn tailstrict_args() {647 eval!("local test(a) = 2; test(error '3') tailstrict");648 }649650 #[test]651 #[should_panic]652 fn no_binding_error() {653 eval!("a");654 }655656 #[test]657 fn test_object() {658 assert_json!("{a:2}", r#"{"a": 2}"#);659 assert_json!("{a:2+2}", r#"{"a": 4}"#);660 assert_json!("{a:2}+{b:2}", r#"{"a": 2,"b": 2}"#);661 assert_json!("{b:3}+{b:2}", r#"{"b": 2}"#);662 assert_json!("{b:3}+{b+:2}", r#"{"b": 5}"#);663 assert_json!("local test='a'; {[test]:2}", r#"{"a": 2}"#);664 assert_json!(665 r#"666 {667 name: "Alice",668 welcome: "Hello " + self.name + "!",669 }670 "#,671 r#"{"name": "Alice","welcome": "Hello Alice!"}"#672 );673 assert_json!(674 r#"675 {676 name: "Alice",677 welcome: "Hello " + self.name + "!",678 } + {679 name: "Bob"680 }681 "#,682 r#"{"name": "Bob","welcome": "Hello Bob!"}"#683 );684 }685686 #[test]687 fn functions() {688 assert_json!(r#"local a = function(b, c = 2) b + c; a(2)"#, "4");689 assert_json!(690 r#"local a = function(b, c = "Dear") b + c + d, d = "World"; a("Hello")"#,691 r#""HelloDearWorld""#692 );693 }694695 #[test]696 fn local_methods() {697 assert_json!(r#"local a(b, c = 2) = b + c; a(2)"#, "4");698 assert_json!(699 r#"local a(b, c = "Dear") = b + c + d, d = "World"; a("Hello")"#,700 r#""HelloDearWorld""#701 );702 }703704 #[test]705 fn object_locals() {706 assert_json!(r#"{local a = 3, b: a}"#, r#"{"b": 3}"#);707 assert_json!(r#"{local a = 3, local c = a, b: c}"#, r#"{"b": 3}"#);708 assert_json!(709 r#"{local a = function (b) {[b]:4}, test: a("test")}"#,710 r#"{"test": {"test": 4}}"#711 );712 }713714 #[test]715 fn object_comp() {716 assert_json!(717 r#"{local t = "a", ["h"+i+"_"+z]: if "h"+(i-1)+"_"+z in self then t+1 else 0+t for i in [1,2,3] for z in [2,3,4] if z != i}"#,718 "{\"h1_2\": \"0a\",\"h1_3\": \"0a\",\"h1_4\": \"0a\",\"h2_3\": \"a1\",\"h2_4\": \"a1\",\"h3_2\": \"0a\",\"h3_4\": \"a1\"}"719 )720 }721722 #[test]723 fn direct_self() {724 println!(725 "{:#?}",726 eval!(727 r#"728 {729 local me = self,730 a: 3,731 b(): me.a,732 }733 "#734 )735 );736 }737738 #[test]739 fn indirect_self() {740 // `self` assigned to `me` was lost when being741 // referenced from field742 eval!(743 r#"{744 local me = self,745 a: 3,746 b: me.a,747 }.b"#748 );749 }750751 // We can't trust other tests (And official jsonnet testsuite), if assert is not working correctly752 #[test]753 fn std_assert_ok() {754 eval!("std.assertEqual(4.5 << 2, 16)");755 }756757 #[test]758 #[should_panic]759 fn std_assert_failure() {760 eval!("std.assertEqual(4.5 << 2, 15)");761 }762763 #[test]764 fn string_is_string() {765 assert!(primitive_equals(766 &eval!("local arr = 'hello'; (!std.isArray(arr)) && (!std.isString(arr))"),767 &Val::Bool(false),768 )769 .unwrap());770 }771772 #[test]773 fn base64_works() {774 assert_json!(r#"std.base64("test")"#, r#""dGVzdA==""#);775 }776777 #[test]778 fn utf8_chars() {779 assert_json!(780 r#"local c="😎";{c:std.codepoint(c),l:std.length(c)}"#,781 r#"{"c": 128526,"l": 1}"#782 )783 }784785 #[test]786 fn json() {787 assert_json!(788 r#"std.manifestJsonEx({a:3, b:4, c:6},"")"#,789 r#""{\n\"a\": 3,\n\"b\": 4,\n\"c\": 6\n}""#790 );791 }792793 #[test]794 fn test() {795 assert_json!(796 r#"[[a, b] for a in [1,2,3] for b in [4,5,6]]"#,797 "[[1,4],[1,5],[1,6],[2,4],[2,5],[2,6],[3,4],[3,5],[3,6]]"798 );799 }800801 #[test]802 fn sjsonnet() {803 eval!(804 r#"805 local x0 = {k: 1};806 local x1 = {k: x0.k + x0.k};807 local x2 = {k: x1.k + x1.k};808 local x3 = {k: x2.k + x2.k};809 local x4 = {k: x3.k + x3.k};810 local x5 = {k: x4.k + x4.k};811 local x6 = {k: x5.k + x5.k};812 local x7 = {k: x6.k + x6.k};813 local x8 = {k: x7.k + x7.k};814 local x9 = {k: x8.k + x8.k};815 local x10 = {k: x9.k + x9.k};816 local x11 = {k: x10.k + x10.k};817 local x12 = {k: x11.k + x11.k};818 local x13 = {k: x12.k + x12.k};819 local x14 = {k: x13.k + x13.k};820 local x15 = {k: x14.k + x14.k};821 local x16 = {k: x15.k + x15.k};822 local x17 = {k: x16.k + x16.k};823 local x18 = {k: x17.k + x17.k};824 local x19 = {k: x18.k + x18.k};825 local x20 = {k: x19.k + x19.k};826 local x21 = {k: x20.k + x20.k};827 x21.k828 "#829 );830 }831832 use test::Bencher;833834 // This test is commented out by default, because of huge compilation slowdown835 // #[bench]836 // fn bench_codegen(b: &mut Bencher) {837 // b.iter(|| {838 // #[allow(clippy::all)]839 // let stdlib = {840 // use jrsonnet_parser::*;841 // include!(concat!(env!("OUT_DIR"), "/stdlib.rs"))842 // };843 // stdlib844 // })845 // }846847 #[bench]848 fn bench_serialize(b: &mut Bencher) {849 b.iter(|| {850 bincode::deserialize::<jrsonnet_parser::LocExpr>(include_bytes!(concat!(851 env!("OUT_DIR"),852 "/stdlib.bincode"853 )))854 .expect("deserialize stdlib")855 })856 }857858 #[bench]859 fn bench_parse(b: &mut Bencher) {860 b.iter(|| {861 jrsonnet_parser::parse(862 jrsonnet_stdlib::STDLIB_STR,863 &jrsonnet_parser::ParserSettings {864 loc_data: true,865 file_name: Rc::new(PathBuf::from("std.jsonnet")),866 },867 )868 })869 }870871 #[test]872 fn equality() {873 println!(874 "{:?}",875 jrsonnet_parser::parse(876 "{ x: 1, y: 2 } == { x: 1, y: 2 }",877 &ParserSettings::default()878 )879 );880 assert_eval!("{ x: 1, y: 2 } == { x: 1, y: 2 }")881 }882}crates/jrsonnet-evaluator/src/obj.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/obj.rs
+++ b/crates/jrsonnet-evaluator/src/obj.rs
@@ -11,11 +11,13 @@
pub location: Option<ExprLocation>,
}
+// Field => This
+type CacheKey = (Rc<str>, usize);
#[derive(Debug)]
pub struct ObjValueInternals {
super_obj: Option<ObjValue>,
this_entries: Rc<HashMap<Rc<str>, ObjMember>>,
- value_cache: RefCell<HashMap<(Rc<str>, usize), Option<Val>>>,
+ value_cache: RefCell<HashMap<CacheKey, Option<Val>>>,
}
#[derive(Clone)]
pub struct ObjValue(pub(crate) Rc<ObjValueInternals>);
crates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/val.rs
+++ b/crates/jrsonnet-evaluator/src/val.rs
@@ -1,7 +1,8 @@
use crate::{
- create_error_result, evaluate,
+ error::Error::*,
+ evaluate,
function::{parse_function_call, parse_function_call_map, place_args},
- with_state, Context, Error, ObjValue, Result,
+ throw, with_state, Context, ObjValue, Result,
};
use jrsonnet_parser::{el, Arg, ArgsDesc, Expr, LocExpr, ParamsDesc};
use std::{
@@ -157,14 +158,14 @@
if num.is_finite() {
Ok(Val::Num(num))
} else {
- create_error_result(Error::RuntimeError("overflow".into()))
+ throw!(RuntimeError("overflow".into()))
}
}
pub fn assert_type(&self, context: &'static str, val_type: ValType) -> Result<()> {
let this_type = self.value_type()?;
if this_type != val_type {
- create_error_result(Error::TypeMismatch(context, vec![val_type], this_type))
+ throw!(TypeMismatch(context, vec![val_type], this_type))
} else {
Ok(())
}
@@ -263,15 +264,15 @@
(Val::Null, Val::Null) => true,
(Val::Str(a), Val::Str(b)) => a == b,
(Val::Num(a), Val::Num(b)) => (a - b).abs() <= f64::EPSILON,
- (Val::Arr(_), Val::Arr(_)) => create_error_result(Error::RuntimeError(
+ (Val::Arr(_), Val::Arr(_)) => throw!(RuntimeError(
"primitiveEquals operates on primitive types, got array".into(),
- ))?,
- (Val::Obj(_), Val::Obj(_)) => create_error_result(Error::RuntimeError(
+ )),
+ (Val::Obj(_), Val::Obj(_)) => throw!(RuntimeError(
"primitiveEquals operates on primitive types, got object".into(),
- ))?,
- (a, b) if is_function_like(&a) && is_function_like(&b) => create_error_result(
- Error::RuntimeError("cannot test equality of functions".into()),
- )?,
+ )),
+ (a, b) if is_function_like(&a) && is_function_like(&b) => {
+ throw!(RuntimeError("cannot test equality of functions".into()))
+ }
(_, _) => false,
})
}
@@ -376,7 +377,7 @@
buf.push('}');
}
Val::Func(_) | Val::Intristic(_, _) => {
- create_error_result(Error::RuntimeError("tried to manifest function".into()))?
+ throw!(RuntimeError("tried to manifest function".into()))
}
Val::Lazy(_) => unreachable!(),
};
crates/jrsonnet-parser/src/expr.rsdiffbeforeafterboth--- a/crates/jrsonnet-parser/src/expr.rs
+++ b/crates/jrsonnet-parser/src/expr.rs
@@ -258,7 +258,7 @@
/// importStr "file.txt"
ImportStr(PathBuf),
/// error "I'm broken"
- Error(LocExpr),
+ ErrorStmt(LocExpr),
/// a(b, c)
Apply(LocExpr, ArgsDesc, bool),
/// a[b]
crates/jrsonnet-parser/src/lib.rsdiffbeforeafterboth--- a/crates/jrsonnet-parser/src/lib.rs
+++ b/crates/jrsonnet-parser/src/lib.rs
@@ -197,7 +197,7 @@
/ l(s,<keyword("function") _ "(" _ params:params(s) _ ")" _ expr:expr(s) {Expr::Function(params, expr)}>)
/ l(s,<assertion:assertion(s) _ ";" _ expr:expr(s) { Expr::AssertExpr(assertion, expr) }>)
- / l(s,<keyword("error") _ expr:expr(s) { Expr::Error(expr) }>)
+ / l(s,<keyword("error") _ expr:expr(s) { Expr::ErrorStmt(expr) }>)
rule slice_part(s: &ParserSettings) -> Option<LocExpr>
= e:(_ e:expr(s) _{e})? {e}