difftreelog
refactor use new object methods
in: master
4 files changed
crates/jrsonnet-evaluator/src/builtin/mod.rsdiffbeforeafterboth144 0, obj: ty!(object) => Val::Obj;144 0, obj: ty!(object) => Val::Obj;145 1, inc_hidden: ty!(boolean) => Val::Bool;145 1, inc_hidden: ty!(boolean) => Val::Bool;146 ], {146 ], {147 let mut out = obj.fields_visibility()147 let out = obj.fields_ex(inc_hidden);148 .into_iter()149 .filter(|(_k, v)| *v || inc_hidden)150 .map(|(k, _v)|k)151 .collect::<Vec<_>>();152 out.sort();153 Ok(Val::Arr(out.into_iter().map(Val::Str).collect::<Vec<_>>().into()))148 Ok(Val::Arr(out.into_iter().map(Val::Str).collect::<Vec<_>>().into()))154 })149 })155}150}164 1, f: ty!(string) => Val::Str;159 1, f: ty!(string) => Val::Str;165 2, inc_hidden: ty!(boolean) => Val::Bool;160 2, inc_hidden: ty!(boolean) => Val::Bool;166 ], {161 ], {167 Ok(Val::Bool(162 Ok(Val::Bool(obj.has_field_ex(f, inc_hidden)))168 obj.fields_visibility()169 .into_iter()170 .filter(|(_k, v)| *v || inc_hidden)171 .any(|(k, _v)| *k == *f),172 ))173 })163 })174}164}crates/jrsonnet-evaluator/src/evaluate.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate.rs
@@ -245,7 +245,7 @@
new_bindings.fill(bindings);
}
- let mut new_members = HashMap::new();
+ let mut new_members = FxHashMap::default();
for member in members.iter() {
match member {
Member::Field(FieldMember {
@@ -320,7 +320,7 @@
ObjBody::MemberList(members) => evaluate_member_list_object(context, members)?,
ObjBody::ObjComp(obj) => {
let future_this = FutureObjValue::new();
- let mut new_members = HashMap::new();
+ let mut new_members = FxHashMap::default();
for (k, v) in evaluate_comp(
context.clone(),
&|ctx| {
crates/jrsonnet-evaluator/src/integrations/serde.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/integrations/serde.rs
+++ b/crates/jrsonnet-evaluator/src/integrations/serde.rs
@@ -3,10 +3,12 @@
throw, LazyBinding, LazyVal, ObjMember, ObjValue, Val,
};
use jrsonnet_parser::Visibility;
+use rustc_hash::FxHasher;
use serde_json::{Map, Number, Value};
use std::{
collections::HashMap,
convert::{TryFrom, TryInto},
+ hash::BuildHasherDefault,
rc::Rc,
};
@@ -31,7 +33,7 @@
}
Val::Obj(o) => {
let mut out = Map::new();
- for key in o.visible_fields() {
+ for key in o.fields() {
out.insert(
(&key as &str).into(),
(&o.get(key)?.expect("field exists")).try_into()?,
@@ -59,7 +61,10 @@
Self::Arr(out.into())
}
Value::Object(o) => {
- let mut entries = HashMap::with_capacity(o.len());
+ let mut entries = HashMap::with_capacity_and_hasher(
+ o.len(),
+ BuildHasherDefault::<FxHasher>::default(),
+ );
for (k, v) in o {
entries.insert(
(k as &str).into(),
crates/jrsonnet-evaluator/src/val.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/val.rs
+++ b/crates/jrsonnet-evaluator/src/val.rs
@@ -395,7 +395,7 @@
Self::Obj(obj) => obj,
_ => throw!(MultiManifestOutputIsNotAObject),
};
- let keys = obj.visible_fields();
+ let keys = obj.fields();
let mut out = Vec::with_capacity(keys.len());
for key in keys {
let value = obj
@@ -588,8 +588,8 @@
if ObjValue::ptr_eq(a, b) {
return Ok(true);
}
- let fields = a.visible_fields();
- if fields != b.visible_fields() {
+ let fields = a.fields();
+ if fields != b.fields() {
return Ok(false);
}
for field in fields {