difftreelog
feat ensure lazy trees are enabled for everyone
in: trunk
4 files changed
crates/fleet-base/src/opts.rsdiffbeforeafterboth--- a/crates/fleet-base/src/opts.rs
+++ b/crates/fleet-base/src/opts.rs
@@ -7,7 +7,10 @@
};
use anyhow::{Context, Result, bail};
-use nix_eval::{FetchSettings, FlakeReference, FlakeSettings, Value, nix_go, util::assert_warn};
+use nix_eval::{
+ FetchSettings, FlakeReference, FlakeReferenceParseFlags, FlakeSettings, Value, nix_go,
+ util::assert_warn,
+};
use nom::{
Parser,
bytes::complete::take_while1,
@@ -213,16 +216,21 @@
let mut fetch_settings = FetchSettings::new();
fetch_settings.set(c"warn-dirty", c"false");
- // TODO: use correct directory, not cwd
+ let mut flake_settings = FlakeSettings::new()?;
+ let mut parse = FlakeReferenceParseFlags::new(&flake_settings)?;
+ // For some reason, lazy trees not being used when there is no base dir set
+ parse.set_base_dir("/")?;
+
let (mut flake, _) = FlakeReference::new(
directory
.to_str()
.ok_or_else(|| anyhow::anyhow!("fleet dir should have utf-8 path"))?,
+ &flake_settings,
+ &parse,
&fetch_settings,
)?;
let flake = flake.lock(&fetch_settings)?;
- let mut flake_settings = FlakeSettings::new()?;
let flake = flake.get_attrs(&mut flake_settings)?;
let builtins_field = Value::eval("builtins")?;
crates/nix-eval/src/lib.rsdiffbeforeafterboth--- a/crates/nix-eval/src/lib.rs
+++ b/crates/nix-eval/src/lib.rs
@@ -11,6 +11,7 @@
use serde::de::DeserializeOwned;
pub use anyhow::Result;
+use tracing::instrument;
use self::logging::nix_logging_cxx;
use self::nix_cxx::set_fetcher_setting;
@@ -18,11 +19,12 @@
alloc_value, c_context, c_context_create, err_code, err_info_msg, eval_state_build,
eval_state_builder_new, expr_eval_from_string, fetchers_settings, fetchers_settings_free,
fetchers_settings_new, flake_lock, flake_lock_flags, flake_lock_flags_free,
- flake_lock_flags_new, flake_reference_parse_flags, flake_reference_parse_flags_free,
- flake_reference_parse_flags_new, flake_reference_parse_flags_set_base_directory,
- flake_settings, flake_settings_free, flake_settings_new, init_bool, init_int, init_string,
- locked_flake_free, locked_flake_get_output_attrs, set_err_msg, setting_set, state_free,
- value_decref, value_incref,
+ flake_lock_flags_new, flake_lock_flags_set_mode_virtual, flake_reference_parse_flags,
+ flake_reference_parse_flags_free, flake_reference_parse_flags_new,
+ flake_reference_parse_flags_set_base_directory, flake_settings, flake_settings_free,
+ flake_settings_new, init_bool, init_int, init_string, locked_flake_free,
+ locked_flake_get_output_attrs, set_err_msg, setting_set, state_free, value_decref,
+ value_incref,
};
// Contains macros helpers
@@ -94,7 +96,7 @@
#[derive(Debug)]
#[repr(i32)]
-enum NixErrorKind {
+pub enum NixErrorKind {
Unknown = 1,
Overflow = 2,
Key = 3,
@@ -136,6 +138,7 @@
pub struct ThreadRegisterGuard {}
impl ThreadRegisterGuard {
+ #[allow(clippy::new_without_default)]
pub fn new() -> Self {
gc_register_my_thread();
Self {}
@@ -200,6 +203,12 @@
Ok(o)
}
}
+
+impl Default for NixContext {
+ fn default() -> Self {
+ Self::new()
+ }
+}
impl Drop for NixContext {
fn drop(&mut self) {
unsafe {
@@ -232,6 +241,17 @@
}
// eval_s
})?;
+ ctx.run_in_context(|c| {
+ unsafe {
+ nix_raw::eval_state_builder_set_eval_setting(
+ c,
+ builder,
+ c"lazy-locks".as_ptr(),
+ c"true".as_ptr(),
+ )
+ }
+ // eval_s
+ })?;
let state = ctx
.run_in_context(|c| unsafe { eval_state_build(c, builder) })
.map(EvalState)?;
@@ -319,7 +339,7 @@
pub struct FlakeReferenceParseFlags(*mut flake_reference_parse_flags);
impl FlakeReferenceParseFlags {
- pub fn new(settings: &mut FlakeSettings) -> Result<Self> {
+ pub fn new(settings: &FlakeSettings) -> Result<Self> {
with_default_context(|c, _| unsafe { flake_reference_parse_flags_new(c, settings.0) })
.map(Self)
}
@@ -346,7 +366,11 @@
struct FlakeLockFlags(*mut flake_lock_flags);
impl FlakeLockFlags {
fn new(settings: &mut FlakeSettings) -> Result<Self> {
- with_default_context(|c, _| unsafe { flake_lock_flags_new(c, settings.0) }).map(Self)
+ let o = with_default_context(|c, _| unsafe { flake_lock_flags_new(c, settings.0) })
+ .map(Self)?;
+ with_default_context(|c, _| unsafe { flake_lock_flags_set_mode_virtual(c, o.0) })?;
+
+ Ok(o)
}
}
impl Drop for FlakeLockFlags {
@@ -381,10 +405,13 @@
pub struct FlakeReference(*mut nix_raw::flake_reference);
impl FlakeReference {
- pub fn new(s: &str, fetch: &FetchSettings) -> Result<(Self, String)> {
- let mut flake_settings = FlakeSettings::new()?;
- let parse_flags = FlakeReferenceParseFlags::new(&mut flake_settings)?;
-
+ #[instrument(name = "new-flake-reference", skip(flake, parse, fetch))]
+ pub fn new(
+ s: &str,
+ flake: &FlakeSettings,
+ parse: &FlakeReferenceParseFlags,
+ fetch: &FetchSettings,
+ ) -> Result<(Self, String)> {
let mut out = null_mut();
let mut fragment = String::new();
// let fetch_settings = fetcher_settings;
@@ -392,8 +419,8 @@
nix_raw::flake_reference_and_fragment_from_string(
c,
fetch.0,
- flake_settings.0,
- parse_flags.0,
+ flake.0,
+ parse.0,
s.as_ptr().cast(),
s.len(),
&mut out,
@@ -405,6 +432,7 @@
Ok((Self(out), fragment))
}
+ #[instrument(name = "lock-flake", skip(self, fetch))]
pub fn lock(&mut self, fetch: &FetchSettings) -> Result<LockedFlake> {
let mut settings = FlakeSettings::new()?;
let lock_flags = FlakeLockFlags::new(&mut settings)?;
crates/nix-eval/src/logging.ccdiffbeforeafterboth1#include "nix-eval/src/logging.rs"2#include "logging.hh"3#include <nix/util/logging.hh>45using namespace nix;67struct TracingLogger : Logger {8 TracingLogger() {}910 bool isVerbose() override { return true; }11 // void addFields(nlohmann::json & json, const Fields & fields)12 // {13 // if (fields.empty())14 // return;15 // auto & arr = json["fields"] = nlohmann::json::array();16 // for (auto & f : fields)17 // if (f.type == Logger::Field::tInt)18 // arr.push_back(f.i);19 // else if (f.type == Logger::Field::tString)20 // arr.push_back(f.s);21 // else22 // unreachable();23 // }24 void log(Verbosity lvl, std::string_view s) override {25 rust::Str str(s.data(), s.size());26 emit_log(lvl, str);27 }28 void logEI(const ErrorInfo &ei) override { emit_log(ei.level, ei.msg.str()); }2930 void startActivity(ActivityId act, Verbosity lvl, ActivityType type,31 const std::string &s, const Fields &fields,32 ActivityId parent) override {33 auto b = new_start_activity(act, lvl, type);34 for (auto &f : fields) {35 if (f.type == Logger::Field::tInt) {36 b->add_int_field(f.i);37 } else if (f.type == Logger::Field::tString) {38 b->add_string_field(f.s);39 } else {40 unreachable();41 }42 }43 b->emit(parent, s);44 };4546 void stopActivity(ActivityId act) override { emit_stop(act); };4748 void result(ActivityId act, ResultType type, const Fields &fields) override {49 auto b = new_start_activity(act, 0, type);50 for (auto &f : fields) {51 if (f.type == Logger::Field::tInt) {52 b->add_int_field(f.i);53 } else if (f.type == Logger::Field::tString) {54 b->add_string_field(f.s);55 } else {56 unreachable();57 }58 }59 b->emit_result(type);60 };6162 void writeToStdout(std::string_view s) override {63 printf("writeToStdout() called\n");64 }65 void warn(const std::string &msg) override { emit_warn(msg); }6667 virtual std::optional<char> ask(std::string_view s) {68 printf("ask() called\n");69 return {};70 }71};7273extern "C" {74void apply_tracing_logger() { logger = std::make_unique<TracingLogger>(); }75}1#include "nix-eval/src/logging.rs"2#include "logging.hh"3#include <nix/util/logging.hh>45using namespace nix;67struct TracingLogger : Logger {8 TracingLogger() {}910 bool isVerbose() override { return true; }11 void log(Verbosity lvl, std::string_view s) override {12 rust::Str str(s.data(), s.size());13 emit_log(lvl, str);14 }15 void logEI(const ErrorInfo &ei) override { emit_log(ei.level, ei.msg.str()); }1617 void startActivity(ActivityId act, Verbosity lvl, ActivityType type,18 const std::string &s, const Fields &fields,19 ActivityId parent) override {20 auto b = new_start_activity(act, lvl, type);21 for (auto &f : fields) {22 if (f.type == Logger::Field::tInt) {23 b->add_int_field(f.i);24 } else if (f.type == Logger::Field::tString) {25 b->add_string_field(f.s);26 } else {27 unreachable();28 }29 }30 b->emit(parent, s);31 };3233 void stopActivity(ActivityId act) override { emit_stop(act); };3435 void result(ActivityId act, ResultType type, const Fields &fields) override {36 auto b = new_start_activity(act, 0, type);37 for (auto &f : fields) {38 if (f.type == Logger::Field::tInt) {39 b->add_int_field(f.i);40 } else if (f.type == Logger::Field::tString) {41 b->add_string_field(f.s);42 } else {43 unreachable();44 }45 }46 b->emit_result(type);47 };4849 void writeToStdout(std::string_view s) override {50 emit_warn("writeToStdout() called, but unsupported");51 }52 void warn(const std::string &msg) override { emit_warn(msg); }5354 virtual std::optional<char> ask(std::string_view s) {55 emit_warn("ask() called, but unsupported");56 return {};57 }58};5960extern "C" {61void apply_tracing_logger() {62 logger = std::make_unique<TracingLogger>();63}64}flake.lockdiffbeforeafterboth--- a/flake.lock
+++ b/flake.lock
@@ -105,7 +105,6 @@
},
"locked": {
"lastModified": 1757000273,
- "narHash": "sha256-9AKhwsSlegWnNFy8++OMNctrxJUUIE7nG4s4ZHmFPic=",
"owner": "deltarocks",
"repo": "nix",
"rev": "eba1f549ec21208cf98343f1351a95e2e6eb3fbb",