git.delta.rocks / jrsonnet / refs/commits / 685a983a9749

difftreelog

feat optional tailstrict in FuncVal::evaluate_simple

Yaroslav Bolyukin2023-04-08parent: #9440ce0.patch.diff
in: master

7 files changed

modifiedcrates/jrsonnet-evaluator/src/arr/mod.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/arr/mod.rs
+++ b/crates/jrsonnet-evaluator/src/arr/mod.rs
@@ -234,6 +234,7 @@
 		}
 	}
 
+	/// Is this vec supports .get_cheap()?
 	pub fn is_cheap(&self) -> bool {
 		match self {
 			ArrValue::Eager(_) | ArrValue::Range(..) | ArrValue::Bytes(_) => true,
modifiedcrates/jrsonnet-evaluator/src/arr/spec.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/arr/spec.rs
+++ b/crates/jrsonnet-evaluator/src/arr/spec.rs
@@ -748,7 +748,7 @@
 			.get(index)
 			.transpose()
 			.expect("index checked")
-			.and_then(|r| self.0.mapper.evaluate_simple(&(r,)));
+			.and_then(|r| self.0.mapper.evaluate_simple(&(r,), false));
 
 		let new_value = match val {
 			Ok(v) => v,
modifiedcrates/jrsonnet-evaluator/src/evaluate/mod.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/evaluate/mod.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate/mod.rs
@@ -414,6 +414,7 @@
 #[allow(clippy::too_many_lines)]
 pub fn evaluate(ctx: Context, expr: &LocExpr) -> Result<Val> {
 	use Expr::*;
+
 	if let Some(trivial) = evaluate_trivial(expr) {
 		return Ok(trivial);
 	}
modifiedcrates/jrsonnet-evaluator/src/function/mod.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/function/mod.rs
+++ b/crates/jrsonnet-evaluator/src/function/mod.rs
@@ -164,12 +164,16 @@
 			Self::Builtin(b) => b.call(call_ctx, loc, args),
 		}
 	}
-	pub fn evaluate_simple<A: ArgsLike + OptionalContext>(&self, args: &A) -> Result<Val> {
+	pub fn evaluate_simple<A: ArgsLike + OptionalContext>(
+		&self,
+		args: &A,
+		tailstrict: bool,
+	) -> Result<Val> {
 		self.evaluate(
 			ContextBuilder::dangerous_empty_state().build(),
 			CallLocation::native(),
 			args,
-			true,
+			tailstrict,
 		)
 	}
 	/// Convert jsonnet function to plain `Fn` value.
modifiedcrates/jrsonnet-evaluator/src/function/native.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/function/native.rs
+++ b/crates/jrsonnet-evaluator/src/function/native.rs
@@ -22,6 +22,7 @@
 				Box::new(move |$($gen),*| {
 					let val = val.evaluate_simple(
 						&($($gen,)*),
+						false,
 					)?;
 					O::from_untyped(val)
 				})
modifiedcrates/jrsonnet-interner/src/lib.rsdiffbeforeafterboth
--- a/crates/jrsonnet-interner/src/lib.rs
+++ b/crates/jrsonnet-interner/src/lib.rs
@@ -174,7 +174,6 @@
 		}
 		// First reference - current object, second - POOL
 		if Inner::strong_count(&self.0) <= 2 {
-			eprintln!("unpool");
 			unpool(&self.0);
 		}
 	}
modifiedcrates/jrsonnet-stdlib/src/arrays.rsdiffbeforeafterboth
8888
89#[builtin]89#[builtin]
90pub fn builtin_filter(func: FuncVal, arr: ArrValue) -> Result<ArrValue> {90pub fn builtin_filter(func: FuncVal, arr: ArrValue) -> Result<ArrValue> {
91 arr.filter(|val| bool::from_untyped(func.evaluate_simple(&(val.clone(),))?))91 arr.filter(|val| bool::from_untyped(func.evaluate_simple(&(val.clone(),), false)?))
92}92}
9393
94#[builtin]94#[builtin]
95pub fn builtin_foldl(func: FuncVal, arr: ArrValue, init: Val) -> Result<Val> {95pub fn builtin_foldl(func: FuncVal, arr: ArrValue, init: Val) -> Result<Val> {
96 let mut acc = init;96 let mut acc = init;
97 for i in arr.iter() {97 for i in arr.iter() {
98 acc = func.evaluate_simple(&(acc, i?))?;98 acc = func.evaluate_simple(&(acc, i?), false)?;
99 }99 }
100 Ok(acc)100 Ok(acc)
101}101}
104pub fn builtin_foldr(func: FuncVal, arr: ArrValue, init: Val) -> Result<Val> {104pub fn builtin_foldr(func: FuncVal, arr: ArrValue, init: Val) -> Result<Val> {
105 let mut acc = init;105 let mut acc = init;
106 for i in arr.iter().rev() {106 for i in arr.iter().rev() {
107 acc = func.evaluate_simple(&(i?, acc))?;107 acc = func.evaluate_simple(&(i?, acc), false)?;
108 }108 }
109 Ok(acc)109 Ok(acc)
110}110}