git.delta.rocks / jrsonnet / refs/commits / 6451b30ca5f3

difftreelog

style fix clippy warnings

Yaroslav Bolyukin2021-07-12parent: #8a68344.patch.diff
in: master

2 files changed

modifiedcrates/jrsonnet-evaluator/src/builtin/mod.rsdiffbeforeafterboth
before · crates/jrsonnet-evaluator/src/builtin/mod.rs
1use crate::{2	equals,3	error::{Error::*, Result},4	operator::evaluate_mod_op,5	parse_args, primitive_equals, push, throw, with_state, ArrValue, Context, EvaluationState,6	FuncVal, IndexableVal, LazyVal, Val,7};8use format::{format_arr, format_obj};9use jrsonnet_gc::Gc;10use jrsonnet_interner::IStr;11use jrsonnet_parser::{ArgsDesc, ExprLocation};12use jrsonnet_types::ty;13use std::{collections::HashMap, path::PathBuf, rc::Rc};1415pub mod stdlib;16pub use stdlib::*;1718use self::manifest::{escape_string_json, manifest_json_ex, ManifestJsonOptions, ManifestType};1920pub mod format;21pub mod manifest;22pub mod sort;2324pub fn std_format(str: IStr, vals: Val) -> Result<Val> {25	push(26		Some(&ExprLocation(Rc::from(PathBuf::from("std.jsonnet")), 0, 0)),27		|| format!("std.format of {}", str),28		|| {29			Ok(match vals {30				Val::Arr(vals) => Val::Str(format_arr(&str, &vals.evaluated()?)?.into()),31				Val::Obj(obj) => Val::Str(format_obj(&str, &obj)?.into()),32				o => Val::Str(format_arr(&str, &[o])?.into()),33			})34		},35	)36}3738pub fn std_slice(39	indexable: IndexableVal,40	index: Option<usize>,41	end: Option<usize>,42	step: Option<usize>,43) -> Result<Val> {44	let index = index.unwrap_or(0);45	let end = end.unwrap_or_else(|| match &indexable {46		IndexableVal::Str(_) => usize::MAX,47		IndexableVal::Arr(v) => v.len(),48	});49	let step = step.unwrap_or(1);50	match &indexable {51		IndexableVal::Str(s) => Ok(Val::Str(52			(s.chars()53				.skip(index)54				.take(end - index)55				.step_by(step)56				.collect::<String>())57			.into(),58		)),59		IndexableVal::Arr(arr) => Ok(Val::Arr(60			(arr.iter()61				.skip(index)62				.take(end - index)63				.step_by(step)64				.collect::<Result<Vec<Val>>>()?)65			.into(),66		)),67	}68}6970type Builtin = fn(context: Context, loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val>;7172type BuiltinsType = HashMap<Box<str>, Builtin>;7374thread_local! {75	static BUILTINS: BuiltinsType = {76		[77			("length".into(), builtin_length as Builtin),78			("type".into(), builtin_type),79			("makeArray".into(), builtin_make_array),80			("codepoint".into(), builtin_codepoint),81			("objectFieldsEx".into(), builtin_object_fields_ex),82			("objectHasEx".into(), builtin_object_has_ex),83			("slice".into(), builtin_slice),84			("substr".into(), builtin_substr),85			("primitiveEquals".into(), builtin_primitive_equals),86			("equals".into(), builtin_equals),87			("modulo".into(), builtin_modulo),88			("mod".into(), builtin_mod),89			("floor".into(), builtin_floor),90			("ceil".into(), builtin_ceil),91			("log".into(), builtin_log),92			("pow".into(), builtin_pow),93			("sqrt".into(), builtin_sqrt),94			("sin".into(), builtin_sin),95			("cos".into(), builtin_cos),96			("tan".into(), builtin_tan),97			("asin".into(), builtin_asin),98			("acos".into(), builtin_acos),99			("atan".into(), builtin_atan),100			("exp".into(), builtin_exp),101			("mantissa".into(), builtin_mantissa),102			("exponent".into(), builtin_exponent),103			("extVar".into(), builtin_ext_var),104			("native".into(), builtin_native),105			("filter".into(), builtin_filter),106			("map".into(), builtin_map),107			("flatMap".into(), builtin_flatmap),108			("foldl".into(), builtin_foldl),109			("foldr".into(), builtin_foldr),110			("sortImpl".into(), builtin_sort_impl),111			("format".into(), builtin_format),112			("range".into(), builtin_range),113			("char".into(), builtin_char),114			("encodeUTF8".into(), builtin_encode_utf8),115			("decodeUTF8".into(), builtin_decode_utf8),116			("md5".into(), builtin_md5),117			("base64".into(), builtin_base64),118			("base64DecodeBytes".into(), builtin_base64_decode_bytes),119			("base64Decode".into(), builtin_base64_decode),120			("trace".into(), builtin_trace),121			("join".into(), builtin_join),122			("escapeStringJson".into(), builtin_escape_string_json),123			("manifestJsonEx".into(), builtin_manifest_json_ex),124			("reverse".into(), builtin_reverse),125			("id".into(), builtin_id),126			("strReplace".into(), builtin_str_replace),127			("splitLimit".into(), builtin_splitlimit),128			("parseJson".into(), builtin_parse_json),129		].iter().cloned().collect()130	};131}132133fn builtin_length(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {134	parse_args!(context, "length", args, 1, [135		0, x: ty!((string | object | array));136	], {137		Ok(match x {138			Val::Str(n) => Val::Num(n.chars().count() as f64),139			Val::Arr(a) => Val::Num(a.len() as f64),140			Val::Obj(o) => Val::Num(141				o.fields_visibility()142					.into_iter()143					.filter(|(_k, v)| *v)144					.count() as f64,145			),146			_ => unreachable!(),147		})148	})149}150151fn builtin_type(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {152	parse_args!(context, "type", args, 1, [153		0, x: ty!(any);154	], {155		Ok(Val::Str(x.value_type().name().into()))156	})157}158159fn builtin_make_array(160	context: Context,161	_loc: Option<&ExprLocation>,162	args: &ArgsDesc,163) -> Result<Val> {164	parse_args!(context, "makeArray", args, 2, [165		0, sz: ty!(BoundedNumber<(Some(0.0)), (None)>) => Val::Num;166		1, func: ty!(function) => Val::Func;167	], {168		let mut out = Vec::with_capacity(sz as usize);169		for i in 0..sz as usize {170			out.push(LazyVal::new_resolved(func.evaluate_values(171				context.clone(),172				&[Val::Num(i as f64)]173			)?))174		}175		Ok(Val::Arr(out.into()))176	})177}178179fn builtin_codepoint(180	context: Context,181	_loc: Option<&ExprLocation>,182	args: &ArgsDesc,183) -> Result<Val> {184	parse_args!(context, "codepoint", args, 1, [185		0, str: ty!(char) => Val::Str;186	], {187		Ok(Val::Num(str.chars().next().unwrap() as u32 as f64))188	})189}190191fn builtin_object_fields_ex(192	context: Context,193	_loc: Option<&ExprLocation>,194	args: &ArgsDesc,195) -> Result<Val> {196	parse_args!(context, "objectFieldsEx", args, 2, [197		0, obj: ty!(object) => Val::Obj;198		1, inc_hidden: ty!(boolean) => Val::Bool;199	], {200		let out = obj.fields_ex(inc_hidden);201		Ok(Val::Arr(out.into_iter().map(Val::Str).collect::<Vec<_>>().into()))202	})203}204205fn builtin_object_has_ex(206	context: Context,207	_loc: Option<&ExprLocation>,208	args: &ArgsDesc,209) -> Result<Val> {210	parse_args!(context, "objectHasEx", args, 3, [211		0, obj: ty!(object) => Val::Obj;212		1, f: ty!(string) => Val::Str;213		2, inc_hidden: ty!(boolean) => Val::Bool;214	], {215		Ok(Val::Bool(obj.has_field_ex(f, inc_hidden)))216	})217}218219fn builtin_parse_json(220	context: Context,221	_loc: Option<&ExprLocation>,222	args: &ArgsDesc,223) -> Result<Val> {224	parse_args!(context, "parseJson", args, 1, [225		0, s: ty!(string) => Val::Str;226	], {227		let state = EvaluationState::default();228		let path = PathBuf::from("std.parseJson").into();229		state.evaluate_snippet_raw(path ,s)230	})231}232233fn builtin_slice(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {234	parse_args!(context, "slice", args, 4, [235		0, indexable: ty!((string | array));236		1, index: ty!((number | null));237		2, end: ty!((number | null));238		3, step: ty!((number | null));239	], {240		std_slice(241			indexable.into_indexable()?,242			index.try_cast_nullable_num("index")?.map(|v| v as usize),243			end.try_cast_nullable_num("end")?.map(|v| v as usize),244			step.try_cast_nullable_num("step")?.map(|v| v as usize),245		)246	})247}248249fn builtin_substr(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {250	parse_args!(context, "substr", args, 3, [251		0, str: ty!(string) => Val::Str;252		1, from: ty!(BoundedNumber<(Some(0.0)), (None)>) => Val::Num;253		2, len: ty!(BoundedNumber<(Some(0.0)), (None)>) => Val::Num;254	], {255		let out: String = str.chars().skip(from as usize).take(len as usize).collect();256		Ok(Val::Str(out.into()))257	})258}259260fn builtin_primitive_equals(261	context: Context,262	_loc: Option<&ExprLocation>,263	args: &ArgsDesc,264) -> Result<Val> {265	parse_args!(context, "primitiveEquals", args, 2, [266		0, a: ty!(any);267		1, b: ty!(any);268	], {269		Ok(Val::Bool(primitive_equals(&a, &b)?))270	})271}272273fn builtin_equals(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {274	parse_args!(context, "equals", args, 2, [275		0, a: ty!(any);276		1, b: ty!(any);277	], {278		Ok(Val::Bool(equals(&a, &b)?))279	})280}281282fn builtin_modulo(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {283	parse_args!(context, "modulo", args, 2, [284		0, a: ty!(number) => Val::Num;285		1, b: ty!(number) => Val::Num;286	], {287		Ok(Val::Num(a % b))288	})289}290291fn builtin_mod(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {292	parse_args!(context, "mod", args, 2, [293		0, a: ty!((number | string));294		1, b: ty!(any);295	], {296		evaluate_mod_op(&a, &b)297	})298}299300fn builtin_floor(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {301	parse_args!(context, "floor", args, 1, [302		0, x: ty!(number) => Val::Num;303	], {304		Ok(Val::Num(x.floor()))305	})306}307308fn builtin_ceil(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {309	parse_args!(context, "ceil", args, 1, [310		0, x: ty!(number) => Val::Num;311	], {312		Ok(Val::Num(x.ceil()))313	})314}315316fn builtin_log(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {317	parse_args!(context, "log", args, 1, [318		0, n: ty!(number) => Val::Num;319	], {320		Ok(Val::Num(n.ln()))321	})322}323324fn builtin_pow(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {325	parse_args!(context, "pow", args, 2, [326		0, x: ty!(number) => Val::Num;327		1, n: ty!(number) => Val::Num;328	], {329		Ok(Val::Num(x.powf(n)))330	})331}332333fn builtin_sqrt(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {334	parse_args!(context, "sqrt", args, 1, [335		0, x: ty!(BoundedNumber<(Some(0.0)), (None)>) => Val::Num;336	], {337		Ok(Val::Num(x.sqrt()))338	})339}340341fn builtin_sin(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {342	parse_args!(context, "sin", args, 1, [343		0, x: ty!(number) => Val::Num;344	], {345		Ok(Val::Num(x.sin()))346	})347}348349fn builtin_cos(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {350	parse_args!(context, "cos", args, 1, [351		0, x: ty!(number) => Val::Num;352	], {353		Ok(Val::Num(x.cos()))354	})355}356357fn builtin_tan(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {358	parse_args!(context, "tan", args, 1, [359		0, x: ty!(number) => Val::Num;360	], {361		Ok(Val::Num(x.tan()))362	})363}364365fn builtin_asin(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {366	parse_args!(context, "asin", args, 1, [367		0, x: ty!(number) => Val::Num;368	], {369		Ok(Val::Num(x.asin()))370	})371}372373fn builtin_acos(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {374	parse_args!(context, "acos", args, 1, [375		0, x: ty!(number) => Val::Num;376	], {377		Ok(Val::Num(x.acos()))378	})379}380381fn builtin_atan(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {382	parse_args!(context, "atan", args, 1, [383		0, x: ty!(number) => Val::Num;384	], {385		Ok(Val::Num(x.atan()))386	})387}388389fn builtin_exp(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {390	parse_args!(context, "exp", args, 1, [391		0, x: ty!(number) => Val::Num;392	], {393		Ok(Val::Num(x.exp()))394	})395}396397fn frexp(s: f64) -> (f64, i16) {398	if 0.0 == s {399		return (s, 0);400	} else {401		let lg = s.abs().log2();402		let x = (lg - lg.floor() - 1.0).exp2();403		let exp = lg.floor() + 1.0;404		(s.signum() * x, exp as i16)405	}406}407408fn builtin_mantissa(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {409	parse_args!(context, "mantissa", args, 1, [410		0, x: ty!(number) => Val::Num;411	], {412		Ok(Val::Num(frexp(x).0))413	})414}415416fn builtin_exponent(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {417	parse_args!(context, "exponent", args, 1, [418		0, x: ty!(number) => Val::Num;419	], {420		Ok(Val::Num(frexp(x).1.into()))421	})422}423424fn builtin_ext_var(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {425	parse_args!(context, "extVar", args, 1, [426		0, x: ty!(string) => Val::Str;427	], {428		Ok(with_state(|s| s.settings().ext_vars.get(&x).cloned()).ok_or(UndefinedExternalVariable(x))?)429	})430}431432fn builtin_native(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {433	parse_args!(context, "native", args, 1, [434		0, x: ty!(string) => Val::Str;435	], {436		Ok(with_state(|s| s.settings().ext_natives.get(&x).cloned()).map(|v| Val::Func(Gc::new(FuncVal::NativeExt(x.clone(), v)))).ok_or(UndefinedExternalFunction(x))?)437	})438}439440fn builtin_filter(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {441	parse_args!(context, "filter", args, 2, [442		0, func: ty!(function) => Val::Func;443		1, arr: ty!(array) => Val::Arr;444	], {445		Ok(Val::Arr(arr.filter(|val| func446			.evaluate_values(context.clone(), &[val.clone()])?447			.try_cast_bool("filter predicate"))?))448	})449}450451fn builtin_map(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {452	parse_args!(context, "map", args, 2, [453		0, func: ty!(function) => Val::Func;454		1, arr: ty!(array) => Val::Arr;455	], {456		Ok(Val::Arr(arr.map(|val| func457			.evaluate_values(context.clone(), &[val]))?))458	})459}460461fn builtin_flatmap(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {462	parse_args!(context, "flatMap", args, 2, [463		0, func: ty!(function) => Val::Func;464		1, arr: ty!((array | string));465	], {466		match arr {467			Val::Str(s) => {468				let mut out = String::new();469				for c in s.chars() {470					match func.evaluate_values(context.clone(), &[Val::Str(c.to_string().into())])? {471						Val::Str(o) => out.push_str(&o),472						_ => throw!(RuntimeError("in std.join all items should be strings".into())),473					};474				}475				Ok(Val::Str(out.into()))476			},477			Val::Arr(a) => {478				let mut out = Vec::new();479				for el in a.iter() {480					let el = el?;481					match func.evaluate_values(context.clone(), &[el])? {482						Val::Arr(o) => for oe in o.iter() {483							out.push(oe?)484						},485						_ => throw!(RuntimeError("in std.join all items should be arrays".into())),486					};487				}488				Ok(Val::Arr(out.into()))489			},490			_ => unreachable!(),491		}492	})493}494495fn builtin_foldl(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {496	parse_args!(context, "foldl", args, 3, [497		0, func: ty!(function) => Val::Func;498		1, arr: ty!(array) => Val::Arr;499		2, init: ty!(any);500	], {501		let mut acc = init;502		for i in arr.iter() {503			acc = func.evaluate_values(context.clone(), &[acc, i?])?;504		}505		Ok(acc)506	})507}508509fn builtin_foldr(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {510	parse_args!(context, "foldr", args, 3, [511		0, func: ty!(function) => Val::Func;512		1, arr: ty!(array) => Val::Arr;513		2, init: ty!(any);514	], {515		let mut acc = init;516		for i in arr.iter().rev() {517			acc = func.evaluate_values(context.clone(), &[acc, i?])?;518		}519		Ok(acc)520	})521}522523#[allow(non_snake_case)]524fn builtin_sort_impl(525	context: Context,526	_loc: Option<&ExprLocation>,527	args: &ArgsDesc,528) -> Result<Val> {529	parse_args!(context, "sort", args, 2, [530		0, arr: ty!(array) => Val::Arr;531		1, keyF: ty!(function) => Val::Func;532	], {533		if arr.len() <= 1 {534			return Ok(Val::Arr(arr))535		}536		Ok(Val::Arr(ArrValue::Eager(sort::sort(context, arr.evaluated()?, &keyF)?)))537	})538}539540fn builtin_format(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {541	parse_args!(context, "format", args, 2, [542		0, str: ty!(string) => Val::Str;543		1, vals: ty!(any)544	], {545		std_format(str, vals)546	})547}548549fn builtin_range(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {550	parse_args!(context, "range", args, 2, [551		0, from: ty!(number) => Val::Num;552		1, to: ty!(number) => Val::Num;553	], {554		if to < from {555			return Ok(Val::Arr(ArrValue::new_eager()))556		}557		let mut out = Vec::with_capacity((1+to as usize-from as usize).max(0));558		for i in from as usize..=to as usize {559			out.push(Val::Num(i as f64));560		}561		Ok(Val::Arr(out.into()))562	})563}564565fn builtin_char(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {566	parse_args!(context, "char", args, 1, [567		0, n: ty!(number) => Val::Num;568	], {569		let mut out = String::new();570		out.push(std::char::from_u32(n as u32).ok_or_else(||571			InvalidUnicodeCodepointGot(n as u32)572		)?);573		Ok(Val::Str(out.into()))574	})575}576577fn builtin_encode_utf8(578	context: Context,579	_loc: Option<&ExprLocation>,580	args: &ArgsDesc,581) -> Result<Val> {582	parse_args!(context, "encodeUTF8", args, 1, [583		0, str: ty!(string) => Val::Str;584	], {585		Ok(Val::Arr((str.bytes().map(|b| Val::Num(b as f64)).collect::<Vec<Val>>()).into()))586	})587}588589fn builtin_decode_utf8(590	context: Context,591	_loc: Option<&ExprLocation>,592	args: &ArgsDesc,593) -> Result<Val> {594	parse_args!(context, "decodeUTF8", args, 1, [595		0, arr: ty!((Array<ubyte>)) => Val::Arr;596	], {597		let data: Result<Vec<u8>> = arr.iter().map(|v| v.map(|v| match v{598			Val::Num(n) => n as u8,599			_ => unreachable!(),600		})).collect();601		let data = data?;602		Ok(Val::Str(String::from_utf8(data).map_err(|_| RuntimeError("bad utf8".into()))?.into()))603	})604}605606fn builtin_md5(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {607	parse_args!(context, "md5", args, 1, [608		0, str: ty!(string) => Val::Str;609	], {610		Ok(Val::Str(format!("{:x}", md5::compute(&str.as_bytes())).into()))611	})612}613614fn builtin_trace(context: Context, loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {615	parse_args!(context, "trace", args, 2, [616		0, str: ty!(string) => Val::Str;617		1, rest: ty!(any);618	], {619		eprint!("TRACE:");620		if let Some(loc) = loc {621			with_state(|s|{622				let locs = s.map_source_locations(&loc.0, &[loc.1]);623				eprint!(" {}:{}", loc.0.file_name().unwrap().to_str().unwrap(), locs[0].line);624			});625		}626		eprintln!(" {}", str);627		Ok(rest)628	})629}630631fn builtin_base64(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {632	parse_args!(context, "base64", args, 1, [633		0, input: ty!((string | (Array<number>)));634	], {635		Ok(Val::Str(match input {636			Val::Str(s) => {637				base64::encode(s.bytes().collect::<Vec<_>>()).into()638			},639			Val::Arr(a) => {640				base64::encode(a.iter().map(|v| {641					Ok(v?.unwrap_num()? as u8)642				}).collect::<Result<Vec<_>>>()?).into()643			},644			_ => unreachable!()645		}))646	})647}648649fn builtin_base64_decode_bytes(650	context: Context,651	_loc: Option<&ExprLocation>,652	args: &ArgsDesc,653) -> Result<Val> {654	parse_args!(context, "base64DecodeBytes", args, 1, [655		0, input: ty!(string) => Val::Str;656	], {657		Ok(Val::Arr(658			base64::decode(&input.as_bytes())659				.map_err(|_| RuntimeError("bad base64".into()))?660				.iter()661				.map(|v| Val::Num(*v as f64)).collect::<Vec<_>>().into()662		))663	})664}665666fn builtin_base64_decode(667	context: Context,668	_loc: Option<&ExprLocation>,669	args: &ArgsDesc,670) -> Result<Val> {671	parse_args!(context, "base64Decode", args, 1, [672		0, input: ty!(string) => Val::Str;673	], {674		Ok(Val::Str(675			String::from_utf8(base64::decode(&input.as_bytes())676				.map_err(|_| RuntimeError("bad base64".into()))?)677				.map_err(|_| RuntimeError("bad utf8".into()))?.into()678		))679	})680}681682fn builtin_join(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {683	parse_args!(context, "join", args, 2, [684		0, sep: ty!((string | array));685		1, arr: ty!(array) => Val::Arr;686	], {687		Ok(match sep {688			Val::Arr(joiner_items) => {689				let mut out = Vec::new();690691				let mut first = true;692				for item in arr.iter() {693					let item = item?.clone();694					if let Val::Arr(items) = item {695						if !first {696							out.reserve(joiner_items.len());697							// TODO: extend698							for item in joiner_items.iter() {699								out.push(item?);700							}701						}702						first = false;703						out.reserve(items.len());704						// TODO: extend705						for item in items.iter() {706							out.push(item?);707						}708					} else {709						throw!(RuntimeError("in std.join all items should be arrays".into()));710					}711				}712713				Val::Arr(out.into())714			},715			Val::Str(sep) => {716				let mut out = String::new();717718				let mut first = true;719				for item in arr.iter() {720					let item = item?.clone();721					if let Val::Str(item) = item {722						if !first {723							out += &sep;724						}725						first = false;726						out += &item;727					} else {728						throw!(RuntimeError("in std.join all items should be strings".into()));729					}730				}731732				Val::Str(out.into())733			},734			_ => unreachable!()735		})736	})737}738739fn builtin_escape_string_json(740	context: Context,741	_loc: Option<&ExprLocation>,742	args: &ArgsDesc,743) -> Result<Val> {744	parse_args!(context, "escapeStringJson", args, 1, [745		0, str_: ty!(string) => Val::Str;746	], {747		Ok(Val::Str(escape_string_json(&str_).into()))748	})749}750751fn builtin_manifest_json_ex(752	context: Context,753	_loc: Option<&ExprLocation>,754	args: &ArgsDesc,755) -> Result<Val> {756	parse_args!(context, "manifestJsonEx", args, 2, [757		0, value: ty!(any);758		1, indent: ty!(string) => Val::Str;759	], {760		Ok(Val::Str(manifest_json_ex(&value, &ManifestJsonOptions {761			padding: &indent,762			mtype: ManifestType::Std,763		})?.into()))764	})765}766767fn builtin_reverse(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {768	parse_args!(context, "reverse", args, 1, [769		0, value: ty!(array) => Val::Arr;770	], {771		Ok(Val::Arr(value.reversed()))772	})773}774775fn builtin_id(context: Context, _loc: Option<&ExprLocation>, args: &ArgsDesc) -> Result<Val> {776	parse_args!(context, "id", args, 1, [777		0, v: ty!(any);778	], {779		Ok(v)780	})781}782783fn builtin_str_replace(784	context: Context,785	_loc: Option<&ExprLocation>,786	args: &ArgsDesc,787) -> Result<Val> {788	parse_args!(context, "strReplace", args, 3, [789		0, str: ty!(string) => Val::Str;790		1, from: ty!(string) => Val::Str;791		2, to: ty!(string) => Val::Str;792	], {793		let mut out = String::new();794		let mut last_idx = 0;795		while let Some(idx) = (&str[last_idx..]).find(&from as &str) {796			out.push_str(&str[last_idx..last_idx+idx]);797			out.push_str(&to);798			last_idx += idx + from.len();799		}800		if last_idx == 0 {801			return Ok(Val::Str(str))802		}803		out.push_str(&str[last_idx..]);804		Ok(Val::Str(out.into()))805	})806}807808fn builtin_splitlimit(809	context: Context,810	_loc: Option<&ExprLocation>,811	args: &ArgsDesc,812) -> Result<Val> {813	parse_args!(context, "splitLimit", args, 3, [814		0, str: ty!(string) => Val::Str;815		1, c: ty!(char) => Val::Str;816		2, maxsplits: ty!(number) => Val::Num;817	], {818		let maxsplits = maxsplits as isize;819		let c = c.chars().next().unwrap();820821		let out: Vec<Val> = if maxsplits == -1 {822			str.split(c).map(|s| Val::Str(s.into())).collect()823		} else {824			str.splitn(maxsplits as usize + 1, c).map(|s| Val::Str(s.into())).collect()825		};826827		Ok(Val::Arr(out.into()))828	})829}830831pub fn call_builtin(832	context: Context,833	loc: Option<&ExprLocation>,834	name: &str,835	args: &ArgsDesc,836) -> Result<Val> {837	BUILTINS838		.with(|builtins| builtins.get(name).copied())839		.ok_or_else(|| IntrinsicNotFound(name.into()))?(context, loc, args)840}
modifiedcrates/jrsonnet-evaluator/src/typed.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/typed.rs
+++ b/crates/jrsonnet-evaluator/src/typed.rs
@@ -32,8 +32,8 @@
 	UnionFailed(ComplexValType, TypeLocErrorList),
 	#[error(
 		"number out of bounds: {0} not in {}..{}",
-		.1.map(|v|v.to_string()).unwrap_or("".to_owned()),
-		.2.map(|v|v.to_string()).unwrap_or("".to_owned()),
+		.1.map(|v|v.to_string()).unwrap_or_else(|| "".to_owned()),
+		.2.map(|v|v.to_string()).unwrap_or_else(|| "".to_owned()),
 	)]
 	BoundsFailed(f64, Option<f64>, Option<f64>),
 }