git.delta.rocks / jrsonnet / refs/commits / 46fae7b561fd

difftreelog

ci fix clippy warnings

Lach2020-08-23parent: #0629674.patch.diff
in: master

3 files changed

deletedMakefilediffbeforeafterboth

no changes

modifiedREADME.mddiffbeforeafterboth
--- a/README.md
+++ b/README.md
@@ -32,8 +32,6 @@
 
 Official benchmark report are available [in this gist](https://gist.github.com/CertainLach/5770d7ad4836066f8e0bd91e823e451b), and updated sometimes. Here it tested against golang, C++, and scala impl. As you can see, it is a lot faster
 
-You can generate this report by calling `make benchmarks`, but it probally won't work in standard setup, you need to link golang jsonnet impl to gojsonnet, and c++ impl to jsonnet.
-
 TODO: Create docker container for easier benchmarking and/or benchmark in CI
 
 Also, there is some ideas to improve performance even further, by i.e:
modifiedcrates/jrsonnet-evaluator/src/builtin/format.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/builtin/format.rs
+++ b/crates/jrsonnet-evaluator/src/builtin/format.rs
@@ -690,12 +690,11 @@
 					if f.is_empty() {
 						throw!(MappingKeysRequired);
 					}
-					let value = if let Some(v) = values.get(f.clone())? {
+					if let Some(v) = values.get(f.clone())? {
 						v
 					} else {
 						throw!(NoSuchFormatField(f));
-					};
-					value
+					}
 				};
 
 				format_code(&mut out, &value, &c, width, precision)?;