difftreelog
fix legacy ssh store support
in: trunk
4 files changed
cmds/fleet/src/cmds/build_systems.rsdiffbeforeafterboth--- a/cmds/fleet/src/cmds/build_systems.rs
+++ b/cmds/fleet/src/cmds/build_systems.rs
@@ -106,6 +106,9 @@
if let Some(destination) = opts.action_attr::<String>(&host, "dest").await? {
host.set_session_destination(destination);
};
+ if let Some(legacy) = opts.action_attr::<bool>(&host, "legacy_ssh_store").await? {
+ host.set_legacy_ssh_store(legacy);
+ };
set.spawn_local(
(async move {
crates/fleet-base/src/host.rsdiffbeforeafterboth--- a/crates/fleet-base/src/host.rs
+++ b/crates/fleet-base/src/host.rs
@@ -13,7 +13,7 @@
use anyhow::{Context, Result, anyhow, bail, ensure};
use fleet_shared::SecretData;
use nix_eval::{Value, nix_go, nix_go_json, util::assert_warn};
-use openssh::SessionBuilder;
+use openssh::{ControlPersist, SessionBuilder};
use serde::de::DeserializeOwned;
use tabled::Tabled;
use tempfile::NamedTempFile;
@@ -99,6 +99,7 @@
// TODO: Both of those values are taken from host opts, there should be a cleaner way to specify it
deploy_kind: OnceCell<DeployKind>,
session_destination: OnceCell<String>,
+ legacy_ssh_store: OnceCell<bool>,
pub host_config: Option<Value>,
pub nixos_config: OnceCell<Value>,
@@ -219,6 +220,11 @@
.set(kind)
.expect("deploy kind is already set");
}
+ pub fn set_legacy_ssh_store(&self, legacy: bool) {
+ self.legacy_ssh_store
+ .set(legacy)
+ .expect("legacy ssh store is already set")
+ }
pub async fn deploy_kind(&self) -> Result<DeployKind> {
if let Some(kind) = self.deploy_kind.get() {
return Ok(*kind);
@@ -263,7 +269,8 @@
if let Some(session) = &self.session.get() {
return Ok((*session).clone());
};
- let session = SessionBuilder::default();
+ let mut session = SessionBuilder::default();
+ session.control_persist(ControlPersist::ClosedAfterInitialConnection);
let dest = self.session_destination.get().unwrap_or(&self.name);
let session = session
@@ -418,9 +425,15 @@
);
nix.arg("copy").arg("--substitute-on-destination");
+ let proto = if self.legacy_ssh_store.get().cloned().unwrap_or(false) {
+ "ssh"
+ } else {
+ "ssh-ng"
+ };
+
match self.deploy_kind().await? {
DeployKind::Fleet | DeployKind::UpgradeToFleet | DeployKind::NixosLustrate => {
- nix.comparg("--to", format!("ssh-ng://{}", self.name));
+ nix.comparg("--to", format!("{proto}://{}", self.name));
}
DeployKind::NixosInstall => {
nix
@@ -428,7 +441,7 @@
.arg("--no-check-sigs")
.comparg(
"--to",
- format!("ssh-ng://root@{}?remote-store=/mnt", self.name),
+ format!("{proto}://root@{}?remote-store=/mnt", self.name),
);
}
}
@@ -568,6 +581,7 @@
session: OnceLock::new(),
deploy_kind: OnceCell::new(),
session_destination: OnceCell::new(),
+ legacy_ssh_store: OnceCell::new(),
}
}
@@ -589,6 +603,7 @@
session: OnceLock::new(),
deploy_kind: OnceCell::new(),
session_destination: OnceCell::new(),
+ legacy_ssh_store: OnceCell::new(),
})
}
pub async fn list_hosts(&self) -> Result<Vec<ConfigHost>> {
crates/fleet-shared/src/encoding.rsdiffbeforeafterboth--- a/crates/fleet-shared/src/encoding.rs
+++ b/crates/fleet-shared/src/encoding.rs
@@ -1,6 +1,5 @@
use std::{
- fmt::{self, Display},
- str::FromStr,
+ collections::BTreeMap, fmt::{self, Display}, str::FromStr
};
use base64::engine::{Engine, general_purpose::STANDARD_NO_PAD};
flake.nixdiffbeforeafterboth168 cargo-fuzz168 cargo-fuzz169 cargo-watch169 cargo-watch170 cargo-outdated170 cargo-outdated171 gdb172171173 pkg-config172 pkg-config174 openssl173 openssl175 bacon176 nil177 rustPlatform.bindgenHook174 rustPlatform.bindgenHook178 inputs'.nix.packages.nix-expr-c175 inputs'.nix.packages.nix-expr-c179 inputs'.nix.packages.nix-flake-c176 inputs'.nix.packages.nix-flake-c