difftreelog
fix do not assert for secret regeneration command
in: trunk
4 files changed
cmds/fleet/src/main.rsdiffbeforeafterboth--- a/cmds/fleet/src/main.rs
+++ b/cmds/fleet/src/main.rs
@@ -203,7 +203,13 @@
.map(|a| extra_args::parse_os(&a))
.transpose()?
.unwrap_or_default();
- let config = opts.fleet_opts.build(nix_args).await?;
+ let config = opts
+ .fleet_opts
+ .build(
+ nix_args,
+ matches!(opts.command, Opts::Deploy(_) | Opts::BuildSystems(_)),
+ )
+ .await?;
match run_command(&config, opts.fleet_opts, opts.command).await {
Ok(()) => {
crates/fleet-base/src/opts.rsdiffbeforeafterboth--- a/crates/fleet-base/src/opts.rs
+++ b/crates/fleet-base/src/opts.rs
@@ -181,7 +181,7 @@
}
// TODO: Config should be detached from opts.
- pub async fn build(&self, nix_args: Vec<OsString>) -> Result<Config> {
+ pub async fn build(&self, nix_args: Vec<OsString>, assert: bool) -> Result<Config> {
let directory = current_dir()?;
let pool = NixSessionPool::new(
@@ -204,7 +204,9 @@
let config_field = nix_go!(fleet_field.config);
- assert_warn("fleet config evaluation", &config_field).await?;
+ if assert {
+ assert_warn("fleet config evaluation", &config_field).await?;
+ }
let import = nix_go!(builtins_field.import);
let overlays = nix_go!(config_field.nixpkgs.overlays);
crates/nix-eval/src/util.rsdiffbeforeafterboth1use std::time::Instant;21use anyhow::bail;3use anyhow::bail;2use tracing::{debug, warn};4use tracing::{debug, warn};3use std::time::Instant;455use crate::{nix_go_json, Value};6use crate::{nix_go_json, Value};678#[tracing::instrument(level = "info", skip(val))]7pub async fn assert_warn(action: &str, val: &Value) -> anyhow::Result<()> {9pub async fn assert_warn(action: &str, val: &Value) -> anyhow::Result<()> {8 let before_errors = Instant::now();10 let before_errors = Instant::now();9 let errors: Vec<String> = nix_go_json!(val.errors);11 let errors: Vec<String> = nix_go_json!(val.errors);10 debug!("errors evaluation took {:?}", before_errors.elapsed());12 debug!("errors evaluation took {:?}", before_errors.elapsed());11 if !errors.is_empty() {13 if !errors.is_empty() {12 bail!(14 bail!(13 "{action} failed with error{}{}",15 "failed with error{}{}",14 (errors.len() != 1).then_some("s:\n- ").unwrap_or(": "),16 if errors.len() != 1 { "s:\n- " } else { ": " },15 errors.join("\n- "),17 errors.join("\n- "),16 );18 );17 }19 }21 debug!("warnings evaluation took {:?}", before_errors.elapsed());23 debug!("warnings evaluation took {:?}", before_errors.elapsed());22 if !warnings.is_empty() {24 if !warnings.is_empty() {23 warn!(25 warn!(24 "{action} completed with warning{}{}",26 "completed with warning{}{}",25 (warnings.len() != 1).then_some("s:\n- ").unwrap_or(": "),27 if warnings.len() != 1 { "s:\n- " } else { ": " },26 warnings.join("\n- "),28 warnings.join("\n- "),27 );29 );28 }30 }modules/secrets-data.nixdiffbeforeafterboth--- a/modules/secrets-data.nix
+++ b/modules/secrets-data.nix
@@ -52,6 +52,7 @@
default = null;
};
};
+ config = {};
};
hostSecretData = {
@@ -78,6 +79,7 @@
default = null;
};
};
+ config = {};
};
in {
options.data = mkDataOption ({config, ...}: {