git.delta.rocks / jrsonnet / refs/commits / 27958b04316f

difftreelog

refactor cleanup

pyypxomoYaroslav Bolyukin2026-03-23parent: #325f0a1.patch.diff
in: master

9 files changed

modifiedbindings/jsonnet/src/lib.rsdiffbeforeafterboth
--- a/bindings/jsonnet/src/lib.rs
+++ b/bindings/jsonnet/src/lib.rs
@@ -45,8 +45,8 @@
 /// If this does not match `LIB_JSONNET_VERSION`
 /// then there is a mismatch between header and compiled library.
 #[no_mangle]
-pub extern "C" fn jsonnet_version() -> &'static [u8; 8] {
-	b"v0.20.0\0"
+pub extern "C" fn jsonnet_version() -> &'static [u8; 12] {
+	b"v0.22.0-rc1\0"
 }
 
 unsafe fn parse_path(input: &CStr) -> Cow<'_, Path> {
modifiedcrates/jrsonnet-evaluator/src/async_import.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/async_import.rs
+++ b/crates/jrsonnet-evaluator/src/async_import.rs
@@ -3,11 +3,7 @@
 
 use jrsonnet_gcmodule::Acyclic;
 use jrsonnet_ir::visit::Visitor;
-use jrsonnet_ir::{
-	ArgsDesc, AssertExpr, AssertStmt, BindSpec, CompSpec, Destruct, Expr, ExprParam, ExprParams,
-	FieldMember, FieldName, ForSpecData, IStr, IfElse, IfSpecData, ImportKind, ObjBody, Slice,
-	SliceDesc, Source, SourcePath, Spanned,
-};
+use jrsonnet_ir::{IStr, Source, SourcePath};
 use rustc_hash::FxHashMap;
 
 use crate::{AsPathLike, FileData, ImportResolver, ResolvePathOwned, State};
@@ -23,7 +19,7 @@
 		self.0.push(Import {
 			path: ResolvePathOwned::Str(value.to_string()),
 			expression,
-		})
+		});
 	}
 }
 
modifiedcrates/jrsonnet-evaluator/src/lib.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/lib.rs
+++ b/crates/jrsonnet-evaluator/src/lib.rs
@@ -5,7 +5,7 @@
 extern crate self as jrsonnet_evaluator;
 
 mod arr;
-// pub mod async_import;
+pub mod async_import;
 mod ctx;
 mod dynamic;
 pub mod error;
modifiedcrates/jrsonnet-evaluator/src/obj/mod.rsdiffbeforeafterboth
--- a/crates/jrsonnet-evaluator/src/obj/mod.rs
+++ b/crates/jrsonnet-evaluator/src/obj/mod.rs
@@ -1,5 +1,13 @@
 use std::{
-	any::Any, cell::{Cell, RefCell}, clone::Clone, cmp::Reverse, collections::hash_map::Entry, fmt::{self, Debug}, hash::{Hash, Hasher}, num::Saturating, ops::ControlFlow
+	any::Any,
+	cell::{Cell, RefCell},
+	clone::Clone,
+	cmp::Reverse,
+	collections::hash_map::Entry,
+	fmt::{self, Debug},
+	hash::{Hash, Hasher},
+	num::Saturating,
+	ops::ControlFlow,
 };
 
 use educe::Educe;
modifiedcrates/jrsonnet-ir-parser/src/lib.rsdiffbeforeafterboth
--- a/crates/jrsonnet-ir-parser/src/lib.rs
+++ b/crates/jrsonnet-ir-parser/src/lib.rs
@@ -3,9 +3,9 @@
 use jrsonnet_gcmodule::Acyclic;
 use jrsonnet_ir::{
 	unescape, ArgsDesc, AssertExpr, AssertStmt, BinaryOp, BinaryOpType, BindSpec, CompSpec,
-	Destruct, DestructRest, Expr, ExprParam, ExprParams, FieldMember, FieldName, ForSpecData, IStr,
-	IfElse, IfSpecData, ImportKind, IndexPart, LiteralType, Member, ObjBody, ObjComp, ObjMembers,
-	Slice, SliceDesc, Source, Span, Spanned, UnaryOpType, Visibility,
+	Destruct, Expr, ExprParam, ExprParams, FieldMember, FieldName, ForSpecData, IStr, IfElse,
+	IfSpecData, ImportKind, IndexPart, LiteralType, Member, ObjBody, ObjComp, ObjMembers, Slice,
+	SliceDesc, Source, Span, Spanned, UnaryOpType, Visibility,
 };
 use jrsonnet_lexer::{collect_lexed_str_block, Lexeme, Lexer, SyntaxKind, T};
 
@@ -30,7 +30,7 @@
 	}
 }
 
-type R<T> = Result<T, ParseError>;
+type Result<T> = std::result::Result<T, ParseError>;
 
 struct Parser<'a> {
 	lexemes: Vec<Lexeme<'a>>,
@@ -103,7 +103,7 @@
 		}
 	}
 
-	fn eat(&mut self, t: SyntaxKind) -> R<()> {
+	fn eat(&mut self, t: SyntaxKind) -> Result<()> {
 		if !self.at(t) {
 			return Err(self.error(format!(
 				"expected {}, got {}",
@@ -138,15 +138,13 @@
 		}
 	}
 
-	fn expect_ident(&mut self) -> R<IStr> {
+	fn expect_ident(&mut self) -> Result<IStr> {
 		if !self.at(SyntaxKind::IDENT) {
 			return Err(self.error(format!("expected identifier, got {}", self.current_desc())));
 		}
 		let text = self.text();
 		if is_reserved(text) {
-			return Err(self.error(format!(
-				"expected identifier, got reserved word '{text}'"
-			)));
+			return Err(self.error(format!("expected identifier, got reserved word '{text}'")));
 		}
 		let s: IStr = text.into();
 		self.eat_any();
@@ -164,36 +162,38 @@
 		"assert"
 			| "else" | "error"
 			| "false" | "for"
-			| "function" | "if"
-			| "import" | "importstr"
-			| "importbin" | "in"
-			| "local" | "null"
-			| "tailstrict" | "then"
-			| "self" | "super"
-			| "true"
+			| "function"
+			| "if" | "import"
+			| "importstr"
+			| "importbin"
+			| "in" | "local"
+			| "null" | "tailstrict"
+			| "then" | "self"
+			| "super" | "true"
 	)
 }
 
-fn spanned<T: Acyclic>(p: &mut Parser<'_>, cb: impl FnOnce(&mut Parser<'_>) -> R<T>) -> R<Spanned<T>> {
+fn spanned<T: Acyclic>(
+	p: &mut Parser<'_>,
+	cb: impl FnOnce(&mut Parser<'_>) -> Result<T>,
+) -> Result<Spanned<T>> {
 	let start = p.span_start();
 	let v = cb(p)?;
 	let end = p.span_end();
 	Ok(Spanned::new(v, Span(p.source.clone(), start, end)))
 }
 
-fn parse_string_content(p: &mut Parser<'_>) -> R<IStr> {
+fn parse_string_content(p: &mut Parser<'_>) -> Result<IStr> {
 	let kind = p.peek();
 	let text = p.text();
 	let s = match kind {
 		SyntaxKind::STRING_DOUBLE => {
 			let inner = &text[1..text.len() - 1];
-			unescape::unescape(inner)
-				.ok_or_else(|| p.error("invalid string escape".into()))?
+			unescape::unescape(inner).ok_or_else(|| p.error("invalid string escape".into()))?
 		}
 		SyntaxKind::STRING_SINGLE => {
 			let inner = &text[1..text.len() - 1];
-			unescape::unescape(inner)
-				.ok_or_else(|| p.error("invalid string escape".into()))?
+			unescape::unescape(inner).ok_or_else(|| p.error("invalid string escape".into()))?
 		}
 		SyntaxKind::STRING_DOUBLE_VERBATIM => {
 			let inner = &text[2..text.len() - 1];
@@ -236,7 +236,7 @@
 	)
 }
 
-fn parse_number(p: &mut Parser<'_>) -> R<f64> {
+fn parse_number(p: &mut Parser<'_>) -> Result<f64> {
 	let text = p.text();
 	let n: f64 = text
 		.replace('_', "")
@@ -263,7 +263,7 @@
 	Some(t)
 }
 
-fn assert_stmt(p: &mut Parser<'_>) -> R<AssertStmt> {
+fn assert_stmt(p: &mut Parser<'_>) -> Result<AssertStmt> {
 	p.eat(T![assert])?;
 	let cond = spanned(p, expr)?;
 	let msg = if p.try_eat(T![:]) {
@@ -274,13 +274,13 @@
 	Ok(AssertStmt(cond, msg))
 }
 
-fn if_spec_data(p: &mut Parser<'_>) -> R<IfSpecData> {
+fn if_spec_data(p: &mut Parser<'_>) -> Result<IfSpecData> {
 	let v = spanned(p, |p| p.eat(T![if]))?;
 	let cond = expr(p)?;
 	Ok(IfSpecData { span: v.span, cond })
 }
 
-fn if_else(p: &mut Parser<'_>) -> R<IfElse> {
+fn if_else(p: &mut Parser<'_>) -> Result<IfElse> {
 	let cond = if_spec_data(p)?;
 	p.eat(T![then])?;
 	let cond_then = expr(p)?;
@@ -296,7 +296,7 @@
 	})
 }
 
-fn slice_desc(p: &mut Parser<'_>, start: Option<Spanned<Expr>>) -> R<SliceDesc> {
+fn slice_desc(p: &mut Parser<'_>, start: Option<Spanned<Expr>>) -> Result<SliceDesc> {
 	p.eat(T![:])?;
 	let end = if !p.at(T![:]) && !p.at(T![']']) {
 		Some(spanned(p, expr)?)
@@ -315,15 +315,12 @@
 	Ok(SliceDesc { start, end, step })
 }
 
-fn destruct(p: &mut Parser<'_>) -> R<Destruct> {
+fn destruct(p: &mut Parser<'_>) -> Result<Destruct> {
 	if p.at_ident() {
 		return Ok(Destruct::Full(p.expect_ident()?));
 	}
 	#[cfg(not(feature = "exp-destruct"))]
-	return Err(p.error(format!(
-		"expected identifier, got {}",
-		p.current_desc()
-	)));
+	return Err(p.error(format!("expected identifier, got {}", p.current_desc())));
 	#[cfg(feature = "exp-destruct")]
 	{
 		if p.try_eat(T![?]) {
@@ -343,17 +340,17 @@
 }
 
 #[cfg(feature = "exp-destruct")]
-fn destruct_rest(p: &mut Parser<'_>) -> R<DestructRest> {
+fn destruct_rest(p: &mut Parser<'_>) -> Result<jrsonnet_ir::DestructRest> {
 	p.eat(T![...])?;
 	if p.at_ident() {
-		Ok(DestructRest::Keep(p.expect_ident()?))
+		Ok(jrsonnet_ir::DestructRest::Keep(p.expect_ident()?))
 	} else {
-		Ok(DestructRest::Drop)
+		Ok(jrsonnet_ir::DestructRest::Drop)
 	}
 }
 
 #[cfg(feature = "exp-destruct")]
-fn destruct_array(p: &mut Parser<'_>) -> R<Destruct> {
+fn destruct_array(p: &mut Parser<'_>) -> Result<Destruct> {
 	p.eat(T!['['])?;
 	let mut start = Vec::new();
 	let mut rest = None;
@@ -391,7 +388,7 @@
 }
 
 #[cfg(feature = "exp-destruct")]
-fn destruct_object(p: &mut Parser<'_>) -> R<Destruct> {
+fn destruct_object(p: &mut Parser<'_>) -> Result<Destruct> {
 	p.eat(T!['{'])?;
 	let mut fields = Vec::new();
 	let mut rest = None;
@@ -426,7 +423,7 @@
 	Ok(Destruct::Object { fields, rest })
 }
 
-fn params(p: &mut Parser<'_>) -> R<ExprParams> {
+fn params(p: &mut Parser<'_>) -> Result<ExprParams> {
 	if p.at(T![')']) {
 		return Ok(ExprParams::new(Vec::new()));
 	}
@@ -452,7 +449,7 @@
 	Ok(ExprParams::new(result))
 }
 
-fn args(p: &mut Parser<'_>) -> R<ArgsDesc> {
+fn args(p: &mut Parser<'_>) -> Result<ArgsDesc> {
 	if p.at(T![')']) {
 		return Ok(ArgsDesc::new(Vec::new(), Vec::new()));
 	}
@@ -489,7 +486,7 @@
 	Ok(ArgsDesc::new(unnamed, named))
 }
 
-fn bind(p: &mut Parser<'_>) -> R<BindSpec> {
+fn bind(p: &mut Parser<'_>) -> Result<BindSpec> {
 	#[cfg(feature = "exp-destruct")]
 	{
 		if !p.at_ident() {
@@ -520,7 +517,7 @@
 	}
 }
 
-fn visibility(p: &mut Parser<'_>) -> R<Visibility> {
+fn visibility(p: &mut Parser<'_>) -> Result<Visibility> {
 	p.eat(T![:])?;
 	if p.try_eat(T![:]) {
 		if p.try_eat(T![:]) {
@@ -533,7 +530,7 @@
 	}
 }
 
-fn field_name(p: &mut Parser<'_>) -> R<FieldName> {
+fn field_name(p: &mut Parser<'_>) -> Result<FieldName> {
 	if p.at_ident() {
 		Ok(FieldName::Fixed(p.expect_ident()?))
 	} else if is_string_token(p.peek()) {
@@ -548,7 +545,7 @@
 	}
 }
 
-fn field(p: &mut Parser<'_>) -> R<FieldMember> {
+fn field(p: &mut Parser<'_>) -> Result<FieldMember> {
 	let name = spanned(p, field_name)?;
 
 	if p.at(T!['(']) {
@@ -578,7 +575,7 @@
 	}
 }
 
-fn member(p: &mut Parser<'_>) -> R<Member> {
+fn member(p: &mut Parser<'_>) -> Result<Member> {
 	if p.at(T![local]) {
 		p.eat(T![local])?;
 		Ok(Member::BindStmt(bind(p)?))
@@ -589,7 +586,7 @@
 	}
 }
 
-fn for_spec(p: &mut Parser<'_>) -> R<ForSpecData> {
+fn for_spec(p: &mut Parser<'_>) -> Result<ForSpecData> {
 	p.eat(T![for])?;
 	let d = destruct(p)?;
 	p.eat(T![in])?;
@@ -597,7 +594,7 @@
 	Ok(ForSpecData { destruct: d, over })
 }
 
-fn compspecs(p: &mut Parser<'_>) -> R<Vec<CompSpec>> {
+fn compspecs(p: &mut Parser<'_>) -> Result<Vec<CompSpec>> {
 	let mut specs = Vec::new();
 	specs.push(CompSpec::ForSpec(for_spec(p)?));
 	loop {
@@ -613,7 +610,7 @@
 	Ok(specs)
 }
 
-fn objinside(p: &mut Parser<'_>) -> R<ObjBody> {
+fn objinside(p: &mut Parser<'_>) -> Result<ObjBody> {
 	if p.at(T!['}']) {
 		return Ok(ObjBody::MemberList(ObjMembers {
 			locals: Rc::new(Vec::new()),
@@ -641,26 +638,22 @@
 			match m {
 				Member::Field(f) => {
 					if field_member.is_some() {
-						return Err(p.error(
-							"object comprehension can only contain one field".into(),
-						));
+						return Err(
+							p.error("object comprehension can only contain one field".into())
+						);
 					}
 					field_member = Some(f);
 				}
 				Member::BindStmt(b) => locals.push(b),
 				Member::AssertStmt(_) => {
-					return Err(p.error(
-						"asserts are unsupported in object comprehension".into(),
-					));
+					return Err(p.error("asserts are unsupported in object comprehension".into()));
 				}
 			}
 		}
 		Ok(ObjBody::ObjComp(ObjComp {
 			locals: Rc::new(locals),
 			field: Rc::new(
-				field_member.ok_or_else(|| {
-					p.error("missing object comprehension field".into())
-				})?,
+				field_member.ok_or_else(|| p.error("missing object comprehension field".into()))?,
 			),
 			compspecs: specs,
 		}))
@@ -683,7 +676,7 @@
 	}
 }
 
-fn expr_basic(p: &mut Parser<'_>) -> R<Expr> {
+fn expr_basic(p: &mut Parser<'_>) -> Result<Expr> {
 	if let Some(lit) = literal(p) {
 		return Ok(Expr::Literal(lit));
 	}
@@ -825,7 +818,6 @@
 	}
 }
 
-/// Flush accumulated index parts into an Expr::Index wrapping `e`.
 fn flush_index_parts(e: &mut Expr, parts: &mut Vec<IndexPart>) {
 	if parts.is_empty() {
 		return;
@@ -837,7 +829,7 @@
 	};
 }
 
-fn expr_suffix(p: &mut Parser<'_>) -> R<Expr> {
+fn expr_suffix(p: &mut Parser<'_>) -> Result<Expr> {
 	let mut e = expr_basic(p)?;
 	// Accumulate consecutive index parts (.field, [expr], ?.field, ?.[expr])
 	// into a single Expr::Index. This is critical for null-coalesce semantics:
@@ -1006,7 +998,7 @@
 	}
 }
 
-fn expr_bp(p: &mut Parser<'_>, min_bp: u8) -> R<Expr> {
+fn expr_bp(p: &mut Parser<'_>, min_bp: u8) -> Result<Expr> {
 	let mut lhs = if let Some(op) = unary_op(p.peek()) {
 		p.eat_any();
 		let rbp = prefix_binding_power(op);
@@ -1038,11 +1030,11 @@
 	Ok(lhs)
 }
 
-fn expr(p: &mut Parser<'_>) -> R<Expr> {
+fn expr(p: &mut Parser<'_>) -> Result<Expr> {
 	expr_bp(p, 0)
 }
 
-pub fn parse(str: &str, settings: &ParserSettings) -> Result<Expr, ParseError> {
+pub fn parse(str: &str, settings: &ParserSettings) -> Result<Expr> {
 	let mut p = Parser::new(str, settings.source.clone());
 	for lexeme in &p.lexemes {
 		if let Some(desc) = lexeme.kind.error_description() {
@@ -1056,20 +1048,14 @@
 	}
 	let e = expr(&mut p)?;
 	if !p.at_eof() {
-		return Err(p.error(format!(
-			"expected end of file, got {}",
-			p.current_desc(),
-		)));
+		return Err(p.error(format!("expected end of file, got {}", p.current_desc(),)));
 	}
 	Ok(e)
 }
 
 pub fn string_to_expr(s: IStr, settings: &ParserSettings) -> Spanned<Expr> {
 	let len = s.len();
-	Spanned::new(
-		Expr::Str(s),
-		Span(settings.source.clone(), 0, len as u32),
-	)
+	Spanned::new(Expr::Str(s), Span(settings.source.clone(), 0, len as u32))
 }
 
 #[cfg(test)]
modifiedcrates/jrsonnet-ir/src/visit.rsdiffbeforeafterboth
before · crates/jrsonnet-ir/src/visit.rs
1use jrsonnet_interner::IStr;23use crate::{4	ArgsDesc, AssertExpr, AssertStmt, BinaryOp, BindSpec, CompSpec, Destruct, Expr, ExprParam,5	ExprParams, FieldMember, FieldName, ForSpecData, IfElse, IfSpecData, ImportKind, IndexPart,6	ObjBody, ObjComp, ObjMembers, Slice, SliceDesc,7};89pub trait Visitor: Sized {10	fn visit_expr(&mut self, e: &Expr) {11		visit_expr(self, e)12	}13	fn visit_import(&mut self, _as_expression: bool, _value: IStr) {}14}1516#[cfg(feature = "exp-destruct")]17pub fn visit_destruct_rest<V: Visitor>(_v: &mut V, destruct: &crate::DestructRest) {18	match destruct {19		crate::DestructRest::Keep(_name) => {}20		crate::DestructRest::Drop => {}21	}22}2324pub fn visit_destruct<V: Visitor>(v: &mut V, destruct: &Destruct) {25	match destruct {26		Destruct::Full(_istr) => {}27		#[cfg(feature = "exp-destruct")]28		Destruct::Skip => {}29		#[cfg(feature = "exp-destruct")]30		Destruct::Array { start, rest, end } => {31			for s in start {32				visit_destruct(v, s);33			}34			if let Some(rest) = rest {35				visit_destruct_rest(v, rest);36			}37			for s in end {38				visit_destruct(v, s);39			}40		}41		#[cfg(feature = "exp-destruct")]42		Destruct::Object { fields, rest } => {43			for (_name, into, default) in fields {44				if let Some(into) = into {45					visit_destruct(v, into);46				}47				if let Some(default) = default {48					v.visit_expr(default);49				}50				if let Some(rest) = rest {51					visit_destruct_rest(v, rest);52				}53			}54		}55	}56}5758pub fn visit_if_spec<V: Visitor>(v: &mut V, cond: &IfSpecData) {59	let IfSpecData { span: _, cond } = cond;60	v.visit_expr(cond);61}6263pub fn visit_comp_spec<V: Visitor>(v: &mut V, c: &CompSpec) {64	match c {65		CompSpec::IfSpec(cond) => visit_if_spec(v, cond),66		CompSpec::ForSpec(for_spec_data) => {67			let ForSpecData { destruct, over } = for_spec_data;68			visit_destruct(v, destruct);69			v.visit_expr(over);70		}71	}72}73pub fn visit_params<V: Visitor>(v: &mut V, par: &ExprParams) {74	let ExprParams {75		exprs,76		signature: _,77		binds_len: _,78	} = par;79	for par in &**exprs {80		let ExprParam { destruct, default } = &par;81		visit_destruct(v, destruct);82		if let Some(default) = default {83			v.visit_expr(default);84		}85	}86}8788pub fn visit_bind_spec<V: Visitor>(v: &mut V, bind: &BindSpec) {89	match bind {90		BindSpec::Field { into, value } => {91			visit_destruct(v, into);92			v.visit_expr(value);93		}94		BindSpec::Function {95			name: _,96			params,97			value,98		} => {99			visit_params(v, params);100			v.visit_expr(value);101		}102	}103}104105pub fn visit_field_member<V: Visitor>(v: &mut V, mem: &FieldMember) {106	let FieldMember {107		name,108		plus: _,109		params,110		visibility: _,111		value,112	} = mem;113	match &**name {114		FieldName::Fixed(_istr) => {}115		FieldName::Dyn(expr) => v.visit_expr(expr),116	}117	if let Some(params) = params {118		visit_params(v, params);119	}120	v.visit_expr(value);121}122123pub fn visit_obj_body<V: Visitor>(v: &mut V, obj_body: &ObjBody) {124	match obj_body {125		ObjBody::MemberList(obj_members) => {126			let ObjMembers {127				locals,128				asserts,129				fields,130			} = obj_members;131			for local in &**locals {132				visit_bind_spec(v, local);133			}134			for assert in &**asserts {135				visit_assert_stmt(v, assert);136			}137			for field in fields {138				visit_field_member(v, field);139			}140		}141		ObjBody::ObjComp(obj_comp) => {142			let ObjComp {143				locals,144				field,145				compspecs,146			} = obj_comp;147			for local in &**locals {148				visit_bind_spec(v, local);149			}150			visit_field_member(v, field);151			for compspec in compspecs {152				visit_comp_spec(v, compspec);153			}154		}155	}156}157158pub fn visit_assert_stmt<V: Visitor>(v: &mut V, ass: &AssertStmt) {159	let AssertStmt(cond, msg) = ass;160	v.visit_expr(cond);161	if let Some(msg) = msg {162		v.visit_expr(msg);163	}164}165pub fn visit_expr<V: Visitor>(v: &mut V, e: &Expr) {166	match e {167		Expr::Literal(_literal_type) => {}168		Expr::Str(_istr) => {}169		Expr::Num(_num) => {}170		Expr::Var(_spanned) => {}171		Expr::Arr(exprs) => {172			for e in &**exprs {173				v.visit_expr(e);174			}175		}176		Expr::ArrComp(expr, comp_specs) => {177			v.visit_expr(expr);178			for ele in comp_specs {179				visit_comp_spec(v, ele);180			}181		}182		Expr::Obj(obj_body) => visit_obj_body(v, obj_body),183		Expr::ObjExtend(expr, obj_body) => {184			v.visit_expr(expr);185			visit_obj_body(v, obj_body);186		}187		Expr::UnaryOp(_unary_op_type, expr) => {188			v.visit_expr(expr);189		}190		Expr::BinaryOp(binary_op) => {191			let BinaryOp { lhs, op: _, rhs } = &**binary_op;192			v.visit_expr(lhs);193			v.visit_expr(rhs);194		}195		Expr::AssertExpr(assert_expr) => {196			let AssertExpr { assert, rest } = &**assert_expr;197			visit_assert_stmt(v, assert);198			v.visit_expr(rest);199		}200		Expr::LocalExpr(bind_specs, expr) => {201			for local in bind_specs {202				visit_bind_spec(v, local);203			}204			v.visit_expr(expr);205		}206		Expr::Import(kind, expr) => {207			v.visit_expr(expr);208209			if let Expr::Str(expr) = &**expr {210				v.visit_import(matches!(**kind, ImportKind::Normal), expr.clone());211			}212		}213		Expr::ErrorStmt(_span, expr) => {214			v.visit_expr(expr);215		}216		Expr::Apply(expr, spanned, _) => {217			v.visit_expr(expr);218			let ArgsDesc { unnamed, named } = &**spanned;219			for unnamed in unnamed {220				v.visit_expr(unnamed);221			}222			for (_name, named) in named {223				v.visit_expr(named);224			}225		}226		Expr::Index { indexable, parts } => {227			v.visit_expr(indexable);228229			for part in parts {230				let IndexPart {231					span: _,232					value,233					#[cfg(feature = "exp-null-coaelse")]234						null_coaelse: _,235				} = part;236				v.visit_expr(value);237			}238		}239		Expr::Function(expr_params, expr) => {240			visit_params(v, expr_params);241			v.visit_expr(expr);242		}243		Expr::IfElse(if_else) => {244			let IfElse {245				cond,246				cond_then,247				cond_else,248			} = &**if_else;249			visit_if_spec(v, cond);250			v.visit_expr(cond_then);251			if let Some(cond_else) = cond_else {252				v.visit_expr(cond_else);253			}254		}255		Expr::Slice(slice) => {256			let Slice { value, slice } = &**slice;257			v.visit_expr(value);258			let SliceDesc { start, end, step } = slice;259260			if let Some(start) = start {261				v.visit_expr(start);262			}263			if let Some(end) = end {264				v.visit_expr(end);265			}266			if let Some(step) = step {267				v.visit_expr(step);268			}269		}270	}271}
after · crates/jrsonnet-ir/src/visit.rs
1use jrsonnet_interner::IStr;23use crate::{4	ArgsDesc, AssertExpr, AssertStmt, BinaryOp, BindSpec, CompSpec, Destruct, Expr, ExprParam,5	ExprParams, FieldMember, FieldName, ForSpecData, IfElse, IfSpecData, ImportKind, IndexPart,6	ObjBody, ObjComp, ObjMembers, Slice, SliceDesc,7};89pub trait Visitor: Sized {10	fn visit_expr(&mut self, e: &Expr) {11		visit_expr(self, e)12	}13	fn visit_import(&mut self, _as_expression: bool, _value: IStr) {}14}1516#[cfg(feature = "exp-destruct")]17pub fn visit_destruct_rest<V: Visitor>(_v: &mut V, destruct: &crate::DestructRest) {18	match destruct {19		crate::DestructRest::Keep(_name) => {}20		crate::DestructRest::Drop => {}21	}22}2324#[allow(unused_variables, reason = "used with exp-destruct")]25pub fn visit_destruct<V: Visitor>(v: &mut V, destruct: &Destruct) {26	match destruct {27		Destruct::Full(_istr) => {}28		#[cfg(feature = "exp-destruct")]29		Destruct::Skip => {}30		#[cfg(feature = "exp-destruct")]31		Destruct::Array { start, rest, end } => {32			for s in start {33				visit_destruct(v, s);34			}35			if let Some(rest) = rest {36				visit_destruct_rest(v, rest);37			}38			for s in end {39				visit_destruct(v, s);40			}41		}42		#[cfg(feature = "exp-destruct")]43		Destruct::Object { fields, rest } => {44			for (_name, into, default) in fields {45				if let Some(into) = into {46					visit_destruct(v, into);47				}48				if let Some(default) = default {49					v.visit_expr(default);50				}51				if let Some(rest) = rest {52					visit_destruct_rest(v, rest);53				}54			}55		}56	}57}5859pub fn visit_if_spec<V: Visitor>(v: &mut V, cond: &IfSpecData) {60	let IfSpecData { span: _, cond } = cond;61	v.visit_expr(cond);62}6364pub fn visit_comp_spec<V: Visitor>(v: &mut V, c: &CompSpec) {65	match c {66		CompSpec::IfSpec(cond) => visit_if_spec(v, cond),67		CompSpec::ForSpec(for_spec_data) => {68			let ForSpecData { destruct, over } = for_spec_data;69			visit_destruct(v, destruct);70			v.visit_expr(over);71		}72	}73}74pub fn visit_params<V: Visitor>(v: &mut V, par: &ExprParams) {75	let ExprParams {76		exprs,77		signature: _,78		binds_len: _,79	} = par;80	for par in &**exprs {81		let ExprParam { destruct, default } = &par;82		visit_destruct(v, destruct);83		if let Some(default) = default {84			v.visit_expr(default);85		}86	}87}8889pub fn visit_bind_spec<V: Visitor>(v: &mut V, bind: &BindSpec) {90	match bind {91		BindSpec::Field { into, value } => {92			visit_destruct(v, into);93			v.visit_expr(value);94		}95		BindSpec::Function {96			name: _,97			params,98			value,99		} => {100			visit_params(v, params);101			v.visit_expr(value);102		}103	}104}105106pub fn visit_field_member<V: Visitor>(v: &mut V, mem: &FieldMember) {107	let FieldMember {108		name,109		plus: _,110		params,111		visibility: _,112		value,113	} = mem;114	match &**name {115		FieldName::Fixed(_istr) => {}116		FieldName::Dyn(expr) => v.visit_expr(expr),117	}118	if let Some(params) = params {119		visit_params(v, params);120	}121	v.visit_expr(value);122}123124pub fn visit_obj_body<V: Visitor>(v: &mut V, obj_body: &ObjBody) {125	match obj_body {126		ObjBody::MemberList(obj_members) => {127			let ObjMembers {128				locals,129				asserts,130				fields,131			} = obj_members;132			for local in &**locals {133				visit_bind_spec(v, local);134			}135			for assert in &**asserts {136				visit_assert_stmt(v, assert);137			}138			for field in fields {139				visit_field_member(v, field);140			}141		}142		ObjBody::ObjComp(obj_comp) => {143			let ObjComp {144				locals,145				field,146				compspecs,147			} = obj_comp;148			for local in &**locals {149				visit_bind_spec(v, local);150			}151			visit_field_member(v, field);152			for compspec in compspecs {153				visit_comp_spec(v, compspec);154			}155		}156	}157}158159pub fn visit_assert_stmt<V: Visitor>(v: &mut V, ass: &AssertStmt) {160	let AssertStmt(cond, msg) = ass;161	v.visit_expr(cond);162	if let Some(msg) = msg {163		v.visit_expr(msg);164	}165}166pub fn visit_expr<V: Visitor>(v: &mut V, e: &Expr) {167	match e {168		Expr::Literal(_literal_type) => {}169		Expr::Str(_istr) => {}170		Expr::Num(_num) => {}171		Expr::Var(_spanned) => {}172		Expr::Arr(exprs) => {173			for e in &**exprs {174				v.visit_expr(e);175			}176		}177		Expr::ArrComp(expr, comp_specs) => {178			v.visit_expr(expr);179			for ele in comp_specs {180				visit_comp_spec(v, ele);181			}182		}183		Expr::Obj(obj_body) => visit_obj_body(v, obj_body),184		Expr::ObjExtend(expr, obj_body) => {185			v.visit_expr(expr);186			visit_obj_body(v, obj_body);187		}188		Expr::UnaryOp(_unary_op_type, expr) => {189			v.visit_expr(expr);190		}191		Expr::BinaryOp(binary_op) => {192			let BinaryOp { lhs, op: _, rhs } = &**binary_op;193			v.visit_expr(lhs);194			v.visit_expr(rhs);195		}196		Expr::AssertExpr(assert_expr) => {197			let AssertExpr { assert, rest } = &**assert_expr;198			visit_assert_stmt(v, assert);199			v.visit_expr(rest);200		}201		Expr::LocalExpr(bind_specs, expr) => {202			for local in bind_specs {203				visit_bind_spec(v, local);204			}205			v.visit_expr(expr);206		}207		Expr::Import(kind, expr) => {208			v.visit_expr(expr);209210			if let Expr::Str(expr) = &**expr {211				v.visit_import(matches!(**kind, ImportKind::Normal), expr.clone());212			}213		}214		Expr::ErrorStmt(_span, expr) => {215			v.visit_expr(expr);216		}217		Expr::Apply(expr, spanned, _) => {218			v.visit_expr(expr);219			let ArgsDesc { unnamed, named } = &**spanned;220			for unnamed in unnamed {221				v.visit_expr(unnamed);222			}223			for (_name, named) in named {224				v.visit_expr(named);225			}226		}227		Expr::Index { indexable, parts } => {228			v.visit_expr(indexable);229230			for part in parts {231				let IndexPart {232					span: _,233					value,234					#[cfg(feature = "exp-null-coaelse")]235						null_coaelse: _,236				} = part;237				v.visit_expr(value);238			}239		}240		Expr::Function(expr_params, expr) => {241			visit_params(v, expr_params);242			v.visit_expr(expr);243		}244		Expr::IfElse(if_else) => {245			let IfElse {246				cond,247				cond_then,248				cond_else,249			} = &**if_else;250			visit_if_spec(v, cond);251			v.visit_expr(cond_then);252			if let Some(cond_else) = cond_else {253				v.visit_expr(cond_else);254			}255		}256		Expr::Slice(slice) => {257			let Slice { value, slice } = &**slice;258			v.visit_expr(value);259			let SliceDesc { start, end, step } = slice;260261			if let Some(start) = start {262				v.visit_expr(start);263			}264			if let Some(end) = end {265				v.visit_expr(end);266			}267			if let Some(step) = step {268				v.visit_expr(step);269			}270		}271	}272}
modifiedcrates/jrsonnet-rowan-parser/src/lex.rsdiffbeforeafterboth
--- a/crates/jrsonnet-rowan-parser/src/lex.rs
+++ b/crates/jrsonnet-rowan-parser/src/lex.rs
@@ -11,9 +11,11 @@
 }
 
 pub fn lex(input: &str) -> Vec<Lexeme<'_>> {
-	Lexer::new(input).map(|l| Lexeme {
-		kind: SyntaxKind::from_raw(l.kind.into_raw()),
-		text: l.text,
-		range: TextRange::new(TextSize::from(l.range.0), TextSize::from(l.range.1)),
-	}).collect()
+	Lexer::new(input)
+		.map(|l| Lexeme {
+			kind: SyntaxKind::from_raw(l.kind.into_raw()),
+			text: l.text,
+			range: TextRange::new(TextSize::from(l.range.0), TextSize::from(l.range.1)),
+		})
+		.collect()
 }
modifiedcrates/jrsonnet-stdlib/src/manifest/ini.rsdiffbeforeafterboth
--- a/crates/jrsonnet-stdlib/src/manifest/ini.rs
+++ b/crates/jrsonnet-stdlib/src/manifest/ini.rs
@@ -3,8 +3,7 @@
 use jrsonnet_evaluator::{
 	manifest::{ManifestFormat, ToStringFormat},
 	typed::{FromUntyped, Typed},
-	ObjValue, Result, ResultExt, Val,
-	IStr,
+	IStr, ObjValue, Result, ResultExt, Val,
 };
 
 pub struct IniFormat {
modifiedxtask/src/sourcegen/kinds.rsdiffbeforeafterboth
--- a/xtask/src/sourcegen/kinds.rs
+++ b/xtask/src/sourcegen/kinds.rs
@@ -120,11 +120,15 @@
 			Self::Literal { name, .. } => match name.as_str() {
 				"FLOAT" => "number".to_owned(),
 				"IDENT" => "identifier".to_owned(),
-				"STRING_DOUBLE" | "STRING_SINGLE" | "STRING_DOUBLE_VERBATIM"
-				| "STRING_SINGLE_VERBATIM" | "STRING_BLOCK" => "string".to_owned(),
+				"STRING_DOUBLE"
+				| "STRING_SINGLE"
+				| "STRING_DOUBLE_VERBATIM"
+				| "STRING_SINGLE_VERBATIM"
+				| "STRING_BLOCK" => "string".to_owned(),
 				"WHITESPACE" => "whitespace".to_owned(),
-				"SINGLE_LINE_SLASH_COMMENT" | "SINGLE_LINE_HASH_COMMENT"
-				| "MULTI_LINE_COMMENT" => "comment".to_owned(),
+				"SINGLE_LINE_SLASH_COMMENT" | "SINGLE_LINE_HASH_COMMENT" | "MULTI_LINE_COMMENT" => {
+					"comment".to_owned()
+				}
 				_ => name.to_lowercase(),
 			},
 			Self::Meta { name, .. } => name.to_lowercase(),