difftreelog
perf faster sort
in: master
3 files changed
crates/jrsonnet-evaluator/build.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/build.rs
+++ b/crates/jrsonnet-evaluator/build.rs
@@ -38,7 +38,8 @@
})
if **name == *"join" || **name == *"manifestJsonEx" ||
**name == *"escapeStringJson" || **name == *"equals" ||
- **name == *"base64" || **name == *"foldl" || **name == *"foldr"
+ **name == *"base64" || **name == *"foldl" || **name == *"foldr" ||
+ **name == *"sortImpl"
)
})
.collect(),
crates/jrsonnet-evaluator/src/evaluate.rsdiffbeforeafterboth--- a/crates/jrsonnet-evaluator/src/evaluate.rs
+++ b/crates/jrsonnet-evaluator/src/evaluate.rs
@@ -10,7 +10,7 @@
ForSpecData, IfSpecData, LiteralType, LocExpr, Member, ObjBody, ParamsDesc, UnaryOpType,
Visibility,
};
-use std::{collections::HashMap, rc::Rc};
+use std::{cmp::Ordering, collections::HashMap, rc::Rc};
pub fn evaluate_binding(b: &BindSpec, context_creator: ContextCreator) -> (Rc<str>, LazyBinding) {
let b = b.clone();
@@ -581,6 +581,58 @@
}
Ok(acc)
}))?,
+ // faster
+ ("std", "sortImpl") => noinline!(parse_args!(context, "std.sort", args, 2, [
+ 0, arr: [Val::Arr]!!Val::Arr, vec![ValType::Arr];
+ 1, keyF: [Val::Func]!!Val::Func, vec![ValType::Func];
+ ], {
+ if arr.len() <= 1 {
+ return Ok(Val::Arr(arr))
+ }
+ let mut new_arr = arr.iter().cloned().collect::<Vec<_>>();
+ match keyF.evaluate_values(context.clone(), &[new_arr[0].clone()])? {
+ Val::Str(_) => {
+ let mut err = None;
+ new_arr.sort_by_cached_key(|k| {
+ match keyF.evaluate_values(context.clone(), &[k.clone()]) {
+ Ok(Val::Str(v)) => v,
+ Ok(_) => {
+ err = Some(create_error(crate::error::Error::RuntimeError("types of all array elements should equal".into())));
+ "".into()
+ }
+ Err(e) => {
+ err = Some(e);
+ "".into()
+ }
+ }
+ });
+ if let Some(e) = err {
+ return Err(e);
+ }
+ },
+ Val::Num(_) => {
+ let mut err = None;
+ new_arr.sort_unstable_by(|a, b| {
+ match (keyF.evaluate_values(context.clone(), &[a.clone()]), keyF.evaluate_values(context.clone(), &[b.clone()])) {
+ (Ok(Val::Num(a)), Ok(Val::Num(b))) => a.partial_cmp(&b).unwrap(),
+ (Ok(_a), Ok(_b)) => {
+ err = Some(create_error(crate::error::Error::RuntimeError("types of all array elements should equal".into())));
+ Ordering::Equal
+ }
+ (Err(e), _) | (_, Err(e)) => {
+ err = Some(e);
+ Ordering::Equal
+ }
+ }
+ });
+ if let Some(e) = err {
+ return Err(e);
+ }
+ },
+ _ => return Err(create_error(crate::error::Error::RuntimeError("keys should be number or string".into())))
+ }
+ Ok(Val::Arr(Rc::new(new_arr)))
+ }))?,
("std", "char") => parse_args!(context, "std.char", args, 1, [
0, n: [Val::Num]!!Val::Num, vec![ValType::Num];
], {
crates/jrsonnet-stdlib/src/std.jsonnetdiffbeforeafterboth1131 std.makeArray(l, function(i) arr[l - i - 1]),1131 std.makeArray(l, function(i) arr[l - i - 1]),113211321133 // Merge-sort for long arrays and naive quicksort for shorter ones1133 // Merge-sort for long arrays and naive quicksort for shorter ones1134 sort(arr, keyF=id)::1134 sortImpl(arr, keyF)::1135 local quickSort(arr, keyF=id) =1135 local quickSort(arr, keyF=id) =1136 local l = std.length(arr);1136 local l = std.length(arr);1137 if std.length(arr) <= 1 then1137 if std.length(arr) <= 1 then1165 local mid = std.floor(l / 2);1165 local mid = std.floor(l / 2);1166 local left = arr[:mid], right = arr[mid:];1166 local left = arr[:mid], right = arr[mid:];1167 merge(std.sort(left, keyF=keyF), std.sort(right, keyF=keyF)),1167 merge(std.sort(left, keyF=keyF), std.sort(right, keyF=keyF)),11681169 sort(arr, keyF=id)::1170 std.sortImpl(arr, keyF),116811711169 uniq(arr, keyF=id)::1172 uniq(arr, keyF=id)::1170 local f(a, b) =1173 local f(a, b) =