--- a/tests/src/benchmarks/mintFee/index.ts +++ b/tests/src/benchmarks/mintFee/index.ts @@ -222,9 +222,7 @@ await collection.mintToken( donor, {Substrate: susbstrateReceiver.address}, - PROPERTIES.slice(0, setup.propertiesNumber).map((p) => { - return {key: p.key, value: Buffer.from(p.value).toString()}; - }), + PROPERTIES.slice(0, setup.propertiesNumber).map((p) => ({key: p.key, value: Buffer.from(p.value).toString()})), ); }, ); --- a/tests/src/benchmarks/opsFee/index.ts +++ b/tests/src/benchmarks/opsFee/index.ts @@ -379,7 +379,7 @@ res['setCollectionProperties'].substrate = convertToTokens((await helper.arrange.calculcateFee( {Substrate: donor.address}, () => collection.setProperties(donor, PROPERTIES.slice(0, 1) - .map(p => { return {key: p.key, value: p.value.toString()}; })), + .map(p => ({key: p.key, value: p.value.toString()}))), ))); res['deleteCollectionProperties'].substrate = convertToTokens((await helper.arrange.calculcateFee( @@ -755,7 +755,7 @@ res['setCollectionProperties'].substrate = convertToTokens((await helper.arrange.calculcateFee( {Substrate: donor.address}, () => collection.setProperties(donor, PROPERTIES.slice(0, 1) - .map(p => { return {key: p.key, value: p.value.toString()}; })), + .map(p => ({key: p.key, value: p.value.toString()}))), ))); res['deleteCollectionProperties'].substrate = convertToTokens((await helper.arrange.calculcateFee( --- a/tests/src/benchmarks/utils/common.ts +++ b/tests/src/benchmarks/utils/common.ts @@ -5,32 +5,26 @@ export const PROPERTIES = Array(40) .fill(0) - .map((_, i) => { - return { - key: `key_${i}`, - value: Uint8Array.from(Buffer.from(`value_${i}`)), - }; - }); + .map((_, i) => ({ + key: `key_${i}`, + value: Uint8Array.from(Buffer.from(`value_${i}`)), + })); export const SUBS_PROPERTIES = Array(40) .fill(0) - .map((_, i) => { - return { - key: `key_${i}`, - value: `value_${i}`, - }; - }); + .map((_, i) => ({ + key: `key_${i}`, + value: `value_${i}`, + })); -export const PERMISSIONS: ITokenPropertyPermission[] = PROPERTIES.map((p) => { - return { - key: p.key, - permission: { - tokenOwner: true, - collectionAdmin: true, - mutable: true, - }, - }; -}); +export const PERMISSIONS: ITokenPropertyPermission[] = PROPERTIES.map((p) => ({ + key: p.key, + permission: { + tokenOwner: true, + collectionAdmin: true, + mutable: true, + }, +})); export function convertToTokens(value: bigint, nominal = 1000_000_000_000_000_000n): number { return Number((value * 1000n) / nominal) / 1000; --- a/tests/src/eth/collectionAdmin.test.ts +++ b/tests/src/eth/collectionAdmin.test.ts @@ -76,9 +76,7 @@ // 2. Expect methods.collectionAdmins == api.rpc.unique.adminlist let adminListEth = await collectionEvm.methods.collectionAdmins().call(); - adminListEth = adminListEth.map((element: IEthCrossAccountId) => { - return helper.address.convertCrossAccountFromEthCrossAccount(element); - }); + adminListEth = adminListEth.map((element: IEthCrossAccountId) => helper.address.convertCrossAccountFromEthCrossAccount(element)); expect(adminListRpc).to.be.like(adminListEth); // 3. check isOwnerOrAdminCross returns true: --- a/tests/src/eth/collectionProperties.test.ts +++ b/tests/src/eth/collectionProperties.test.ts @@ -181,17 +181,11 @@ const propertyPermissions = data2?.raw.tokenPropertyPermissions; expect(propertyPermissions?.length).to.equal(2); - expect(propertyPermissions.find((tpp: ITokenPropertyPermission) => { - return tpp.key === 'URI' && tpp.permission.mutable && tpp.permission.collectionAdmin && !tpp.permission.tokenOwner; - })).to.be.not.null; + expect(propertyPermissions.find((tpp: ITokenPropertyPermission) => tpp.key === 'URI' && tpp.permission.mutable && tpp.permission.collectionAdmin && !tpp.permission.tokenOwner)).to.be.not.null; - expect(propertyPermissions.find((tpp: ITokenPropertyPermission) => { - return tpp.key === 'URISuffix' && tpp.permission.mutable && tpp.permission.collectionAdmin && !tpp.permission.tokenOwner; - })).to.be.not.null; + expect(propertyPermissions.find((tpp: ITokenPropertyPermission) => tpp.key === 'URISuffix' && tpp.permission.mutable && tpp.permission.collectionAdmin && !tpp.permission.tokenOwner)).to.be.not.null; - expect(data2?.raw.properties?.find((property: IProperty) => { - return property.key === 'baseURI' && property.value === BASE_URI; - })).to.be.not.null; + expect(data2?.raw.properties?.find((property: IProperty) => property.key === 'baseURI' && property.value === BASE_URI)).to.be.not.null; const token1Result = await contract.methods.mint(bruh).send(); const tokenId1 = token1Result.events.Transfer.returnValues.tokenId; --- a/tests/src/eth/evmCoder.test.ts +++ b/tests/src/eth/evmCoder.test.ts @@ -17,8 +17,7 @@ import {IKeyringPair} from '@polkadot/types/types'; import {itEth, expect, usingEthPlaygrounds} from './util'; -const getContractSource = (collectionAddress: string, contractAddress: string): string => { - return ` +const getContractSource = (collectionAddress: string, contractAddress: string): string => ` // SPDX-License-Identifier: MIT pragma solidity ^0.8.0; interface ITest { @@ -51,7 +50,6 @@ } } `; -}; describe('Evm Coder tests', () => { --- a/tests/src/eth/nonFungible.test.ts +++ b/tests/src/eth/nonFungible.test.ts @@ -102,17 +102,15 @@ const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(receiverSub); // const receiverCross = helper.ethCrossAccount.fromKeyringPair(bob); - const properties = Array(5).fill(0).map((_, i) => { return {key: `key_${i}`, value: Buffer.from(`value_${i}`)}; }); + const properties = Array(5).fill(0).map((_, i) => ({key: `key_${i}`, value: Buffer.from(`value_${i}`)})); const permissions: ITokenPropertyPermission[] = properties - .map(p => { - return { - key: p.key, permission: { - tokenOwner: false, - collectionAdmin: true, - mutable: false, - }, - }; - }); + .map(p => ({ + key: p.key, permission: { + tokenOwner: false, + collectionAdmin: true, + mutable: false, + }, + })); const collection = await helper.nft.mintCollection(minter, { tokenPrefix: 'ethp', @@ -146,7 +144,7 @@ expect(tokenId).to.be.equal(expectedTokenId); expect(await contract.methods.properties(tokenId, []).call()).to.be.like(properties - .map(p => { return helper.ethProperty.property(p.key, p.value.toString()); })); + .map(p => helper.ethProperty.property(p.key, p.value.toString()))); expect(await helper.nft.getTokenOwner(collection.collectionId, tokenId)) .to.deep.eq(testCase === 'ethereum' ? {Ethereum: receiverEth.toLowerCase()} : {Substrate: receiverSub.address}); --- a/tests/src/eth/reFungible.test.ts +++ b/tests/src/eth/reFungible.test.ts @@ -46,12 +46,11 @@ const receiverSub = bob; const receiverCrossSub = helper.ethCrossAccount.fromKeyringPair(receiverSub); - const properties = Array(5).fill(0).map((_, i) => { return {key: `key_${i}`, value: Buffer.from(`value_${i}`)}; }); - const permissions: ITokenPropertyPermission[] = properties.map(p => { return {key: p.key, permission: { + const properties = Array(5).fill(0).map((_, i) => ({key: `key_${i}`, value: Buffer.from(`value_${i}`)})); + const permissions: ITokenPropertyPermission[] = properties.map(p => ({key: p.key, permission: { tokenOwner: false, collectionAdmin: true, - mutable: false}}; - }); + mutable: false}})); const collection = await helper.rft.mintCollection(minter, { @@ -86,7 +85,7 @@ expect(tokenId).to.be.equal(expectedTokenId); expect(await contract.methods.properties(tokenId, []).call()).to.be.like(properties - .map(p => { return helper.ethProperty.property(p.key, p.value.toString()); })); + .map(p => helper.ethProperty.property(p.key, p.value.toString()))); expect(await helper.nft.getTokenOwner(collection.collectionId, tokenId)) .to.deep.eq(testCase === 'ethereum' ? {Ethereum: receiverEth.toLowerCase()} : {Substrate: receiverSub.address}); --- a/tests/src/eth/tokenProperties.test.ts +++ b/tests/src/eth/tokenProperties.test.ts @@ -241,10 +241,10 @@ itEth.ifWithPallets(`Can be multiple set/read for ${testCase.mode}`, testCase.requiredPallets, async({helper}) => { const caller = await helper.eth.createAccountWithBalance(donor); - const properties = Array(5).fill(0).map((_, i) => { return {key: `key_${i}`, value: Buffer.from(`value_${i}`)}; }); - const permissions: ITokenPropertyPermission[] = properties.map(p => { return {key: p.key, permission: {tokenOwner: true, + const properties = Array(5).fill(0).map((_, i) => ({key: `key_${i}`, value: Buffer.from(`value_${i}`)})); + const permissions: ITokenPropertyPermission[] = properties.map(p => ({key: p.key, permission: {tokenOwner: true, collectionAdmin: true, - mutable: true}}; }); + mutable: true}})); const collection = await helper[testCase.mode].mintCollection(alice, { tokenPrefix: 'ethp', @@ -267,10 +267,10 @@ await contract.methods.setProperties(token.tokenId, properties).send({from: caller}); const values = await token.getProperties(properties.map(p => p.key)); - expect(values).to.be.deep.equal(properties.map(p => { return {key: p.key, value: p.value.toString()}; })); + expect(values).to.be.deep.equal(properties.map(p => ({key: p.key, value: p.value.toString()}))); expect(await contract.methods.properties(token.tokenId, []).call()).to.be.like(properties - .map(p => { return helper.ethProperty.property(p.key, p.value.toString()); })); + .map(p => helper.ethProperty.property(p.key, p.value.toString()))); expect(await contract.methods.properties(token.tokenId, [properties[0].key]).call()) .to.be.like([helper.ethProperty.property(properties[0].key, properties[0].value.toString())]); --- a/tests/src/fungible.test.ts +++ b/tests/src/fungible.test.ts @@ -46,7 +46,7 @@ itSub('RPC method tokenOnewrs for fungible collection and token', async ({helper}) => { const ethAcc = {Ethereum: '0x67fb3503a61b284dc83fa96dceec4192db47dc7c'}; - const facelessCrowd = (await helper.arrange.createAccounts(Array(7).fill(0n), donor)).map(keyring => {return {Substrate: keyring.address};}); + const facelessCrowd = (await helper.arrange.createAccounts(Array(7).fill(0n), donor)).map(keyring => ({Substrate: keyring.address})); const collection = await helper.ft.mintCollection(alice, {name: 'test', description: 'test', tokenPrefix: 'test'}); --- a/tests/src/getPropertiesRpc.test.ts +++ b/tests/src/getPropertiesRpc.test.ts @@ -48,17 +48,13 @@ describe('query properties RPC', () => { let alice: IKeyringPair; - const mintCollection = async (helper: UniqueHelper) => { - return await helper.nft.mintCollection(alice, { - tokenPrefix: 'prps', - properties: collectionProps, - tokenPropertyPermissions: tokenPropPermissions, - }); - }; + const mintCollection = async (helper: UniqueHelper) => await helper.nft.mintCollection(alice, { + tokenPrefix: 'prps', + properties: collectionProps, + tokenPropertyPermissions: tokenPropPermissions, + }); - const mintToken = async (collection: UniqueNFTCollection) => { - return await collection.mintToken(alice, {Substrate: alice.address}, tokenProps); - }; + const mintToken = async (collection: UniqueNFTCollection) => await collection.mintToken(alice, {Substrate: alice.address}, tokenProps); before(async () => { --- a/tests/src/nesting/tokenProperties.test.ts +++ b/tests/src/nesting/tokenProperties.test.ts @@ -44,7 +44,7 @@ async function mintCollectionWithAllPermissionsAndToken(helper: UniqueHelper, mode: 'NFT' | 'RFT'): Promise<[UniqueNFToken | UniqueRFToken, bigint]> { const collection = await (mode == 'NFT' ? helper.nft : helper.rft).mintCollection(alice, { tokenPropertyPermissions: permissions.flatMap(({permission, signers}, i) => - signers.map(signer => {return {key: `${i+1}_${signer.address}`, permission};})), + signers.map(signer => ({key: `${i+1}_${signer.address}`, permission}))), }); return mode == 'NFT' ? [await collection.mintToken(alice), 1n] : [await collection.mintToken(alice, 100n as any), 100n]; } @@ -201,7 +201,7 @@ const collectionA = await helper.nft.mintCollection(alice, {permissions: {nesting: {tokenOwner: true}}}); const collectionB = await helper.nft.mintCollection(alice, { tokenPropertyPermissions: permissions.flatMap(({permission, signers}, i) => - signers.map(signer => {return {key: `${i+1}_${signer.address}`, permission};})), + signers.map(signer => ({key: `${i+1}_${signer.address}`, permission}))), }); const targetToken = await collectionA.mintToken(alice); const nestedToken = await collectionB.mintToken(alice, targetToken.nestingAccount()); @@ -239,7 +239,7 @@ const collectionA = await helper.nft.mintCollection(alice, {permissions: {nesting: {tokenOwner: true}}}); const collectionB = await helper.nft.mintCollection(alice, { tokenPropertyPermissions: permissions.flatMap(({permission, signers}, i) => - signers.map(signer => {return {key: `${i+1}_${signer.address}`, permission};})), + signers.map(signer => ({key: `${i+1}_${signer.address}`, permission}))), }); const targetToken = await collectionA.mintToken(alice); const nestedToken = await collectionB.mintToken(alice, targetToken.nestingAccount()); @@ -284,7 +284,7 @@ const collectionA = await helper.nft.mintCollection(alice, {permissions: {nesting: {tokenOwner: true}}}); const collectionB = await helper.nft.mintCollection(alice, { tokenPropertyPermissions: permissions.flatMap(({permission, signers}, i) => - signers.map(signer => {return {key: `${i+1}_${signer.address}`, permission};})), + signers.map(signer => ({key: `${i+1}_${signer.address}`, permission}))), }); const targetToken = await collectionA.mintToken(alice); const nestedToken = await collectionB.mintToken(alice, targetToken.nestingAccount()); @@ -477,7 +477,7 @@ async function mintCollectionWithAllPermissionsAndToken(helper: UniqueHelper, mode: 'NFT' | 'RFT'): Promise<[UniqueNFToken | UniqueRFToken, bigint]> { const collection = await (mode == 'NFT' ? helper.nft : helper.rft).mintCollection(alice, { - tokenPropertyPermissions: constitution.map(({permission}, i) => {return {key: `${i+1}`, permission};}), + tokenPropertyPermissions: constitution.map(({permission}, i) => ({key: `${i+1}`, permission})), }); return mode == 'NFT' ? [await collection.mintToken(alice), 1n] : [await collection.mintToken(alice, 100n as any), 100n]; } --- a/tests/src/refungible.test.ts +++ b/tests/src/refungible.test.ts @@ -64,7 +64,7 @@ itSub('RPC method tokenOwners for refungible collection and token', async ({helper}) => { const ethAcc = {Ethereum: '0x67fb3503a61b284dc83fa96dceec4192db47dc7c'}; - const facelessCrowd = (await helper.arrange.createAccounts(Array(7).fill(0n), donor)).map(keyring => {return {Substrate: keyring.address};}); + const facelessCrowd = (await helper.arrange.createAccounts(Array(7).fill(0n), donor)).map(keyring => ({Substrate: keyring.address})); const collection = await helper.rft.mintCollection(alice, {name: 'test', description: 'test', tokenPrefix: 'test'}); --- a/tests/src/rpc.test.ts +++ b/tests/src/rpc.test.ts @@ -40,7 +40,7 @@ // Set-up a few token owners of all stripes const ethAcc = {Ethereum: '0x67fb3503a61b284dc83fa96dceec4192db47dc7c'}; const facelessCrowd = (await helper.arrange.createAccounts([0n, 0n, 0n, 0n, 0n, 0n, 0n], donor)) - .map(i => {return {Substrate: i.address};}); + .map(i => ({Substrate: i.address})); const collection = await helper.ft.mintCollection(alice, {name: 'RPC-2', tokenPrefix: 'RPC'}); // mint some maximum (u128) amounts of tokens possible --- a/tests/src/sub/appPromotion/appPromotion.test.ts +++ b/tests/src/sub/appPromotion/appPromotion.test.ts @@ -357,11 +357,9 @@ const stakers = await getAccounts(3); await Promise.all(stakers.map(staker => helper.staking.stake(staker, 100n * nominal))); - await Promise.all(stakers.map(staker => { - return testCase.method === 'unstakeAll' - ? helper.staking.unstakeAll(staker) - : helper.staking.unstakePartial(staker, 100n * nominal); - })); + await Promise.all(stakers.map(staker => testCase.method === 'unstakeAll' + ? helper.staking.unstakeAll(staker) + : helper.staking.unstakePartial(staker, 100n * nominal))); await Promise.all(stakers.map(async (staker) => { expect(await helper.staking.getPendingUnstake({Substrate: staker.address})).to.be.equal(100n * nominal); @@ -375,11 +373,9 @@ const stakers = await getAccounts(10); await Promise.all(stakers.map(staker => helper.staking.stake(staker, 100n * nominal))); - const unstakingResults = await Promise.allSettled(stakers.map((staker, i) => { - return i % 2 === 0 - ? helper.staking.unstakeAll(staker) - : helper.staking.unstakePartial(staker, 100n * nominal); - })); + const unstakingResults = await Promise.allSettled(stakers.map((staker, i) => i % 2 === 0 + ? helper.staking.unstakeAll(staker) + : helper.staking.unstakePartial(staker, 100n * nominal))); const successfulUnstakes = unstakingResults.filter(result => result.status === 'fulfilled'); expect(successfulUnstakes).to.have.length(3); --- a/tests/src/util/index.ts +++ b/tests/src/util/index.ts @@ -19,13 +19,9 @@ chai.use(chaiSubset); export const expect = chai.expect; -const getTestHash = (filename: string) => { - return crypto.createHash('md5').update(filename).digest('hex'); -}; +const getTestHash = (filename: string) => crypto.createHash('md5').update(filename).digest('hex'); -export const getTestSeed = (filename: string) => { - return `//Alice+${getTestHash(filename)}`; -}; +export const getTestSeed = (filename: string) => `//Alice+${getTestHash(filename)}`; async function usingPlaygroundsGeneral(helperType: new(logger: ILogger) => T, url: string, code: (helper: T, privateKey: (seed: string | {filename?: string, url?: string, ignoreFundsPresence?: boolean}) => Promise) => Promise) { const silentConsole = new SilentConsole(); @@ -65,49 +61,27 @@ } } -export const usingPlaygrounds = (code: (helper: DevUniqueHelper, privateKey: (seed: string | {filename?: string, url?: string, ignoreFundsPresence?: boolean}) => Promise) => Promise, url: string = config.substrateUrl) => { - return usingPlaygroundsGeneral(DevUniqueHelper, url, code); -}; +export const usingPlaygrounds = (code: (helper: DevUniqueHelper, privateKey: (seed: string | {filename?: string, url?: string, ignoreFundsPresence?: boolean}) => Promise) => Promise, url: string = config.substrateUrl) => usingPlaygroundsGeneral(DevUniqueHelper, url, code); -export const usingWestmintPlaygrounds = (url: string, code: (helper: DevWestmintHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevWestmintHelper, url, code); -}; +export const usingWestmintPlaygrounds = (url: string, code: (helper: DevWestmintHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevWestmintHelper, url, code); -export const usingStateminePlaygrounds = (url: string, code: (helper: DevWestmintHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevWestmintHelper, url, code); -}; +export const usingStateminePlaygrounds = (url: string, code: (helper: DevWestmintHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevWestmintHelper, url, code); -export const usingStatemintPlaygrounds = (url: string, code: (helper: DevWestmintHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevWestmintHelper, url, code); -}; +export const usingStatemintPlaygrounds = (url: string, code: (helper: DevWestmintHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevWestmintHelper, url, code); -export const usingRelayPlaygrounds = (url: string, code: (helper: DevRelayHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevRelayHelper, url, code); -}; +export const usingRelayPlaygrounds = (url: string, code: (helper: DevRelayHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevRelayHelper, url, code); -export const usingAcalaPlaygrounds = (url: string, code: (helper: DevAcalaHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevAcalaHelper, url, code); -}; +export const usingAcalaPlaygrounds = (url: string, code: (helper: DevAcalaHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevAcalaHelper, url, code); -export const usingKaruraPlaygrounds = (url: string, code: (helper: DevKaruraHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevAcalaHelper, url, code); -}; +export const usingKaruraPlaygrounds = (url: string, code: (helper: DevKaruraHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevAcalaHelper, url, code); -export const usingMoonbeamPlaygrounds = (url: string, code: (helper: DevMoonbeamHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevMoonbeamHelper, url, code); -}; +export const usingMoonbeamPlaygrounds = (url: string, code: (helper: DevMoonbeamHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevMoonbeamHelper, url, code); -export const usingMoonriverPlaygrounds = (url: string, code: (helper: DevMoonbeamHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevMoonriverHelper, url, code); -}; +export const usingMoonriverPlaygrounds = (url: string, code: (helper: DevMoonbeamHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevMoonriverHelper, url, code); -export const usingAstarPlaygrounds = (url: string, code: (helper: DevAstarHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevAstarHelper, url, code); -}; +export const usingAstarPlaygrounds = (url: string, code: (helper: DevAstarHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevAstarHelper, url, code); -export const usingShidenPlaygrounds = (url: string, code: (helper: DevShidenHelper, privateKey: (seed: string) => Promise) => Promise) => { - return usingPlaygroundsGeneral(DevShidenHelper, url, code); -}; +export const usingShidenPlaygrounds = (url: string, code: (helper: DevShidenHelper, privateKey: (seed: string) => Promise) => Promise) => usingPlaygroundsGeneral(DevShidenHelper, url, code); export const MINIMUM_DONOR_FUND = 100_000n; export const DONOR_FUNDING = 2_000_000n; --- a/tests/src/util/playgrounds/unique.dev.ts +++ b/tests/src/util/playgrounds/unique.dev.ts @@ -771,9 +771,7 @@ // <<< Referendum voting <<< // Wait the proposal to pass - await this.helper.wait.expectEvent(3, Event.Democracy.Passed, event => { - return event.referendumIndex() == referendumIndex; - }); + await this.helper.wait.expectEvent(3, Event.Democracy.Passed, event => event.referendumIndex() == referendumIndex); await this.helper.wait.newBlocks(1); @@ -924,7 +922,7 @@ event( maxBlocksToWait: number, eventHelperType: new () => T, - filter: (_: T) => boolean = () => { return true; }, + filter: (_: T) => boolean = () => true, ) { // eslint-disable-next-line no-async-promise-executor const promise = new Promise(async (resolve) => { @@ -970,7 +968,7 @@ async expectEvent( maxBlocksToWait: number, eventHelperType: new () => T, - filter: (e: T) => boolean = () => { return true; }, + filter: (e: T) => boolean = () => true, ) { const e = await this.event(maxBlocksToWait, eventHelperType, filter); if (e == null) { @@ -1077,9 +1075,7 @@ async startCapture() { this.stopCapture(); this.unsubscribe = (await this.helper.getApi().query.system.events((eventRecords: FrameSystemEventRecord[]) => { - const newEvents = eventRecords.filter(r => { - return r.event.section == this.eventSection && r.event.method == this.eventMethod; - }); + const newEvents = eventRecords.filter(r => r.event.section == this.eventSection && r.event.method == this.eventMethod); this.events.push(...newEvents); })) as any; @@ -1105,12 +1101,10 @@ async payoutStakers(signer: IKeyringPair, stakersToPayout: number): Promise<{staker: string, stake: bigint, payout: bigint}[]> { const payoutResult = await this.helper.executeExtrinsic(signer, 'api.tx.appPromotion.payoutStakers', [stakersToPayout], true); - return payoutResult.result.events.filter(e => e.event.method === 'StakingRecalculation').map(e => { - return { - staker: e.event.data[0].toString(), - stake: e.event.data[1].toBigInt(), - payout: e.event.data[2].toBigInt(), - }; - }); + return payoutResult.result.events.filter(e => e.event.method === 'StakingRecalculation').map(e => ({ + staker: e.event.data[0].toString(), + stake: e.event.data[1].toBigInt(), + payout: e.event.data[2].toBigInt(), + })); } } --- a/tests/src/util/playgrounds/unique.ts +++ b/tests/src/util/playgrounds/unique.ts @@ -2395,7 +2395,7 @@ return total.toBigInt(); } - async getLocked(address: TSubstrateAccount): Promise<[{ id: string, amount: bigint, reason: string }]> { + async getLocked(address: TSubstrateAccount): Promise<{ id: string, amount: bigint, reason: string }[]> { const locks = (await this.helper.callRpc('api.query.balances.locks', [address])).toHuman(); return locks.map((lock: any) => ({id: lock.id, amount: BigInt(lock.amount.replace(/,/g, '')), reasons: lock.reasons})); } @@ -2581,14 +2581,12 @@ */ async getVestingSchedules(address: TSubstrateAccount): Promise<{ start: bigint, period: bigint, periodCount: bigint, perPeriod: bigint }[]> { const schedule = (await this.helper.callRpc('api.query.vesting.vestingSchedules', [address])).toJSON(); - return schedule.map((schedule: any) => { - return { - start: BigInt(schedule.start), - period: BigInt(schedule.period), - periodCount: BigInt(schedule.periodCount), - perPeriod: BigInt(schedule.perPeriod), - }; - }); + return schedule.map((schedule: any) => ({ + start: BigInt(schedule.start), + period: BigInt(schedule.period), + periodCount: BigInt(schedule.periodCount), + perPeriod: BigInt(schedule.perPeriod), + })); } /** @@ -2804,12 +2802,10 @@ */ async getTotalStakedPerBlock(address: ICrossAccountId): Promise { const rawTotalStakerdPerBlock = await this.helper.callRpc('api.rpc.appPromotion.totalStakedPerBlock', [address]); - return rawTotalStakerdPerBlock.map(([block, amount]: any[]) => { - return { - block: block.toBigInt(), - amount: amount.toBigInt(), - }; - }); + return rawTotalStakerdPerBlock.map(([block, amount]: any[]) => ({ + block: block.toBigInt(), + amount: amount.toBigInt(), + })); } /** @@ -2828,12 +2824,10 @@ */ async getPendingUnstakePerBlock(address: ICrossAccountId): Promise { const rawUnstakedPerBlock = await this.helper.callRpc('api.rpc.appPromotion.pendingUnstakePerBlock', [address]); - const result = rawUnstakedPerBlock.map(([block, amount]: any[]) => { - return { - block: block.toBigInt(), - amount: amount.toBigInt(), - }; - }); + const result = rawUnstakedPerBlock.map(([block, amount]: any[]) => ({ + block: block.toBigInt(), + amount: amount.toBigInt(), + })); return result; } } --- a/tests/src/xcm/xcmQuartz.test.ts +++ b/tests/src/xcm/xcmQuartz.test.ts @@ -682,10 +682,8 @@ maliciousXcmProgramSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramSent.messageHash() - && event.outcome().isFailedToTransactAsset; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramSent.messageHash() + && event.outcome().isFailedToTransactAsset); targetAccountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(targetAccountBalance).to.be.equal(0n); @@ -765,10 +763,8 @@ maliciousXcmProgramFullIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); let accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -780,10 +776,8 @@ maliciousXcmProgramHereIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -858,10 +852,8 @@ }); const expectFailedToTransact = async (helper: DevUniqueHelper, messageSent: any) => { - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == messageSent.messageHash() - && event.outcome().isFailedToTransactAsset; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == messageSent.messageHash() + && event.outcome().isFailedToTransactAsset); }; itSub('Quartz rejects KAR tokens from Karura', async ({helper}) => { @@ -1172,10 +1164,8 @@ maliciousXcmProgramSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramSent.messageHash() - && event.outcome().isFailedToTransactAsset; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramSent.messageHash() + && event.outcome().isFailedToTransactAsset); targetAccountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(targetAccountBalance).to.be.equal(0n); @@ -1263,10 +1253,8 @@ maliciousXcmProgramFullIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); let accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -1282,10 +1270,8 @@ maliciousXcmProgramHereIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -1544,10 +1530,8 @@ maliciousXcmProgramSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramSent.messageHash() - && event.outcome().isFailedToTransactAsset; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramSent.messageHash() + && event.outcome().isFailedToTransactAsset); targetAccountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(targetAccountBalance).to.be.equal(0n); @@ -1627,10 +1611,8 @@ maliciousXcmProgramFullIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); let accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -1642,10 +1624,8 @@ maliciousXcmProgramHereIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); --- a/tests/src/xcm/xcmUnique.test.ts +++ b/tests/src/xcm/xcmUnique.test.ts @@ -684,10 +684,8 @@ maliciousXcmProgramSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramSent.messageHash() - && event.outcome().isFailedToTransactAsset; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramSent.messageHash() + && event.outcome().isFailedToTransactAsset); targetAccountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(targetAccountBalance).to.be.equal(0n); @@ -767,10 +765,8 @@ maliciousXcmProgramFullIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); let accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -782,10 +778,8 @@ maliciousXcmProgramHereIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -860,10 +854,8 @@ }); const expectFailedToTransact = async (helper: DevUniqueHelper, messageSent: any) => { - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == messageSent.messageHash() - && event.outcome().isFailedToTransactAsset; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == messageSent.messageHash() + && event.outcome().isFailedToTransactAsset); }; itSub('Unique rejects ACA tokens from Acala', async ({helper}) => { @@ -1175,10 +1167,8 @@ maliciousXcmProgramSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramSent.messageHash() - && event.outcome().isFailedToTransactAsset; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramSent.messageHash() + && event.outcome().isFailedToTransactAsset); targetAccountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(targetAccountBalance).to.be.equal(0n); @@ -1266,10 +1256,8 @@ maliciousXcmProgramFullIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); let accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -1285,10 +1273,8 @@ maliciousXcmProgramHereIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -1546,10 +1532,8 @@ maliciousXcmProgramSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramSent.messageHash() - && event.outcome().isFailedToTransactAsset; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramSent.messageHash() + && event.outcome().isFailedToTransactAsset); targetAccountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(targetAccountBalance).to.be.equal(0n); @@ -1629,10 +1613,8 @@ maliciousXcmProgramFullIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramFullIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); let accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n); @@ -1644,10 +1626,8 @@ maliciousXcmProgramHereIdSent = await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.XcmpMessageSent); }); - await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => { - return event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() - && event.outcome().isUntrustedReserveLocation; - }); + await helper.wait.expectEvent(maxWaitBlocks, Event.XcmpQueue.Fail, event => event.messageHash() == maliciousXcmProgramHereIdSent.messageHash() + && event.outcome().isUntrustedReserveLocation); accountBalance = await helper.balance.getSubstrate(targetAccount.address); expect(accountBalance).to.be.equal(0n);