From b995e58942f3c00fa6ad5ccc240938645a01e910 Mon Sep 17 00:00:00 2001 From: Greg Zaitsev Date: Fri, 26 Feb 2021 12:48:37 +0000 Subject: [PATCH] Merge pull request #112 from usetech-llc/feature/NFTPAR-308_limited_owners_control Limited owners control --- --- a/pallets/nft/src/lib.rs +++ b/pallets/nft/src/lib.rs @@ -382,6 +382,8 @@ AccountTokenLimitExceeded, /// Collection limit bounds per collection exceeded CollectionLimitBoundsExceeded, + /// Tried to enable permissions which are only permitted to be disabled + OwnerPermissionsCantBeReverted, /// Schema data size limit bound exceeded SchemaDataLimitExceeded, /// Maximum refungibility exceeded @@ -639,6 +641,11 @@ let sender = ensure_signed(origin)?; Self::check_owner_permissions(collection_id, sender)?; + let target_collection = >::get(collection_id); + if !target_collection.limits.owner_can_destroy { + fail!(Error::::NoPermission); + } + >::remove_prefix(collection_id); >::remove_prefix(collection_id); >::remove_prefix(collection_id); @@ -1022,9 +1029,14 @@ // Transfer permissions check let target_collection = >::get(collection_id); - ensure!(Self::is_item_owner(sender.clone(), collection_id, item_id) || - Self::is_owner_or_admin_permissions(collection_id, sender.clone()), - Error::::NoPermission); + ensure!( + Self::is_item_owner(sender.clone(), collection_id, item_id) || + ( + target_collection.limits.owner_can_transfer && + Self::is_owner_or_admin_permissions(collection_id, sender.clone()) + ), + Error::::NoPermission + ); if target_collection.access == AccessMode::WhiteList { Self::check_white_list(collection_id, &sender)?; @@ -1098,9 +1110,14 @@ // Transfer permissions check let target_collection = >::get(collection_id); - ensure!(Self::is_item_owner(sender.clone(), collection_id, item_id) || - Self::is_owner_or_admin_permissions(collection_id, sender.clone()), - Error::::NoPermission); + ensure!( + Self::is_item_owner(sender.clone(), collection_id, item_id) || + ( + target_collection.limits.owner_can_transfer && + Self::is_owner_or_admin_permissions(collection_id, sender.clone()) + ), + Error::::NoPermission + ); if target_collection.access == AccessMode::WhiteList { Self::check_white_list(collection_id, &sender)?; @@ -1156,8 +1173,14 @@ Self::is_correct_transfer(collection_id, &target_collection, &recipient)?; // Transfer permissions check - ensure!(appoved_transfer || Self::is_owner_or_admin_permissions(collection_id, sender.clone()), - Error::::NoPermission); + ensure!( + appoved_transfer || + ( + target_collection.limits.owner_can_transfer && + Self::is_owner_or_admin_permissions(collection_id, sender.clone()) + ), + Error::::NoPermission + ); if target_collection.access == AccessMode::WhiteList { Self::check_white_list(collection_id, &sender)?; @@ -1524,25 +1547,32 @@ pub fn set_collection_limits( origin, collection_id: u32, - limits: CollectionLimits, + new_limits: CollectionLimits, ) -> DispatchResult { let sender = ensure_signed(origin)?; Self::check_owner_permissions(collection_id, sender.clone())?; let mut target_collection = >::get(collection_id); + let old_limits = target_collection.limits; let chain_limits = ChainLimit::get(); - let climits = target_collection.limits; // collection bounds - ensure!(limits.sponsor_transfer_timeout <= MAX_SPONSOR_TIMEOUT && - limits.account_token_ownership_limit <= MAX_TOKEN_OWNERSHIP, + ensure!(new_limits.sponsor_transfer_timeout <= MAX_SPONSOR_TIMEOUT && + new_limits.account_token_ownership_limit <= MAX_TOKEN_OWNERSHIP && + new_limits.sponsored_data_size <= chain_limits.custom_data_limit && + new_limits.sponsored_mint_size <= chain_limits.custom_data_limit, Error::::CollectionLimitBoundsExceeded); // token_limit check prev - ensure!(climits.token_limit > limits.token_limit && - limits.token_limit <= chain_limits.account_token_ownership_limit, - Error::::AccountTokenLimitExceeded); + ensure!(old_limits.token_limit >= new_limits.token_limit, Error::::CollectionTokenLimitExceeded); + ensure!(new_limits.token_limit > 0, Error::::CollectionTokenLimitExceeded); - target_collection.limits = limits; + ensure!( + (old_limits.owner_can_transfer || !new_limits.owner_can_transfer) && + (old_limits.owner_can_destroy || !new_limits.owner_can_destroy), + Error::::OwnerPermissionsCantBeReverted, + ); + + target_collection.limits = new_limits; >::insert(collection_id, target_collection); Ok(()) --- a/tests/src/approve.test.ts +++ b/tests/src/approve.test.ts @@ -3,6 +3,7 @@ // file 'LICENSE', which is part of this source code package. // import { ApiPromise } from '@polkadot/api'; +import { IKeyringPair } from '@polkadot/types/types'; import BN from 'bn.js'; import chai from 'chai'; import chaiAsPromised from 'chai-as-promised'; @@ -15,6 +16,7 @@ createFungibleItemExpectSuccess, createItemExpectSuccess, destroyCollectionExpectSuccess, + setCollectionLimitsExpectSuccess, transferFromExpectSuccess, U128_MAX, } from './util/helpers'; @@ -23,10 +25,20 @@ const expect = chai.expect; describe('Integration Test approve(spender, collection_id, item_id, amount):', () => { + let Alice: IKeyringPair; + let Bob: IKeyringPair; + let Charlie: IKeyringPair; + + before(async () => { + await usingApi(async (api) => { + Alice = privateKey('//Alice'); + Bob = privateKey('//Bob'); + Charlie = privateKey('//Charlie'); + }); + }); + it('Execute the extrinsic and check approvedList', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); const nftCollectionId = await createCollectionExpectSuccess(); // nft const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT'); @@ -45,8 +57,6 @@ it('Remove approval by using 0 amount', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); const nftCollectionId = await createCollectionExpectSuccess(); // nft const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT'); @@ -65,13 +75,30 @@ await approveExpectSuccess(reFungibleCollectionId, newReFungibleTokenId, Alice, Bob, 0); }); }); + + it('can be called by collection owner on non-owned item when OwnerCanTransfer == true', async () => { + const collectionId = await createCollectionExpectSuccess(); + const itemId = await createItemExpectSuccess(Alice, collectionId, 'NFT', Bob.address); + + await approveExpectSuccess(collectionId, itemId, Alice, Charlie); + }); }); describe('Negative Integration Test approve(spender, collection_id, item_id, amount):', () => { + let Alice: IKeyringPair; + let Bob: IKeyringPair; + let Charlie: IKeyringPair; + + before(async () => { + await usingApi(async (api) => { + Alice = privateKey('//Alice'); + Bob = privateKey('//Bob'); + Charlie = privateKey('//Charlie'); + }); + }); + it('Approve for a collection that does not exist', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); // nft const nftCollectionCount = await api.query.nft.createdCollectionCount() as unknown as number; await approveExpectFail(nftCollectionCount + 1, 1, Alice, Bob); @@ -86,8 +113,6 @@ it('Approve for a collection that was destroyed', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); // nft const nftCollectionId = await createCollectionExpectSuccess(); await destroyCollectionExpectSuccess(nftCollectionId); @@ -106,8 +131,6 @@ it('Approve transfer of a token that does not exist', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); // nft const nftCollectionId = await createCollectionExpectSuccess(); await approveExpectFail(nftCollectionId, 2, Alice, Bob); @@ -123,8 +146,6 @@ it('Approve using the address that does not own the approved token', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); const nftCollectionId = await createCollectionExpectSuccess(); // nft const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT'); @@ -140,4 +161,12 @@ await approveExpectFail(reFungibleCollectionId, newReFungibleTokenId, Bob, Alice); }); }); + + it('fails when called by collection owner on non-owned item when OwnerCanTransfer == false', async () => { + const collectionId = await createCollectionExpectSuccess(); + const itemId = await createItemExpectSuccess(Alice, collectionId, 'NFT', Bob.address); + await setCollectionLimitsExpectSuccess(Alice, collectionId, { OwnerCanTransfer: false }); + + await approveExpectFail(collectionId, itemId, Alice, Charlie); + }); }); --- a/tests/src/destroyCollection.test.ts +++ b/tests/src/destroyCollection.test.ts @@ -3,10 +3,12 @@ // file 'LICENSE', which is part of this source code package. // +import { IKeyringPair } from '@polkadot/types/types'; import chai from 'chai'; import chaiAsPromised from 'chai-as-promised'; +import privateKey from './substrate/privateKey'; import { default as usingApi } from "./substrate/substrate-api"; -import { createCollectionExpectSuccess, destroyCollectionExpectSuccess, destroyCollectionExpectFailure } from "./util/helpers"; +import { createCollectionExpectSuccess, destroyCollectionExpectSuccess, destroyCollectionExpectFailure, setCollectionLimitsExpectSuccess } from "./util/helpers"; chai.use(chaiAsPromised); @@ -26,6 +28,14 @@ }); describe('(!negative test!) integration test: ext. destroyCollection():', () => { + let alice: IKeyringPair; + + before(async () => { + await usingApi(async (api) => { + alice = privateKey('//Alice'); + }); + }); + it('(!negative test!) Destroy a collection that never existed', async () => { await usingApi(async (api) => { // Find the collection that never existed @@ -43,4 +53,10 @@ await destroyCollectionExpectFailure(collectionId, '//Bob'); await destroyCollectionExpectSuccess(collectionId, '//Alice'); }); + it('fails when OwnerCanDestroy == false', async () => { + const collectionId = await createCollectionExpectSuccess(); + await setCollectionLimitsExpectSuccess(alice, collectionId, { OwnerCanDestroy: false }); + + await destroyCollectionExpectFailure(collectionId, '//Alice'); + }); }); --- a/tests/src/setCollectionLimits.test.ts +++ b/tests/src/setCollectionLimits.test.ts @@ -14,6 +14,8 @@ createCollectionExpectSuccess, getCreatedCollectionCount, getCreateItemResult, getDetailedCollectionInfo, + setCollectionLimitsExpectFailure, + setCollectionLimitsExpectSuccess, } from './util/helpers'; chai.use(chaiAsPromised); @@ -26,21 +28,8 @@ const accountTokenOwnershipLimit = 0; const sponsoredDataSize = 0; const sponsoredMintSize = 0; -const tokenLimit = 0; - -describe('hooks', () => { - before(async () => { - await usingApi(async () => { - const keyring = new Keyring({ type: 'sr25519' }); - alice = keyring.addFromUri('//Alice'); - }); - }); - it('choose or create collection for testing', async () => { - await usingApi(async () => { - collectionIdForTesting = await createCollectionExpectSuccess({name: 'A', description: 'B', tokenPrefix: 'C', mode: {type: 'NFT'}}); - }); - }); -}); +const sponsorTimeout = 1; +const tokenLimit = 1; describe('setCollectionLimits positive', () => { let tx; @@ -48,6 +37,7 @@ await usingApi(async () => { const keyring = new Keyring({ type: 'sr25519' }); alice = keyring.addFromUri('//Alice'); + collectionIdForTesting = await createCollectionExpectSuccess({name: 'A', description: 'B', tokenPrefix: 'C', mode: {type: 'NFT'}}); }); }); it('execute setCollectionLimits with predefined params ', async () => { @@ -55,25 +45,28 @@ tx = api.tx.nft.setCollectionLimits( collectionIdForTesting, { - accountTokenOwnershipLimit, - sponsoredDataSize, - sponsoredMintSize, - tokenLimit, + AccountTokenOwnershipLimit: accountTokenOwnershipLimit, + SponsoredMintSize: sponsoredDataSize, + TokenLimit: tokenLimit, + SponsorTimeout: sponsorTimeout, + OwnerCanTransfer: true, + OwnerCanDestroy: true }, ); const events = await submitTransactionAsync(alice, tx); const result = getCreateItemResult(events); + + // get collection limits defined previously + const collectionInfo = await getDetailedCollectionInfo(api, collectionIdForTesting) as ICollectionInterface; + // tslint:disable-next-line:no-unused-expression expect(result.success).to.be.true; - }); - }); - it('get collection limits defined in previous test', async () => { - await usingApi(async (api: ApiPromise) => { - const collectionInfo = await getDetailedCollectionInfo(api, collectionIdForTesting) as ICollectionInterface; expect(collectionInfo.Limits.AccountTokenOwnershipLimit.toNumber()).to.be.equal(accountTokenOwnershipLimit); - expect(collectionInfo.Limits.SponsoredMintSize.toNumber()).to.be.equal(sponsoredMintSize); + expect(collectionInfo.Limits.SponsoredMintSize.toNumber()).to.be.equal(sponsoredDataSize); expect(collectionInfo.Limits.TokenLimit.toNumber()).to.be.equal(tokenLimit); - expect(collectionInfo.Limits.SponsorTimeout.toNumber()).to.be.equal(sponsoredDataSize); + expect(collectionInfo.Limits.SponsorTimeout.toNumber()).to.be.equal(sponsorTimeout); + expect(collectionInfo.Limits.OwnerCanTransfer.valueOf()).to.be.true; + expect(collectionInfo.Limits.OwnerCanDestroy.valueOf()).to.be.true; }); }); }); @@ -85,6 +78,7 @@ const keyring = new Keyring({ type: 'sr25519' }); alice = keyring.addFromUri('//Alice'); bob = keyring.addFromUri('//Bob'); + collectionIdForTesting = await createCollectionExpectSuccess({name: 'A', description: 'B', tokenPrefix: 'C', mode: {type: 'NFT'}}); }); }); it('execute setCollectionLimits for not exists collection', async () => { @@ -131,4 +125,44 @@ await expect(submitTransactionExpectFailAsync(alice, tx)).to.be.rejected; }); }); + + it('fails when trying to enable OwnerCanTransfer after it was disabled', async () => { + const collectionId = await createCollectionExpectSuccess(); + await setCollectionLimitsExpectSuccess(alice, collectionId, { + AccountTokenOwnershipLimit: accountTokenOwnershipLimit, + SponsoredMintSize: sponsoredDataSize, + TokenLimit: tokenLimit, + SponsorTimeout: sponsorTimeout, + OwnerCanTransfer: false, + OwnerCanDestroy: true + }); + await setCollectionLimitsExpectFailure(alice, collectionId, { + AccountTokenOwnershipLimit: accountTokenOwnershipLimit, + SponsoredMintSize: sponsoredDataSize, + TokenLimit: tokenLimit, + SponsorTimeout: sponsorTimeout, + OwnerCanTransfer: true, + OwnerCanDestroy: true + }); + }); + + it('fails when trying to enable OwnerCanDestroy after it was disabled', async () => { + const collectionId = await createCollectionExpectSuccess(); + await setCollectionLimitsExpectSuccess(alice, collectionId, { + AccountTokenOwnershipLimit: accountTokenOwnershipLimit, + SponsoredMintSize: sponsoredDataSize, + TokenLimit: tokenLimit, + SponsorTimeout: sponsorTimeout, + OwnerCanTransfer: true, + OwnerCanDestroy: false + }); + await setCollectionLimitsExpectFailure(alice, collectionId, { + AccountTokenOwnershipLimit: accountTokenOwnershipLimit, + SponsoredMintSize: sponsoredDataSize, + TokenLimit: tokenLimit, + SponsorTimeout: sponsorTimeout, + OwnerCanTransfer: true, + OwnerCanDestroy: true + }); + }); }); --- a/tests/src/transferFrom.test.ts +++ b/tests/src/transferFrom.test.ts @@ -3,6 +3,7 @@ // file 'LICENSE', which is part of this source code package. // import { ApiPromise } from '@polkadot/api'; +import { IKeyringPair } from '@polkadot/types/types'; import chai from 'chai'; import chaiAsPromised from 'chai-as-promised'; import privateKey from './substrate/privateKey'; @@ -18,17 +19,27 @@ transferFromExpectFail, transferFromExpectSuccess, burnItemExpectSuccess, + setCollectionLimitsExpectSuccess, } from './util/helpers'; chai.use(chaiAsPromised); const expect = chai.expect; describe('Integration Test transferFrom(from, recipient, collection_id, item_id, value):', () => { + let Alice: IKeyringPair; + let Bob: IKeyringPair; + let Charlie: IKeyringPair; + + before(async () => { + await usingApi(async (api) => { + Alice = privateKey('//Alice'); + Bob = privateKey('//Bob'); + Charlie = privateKey('//Charlie'); + }); + }); + it('Execute the extrinsic and check nftItemList - owner of token', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); // nft const nftCollectionId = await createCollectionExpectSuccess(); const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT'); @@ -66,14 +77,30 @@ expect((await getAllowance(fungibleCollectionId, newFungibleTokenId, alice.address, bob.address)).toString()).to.equal('0'); }); }); + + it('can be called by collection owner on non-owned item when OwnerCanTransfer == true', async () => { + const collectionId = await createCollectionExpectSuccess(); + const itemId = await createItemExpectSuccess(Alice, collectionId, 'NFT', Bob.address); + + await transferFromExpectSuccess(collectionId, itemId, Alice, Bob, Charlie); + }); }); describe('Negative Integration Test transferFrom(from, recipient, collection_id, item_id, value):', () => { + let Alice: IKeyringPair; + let Bob: IKeyringPair; + let Charlie: IKeyringPair; + + before(async () => { + await usingApi(async (api) => { + Alice = privateKey('//Alice'); + Bob = privateKey('//Bob'); + Charlie = privateKey('//Charlie'); + }); + }); + it('transferFrom for a collection that does not exist', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); // nft const nftCollectionCount = await api.query.nft.createdCollectionCount() as unknown as number; await approveExpectFail(nftCollectionCount + 1, 1, Alice, Bob); @@ -113,9 +140,6 @@ it('transferFrom for not approved address', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); // nft const nftCollectionId = await createCollectionExpectSuccess(); const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT'); @@ -137,9 +161,6 @@ it('transferFrom incorrect token count', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); // nft const nftCollectionId = await createCollectionExpectSuccess(); const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT'); @@ -164,9 +185,6 @@ it('execute transferFrom from account that is not owner of collection', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); const Dave = privateKey('//Dave'); // nft const nftCollectionId = await createCollectionExpectSuccess(); @@ -206,9 +224,6 @@ }); it( 'transferFrom burnt token before approve NFT', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); // nft const nftCollectionId = await createCollectionExpectSuccess(); const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT'); @@ -219,9 +234,6 @@ }); it( 'transferFrom burnt token before approve Fungible', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); const fungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}}); const newFungibleTokenId = await createItemExpectSuccess(Alice, fungibleCollectionId, 'Fungible'); await burnItemExpectSuccess(Alice, fungibleCollectionId, 1, 10); @@ -232,9 +244,6 @@ }); it( 'transferFrom burnt token before approve ReFungible', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); const reFungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'ReFungible'}}); const newReFungibleTokenId = await createItemExpectSuccess(Alice, reFungibleCollectionId, 'ReFungible'); await burnItemExpectSuccess(Alice, reFungibleCollectionId, newReFungibleTokenId, 1); @@ -246,9 +255,6 @@ it( 'transferFrom burnt token after approve NFT', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); // nft const nftCollectionId = await createCollectionExpectSuccess(); const newNftTokenId = await createItemExpectSuccess(Alice, nftCollectionId, 'NFT'); @@ -259,9 +265,6 @@ }); it( 'transferFrom burnt token after approve Fungible', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); const fungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'Fungible', decimalPoints: 0}}); const newFungibleTokenId = await createItemExpectSuccess(Alice, fungibleCollectionId, 'Fungible'); await approveExpectSuccess(fungibleCollectionId, newFungibleTokenId, Alice, Bob); @@ -272,9 +275,6 @@ }); it( 'transferFrom burnt token after approve ReFungible', async () => { await usingApi(async (api: ApiPromise) => { - const Alice = privateKey('//Alice'); - const Bob = privateKey('//Bob'); - const Charlie = privateKey('//Charlie'); const reFungibleCollectionId = await createCollectionExpectSuccess({mode: {type: 'ReFungible'}}); const newReFungibleTokenId = await createItemExpectSuccess(Alice, reFungibleCollectionId, 'ReFungible'); await approveExpectSuccess(reFungibleCollectionId, newReFungibleTokenId, Alice, Bob); @@ -282,5 +282,13 @@ await transferFromExpectFail(reFungibleCollectionId, newReFungibleTokenId, Bob, Alice, Charlie, 1); }); - }); + }); + + it('fails when called by collection owner on non-owned item when OwnerCanTransfer == false', async () => { + const collectionId = await createCollectionExpectSuccess(); + const itemId = await createItemExpectSuccess(Alice, collectionId, 'NFT', Bob.address); + await setCollectionLimitsExpectSuccess(Alice, collectionId, { OwnerCanTransfer: false }); + + await transferFromExpectFail(collectionId, itemId, Alice, Bob, Charlie); + }); }); --- a/tests/src/types.ts +++ b/tests/src/types.ts @@ -17,6 +17,8 @@ SponsoredMintSize: BN; TokenLimit: BN; SponsorTimeout: BN; + OwnerCanTransfer: boolean; + OwnerCanDestroy: boolean; }; MintMode: boolean; Mode: { --- a/tests/src/util/helpers.ts +++ b/tests/src/util/helpers.ts @@ -333,6 +333,36 @@ }); } +export async function queryCollectionLimits(collectionId: number) { + return await usingApi(async (api) => { + return ((await api.query.nft.collection(collectionId)).toJSON() as any).Limits; + }); +} + +export async function setCollectionLimitsExpectSuccess(sender: IKeyringPair, collectionId: number, limits: any) { + await usingApi(async (api) => { + const oldLimits = await queryCollectionLimits(collectionId); + const newLimits = { ...oldLimits as any, ...limits }; + const tx = api.tx.nft.setCollectionLimits(collectionId, newLimits); + const events = await submitTransactionAsync(sender, tx); + const result = getGenericResult(events); + + expect(result.success).to.be.true; + }); +} + +export async function setCollectionLimitsExpectFailure(sender: IKeyringPair, collectionId: number, limits: any) { + await usingApi(async (api) => { + const oldLimits = await queryCollectionLimits(collectionId); + const newLimits = { ...oldLimits as any, ...limits }; + const tx = api.tx.nft.setCollectionLimits(collectionId, newLimits); + const events = await expect(submitTransactionExpectFailAsync(sender, tx)).to.be.rejected; + const result = getGenericResult(events); + + expect(result.success).to.be.false; + }); +} + export async function setCollectionSponsorExpectSuccess(collectionId: number, sponsor: string) { await usingApi(async (api) => { -- gitstuff