From 6ac8e66dbab7dfd36bb72615fcfdf2f2c4cf5844 Mon Sep 17 00:00:00 2001
From: Daniel Shiposha <dshiposha@usetech.com>
Date: Wed, 11 May 2022 11:11:52 +0000
Subject: [PATCH] Add proper common pallet errors


---
--- a/pallets/common/src/lib.rs
+++ b/pallets/common/src/lib.rs
@@ -366,9 +366,14 @@
 		/// Tried to store more data than allowed in collection field
 		CollectionFieldSizeExceeded,
 
+		/// Tried to store more property data than allowed
 		NoSpaceForProperty,
 
+		/// Tried to store more property keys than allowed
 		PropertyLimitReached,
+
+		/// Unable to read array of unbounded keys
+		UnableToReadUnboundedKeys,
 	}
 
 	#[pallet::storage]
@@ -865,9 +870,8 @@
 	) -> Result<Vec<PropertyKey>, DispatchError> {
 		keys.into_iter()
 			.map(|key| -> Result<PropertyKey, DispatchError> {
-				// TODO Fix error
 				key.try_into()
-					.map_err(|_| DispatchError::Other("Can't read property key"))
+					.map_err(|_| <Error<T>>::UnableToReadUnboundedKeys.into())
 			})
 			.collect::<Result<Vec<PropertyKey>, DispatchError>>()
 	}

-- 
gitstuff