From 55d2f5bff4345a9bd582ce0253c47c801e05f220 Mon Sep 17 00:00:00 2001 From: str-mv Date: Tue, 31 Aug 2021 14:24:23 +0000 Subject: [PATCH] Style update --- --- a/pallets/nft/src/mock.rs +++ b/pallets/nft/src/mock.rs @@ -98,12 +98,6 @@ type WeightInfo = (); } -<<<<<<< HEAD -type Timestamp = pallet_timestamp::Pallet; -type Randomness = pallet_randomness_collective_flip::Pallet; - -======= ->>>>>>> origin/develop parameter_types! { pub const CollectionCreationPrice: u32 = 0; pub TreasuryAccountId: u64 = 1234; --- a/pallets/nft/src/tests.rs +++ b/pallets/nft/src/tests.rs @@ -2080,206 +2080,210 @@ Error::::NoPermission ); -#[test] -fn collection_transfer_flag_works() { - new_test_ext().execute_with(|| { - let origin1 = Origin::signed(1); + #[test] + fn collection_transfer_flag_works() { + new_test_ext().execute_with(|| { + let origin1 = Origin::signed(1); - let collection_id = create_test_collection(&CollectionMode::NFT, 1); - assert_ok!(TemplateModule::set_transfers_enabled_flag(origin1, 1, true)); + let collection_id = create_test_collection(&CollectionMode::NFT, 1); + assert_ok!(TemplateModule::set_transfers_enabled_flag(origin1, 1, true)); - let data = default_nft_data(); - create_test_item(collection_id, &data.into()); - assert_eq!(TemplateModule::balance_count(1, 1), 1); - assert_eq!(TemplateModule::address_tokens(1, 1), [1]); + let data = default_nft_data(); + create_test_item(collection_id, &data.into()); + assert_eq!(TemplateModule::balance_count(1, 1), 1); + assert_eq!(TemplateModule::address_tokens(1, 1), [1]); - let origin1 = Origin::signed(1); + let origin1 = Origin::signed(1); - // default scenario - assert_ok!(TemplateModule::transfer(origin1, account(2), 1, 1, 1000)); - assert_eq!(TemplateModule::nft_item_id(1, 1).unwrap().owner, account(2)); - assert_eq!(TemplateModule::balance_count(1, 1), 0); - assert_eq!(TemplateModule::balance_count(1, 2), 1); + // default scenario + assert_ok!(TemplateModule::transfer(origin1, account(2), 1, 1, 1000)); + assert_eq!(TemplateModule::nft_item_id(1, 1).unwrap().owner, account(2)); + assert_eq!(TemplateModule::balance_count(1, 1), 0); + assert_eq!(TemplateModule::balance_count(1, 2), 1); - assert_eq!(TemplateModule::address_tokens(1, 2), [1]); - }); -} + assert_eq!(TemplateModule::address_tokens(1, 2), [1]); + }); + } -#[test] -fn set_variable_meta_data_on_nft_with_admin_flag() { - new_test_ext().execute_with(|| { - default_limits(); + #[test] + fn set_variable_meta_data_on_nft_with_admin_flag() { + new_test_ext().execute_with(|| { + default_limits(); - let collection_id = create_test_collection_for_owner(&CollectionMode::NFT, 2, 1); + let collection_id = create_test_collection_for_owner(&CollectionMode::NFT, 2, 1); - let origin1 = Origin::signed(1); - let origin2 = Origin::signed(2); + let origin1 = Origin::signed(1); + let origin2 = Origin::signed(2); - assert_ok!(TemplateModule::set_mint_permission( - origin2.clone(), - collection_id, - true - )); - assert_ok!(TemplateModule::add_to_white_list( - origin2.clone(), - collection_id, - account(1) - )); + assert_ok!(TemplateModule::set_mint_permission( + origin2.clone(), + collection_id, + true + )); + assert_ok!(TemplateModule::add_to_white_list( + origin2.clone(), + collection_id, + account(1) + )); - assert_ok!(TemplateModule::add_collection_admin( - origin2.clone(), - collection_id, - account(1) - )); + assert_ok!(TemplateModule::add_collection_admin( + origin2.clone(), + collection_id, + account(1) + )); - let data = default_nft_data(); - create_test_item(1, &data.into()); + let data = default_nft_data(); + create_test_item(1, &data.into()); - TemplateModule::set_meta_update_permission_flag( - origin2.clone(), - collection_id, - MetaUpdatePermission::Admin, - ); + TemplateModule::set_meta_update_permission_flag( + origin2.clone(), + collection_id, + MetaUpdatePermission::Admin, + ); - let variable_data = b"test set_variable_meta_data method.".to_vec(); - assert_ok!(TemplateModule::set_variable_meta_data( - origin1, - collection_id, - 1, - variable_data.clone() - )); + let variable_data = b"test set_variable_meta_data method.".to_vec(); + assert_ok!(TemplateModule::set_variable_meta_data( + origin1, + collection_id, + 1, + variable_data.clone() + )); - assert_eq!( - TemplateModule::nft_item_id(collection_id, 1) - .unwrap() - .variable_data, - variable_data - ); - }); -} + assert_eq!( + TemplateModule::nft_item_id(collection_id, 1) + .unwrap() + .variable_data, + variable_data + ); + }); + } -#[test] -fn set_variable_meta_data_on_nft_with_admin_flag_neg() { - new_test_ext().execute_with(|| { - default_limits(); + #[test] + fn set_variable_meta_data_on_nft_with_admin_flag_neg() { + new_test_ext().execute_with(|| { + default_limits(); - let collection_id = create_test_collection_for_owner(&CollectionMode::NFT, 2, 1); + let collection_id = create_test_collection_for_owner(&CollectionMode::NFT, 2, 1); - let origin1 = Origin::signed(1); - let origin2 = Origin::signed(2); + let origin1 = Origin::signed(1); + let origin2 = Origin::signed(2); - assert_ok!(TemplateModule::set_mint_permission( - origin2.clone(), - collection_id, - true - )); - assert_ok!(TemplateModule::add_to_white_list( - origin2.clone(), - collection_id, - account(1) - )); + assert_ok!(TemplateModule::set_mint_permission( + origin2.clone(), + collection_id, + true + )); + assert_ok!(TemplateModule::add_to_white_list( + origin2.clone(), + collection_id, + account(1) + )); - let data = default_nft_data(); - create_test_item(1, &data.into()); + let data = default_nft_data(); + create_test_item(1, &data.into()); - TemplateModule::set_meta_update_permission_flag( - origin2.clone(), - collection_id, - MetaUpdatePermission::Admin, - ); + TemplateModule::set_meta_update_permission_flag( + origin2.clone(), + collection_id, + MetaUpdatePermission::Admin, + ); - let variable_data = b"test set_variable_meta_data method.".to_vec(); - assert_noop!( - TemplateModule::set_variable_meta_data( - origin1, - collection_id, - 1, - variable_data.clone() - ), - Error::::NoPermission - ); - }); -} + let variable_data = b"test set_variable_meta_data method.".to_vec(); + assert_noop!( + TemplateModule::set_variable_meta_data( + origin1, + collection_id, + 1, + variable_data.clone() + ), + Error::::NoPermission + ); + }); + } -#[test] -fn set_variable_meta_flag_after_freeze() { - new_test_ext().execute_with(|| { - default_limits(); + #[test] + fn set_variable_meta_flag_after_freeze() { + new_test_ext().execute_with(|| { + default_limits(); - let collection_id = create_test_collection_for_owner(&CollectionMode::NFT, 2, 1); + let collection_id = create_test_collection_for_owner(&CollectionMode::NFT, 2, 1); - let origin2 = Origin::signed(2); + let origin2 = Origin::signed(2); - TemplateModule::set_meta_update_permission_flag( - origin2.clone(), - collection_id, - MetaUpdatePermission::None, - ); - assert_noop!( - TemplateModule::set_meta_update_permission_flag( - origin2.clone(), - collection_id, - MetaUpdatePermission::Admin - ), - Error::::MetadataFlagFrozen - ); - }); -} + TemplateModule::set_meta_update_permission_flag( + origin2.clone(), + collection_id, + MetaUpdatePermission::None, + ); + assert_noop!( + TemplateModule::set_meta_update_permission_flag( + origin2.clone(), + collection_id, + MetaUpdatePermission::Admin + ), + Error::::MetadataFlagFrozen + ); + }); + } -#[test] -fn set_variable_meta_data_on_nft_with_none_flag_neg() { - new_test_ext().execute_with(|| { - default_limits(); + #[test] + fn set_variable_meta_data_on_nft_with_none_flag_neg() { + new_test_ext().execute_with(|| { + default_limits(); - let collection_id = create_test_collection_for_owner(&CollectionMode::NFT, 1, 1); - let origin1 = Origin::signed(1); + let collection_id = create_test_collection_for_owner(&CollectionMode::NFT, 1, 1); + let origin1 = Origin::signed(1); - let data = default_nft_data(); - create_test_item(1, &data.into()); + let data = default_nft_data(); + create_test_item(1, &data.into()); - TemplateModule::set_meta_update_permission_flag( - origin1.clone(), - collection_id, - MetaUpdatePermission::None, - ); + TemplateModule::set_meta_update_permission_flag( + origin1.clone(), + collection_id, + MetaUpdatePermission::None, + ); - let variable_data = b"test set_variable_meta_data method.".to_vec(); - assert_noop!( - TemplateModule::set_variable_meta_data( - origin1.clone(), - collection_id, - 1, - variable_data.clone() - ), - Error::::MetadataUpdateDenied - ); + let variable_data = b"test set_variable_meta_data method.".to_vec(); + assert_noop!( + TemplateModule::set_variable_meta_data( + origin1.clone(), + collection_id, + 1, + variable_data.clone() + ), + Error::::MetadataUpdateDenied + ); + }); + } -#[test] -fn collection_transfer_flag_works_neg() { - new_test_ext().execute_with(|| { - let origin1 = Origin::signed(1); + #[test] + fn collection_transfer_flag_works_neg() { + new_test_ext().execute_with(|| { + let origin1 = Origin::signed(1); - let collection_id = create_test_collection(&CollectionMode::NFT, 1); - assert_ok!(TemplateModule::set_transfers_enabled_flag( - origin1, 1, false - )); + let collection_id = create_test_collection(&CollectionMode::NFT, 1); + assert_ok!(TemplateModule::set_transfers_enabled_flag( + origin1, 1, false + )); - let data = default_nft_data(); - create_test_item(collection_id, &data.into()); - assert_eq!(TemplateModule::balance_count(1, 1), 1); - assert_eq!(TemplateModule::address_tokens(1, 1), [1]); + let data = default_nft_data(); + create_test_item(collection_id, &data.into()); + assert_eq!(TemplateModule::balance_count(1, 1), 1); + assert_eq!(TemplateModule::address_tokens(1, 1), [1]); - let origin1 = Origin::signed(1); + let origin1 = Origin::signed(1); - // default scenario - assert_noop!( - TemplateModule::transfer(origin1, account(2), 1, 1, 1000), - Error::::TransferNotAllowed - ); - assert_eq!(TemplateModule::nft_item_id(1, 1).unwrap().owner, account(1)); - assert_eq!(TemplateModule::balance_count(1, 1), 1); - assert_eq!(TemplateModule::balance_count(1, 2), 0); + // default scenario + assert_noop!( + TemplateModule::transfer(origin1, account(2), 1, 1, 1000), + Error::::TransferNotAllowed + ); + assert_eq!(TemplateModule::nft_item_id(1, 1).unwrap().owner, account(1)); + assert_eq!(TemplateModule::balance_count(1, 1), 1); + assert_eq!(TemplateModule::balance_count(1, 2), 0); - assert_eq!(TemplateModule::address_tokens(1, 1), [1]); + assert_eq!(TemplateModule::address_tokens(1, 1), [1]); + }); + } }); } --- a/tests/src/addCollectionAdmin.test.ts +++ b/tests/src/addCollectionAdmin.test.ts @@ -4,7 +4,6 @@ // import { ApiPromise } from '@polkadot/api'; -import BN from 'bn.js'; import chai from 'chai'; import chaiAsPromised from 'chai-as-promised'; import privateKey from './substrate/privateKey'; --- a/tests/src/collision-tests/adminLimitsOff.test.ts +++ b/tests/src/collision-tests/adminLimitsOff.test.ts @@ -1,5 +1,4 @@ import { IKeyringPair } from '@polkadot/types/types'; -import BN from 'bn.js'; import chai from 'chai'; import chaiAsPromised from 'chai-as-promised'; import privateKey from '../substrate/privateKey'; --- a/tests/src/eth/nonFungible.test.ts +++ b/tests/src/eth/nonFungible.test.ts @@ -6,7 +6,6 @@ import privateKey from '../substrate/privateKey'; import { approveExpectSuccess, burnItemExpectSuccess, createCollectionExpectSuccess, createItemExpectSuccess, transferExpectSuccess, transferFromExpectSuccess, UNIQUE } from '../util/helpers'; import { collectionIdToAddress, createEthAccount, createEthAccountWithBalance, GAS_ARGS, itWeb3, normalizeEvents, recordEthFee, recordEvents, subToEth, transferBalanceToEth } from './util/helpers'; -import { evmToAddress } from '@polkadot/util-crypto'; import nonFungibleAbi from './nonFungibleAbi.json'; import { expect } from 'chai'; import waitNewBlocks from '../substrate/wait-new-blocks'; --- a/tests/src/util/helpers.ts +++ b/tests/src/util/helpers.ts @@ -1084,15 +1084,6 @@ await setMintPermissionExpectSuccess(sender, collectionId, true); } -export async function addCollectionAdminExpectSuccess(sender: IKeyringPair, collectionId: number, address: IKeyringPair) { - await usingApi(async (api) => { - const changeAdminTx = api.tx.nft.addCollectionAdmin(collectionId, normalizeAccountId(address.address)); - const events = await submitTransactionAsync(sender, changeAdminTx); - const result = getCreateCollectionResult(events); - expect(result.success).to.be.true; - }); -} - export async function setMintPermissionExpectFailure(sender: IKeyringPair, collectionId: number, enabled: boolean) { await usingApi(async (api) => { // Run the transaction -- gitstuff