From 46515fa1c836faba3e0ab449072f06b57d4af3be Mon Sep 17 00:00:00 2001 From: ut-akuznetsov <59873862+ut-akuznetsov@users.noreply.github.com> Date: Thu, 12 Jan 2023 11:49:32 +0000 Subject: [PATCH] Merge pull request #826 from UniqueNetwork/fix/deprecate-eth-methods Deprecate ethereum methods --- --- a/tests/src/eth/abi/fungibleDeprecated.json +++ b/tests/src/eth/abi/fungibleDeprecated.json @@ -88,14 +88,5 @@ "outputs": [], "stateMutability": "nonpayable", "type": "function" - }, - { - "inputs": [ - { "internalType": "address", "name": "newOwner", "type": "address" } - ], - "name": "changeCollectionOwner", - "outputs": [], - "stateMutability": "nonpayable", - "type": "function" } ] --- a/tests/src/eth/abi/nonFungible.json +++ b/tests/src/eth/abi/nonFungible.json @@ -51,12 +51,6 @@ }, { "anonymous": false, - "inputs": [], - "name": "MintingFinished", - "type": "event" - }, - { - "anonymous": false, "inputs": [ { "indexed": true, @@ -420,13 +414,6 @@ "name": "description", "outputs": [{ "internalType": "string", "name": "", "type": "string" }], "stateMutability": "view", - "type": "function" - }, - { - "inputs": [], - "name": "finishMinting", - "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }], - "stateMutability": "nonpayable", "type": "function" }, { @@ -513,13 +500,6 @@ "name": "mintWithTokenURI", "outputs": [{ "internalType": "uint256", "name": "", "type": "uint256" }], "stateMutability": "nonpayable", - "type": "function" - }, - { - "inputs": [], - "name": "mintingFinished", - "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }], - "stateMutability": "view", "type": "function" }, { --- a/tests/src/eth/abi/reFungible.json +++ b/tests/src/eth/abi/reFungible.json @@ -51,12 +51,6 @@ }, { "anonymous": false, - "inputs": [], - "name": "MintingFinished", - "type": "event" - }, - { - "anonymous": false, "inputs": [ { "indexed": true, @@ -402,13 +396,6 @@ "name": "description", "outputs": [{ "internalType": "string", "name": "", "type": "string" }], "stateMutability": "view", - "type": "function" - }, - { - "inputs": [], - "name": "finishMinting", - "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }], - "stateMutability": "nonpayable", "type": "function" }, { @@ -495,13 +482,6 @@ "name": "mintWithTokenURI", "outputs": [{ "internalType": "uint256", "name": "", "type": "uint256" }], "stateMutability": "nonpayable", - "type": "function" - }, - { - "inputs": [], - "name": "mintingFinished", - "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }], - "stateMutability": "view", "type": "function" }, { --- a/tests/src/eth/abi/reFungibleDeprecated.json +++ b/tests/src/eth/abi/reFungibleDeprecated.json @@ -82,6 +82,17 @@ }, { "inputs": [ + { "internalType": "uint256", "name": "tokenId", "type": "uint256" }, + { "internalType": "string", "name": "key", "type": "string" }, + { "internalType": "bytes", "name": "value", "type": "bytes" } + ], + "name": "setProperty", + "outputs": [], + "stateMutability": "nonpayable", + "type": "function" + }, + { + "inputs": [ { "internalType": "address", "name": "newOwner", "type": "address" } ], "name": "changeCollectionOwner", --- a/tests/src/eth/abi/reFungibleToken.json +++ b/tests/src/eth/abi/reFungibleToken.json @@ -98,16 +98,6 @@ }, { "inputs": [ - { "internalType": "address", "name": "from", "type": "address" }, - { "internalType": "uint256", "name": "amount", "type": "uint256" } - ], - "name": "burnFrom", - "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }], - "stateMutability": "nonpayable", - "type": "function" - }, - { - "inputs": [ { "components": [ { "internalType": "address", "name": "eth", "type": "address" }, --- /dev/null +++ b/tests/src/eth/abi/reFungibleTokenDeprecated.json @@ -0,0 +1,12 @@ +[ + { + "inputs": [ + { "internalType": "address", "name": "from", "type": "address" }, + { "internalType": "uint256", "name": "amount", "type": "uint256" } + ], + "name": "burnFrom", + "outputs": [{ "internalType": "bool", "name": "", "type": "bool" }], + "stateMutability": "nonpayable", + "type": "function" + } +] --- a/tests/src/eth/reFungible.test.ts +++ b/tests/src/eth/reFungible.test.ts @@ -74,7 +74,7 @@ const result = await contract.methods.mint(caller).send(); const tokenId = result.events.Transfer.returnValues.tokenId; - const tokenContract = await helper.ethNativeContract.rftTokenById(collectionId, tokenId, caller); + const tokenContract = await helper.ethNativeContract.rftTokenById(collectionId, tokenId, caller, true); await tokenContract.methods.repartition(2).send(); await tokenContract.methods.transfer(receiver, 1).send(); @@ -316,7 +316,7 @@ const address = helper.ethAddress.fromCollectionId(collection.collectionId); const contract = await helper.ethNativeContract.collection(address, 'rft'); - const rftToken = await helper.ethNativeContract.rftTokenById(token.collectionId, token.tokenId, owner); + const rftToken = await helper.ethNativeContract.rftTokenById(token.collectionId, token.tokenId, owner, true); { await rftToken.methods.approve(operator, 15n).send({from: owner}); --- a/tests/src/eth/reFungibleToken.test.ts +++ b/tests/src/eth/reFungibleToken.test.ts @@ -458,7 +458,7 @@ const result = await contract.methods.mint(caller).send(); const tokenId = result.events.Transfer.returnValues.tokenId; const tokenAddress = helper.ethAddress.fromTokenId(collectionId, tokenId); - const tokenContract = await helper.ethNativeContract.rftToken(tokenAddress, caller); + const tokenContract = await helper.ethNativeContract.rftToken(tokenAddress, caller, true); await tokenContract.methods.repartition(2).send(); await tokenContract.methods.transfer(receiver, 1).send(); --- a/tests/src/eth/util/playgrounds/unique.dev.ts +++ b/tests/src/eth/util/playgrounds/unique.dev.ts @@ -29,6 +29,7 @@ import refungibleAbi from '../../abi/reFungible.json'; import refungibleDeprecatedAbi from '../../abi/reFungibleDeprecated.json'; import refungibleTokenAbi from '../../abi/reFungibleToken.json'; +import refungibleTokenDeprecatedAbi from '../../abi/reFungibleTokenDeprecated.json'; import contractHelpersAbi from '../../abi/contractHelpers.json'; import {ICrossAccountId, TEthereumAccount} from '../../../util/playgrounds/types'; import {TCollectionMode} from '../../../util/playgrounds/types'; @@ -187,17 +188,18 @@ return this.collection(this.helper.ethAddress.fromCollectionId(collectionId), mode, caller, mergeDeprecated); } - async rftToken(address: string, caller?: string) { + async rftToken(address: string, caller?: string, mergeDeprecated = false) { const web3 = this.helper.getWeb3(); - return unlimitedMoneyHack(new web3.eth.Contract(refungibleTokenAbi as any, address, { + const abi = mergeDeprecated ? [...refungibleTokenAbi, ...refungibleTokenDeprecatedAbi] : refungibleTokenAbi; + return unlimitedMoneyHack(new web3.eth.Contract(abi as any, address, { gas: this.helper.eth.DEFAULT_GAS, gasPrice: await this.getGasPrice(), ...(caller ? {from: caller} : {}), })); } - rftTokenById(collectionId: number, tokenId: number, caller?: string) { - return this.rftToken(this.helper.ethAddress.fromTokenId(collectionId, tokenId), caller); + rftTokenById(collectionId: number, tokenId: number, caller?: string, mergeDeprecated = false) { + return this.rftToken(this.helper.ethAddress.fromTokenId(collectionId, tokenId), caller, mergeDeprecated); } } -- gitstuff