From 2f30e2f1b1715e5c9cf238660b0fee3f25888ab0 Mon Sep 17 00:00:00 2001 From: Trubnikov Sergey Date: Wed, 11 Jan 2023 06:44:26 +0000 Subject: [PATCH] misk: remove simple type aliases --- --- a/crates/evm-coder/src/events.rs +++ b/crates/evm-coder/src/events.rs @@ -61,7 +61,7 @@ } } -impl ToTopic for uint32 { +impl ToTopic for u32 { fn to_topic(&self) -> H256 { let mut out = [0u8; 32]; out[28..32].copy_from_slice(&self.to_be_bytes()); --- a/crates/evm-coder/src/lib.rs +++ b/crates/evm-coder/src/lib.rs @@ -132,11 +132,6 @@ use primitive_types::{U256, H160, H256}; pub type address = H160; - pub type uint8 = u8; - pub type uint16 = u16; - pub type uint32 = u32; - pub type uint64 = u64; - pub type uint128 = u128; pub type uint256 = U256; pub type bytes4 = [u8; 4]; pub type topic = H256; @@ -148,10 +143,6 @@ #[derive(Default, Debug, PartialEq, Eq, Clone)] pub struct bytes(pub Vec); - - /// Solidity doesn't have `void` type, however we have special implementation - /// for empty tuple return type - pub type void = (); //#region Special types /// Makes function payable --- a/pallets/common/src/erc.rs +++ b/pallets/common/src/erc.rs @@ -93,12 +93,7 @@ /// @param value Propery value. #[solidity(hide)] #[weight(>::set_collection_properties(1))] - fn set_collection_property( - &mut self, - caller: caller, - key: string, - value: bytes, - ) -> Result { + fn set_collection_property(&mut self, caller: caller, key: string, value: bytes) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let key = >::from(key) .try_into() @@ -117,7 +112,7 @@ &mut self, caller: caller, properties: Vec, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let properties = properties @@ -212,7 +207,7 @@ /// /// @param sponsor Address of the sponsor from whose account funds will be debited for operations with the contract. #[solidity(hide)] - fn set_collection_sponsor(&mut self, caller: caller, sponsor: address) -> Result { + fn set_collection_sponsor(&mut self, caller: caller, sponsor: address) -> Result<()> { self.consume_store_reads_and_writes(1, 1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -231,7 +226,7 @@ &mut self, caller: caller, sponsor: eth::CrossAddress, - ) -> Result { + ) -> Result<()> { self.consume_store_reads_and_writes(1, 1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -252,7 +247,7 @@ /// Collection sponsorship confirmation. /// /// @dev After setting the sponsor for the collection, it must be confirmed with this function. - fn confirm_collection_sponsorship(&mut self, caller: caller) -> Result { + fn confirm_collection_sponsorship(&mut self, caller: caller) -> Result<()> { self.consume_store_writes(1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -261,7 +256,7 @@ } /// Remove collection sponsor. - fn remove_collection_sponsor(&mut self, caller: caller) -> Result { + fn remove_collection_sponsor(&mut self, caller: caller) -> Result<()> { self.consume_store_reads_and_writes(1, 1)?; let caller = T::CrossAccountId::from_eth(caller); self.remove_sponsor(&caller).map_err(dispatch_to_evm::) @@ -343,11 +338,7 @@ /// @dev Throws error if limit not found. /// @param limit Some limit. #[solidity(rename_selector = "setCollectionLimit")] - fn set_collection_limit( - &mut self, - caller: caller, - limit: eth::CollectionLimit, - ) -> Result { + fn set_collection_limit(&mut self, caller: caller, limit: eth::CollectionLimit) -> Result<()> { self.consume_store_reads_and_writes(1, 1)?; if !limit.has_value() { @@ -369,7 +360,7 @@ &mut self, caller: caller, new_admin: eth::CrossAddress, - ) -> Result { + ) -> Result<()> { self.consume_store_reads_and_writes(2, 2)?; let caller = T::CrossAccountId::from_eth(caller); @@ -384,7 +375,7 @@ &mut self, caller: caller, admin: eth::CrossAddress, - ) -> Result { + ) -> Result<()> { self.consume_store_reads_and_writes(2, 2)?; let caller = T::CrossAccountId::from_eth(caller); @@ -396,7 +387,7 @@ /// Add collection admin. /// @param newAdmin Address of the added administrator. #[solidity(hide)] - fn add_collection_admin(&mut self, caller: caller, new_admin: address) -> Result { + fn add_collection_admin(&mut self, caller: caller, new_admin: address) -> Result<()> { self.consume_store_reads_and_writes(2, 2)?; let caller = T::CrossAccountId::from_eth(caller); @@ -409,7 +400,7 @@ /// /// @param admin Address of the removed administrator. #[solidity(hide)] - fn remove_collection_admin(&mut self, caller: caller, admin: address) -> Result { + fn remove_collection_admin(&mut self, caller: caller, admin: address) -> Result<()> { self.consume_store_reads_and_writes(2, 2)?; let caller = T::CrossAccountId::from_eth(caller); @@ -422,7 +413,7 @@ /// /// @param enable If "true" degenerates to nesting: 'Owner' else to nesting: 'Disabled' #[solidity(rename_selector = "setCollectionNesting")] - fn set_nesting_bool(&mut self, caller: caller, enable: bool) -> Result { + fn set_nesting_bool(&mut self, caller: caller, enable: bool) -> Result<()> { self.consume_store_reads_and_writes(1, 1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -446,7 +437,7 @@ caller: caller, enable: bool, collections: Vec
, - ) -> Result { + ) -> Result<()> { self.consume_store_reads_and_writes(1, 1)?; if collections.is_empty() { @@ -513,7 +504,7 @@ /// @param mode Access mode /// 0 for Normal /// 1 for AllowList - fn set_collection_access(&mut self, caller: caller, mode: uint8) -> Result { + fn set_collection_access(&mut self, caller: caller, mode: u8) -> Result<()> { self.consume_store_reads_and_writes(1, 1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -540,7 +531,7 @@ /// /// @param user Address of a trusted user. #[solidity(hide)] - fn add_to_collection_allow_list(&mut self, caller: caller, user: address) -> Result { + fn add_to_collection_allow_list(&mut self, caller: caller, user: address) -> Result<()> { self.consume_store_writes(1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -556,7 +547,7 @@ &mut self, caller: caller, user: eth::CrossAddress, - ) -> Result { + ) -> Result<()> { self.consume_store_writes(1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -569,7 +560,7 @@ /// /// @param user Address of a removed user. #[solidity(hide)] - fn remove_from_collection_allow_list(&mut self, caller: caller, user: address) -> Result { + fn remove_from_collection_allow_list(&mut self, caller: caller, user: address) -> Result<()> { self.consume_store_writes(1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -585,7 +576,7 @@ &mut self, caller: caller, user: eth::CrossAddress, - ) -> Result { + ) -> Result<()> { self.consume_store_writes(1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -597,7 +588,7 @@ /// Switch permission for minting. /// /// @param mode Enable if "true". - fn set_collection_mint_mode(&mut self, caller: caller, mode: bool) -> Result { + fn set_collection_mint_mode(&mut self, caller: caller, mode: bool) -> Result<()> { self.consume_store_reads_and_writes(1, 1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -654,7 +645,7 @@ /// @dev Owner can be changed only by current owner /// @param newOwner new owner account #[solidity(hide, rename_selector = "changeCollectionOwner")] - fn set_owner(&mut self, caller: caller, new_owner: address) -> Result { + fn set_owner(&mut self, caller: caller, new_owner: address) -> Result<()> { self.consume_store_writes(1)?; let caller = T::CrossAccountId::from_eth(caller); @@ -682,7 +673,7 @@ &mut self, caller: caller, new_owner: eth::CrossAddress, - ) -> Result { + ) -> Result<()> { self.consume_store_writes(1)?; let caller = T::CrossAccountId::from_eth(caller); --- a/pallets/evm-contract-helpers/src/eth.rs +++ b/pallets/evm-contract-helpers/src/eth.rs @@ -108,7 +108,7 @@ caller: caller, contract_address: address, sponsor: address, - ) -> Result { + ) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; @@ -125,7 +125,7 @@ /// Set contract as self sponsored. /// /// @param contractAddress Contract for which a self sponsoring is being enabled. - fn self_sponsored_enable(&mut self, caller: caller, contract_address: address) -> Result { + fn self_sponsored_enable(&mut self, caller: caller, contract_address: address) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; @@ -146,7 +146,7 @@ /// Remove sponsor. /// /// @param contractAddress Contract for which a sponsorship is being removed. - fn remove_sponsor(&mut self, caller: caller, contract_address: address) -> Result { + fn remove_sponsor(&mut self, caller: caller, contract_address: address) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; @@ -161,7 +161,7 @@ /// @dev Caller must be same that set via [`setSponsor`]. /// /// @param contractAddress Сontract for which need to confirm sponsorship. - fn confirm_sponsorship(&mut self, caller: caller, contract_address: address) -> Result { + fn confirm_sponsorship(&mut self, caller: caller, contract_address: address) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; @@ -210,7 +210,7 @@ caller: caller, contract_address: address, mode: SponsoringModeT, - ) -> Result { + ) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; @@ -223,7 +223,7 @@ /// Get current contract sponsoring rate limit /// @param contractAddress Contract to get sponsoring rate limit of /// @return uint32 Amount of blocks between two sponsored transactions - fn sponsoring_rate_limit(&self, contract_address: address) -> Result { + fn sponsoring_rate_limit(&self, contract_address: address) -> Result { self.recorder().consume_sload()?; Ok(>::get(contract_address) @@ -241,8 +241,8 @@ &mut self, caller: caller, contract_address: address, - rate_limit: uint32, - ) -> Result { + rate_limit: u32, + ) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; @@ -262,7 +262,7 @@ caller: caller, contract_address: address, fee_limit: uint256, - ) -> Result { + ) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; @@ -304,7 +304,7 @@ contract_address: address, user: address, is_allowed: bool, - ) -> Result { + ) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; @@ -332,7 +332,7 @@ caller: caller, contract_address: address, enabled: bool, - ) -> Result { + ) -> Result<()> { self.recorder().consume_sload()?; self.recorder().consume_sstore()?; --- a/pallets/fungible/src/erc.rs +++ b/pallets/fungible/src/erc.rs @@ -72,7 +72,7 @@ Ok(>::get(self.id).into()) } - fn decimals(&self) -> Result { + fn decimals(&self) -> Result { Ok(if let CollectionMode::Fungible(decimals) = &self.mode { *decimals } else { --- a/pallets/nonfungible/src/erc.rs +++ b/pallets/nonfungible/src/erc.rs @@ -423,7 +423,7 @@ _to: address, _token_id: uint256, _data: bytes, - ) -> Result { + ) -> Result<()> { // TODO: Not implemetable Err("not implemented".into()) } @@ -433,7 +433,7 @@ _from: address, _to: address, _token_id: uint256, - ) -> Result { + ) -> Result<()> { // TODO: Not implemetable Err("not implemented".into()) } @@ -454,7 +454,7 @@ from: address, to: address, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let from = T::CrossAccountId::from_eth(from); let to = T::CrossAccountId::from_eth(to); @@ -475,7 +475,7 @@ /// @param approved The new approved NFT controller /// @param tokenId The NFT to approve #[weight(>::approve())] - fn approve(&mut self, caller: caller, approved: address, token_id: uint256) -> Result { + fn approve(&mut self, caller: caller, approved: address, token_id: uint256) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let approved = T::CrossAccountId::from_eth(approved); let token = token_id.try_into()?; @@ -495,7 +495,7 @@ caller: caller, operator: address, approved: bool, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let operator = T::CrossAccountId::from_eth(operator); @@ -528,7 +528,7 @@ /// operator of the current owner. /// @param tokenId The NFT to approve #[weight(>::burn_item())] - fn burn(&mut self, caller: caller, token_id: uint256) -> Result { + fn burn(&mut self, caller: caller, token_id: uint256) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let token = token_id.try_into()?; @@ -773,7 +773,7 @@ caller: caller, approved: eth::CrossAddress, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let approved = approved.into_sub_cross_account::()?; let token = token_id.try_into()?; @@ -789,7 +789,7 @@ /// @param to The new owner /// @param tokenId The NFT to transfer #[weight(>::transfer())] - fn transfer(&mut self, caller: caller, to: address, token_id: uint256) -> Result { + fn transfer(&mut self, caller: caller, to: address, token_id: uint256) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let to = T::CrossAccountId::from_eth(to); let token = token_id.try_into()?; @@ -812,7 +812,7 @@ caller: caller, to: eth::CrossAddress, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let to = to.into_sub_cross_account::()?; let token = token_id.try_into()?; @@ -837,7 +837,7 @@ from: eth::CrossAddress, to: eth::CrossAddress, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let from = from.into_sub_cross_account::()?; let to = to.into_sub_cross_account::()?; @@ -858,7 +858,7 @@ /// @param tokenId The NFT to transfer #[solidity(hide)] #[weight(>::burn_from())] - fn burn_from(&mut self, caller: caller, from: address, token_id: uint256) -> Result { + fn burn_from(&mut self, caller: caller, from: address, token_id: uint256) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let from = T::CrossAccountId::from_eth(from); let token = token_id.try_into()?; @@ -883,7 +883,7 @@ caller: caller, from: eth::CrossAddress, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let from = from.into_sub_cross_account::()?; let token = token_id.try_into()?; --- a/pallets/refungible/src/erc.rs +++ b/pallets/refungible/src/erc.rs @@ -424,7 +424,7 @@ _to: address, _token_id: uint256, _data: bytes, - ) -> Result { + ) -> Result<()> { // TODO: Not implemetable Err("not implemented".into()) } @@ -436,7 +436,7 @@ _from: address, _to: address, _token_id: uint256, - ) -> Result { + ) -> Result<()> { // TODO: Not implemetable Err("not implemented".into()) } @@ -458,7 +458,7 @@ from: address, to: address, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let from = T::CrossAccountId::from_eth(from); let to = T::CrossAccountId::from_eth(to); @@ -477,7 +477,7 @@ } /// @dev Not implemented - fn approve(&mut self, _caller: caller, _approved: address, _token_id: uint256) -> Result { + fn approve(&mut self, _caller: caller, _approved: address, _token_id: uint256) -> Result<()> { Err("not implemented".into()) } @@ -491,7 +491,7 @@ caller: caller, operator: address, approved: bool, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let operator = T::CrossAccountId::from_eth(operator); @@ -556,7 +556,7 @@ /// operator of the current owner. /// @param tokenId The RFT to approve #[weight(>::burn_item_fully())] - fn burn(&mut self, caller: caller, token_id: uint256) -> Result { + fn burn(&mut self, caller: caller, token_id: uint256) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let token = token_id.try_into()?; @@ -805,7 +805,7 @@ /// @param to The new owner /// @param tokenId The RFT to transfer #[weight(>::transfer_creating_removing())] - fn transfer(&mut self, caller: caller, to: address, token_id: uint256) -> Result { + fn transfer(&mut self, caller: caller, to: address, token_id: uint256) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let to = T::CrossAccountId::from_eth(to); let token = token_id.try_into()?; @@ -833,7 +833,7 @@ caller: caller, to: eth::CrossAddress, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let to = to.into_sub_cross_account::()?; let token = token_id.try_into()?; @@ -862,7 +862,7 @@ from: eth::CrossAddress, to: eth::CrossAddress, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let from = from.into_sub_cross_account::()?; let to = to.into_sub_cross_account::()?; @@ -888,7 +888,7 @@ /// @param tokenId The RFT to transfer #[solidity(hide)] #[weight(>::burn_from())] - fn burn_from(&mut self, caller: caller, from: address, token_id: uint256) -> Result { + fn burn_from(&mut self, caller: caller, from: address, token_id: uint256) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let from = T::CrossAccountId::from_eth(from); let token = token_id.try_into()?; @@ -917,7 +917,7 @@ caller: caller, from: eth::CrossAddress, token_id: uint256, - ) -> Result { + ) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let from = from.into_sub_cross_account::()?; let token = token_id.try_into()?; --- a/pallets/refungible/src/erc_token.rs +++ b/pallets/refungible/src/erc_token.rs @@ -109,7 +109,7 @@ } /// @dev Not supported - fn decimals(&self) -> Result { + fn decimals(&self) -> Result { // Decimals aren't supported for refungible tokens Ok(0) } --- a/pallets/unique/src/eth/mod.rs +++ b/pallets/unique/src/eth/mod.rs @@ -231,7 +231,7 @@ caller: caller, value: value, name: string, - decimals: uint8, + decimals: u8, description: string, token_prefix: string, ) -> Result
{ @@ -334,7 +334,7 @@ } #[weight(>::destroy_collection())] - fn destroy_collection(&mut self, caller: caller, collection_address: address) -> Result { + fn destroy_collection(&mut self, caller: caller, collection_address: address) -> Result<()> { let caller = T::CrossAccountId::from_eth(caller); let collection_id = pallet_common::eth::map_eth_to_id(&collection_address) @@ -366,14 +366,14 @@ /// Returns address of a collection. /// @param collectionId - CollectionId of the collection /// @return eth mirror address of the collection - fn collection_address(&self, collection_id: uint32) -> Result
{ + fn collection_address(&self, collection_id: u32) -> Result
{ Ok(collection_id_to_address(collection_id.into())) } /// Returns collectionId of a collection. /// @param collectionAddress - Eth address of the collection /// @return collectionId of the collection - fn collection_id(&self, collection_address: address) -> Result { + fn collection_id(&self, collection_address: address) -> Result { map_eth_to_id(&collection_address) .map(|id| id.0) .ok_or(Error::Revert(format!( -- gitstuff