From 196e17086f5da7a3fca34f4a337fd45e1ef0b182 Mon Sep 17 00:00:00 2001 From: Fahrrader Date: Fri, 16 Dec 2022 16:31:12 +0000 Subject: [PATCH] style(repair): adjust test names + documentation --- --- a/pallets/common/src/lib.rs +++ b/pallets/common/src/lib.rs @@ -1223,7 +1223,7 @@ } /// Set a scoped collection property, where the scope is a special prefix - /// prohibiting a user to change the property. + /// prohibiting a user access to change the property directly. /// /// * `collection_id` - ID of the collection for which the property is being set. /// * `scope` - Property scope. @@ -1242,7 +1242,7 @@ } /// Set scoped collection properties, where the scope is a special prefix - /// prohibiting a user to change the properties. + /// prohibiting a user access to change the properties directly. /// /// * `collection_id` - ID of the collection for which the properties is being set. /// * `scope` - Property scope. --- a/pallets/unique/src/lib.rs +++ b/pallets/unique/src/lib.rs @@ -983,7 +983,7 @@ }) } - /// Repairs a collection's properties if the data was somehow corrupted. + /// Repairs a collection if the data was somehow corrupted. /// /// # Arguments /// @@ -997,7 +997,7 @@ >::repair_collection(collection_id) } - /// Repairs a token's properties if the data was somehow corrupted. + /// Repairs a token if the data was somehow corrupted. /// /// # Arguments /// --- a/tests/src/nesting/collectionProperties.seqtest.ts +++ b/tests/src/nesting/collectionProperties.seqtest.ts @@ -17,7 +17,7 @@ import {IKeyringPair} from '@polkadot/types/types'; import {itSub, Pallets, usingPlaygrounds, expect, requirePalletsOrSkip} from '../util'; -describe('Integration Test: Collection Properties', () => { +describe('Integration Test: Collection Properties with sudo', () => { let superuser: IKeyringPair; let alice: IKeyringPair; @@ -40,7 +40,7 @@ requirePalletsOrSkip(this, helper, testSuite.requiredPallets); }); }); - + itSub('Repairing an unbroken collection\'s properties preserves the consumed space', async({helper}) => { const properties = [ {key: 'sea-creatures', value: 'mermaids'}, --- a/tests/src/nesting/collectionProperties.test.ts +++ b/tests/src/nesting/collectionProperties.test.ts @@ -315,7 +315,7 @@ } }); - itSub('Modifying a collection property with different sizes correctly changes the consumed space', async({helper}) => { + itSub('Forbids to repair a collection if called with non-sudo', async({helper}) => { const collection = await helper[testSuite.mode].mintCollection(alice, {properties: [ {key: 'sea-creatures', value: 'mermaids'}, {key: 'goldenratio', value: '1.6180339887498948482045868343656381177203091798057628621354486227052604628189'}, --- a/tests/src/nesting/tokenProperties.seqtest.ts +++ b/tests/src/nesting/tokenProperties.seqtest.ts @@ -17,7 +17,7 @@ import {IKeyringPair} from '@polkadot/types/types'; import {itSub, Pallets, usingPlaygrounds, expect, requirePalletsOrSkip} from '../util'; -describe('Integration Test: Token Properties', () => { +describe('Integration Test: Token Properties with sudo', () => { let superuser: IKeyringPair; let alice: IKeyringPair; // collection owner -- gitstuff