--- a/js-packages/playgrounds/types.ts +++ b/js-packages/playgrounds/types.ts @@ -160,7 +160,7 @@ External = 1, /// Supports ERC721Metadata Erc721metadata = 64, - /// Tokens in foreign collections can be transferred, but not burnt + /// A collection of foreign assets Foreign = 128, } --- a/js-packages/tests/eth/api/CollectionHelpers.sol +++ b/js-packages/tests/eth/api/CollectionHelpers.sol @@ -132,7 +132,7 @@ type CollectionFlags is uint8; library CollectionFlagsLib { - /// Tokens in foreign collections can be transferred, but not burnt + /// A collection of foreign assets CollectionFlags constant foreignField = CollectionFlags.wrap(128); /// Supports ERC721Metadata CollectionFlags constant erc721metadataField = CollectionFlags.wrap(64); --- a/pallets/foreign-assets/src/lib.rs +++ b/pallets/foreign-assets/src/lib.rs @@ -259,7 +259,7 @@ } } - /// Converts a multiasset to a Unique Network's collection (either local or the foreign one). + /// Converts a multiasset to a Unique Network's collection (either local or a foreign one). /// /// The function will try to convert the multiasset's reserve location /// to the Unique Network's local collection. @@ -385,8 +385,6 @@ /// Withdraws an asset instance from the `from` account. /// /// Transfers the asset instance to the pallet's account. - /// - /// Won't withdraw the instance if it has children. fn withdraw_asset_instance( xcm_ext: &dyn XcmExtensions, collection_id: CollectionId, --- a/pallets/unique/src/eth/stubs/CollectionHelpers.sol +++ b/pallets/unique/src/eth/stubs/CollectionHelpers.sol @@ -199,7 +199,7 @@ type CollectionFlags is uint8; library CollectionFlagsLib { - /// Tokens in foreign collections can be transferred, but not burnt + /// A collection of foreign assets CollectionFlags constant foreignField = CollectionFlags.wrap(128); /// Supports ERC721Metadata CollectionFlags constant erc721metadataField = CollectionFlags.wrap(64); --- a/primitives/data-structs/src/lib.rs +++ b/primitives/data-structs/src/lib.rs @@ -378,7 +378,7 @@ #[derive(AbiCoderFlags, Bitfields, Clone, Copy, PartialEq, Eq, Debug, Default)] #[bondrewd(enforce_bytes = 1)] pub struct CollectionFlags { - /// Reserved flag + /// A collection of foreign assets #[bondrewd(bits = "0..1")] pub foreign: bool, /// Supports ERC721Metadata