From a5bf8061bf53451e54ec8ba81c185ad2711ea216 Mon Sep 17 00:00:00 2001 From: Yaroslav Bolyukin Date: Sat, 27 Aug 2022 23:39:32 +0000 Subject: [PATCH] fix: remove unnecessary reference --- --- a/crates/jrsonnet-evaluator/src/lib.rs +++ b/crates/jrsonnet-evaluator/src/lib.rs @@ -387,7 +387,7 @@ let resolved = self.resolve_from(from, path)?; self.import_resolved(resolved) } - pub fn import(&self, path: &impl AsRef) -> Result { + pub fn import(&self, path: impl AsRef) -> Result { let resolved = self.resolve(path)?; self.import_resolved(resolved) } @@ -620,7 +620,7 @@ // Only panics in case of [`ImportResolver`] contract violation #[allow(clippy::missing_panics_doc)] - pub fn resolve(&self, path: &impl AsRef) -> Result { + pub fn resolve(&self, path: impl AsRef) -> Result { self.import_resolver().resolve(path.as_ref()) } pub fn import_resolver(&self) -> Ref { --- a/crates/jrsonnet-parser/src/lib.rs +++ b/crates/jrsonnet-parser/src/lib.rs @@ -360,8 +360,6 @@ #[cfg(test)] pub mod tests { - use std::borrow::Cow; - use jrsonnet_interner::IStr; use BinaryOpType::*; @@ -373,7 +371,7 @@ parse( $s, &ParserSettings { - file_name: Source::new_virtual(Cow::Borrowed(""), IStr::empty()), + file_name: Source::new_virtual("".into(), IStr::empty()), }, ) .unwrap() @@ -385,7 +383,7 @@ LocExpr( std::rc::Rc::new($expr), ExprLocation( - Source::new_virtual(Cow::Borrowed(""), IStr::empty()), + Source::new_virtual("".into(), IStr::empty()), $from, $to, ), @@ -721,7 +719,7 @@ fn add_location_info_to_all_sub_expressions() { use Expr::*; - let file_name = Source::new_virtual(Cow::Borrowed(""), IStr::empty()); + let file_name = Source::new_virtual("".into(), IStr::empty()); let expr = parse( "{} { local x = 1, x: x } + {}", &ParserSettings { file_name }, -- gitstuff