From 6eba9c3aac872f54dfdaa0c9aa98cbf3f71e8a4b Mon Sep 17 00:00:00 2001 From: Yaroslav Bolyukin Date: Fri, 05 Aug 2022 17:58:42 +0000 Subject: [PATCH] fix(cli): gc stats were always printed --- --- a/crates/jrsonnet-cli/src/lib.rs +++ b/crates/jrsonnet-cli/src/lib.rs @@ -102,11 +102,13 @@ } impl GcOpts { pub fn stats_printer(&self) -> (Option, Option) { + // Constructed structs have side-effects in Drop impl + #[allow(clippy::unnecessary_lazy_evaluations)] ( - self.gc_print_stats.then_some(GcStatsPrinter { + self.gc_print_stats.then(|| GcStatsPrinter { collect_before_printing_stats: self.gc_collect_before_printing_stats, }), - (!self.gc_collect_on_exit).then_some(LeakSpace {}), + (!self.gc_collect_on_exit).then(|| LeakSpace {}), ) } } -- gitstuff