--- a/crates/jrsonnet-evaluator/src/gc.rs +++ b/crates/jrsonnet-evaluator/src/gc.rs @@ -18,7 +18,7 @@ } fn is_type_tracked() -> bool { - return true; + true } } @@ -101,6 +101,11 @@ &mut self.0 } } +impl Default for GcHashSet { + fn default() -> Self { + Self::new() + } +} #[derive(Clone)] pub struct GcHashMap(pub FxHashMap); @@ -139,3 +144,8 @@ &mut self.0 } } +impl Default for GcHashMap { + fn default() -> Self { + Self::new() + } +} --- a/crates/jrsonnet-evaluator/src/lib.rs +++ b/crates/jrsonnet-evaluator/src/lib.rs @@ -125,6 +125,7 @@ evaluated: Option, } +#[allow(clippy::type_complexity)] pub struct Breakpoint { loc: ExprLocation, collected: RefCell>)>>, @@ -254,7 +255,7 @@ ro_map.get(name).map(|value| value.source_code.clone()) } pub fn map_source_locations(&self, file: &Path, locs: &[usize]) -> Vec { - offset_to_location(&self.get_source(file).unwrap_or("".into()), locs) + offset_to_location(&self.get_source(file).unwrap_or_else(|| "".into()), locs) } pub fn map_from_source_location( &self, @@ -396,7 +397,7 @@ data.stack_generation += 1; result = data .breakpoints - .insert(data.stack_depth, data.stack_generation, &e, result); + .insert(data.stack_depth, data.stack_generation, e, result); } if let Err(mut err) = result { err.trace_mut().0.push(StackTraceElement { @@ -486,7 +487,7 @@ pub fn manifest(&self, val: Val) -> Result { self.run_in_state(|| { push_description_frame( - || format!("manifestification"), + || "manifestification".to_string(), || val.manifest(&self.manifest_format()), ) }) @@ -640,8 +641,8 @@ } pub fn cc_ptr_eq(a: &Cc, b: &Cc) -> bool { - let a = &a as &T; - let b = &b as &T; + let a = a as &T; + let b = b as &T; std::ptr::eq(a, b) } --- a/crates/jrsonnet-evaluator/src/obj.rs +++ b/crates/jrsonnet-evaluator/src/obj.rs @@ -123,7 +123,7 @@ } } for (name, member) in self.0.this_entries.iter() { - if handler(name, &member) { + if handler(name, member) { return true; } }